Browse Source

feat(discover): Add support for p90 in discover (#61990)

Riccardo Busetti 1 year ago
parent
commit
eac44dacd7

+ 10 - 0
src/sentry/search/events/datasets/discover.py

@@ -322,6 +322,16 @@ class DiscoverDatasetConfig(DatasetConfig):
                     default_result_type="duration",
                     redundant_grouping=True,
                 ),
+                SnQLFunction(
+                    "p90",
+                    optional_args=[
+                        with_default("transaction.duration", NumericColumn("column")),
+                    ],
+                    snql_aggregate=lambda args, alias: self._resolve_percentile(args, alias, 0.90),
+                    result_type_fn=self.reflective_result_type(),
+                    default_result_type="duration",
+                    redundant_grouping=True,
+                ),
                 SnQLFunction(
                     "p95",
                     optional_args=[

+ 2 - 2
tests/snuba/api/endpoints/test_organization_events_stats.py

@@ -1735,8 +1735,8 @@ class OrganizationEventsStatsTopNEvents(APITestCase, SnubaTestCase):
                     "end": iso_format(self.day_ago + timedelta(hours=2)),
                     "interval": "1h",
                     "yAxis": "count()",
-                    "orderby": ["-p99()"],
-                    "field": ["transaction", "avg(transaction.duration)", "p99()"],
+                    "orderby": ["-p90()"],
+                    "field": ["transaction", "avg(transaction.duration)", "p90()"],
                     "topEvents": 5,
                 },
                 format="json",