Browse Source

ref: revert logging in group_external_issues to fix typing error (#71757)

a potential crash occurred when accessing request.user in the logging
statement

reverts #24111

<!-- Describe your PR here. -->
anthony sottile 9 months ago
parent
commit
4aff5bad88
2 changed files with 0 additions and 13 deletions
  1. 0 1
      pyproject.toml
  2. 0 12
      src/sentry/api/endpoints/group_external_issues.py

+ 0 - 1
pyproject.toml

@@ -131,7 +131,6 @@ module = [
     "sentry.api.endpoints.codeowners",
     "sentry.api.endpoints.codeowners.index",
     "sentry.api.endpoints.event_attachments",
-    "sentry.api.endpoints.group_external_issues",
     "sentry.api.endpoints.group_integration_details",
     "sentry.api.endpoints.group_integrations",
     "sentry.api.endpoints.index",

+ 0 - 12
src/sentry/api/endpoints/group_external_issues.py

@@ -1,5 +1,3 @@
-import logging
-
 from rest_framework.request import Request
 from rest_framework.response import Response
 
@@ -9,8 +7,6 @@ from sentry.api.bases.group import GroupEndpoint
 from sentry.api.serializers import serialize
 from sentry.models.platformexternalissue import PlatformExternalIssue
 
-logger = logging.getLogger("sentry.api")
-
 
 @region_silo_endpoint
 class GroupExternalIssuesEndpoint(GroupEndpoint):
@@ -19,16 +15,8 @@ class GroupExternalIssuesEndpoint(GroupEndpoint):
     }
 
     def get(self, request: Request, group) -> Response:
-
         external_issues = PlatformExternalIssue.objects.filter(group_id=group.id)
 
-        logger.info(
-            "group_external_issue.get",
-            extra={
-                "user": request.user.username,
-                "is_sentry_app_user": request.user.is_sentry_app,
-            },
-        )
         return self.paginate(
             request=request,
             queryset=external_issues,