Browse Source

ref: fix typing of endpoints.organization_metrics (#71760)

<!-- Describe your PR here. -->
anthony sottile 9 months ago
parent
commit
de4aaaa085
2 changed files with 7 additions and 14 deletions
  1. 0 1
      pyproject.toml
  2. 7 13
      src/sentry/api/endpoints/organization_metrics.py

+ 0 - 1
pyproject.toml

@@ -161,7 +161,6 @@ module = [
     "sentry.api.endpoints.organization_member.index",
     "sentry.api.endpoints.organization_member.requests.invite.details",
     "sentry.api.endpoints.organization_member_unreleased_commits",
-    "sentry.api.endpoints.organization_metrics",
     "sentry.api.endpoints.organization_metrics_meta",
     "sentry.api.endpoints.organization_metrics_samples",
     "sentry.api.endpoints.organization_onboarding_continuation_email",

+ 7 - 13
src/sentry/api/endpoints/organization_metrics.py

@@ -1,5 +1,3 @@
-from collections.abc import Sequence
-
 from rest_framework.exceptions import ParseError
 from rest_framework.request import Request
 
@@ -20,7 +18,7 @@ def can_access_use_case_id(request: Request, use_case_id: UseCaseID) -> bool:
     )
 
 
-def get_default_use_case_ids(request: Request) -> Sequence[UseCaseID]:
+def get_default_use_case_ids(request: Request) -> list[str]:
     """
     Gets the default use case ids given a Request.
 
@@ -30,15 +28,11 @@ def get_default_use_case_ids(request: Request) -> Sequence[UseCaseID]:
     Returns:
         A list of use case ids that can be used for the API request.
     """
-    default_use_case_ids = []
-
-    for use_case_id in UseCaseID:
-        if not can_access_use_case_id(request, use_case_id):
-            continue
-
-        default_use_case_ids.append(use_case_id)
-
-    return default_use_case_ids
+    return [
+        use_case_id.value
+        for use_case_id in UseCaseID
+        if can_access_use_case_id(request, use_case_id)
+    ]
 
 
 def get_use_case_id(request: Request) -> UseCaseID:
@@ -61,7 +55,7 @@ def get_use_case_id(request: Request) -> UseCaseID:
         raise ParseError(detail="The supplied use case doesn't exist or it's private")
 
 
-def get_use_case_ids(request: Request) -> Sequence[UseCaseID]:
+def get_use_case_ids(request: Request) -> list[UseCaseID]:
     """
     Gets the use case ids from the Request. If at least one use case id is malformed or private the entire request
     will fail.