fix(ddm): add analytics (#59780)

static/app/utils/analytics/ddmAnalyticsEvents.tsx

@@ -1,23 +1,12 @@
 export type DDMEventParameters = {
-  'ddm.page-view': {
-    organization: string;
-  };
-  'ddm.scratchpad.remove': {
-    organization: string;
-  };
-  'ddm.scratchpad.save': {
-    organization: string;
-  };
-  'ddm.scratchpad.set-default': {
-    organization: string;
-  };
-  'ddm.widget.add': {
-    organization: string;
-  };
+  'ddm.page-view': {};
+  'ddm.scratchpad.remove': {};
+  'ddm.scratchpad.save': {};
+  'ddm.scratchpad.set-default': {};
+  'ddm.widget.add': {};
   'ddm.widget.sort': {
     by: string;
     order: string;
-    organization: string;
   };
 };
 

static/app/views/ddm/ddm.tsx

@@ -24,7 +24,7 @@ function DDM() {
 
   useEffect(() => {
     trackAnalytics('ddm.page-view', {
-      organization: organization.slug,
+      organization,
     });
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);

static/app/views/ddm/scratchpad.tsx

@@ -41,7 +41,7 @@ export function MetricScratchpad() {
       <AddWidgetPanel
         onClick={() => {
           trackAnalytics('ddm.widget.add', {
-            organization: organization.slug,
+            organization,
           });
 
           addWidget();

static/app/views/ddm/scratchpadSelector.tsx

@@ -186,7 +186,7 @@ export function ScratchpadSelector() {
                 onPointerDown={e => e.stopPropagation()}
                 onClick={() => {
                   trackAnalytics('ddm.scratchpad.set-default', {
-                    organization: organization.slug,
+                    organization,
                   });
 
                   if (isDefault(s)) {
@@ -210,7 +210,7 @@ export function ScratchpadSelector() {
                   openConfirmModal({
                     onConfirm: () => {
                       trackAnalytics('ddm.scratchpad.remove', {
-                        organization: organization.slug,
+                        organization,
                       });
 
                       return scratchpads.remove(s.id);
@@ -228,7 +228,7 @@ export function ScratchpadSelector() {
           </Fragment>
         ),
       })),
-    [scratchpads, isDefault, organization.slug]
+    [scratchpads, isDefault, organization]
   );
 
   return (
@@ -276,7 +276,7 @@ function SaveAsDropdown({
 
   const save = useCallback(() => {
     trackAnalytics('ddm.scratchpad.save', {
-      organization: organization.slug,
+      organization,
     });
 
     onSave(name);

static/app/views/ddm/summaryTable.tsx

@@ -36,7 +36,7 @@ export function SummaryTable({
   sort?: SortState;
 }) {
   const {selection} = usePageFilters();
-  const {slug} = useOrganization();
+  const organization = useOrganization();
 
   const hasActions = series.some(s => s.release || s.transaction);
 
@@ -48,7 +48,7 @@ export function SummaryTable({
   const changeSort = useCallback(
     (name: SortState['name']) => {
       trackAnalytics('ddm.widget.sort', {
-        organization: slug,
+        organization,
         by: name,
         order: sort.order,
       });
@@ -73,12 +73,14 @@ export function SummaryTable({
         });
       }
     },
-    [sort, onSortChange, slug]
+    [sort, onSortChange, organization]
   );
 
   const releaseTo = (release: string) => {
     return {
-      pathname: `/organizations/${slug}/releases/${encodeURIComponent(release)}/`,
+      pathname: `/organizations/${organization.slug}/releases/${encodeURIComponent(
+        release
+      )}/`,
       query: {
         pageStart: start,
         pageEnd: end,
@@ -91,7 +93,7 @@ export function SummaryTable({
 
   const transactionTo = (transaction: string) =>
     transactionSummaryRouteWithQuery({
-      orgSlug: slug,
+      orgSlug: organization.slug,
       transaction,
       projectID: selection.projects.map(p => String(p)),
       query: {