Browse Source

Throwing exception instead of silently drop error

Tobias Oitzinger 6 years ago
parent
commit
1c83da6afe
1 changed files with 6 additions and 4 deletions
  1. 6 4
      modules/database/classes/Kohana/Database/Query/Builder.php

+ 6 - 4
modules/database/classes/Kohana/Database/Query/Builder.php

@@ -208,9 +208,11 @@ abstract class Kohana_Database_Query_Builder extends Database_Query {
 	/**
 	 * Compiles an array of ORDER BY statements into an SQL partial.
 	 *
-	 * @param   object  $db       Database instance
-	 * @param   array   $columns  sorting columns
-	 * @return  string
+	 * @param  Database  $db       Database instance
+	 * @param  array     $columns  sorting columns
+	 *
+	 * @return string
+	 * @throws Database_Exception
 	 */
 	protected function _compile_order_by(Database $db, array $columns)
 	{
@@ -234,7 +236,7 @@ abstract class Kohana_Database_Query_Builder extends Database_Query {
 			{
 				// Make sure direction is either ASC or DESC to prevent injections
 				if ( ! in_array($direction, ['ASC', 'DESC'])) {
-					$direction = 'ASC';
+					throw new Database_Exception('Invalid sorting direction: ' . $direction);
 				}
 
 				// Make the direction uppercase