Browse Source

Add check to order_by clause

Tobias Oitzinger 6 years ago
parent
commit
decd10c6d0
1 changed files with 5 additions and 0 deletions
  1. 5 0
      modules/database/classes/Kohana/Database/Query/Builder.php

+ 5 - 0
modules/database/classes/Kohana/Database/Query/Builder.php

@@ -232,6 +232,11 @@ abstract class Kohana_Database_Query_Builder extends Database_Query {
 
 			if ($direction)
 			{
+				// Make sure direction is either ASC or DESC to prevent injections
+				if ( ! in_array($direction, ['ASC', 'DESC'])) {
+					$direction = 'ASC';
+				}
+
 				// Make the direction uppercase
 				$direction = ' '.strtoupper($direction);
 			}