123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348 |
- # Copyright (C) 2012-2024 Zammad Foundation, https://zammad-foundation.org/
- require 'rails_helper'
- require 'models/form_updater/concerns/checks_core_workflow_examples'
- require 'models/form_updater/concerns/has_security_options_examples'
- require 'models/form_updater/concerns/applies_ticket_shared_draft_examples'
- require 'models/form_updater/concerns/stores_taskbar_state_examples'
- require 'models/form_updater/concerns/applies_taskbar_state_examples'
- RSpec.describe(FormUpdater::Updater::Ticket::Edit) do
- subject(:resolved_result) do
- described_class.new(
- context: context,
- relation_fields: relation_fields,
- meta: meta,
- data: data,
- id: id,
- )
- end
- let(:group) { create(:group) }
- let(:user) { create(:agent, groups: [group]) }
- let(:context) { { current_user: user } }
- let(:meta) { { initial: true, form_id: SecureRandom.uuid } }
- let(:data) { {} }
- let(:id) { nil }
- let(:relation_fields) do
- [
- {
- name: 'group_id',
- relation: 'group',
- },
- {
- name: 'state_id',
- relation: 'TicketState',
- },
- {
- name: 'priority_id',
- relation: 'TicketPriority',
- },
- ]
- end
- let(:expected_result) do
- {
- 'group_id' => {
- options: [ { value: group.id, label: group.name } ],
- },
- 'state_id' => {
- options: Ticket::State.by_category(:viewable_agent_edit).reorder(name: :asc).map { |state| { value: state.id, label: state.name } },
- },
- 'priority_id' => {
- options: Ticket::Priority.where(active: true).reorder(id: :asc).map { |priority| { value: priority.id, label: priority.name } },
- },
- }
- end
- context 'when resolving' do
- it 'returns all resolved relation fields with correct value + label' do
- expect(resolved_result.resolve[:fields]).to include(
- 'group_id' => include(expected_result['group_id']),
- 'state_id' => include(expected_result['state_id']),
- 'priority_id' => include(expected_result['priority_id']),
- )
- end
- context 'when body is used' do
- before do
- create(:core_workflow, object: 'Ticket',
- perform: {
- body: {
- operator: 'set_readonly',
- set_readonly: true
- },
- })
- end
- it 'body (and also attachments) should be disabled' do
- expect(resolved_result.resolve[:fields]).to include(
- 'body' => include({
- disabled: true,
- }),
- 'attachments' => include({
- disabled: true,
- }),
- )
- end
- end
- context 'when ticket has object attribute value with a historical value', db_strategy: :reset do
- let(:field_name) { SecureRandom.uuid }
- let(:screens) do
- {
- create_middle: {
- '-all-' => {
- shown: true,
- required: false,
- },
- },
- create: {
- '-all-' => {
- shown: true,
- required: false,
- },
- },
- edit: {
- '-all-' => {
- shown: true,
- required: false,
- },
- },
- }
- end
- let(:object_attribute_field_type) { :object_manager_attribute_select }
- let(:object_attribute) do
- create(object_attribute_field_type, object_name: 'Ticket', name: field_name, display: field_name, screens: screens)
- end
- let(:ticket_object_attribute_value) { 'key_3' }
- let(:id) do
- Gql::ZammadSchema.id_from_object(create(:ticket, group: group, object_attribute.name => ticket_object_attribute_value))
- end
- before do
- object_attribute
- ObjectManager::Attribute.migration_execute
- object_attribute.reload
- end
- shared_examples 'resolve fields' do
- it 'checks that "rejectNonExistentValues" is false' do
- # Trigger first object authorization check.
- resolved_result.authorized?
- result = resolved_result.resolve[:fields]
- expect(result[field_name]).to include(expected_result)
- end
- end
- context 'when object attribute is a select field' do
- before do
- object_attribute.update!(data_option: object_attribute[:data_option].merge({ options: { key_1: 'value_1', key_2: 'value_2' } }))
- ObjectManager::Attribute.migration_execute
- end
- let(:expected_result) do
- {
- options: [
- {
- value: 'key_1',
- label: 'value_1',
- },
- {
- value: 'key_2',
- label: 'value_2',
- },
- ],
- clearable: true,
- rejectNonExistentValues: false
- }
- end
- include_examples 'resolve fields'
- end
- context 'when object attribute is a tree select field' do
- let(:object_attribute_field_type) { :object_manager_attribute_tree_select }
- let(:ticket_object_attribute_value) { 'Incident::Softwareproblem::MS Office' }
- let(:expected_result) do
- {
- options: [
- {
- label: 'Incident',
- value: 'Incident',
- disabled: false,
- children: [
- {
- label: 'Hardware',
- value: 'Incident::Hardware',
- disabled: false,
- children: [
- {
- label: 'Monitor',
- value: 'Incident::Hardware::Monitor',
- disabled: false,
- },
- {
- label: 'Mouse',
- value: 'Incident::Hardware::Mouse',
- disabled: false,
- },
- ]
- },
- ]
- },
- {
- label: 'Change request',
- value: 'Change request',
- disabled: false,
- }
- ],
- clearable: true,
- rejectNonExistentValues: false
- }
- end
- before do
- object_attribute.update!(data_option: object_attribute[:data_option].merge({ options: [
- {
- 'name' => 'Incident',
- 'value' => 'Incident',
- 'children' => [
- {
- 'name' => 'Hardware',
- 'value' => 'Incident::Hardware',
- 'children' => [
- {
- 'name' => 'Monitor',
- 'value' => 'Incident::Hardware::Monitor'
- },
- {
- 'name' => 'Mouse',
- 'value' => 'Incident::Hardware::Mouse'
- },
- ]
- },
- ]
- },
- {
- 'name' => 'Change request',
- 'value' => 'Change request'
- }
- ] }))
- ObjectManager::Attribute.migration_execute
- end
- include_examples 'resolve fields'
- end
- end
- context 'when time accounting should be triggered' do
- let(:id) do
- Gql::ZammadSchema.id_from_object(create(:ticket, group: group))
- end
- before do
- Setting.set('time_accounting', true)
- end
- it 'checks that time_accounting flag is not present' do
- # Trigger first object authorization check.
- resolved_result.authorized?
- # Time accounting check was moved into a separate validator, the flag should be absent.
- flags = resolved_result.resolve[:flags]
- expect(flags).not_to have_key(:time_accounting)
- end
- end
- context 'when auto save should be applied' do
- let(:taskbar_key) { 'TicketZoom-1234' }
- let(:taskbar) { create(:taskbar, key: taskbar_key, callback: 'Ticket', user_id: user.id, state: taskbar_state) }
- let(:taskbar_state) { { 'title' => 'test', 'owner_id' => 1 } }
- let(:field_name) { 'title' }
- let(:field_result) { { value: 'test' } }
- let(:additional_data) { { 'taskbarId' => Gql::ZammadSchema.id_from_object(taskbar), 'applyTaskbarState' => true } }
- let(:meta) { { additional_data: } }
- before do
- # Trigger first object authorization check.
- resolved_result.authorized?
- end
- it 'owner_id should be nil for system user' do
- fields = resolved_result.resolve[:fields]
- expect(fields['owner_id'][:value]).to be_nil
- end
- context 'when new article exists' do
- let(:taskbar_state) { { 'title' => 'test', 'article' => { 'articleType' => 'email' } } }
- it 'checks that newArticlePresent flag is present' do
- flags = resolved_result.resolve[:flags]
- expect(flags[:newArticlePresent]).to be_truthy
- end
- end
- end
- context 'when data should be stored' do
- let(:taskbar_key) { 'TicketZoom-1234' }
- let(:taskbar) { create(:taskbar, key: taskbar_key, callback: 'Ticket', user_id: user.id) }
- let(:additional_data) { { 'taskbarId' => Gql::ZammadSchema.id_from_object(taskbar) } }
- let(:meta) { { additional_data: } }
- let(:id) do
- Gql::ZammadSchema.id_from_object(create(:ticket, group: group, state_id: 1))
- end
- shared_examples 'stores the form value of the field' do
- it 'checks that data was stored correctly' do
- # Trigger first object authorization check.
- resolved_result.authorized?
- resolved_result.resolve
- state = taskbar.reload.state
- expect(state).to include(result)
- end
- end
- context 'when new article is saved' do
- let(:result) { { 'ticket' => include({ 'title' => 'test' }), 'article' => { 'type' => 'email' } } }
- let(:data) { { 'title' => 'test', 'article' => { 'articleType' => 'email' } } }
- include_examples 'stores the form value of the field'
- end
- context 'when data should be skipped' do
- let(:data) { { 'title' => 'test', 'state_id' => 1 } }
- let(:result) { { 'ticket' => { 'title' => 'test' } } }
- include_examples 'stores the form value of the field'
- end
- end
- end
- include_examples 'FormUpdater::ChecksCoreWorkflow', object_name: 'Ticket'
- include_examples 'FormUpdater::HasSecurityOptions', type: 'edit'
- include_examples 'FormUpdater::AppliesTicketSharedDraft', draft_type: 'detail-view'
- context 'when data should be stored and applied' do
- let(:id) do
- Gql::ZammadSchema.id_from_object(create(:ticket, group: group))
- end
- before do
- # Trigger creation of the ticket and handover the id.
- id
- # Trigger first object authorization check.
- resolved_result.authorized?
- end
- include_examples 'FormUpdater::StoresTaskbarState', taskbar_key: 'TicketZoom-1234', taskbar_callback: 'Ticket', store_state_collect_group_key: 'ticket', store_state_group_keys: ['article'] # gitleaks:allow
- include_examples 'FormUpdater::AppliesTaskbarState', taskbar_key: 'TicketZoom-1234', taskbar_callback: 'Ticket', apply_state_group_keys: %w[ticket article] # gitleaks:allow
- end
- end
|