# Copyright (C) 2012-2024 Zammad Foundation, https://zammad-foundation.org/ require 'rails_helper' RSpec.describe 'Manage > Users', type: :system do describe 'switching to an alternative user', authenticated_as: :authenticate, authentication_type: :form do let(:original_user) { create(:admin) } let(:alternative_one_user) { create(:admin) } let(:alternative_two_user) { create(:admin) } let(:alternative_three_user) { create(:customer) } def authenticate alternative_one_user alternative_two_user alternative_three_user original_user end it 'starts as original user' do expect(current_user).to eq original_user end it 'switches to alternative user' do switch_to(alternative_one_user) expect(current_user).to eq alternative_one_user end it 'switches to another alternative user' do switch_to(alternative_one_user) switch_to(alternative_two_user) expect(current_user).to eq alternative_two_user end it 'switches back to original user' do switch_to(alternative_one_user) switch_to(alternative_two_user) click '.switchBackToUser-close' expect(current_user).to eq original_user end it 'switches to customer user while maintenance mode is active' do Setting.set('maintenance_mode', true) switch_to(alternative_three_user) expect(current_user).to eq alternative_three_user end def switch_to(user) visit 'manage/users' within(:active_content) do row = find("tr[data-id=\"#{user.id}\"]") row.find('.js-action').click row.find('.js-switchTo').click end expect(page).to have_text("Zammad looks like this for \"#{user.firstname} #{user.lastname}\"") end end # Fixes GitHub Issue #3050 - Newly created users are only shown in the admin interface after reload describe 'adding a new user', authenticated_as: -> { user } do let(:user) { create(:admin) } it 'newly added user is visible in the user list' do visit '#manage/users' within(:active_content) do find('[data-type=new]').click find('[name=firstname]').fill_in with: 'NewTestUserFirstName' find('[name=lastname]').fill_in with: 'User' find('span.label-text', text: 'Customer').first(:xpath, './/..').click click '.js-submit' expect(page).to have_css('table td', text: 'NewTestUserFirstName') end end describe 'select an Organization' do before do create(:organization, name: 'Example Inc.', active: true) create(:organization, name: 'Inactive Inc.', active: false) end it 'check for inactive Organizations in Organization selection' do visit '#manage/users' within(:active_content) do find('[data-type=new]').click find('[name=organization_id] ~ .searchableSelect-main').fill_in with: '**' expect(page).to have_css('ul.js-optionsList > li.js-option', minimum: 2) expect(page).to have_css('ul.js-optionsList > li.js-option .is-inactive', count: 1) end end end describe 'with email with umlauts' do it 'is valid' do visit '#manage/users' within(:active_content) do find('[data-type=new]').click find('[name=firstname]').fill_in with: 'NewTestUserFirstName' find('[name=lastname]').fill_in with: 'User' find('[name=email]').fill_in with: 'üser@äcme.corp' find('span.label-text', text: 'Customer').first(:xpath, './/..').click click '.js-submit' expect(page).to have_css('table td', text: 'üser@äcme.corp') end end end end describe 'show/unlock a user', authenticated_as: :authenticate do let(:user) { create(:admin) } let(:locked_user) { create(:user, login_failed: 6) } def authenticate locked_user user end it 'check marked locked user and execute unlock action' do visit '#manage/users' within(:active_content) do row = find("tr[data-id=\"#{locked_user.id}\"]") expect(row).to have_css('.icon-lock') row.find('.js-action').click row.find('li.unlock').click expect(row).to have_no_css('.icon-lock') end end end context 'updating a user' do let(:user) { create(:admin, firstname: 'Dummy') } let(:row) { find "table tbody tr[data-id='#{user.id}']" } let(:group) { Group.first } let(:group2) { Group.second } before do user visit '#manage/users' within(:active_content) do row.click end end it 'handles permission checkboxes correctly' do in_modal do scroll_into_view '[data-attribute-name="group_ids"]' within '.js-groupListNewItemRow' do click '.js-input' click 'li', text: group.name click 'input[value="full"]', visible: :all expect(find('input[value="full"]', visible: :all)).to be_checked click 'input[value="read"]', visible: :all expect(find('input[value="full"]', visible: :all)).not_to be_checked expect(find('input[value="read"]', visible: :all)).to be_checked click 'input[value="full"]', visible: :all expect(find('input[value="full"]', visible: :all)).to be_checked expect(find('input[value="read"]', visible: :all)).not_to be_checked end end end it 'adds group permissions correctly' do in_modal do scroll_into_view '[data-attribute-name="group_ids"]' expect(page).to have_no_css '[data-attribute-name="group_ids"] tbody tr[data-id]' within '.js-groupListNewItemRow' do click '.js-input' click 'li', text: group.name click 'input[value="full"]', visible: :all click '.js-add' end expect(page).to have_css "table.settings-list tbody tr[data-id='#{group.id}']" within '.js-groupListNewItemRow' do click '.js-input' click 'li', text: group2.name click 'input[value="read"]', visible: :all end click_on 'Submit' end # only the first group is added # because add button is not clicked for the 2nd group expect(user.reload.user_groups).to contain_exactly( have_attributes(group: group, access: 'full') ) end context 'when user already has a group configured', authenticated_as: :authenticate do def authenticate user.groups << group user.groups << group2 true end it 'toggles groups on (un)checking agent role' do in_modal do scroll_into_view '.user_permission' expect(page).to have_css('[data-attribute-name="group_ids"]') click 'span', text: 'Agent' expect(page).to have_no_css('[data-attribute-name="group_ids"]') click 'span', text: 'Agent' expect(page).to have_css('[data-attribute-name="group_ids"]') end end it 'removes group correctly' do in_modal do scroll_into_view '[data-attribute-name="group_ids"]' within "[data-attribute-name='group_ids'] tbody tr[data-id='#{group.id}']" do click '.js-remove' end click_on 'Submit' end expect(user.reload.user_groups).to contain_exactly( have_attributes(group: group2, access: 'full') ) end end it 'allows to update a user with no email/first/last/phone if login is present' do in_modal do fill_in 'firstname', with: '' fill_in 'lastname', with: '' fill_in 'Email', with: '' fill_in 'Phone', with: '' click_on 'Submit' end within :active_content do expect(page).to have_no_text(user.firstname) end end context 'when user has auto login' do let(:user) { create(:admin, login: "auto-#{SecureRandom.uuid}") } it 'does not allow to update a user with no email/first/last/phone' do in_modal do fill_in 'firstname', with: '' fill_in 'lastname', with: '' fill_in 'Email', with: '' fill_in 'Phone', with: '' click_on 'Submit' expect(page).to have_text('At least one identifier') end end end context 'when user has email with umlauts' do let(:user) { create(:admin, login: 'üser@äcme.corp', email: 'üser@äcme.corp') } it 'does allow to update' do in_modal do fill_in 'firstname', with: 'Üser' click_on 'Submit' end expect(page).to have_no_text('Invalid email') end end end describe 'check user edit permissions', authenticated_as: -> { user } do shared_examples 'user permission' do |allow| it(allow ? 'allows editing' : 'forbids editing') do visit "#user/profile/#{record.id}" find('.js-action .icon-arrow-down').click selector = '.js-action [data-type="edit"]' expect(page).to(allow ? have_css(selector) : have_no_css(selector)) end end context 'when admin tries to change admin' do let(:user) { create(:admin) } let(:record) { create(:admin) } include_examples 'user permission', true end context 'when admin tries to change agent' do let(:user) { create(:admin) } let(:record) { create(:agent) } include_examples 'user permission', true end context 'when admin tries to change customer' do let(:user) { create(:admin) } let(:record) { create(:customer) } include_examples 'user permission', true end context 'when agent tries to change admin' do let(:user) { create(:agent) } let(:record) { create(:admin) } include_examples 'user permission', false end context 'when agent tries to change agent' do let(:user) { create(:agent) } let(:record) { create(:agent) } include_examples 'user permission', false end context 'when agent tries to change customer' do let(:user) { create(:agent) } let(:record) { create(:customer) } include_examples 'user permission', true end context 'when agent tries to change customer who is also admin' do let(:user) { create(:agent) } let(:record) { create(:customer, role_ids: Role.signup_role_ids.push(Role.find_by(name: 'Admin').id)) } include_examples 'user permission', false end context 'when agent tries to change customer who is also agent' do let(:user) { create(:agent) } let(:record) { create(:customer, role_ids: Role.signup_role_ids.push(Role.find_by(name: 'Agent').id)) } include_examples 'user permission', false end end describe 'UI is not updated right after importing users csv file #3919' do before do visit '#manage/users' ensure_websocket User.csv_import( string: Rails.root.join('spec/fixtures/files/csv_import/user/simple.csv').read, parse_params: { col_sep: ';', }, try: false, delete: false, ) end it 'does update the user list after import of new users' do expect(page).to have_text('firstname-simple-import1') end end describe 'Missing secondary organizations in user profile after refreshing with many secondary organizations. #4331' do let(:organizations) { create_list(:organization, 20) } let(:customer) { create(:customer, organization: organizations[0], organizations: organizations[1..]) } before do customer visit '#manage/users' click "tr[data-id='#{customer.id}']" end it 'does show all secondary organizations on edit' do tokens = page.all('div[data-attribute-name="organization_ids"] .token') expect(tokens.count).to eq(19) end end describe 'Two-Factor Authentication', authenticated_as: :authenticate do let(:admin) { create(:admin) } let(:agent) { create(:agent) } let(:two_factor_pref) { create(:user_two_factor_preference, :authenticator_app, user: agent) } let(:enabled) { true } def authenticate Setting.set('two_factor_authentication_method_authenticator_app', true) Setting.set('two_factor_authentication_enforce_role_ids', []) two_factor_pref agent.reload Setting.set('two_factor_authentication_method_authenticator_app', enabled) admin end def open_configure_two_factor row = find("tr[data-id=\"#{agent.id}\"]") row.find('.js-action').click row.find('.js-manageTwoFactor span').click end def expect_no_two_factor row = find("tr[data-id=\"#{agent.id}\"]") row.find('.js-action').click expect(row).to have_no_css('.js-manageTwoFactor') end before do visit '#manage/users' end it 'does remove the two-factor method' do open_configure_two_factor select 'Authenticator App', from: 'method' click_on 'Remove method' wait.until { !User::TwoFactorPreference.exists?(id: two_factor_pref.id) } expect_no_two_factor end it 'does remove all two-factor methods' do open_configure_two_factor click_on 'Remove all methods' click_on 'Yes' wait.until { !User::TwoFactorPreference.exists?(id: two_factor_pref.id) } expect_no_two_factor end describe 'when Two-Factor is disabled' do let(:enabled) { false } it 'does remove all two-factor methods' do open_configure_two_factor click_on 'Remove all methods' click_on 'Yes' wait.until { !User::TwoFactorPreference.exists?(id: two_factor_pref.id) } expect_no_two_factor end end end end