Browse Source

Fixes #4694 - Tab to delete knowledge base is empty

Mantas 1 year ago
parent
commit
d445b2d653

+ 2 - 5
app/assets/javascripts/app/controllers/knowledge_base/base_form.coffee

@@ -2,8 +2,9 @@ class App.KnowledgeBaseForm extends App.Controller
   events:
     'submit form': 'submit'
     'hidden.bs.tab': 'didHide'
-
   additionalButtons: []
+  className: 'page-content'
+  split: false
 
   didHide: ->
     @formControllers?.forEach (elem) -> elem.hideAlert()
@@ -12,10 +13,6 @@ class App.KnowledgeBaseForm extends App.Controller
     super
     @render()
 
-  className: 'page-content'
-
-  split: false
-
   buildFormController: (screen) ->
     isVertical = @split && _.values(App.Model.attributesGet(screen, App.KnowledgeBase.configure_attributes))[0].horizontal
 

+ 0 - 0
app/assets/javascripts/app/views/knowledge_base/vertical_form.coffee → app/assets/javascripts/app/controllers/knowledge_base/vertical_form.coffee


+ 21 - 0
spec/system/admin/knowledge_base/delete_spec.rb

@@ -0,0 +1,21 @@
+# Copyright (C) 2012-2023 Zammad Foundation, https://zammad-foundation.org/
+
+require 'rails_helper'
+
+RSpec.describe 'Admin Panel > Knowledge Base > Delete', type: :system do
+  include_context 'basic Knowledge Base'
+
+  before do
+    knowledge_base
+    visit '/#manage/knowledge_base'
+    find('a', text: 'Delete').click
+  end
+
+  it 'deletes the knowledge base' do
+    find('input[name="title"]').fill_in with: knowledge_base.translations.first.title
+
+    click_on 'Delete Knowledge Base'
+
+    expect(KnowledgeBase.count).to be_zero
+  end
+end