Browse Source

Add response body to result of client errors because there might be information provided by the server.

Thorsten Eckel 6 years ago
parent
commit
c3105bb804
2 changed files with 7 additions and 6 deletions
  1. 1 0
      lib/user_agent.rb
  2. 6 6
      test/integration/user_agent_test.rb

+ 1 - 0
lib/user_agent.rb

@@ -401,6 +401,7 @@ returns
         error: "Client Error: #{response.inspect}!",
         success: false,
         code: response.code,
+        body: response.body
       )
     when Net::HTTPInternalServerError
       return Result.new(

+ 6 - 6
test/integration/user_agent_test.rb

@@ -157,7 +157,7 @@ class UserAgentTest < ActiveSupport::TestCase
     assert(result)
     assert_equal(false, result.success?)
     assert_equal('401', result.code)
-    assert_equal(NilClass, result.body.class)
+    assert_equal("HTTP Basic: Access denied.\n", result.body)
 
     # post / 200
     result = UserAgent.post(
@@ -195,7 +195,7 @@ class UserAgentTest < ActiveSupport::TestCase
     assert(result)
     assert_equal(false, result.success?)
     assert_equal('401', result.code)
-    assert_equal(NilClass, result.body.class)
+    assert_equal("HTTP Basic: Access denied.\n", result.body)
 
     # put / 200
     result = UserAgent.put(
@@ -233,7 +233,7 @@ class UserAgentTest < ActiveSupport::TestCase
     assert(result)
     assert_equal(false, result.success?)
     assert_equal('401', result.code)
-    assert_equal(NilClass, result.body.class)
+    assert_equal("HTTP Basic: Access denied.\n", result.body)
 
     # delete / 200
     result = UserAgent.delete(
@@ -264,7 +264,7 @@ class UserAgentTest < ActiveSupport::TestCase
     assert(result)
     assert_equal(false, result.success?)
     assert_equal('401', result.code)
-    assert_equal(NilClass, result.body.class)
+    assert_equal("HTTP Basic: Access denied.\n", result.body)
   end
 
   # check
@@ -315,7 +315,7 @@ class UserAgentTest < ActiveSupport::TestCase
     assert(result)
     assert_equal(false, result.success?)
     assert_equal('401', result.code)
-    assert_equal(NilClass, result.body.class)
+    assert_equal("HTTP Basic: Access denied.\n", result.body)
   end
 
   # check
@@ -479,7 +479,7 @@ class UserAgentTest < ActiveSupport::TestCase
       assert(result.body =~ /"remote_ip":"#{ENV['ZAMMAD_PROXY_REMOTE_IP_CHECK']}"/)
     end
 
-    # get / 401
+    # get / 404
     result = UserAgent.get(
       "#{host}/test/not_existing",
       {