Browse Source

Fixes #4478 - Inline translation not working in overview-administration.

Rolf Schmidt 1 year ago
parent
commit
ae09b8a2dc

+ 1 - 1
app/assets/javascripts/app/controllers/_application_controller/table.coffee

@@ -463,7 +463,7 @@ class App.ControllerTable extends App.Controller
               callback(click..., e)
       )
 
-    if @dndCallback
+    if @dndCallback && !App.Config.get('translation_inline')
       dndOptions =
         tolerance:            'pointer'
         distance:             15

+ 14 - 0
spec/system/system/translations_spec.rb

@@ -131,4 +131,18 @@ RSpec.describe 'System > Translations', type: :system do
     end
   end
 
+  context 'Inline translation not working in overview-administration#4478' do
+    before do
+      visit '#manage/overviews'
+    end
+
+    it 'does change an overview translation' do
+      page.send_keys [*hot_keys, 't']
+      page.first('.table-overview table tbody tr td span.translation').click
+      page.send_keys ['overview-issue-4478']
+      find('#global-search').click
+      page.send_keys [*hot_keys, 't']
+      wait.until { Translation.where("target LIKE '%overview-issue-4478%'").count == 1 }
+    end
+  end
 end