Browse Source

Refactoring: In idiomatic Ruby loops are exited early by `return`-ing instead of `break`-ing.

Mantas 4 years ago
parent
commit
ab43ff94c8
1 changed files with 6 additions and 6 deletions
  1. 6 6
      spec/support/capybara/custom_extensions.rb

+ 6 - 6
spec/support/capybara/custom_extensions.rb

@@ -17,18 +17,18 @@ class Capybara::Node::Element
   #
   # @return [Capybara::Node::Element] the element/node
   def in_fixed_position(checks: 100)
+    previous = native.location
 
-    previous = nil
-    (checks + 1).times do |check|
-      raise "Element still moving after #{checks} checks" if check == checks
+    (checks + 1).times do
+      sleep 0.2
 
       current = native.location
-      sleep 0.2
-      break if previous == current
+
+      return self if previous == current
 
       previous = current
     end
 
-    self
+    raise "Element still moving after #{checks} checks"
   end
 end