Browse Source

Fixes #5396 - Checklist item can't be edited when checklist created empty.

Mantas Masalskis 4 months ago
parent
commit
8030396c2d

+ 3 - 3
app/assets/javascripts/app/controllers/ticket_zoom/sidebar_checklist/item_edit.coffee

@@ -62,20 +62,20 @@ class App.SidebarChecklistItemEdit extends App.Controller
     item = @object()
     item.text = newValue
 
-    @parentVC.setDisabled(e.target)
+    @parentVC.setDisabled(row)
 
     item.save(
       done: =>
         @releaseController()
         @parentVC.updateDisplayValue(item)
-        @parentVC.setEnabled(e.target)
+        @parentVC.setEnabled(row)
       fail: (settings, details) =>
         @notify(
           type: 'error'
           msg:  App.i18n.translateContent(details.error)
         )
         @releaseController()
-        @parentVC.setEnabled(e.target)
+        @parentVC.setEnabled(row)
         @parentVC.renderTable()
     )
 

+ 6 - 2
app/assets/javascripts/app/controllers/ticket_zoom/sidebar_checklist/show.coffee

@@ -195,6 +195,10 @@ class App.SidebarChecklistShow extends App.Controller
     @isRenamingChecklist = new App.SidebarChecklistRename(el: elem, parentVC: @, originalValue: @checklistTitle())
 
   onEntryTextClicked: (e) =>
+    @table
+      .find('.js-table-action-menu:visible')
+      .dropdown('toggle')
+
     return if $(e.target).closest('td').find('.js-input').length
 
     # skip on link openings
@@ -368,8 +372,8 @@ class App.SidebarChecklistShow extends App.Controller
       App.Utils.linkify(object.text)
     else if @readonly
       '-'
-
-    return if text == row.data('text-value')
+    else
+      ''
 
     row.data('text-value', text)