Browse Source

Maintenance: Bump rubocop-rspec from 2.9.0 to 2.10.0

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.9.0...v2.10.0)
Martin Gruner 2 years ago
parent
commit
78a0f6370a

+ 3 - 3
Gemfile.lock

@@ -377,7 +377,7 @@ GEM
       iniparse (~> 1.4)
       rexml (~> 3.2)
     parallel (1.22.1)
-    parser (3.1.1.0)
+    parser (3.1.2.0)
       ast (~> 2.4.1)
     pg (1.2.3)
     power_assert (2.0.1)
@@ -484,7 +484,7 @@ GEM
       rubocop-ast (>= 1.16.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.16.0)
+    rubocop-ast (1.17.0)
       parser (>= 3.1.1.0)
     rubocop-faker (1.1.0)
       faker (>= 2.12.0)
@@ -500,7 +500,7 @@ GEM
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
-    rubocop-rspec (2.9.0)
+    rubocop-rspec (2.10.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     ruby-saml (1.14.0)

+ 1 - 1
spec/controllers/integration/exchange_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe 'Exchange integration endpoint', type: :request do
   describe 'autodiscovery' do
     # see https://github.com/zammad/zammad/issues/2065
     context 'when Autodiscover gem raises Errno::EADDRNOTAVAIL (#2065)' do
-      let(:client) { instance_double('Autodiscover::Client') }
+      let(:client) { instance_double(Autodiscover::Client) }
 
       it 'rescues and responds with an empty hash (to proceed to manual configuration)' do
         allow(Autodiscover::Client).to receive(:new).with(any_args).and_return(client)

+ 1 - 1
spec/lib/report/ticket_generic_time_spec.rb

@@ -327,7 +327,7 @@ RSpec.describe Report::TicketGenericTime, searchindex: true do
 
     # Regression test for issue #2246 - Records in Reporting not updated when single ActiveRecord can not be found
     it 'correctly handles missing tickets', searchindex: false do
-      class_double('SearchIndexBackend', selectors: { ticket_ids: [-1] }, drop_index: nil, drop_pipeline: nil).as_stubbed_const
+      class_double(SearchIndexBackend, selectors: { ticket_ids: [-1] }, drop_index: nil, drop_pipeline: nil).as_stubbed_const
 
       expect do
         described_class.items(

+ 1 - 1
spec/lib/search_index_backend_spec.rb

@@ -904,7 +904,7 @@ RSpec.describe SearchIndexBackend do
         allow(described_class).to receive(:convert_es_date_range).and_return(mock_range)
       end
 
-      let(:mock_range) { instance_double('Range', overlaps?: true) }
+      let(:mock_range) { instance_double(Range, overlaps?: true) }
 
       it 'checks overlap once for 2 ranges' do
         described_class.verify_date_range 'url', build_payload(range_1, range_2)

+ 1 - 1
spec/lib/sequencer/unit/import/common/model/save_spec.rb

@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe Sequencer::Unit::Import::Common::Model::Save, sequencer: :unit do
-  let(:user) { instance_double('User') }
+  let(:user) { instance_double(User) }
 
   before { allow(user).to receive(:save!) }
 

+ 1 - 1
spec/requests/channels_twitter_spec.rb

@@ -114,7 +114,7 @@ RSpec.describe 'Twitter channel API endpoints', type: :request do
         allow(twitter_sync).to receive(:process_webhook)
       end
 
-      let(:twitter_sync) { instance_double('TwitterSync') }
+      let(:twitter_sync) { instance_double(TwitterSync) }
 
       it 'delegates to TwitterSync#process_webhook' do
         post '/api/v1/channels_twitter_webhook', params: params, headers: headers, as: :json

+ 1 - 1
spec/requests/integration/exchange_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe 'Exchange integration endpoint', type: :request do
   describe 'autodiscovery' do
     # see https://github.com/zammad/zammad/issues/2065
     context 'when Autodiscover gem raises Errno::EADDRNOTAVAIL (#2065)' do
-      let(:client) { instance_double('Autodiscover::Client') }
+      let(:client) { instance_double(Autodiscover::Client) }
 
       it 'rescues and responds with an empty hash (to proceed to manual configuration)' do
         allow(Autodiscover::Client).to receive(:new).with(any_args).and_return(client)

+ 2 - 2
spec/requests/integration/github_spec.rb

@@ -60,7 +60,7 @@ RSpec.describe 'GitHub', type: :request, required_envs: %w[GITHUB_ENDPOINT GITHU
       expect(json_response['error']).to eq('Not authorized (user)!')
 
       authenticated_as(admin)
-      instance = instance_double('GitHub')
+      instance = instance_double(GitHub)
       expect(GitHub).to receive(:new).with(endpoint, token).and_return instance
       expect(instance).to receive(:verify!).and_return(true)
 
@@ -76,7 +76,7 @@ RSpec.describe 'GitHub', type: :request, required_envs: %w[GITHUB_ENDPOINT GITHU
         links: [ ENV['GITHUB_ISSUE_LINK'] ],
       }
       authenticated_as(agent)
-      instance = instance_double('GitHub')
+      instance = instance_double(GitHub)
       expect(GitHub).to receive(:new).and_return instance
       expect(instance).to receive(:issues_by_urls).and_return([issue_data])
 

+ 2 - 2
spec/requests/integration/gitlab_spec.rb

@@ -65,7 +65,7 @@ RSpec.describe 'GitLab', type: :request, required_envs: %w[GITLAB_ENDPOINT GITLA
       expect(json_response['error']).to eq('Not authorized (user)!')
 
       authenticated_as(admin)
-      instance = instance_double('GitLab')
+      instance = instance_double(GitLab)
       expect(GitLab).to receive(:new).with(endpoint, token).and_return instance
       expect(instance).to receive(:verify!).and_return(true)
 
@@ -81,7 +81,7 @@ RSpec.describe 'GitLab', type: :request, required_envs: %w[GITLAB_ENDPOINT GITLA
         links: [ ENV['GITLAB_ISSUE_LINK'] ],
       }
       authenticated_as(agent)
-      instance = instance_double('GitLab')
+      instance = instance_double(GitLab)
       expect(GitLab).to receive(:new).and_return instance
       expect(instance).to receive(:issues_by_urls).and_return([issue_data])