Просмотр исходного кода

Applied RuboCop Style/BlockDelimiters to improve readability.

Thorsten Eckel 7 лет назад
Родитель
Сommit
757f0ac9bd

+ 0 - 8
.rubocop.yml

@@ -99,14 +99,6 @@ Style/EmptyLinesAroundModuleBody:
   Description: "Keeps track of empty lines around module bodies."
   Description: "Keeps track of empty lines around module bodies."
   Enabled: false
   Enabled: false
 
 
-Style/BlockDelimiters:
-  Description: >-
-                Avoid using {...} for multi-line blocks (multiline chaining is
-                always ugly).
-                Prefer {...} over do...end for single-line blocks.
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks'
-  Enabled: false
-
 Style/MultilineBlockChain:
 Style/MultilineBlockChain:
   Description: 'Avoid multi-line chains of blocks.'
   Description: 'Avoid multi-line chains of blocks.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks'

+ 2 - 2
app/controllers/application_controller/handles_errors.rb

@@ -44,12 +44,12 @@ module ApplicationController::HandlesErrors
 
 
     respond_to do |format|
     respond_to do |format|
       format.json { render json: humanize_error(e.message), status: status }
       format.json { render json: humanize_error(e.message), status: status }
-      format.any {
+      format.any do
         @exception = e
         @exception = e
         @traceback = !Rails.env.production?
         @traceback = !Rails.env.production?
         file = File.open(Rails.root.join('public', "#{status_code}.html"), 'r')
         file = File.open(Rails.root.join('public', "#{status_code}.html"), 'r')
         render inline: file.read, status: status
         render inline: file.read, status: status
-      }
+      end
     end
     end
   end
   end
 
 

+ 4 - 4
app/controllers/application_controller/logs_http_access.rb

@@ -22,14 +22,14 @@ module ApplicationController::LogsHttpAccess
       content_encoding: request.headers['Content-Encoding'],
       content_encoding: request.headers['Content-Encoding'],
       source: request.headers['User-Agent'] || request.headers['Server'],
       source: request.headers['User-Agent'] || request.headers['Server'],
     }
     }
-    request.headers.each { |key, value|
+    request.headers.each do |key, value|
       next if key[0, 5] != 'HTTP_'
       next if key[0, 5] != 'HTTP_'
       request_data[:content] += if key == 'HTTP_COOKIE'
       request_data[:content] += if key == 'HTTP_COOKIE'
                                   "#{key}: xxxxx\n"
                                   "#{key}: xxxxx\n"
                                 else
                                 else
                                   "#{key}: #{value}\n"
                                   "#{key}: #{value}\n"
                                 end
                                 end
-    }
+    end
     body = request.body.read
     body = request.body.read
     if body
     if body
       request_data[:content] += "\n" + body
       request_data[:content] += "\n" + body
@@ -44,9 +44,9 @@ module ApplicationController::LogsHttpAccess
       content_encoding: nil,
       content_encoding: nil,
       source: nil,
       source: nil,
     }
     }
-    response.headers.each { |key, value|
+    response.headers.each do |key, value|
       response_data[:content] += "#{key}: #{value}\n"
       response_data[:content] += "#{key}: #{value}\n"
-    }
+    end
     body = response.body
     body = response.body
     if body
     if body
       response_data[:content] += "\n" + body
       response_data[:content] += "\n" + body

+ 6 - 6
app/controllers/application_controller/renders_models.rb

@@ -111,9 +111,9 @@ module ApplicationController::RendersModels
 
 
     if params[:expand]
     if params[:expand]
       list = []
       list = []
-      generic_objects.each { |generic_object|
+      generic_objects.each do |generic_object|
         list.push generic_object.attributes_with_association_names
         list.push generic_object.attributes_with_association_names
-      }
+      end
       render json: list, status: :ok
       render json: list, status: :ok
       return
       return
     end
     end
@@ -121,10 +121,10 @@ module ApplicationController::RendersModels
     if params[:full]
     if params[:full]
       assets = {}
       assets = {}
       item_ids = []
       item_ids = []
-      generic_objects.each { |item|
+      generic_objects.each do |item|
         item_ids.push item.id
         item_ids.push item.id
         assets = item.assets(assets)
         assets = item.assets(assets)
-      }
+      end
       render json: {
       render json: {
         record_ids: item_ids,
         record_ids: item_ids,
         assets: assets,
         assets: assets,
@@ -133,9 +133,9 @@ module ApplicationController::RendersModels
     end
     end
 
 
     generic_objects_with_associations = []
     generic_objects_with_associations = []
-    generic_objects.each { |item|
+    generic_objects.each do |item|
       generic_objects_with_associations.push item.attributes_with_association_ids
       generic_objects_with_associations.push item.attributes_with_association_ids
-    }
+    end
     model_index_render_result(generic_objects_with_associations)
     model_index_render_result(generic_objects_with_associations)
   end
   end
 
 

+ 2 - 2
app/controllers/applications_controller.rb

@@ -8,7 +8,7 @@ class ApplicationsController < ApplicationController
     if params[:full]
     if params[:full]
       assets = {}
       assets = {}
       item_ids = []
       item_ids = []
-      all.each { |item|
+      all.each do |item|
         item_ids.push item.id
         item_ids.push item.id
         if !assets[:Application]
         if !assets[:Application]
           assets[:Application] = {}
           assets[:Application] = {}
@@ -16,7 +16,7 @@ class ApplicationsController < ApplicationController
         application = item.attributes
         application = item.attributes
         application[:clients] = Doorkeeper::AccessToken.where(application_id: item.id).count
         application[:clients] = Doorkeeper::AccessToken.where(application_id: item.id).count
         assets[:Application][item.id] = application
         assets[:Application][item.id] = application
-      }
+      end
       render json: {
       render json: {
         record_ids: item_ids,
         record_ids: item_ids,
         assets: assets,
         assets: assets,

+ 2 - 2
app/controllers/calendars_controller.rb

@@ -8,10 +8,10 @@ class CalendarsController < ApplicationController
     # calendars
     # calendars
     assets = {}
     assets = {}
     calendar_ids = []
     calendar_ids = []
-    Calendar.all.order(:name, :created_at).each { |calendar|
+    Calendar.all.order(:name, :created_at).each do |calendar|
       calendar_ids.push calendar.id
       calendar_ids.push calendar.id
       assets = calendar.assets(assets)
       assets = calendar.assets(assets)
-    }
+    end
 
 
     ical_feeds = Calendar.ical_feeds
     ical_feeds = Calendar.ical_feeds
     timezones = Calendar.timezones
     timezones = Calendar.timezones

+ 10 - 10
app/controllers/channels_email_controller.rb

@@ -11,12 +11,12 @@ class ChannelsEmailController < ApplicationController
     not_used_email_address_ids = []
     not_used_email_address_ids = []
     accounts_fixed = []
     accounts_fixed = []
     assets = {}
     assets = {}
-    Channel.order(:id).each { |channel|
+    Channel.order(:id).each do |channel|
       if system_online_service && channel.preferences && channel.preferences['online_service_disable']
       if system_online_service && channel.preferences && channel.preferences['online_service_disable']
         email_addresses = EmailAddress.where(channel_id: channel.id)
         email_addresses = EmailAddress.where(channel_id: channel.id)
-        email_addresses.each { |email_address|
+        email_addresses.each do |email_address|
           accounts_fixed.push email_address
           accounts_fixed.push email_address
-        }
+        end
         next
         next
       end
       end
       if channel.area == 'Email::Account'
       if channel.area == 'Email::Account'
@@ -26,15 +26,15 @@ class ChannelsEmailController < ApplicationController
         notification_channel_ids.push channel.id
         notification_channel_ids.push channel.id
         assets = channel.assets(assets)
         assets = channel.assets(assets)
       end
       end
-    }
-    EmailAddress.all.each { |email_address|
+    end
+    EmailAddress.all.each do |email_address|
       next if system_online_service && email_address.preferences && email_address.preferences['online_service_disable']
       next if system_online_service && email_address.preferences && email_address.preferences['online_service_disable']
       email_address_ids.push email_address.id
       email_address_ids.push email_address.id
       assets = email_address.assets(assets)
       assets = email_address.assets(assets)
       if !email_address.channel_id || !email_address.active || !Channel.find_by(id: email_address.channel_id)
       if !email_address.channel_id || !email_address.active || !Channel.find_by(id: email_address.channel_id)
         not_used_email_address_ids.push email_address.id
         not_used_email_address_ids.push email_address.id
       end
       end
-    }
+    end
     render json: {
     render json: {
       accounts_fixed: accounts_fixed,
       accounts_fixed: accounts_fixed,
       assets: assets,
       assets: assets,
@@ -224,7 +224,7 @@ class ChannelsEmailController < ApplicationController
     # save settings
     # save settings
     if result[:result] == 'ok'
     if result[:result] == 'ok'
 
 
-      Channel.where(area: 'Email::Notification').each { |channel|
+      Channel.where(area: 'Email::Notification').each do |channel|
         active = false
         active = false
         if adapter =~ /^#{channel.options[:outbound][:adapter]}$/i
         if adapter =~ /^#{channel.options[:outbound][:adapter]}$/i
           active = true
           active = true
@@ -239,7 +239,7 @@ class ChannelsEmailController < ApplicationController
         end
         end
         channel.active = active
         channel.active = active
         channel.save
         channel.save
-      }
+      end
     end
     end
     render json: result
     render json: result
   end
   end
@@ -247,7 +247,7 @@ class ChannelsEmailController < ApplicationController
   private
   private
 
 
   def account_duplicate?(result, channel_id = nil)
   def account_duplicate?(result, channel_id = nil)
-    Channel.where(area: 'Email::Account').each { |channel|
+    Channel.where(area: 'Email::Account').each do |channel|
       next if !channel.options
       next if !channel.options
       next if !channel.options[:inbound]
       next if !channel.options[:inbound]
       next if !channel.options[:inbound][:adapter]
       next if !channel.options[:inbound][:adapter]
@@ -261,7 +261,7 @@ class ChannelsEmailController < ApplicationController
         message: 'Account already exists!',
         message: 'Account already exists!',
       }
       }
       return true
       return true
-    }
+    end
     false
     false
   end
   end
 
 

+ 4 - 4
app/controllers/channels_facebook_controller.rb

@@ -5,14 +5,14 @@ class ChannelsFacebookController < ApplicationController
 
 
   def index
   def index
     assets = {}
     assets = {}
-    ExternalCredential.where(name: 'facebook').each { |external_credential|
+    ExternalCredential.where(name: 'facebook').each do |external_credential|
       assets = external_credential.assets(assets)
       assets = external_credential.assets(assets)
-    }
+    end
     channel_ids = []
     channel_ids = []
-    Channel.where(area: 'Facebook::Account').order(:id).each { |channel|
+    Channel.where(area: 'Facebook::Account').order(:id).each do |channel|
       assets = channel.assets(assets)
       assets = channel.assets(assets)
       channel_ids.push channel.id
       channel_ids.push channel.id
-    }
+    end
     render json: {
     render json: {
       assets: assets,
       assets: assets,
       channel_ids: channel_ids,
       channel_ids: channel_ids,

+ 2 - 2
app/controllers/channels_telegram_controller.rb

@@ -7,10 +7,10 @@ class ChannelsTelegramController < ApplicationController
   def index
   def index
     assets = {}
     assets = {}
     channel_ids = []
     channel_ids = []
-    Channel.where(area: 'Telegram::Bot').order(:id).each { |channel|
+    Channel.where(area: 'Telegram::Bot').order(:id).each do |channel|
       assets = channel.assets(assets)
       assets = channel.assets(assets)
       channel_ids.push channel.id
       channel_ids.push channel.id
-    }
+    end
     render json: {
     render json: {
       assets: assets,
       assets: assets,
       channel_ids: channel_ids
       channel_ids: channel_ids

+ 4 - 4
app/controllers/channels_twitter_controller.rb

@@ -5,14 +5,14 @@ class ChannelsTwitterController < ApplicationController
 
 
   def index
   def index
     assets = {}
     assets = {}
-    ExternalCredential.where(name: 'twitter').each { |external_credential|
+    ExternalCredential.where(name: 'twitter').each do |external_credential|
       assets = external_credential.assets(assets)
       assets = external_credential.assets(assets)
-    }
+    end
     channel_ids = []
     channel_ids = []
-    Channel.where(area: 'Twitter::Account').order(:id).each { |channel|
+    Channel.where(area: 'Twitter::Account').order(:id).each do |channel|
       assets = channel.assets(assets)
       assets = channel.assets(assets)
       channel_ids.push channel.id
       channel_ids.push channel.id
-    }
+    end
     render json: {
     render json: {
       assets: assets,
       assets: assets,
       channel_ids: channel_ids,
       channel_ids: channel_ids,

Некоторые файлы не были показаны из-за большого количества измененных файлов