Browse Source

Corrected test/ folder with rubocop cop 'Style/StringLiterals'.

Thorsten Eckel 10 years ago
parent
commit
58ea373054

+ 3 - 3
test/browser/agent_ticket_actions_level5_test.rb

@@ -9,9 +9,9 @@ class AgentTicketActionLevel5Test < TestCase
     signature_body1 = "--\nsig body 1 äöüß " + suffix
     signature_name2 = 'sig name 2 äöüß ' + suffix
     signature_body2 = "--\nsig body 2 äöüß " + suffix
-    group_name1     = "group name 1 " + suffix
-    group_name2     = "group name 2 " + suffix
-    group_name3     = "group name 3 " + suffix
+    group_name1     = 'group name 1 ' + suffix
+    group_name2     = 'group name 2 ' + suffix
+    group_name3     = 'group name 3 ' + suffix
 
     @browser = browser_instance
     login(

+ 31 - 31
test/browser_test_helper.rb

@@ -1,4 +1,4 @@
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 require File.expand_path('../../config/environment', __FILE__)
 require 'selenium-webdriver'
 
@@ -94,7 +94,7 @@ class TestCase < Test::Unit::TestCase
 
     element = instance.find_elements( { :css => '#login input[name="username"]' } )[0]
     if !element
-      raise "No login box found"
+      raise 'No login box found'
     end
     element.clear
     element.send_keys( params[:username] )
@@ -111,9 +111,9 @@ class TestCase < Test::Unit::TestCase
     sleep 4
     login = instance.find_elements( { :css => '.user-menu .user a' } )[0].attribute('title')
     if login != params[:username]
-      raise "login failed"
+      raise 'login failed'
     end
-    assert( true, "login ok" )
+    assert( true, 'login ok' )
     login
   end
 
@@ -137,11 +137,11 @@ class TestCase < Test::Unit::TestCase
       sleep 1
       login = instance.find_elements( { :css => '#login' } )[0]
       if login
-        assert( true, "logout ok" )
+        assert( true, 'logout ok' )
         return
       end
     }
-    raise "no login box found, seems logout was not successfully!"
+    raise 'no login box found, seems logout was not successfully!'
   end
 
 =begin
@@ -632,10 +632,10 @@ puts "tv #{params.inspect}"
         is_modified = instance.find_elements( { :css => '.tasks .active .icon.modified' } )[0]
         puts "m #{data[:modified].inspect}"
         if exists
-          puts " ecists"
+          puts ' ecists'
         end
         if is_modified
-          puts " is_modified"
+          puts ' is_modified'
         end
         if data[:modified] == true
           if is_modified
@@ -804,7 +804,7 @@ wait untill text in selector disabppears
     (1..loops).each { |loop|
       element = instance.find_elements( { :css => params[:css] } )[0]
       if !element #|| element.displayed?
-        assert( true, "not found" )
+        assert( true, 'not found' )
         sleep 1
         return true
       end
@@ -865,7 +865,7 @@ wait untill text in selector disabppears
       end
     end
     sleep 1
-    assert( true, "all tasks closed" )
+    assert( true, 'all tasks closed' )
   end
 
 =begin
@@ -926,7 +926,7 @@ wait untill text in selector disabppears
       element = instance.find_elements( { :css => 'body' } )[0]
       text = element.text
       if text =~ /#{Regexp.quote(data[:name])}/
-        assert( true, "overview created" )
+        assert( true, 'overview created' )
         overview = {
           :name => name,
         }
@@ -934,7 +934,7 @@ wait untill text in selector disabppears
       end
       sleep 1
     }
-    raise "overview creation failed"
+    raise 'overview creation failed'
   end
 
 =begin
@@ -968,7 +968,7 @@ wait untill text in selector disabppears
     instance.find_elements( { :css => 'a[href="#ticket/create"]' } )[0].click
     element = instance.find_elements( { :css => '.active .newTicket' } )[0]
     if !element
-      raise "no ticket create screen found!"
+      raise 'no ticket create screen found!'
     end
     sleep 1
 
@@ -1034,7 +1034,7 @@ wait untill text in selector disabppears
     end
 
     if params[:do_not_submit]
-      assert( true, "ticket created without submit" )
+      assert( true, 'ticket created without submit' )
       return
     end
     sleep 0.8
@@ -1043,11 +1043,11 @@ wait untill text in selector disabppears
     sleep 1
     (1..8).each {|loop|
       if instance.current_url =~ /#{Regexp.quote('#ticket/zoom/')}/
-        assert( true, "ticket created" )
+        assert( true, 'ticket created' )
         sleep 2.5
         id = instance.current_url
         id.gsub!(//, )
-        id.gsub!(/^.+?\/(\d+)$/, "\\1")
+        id.gsub!(/^.+?\/(\d+)$/, '\\1')
 
         element = instance.find_elements( { :css => '.active .page-header .ticket-number' } )[0]
         if element
@@ -1211,12 +1211,12 @@ wait untill text in selector disabppears
         end
       }
       if !found
-        raise "no discard message found"
+        raise 'no discard message found'
       end
     end
 
     if params[:do_not_submit]
-      assert( true, "ticket updated without submit" )
+      assert( true, 'ticket updated without submit' )
       return true
     end
 
@@ -1233,7 +1233,7 @@ wait untill text in selector disabppears
       end
       sleep 1
     }
-    raise "unable to update ticket"
+    raise 'unable to update ticket'
   end
 
 =begin
@@ -1332,7 +1332,7 @@ wait untill text in selector disabppears
     sleep 0.5
     text = instance.find_elements( { :css => '#global-search' } )[0].attribute('value')
     if !text
-      raise "#global-search is not empty!"
+      raise '#global-search is not empty!'
     end
 
     # search by number again
@@ -1375,7 +1375,7 @@ wait untill text in selector disabppears
     overviews = {}
     instance.find_elements( { :css => '.content.active .sidebar a[href]' } ).each {|element|
       url = element.attribute('href')
-      url.gsub!(/(http|https):\/\/.+?\/(.+?)$/, "\\2")
+      url.gsub!(/(http|https):\/\/.+?\/(.+?)$/, '\\2')
       overviews[url] = 0
       #puts url.inspect
       #puts element.inspect
@@ -1411,7 +1411,7 @@ wait untill text in selector disabppears
     sleep 0.5
     text = instance.find_elements( { :css => '#global-search' } )[0].attribute('value')
     if !text
-      raise "#global-search is not empty!"
+      raise '#global-search is not empty!'
     end
     element = instance.find_elements( { :css => '#global-search' } )[0]
     element.click
@@ -1514,7 +1514,7 @@ wait untill text in selector disabppears
       :value   => data[:lastname],
     )
 
-    assert( true, "user created" )
+    assert( true, 'user created' )
   end
 
 =begin
@@ -1551,12 +1551,12 @@ wait untill text in selector disabppears
       element = instance.find_elements( { :css => 'body' } )[0]
       text = element.text
       if text =~ /#{Regexp.quote(data[:name])}/
-        assert( true, "sla created" )
+        assert( true, 'sla created' )
         return true
       end
       sleep 1
     }
-    raise "sla creation failed"
+    raise 'sla creation failed'
   end
 
 =begin
@@ -1597,12 +1597,12 @@ wait untill text in selector disabppears
       element = instance.find_elements( { :css => 'body' } )[0]
       text = element.text
       if text =~ /#{Regexp.quote(data[:name])}/
-        assert( true, "text module created" )
+        assert( true, 'text module created' )
         return true
       end
       sleep 1
     }
-    raise "text module creation failed"
+    raise 'text module creation failed'
   end
 
 =begin
@@ -1640,12 +1640,12 @@ wait untill text in selector disabppears
       element = instance.find_elements( { :css => 'body' } )[0]
       text = element.text
       if text =~ /#{Regexp.quote(data[:name])}/
-        assert( true, "signature created" )
+        assert( true, 'signature created' )
         return true
       end
       sleep 1
     }
-    raise "signature creation failed"
+    raise 'signature creation failed'
   end
 
 =begin
@@ -1691,7 +1691,7 @@ wait untill text in selector disabppears
       element = instance.find_elements( { :css => 'body' } )[0]
       text = element.text
       if text =~ /#{Regexp.quote(data[:name])}/
-        assert( true, "group created" )
+        assert( true, 'group created' )
 
         # add member
         if data[:member]
@@ -1715,7 +1715,7 @@ wait untill text in selector disabppears
       sleep 1
       return true
     }
-    raise "group creation failed"
+    raise 'group creation failed'
   end
 
   def quote(string)

+ 2 - 2
test/integration/elasticsearch_test.rb

@@ -163,7 +163,7 @@ class ElasticsearchTest < ActiveSupport::TestCase
     sleep 1
 
     ticket2 = Ticket.create(
-      :title         => "something else",
+      :title         => 'something else',
       :group         => Group.lookup( :name => 'Users'),
       :customer_id   => customer2.id,
       :state         => Ticket::State.lookup( :name => 'open' ),
@@ -189,7 +189,7 @@ class ElasticsearchTest < ActiveSupport::TestCase
     sleep 1
 
     ticket3 = Ticket.create(
-      :title         => "something else",
+      :title         => 'something else',
       :group         => Group.lookup( :name => 'WithoutAccess'),
       :customer_id   => customer3.id,
       :state         => Ticket::State.lookup( :name => 'open' ),

+ 4 - 4
test/integration/otrs_import_test.rb

@@ -10,9 +10,9 @@ class OtrsImportTest < ActiveSupport::TestCase
     raise "ERROR: Need IMPORT_OTRS_ENDPOINT_KEY - hint IMPORT_OTRS_ENDPOINT_KEY='01234567899876543210'"
   end
 
-  Setting.set("import_otrs_endpoint", ENV['IMPORT_OTRS_ENDPOINT'])
-  Setting.set("import_otrs_endpoint_key", ENV['IMPORT_OTRS_ENDPOINT_KEY'])
-  Setting.set("import_mode", true)
+  Setting.set('import_otrs_endpoint', ENV['IMPORT_OTRS_ENDPOINT'])
+  Setting.set('import_otrs_endpoint_key', ENV['IMPORT_OTRS_ENDPOINT_KEY'])
+  Setting.set('import_mode', true)
   Import::OTRS2.start
 
   # check settings items
@@ -24,7 +24,7 @@ class OtrsImportTest < ActiveSupport::TestCase
         http      = $1
         fqdn      = $2
         system_id = $3
-        system_id.gsub!(/[A-z]/, "") # strip chars
+        system_id.gsub!(/[A-z]/, '') # strip chars
     end
     assert_equal( system_id, Setting.get('system_id'), 'system_id' )
     assert_equal( fqdn, Setting.get('fqdn'), 'fqdn' )

+ 11 - 11
test/integration/twitter_test.rb

@@ -79,7 +79,7 @@ class TwitterTest < ActiveSupport::TestCase
       :updated_by_id  => 1,
       :created_by_id  => 1,
     )
-    assert( ticket, "outbound ticket created" )
+    assert( ticket, 'outbound ticket created' )
     article = Ticket::Article.create(
       :ticket_id      => ticket.id,
       :type_id        => Ticket::Article::Type.where( :name => 'twitter status' ).first.id,
@@ -92,7 +92,7 @@ class TwitterTest < ActiveSupport::TestCase
       :updated_by_id  => 1,
       :created_by_id  => 1,
     )
-    assert( article, "outbound article created" )
+    assert( article, 'outbound article created' )
     assert_equal( article.ticket.articles.count, 1 )
     sleep 10
 
@@ -103,7 +103,7 @@ class TwitterTest < ActiveSupport::TestCase
       config.access_token        = user2_token
       config.access_token_secret = user2_token_secret
     end
-    client.search(hash, :count => 50, :result_type => "recent").collect do |tweet|
+    client.search(hash, :count => 50, :result_type => 'recent').collect do |tweet|
       assert_equal( tweet.id, article.message_id )
     end
 
@@ -173,16 +173,16 @@ class TwitterTest < ActiveSupport::TestCase
       # check if ticket and article has been created
       article = Ticket::Article.where( :message_id => dm.id ).last
     }
-    puts "----------------------------------------"
-    puts "DM: " + dm.inspect
-    puts "AT: " + article.inspect
-    puts "----------------------------------------"
+    puts '----------------------------------------'
+    puts 'DM: ' + dm.inspect
+    puts 'AT: ' + article.inspect
+    puts '----------------------------------------'
 
-    assert( article, "inbound article created" )
+    assert( article, 'inbound article created' )
 #    ticket  = Ticket.find( article.ticket.id )
     ticket  = article.ticket
-    assert( ticket, "ticket of inbound article exists" )
-    assert( ticket.articles, "ticket.articles exists" )
+    assert( ticket, 'ticket of inbound article exists' )
+    assert( ticket.articles, 'ticket.articles exists' )
     article_count = ticket.articles.count
     assert( article_count )
 #    assert_equal( ticket.state.name, 'new' )
@@ -199,7 +199,7 @@ class TwitterTest < ActiveSupport::TestCase
       :updated_by_id  => 1,
       :created_by_id  => 1,
     )
-    assert( outbound_article, "outbound article created" )
+    assert( outbound_article, 'outbound article created' )
     assert_equal( outbound_article.ticket.articles.count, article_count + 1 )
     sleep 10
 

+ 8 - 8
test/integration/user_agent_test.rb

@@ -302,7 +302,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # ftp / 200
     result = UserAgent.request(
-      "ftp://ftp.gwdg.de/msgs/banner.msg",
+      'ftp://ftp.gwdg.de/msgs/banner.msg',
     )
     assert(result)
     assert_equal(true, result.success?)
@@ -312,7 +312,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # ftp / 401
     result = UserAgent.request(
-      "ftp://ftp.gwdg.de/msgs/not_existing.msg",
+      'ftp://ftp.gwdg.de/msgs/not_existing.msg',
     )
     assert(result)
     assert_equal(false, result.success?)
@@ -321,7 +321,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # get / 200 / gzip
     result = UserAgent.request(
-      "https://httpbin.org/gzip",
+      'https://httpbin.org/gzip',
     )
     assert(result)
     assert_equal(true, result.success?)
@@ -331,7 +331,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # get / 200 / gzip
     result = UserAgent.request(
-      "http://httpbin.org/gzip",
+      'http://httpbin.org/gzip',
     )
     assert(result)
     assert_equal(true, result.success?)
@@ -341,7 +341,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # get / 200 / gzip
     result = UserAgent.request(
-      "https://httpbin.org/deflate",
+      'https://httpbin.org/deflate',
     )
     assert(result)
     assert_equal(true, result.success?)
@@ -351,7 +351,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # get / 200 / gzip
     result = UserAgent.request(
-      "http://httpbin.org/deflate",
+      'http://httpbin.org/deflate',
     )
     assert(result)
     assert_equal(true, result.success?)
@@ -367,7 +367,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # get / 0
     result = UserAgent.request(
-      "http://not.existing.host/test.php",
+      'http://not.existing.host/test.php',
     )
     assert(result)
     assert_equal(false, result.success?)
@@ -376,7 +376,7 @@ class UserAgentTest < ActiveSupport::TestCase
 
     # ftp / 0
     result = UserAgent.request(
-      "ftp://not.existing.host/test.bin",
+      'ftp://not.existing.host/test.bin',
     )
     assert(result)
     assert_equal(false, result.success?)

+ 1 - 1
test/integration_test_helper.rb

@@ -1,4 +1,4 @@
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 require File.expand_path('../../config/environment', __FILE__)
 require 'rails/test_help'
 require 'cache'

+ 1 - 1
test/test_helper.rb

@@ -1,4 +1,4 @@
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 require File.expand_path('../../config/environment', __FILE__)
 require 'rails/test_help'
 require 'cache'

+ 17 - 17
test/ui_test.rb

@@ -1,4 +1,4 @@
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 require File.expand_path('../../config/environment', __FILE__)
 require 'rails/test_help'
 require 'test/unit'
@@ -17,32 +17,32 @@ class ExampleTest < Test::Unit::TestCase
     end
 
     def test_first_page
-        browser.get "http://portal.znuny.com/"
-	assert_equal browser.current_url, "https://portal.znuny.com/#login"
+        browser.get 'http://portal.znuny.com/'
+	assert_equal browser.current_url, 'https://portal.znuny.com/#login'
     end
 
     def test_login_failed
-       browser.get "http://portal.znuny.com/"
-       element_username = browser.find_element :name => "username"
-       element_username.send_keys "roy@kaldung.de"
-       element_password = browser.find_element :name => "password"
-       element_password.send_keys "123456"
+       browser.get 'http://portal.znuny.com/'
+       element_username = browser.find_element :name => 'username'
+       element_username.send_keys 'roy@kaldung.de'
+       element_password = browser.find_element :name => 'password'
+       element_password.send_keys '123456'
        element_password.submit
        wait = Selenium::WebDriver::Wait.new(:timeout => 10) # seconds
-       wait.until { browser.find_element(:id => "app") }
-       assert_equal browser.current_url, "https://portal.znuny.com/#login"
+       wait.until { browser.find_element(:id => 'app') }
+       assert_equal browser.current_url, 'https://portal.znuny.com/#login'
     end
 
     def test_login_passed
-       browser.get "http://portal.znuny.com/"
-       element_username = browser.find_element :name => "username"
-       element_username.send_keys "roy@kaldung.com"
-       element_password = browser.find_element :name => "password"
-       element_password.send_keys "090504"
+       browser.get 'http://portal.znuny.com/'
+       element_username = browser.find_element :name => 'username'
+       element_username.send_keys 'roy@kaldung.com'
+       element_password = browser.find_element :name => 'password'
+       element_password.send_keys '090504'
        element_password.submit
        wait = Selenium::WebDriver::Wait.new(:timeout => 10) # seconds
-       wait.until { browser.find_element(:id => "app") }
-       assert_equal browser.current_url, "https://portal.znuny.com/#ticket_view/my_tickets"
+       wait.until { browser.find_element(:id => 'app') }
+       assert_equal browser.current_url, 'https://portal.znuny.com/#ticket_view/my_tickets'
     end
 end
 

+ 1 - 1
test/unit/aaa_string_test.rb

@@ -71,7 +71,7 @@ class AaaStringTest < ActiveSupport::TestCase
     result = "test\ntest"
     assert_equal( result, html.html2text )
 
-    html   = "<table><tr><td>test</td><td>col</td></td></tr><tr><td>test</td><td>4711</td></tr></table>"
+    html   = '<table><tr><td>test</td><td>col</td></td></tr><tr><td>test</td><td>4711</td></tr></table>'
     result = "test col  \ntest 4711"
     assert_equal( result, html.html2text )
 

Some files were not shown because too many files changed in this diff