Browse Source

Maintenance: Improving readonly view in agent interface.

Tobias Schäfer 2 years ago
parent
commit
4d254dfdf7

+ 1 - 0
app/assets/javascripts/app/controllers/knowledge_base/sidebar/linked_tickets.coffee

@@ -20,6 +20,7 @@ class App.KnowledgeBaseSidebarLinkedTickets extends App.Controller
   render: ->
     @html App.view('knowledge_base/sidebar/linked_tickets')(
       tickets: @object.translation(@kb_locale.id)?.linked_tickets() || []
+      editable: true
     )
 
     @renderPopovers()

+ 1 - 0
app/assets/javascripts/app/controllers/knowledge_base/sidebar/tags.coffee

@@ -10,6 +10,7 @@ class App.KnowledgeBaseSidebarTags extends App.Controller
       object_type: 'KnowledgeBaseAnswer'
       object:      @object
       tags:        @object.tags
+      editable:    true
     )
 
   updateIfNeeded: ->

+ 3 - 0
app/assets/javascripts/app/controllers/ticket_zoom/sidebar_ticket.coffee

@@ -152,12 +152,14 @@ class SidebarTicket extends App.Controller
         object_type: 'Ticket'
         object:      @ticket
         tags:        @tags
+        editable:    @ticket.editable()
       )
       @linkWidget = new App.WidgetLink.Ticket(
         el:          localEl.filter('.js-links')
         object_type: 'Ticket'
         object:      @ticket
         links:       @links
+        editable:    @ticket.editable()
       )
 
       if @permissionCheck('knowledge_base.*') and App.Config.get('kb_active')
@@ -166,6 +168,7 @@ class SidebarTicket extends App.Controller
           object_type: 'Ticket'
           object:      @ticket
           links:       @links
+          editable:    @ticket.editable()
         )
 
       @timeUnitWidget = new App.TicketZoomTimeUnit(

+ 1 - 0
app/assets/javascripts/app/controllers/widget/link/kb_answer.coffee

@@ -43,6 +43,7 @@ class App.WidgetLinkKbAnswer extends App.WidgetLink
   render: ->
     @html App.view('link/kb_answer')(
       list: @linksForRendering()
+      editable: @editable
     )
 
     @renderPopovers()

+ 2 - 0
app/assets/javascripts/app/controllers/widget/link/ticket.coffee

@@ -47,11 +47,13 @@ class App.WidgetLink.Ticket extends App.WidgetLink
         tickets: list[type].tickets
         object: 'Ticket'
         linkType: type
+        editable: @editable
       ) unless list[type].tickets.length == 0
 
     # insert data
     @html App.view('link/ticket/list')(
       links: list
+      editable: @editable
     )
 
     @renderPopovers()

+ 2 - 0
app/assets/javascripts/app/controllers/widget/tag.coffee

@@ -51,8 +51,10 @@ class App.WidgetTag extends App.Controller
   render: =>
     return if @lastLocalTags && _.isEqual(@lastLocalTags, @localTags)
     @lastLocalTags = _.clone(@localTags)
+
     @html App.view(@templateName)(
       tags: @localTags || [],
+      editable: @editable
     )
     source = "#{App.Config.get('api_path')}/tag_search"
     @$('.js-newTagInput').autocomplete(

+ 2 - 2
app/assets/javascripts/app/views/generic/ticket_list.jst.eco

@@ -17,7 +17,7 @@
       </a>
       <%- @humanTime(ticket.created_at, false, 'time') %>
     </div>
-    <% if @object: %>
+    <% if @object && @editable: %>
     <a class="list-item-delete js-delete" data-object="<%= @object %>" data-object-id="<%= ticket.id %>" data-link-type="<%= @linkType || 'normal' %>" data-type="remove">
       <%- @Icon('diagonal-cross') %>
     </a>
@@ -31,4 +31,4 @@
     <div data-show="collapsed"><%- @Icon('arrow-up') %> <span><%- @T('Show less') %></span></div>
   </div>
   <% end %>
-</div>
+</div>

+ 1 - 1
app/assets/javascripts/app/views/knowledge_base/sidebar/linked_tickets.jst.eco

@@ -2,7 +2,7 @@
   <h2><%- @T('Linked Tickets') %></h2>
 </div>
 
-<%- @V('generic/ticket_list', show_max: 5, tickets: @tickets, object: 'Ticket') %>
+<%- @V('generic/ticket_list', show_max: 5, tickets: @tickets, object: 'Ticket', editable: @editable) %>
 
 <a class="btn btn--action btn--small js-add" href="#">
   <%- @Icon('plus-small') %> <span><%- @T('Add') %></span>

+ 8 - 4
app/assets/javascripts/app/views/link/kb_answer.jst.eco

@@ -8,9 +8,13 @@
       <div class="task-text">
         <a class="name kb-answer-popover" data-id="<%- item.id %>" href="<%- item.url %>"><%= item.title %></a>
       </div>
-      <a class="list-item-delete js-delete" data-object="KnowledgeBase::Answer::Translation" data-object-id="<%= item.id %>" data-link-type="normal">
-        <%- @Icon('diagonal-cross') %>
-      </a>
+      <% if @editable: %>
+        <a class="list-item-delete js-delete" data-object="KnowledgeBase::Answer::Translation" data-object-id="<%= item.id %>" data-link-type="normal">
+          <%- @Icon('diagonal-cross') %>
+        </a>
+      <% end %>
   <% end %>
 </ol>
-<div class="text-muted js-add u-clickable">+ <%- @T('Link Related Answer') %></div>
+<% if @editable: %>
+  <div class="text-muted js-add u-clickable">+ <%- @T('Link Related Answer') %></div>
+<% end %>

+ 3 - 1
app/assets/javascripts/app/views/link/ticket/list.jst.eco

@@ -5,4 +5,6 @@
   <%- @links[type].ticketList %>
 </div>
 <% end %>
-<div class="text-muted u-clickable js-add">+ <%- @T('Add Link') %></div>
+<% if @editable: %>
+  <div class="text-muted u-clickable js-add">+ <%- @T('Add Link') %></div>
+<% end %>

Some files were not shown because too many files changed in this diff