Browse Source

Corrected with rubocop cop 'Style/MultilineOperationIndentation'.

Thorsten Eckel 10 years ago
parent
commit
39578cea49

+ 4 - 4
app/models/activity_stream.rb

@@ -99,12 +99,12 @@ return all activity entries of an user
     return [] if role_ids.include?(customer_role.id)
     if group_ids.empty?
       stream = ActivityStream.where('(role_id IN (?) AND group_id is NULL)', role_ids )
-      .order( 'created_at DESC, id DESC' )
-      .limit( limit )
+               .order( 'created_at DESC, id DESC' )
+               .limit( limit )
     else
       stream = ActivityStream.where('(role_id IN (?) AND group_id is NULL) OR ( role_id IN (?) AND group_id IN (?) ) OR ( role_id is NULL AND group_id IN (?) )', role_ids, role_ids, group_ids, group_ids )
-      .order( 'created_at DESC, id DESC' )
-      .limit( limit )
+               .order( 'created_at DESC, id DESC' )
+               .limit( limit )
     end
     list = []
     stream.each do |item|

+ 1 - 1
app/models/channel/email_parser.rb

@@ -103,7 +103,7 @@ class Channel::EmailParser
       data[:from_local]        = Mail::Address.new( from ).local
       data[:from_domain]       = Mail::Address.new( from ).domain
       data[:from_display_name] = Mail::Address.new( from ).display_name ||
-      ( Mail::Address.new( from ).comments && Mail::Address.new( from ).comments[0] )
+                                 ( Mail::Address.new( from ).comments && Mail::Address.new( from ).comments[0] )
     rescue
       data[:from_email]  = from
       data[:from_local]  = from

+ 2 - 2
app/models/history.rb

@@ -151,8 +151,8 @@ returns
     if !related_history_object
       history_object = self.object_lookup( requested_object )
       history = History.where( history_object_id: history_object.id )
-      .where( o_id: requested_object_id )
-      .order('created_at ASC, id ASC')
+                .where( o_id: requested_object_id )
+                .order('created_at ASC, id ASC')
     else
       history_object_requested = self.object_lookup( requested_object )
       history_object_related   = self.object_lookup( related_history_object )

+ 2 - 2
app/models/job.rb

@@ -43,8 +43,8 @@ class Job < ApplicationModel
 
       # find tickets to change
       tickets = Ticket.where( job.condition.permit! )
-        .order( '`tickets`.`created_at` DESC' )
-        .limit( 1_000 )
+                .order( '`tickets`.`created_at` DESC' )
+                .limit( 1_000 )
       job.processed = tickets.count
       tickets.each do |ticket|
         #puts "CHANGE #{job.execute.inspect}"

+ 4 - 2
app/models/observer/ticket/last_contact.rb

@@ -18,8 +18,10 @@ class Observer::Ticket::LastContact < ActiveRecord::Observer
 
       # check if last communication is done by agent, else do not set last_contact_customer
       if record.ticket.last_contact_customer == nil ||
-        record.ticket.last_contact_agent == nil ||
-        record.ticket.last_contact_agent.to_i > record.ticket.last_contact_customer.to_i
+         record.ticket.last_contact_agent == nil ||
+         record.ticket.last_contact_agent.to_i > record.ticket.last_contact_customer.to_i
+
+        # set last_contact customer
         record.ticket.last_contact_customer = record.created_at
 
         # set last_contact

+ 5 - 4
app/models/online_notification.rb

@@ -88,8 +88,8 @@ return all online notifications of an user
   def self.list(user, limit)
 
     notifications = OnlineNotification.where(user_id: user.id)
-      .order( 'created_at DESC, id DESC' )
-      .limit( limit )
+                    .order( 'created_at DESC, id DESC' )
+                    .limit( limit )
     list = []
     notifications.each do |item|
       data = item.attributes
@@ -116,8 +116,9 @@ return all online notifications of an object
       object_lookup_id: object_id,
       o_id: o_id,
     )
-      .order( 'created_at DESC, id DESC' )
-      .limit( 10_000 )
+    .order( 'created_at DESC, id DESC' )
+    .limit( 10_000 )
+
     list = []
     notifications.each do |item|
       data = item.attributes

+ 4 - 4
app/models/recent_view.rb

@@ -38,12 +38,12 @@ class RecentView < ApplicationModel
   def self.list( user, limit = 10, type = nil )
     if !type
       recent_views = RecentView.where( created_by_id: user.id )
-      .order('created_at DESC, id DESC')
-      .limit(limit)
+                     .order('created_at DESC, id DESC')
+                     .limit(limit)
     else
       recent_views = RecentView.select('DISTINCT(o_id), recent_view_object_id').where( created_by_id: user.id, recent_view_object_id: ObjectLookup.by_name(type) )
-      .order('created_at DESC, id DESC')
-      .limit(limit)
+                     .order('created_at DESC, id DESC')
+                     .limit(limit)
     end
 
     list = []

+ 3 - 3
app/models/store.rb

@@ -81,7 +81,7 @@ returns
     # search
     store_object_id = Store::Object.lookup( name: data[:object] )
     stores = Store.where( store_object_id: store_object_id, o_id: data[:o_id].to_i )
-    .order('created_at ASC, id ASC')
+             .order('created_at ASC, id ASC')
     stores
   end
 
@@ -104,8 +104,8 @@ returns
     # search
     store_object_id = Store::Object.lookup( name: data[:object] )
     stores = Store.where( store_object_id: store_object_id )
-    .where( o_id: data[:o_id] )
-    .order('created_at ASC, id ASC')
+             .where( o_id: data[:o_id] )
+             .order('created_at ASC, id ASC')
     stores.each do |store|
 
       # check backend for references

+ 3 - 3
app/models/ticket.rb

@@ -95,9 +95,9 @@ returns
     access_condition = []
     if user.is_role(Z_ROLENAME_AGENT)
       group_ids = Group.select( 'groups.id' ).joins(:users)
-      .where( 'groups_users.user_id = ?', user.id )
-      .where( 'groups.active = ?', true )
-      .map( &:id )
+                  .where( 'groups_users.user_id = ?', user.id )
+                  .where( 'groups.active = ?', true )
+                  .map( &:id )
       access_condition = [ 'group_id IN (?)', group_ids ]
     else
       if !user.organization || ( !user.organization.shared || user.organization.shared == false )

+ 17 - 17
app/models/ticket/overviews.rb

@@ -109,13 +109,13 @@ returns
     # get only tickets with permissions
     if data[:current_user].is_role('Customer')
       group_ids = Group.select( 'groups.id' )
-      .where( 'groups.active = ?', true )
-      .map( &:id )
+                  .where( 'groups.active = ?', true )
+                  .map( &:id )
     else
       group_ids = Group.select( 'groups.id' ).joins(:users)
-      .where( 'groups_users.user_id = ?', [ data[:current_user].id ] )
-      .where( 'groups.active = ?', true )
-      .map( &:id )
+                  .where( 'groups_users.user_id = ?', [ data[:current_user].id ] )
+                  .where( 'groups.active = ?', true )
+                  .map( &:id )
     end
 
     # overview meta for navbar
@@ -148,10 +148,10 @@ returns
         order_by = overview_selected.group_by + '_id, ' + order_by
       end
       tickets = Ticket.select( 'id' )
-      .where( group_id: group_ids )
-      .where( _condition( overview_selected.condition ) )
-      .order( order_by )
-      .limit( 500 )
+                .where( group_id: group_ids )
+                .where( _condition( overview_selected.condition ) )
+                .order( order_by )
+                .limit( 500 )
 
       ticket_ids = []
       tickets.each { |ticket|
@@ -159,8 +159,8 @@ returns
       }
 
       tickets_count = Ticket.where( group_id: group_ids )
-      .where( _condition( overview_selected.condition ) )
-      .count()
+                      .where( _condition( overview_selected.condition ) )
+                      .count()
 
       return {
         ticket_ids: ticket_ids,
@@ -172,14 +172,14 @@ returns
     # get tickets for overview
     data[:start_page] ||= 1
     tickets = Ticket.where( group_id: group_ids )
-    .where( _condition( overview_selected.condition ) )
-    .order( overview_selected[:order][:by].to_s + ' ' + overview_selected[:order][:direction].to_s )#.
-    #      limit( overview_selected.view[ data[:view_mode].to_sym ][:per_page] ).
-    #      offset( overview_selected.view[ data[:view_mode].to_sym ][:per_page].to_i * ( data[:start_page].to_i - 1 ) )
+              .where( _condition( overview_selected.condition ) )
+              .order( overview_selected[:order][:by].to_s + ' ' + overview_selected[:order][:direction].to_s )
+    #          .limit( overview_selected.view[ data[:view_mode].to_sym ][:per_page] )
+    #          .offset( overview_selected.view[ data[:view_mode].to_sym ][:per_page].to_i * ( data[:start_page].to_i - 1 ) )
 
     tickets_count = Ticket.where( group_id: group_ids )
-    .where( _condition( overview_selected.condition ) )
-    .count()
+                    .where( _condition( overview_selected.condition ) )
+                    .count()
 
     {
       tickets: tickets,

Some files were not shown because too many files changed in this diff