Fixes #1679 - Read-only view for tickets contains misleading elements.

app/assets/javascripts/app/controllers/ticket_zoom.coffee

@@ -502,30 +502,31 @@ class App.TicketZoom extends App.Controller
 
       @form_id = @taskGet('article').form_id || App.ControllerForm.formId()
 
-      @articleNew = new App.TicketZoomArticleNew(
-        ticket:                       @ticket
-        ticket_id:                    @ticket_id
-        el:                           elLocal.find('.article-new')
-        formMeta:                     @formMeta
-        form_id:                      @form_id
-        defaults:                     @taskGet('article')
-        taskKey:                      @taskKey
-        ui:                           @
-        richTextUploadStartCallback:  @submitDisable
-        richTextUploadRenderCallback: (attachments) =>
-          @submitEnable()
-          @taskUpdateAttachments('article', attachments)
-          @delay(@markForm, 250, 'ticket-zoom-form-update')
-        richTextUploadDeleteCallback: (attachments) =>
-          @taskUpdateAttachments('article', attachments)
-          @delay(@markForm, 250, 'ticket-zoom-form-update')
-      )
+      if @ticket.editable()
+        @articleNew = new App.TicketZoomArticleNew(
+          ticket:                       @ticket
+          ticket_id:                    @ticket_id
+          el:                           elLocal.find('.article-new')
+          formMeta:                     @formMeta
+          form_id:                      @form_id
+          defaults:                     @taskGet('article')
+          taskKey:                      @taskKey
+          ui:                           @
+          richTextUploadStartCallback:  @submitDisable
+          richTextUploadRenderCallback: (attachments) =>
+            @submitEnable()
+            @taskUpdateAttachments('article', attachments)
+            @delay(@markForm, 250, 'ticket-zoom-form-update')
+          richTextUploadDeleteCallback: (attachments) =>
+            @taskUpdateAttachments('article', attachments)
+            @delay(@markForm, 250, 'ticket-zoom-form-update')
+        )
 
-      @highligher = new App.TicketZoomHighlighter(
-        el:        elLocal.find('.js-highlighterContainer')
-        ticket:    @ticket
-        ticket_id: @ticket_id
-      )
+        @highlighter = new App.TicketZoomHighlighter(
+          el:        elLocal.find('.js-highlighterContainer')
+          ticket:    @ticket
+          ticket_id: @ticket_id
+        )
 
       new App.TicketZoomSetting(
         el:        elLocal.find('.js-settingContainer')
@@ -536,7 +537,7 @@ class App.TicketZoom extends App.Controller
         ticket:             @ticket
         el:                 elLocal.find('.ticket-article')
         ui:                 @
-        highligher:         @highligher
+        highlighter:        @highlighter
         ticket_article_ids: @ticket_article_ids
         form_id:            @form_id
       )
@@ -627,6 +628,7 @@ class App.TicketZoom extends App.Controller
     if !@autosaveLast
       @autosaveLast = @taskGet()
     return if !@ticket
+    return if !@ticket.editable()
     currentParams = @formCurrent()
 
     # check changed between last autosave
@@ -712,7 +714,7 @@ class App.TicketZoom extends App.Controller
   formCurrent: =>
     currentParams =
       ticket:  @formParam(@el.find('.edit'))
-      article: @articleNew.params()
+      article: @articleNew?.params() || {}
 
     # add attachments if exist
     attachmentCount = @$('.article-add .textBubble .attachments .attachment').length
@@ -768,7 +770,7 @@ class App.TicketZoom extends App.Controller
 
     params         = {}
     params.ticket  = @forRemoveMeta(@ticketParams())
-    params.article = @forRemoveMeta(@articleNew.params())
+    params.article = @forRemoveMeta(@articleNew?.params())
 
     # clear all changes
     if _.isEmpty(diff.ticket) && _.isEmpty(diff.article)
@@ -960,7 +962,7 @@ class App.TicketZoom extends App.Controller
     e.preventDefault()
 
     params =
-      new_article:       @articleNew.params()
+      new_article:       @articleNew?.params() || {}
       ticket_attributes: @ticketParams()
 
     params.new_article.body = App.Utils.signatureRemoveByHtml(params.new_article.body)
@@ -1190,8 +1192,9 @@ class App.TicketZoom extends App.Controller
   taskReset: =>
     @form_id = App.ControllerForm.formId()
 
-    @articleNew.form_id = @form_id
-    @articleNew.render()
+    if @articleNew
+      @articleNew.form_id = @form_id
+      @articleNew.render()
 
     @articleView.updateFormId(@form_id)
 

app/assets/javascripts/app/controllers/ticket_zoom/article_action/delete.coffee

@@ -41,6 +41,7 @@ class Delete
     timeframe_miliseconds - (now - created_at)
 
   @deletableForAgent: (actions, ticket, article, ui) ->
+    return false if !ticket.editable()
     return false if ticket.currentView() is 'customer'
     return false if article.created_by_id != App.User.current()?.id
     return false if article.type.communication && !article.internal

app/assets/javascripts/app/controllers/ticket_zoom/article_action/email_reply.coffee

@@ -1,5 +1,6 @@
 class EmailReply extends App.Controller
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     return actions if ticket.currentView() is 'customer'
     group = ticket.group
     return actions if !group.email_address_id

app/assets/javascripts/app/controllers/ticket_zoom/article_action/facebook_reply.coffee

@@ -1,5 +1,6 @@
 class FacebookReply
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     return actions if ticket.currentView() is 'customer'
 
     if article.type.name is 'facebook feed post' || article.type.name is 'facebook feed comment'

app/assets/javascripts/app/controllers/ticket_zoom/article_action/internal.coffee

@@ -1,5 +1,6 @@
 class Internal
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     return actions if ticket.currentView() is 'customer'
 
     if article.internal is true

app/assets/javascripts/app/controllers/ticket_zoom/article_action/note.coffee

@@ -1,5 +1,6 @@
 class Note
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     actions
 
   @perform: (articleContainer, type, ticket, article, ui) ->

app/assets/javascripts/app/controllers/ticket_zoom/article_action/phone_reply.coffee

@@ -1,5 +1,6 @@
 class PhoneReply
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     actions
 
   @perform: (articleContainer, type, ticket, article, ui) ->

app/assets/javascripts/app/controllers/ticket_zoom/article_action/sms_reply.coffee

@@ -1,5 +1,6 @@
 class SmsReply
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     return actions if ticket.currentView() is 'customer'
 
     if article.sender.name is 'Customer' && article.type.name is 'sms'

app/assets/javascripts/app/controllers/ticket_zoom/article_action/split.coffee

@@ -1,5 +1,6 @@
 class Split
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     return actions if ticket.currentView() is 'customer'
 
     actions.push {

app/assets/javascripts/app/controllers/ticket_zoom/article_action/telegram.coffee

@@ -1,5 +1,6 @@
 class TelegramReply
   @action: (actions, ticket, article, ui) ->
+    return actions if !ticket.editable()
     return actions if ticket.currentView() is 'customer'
 
     if article.sender.name is 'Customer' && article.type.name is 'telegram personal-message'