Maintenance: Improve popover handling.

A.k.a. eliminate the dreaded "popover killer".

app/assets/javascripts/app/controllers/_plugin/navigation.coffee

@@ -322,7 +322,6 @@ class Navigation extends App.Controller
   andClose: =>
     @searchContainer.removeClass('focused filled open no-match loading')
     @globalSearch.close()
-    @delayedRemoveAnyPopover()
 
   search: (delay) =>
     query = @searchInput.val().trim()

app/assets/javascripts/app/controllers/search.coffee

@@ -113,8 +113,6 @@ class App.Search extends App.Controller
     @updateFilledClass()
     @updateTask()
 
-    @delayedRemoveAnyPopover()
-
   search: (delay, force = false) =>
     query = @searchInput.val().trim()
     if !force

app/assets/javascripts/app/lib/app_post/task_manager.coffee

@@ -410,8 +410,6 @@ class _taskManagerSingleton extends App.Controller
     if controller.hide && _.isFunction(controller.hide)
       controller.hide()
 
-    @delayedRemoveAnyPopover()
-
     true
 
   # get task

app/assets/javascripts/app/lib/mixins/popover_providable.coffee

@@ -37,9 +37,6 @@ InstanceMethods =
 
     @initializedPopovers = undefined
 
-  delayedRemoveAnyPopover: ->
-    @delay(@constructor.anyPopoversDestroy, 100, 'removePopovers')
-
 App.PopoverProvidable =
   registerPopovers: (klasses...) ->
     @allPopovers = undefined

spec/support/capybara/common_actions.rb

@@ -279,10 +279,7 @@ module CommonActions
   #
   # @example
   # popover_on_hover(page.find('button.hover_me'))
-  def popover_on_hover(element, wait_for_popover_killer: true)
-    # wait for popover killer to pass
-    sleep 3 if wait_for_popover_killer
-
+  def popover_on_hover(element)
     move_mouse_to(element)
     move_mouse_by(5, 5)
   end

spec/system/knowledge_base/locale/answer/edit_spec.rb

@@ -26,8 +26,6 @@ RSpec.describe 'Knowledge Base Locale Answer Edit', type: :system do
     def open_editor_and_add_link(input)
       visit "#knowledge_base/#{knowledge_base.id}/locale/#{primary_locale.system_locale.locale}/answer/#{draft_answer.id}/edit"
 
-      sleep 3 # wait for popover killer to pass
-
       find('a[data-action="link"]').click
 
       within('.popover-content') do
@@ -66,8 +64,6 @@ RSpec.describe 'Knowledge Base Locale Answer Edit', type: :system do
     it 'has adding functionality' do
       visit "#knowledge_base/#{knowledge_base.id}/locale/#{primary_locale.system_locale.locale}/answer/#{published_answer.id}/edit"
 
-      sleep 3 # wait for popover killer to pass
-
       find('a[data-action="embed_video"]').click
 
       within('.popover-content') do

spec/system/profile/out_of_office_spec.rb

@@ -5,7 +5,6 @@ require 'rails_helper'
 RSpec.describe 'Profile > Out of Office', type: :system do
   before do
     visit 'profile/out_of_office'
-    sleep 3 # wait for popover killer to pass
   end
 
   it 'does find agents' do

spec/system/search_spec.rb

@@ -128,7 +128,6 @@ RSpec.describe 'Search', type: :system, authenticated: true, searchindex: true d
     end
 
     before do
-      sleep 3 # wait for popover killer to pass
       fill_in id: 'global-search', with: organization.name.to_s
     end
 

spec/system/ticket/zoom_spec.rb

@@ -1428,7 +1428,6 @@ RSpec.describe 'Ticket zoom', type: :system do
       ticket.update(pending_time: 1.day.from_now, state: Ticket::State.lookup(name: 'pending reminder'))
 
       visit "ticket/zoom/#{ticket.id}"
-      sleep 3 # wait for popover killer to pass
     end
 
     let(:ticket) { Ticket.first }
@@ -2538,7 +2537,6 @@ RSpec.describe 'Ticket zoom', type: :system do
     end
 
     it 'does show the extended escalation information' do
-      sleep 4 # wait for popup killer
       page.find('.escalation-popover').hover
       expect(page).to have_text('FIRST RESPONSE TIME')
       expect(page).to have_text('UPDATE TIME')