Browse Source

Follow-up bed390e5fe49a2fa4d9e572d9b5d1644f2bea41c - Fixes #5106 - SSL verification with SAML fails with valid Let's Encrypt certificates

Tobias Schäfer 7 months ago
parent
commit
0f3ffa168e

+ 1 - 1
app/models/setting/validation/saml/tls.rb

@@ -29,7 +29,7 @@ class Setting::Validation::Saml::TLS < Setting::Validation::Base
     )
 
     return nil if resp.error.nil?
-    return nil if resp.error.starts_with?('#<Net::HTTP')
+    return nil if resp.error.include?('#<Net::HTTP')
 
     Rails.logger.error("SAML: TLS verification failed for '#{url}': #{resp.error}")
 

+ 1 - 1
spec/models/setting/validation/saml/tls_spec.rb

@@ -53,7 +53,7 @@ RSpec.describe Setting::Validation::Saml::TLS do
 
       context 'with a HTTP error' do
         it 'raises no error' do
-          result = UserAgent::Result.new(success: false, error: '#<Net::HTTPNotFound')
+          result = UserAgent::Result.new(success: false, error: 'Client Error: #<Net::HTTPNotFound')
           allow(UserAgent).to receive(:get).and_return(result)
 
           expect { Setting.set(setting_name, setting_value) }.not_to raise_error