Browse Source

[networking] Strip whitespace around header values (#8802)

Fixes https://github.com/yt-dlp/yt-dlp/issues/8729
Authored by: coletdjnz
coletdjnz 1 year ago
parent
commit
196eb0fe77
2 changed files with 6 additions and 1 deletions
  1. 5 0
      test/test_utils.py
  2. 1 1
      yt_dlp/utils/networking.py

+ 5 - 0
test/test_utils.py

@@ -2370,6 +2370,11 @@ Line 1
         headers4 = HTTPHeaderDict({'ytdl-test': 'data;'})
         self.assertEqual(set(headers4.items()), {('Ytdl-Test', 'data;')})
 
+        # common mistake: strip whitespace from values
+        # https://github.com/yt-dlp/yt-dlp/issues/8729
+        headers5 = HTTPHeaderDict({'ytdl-test': ' data; '})
+        self.assertEqual(set(headers5.items()), {('Ytdl-Test', 'data;')})
+
     def test_extract_basic_auth(self):
         assert extract_basic_auth('http://:foo.bar') == ('http://:foo.bar', None)
         assert extract_basic_auth('http://foo.bar') == ('http://foo.bar', None)

+ 1 - 1
yt_dlp/utils/networking.py

@@ -67,7 +67,7 @@ class HTTPHeaderDict(collections.UserDict, dict):
     def __setitem__(self, key, value):
         if isinstance(value, bytes):
             value = value.decode('latin-1')
-        super().__setitem__(key.title(), str(value))
+        super().__setitem__(key.title(), str(value).strip())
 
     def __getitem__(self, key):
         return super().__getitem__(key.title())