NoUncountedMembersChecker.cpp 4.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159
  1. //=======- NoUncountedMembersChecker.cpp -------------------------*- C++ -*-==//
  2. //
  3. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
  4. // See https://llvm.org/LICENSE.txt for license information.
  5. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
  6. //
  7. //===----------------------------------------------------------------------===//
  8. #include "ASTUtils.h"
  9. #include "DiagOutputUtils.h"
  10. #include "PtrTypesSemantics.h"
  11. #include "clang/AST/CXXInheritance.h"
  12. #include "clang/AST/Decl.h"
  13. #include "clang/AST/DeclCXX.h"
  14. #include "clang/AST/RecursiveASTVisitor.h"
  15. #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
  16. #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
  17. #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
  18. #include "clang/StaticAnalyzer/Core/Checker.h"
  19. #include "llvm/ADT/DenseSet.h"
  20. #include "llvm/Support/Casting.h"
  21. #include <optional>
  22. using namespace clang;
  23. using namespace ento;
  24. namespace {
  25. class NoUncountedMemberChecker
  26. : public Checker<check::ASTDecl<TranslationUnitDecl>> {
  27. private:
  28. BugType Bug;
  29. mutable BugReporter *BR;
  30. public:
  31. NoUncountedMemberChecker()
  32. : Bug(this,
  33. "Member variable is a raw-poiner/reference to reference-countable "
  34. "type",
  35. "WebKit coding guidelines") {}
  36. void checkASTDecl(const TranslationUnitDecl *TUD, AnalysisManager &MGR,
  37. BugReporter &BRArg) const {
  38. BR = &BRArg;
  39. // The calls to checkAST* from AnalysisConsumer don't
  40. // visit template instantiations or lambda classes. We
  41. // want to visit those, so we make our own RecursiveASTVisitor.
  42. struct LocalVisitor : public RecursiveASTVisitor<LocalVisitor> {
  43. const NoUncountedMemberChecker *Checker;
  44. explicit LocalVisitor(const NoUncountedMemberChecker *Checker)
  45. : Checker(Checker) {
  46. assert(Checker);
  47. }
  48. bool shouldVisitTemplateInstantiations() const { return true; }
  49. bool shouldVisitImplicitCode() const { return false; }
  50. bool VisitRecordDecl(const RecordDecl *RD) {
  51. Checker->visitRecordDecl(RD);
  52. return true;
  53. }
  54. };
  55. LocalVisitor visitor(this);
  56. visitor.TraverseDecl(const_cast<TranslationUnitDecl *>(TUD));
  57. }
  58. void visitRecordDecl(const RecordDecl *RD) const {
  59. if (shouldSkipDecl(RD))
  60. return;
  61. for (auto *Member : RD->fields()) {
  62. const Type *MemberType = Member->getType().getTypePtrOrNull();
  63. if (!MemberType)
  64. continue;
  65. if (auto *MemberCXXRD = MemberType->getPointeeCXXRecordDecl()) {
  66. // If we don't see the definition we just don't know.
  67. if (MemberCXXRD->hasDefinition()) {
  68. std::optional<bool> isRCAble = isRefCountable(MemberCXXRD);
  69. if (isRCAble && *isRCAble)
  70. reportBug(Member, MemberType, MemberCXXRD, RD);
  71. }
  72. }
  73. }
  74. }
  75. bool shouldSkipDecl(const RecordDecl *RD) const {
  76. if (!RD->isThisDeclarationADefinition())
  77. return true;
  78. if (RD->isImplicit())
  79. return true;
  80. if (RD->isLambda())
  81. return true;
  82. // If the construct doesn't have a source file, then it's not something
  83. // we want to diagnose.
  84. const auto RDLocation = RD->getLocation();
  85. if (!RDLocation.isValid())
  86. return true;
  87. const auto Kind = RD->getTagKind();
  88. // FIMXE: Should we check union members too?
  89. if (Kind != TTK_Struct && Kind != TTK_Class)
  90. return true;
  91. // Ignore CXXRecords that come from system headers.
  92. if (BR->getSourceManager().isInSystemHeader(RDLocation))
  93. return true;
  94. // Ref-counted smartpointers actually have raw-pointer to uncounted type as
  95. // a member but we trust them to handle it correctly.
  96. auto CXXRD = llvm::dyn_cast_or_null<CXXRecordDecl>(RD);
  97. if (CXXRD)
  98. return isRefCounted(CXXRD);
  99. return false;
  100. }
  101. void reportBug(const FieldDecl *Member, const Type *MemberType,
  102. const CXXRecordDecl *MemberCXXRD,
  103. const RecordDecl *ClassCXXRD) const {
  104. assert(Member);
  105. assert(MemberType);
  106. assert(MemberCXXRD);
  107. SmallString<100> Buf;
  108. llvm::raw_svector_ostream Os(Buf);
  109. Os << "Member variable ";
  110. printQuotedName(Os, Member);
  111. Os << " in ";
  112. printQuotedQualifiedName(Os, ClassCXXRD);
  113. Os << " is a "
  114. << (isa<PointerType>(MemberType) ? "raw pointer" : "reference")
  115. << " to ref-countable type ";
  116. printQuotedQualifiedName(Os, MemberCXXRD);
  117. Os << "; member variables must be ref-counted.";
  118. PathDiagnosticLocation BSLoc(Member->getSourceRange().getBegin(),
  119. BR->getSourceManager());
  120. auto Report = std::make_unique<BasicBugReport>(Bug, Os.str(), BSLoc);
  121. Report->addRange(Member->getSourceRange());
  122. BR->emitReport(std::move(Report));
  123. }
  124. };
  125. } // namespace
  126. void ento::registerNoUncountedMemberChecker(CheckerManager &Mgr) {
  127. Mgr.registerChecker<NoUncountedMemberChecker>();
  128. }
  129. bool ento::shouldRegisterNoUncountedMemberChecker(
  130. const CheckerManager &Mgr) {
  131. return true;
  132. }