123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337 |
- //=== InnerPointerChecker.cpp -------------------------------------*- C++ -*--//
- //
- // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
- // See https://llvm.org/LICENSE.txt for license information.
- // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
- //
- //===----------------------------------------------------------------------===//
- //
- // This file defines a check that marks a raw pointer to a C++ container's
- // inner buffer released when the object is destroyed. This information can
- // be used by MallocChecker to detect use-after-free problems.
- //
- //===----------------------------------------------------------------------===//
- #include "AllocationState.h"
- #include "InterCheckerAPI.h"
- #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
- #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
- #include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h"
- #include "clang/StaticAnalyzer/Core/Checker.h"
- #include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h"
- #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
- #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
- using namespace clang;
- using namespace ento;
- // Associate container objects with a set of raw pointer symbols.
- REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(PtrSet, SymbolRef)
- REGISTER_MAP_WITH_PROGRAMSTATE(RawPtrMap, const MemRegion *, PtrSet)
- namespace {
- class InnerPointerChecker
- : public Checker<check::DeadSymbols, check::PostCall> {
- CallDescription AppendFn, AssignFn, AddressofFn, ClearFn, CStrFn, DataFn,
- DataMemberFn, EraseFn, InsertFn, PopBackFn, PushBackFn, ReplaceFn,
- ReserveFn, ResizeFn, ShrinkToFitFn, SwapFn;
- public:
- class InnerPointerBRVisitor : public BugReporterVisitor {
- SymbolRef PtrToBuf;
- public:
- InnerPointerBRVisitor(SymbolRef Sym) : PtrToBuf(Sym) {}
- static void *getTag() {
- static int Tag = 0;
- return &Tag;
- }
- void Profile(llvm::FoldingSetNodeID &ID) const override {
- ID.AddPointer(getTag());
- }
- virtual PathDiagnosticPieceRef
- VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
- PathSensitiveBugReport &BR) override;
- // FIXME: Scan the map once in the visitor's constructor and do a direct
- // lookup by region.
- bool isSymbolTracked(ProgramStateRef State, SymbolRef Sym) {
- RawPtrMapTy Map = State->get<RawPtrMap>();
- for (const auto &Entry : Map) {
- if (Entry.second.contains(Sym))
- return true;
- }
- return false;
- }
- };
- InnerPointerChecker()
- : AppendFn({"std", "basic_string", "append"}),
- AssignFn({"std", "basic_string", "assign"}),
- AddressofFn({"std", "addressof"}),
- ClearFn({"std", "basic_string", "clear"}),
- CStrFn({"std", "basic_string", "c_str"}), DataFn({"std", "data"}, 1),
- DataMemberFn({"std", "basic_string", "data"}),
- EraseFn({"std", "basic_string", "erase"}),
- InsertFn({"std", "basic_string", "insert"}),
- PopBackFn({"std", "basic_string", "pop_back"}),
- PushBackFn({"std", "basic_string", "push_back"}),
- ReplaceFn({"std", "basic_string", "replace"}),
- ReserveFn({"std", "basic_string", "reserve"}),
- ResizeFn({"std", "basic_string", "resize"}),
- ShrinkToFitFn({"std", "basic_string", "shrink_to_fit"}),
- SwapFn({"std", "basic_string", "swap"}) {}
- /// Check whether the called member function potentially invalidates
- /// pointers referring to the container object's inner buffer.
- bool isInvalidatingMemberFunction(const CallEvent &Call) const;
- /// Check whether the called function returns a raw inner pointer.
- bool isInnerPointerAccessFunction(const CallEvent &Call) const;
- /// Mark pointer symbols associated with the given memory region released
- /// in the program state.
- void markPtrSymbolsReleased(const CallEvent &Call, ProgramStateRef State,
- const MemRegion *ObjRegion,
- CheckerContext &C) const;
- /// Standard library functions that take a non-const `basic_string` argument by
- /// reference may invalidate its inner pointers. Check for these cases and
- /// mark the pointers released.
- void checkFunctionArguments(const CallEvent &Call, ProgramStateRef State,
- CheckerContext &C) const;
- /// Record the connection between raw pointers referring to a container
- /// object's inner buffer and the object's memory region in the program state.
- /// Mark potentially invalidated pointers released.
- void checkPostCall(const CallEvent &Call, CheckerContext &C) const;
- /// Clean up the program state map.
- void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
- };
- } // end anonymous namespace
- bool InnerPointerChecker::isInvalidatingMemberFunction(
- const CallEvent &Call) const {
- if (const auto *MemOpCall = dyn_cast<CXXMemberOperatorCall>(&Call)) {
- OverloadedOperatorKind Opc = MemOpCall->getOriginExpr()->getOperator();
- if (Opc == OO_Equal || Opc == OO_PlusEqual)
- return true;
- return false;
- }
- return isa<CXXDestructorCall>(Call) ||
- matchesAny(Call, AppendFn, AssignFn, ClearFn, EraseFn, InsertFn,
- PopBackFn, PushBackFn, ReplaceFn, ReserveFn, ResizeFn,
- ShrinkToFitFn, SwapFn);
- }
- bool InnerPointerChecker::isInnerPointerAccessFunction(
- const CallEvent &Call) const {
- return matchesAny(Call, CStrFn, DataFn, DataMemberFn);
- }
- void InnerPointerChecker::markPtrSymbolsReleased(const CallEvent &Call,
- ProgramStateRef State,
- const MemRegion *MR,
- CheckerContext &C) const {
- if (const PtrSet *PS = State->get<RawPtrMap>(MR)) {
- const Expr *Origin = Call.getOriginExpr();
- for (const auto Symbol : *PS) {
- // NOTE: `Origin` may be null, and will be stored so in the symbol's
- // `RefState` in MallocChecker's `RegionState` program state map.
- State = allocation_state::markReleased(State, Symbol, Origin);
- }
- State = State->remove<RawPtrMap>(MR);
- C.addTransition(State);
- return;
- }
- }
- void InnerPointerChecker::checkFunctionArguments(const CallEvent &Call,
- ProgramStateRef State,
- CheckerContext &C) const {
- if (const auto *FC = dyn_cast<AnyFunctionCall>(&Call)) {
- const FunctionDecl *FD = FC->getDecl();
- if (!FD || !FD->isInStdNamespace())
- return;
- for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) {
- QualType ParamTy = FD->getParamDecl(I)->getType();
- if (!ParamTy->isReferenceType() ||
- ParamTy->getPointeeType().isConstQualified())
- continue;
- // In case of member operator calls, `this` is counted as an
- // argument but not as a parameter.
- bool isaMemberOpCall = isa<CXXMemberOperatorCall>(FC);
- unsigned ArgI = isaMemberOpCall ? I+1 : I;
- SVal Arg = FC->getArgSVal(ArgI);
- const auto *ArgRegion =
- dyn_cast_or_null<TypedValueRegion>(Arg.getAsRegion());
- if (!ArgRegion)
- continue;
- // std::addressof function accepts a non-const reference as an argument,
- // but doesn't modify it.
- if (AddressofFn.matches(Call))
- continue;
- markPtrSymbolsReleased(Call, State, ArgRegion, C);
- }
- }
- }
- // [string.require]
- //
- // "References, pointers, and iterators referring to the elements of a
- // basic_string sequence may be invalidated by the following uses of that
- // basic_string object:
- //
- // -- As an argument to any standard library function taking a reference
- // to non-const basic_string as an argument. For example, as an argument to
- // non-member functions swap(), operator>>(), and getline(), or as an argument
- // to basic_string::swap().
- //
- // -- Calling non-const member functions, except operator[], at, front, back,
- // begin, rbegin, end, and rend."
- void InnerPointerChecker::checkPostCall(const CallEvent &Call,
- CheckerContext &C) const {
- ProgramStateRef State = C.getState();
- // TODO: Do we need these to be typed?
- const TypedValueRegion *ObjRegion = nullptr;
- if (const auto *ICall = dyn_cast<CXXInstanceCall>(&Call)) {
- ObjRegion = dyn_cast_or_null<TypedValueRegion>(
- ICall->getCXXThisVal().getAsRegion());
- // Check [string.require] / second point.
- if (isInvalidatingMemberFunction(Call)) {
- markPtrSymbolsReleased(Call, State, ObjRegion, C);
- return;
- }
- }
- if (isInnerPointerAccessFunction(Call)) {
- if (isa<SimpleFunctionCall>(Call)) {
- // NOTE: As of now, we only have one free access function: std::data.
- // If we add more functions like this in the list, hardcoded
- // argument index should be changed.
- ObjRegion =
- dyn_cast_or_null<TypedValueRegion>(Call.getArgSVal(0).getAsRegion());
- }
- if (!ObjRegion)
- return;
- SVal RawPtr = Call.getReturnValue();
- if (SymbolRef Sym = RawPtr.getAsSymbol(/*IncludeBaseRegions=*/true)) {
- // Start tracking this raw pointer by adding it to the set of symbols
- // associated with this container object in the program state map.
- PtrSet::Factory &F = State->getStateManager().get_context<PtrSet>();
- const PtrSet *SetPtr = State->get<RawPtrMap>(ObjRegion);
- PtrSet Set = SetPtr ? *SetPtr : F.getEmptySet();
- assert(C.wasInlined || !Set.contains(Sym));
- Set = F.add(Set, Sym);
- State = State->set<RawPtrMap>(ObjRegion, Set);
- C.addTransition(State);
- }
- return;
- }
- // Check [string.require] / first point.
- checkFunctionArguments(Call, State, C);
- }
- void InnerPointerChecker::checkDeadSymbols(SymbolReaper &SymReaper,
- CheckerContext &C) const {
- ProgramStateRef State = C.getState();
- PtrSet::Factory &F = State->getStateManager().get_context<PtrSet>();
- RawPtrMapTy RPM = State->get<RawPtrMap>();
- for (const auto &Entry : RPM) {
- if (!SymReaper.isLiveRegion(Entry.first)) {
- // Due to incomplete destructor support, some dead regions might
- // remain in the program state map. Clean them up.
- State = State->remove<RawPtrMap>(Entry.first);
- }
- if (const PtrSet *OldSet = State->get<RawPtrMap>(Entry.first)) {
- PtrSet CleanedUpSet = *OldSet;
- for (const auto Symbol : Entry.second) {
- if (!SymReaper.isLive(Symbol))
- CleanedUpSet = F.remove(CleanedUpSet, Symbol);
- }
- State = CleanedUpSet.isEmpty()
- ? State->remove<RawPtrMap>(Entry.first)
- : State->set<RawPtrMap>(Entry.first, CleanedUpSet);
- }
- }
- C.addTransition(State);
- }
- namespace clang {
- namespace ento {
- namespace allocation_state {
- std::unique_ptr<BugReporterVisitor> getInnerPointerBRVisitor(SymbolRef Sym) {
- return std::make_unique<InnerPointerChecker::InnerPointerBRVisitor>(Sym);
- }
- const MemRegion *getContainerObjRegion(ProgramStateRef State, SymbolRef Sym) {
- RawPtrMapTy Map = State->get<RawPtrMap>();
- for (const auto &Entry : Map) {
- if (Entry.second.contains(Sym)) {
- return Entry.first;
- }
- }
- return nullptr;
- }
- } // end namespace allocation_state
- } // end namespace ento
- } // end namespace clang
- PathDiagnosticPieceRef InnerPointerChecker::InnerPointerBRVisitor::VisitNode(
- const ExplodedNode *N, BugReporterContext &BRC, PathSensitiveBugReport &) {
- if (!isSymbolTracked(N->getState(), PtrToBuf) ||
- isSymbolTracked(N->getFirstPred()->getState(), PtrToBuf))
- return nullptr;
- const Stmt *S = N->getStmtForDiagnostics();
- if (!S)
- return nullptr;
- const MemRegion *ObjRegion =
- allocation_state::getContainerObjRegion(N->getState(), PtrToBuf);
- const auto *TypedRegion = cast<TypedValueRegion>(ObjRegion);
- QualType ObjTy = TypedRegion->getValueType();
- SmallString<256> Buf;
- llvm::raw_svector_ostream OS(Buf);
- OS << "Pointer to inner buffer of '" << ObjTy.getAsString()
- << "' obtained here";
- PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
- N->getLocationContext());
- return std::make_shared<PathDiagnosticEventPiece>(Pos, OS.str(), true);
- }
- void ento::registerInnerPointerChecker(CheckerManager &Mgr) {
- registerInnerPointerCheckerAux(Mgr);
- Mgr.registerChecker<InnerPointerChecker>();
- }
- bool ento::shouldRegisterInnerPointerChecker(const CheckerManager &mgr) {
- return true;
- }
|