ydb/yql/essentials/public/fastcheck/linter_ut.cpp

#include "linter.h"
#include <library/cpp/testing/unittest/registar.h>

using namespace NYql;
using namespace NYql::NFastCheck;

Y_UNIT_TEST_SUITE(TLinterTests) {
    Y_UNIT_TEST(ListChecksResult) {
        auto res = ListChecks();
        UNIT_ASSERT(!res.empty());
    }

    Y_UNIT_TEST(DummyLexerSExpr) {
        TChecksRequest request;
        request.Program = "((return world))";
        request.Syntax = ESyntax::SExpr;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "lexer"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "lexer");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(DummyLexerPg) {
        TChecksRequest request;
        request.Program = "select 1::text";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "lexer"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "lexer");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(GoodLexerYql) {
        TChecksRequest request;
        request.Program = "1";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "lexer"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "lexer");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(BadLexerYql) {
        TChecksRequest request;
        request.Program = "Я";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "lexer"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "lexer");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(DummyFormatSExpr) {
        TChecksRequest request;
        request.Program = "((return world))";
        request.Syntax = ESyntax::SExpr;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "format"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "format");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(DummyFormatPg) {
        TChecksRequest request;
        request.Program = "select 1::text";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "format"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "format");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(GoodFormatYql) {
        TChecksRequest request;
        request.Program = "SELECT\n    1\n;\n";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "format"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "format");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(UnparsedFormatYql) {
        TChecksRequest request;
        request.Program = "select1\n";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "format"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "format");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(BadFormatYql) {
        TChecksRequest request;
        request.Program = "select 1";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "format"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "format");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(ContextForBadFormatYql) {
        TChecksRequest request;
        request.Program = "SELECT\n    'привет',1;";
        request.File = "myFile.sql";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "format"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "format");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 1);
        const auto& pos = res.Checks[0].Issues.back().Position;
        UNIT_ASSERT_VALUES_EQUAL(pos.Row, 2);
        UNIT_ASSERT_VALUES_EQUAL(pos.Column, 13);
    }

    Y_UNIT_TEST(GoodParserSExpr) {
        TChecksRequest request;
        request.Program = "((return world))";
        request.Syntax = ESyntax::SExpr;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(BadParserSExpr) {
        TChecksRequest request;
        request.Program = ")";
        request.Syntax = ESyntax::SExpr;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(GoodParserPg) {
        TChecksRequest request;
        request.Program = "select 1::text";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(BadParserPg) {
        TChecksRequest request;
        request.Program = "sel";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(DummyParserPg) {
        TChecksRequest request;
        request.Program = "select 1::text";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(GoodParserYql) {
        TChecksRequest request;
        request.Program = "SELECT 1";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(BadParserYql) {
        TChecksRequest request;
        request.Program = "1";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "parser"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "parser");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(DummyTranslatorSExpr) {
        TChecksRequest request;
        request.Program = "((return world))";
        request.Syntax = ESyntax::SExpr;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(res.Checks[0].Success);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(), 0);
    }

    Y_UNIT_TEST(GoodTranslatorPg) {
        TChecksRequest request;
        request.ClusterMapping["plato"] = TString(YtProviderName);
        request.Program = "select * from plato.\"Input\"";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(BadTranslatorPg) {
        TChecksRequest request;
        request.Program = "select * from \"Input\"";
        request.Syntax = ESyntax::PG;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(GoodTranslatorYql) {
        TChecksRequest request;
        request.ClusterMapping["plato"] = TString(YtProviderName);
        request.Program = "use plato; select * from Input";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(BadTranslatorYql) {
        TChecksRequest request;
        request.Program = "select ListLengggth([1,2,3])";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(AllowYqlExportsForLibrary) {
        TChecksRequest request;
        request.Program = "$a = 1; export $a";
        request.Mode = EMode::Library;
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(AllowYqlExportsForDefault) {
        TChecksRequest request;
        request.Program = "$a = 1; export $a";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(DisallowYqlExportsForMain) {
        TChecksRequest request;
        request.Program = "$a = 1; export $a";
        request.Syntax = ESyntax::YQL;
        request.Mode = EMode::Main;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(DisallowYqlExportsForView) {
        TChecksRequest request;
        request.Program = "$a = 1; export $a";
        request.Syntax = ESyntax::YQL;
        request.Mode = EMode::View;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(GoodYqlView) {
        TChecksRequest request;
        request.Program = "select 1";
        request.Syntax = ESyntax::YQL;
        request.Mode = EMode::View;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
    }

    Y_UNIT_TEST(BadYqlView) {
        TChecksRequest request;
        request.Program = "select 1;select 2";
        request.Syntax = ESyntax::YQL;
        request.Mode = EMode::View;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "translator"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "translator");
        UNIT_ASSERT(!res.Checks[0].Success);
        Cerr << res.Checks[0].Issues.ToString();
        UNIT_ASSERT(res.Checks[0].Issues.Size() > 0);
    }

    Y_UNIT_TEST(AllChecks) {
        TChecksRequest request;
        request.Program = "SELECT\n    1\n;\n";
        request.Syntax = ESyntax::YQL;
        auto res = RunChecks(request);
        TSet<TString> passedChecks;
        for (const auto& r : res.Checks) {
            Cerr << r.CheckName << "\n";
            UNIT_ASSERT(r.Success);
            Cerr << r.Issues.ToString();
            UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
            passedChecks.insert(r.CheckName);
        }

        UNIT_ASSERT_VALUES_EQUAL(passedChecks, ListChecks());
    }

    Y_UNIT_TEST(AllChecksByStar) {
        TChecksRequest request;
        request.Program = "SELECT\n    1\n;\n";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.CheckNameGlob = "*"});
        auto res = RunChecks(request);
        TSet<TString> passedChecks;
        for (const auto& r : res.Checks) {
            Cerr << r.CheckName << "\n";
            UNIT_ASSERT(r.Success);
            Cerr << r.Issues.ToString();
            UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].Issues.Size(),0);
            passedChecks.insert(r.CheckName);
        }

        UNIT_ASSERT_VALUES_EQUAL(passedChecks, ListChecks());
    }

    Y_UNIT_TEST(NoChecksByStarWithSecondFilter) {
        TChecksRequest request;
        request.Program = "1";
        request.Syntax = ESyntax::YQL;
        request.Filters.ConstructInPlace();
        request.Filters->push_back(TCheckFilter{.Include = false, .CheckNameGlob = "*"});
        request.Filters->push_back(TCheckFilter{.Include = true, .CheckNameGlob = "lexer"});
        auto res = RunChecks(request);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks.size(), 1);
        UNIT_ASSERT_VALUES_EQUAL(res.Checks[0].CheckName, "lexer");
        UNIT_ASSERT(res.Checks[0].Success);
    }
}