12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507 |
- //===- ObjCARCOpts.cpp - ObjC ARC Optimization ----------------------------===//
- //
- // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
- // See https://llvm.org/LICENSE.txt for license information.
- // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
- //
- //===----------------------------------------------------------------------===//
- //
- /// \file
- /// This file defines ObjC ARC optimizations. ARC stands for Automatic
- /// Reference Counting and is a system for managing reference counts for objects
- /// in Objective C.
- ///
- /// The optimizations performed include elimination of redundant, partially
- /// redundant, and inconsequential reference count operations, elimination of
- /// redundant weak pointer operations, and numerous minor simplifications.
- ///
- /// WARNING: This file knows about certain library functions. It recognizes them
- /// by name, and hardwires knowledge of their semantics.
- ///
- /// WARNING: This file knows about how certain Objective-C library functions are
- /// used. Naive LLVM IR transformations which would otherwise be
- /// behavior-preserving may break these assumptions.
- //
- //===----------------------------------------------------------------------===//
- #include "ARCRuntimeEntryPoints.h"
- #include "BlotMapVector.h"
- #include "DependencyAnalysis.h"
- #include "ObjCARC.h"
- #include "ProvenanceAnalysis.h"
- #include "PtrState.h"
- #include "llvm/ADT/DenseMap.h"
- #include "llvm/ADT/STLExtras.h"
- #include "llvm/ADT/SmallPtrSet.h"
- #include "llvm/ADT/SmallVector.h"
- #include "llvm/ADT/Statistic.h"
- #include "llvm/Analysis/AliasAnalysis.h"
- #include "llvm/Analysis/EHPersonalities.h"
- #include "llvm/Analysis/ObjCARCAliasAnalysis.h"
- #include "llvm/Analysis/ObjCARCAnalysisUtils.h"
- #include "llvm/Analysis/ObjCARCInstKind.h"
- #include "llvm/Analysis/ObjCARCUtil.h"
- #include "llvm/IR/BasicBlock.h"
- #include "llvm/IR/CFG.h"
- #include "llvm/IR/Constant.h"
- #include "llvm/IR/Constants.h"
- #include "llvm/IR/DerivedTypes.h"
- #include "llvm/IR/Function.h"
- #include "llvm/IR/GlobalVariable.h"
- #include "llvm/IR/InstIterator.h"
- #include "llvm/IR/InstrTypes.h"
- #include "llvm/IR/Instruction.h"
- #include "llvm/IR/Instructions.h"
- #include "llvm/IR/LLVMContext.h"
- #include "llvm/IR/Metadata.h"
- #include "llvm/IR/Type.h"
- #include "llvm/IR/User.h"
- #include "llvm/IR/Value.h"
- #include "llvm/Support/Casting.h"
- #include "llvm/Support/CommandLine.h"
- #include "llvm/Support/Compiler.h"
- #include "llvm/Support/Debug.h"
- #include "llvm/Support/ErrorHandling.h"
- #include "llvm/Support/raw_ostream.h"
- #include "llvm/Transforms/ObjCARC.h"
- #include <cassert>
- #include <iterator>
- #include <utility>
- using namespace llvm;
- using namespace llvm::objcarc;
- #define DEBUG_TYPE "objc-arc-opts"
- static cl::opt<unsigned> MaxPtrStates("arc-opt-max-ptr-states",
- cl::Hidden,
- cl::desc("Maximum number of ptr states the optimizer keeps track of"),
- cl::init(4095));
- /// \defgroup ARCUtilities Utility declarations/definitions specific to ARC.
- /// @{
- /// This is similar to GetRCIdentityRoot but it stops as soon
- /// as it finds a value with multiple uses.
- static const Value *FindSingleUseIdentifiedObject(const Value *Arg) {
- // ConstantData (like ConstantPointerNull and UndefValue) is used across
- // modules. It's never a single-use value.
- if (isa<ConstantData>(Arg))
- return nullptr;
- if (Arg->hasOneUse()) {
- if (const BitCastInst *BC = dyn_cast<BitCastInst>(Arg))
- return FindSingleUseIdentifiedObject(BC->getOperand(0));
- if (const GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Arg))
- if (GEP->hasAllZeroIndices())
- return FindSingleUseIdentifiedObject(GEP->getPointerOperand());
- if (IsForwarding(GetBasicARCInstKind(Arg)))
- return FindSingleUseIdentifiedObject(
- cast<CallInst>(Arg)->getArgOperand(0));
- if (!IsObjCIdentifiedObject(Arg))
- return nullptr;
- return Arg;
- }
- // If we found an identifiable object but it has multiple uses, but they are
- // trivial uses, we can still consider this to be a single-use value.
- if (IsObjCIdentifiedObject(Arg)) {
- for (const User *U : Arg->users())
- if (!U->use_empty() || GetRCIdentityRoot(U) != Arg)
- return nullptr;
- return Arg;
- }
- return nullptr;
- }
- /// @}
- ///
- /// \defgroup ARCOpt ARC Optimization.
- /// @{
- // TODO: On code like this:
- //
- // objc_retain(%x)
- // stuff_that_cannot_release()
- // objc_autorelease(%x)
- // stuff_that_cannot_release()
- // objc_retain(%x)
- // stuff_that_cannot_release()
- // objc_autorelease(%x)
- //
- // The second retain and autorelease can be deleted.
- // TODO: It should be possible to delete
- // objc_autoreleasePoolPush and objc_autoreleasePoolPop
- // pairs if nothing is actually autoreleased between them. Also, autorelease
- // calls followed by objc_autoreleasePoolPop calls (perhaps in ObjC++ code
- // after inlining) can be turned into plain release calls.
- // TODO: Critical-edge splitting. If the optimial insertion point is
- // a critical edge, the current algorithm has to fail, because it doesn't
- // know how to split edges. It should be possible to make the optimizer
- // think in terms of edges, rather than blocks, and then split critical
- // edges on demand.
- // TODO: OptimizeSequences could generalized to be Interprocedural.
- // TODO: Recognize that a bunch of other objc runtime calls have
- // non-escaping arguments and non-releasing arguments, and may be
- // non-autoreleasing.
- // TODO: Sink autorelease calls as far as possible. Unfortunately we
- // usually can't sink them past other calls, which would be the main
- // case where it would be useful.
- // TODO: The pointer returned from objc_loadWeakRetained is retained.
- // TODO: Delete release+retain pairs (rare).
- STATISTIC(NumNoops, "Number of no-op objc calls eliminated");
- STATISTIC(NumPartialNoops, "Number of partially no-op objc calls eliminated");
- STATISTIC(NumAutoreleases,"Number of autoreleases converted to releases");
- STATISTIC(NumRets, "Number of return value forwarding "
- "retain+autoreleases eliminated");
- STATISTIC(NumRRs, "Number of retain+release paths eliminated");
- STATISTIC(NumPeeps, "Number of calls peephole-optimized");
- #ifndef NDEBUG
- STATISTIC(NumRetainsBeforeOpt,
- "Number of retains before optimization");
- STATISTIC(NumReleasesBeforeOpt,
- "Number of releases before optimization");
- STATISTIC(NumRetainsAfterOpt,
- "Number of retains after optimization");
- STATISTIC(NumReleasesAfterOpt,
- "Number of releases after optimization");
- #endif
- namespace {
- /// Per-BasicBlock state.
- class BBState {
- /// The number of unique control paths from the entry which can reach this
- /// block.
- unsigned TopDownPathCount = 0;
- /// The number of unique control paths to exits from this block.
- unsigned BottomUpPathCount = 0;
- /// The top-down traversal uses this to record information known about a
- /// pointer at the bottom of each block.
- BlotMapVector<const Value *, TopDownPtrState> PerPtrTopDown;
- /// The bottom-up traversal uses this to record information known about a
- /// pointer at the top of each block.
- BlotMapVector<const Value *, BottomUpPtrState> PerPtrBottomUp;
- /// Effective predecessors of the current block ignoring ignorable edges and
- /// ignored backedges.
- SmallVector<BasicBlock *, 2> Preds;
- /// Effective successors of the current block ignoring ignorable edges and
- /// ignored backedges.
- SmallVector<BasicBlock *, 2> Succs;
- public:
- static const unsigned OverflowOccurredValue;
- BBState() = default;
- using top_down_ptr_iterator = decltype(PerPtrTopDown)::iterator;
- using const_top_down_ptr_iterator = decltype(PerPtrTopDown)::const_iterator;
- top_down_ptr_iterator top_down_ptr_begin() { return PerPtrTopDown.begin(); }
- top_down_ptr_iterator top_down_ptr_end() { return PerPtrTopDown.end(); }
- const_top_down_ptr_iterator top_down_ptr_begin() const {
- return PerPtrTopDown.begin();
- }
- const_top_down_ptr_iterator top_down_ptr_end() const {
- return PerPtrTopDown.end();
- }
- bool hasTopDownPtrs() const {
- return !PerPtrTopDown.empty();
- }
- unsigned top_down_ptr_list_size() const {
- return std::distance(top_down_ptr_begin(), top_down_ptr_end());
- }
- using bottom_up_ptr_iterator = decltype(PerPtrBottomUp)::iterator;
- using const_bottom_up_ptr_iterator =
- decltype(PerPtrBottomUp)::const_iterator;
- bottom_up_ptr_iterator bottom_up_ptr_begin() {
- return PerPtrBottomUp.begin();
- }
- bottom_up_ptr_iterator bottom_up_ptr_end() { return PerPtrBottomUp.end(); }
- const_bottom_up_ptr_iterator bottom_up_ptr_begin() const {
- return PerPtrBottomUp.begin();
- }
- const_bottom_up_ptr_iterator bottom_up_ptr_end() const {
- return PerPtrBottomUp.end();
- }
- bool hasBottomUpPtrs() const {
- return !PerPtrBottomUp.empty();
- }
- unsigned bottom_up_ptr_list_size() const {
- return std::distance(bottom_up_ptr_begin(), bottom_up_ptr_end());
- }
- /// Mark this block as being an entry block, which has one path from the
- /// entry by definition.
- void SetAsEntry() { TopDownPathCount = 1; }
- /// Mark this block as being an exit block, which has one path to an exit by
- /// definition.
- void SetAsExit() { BottomUpPathCount = 1; }
- /// Attempt to find the PtrState object describing the top down state for
- /// pointer Arg. Return a new initialized PtrState describing the top down
- /// state for Arg if we do not find one.
- TopDownPtrState &getPtrTopDownState(const Value *Arg) {
- return PerPtrTopDown[Arg];
- }
- /// Attempt to find the PtrState object describing the bottom up state for
- /// pointer Arg. Return a new initialized PtrState describing the bottom up
- /// state for Arg if we do not find one.
- BottomUpPtrState &getPtrBottomUpState(const Value *Arg) {
- return PerPtrBottomUp[Arg];
- }
- /// Attempt to find the PtrState object describing the bottom up state for
- /// pointer Arg.
- bottom_up_ptr_iterator findPtrBottomUpState(const Value *Arg) {
- return PerPtrBottomUp.find(Arg);
- }
- void clearBottomUpPointers() {
- PerPtrBottomUp.clear();
- }
- void clearTopDownPointers() {
- PerPtrTopDown.clear();
- }
- void InitFromPred(const BBState &Other);
- void InitFromSucc(const BBState &Other);
- void MergePred(const BBState &Other);
- void MergeSucc(const BBState &Other);
- /// Compute the number of possible unique paths from an entry to an exit
- /// which pass through this block. This is only valid after both the
- /// top-down and bottom-up traversals are complete.
- ///
- /// Returns true if overflow occurred. Returns false if overflow did not
- /// occur.
- bool GetAllPathCountWithOverflow(unsigned &PathCount) const {
- if (TopDownPathCount == OverflowOccurredValue ||
- BottomUpPathCount == OverflowOccurredValue)
- return true;
- unsigned long long Product =
- (unsigned long long)TopDownPathCount*BottomUpPathCount;
- // Overflow occurred if any of the upper bits of Product are set or if all
- // the lower bits of Product are all set.
- return (Product >> 32) ||
- ((PathCount = Product) == OverflowOccurredValue);
- }
- // Specialized CFG utilities.
- using edge_iterator = SmallVectorImpl<BasicBlock *>::const_iterator;
- edge_iterator pred_begin() const { return Preds.begin(); }
- edge_iterator pred_end() const { return Preds.end(); }
- edge_iterator succ_begin() const { return Succs.begin(); }
- edge_iterator succ_end() const { return Succs.end(); }
- void addSucc(BasicBlock *Succ) { Succs.push_back(Succ); }
- void addPred(BasicBlock *Pred) { Preds.push_back(Pred); }
- bool isExit() const { return Succs.empty(); }
- };
- } // end anonymous namespace
- const unsigned BBState::OverflowOccurredValue = 0xffffffff;
- namespace llvm {
- raw_ostream &operator<<(raw_ostream &OS,
- BBState &BBState) LLVM_ATTRIBUTE_UNUSED;
- } // end namespace llvm
- void BBState::InitFromPred(const BBState &Other) {
- PerPtrTopDown = Other.PerPtrTopDown;
- TopDownPathCount = Other.TopDownPathCount;
- }
- void BBState::InitFromSucc(const BBState &Other) {
- PerPtrBottomUp = Other.PerPtrBottomUp;
- BottomUpPathCount = Other.BottomUpPathCount;
- }
- /// The top-down traversal uses this to merge information about predecessors to
- /// form the initial state for a new block.
- void BBState::MergePred(const BBState &Other) {
- if (TopDownPathCount == OverflowOccurredValue)
- return;
- // Other.TopDownPathCount can be 0, in which case it is either dead or a
- // loop backedge. Loop backedges are special.
- TopDownPathCount += Other.TopDownPathCount;
- // In order to be consistent, we clear the top down pointers when by adding
- // TopDownPathCount becomes OverflowOccurredValue even though "true" overflow
- // has not occurred.
- if (TopDownPathCount == OverflowOccurredValue) {
- clearTopDownPointers();
- return;
- }
- // Check for overflow. If we have overflow, fall back to conservative
- // behavior.
- if (TopDownPathCount < Other.TopDownPathCount) {
- TopDownPathCount = OverflowOccurredValue;
- clearTopDownPointers();
- return;
- }
- // For each entry in the other set, if our set has an entry with the same key,
- // merge the entries. Otherwise, copy the entry and merge it with an empty
- // entry.
- for (auto MI = Other.top_down_ptr_begin(), ME = Other.top_down_ptr_end();
- MI != ME; ++MI) {
- auto Pair = PerPtrTopDown.insert(*MI);
- Pair.first->second.Merge(Pair.second ? TopDownPtrState() : MI->second,
- /*TopDown=*/true);
- }
- // For each entry in our set, if the other set doesn't have an entry with the
- // same key, force it to merge with an empty entry.
- for (auto MI = top_down_ptr_begin(), ME = top_down_ptr_end(); MI != ME; ++MI)
- if (Other.PerPtrTopDown.find(MI->first) == Other.PerPtrTopDown.end())
- MI->second.Merge(TopDownPtrState(), /*TopDown=*/true);
- }
- /// The bottom-up traversal uses this to merge information about successors to
- /// form the initial state for a new block.
- void BBState::MergeSucc(const BBState &Other) {
- if (BottomUpPathCount == OverflowOccurredValue)
- return;
- // Other.BottomUpPathCount can be 0, in which case it is either dead or a
- // loop backedge. Loop backedges are special.
- BottomUpPathCount += Other.BottomUpPathCount;
- // In order to be consistent, we clear the top down pointers when by adding
- // BottomUpPathCount becomes OverflowOccurredValue even though "true" overflow
- // has not occurred.
- if (BottomUpPathCount == OverflowOccurredValue) {
- clearBottomUpPointers();
- return;
- }
- // Check for overflow. If we have overflow, fall back to conservative
- // behavior.
- if (BottomUpPathCount < Other.BottomUpPathCount) {
- BottomUpPathCount = OverflowOccurredValue;
- clearBottomUpPointers();
- return;
- }
- // For each entry in the other set, if our set has an entry with the
- // same key, merge the entries. Otherwise, copy the entry and merge
- // it with an empty entry.
- for (auto MI = Other.bottom_up_ptr_begin(), ME = Other.bottom_up_ptr_end();
- MI != ME; ++MI) {
- auto Pair = PerPtrBottomUp.insert(*MI);
- Pair.first->second.Merge(Pair.second ? BottomUpPtrState() : MI->second,
- /*TopDown=*/false);
- }
- // For each entry in our set, if the other set doesn't have an entry
- // with the same key, force it to merge with an empty entry.
- for (auto MI = bottom_up_ptr_begin(), ME = bottom_up_ptr_end(); MI != ME;
- ++MI)
- if (Other.PerPtrBottomUp.find(MI->first) == Other.PerPtrBottomUp.end())
- MI->second.Merge(BottomUpPtrState(), /*TopDown=*/false);
- }
- raw_ostream &llvm::operator<<(raw_ostream &OS, BBState &BBInfo) {
- // Dump the pointers we are tracking.
- OS << " TopDown State:\n";
- if (!BBInfo.hasTopDownPtrs()) {
- LLVM_DEBUG(dbgs() << " NONE!\n");
- } else {
- for (auto I = BBInfo.top_down_ptr_begin(), E = BBInfo.top_down_ptr_end();
- I != E; ++I) {
- const PtrState &P = I->second;
- OS << " Ptr: " << *I->first
- << "\n KnownSafe: " << (P.IsKnownSafe()?"true":"false")
- << "\n ImpreciseRelease: "
- << (P.IsTrackingImpreciseReleases()?"true":"false") << "\n"
- << " HasCFGHazards: "
- << (P.IsCFGHazardAfflicted()?"true":"false") << "\n"
- << " KnownPositive: "
- << (P.HasKnownPositiveRefCount()?"true":"false") << "\n"
- << " Seq: "
- << P.GetSeq() << "\n";
- }
- }
- OS << " BottomUp State:\n";
- if (!BBInfo.hasBottomUpPtrs()) {
- LLVM_DEBUG(dbgs() << " NONE!\n");
- } else {
- for (auto I = BBInfo.bottom_up_ptr_begin(), E = BBInfo.bottom_up_ptr_end();
- I != E; ++I) {
- const PtrState &P = I->second;
- OS << " Ptr: " << *I->first
- << "\n KnownSafe: " << (P.IsKnownSafe()?"true":"false")
- << "\n ImpreciseRelease: "
- << (P.IsTrackingImpreciseReleases()?"true":"false") << "\n"
- << " HasCFGHazards: "
- << (P.IsCFGHazardAfflicted()?"true":"false") << "\n"
- << " KnownPositive: "
- << (P.HasKnownPositiveRefCount()?"true":"false") << "\n"
- << " Seq: "
- << P.GetSeq() << "\n";
- }
- }
- return OS;
- }
- namespace {
- /// The main ARC optimization pass.
- class ObjCARCOpt {
- bool Changed = false;
- bool CFGChanged = false;
- ProvenanceAnalysis PA;
- /// A cache of references to runtime entry point constants.
- ARCRuntimeEntryPoints EP;
- /// A cache of MDKinds that can be passed into other functions to propagate
- /// MDKind identifiers.
- ARCMDKindCache MDKindCache;
- BundledRetainClaimRVs *BundledInsts = nullptr;
- /// A flag indicating whether the optimization that removes or moves
- /// retain/release pairs should be performed.
- bool DisableRetainReleasePairing = false;
- /// Flags which determine whether each of the interesting runtime functions
- /// is in fact used in the current function.
- unsigned UsedInThisFunction;
- DenseMap<BasicBlock *, ColorVector> BlockEHColors;
- bool OptimizeRetainRVCall(Function &F, Instruction *RetainRV);
- void OptimizeAutoreleaseRVCall(Function &F, Instruction *AutoreleaseRV,
- ARCInstKind &Class);
- void OptimizeIndividualCalls(Function &F);
- /// Optimize an individual call, optionally passing the
- /// GetArgRCIdentityRoot if it has already been computed.
- void OptimizeIndividualCallImpl(Function &F, Instruction *Inst,
- ARCInstKind Class, const Value *Arg);
- /// Try to optimize an AutoreleaseRV with a RetainRV or UnsafeClaimRV. If the
- /// optimization occurs, returns true to indicate that the caller should
- /// assume the instructions are dead.
- bool OptimizeInlinedAutoreleaseRVCall(Function &F, Instruction *Inst,
- const Value *&Arg, ARCInstKind Class,
- Instruction *AutoreleaseRV,
- const Value *&AutoreleaseRVArg);
- void CheckForCFGHazards(const BasicBlock *BB,
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BBState &MyStates) const;
- bool VisitInstructionBottomUp(Instruction *Inst, BasicBlock *BB,
- BlotMapVector<Value *, RRInfo> &Retains,
- BBState &MyStates);
- bool VisitBottomUp(BasicBlock *BB,
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains);
- bool VisitInstructionTopDown(
- Instruction *Inst, DenseMap<Value *, RRInfo> &Releases, BBState &MyStates,
- const DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- &ReleaseInsertPtToRCIdentityRoots);
- bool VisitTopDown(
- BasicBlock *BB, DenseMap<const BasicBlock *, BBState> &BBStates,
- DenseMap<Value *, RRInfo> &Releases,
- const DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- &ReleaseInsertPtToRCIdentityRoots);
- bool Visit(Function &F, DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases);
- void MoveCalls(Value *Arg, RRInfo &RetainsToMove, RRInfo &ReleasesToMove,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases,
- SmallVectorImpl<Instruction *> &DeadInsts, Module *M);
- bool PairUpRetainsAndReleases(DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases, Module *M,
- Instruction *Retain,
- SmallVectorImpl<Instruction *> &DeadInsts,
- RRInfo &RetainsToMove, RRInfo &ReleasesToMove,
- Value *Arg, bool KnownSafe,
- bool &AnyPairsCompletelyEliminated);
- bool PerformCodePlacement(DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases, Module *M);
- void OptimizeWeakCalls(Function &F);
- bool OptimizeSequences(Function &F);
- void OptimizeReturns(Function &F);
- template <typename PredicateT>
- static void cloneOpBundlesIf(CallBase *CI,
- SmallVectorImpl<OperandBundleDef> &OpBundles,
- PredicateT Predicate) {
- for (unsigned I = 0, E = CI->getNumOperandBundles(); I != E; ++I) {
- OperandBundleUse B = CI->getOperandBundleAt(I);
- if (Predicate(B))
- OpBundles.emplace_back(B);
- }
- }
- void addOpBundleForFunclet(BasicBlock *BB,
- SmallVectorImpl<OperandBundleDef> &OpBundles) {
- if (!BlockEHColors.empty()) {
- const ColorVector &CV = BlockEHColors.find(BB)->second;
- assert(CV.size() > 0 && "Uncolored block");
- for (BasicBlock *EHPadBB : CV)
- if (auto *EHPad = dyn_cast<FuncletPadInst>(EHPadBB->getFirstNonPHI())) {
- OpBundles.emplace_back("funclet", EHPad);
- return;
- }
- }
- }
- #ifndef NDEBUG
- void GatherStatistics(Function &F, bool AfterOptimization = false);
- #endif
- public:
- void init(Function &F);
- bool run(Function &F, AAResults &AA);
- bool hasCFGChanged() const { return CFGChanged; }
- };
- } // end anonymous namespace
- /// Turn objc_retainAutoreleasedReturnValue into objc_retain if the operand is
- /// not a return value.
- bool
- ObjCARCOpt::OptimizeRetainRVCall(Function &F, Instruction *RetainRV) {
- // Check for the argument being from an immediately preceding call or invoke.
- const Value *Arg = GetArgRCIdentityRoot(RetainRV);
- if (const Instruction *Call = dyn_cast<CallBase>(Arg)) {
- if (Call->getParent() == RetainRV->getParent()) {
- BasicBlock::const_iterator I(Call);
- ++I;
- while (IsNoopInstruction(&*I))
- ++I;
- if (&*I == RetainRV)
- return false;
- } else if (const InvokeInst *II = dyn_cast<InvokeInst>(Call)) {
- BasicBlock *RetainRVParent = RetainRV->getParent();
- if (II->getNormalDest() == RetainRVParent) {
- BasicBlock::const_iterator I = RetainRVParent->begin();
- while (IsNoopInstruction(&*I))
- ++I;
- if (&*I == RetainRV)
- return false;
- }
- }
- }
- assert(!BundledInsts->contains(RetainRV) &&
- "a bundled retainRV's argument should be a call");
- // Turn it to a plain objc_retain.
- Changed = true;
- ++NumPeeps;
- LLVM_DEBUG(dbgs() << "Transforming objc_retainAutoreleasedReturnValue => "
- "objc_retain since the operand is not a return value.\n"
- "Old = "
- << *RetainRV << "\n");
- Function *NewDecl = EP.get(ARCRuntimeEntryPointKind::Retain);
- cast<CallInst>(RetainRV)->setCalledFunction(NewDecl);
- LLVM_DEBUG(dbgs() << "New = " << *RetainRV << "\n");
- return false;
- }
- bool ObjCARCOpt::OptimizeInlinedAutoreleaseRVCall(
- Function &F, Instruction *Inst, const Value *&Arg, ARCInstKind Class,
- Instruction *AutoreleaseRV, const Value *&AutoreleaseRVArg) {
- if (BundledInsts->contains(Inst))
- return false;
- // Must be in the same basic block.
- assert(Inst->getParent() == AutoreleaseRV->getParent());
- // Must operate on the same root.
- Arg = GetArgRCIdentityRoot(Inst);
- AutoreleaseRVArg = GetArgRCIdentityRoot(AutoreleaseRV);
- if (Arg != AutoreleaseRVArg) {
- // If there isn't an exact match, check if we have equivalent PHIs.
- const PHINode *PN = dyn_cast<PHINode>(Arg);
- if (!PN)
- return false;
- SmallVector<const Value *, 4> ArgUsers;
- getEquivalentPHIs(*PN, ArgUsers);
- if (!llvm::is_contained(ArgUsers, AutoreleaseRVArg))
- return false;
- }
- // Okay, this is a match. Merge them.
- ++NumPeeps;
- LLVM_DEBUG(dbgs() << "Found inlined objc_autoreleaseReturnValue '"
- << *AutoreleaseRV << "' paired with '" << *Inst << "'\n");
- // Delete the RV pair, starting with the AutoreleaseRV.
- AutoreleaseRV->replaceAllUsesWith(
- cast<CallInst>(AutoreleaseRV)->getArgOperand(0));
- Changed = true;
- EraseInstruction(AutoreleaseRV);
- if (Class == ARCInstKind::RetainRV) {
- // AutoreleaseRV and RetainRV cancel out. Delete the RetainRV.
- Inst->replaceAllUsesWith(cast<CallInst>(Inst)->getArgOperand(0));
- EraseInstruction(Inst);
- return true;
- }
- // UnsafeClaimRV is a frontend peephole for RetainRV + Release. Since the
- // AutoreleaseRV and RetainRV cancel out, replace UnsafeClaimRV with Release.
- assert(Class == ARCInstKind::UnsafeClaimRV);
- Value *CallArg = cast<CallInst>(Inst)->getArgOperand(0);
- CallInst *Release = CallInst::Create(
- EP.get(ARCRuntimeEntryPointKind::Release), CallArg, "", Inst);
- assert(IsAlwaysTail(ARCInstKind::UnsafeClaimRV) &&
- "Expected UnsafeClaimRV to be safe to tail call");
- Release->setTailCall();
- Inst->replaceAllUsesWith(CallArg);
- EraseInstruction(Inst);
- // Run the normal optimizations on Release.
- OptimizeIndividualCallImpl(F, Release, ARCInstKind::Release, Arg);
- return true;
- }
- /// Turn objc_autoreleaseReturnValue into objc_autorelease if the result is not
- /// used as a return value.
- void ObjCARCOpt::OptimizeAutoreleaseRVCall(Function &F,
- Instruction *AutoreleaseRV,
- ARCInstKind &Class) {
- // Check for a return of the pointer value.
- const Value *Ptr = GetArgRCIdentityRoot(AutoreleaseRV);
- // If the argument is ConstantPointerNull or UndefValue, its other users
- // aren't actually interesting to look at.
- if (isa<ConstantData>(Ptr))
- return;
- SmallVector<const Value *, 2> Users;
- Users.push_back(Ptr);
- // Add PHIs that are equivalent to Ptr to Users.
- if (const PHINode *PN = dyn_cast<PHINode>(Ptr))
- getEquivalentPHIs(*PN, Users);
- do {
- Ptr = Users.pop_back_val();
- for (const User *U : Ptr->users()) {
- if (isa<ReturnInst>(U) || GetBasicARCInstKind(U) == ARCInstKind::RetainRV)
- return;
- if (isa<BitCastInst>(U))
- Users.push_back(U);
- }
- } while (!Users.empty());
- Changed = true;
- ++NumPeeps;
- LLVM_DEBUG(
- dbgs() << "Transforming objc_autoreleaseReturnValue => "
- "objc_autorelease since its operand is not used as a return "
- "value.\n"
- "Old = "
- << *AutoreleaseRV << "\n");
- CallInst *AutoreleaseRVCI = cast<CallInst>(AutoreleaseRV);
- Function *NewDecl = EP.get(ARCRuntimeEntryPointKind::Autorelease);
- AutoreleaseRVCI->setCalledFunction(NewDecl);
- AutoreleaseRVCI->setTailCall(false); // Never tail call objc_autorelease.
- Class = ARCInstKind::Autorelease;
- LLVM_DEBUG(dbgs() << "New: " << *AutoreleaseRV << "\n");
- }
- /// Visit each call, one at a time, and make simplifications without doing any
- /// additional analysis.
- void ObjCARCOpt::OptimizeIndividualCalls(Function &F) {
- LLVM_DEBUG(dbgs() << "\n== ObjCARCOpt::OptimizeIndividualCalls ==\n");
- // Reset all the flags in preparation for recomputing them.
- UsedInThisFunction = 0;
- // Store any delayed AutoreleaseRV intrinsics, so they can be easily paired
- // with RetainRV and UnsafeClaimRV.
- Instruction *DelayedAutoreleaseRV = nullptr;
- const Value *DelayedAutoreleaseRVArg = nullptr;
- auto setDelayedAutoreleaseRV = [&](Instruction *AutoreleaseRV) {
- assert(!DelayedAutoreleaseRV || !AutoreleaseRV);
- DelayedAutoreleaseRV = AutoreleaseRV;
- DelayedAutoreleaseRVArg = nullptr;
- };
- auto optimizeDelayedAutoreleaseRV = [&]() {
- if (!DelayedAutoreleaseRV)
- return;
- OptimizeIndividualCallImpl(F, DelayedAutoreleaseRV,
- ARCInstKind::AutoreleaseRV,
- DelayedAutoreleaseRVArg);
- setDelayedAutoreleaseRV(nullptr);
- };
- auto shouldDelayAutoreleaseRV = [&](Instruction *NonARCInst) {
- // Nothing to delay, but we may as well skip the logic below.
- if (!DelayedAutoreleaseRV)
- return true;
- // If we hit the end of the basic block we're not going to find an RV-pair.
- // Stop delaying.
- if (NonARCInst->isTerminator())
- return false;
- // Given the frontend rules for emitting AutoreleaseRV, RetainRV, and
- // UnsafeClaimRV, it's probably safe to skip over even opaque function calls
- // here since OptimizeInlinedAutoreleaseRVCall will confirm that they
- // have the same RCIdentityRoot. However, what really matters is
- // skipping instructions or intrinsics that the inliner could leave behind;
- // be conservative for now and don't skip over opaque calls, which could
- // potentially include other ARC calls.
- auto *CB = dyn_cast<CallBase>(NonARCInst);
- if (!CB)
- return true;
- return CB->getIntrinsicID() != Intrinsic::not_intrinsic;
- };
- // Visit all objc_* calls in F.
- for (inst_iterator I = inst_begin(&F), E = inst_end(&F); I != E; ) {
- Instruction *Inst = &*I++;
- if (auto *CI = dyn_cast<CallInst>(Inst))
- if (objcarc::hasAttachedCallOpBundle(CI)) {
- BundledInsts->insertRVCall(&*I, CI);
- Changed = true;
- }
- ARCInstKind Class = GetBasicARCInstKind(Inst);
- // Skip this loop if this instruction isn't itself an ARC intrinsic.
- const Value *Arg = nullptr;
- switch (Class) {
- default:
- optimizeDelayedAutoreleaseRV();
- break;
- case ARCInstKind::CallOrUser:
- case ARCInstKind::User:
- case ARCInstKind::None:
- // This is a non-ARC instruction. If we're delaying an AutoreleaseRV,
- // check if it's safe to skip over it; if not, optimize the AutoreleaseRV
- // now.
- if (!shouldDelayAutoreleaseRV(Inst))
- optimizeDelayedAutoreleaseRV();
- continue;
- case ARCInstKind::AutoreleaseRV:
- optimizeDelayedAutoreleaseRV();
- setDelayedAutoreleaseRV(Inst);
- continue;
- case ARCInstKind::RetainRV:
- case ARCInstKind::UnsafeClaimRV:
- if (DelayedAutoreleaseRV) {
- // We have a potential RV pair. Check if they cancel out.
- if (OptimizeInlinedAutoreleaseRVCall(F, Inst, Arg, Class,
- DelayedAutoreleaseRV,
- DelayedAutoreleaseRVArg)) {
- setDelayedAutoreleaseRV(nullptr);
- continue;
- }
- optimizeDelayedAutoreleaseRV();
- }
- break;
- }
- OptimizeIndividualCallImpl(F, Inst, Class, Arg);
- }
- // Catch the final delayed AutoreleaseRV.
- optimizeDelayedAutoreleaseRV();
- }
- /// This function returns true if the value is inert. An ObjC ARC runtime call
- /// taking an inert operand can be safely deleted.
- static bool isInertARCValue(Value *V, SmallPtrSet<Value *, 1> &VisitedPhis) {
- V = V->stripPointerCasts();
- if (IsNullOrUndef(V))
- return true;
- // See if this is a global attribute annotated with an 'objc_arc_inert'.
- if (auto *GV = dyn_cast<GlobalVariable>(V))
- if (GV->hasAttribute("objc_arc_inert"))
- return true;
- if (auto PN = dyn_cast<PHINode>(V)) {
- // Ignore this phi if it has already been discovered.
- if (!VisitedPhis.insert(PN).second)
- return true;
- // Look through phis's operands.
- for (Value *Opnd : PN->incoming_values())
- if (!isInertARCValue(Opnd, VisitedPhis))
- return false;
- return true;
- }
- return false;
- }
- void ObjCARCOpt::OptimizeIndividualCallImpl(Function &F, Instruction *Inst,
- ARCInstKind Class,
- const Value *Arg) {
- LLVM_DEBUG(dbgs() << "Visiting: Class: " << Class << "; " << *Inst << "\n");
- // We can delete this call if it takes an inert value.
- SmallPtrSet<Value *, 1> VisitedPhis;
- if (BundledInsts->contains(Inst)) {
- UsedInThisFunction |= 1 << unsigned(Class);
- return;
- }
- if (IsNoopOnGlobal(Class))
- if (isInertARCValue(Inst->getOperand(0), VisitedPhis)) {
- if (!Inst->getType()->isVoidTy())
- Inst->replaceAllUsesWith(Inst->getOperand(0));
- Inst->eraseFromParent();
- Changed = true;
- return;
- }
- switch (Class) {
- default:
- break;
- // Delete no-op casts. These function calls have special semantics, but
- // the semantics are entirely implemented via lowering in the front-end,
- // so by the time they reach the optimizer, they are just no-op calls
- // which return their argument.
- //
- // There are gray areas here, as the ability to cast reference-counted
- // pointers to raw void* and back allows code to break ARC assumptions,
- // however these are currently considered to be unimportant.
- case ARCInstKind::NoopCast:
- Changed = true;
- ++NumNoops;
- LLVM_DEBUG(dbgs() << "Erasing no-op cast: " << *Inst << "\n");
- EraseInstruction(Inst);
- return;
- // If the pointer-to-weak-pointer is null, it's undefined behavior.
- case ARCInstKind::StoreWeak:
- case ARCInstKind::LoadWeak:
- case ARCInstKind::LoadWeakRetained:
- case ARCInstKind::InitWeak:
- case ARCInstKind::DestroyWeak: {
- CallInst *CI = cast<CallInst>(Inst);
- if (IsNullOrUndef(CI->getArgOperand(0))) {
- Changed = true;
- new StoreInst(ConstantInt::getTrue(CI->getContext()),
- UndefValue::get(Type::getInt1PtrTy(CI->getContext())), CI);
- Value *NewValue = UndefValue::get(CI->getType());
- LLVM_DEBUG(
- dbgs() << "A null pointer-to-weak-pointer is undefined behavior."
- "\nOld = "
- << *CI << "\nNew = " << *NewValue << "\n");
- CI->replaceAllUsesWith(NewValue);
- CI->eraseFromParent();
- return;
- }
- break;
- }
- case ARCInstKind::CopyWeak:
- case ARCInstKind::MoveWeak: {
- CallInst *CI = cast<CallInst>(Inst);
- if (IsNullOrUndef(CI->getArgOperand(0)) ||
- IsNullOrUndef(CI->getArgOperand(1))) {
- Changed = true;
- new StoreInst(ConstantInt::getTrue(CI->getContext()),
- UndefValue::get(Type::getInt1PtrTy(CI->getContext())), CI);
- Value *NewValue = UndefValue::get(CI->getType());
- LLVM_DEBUG(
- dbgs() << "A null pointer-to-weak-pointer is undefined behavior."
- "\nOld = "
- << *CI << "\nNew = " << *NewValue << "\n");
- CI->replaceAllUsesWith(NewValue);
- CI->eraseFromParent();
- return;
- }
- break;
- }
- case ARCInstKind::RetainRV:
- if (OptimizeRetainRVCall(F, Inst))
- return;
- break;
- case ARCInstKind::AutoreleaseRV:
- OptimizeAutoreleaseRVCall(F, Inst, Class);
- break;
- }
- // objc_autorelease(x) -> objc_release(x) if x is otherwise unused.
- if (IsAutorelease(Class) && Inst->use_empty()) {
- CallInst *Call = cast<CallInst>(Inst);
- const Value *Arg = Call->getArgOperand(0);
- Arg = FindSingleUseIdentifiedObject(Arg);
- if (Arg) {
- Changed = true;
- ++NumAutoreleases;
- // Create the declaration lazily.
- LLVMContext &C = Inst->getContext();
- Function *Decl = EP.get(ARCRuntimeEntryPointKind::Release);
- CallInst *NewCall =
- CallInst::Create(Decl, Call->getArgOperand(0), "", Call);
- NewCall->setMetadata(MDKindCache.get(ARCMDKindID::ImpreciseRelease),
- MDNode::get(C, std::nullopt));
- LLVM_DEBUG(dbgs() << "Replacing autorelease{,RV}(x) with objc_release(x) "
- "since x is otherwise unused.\nOld: "
- << *Call << "\nNew: " << *NewCall << "\n");
- EraseInstruction(Call);
- Inst = NewCall;
- Class = ARCInstKind::Release;
- }
- }
- // For functions which can never be passed stack arguments, add
- // a tail keyword.
- if (IsAlwaysTail(Class) && !cast<CallInst>(Inst)->isNoTailCall()) {
- Changed = true;
- LLVM_DEBUG(
- dbgs() << "Adding tail keyword to function since it can never be "
- "passed stack args: "
- << *Inst << "\n");
- cast<CallInst>(Inst)->setTailCall();
- }
- // Ensure that functions that can never have a "tail" keyword due to the
- // semantics of ARC truly do not do so.
- if (IsNeverTail(Class)) {
- Changed = true;
- LLVM_DEBUG(dbgs() << "Removing tail keyword from function: " << *Inst
- << "\n");
- cast<CallInst>(Inst)->setTailCall(false);
- }
- // Set nounwind as needed.
- if (IsNoThrow(Class)) {
- Changed = true;
- LLVM_DEBUG(dbgs() << "Found no throw class. Setting nounwind on: " << *Inst
- << "\n");
- cast<CallInst>(Inst)->setDoesNotThrow();
- }
- // Note: This catches instructions unrelated to ARC.
- if (!IsNoopOnNull(Class)) {
- UsedInThisFunction |= 1 << unsigned(Class);
- return;
- }
- // If we haven't already looked up the root, look it up now.
- if (!Arg)
- Arg = GetArgRCIdentityRoot(Inst);
- // ARC calls with null are no-ops. Delete them.
- if (IsNullOrUndef(Arg)) {
- Changed = true;
- ++NumNoops;
- LLVM_DEBUG(dbgs() << "ARC calls with null are no-ops. Erasing: " << *Inst
- << "\n");
- EraseInstruction(Inst);
- return;
- }
- // Keep track of which of retain, release, autorelease, and retain_block
- // are actually present in this function.
- UsedInThisFunction |= 1 << unsigned(Class);
- // If Arg is a PHI, and one or more incoming values to the
- // PHI are null, and the call is control-equivalent to the PHI, and there
- // are no relevant side effects between the PHI and the call, and the call
- // is not a release that doesn't have the clang.imprecise_release tag, the
- // call could be pushed up to just those paths with non-null incoming
- // values. For now, don't bother splitting critical edges for this.
- if (Class == ARCInstKind::Release &&
- !Inst->getMetadata(MDKindCache.get(ARCMDKindID::ImpreciseRelease)))
- return;
- SmallVector<std::pair<Instruction *, const Value *>, 4> Worklist;
- Worklist.push_back(std::make_pair(Inst, Arg));
- do {
- std::pair<Instruction *, const Value *> Pair = Worklist.pop_back_val();
- Inst = Pair.first;
- Arg = Pair.second;
- const PHINode *PN = dyn_cast<PHINode>(Arg);
- if (!PN)
- continue;
- // Determine if the PHI has any null operands, or any incoming
- // critical edges.
- bool HasNull = false;
- bool HasCriticalEdges = false;
- for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
- Value *Incoming = GetRCIdentityRoot(PN->getIncomingValue(i));
- if (IsNullOrUndef(Incoming))
- HasNull = true;
- else if (PN->getIncomingBlock(i)->getTerminator()->getNumSuccessors() !=
- 1) {
- HasCriticalEdges = true;
- break;
- }
- }
- // If we have null operands and no critical edges, optimize.
- if (HasCriticalEdges)
- continue;
- if (!HasNull)
- continue;
- Instruction *DepInst = nullptr;
- // Check that there is nothing that cares about the reference
- // count between the call and the phi.
- switch (Class) {
- case ARCInstKind::Retain:
- case ARCInstKind::RetainBlock:
- // These can always be moved up.
- break;
- case ARCInstKind::Release:
- // These can't be moved across things that care about the retain
- // count.
- DepInst = findSingleDependency(NeedsPositiveRetainCount, Arg,
- Inst->getParent(), Inst, PA);
- break;
- case ARCInstKind::Autorelease:
- // These can't be moved across autorelease pool scope boundaries.
- DepInst = findSingleDependency(AutoreleasePoolBoundary, Arg,
- Inst->getParent(), Inst, PA);
- break;
- case ARCInstKind::UnsafeClaimRV:
- case ARCInstKind::RetainRV:
- case ARCInstKind::AutoreleaseRV:
- // Don't move these; the RV optimization depends on the autoreleaseRV
- // being tail called, and the retainRV being immediately after a call
- // (which might still happen if we get lucky with codegen layout, but
- // it's not worth taking the chance).
- continue;
- default:
- llvm_unreachable("Invalid dependence flavor");
- }
- if (DepInst != PN)
- continue;
- Changed = true;
- ++NumPartialNoops;
- // Clone the call into each predecessor that has a non-null value.
- CallInst *CInst = cast<CallInst>(Inst);
- Type *ParamTy = CInst->getArgOperand(0)->getType();
- for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
- Value *Incoming = GetRCIdentityRoot(PN->getIncomingValue(i));
- if (IsNullOrUndef(Incoming))
- continue;
- Value *Op = PN->getIncomingValue(i);
- Instruction *InsertPos = &PN->getIncomingBlock(i)->back();
- SmallVector<OperandBundleDef, 1> OpBundles;
- cloneOpBundlesIf(CInst, OpBundles, [](const OperandBundleUse &B) {
- return B.getTagID() != LLVMContext::OB_funclet;
- });
- addOpBundleForFunclet(InsertPos->getParent(), OpBundles);
- CallInst *Clone = CallInst::Create(CInst, OpBundles);
- if (Op->getType() != ParamTy)
- Op = new BitCastInst(Op, ParamTy, "", InsertPos);
- Clone->setArgOperand(0, Op);
- Clone->insertBefore(InsertPos);
- LLVM_DEBUG(dbgs() << "Cloning " << *CInst << "\n"
- "And inserting clone at "
- << *InsertPos << "\n");
- Worklist.push_back(std::make_pair(Clone, Incoming));
- }
- // Erase the original call.
- LLVM_DEBUG(dbgs() << "Erasing: " << *CInst << "\n");
- EraseInstruction(CInst);
- } while (!Worklist.empty());
- }
- /// If we have a top down pointer in the S_Use state, make sure that there are
- /// no CFG hazards by checking the states of various bottom up pointers.
- static void CheckForUseCFGHazard(const Sequence SuccSSeq,
- const bool SuccSRRIKnownSafe,
- TopDownPtrState &S,
- bool &SomeSuccHasSame,
- bool &AllSuccsHaveSame,
- bool &NotAllSeqEqualButKnownSafe,
- bool &ShouldContinue) {
- switch (SuccSSeq) {
- case S_CanRelease: {
- if (!S.IsKnownSafe() && !SuccSRRIKnownSafe) {
- S.ClearSequenceProgress();
- break;
- }
- S.SetCFGHazardAfflicted(true);
- ShouldContinue = true;
- break;
- }
- case S_Use:
- SomeSuccHasSame = true;
- break;
- case S_Stop:
- case S_MovableRelease:
- if (!S.IsKnownSafe() && !SuccSRRIKnownSafe)
- AllSuccsHaveSame = false;
- else
- NotAllSeqEqualButKnownSafe = true;
- break;
- case S_Retain:
- llvm_unreachable("bottom-up pointer in retain state!");
- case S_None:
- llvm_unreachable("This should have been handled earlier.");
- }
- }
- /// If we have a Top Down pointer in the S_CanRelease state, make sure that
- /// there are no CFG hazards by checking the states of various bottom up
- /// pointers.
- static void CheckForCanReleaseCFGHazard(const Sequence SuccSSeq,
- const bool SuccSRRIKnownSafe,
- TopDownPtrState &S,
- bool &SomeSuccHasSame,
- bool &AllSuccsHaveSame,
- bool &NotAllSeqEqualButKnownSafe) {
- switch (SuccSSeq) {
- case S_CanRelease:
- SomeSuccHasSame = true;
- break;
- case S_Stop:
- case S_MovableRelease:
- case S_Use:
- if (!S.IsKnownSafe() && !SuccSRRIKnownSafe)
- AllSuccsHaveSame = false;
- else
- NotAllSeqEqualButKnownSafe = true;
- break;
- case S_Retain:
- llvm_unreachable("bottom-up pointer in retain state!");
- case S_None:
- llvm_unreachable("This should have been handled earlier.");
- }
- }
- /// Check for critical edges, loop boundaries, irreducible control flow, or
- /// other CFG structures where moving code across the edge would result in it
- /// being executed more.
- void
- ObjCARCOpt::CheckForCFGHazards(const BasicBlock *BB,
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BBState &MyStates) const {
- // If any top-down local-use or possible-dec has a succ which is earlier in
- // the sequence, forget it.
- for (auto I = MyStates.top_down_ptr_begin(), E = MyStates.top_down_ptr_end();
- I != E; ++I) {
- TopDownPtrState &S = I->second;
- const Sequence Seq = I->second.GetSeq();
- // We only care about S_Retain, S_CanRelease, and S_Use.
- if (Seq == S_None)
- continue;
- // Make sure that if extra top down states are added in the future that this
- // code is updated to handle it.
- assert((Seq == S_Retain || Seq == S_CanRelease || Seq == S_Use) &&
- "Unknown top down sequence state.");
- const Value *Arg = I->first;
- bool SomeSuccHasSame = false;
- bool AllSuccsHaveSame = true;
- bool NotAllSeqEqualButKnownSafe = false;
- for (const BasicBlock *Succ : successors(BB)) {
- // If VisitBottomUp has pointer information for this successor, take
- // what we know about it.
- const DenseMap<const BasicBlock *, BBState>::iterator BBI =
- BBStates.find(Succ);
- assert(BBI != BBStates.end());
- const BottomUpPtrState &SuccS = BBI->second.getPtrBottomUpState(Arg);
- const Sequence SuccSSeq = SuccS.GetSeq();
- // If bottom up, the pointer is in an S_None state, clear the sequence
- // progress since the sequence in the bottom up state finished
- // suggesting a mismatch in between retains/releases. This is true for
- // all three cases that we are handling here: S_Retain, S_Use, and
- // S_CanRelease.
- if (SuccSSeq == S_None) {
- S.ClearSequenceProgress();
- continue;
- }
- // If we have S_Use or S_CanRelease, perform our check for cfg hazard
- // checks.
- const bool SuccSRRIKnownSafe = SuccS.IsKnownSafe();
- // *NOTE* We do not use Seq from above here since we are allowing for
- // S.GetSeq() to change while we are visiting basic blocks.
- switch(S.GetSeq()) {
- case S_Use: {
- bool ShouldContinue = false;
- CheckForUseCFGHazard(SuccSSeq, SuccSRRIKnownSafe, S, SomeSuccHasSame,
- AllSuccsHaveSame, NotAllSeqEqualButKnownSafe,
- ShouldContinue);
- if (ShouldContinue)
- continue;
- break;
- }
- case S_CanRelease:
- CheckForCanReleaseCFGHazard(SuccSSeq, SuccSRRIKnownSafe, S,
- SomeSuccHasSame, AllSuccsHaveSame,
- NotAllSeqEqualButKnownSafe);
- break;
- case S_Retain:
- case S_None:
- case S_Stop:
- case S_MovableRelease:
- break;
- }
- }
- // If the state at the other end of any of the successor edges
- // matches the current state, require all edges to match. This
- // guards against loops in the middle of a sequence.
- if (SomeSuccHasSame && !AllSuccsHaveSame) {
- S.ClearSequenceProgress();
- } else if (NotAllSeqEqualButKnownSafe) {
- // If we would have cleared the state foregoing the fact that we are known
- // safe, stop code motion. This is because whether or not it is safe to
- // remove RR pairs via KnownSafe is an orthogonal concept to whether we
- // are allowed to perform code motion.
- S.SetCFGHazardAfflicted(true);
- }
- }
- }
- bool ObjCARCOpt::VisitInstructionBottomUp(
- Instruction *Inst, BasicBlock *BB, BlotMapVector<Value *, RRInfo> &Retains,
- BBState &MyStates) {
- bool NestingDetected = false;
- ARCInstKind Class = GetARCInstKind(Inst);
- const Value *Arg = nullptr;
- LLVM_DEBUG(dbgs() << " Class: " << Class << "\n");
- switch (Class) {
- case ARCInstKind::Release: {
- Arg = GetArgRCIdentityRoot(Inst);
- BottomUpPtrState &S = MyStates.getPtrBottomUpState(Arg);
- NestingDetected |= S.InitBottomUp(MDKindCache, Inst);
- break;
- }
- case ARCInstKind::RetainBlock:
- // In OptimizeIndividualCalls, we have strength reduced all optimizable
- // objc_retainBlocks to objc_retains. Thus at this point any
- // objc_retainBlocks that we see are not optimizable.
- break;
- case ARCInstKind::Retain:
- case ARCInstKind::RetainRV: {
- Arg = GetArgRCIdentityRoot(Inst);
- BottomUpPtrState &S = MyStates.getPtrBottomUpState(Arg);
- if (S.MatchWithRetain()) {
- // Don't do retain+release tracking for ARCInstKind::RetainRV, because
- // it's better to let it remain as the first instruction after a call.
- if (Class != ARCInstKind::RetainRV) {
- LLVM_DEBUG(dbgs() << " Matching with: " << *Inst << "\n");
- Retains[Inst] = S.GetRRInfo();
- }
- S.ClearSequenceProgress();
- }
- // A retain moving bottom up can be a use.
- break;
- }
- case ARCInstKind::AutoreleasepoolPop:
- // Conservatively, clear MyStates for all known pointers.
- MyStates.clearBottomUpPointers();
- return NestingDetected;
- case ARCInstKind::AutoreleasepoolPush:
- case ARCInstKind::None:
- // These are irrelevant.
- return NestingDetected;
- default:
- break;
- }
- // Consider any other possible effects of this instruction on each
- // pointer being tracked.
- for (auto MI = MyStates.bottom_up_ptr_begin(),
- ME = MyStates.bottom_up_ptr_end();
- MI != ME; ++MI) {
- const Value *Ptr = MI->first;
- if (Ptr == Arg)
- continue; // Handled above.
- BottomUpPtrState &S = MI->second;
- if (S.HandlePotentialAlterRefCount(Inst, Ptr, PA, Class))
- continue;
- S.HandlePotentialUse(BB, Inst, Ptr, PA, Class);
- }
- return NestingDetected;
- }
- bool ObjCARCOpt::VisitBottomUp(BasicBlock *BB,
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains) {
- LLVM_DEBUG(dbgs() << "\n== ObjCARCOpt::VisitBottomUp ==\n");
- bool NestingDetected = false;
- BBState &MyStates = BBStates[BB];
- // Merge the states from each successor to compute the initial state
- // for the current block.
- BBState::edge_iterator SI(MyStates.succ_begin()),
- SE(MyStates.succ_end());
- if (SI != SE) {
- const BasicBlock *Succ = *SI;
- DenseMap<const BasicBlock *, BBState>::iterator I = BBStates.find(Succ);
- assert(I != BBStates.end());
- MyStates.InitFromSucc(I->second);
- ++SI;
- for (; SI != SE; ++SI) {
- Succ = *SI;
- I = BBStates.find(Succ);
- assert(I != BBStates.end());
- MyStates.MergeSucc(I->second);
- }
- }
- LLVM_DEBUG(dbgs() << "Before:\n"
- << BBStates[BB] << "\n"
- << "Performing Dataflow:\n");
- // Visit all the instructions, bottom-up.
- for (BasicBlock::iterator I = BB->end(), E = BB->begin(); I != E; --I) {
- Instruction *Inst = &*std::prev(I);
- // Invoke instructions are visited as part of their successors (below).
- if (isa<InvokeInst>(Inst))
- continue;
- LLVM_DEBUG(dbgs() << " Visiting " << *Inst << "\n");
- NestingDetected |= VisitInstructionBottomUp(Inst, BB, Retains, MyStates);
- // Bail out if the number of pointers being tracked becomes too large so
- // that this pass can complete in a reasonable amount of time.
- if (MyStates.bottom_up_ptr_list_size() > MaxPtrStates) {
- DisableRetainReleasePairing = true;
- return false;
- }
- }
- // If there's a predecessor with an invoke, visit the invoke as if it were
- // part of this block, since we can't insert code after an invoke in its own
- // block, and we don't want to split critical edges.
- for (BBState::edge_iterator PI(MyStates.pred_begin()),
- PE(MyStates.pred_end()); PI != PE; ++PI) {
- BasicBlock *Pred = *PI;
- if (InvokeInst *II = dyn_cast<InvokeInst>(&Pred->back()))
- NestingDetected |= VisitInstructionBottomUp(II, BB, Retains, MyStates);
- }
- LLVM_DEBUG(dbgs() << "\nFinal State:\n" << BBStates[BB] << "\n");
- return NestingDetected;
- }
- // Fill ReleaseInsertPtToRCIdentityRoots, which is a map from insertion points
- // to the set of RC identity roots that would be released by the release calls
- // moved to the insertion points.
- static void collectReleaseInsertPts(
- const BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- &ReleaseInsertPtToRCIdentityRoots) {
- for (const auto &P : Retains) {
- // Retains is a map from an objc_retain call to a RRInfo of the RC identity
- // root of the call. Get the RC identity root of the objc_retain call.
- Instruction *Retain = cast<Instruction>(P.first);
- Value *Root = GetRCIdentityRoot(Retain->getOperand(0));
- // Collect all the insertion points of the objc_release calls that release
- // the RC identity root of the objc_retain call.
- for (const Instruction *InsertPt : P.second.ReverseInsertPts)
- ReleaseInsertPtToRCIdentityRoots[InsertPt].insert(Root);
- }
- }
- // Get the RC identity roots from an insertion point of an objc_release call.
- // Return nullptr if the passed instruction isn't an insertion point.
- static const SmallPtrSet<const Value *, 2> *
- getRCIdentityRootsFromReleaseInsertPt(
- const Instruction *InsertPt,
- const DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- &ReleaseInsertPtToRCIdentityRoots) {
- auto I = ReleaseInsertPtToRCIdentityRoots.find(InsertPt);
- if (I == ReleaseInsertPtToRCIdentityRoots.end())
- return nullptr;
- return &I->second;
- }
- bool ObjCARCOpt::VisitInstructionTopDown(
- Instruction *Inst, DenseMap<Value *, RRInfo> &Releases, BBState &MyStates,
- const DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- &ReleaseInsertPtToRCIdentityRoots) {
- bool NestingDetected = false;
- ARCInstKind Class = GetARCInstKind(Inst);
- const Value *Arg = nullptr;
- // Make sure a call to objc_retain isn't moved past insertion points of calls
- // to objc_release.
- if (const SmallPtrSet<const Value *, 2> *Roots =
- getRCIdentityRootsFromReleaseInsertPt(
- Inst, ReleaseInsertPtToRCIdentityRoots))
- for (const auto *Root : *Roots) {
- TopDownPtrState &S = MyStates.getPtrTopDownState(Root);
- // Disable code motion if the current position is S_Retain to prevent
- // moving the objc_retain call past objc_release calls. If it's
- // S_CanRelease or larger, it's not necessary to disable code motion as
- // the insertion points that prevent the objc_retain call from moving down
- // should have been set already.
- if (S.GetSeq() == S_Retain)
- S.SetCFGHazardAfflicted(true);
- }
- LLVM_DEBUG(dbgs() << " Class: " << Class << "\n");
- switch (Class) {
- case ARCInstKind::RetainBlock:
- // In OptimizeIndividualCalls, we have strength reduced all optimizable
- // objc_retainBlocks to objc_retains. Thus at this point any
- // objc_retainBlocks that we see are not optimizable. We need to break since
- // a retain can be a potential use.
- break;
- case ARCInstKind::Retain:
- case ARCInstKind::RetainRV: {
- Arg = GetArgRCIdentityRoot(Inst);
- TopDownPtrState &S = MyStates.getPtrTopDownState(Arg);
- NestingDetected |= S.InitTopDown(Class, Inst);
- // A retain can be a potential use; proceed to the generic checking
- // code below.
- break;
- }
- case ARCInstKind::Release: {
- Arg = GetArgRCIdentityRoot(Inst);
- TopDownPtrState &S = MyStates.getPtrTopDownState(Arg);
- // Try to form a tentative pair in between this release instruction and the
- // top down pointers that we are tracking.
- if (S.MatchWithRelease(MDKindCache, Inst)) {
- // If we succeed, copy S's RRInfo into the Release -> {Retain Set
- // Map}. Then we clear S.
- LLVM_DEBUG(dbgs() << " Matching with: " << *Inst << "\n");
- Releases[Inst] = S.GetRRInfo();
- S.ClearSequenceProgress();
- }
- break;
- }
- case ARCInstKind::AutoreleasepoolPop:
- // Conservatively, clear MyStates for all known pointers.
- MyStates.clearTopDownPointers();
- return false;
- case ARCInstKind::AutoreleasepoolPush:
- case ARCInstKind::None:
- // These can not be uses of
- return false;
- default:
- break;
- }
- // Consider any other possible effects of this instruction on each
- // pointer being tracked.
- for (auto MI = MyStates.top_down_ptr_begin(),
- ME = MyStates.top_down_ptr_end();
- MI != ME; ++MI) {
- const Value *Ptr = MI->first;
- if (Ptr == Arg)
- continue; // Handled above.
- TopDownPtrState &S = MI->second;
- if (S.HandlePotentialAlterRefCount(Inst, Ptr, PA, Class, *BundledInsts))
- continue;
- S.HandlePotentialUse(Inst, Ptr, PA, Class);
- }
- return NestingDetected;
- }
- bool ObjCARCOpt::VisitTopDown(
- BasicBlock *BB, DenseMap<const BasicBlock *, BBState> &BBStates,
- DenseMap<Value *, RRInfo> &Releases,
- const DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- &ReleaseInsertPtToRCIdentityRoots) {
- LLVM_DEBUG(dbgs() << "\n== ObjCARCOpt::VisitTopDown ==\n");
- bool NestingDetected = false;
- BBState &MyStates = BBStates[BB];
- // Merge the states from each predecessor to compute the initial state
- // for the current block.
- BBState::edge_iterator PI(MyStates.pred_begin()),
- PE(MyStates.pred_end());
- if (PI != PE) {
- const BasicBlock *Pred = *PI;
- DenseMap<const BasicBlock *, BBState>::iterator I = BBStates.find(Pred);
- assert(I != BBStates.end());
- MyStates.InitFromPred(I->second);
- ++PI;
- for (; PI != PE; ++PI) {
- Pred = *PI;
- I = BBStates.find(Pred);
- assert(I != BBStates.end());
- MyStates.MergePred(I->second);
- }
- }
- // Check that BB and MyStates have the same number of predecessors. This
- // prevents retain calls that live outside a loop from being moved into the
- // loop.
- if (!BB->hasNPredecessors(MyStates.pred_end() - MyStates.pred_begin()))
- for (auto I = MyStates.top_down_ptr_begin(),
- E = MyStates.top_down_ptr_end();
- I != E; ++I)
- I->second.SetCFGHazardAfflicted(true);
- LLVM_DEBUG(dbgs() << "Before:\n"
- << BBStates[BB] << "\n"
- << "Performing Dataflow:\n");
- // Visit all the instructions, top-down.
- for (Instruction &Inst : *BB) {
- LLVM_DEBUG(dbgs() << " Visiting " << Inst << "\n");
- NestingDetected |= VisitInstructionTopDown(
- &Inst, Releases, MyStates, ReleaseInsertPtToRCIdentityRoots);
- // Bail out if the number of pointers being tracked becomes too large so
- // that this pass can complete in a reasonable amount of time.
- if (MyStates.top_down_ptr_list_size() > MaxPtrStates) {
- DisableRetainReleasePairing = true;
- return false;
- }
- }
- LLVM_DEBUG(dbgs() << "\nState Before Checking for CFG Hazards:\n"
- << BBStates[BB] << "\n\n");
- CheckForCFGHazards(BB, BBStates, MyStates);
- LLVM_DEBUG(dbgs() << "Final State:\n" << BBStates[BB] << "\n");
- return NestingDetected;
- }
- static void
- ComputePostOrders(Function &F,
- SmallVectorImpl<BasicBlock *> &PostOrder,
- SmallVectorImpl<BasicBlock *> &ReverseCFGPostOrder,
- unsigned NoObjCARCExceptionsMDKind,
- DenseMap<const BasicBlock *, BBState> &BBStates) {
- /// The visited set, for doing DFS walks.
- SmallPtrSet<BasicBlock *, 16> Visited;
- // Do DFS, computing the PostOrder.
- SmallPtrSet<BasicBlock *, 16> OnStack;
- SmallVector<std::pair<BasicBlock *, succ_iterator>, 16> SuccStack;
- // Functions always have exactly one entry block, and we don't have
- // any other block that we treat like an entry block.
- BasicBlock *EntryBB = &F.getEntryBlock();
- BBState &MyStates = BBStates[EntryBB];
- MyStates.SetAsEntry();
- Instruction *EntryTI = EntryBB->getTerminator();
- SuccStack.push_back(std::make_pair(EntryBB, succ_iterator(EntryTI)));
- Visited.insert(EntryBB);
- OnStack.insert(EntryBB);
- do {
- dfs_next_succ:
- BasicBlock *CurrBB = SuccStack.back().first;
- succ_iterator SE(CurrBB->getTerminator(), false);
- while (SuccStack.back().second != SE) {
- BasicBlock *SuccBB = *SuccStack.back().second++;
- if (Visited.insert(SuccBB).second) {
- SuccStack.push_back(
- std::make_pair(SuccBB, succ_iterator(SuccBB->getTerminator())));
- BBStates[CurrBB].addSucc(SuccBB);
- BBState &SuccStates = BBStates[SuccBB];
- SuccStates.addPred(CurrBB);
- OnStack.insert(SuccBB);
- goto dfs_next_succ;
- }
- if (!OnStack.count(SuccBB)) {
- BBStates[CurrBB].addSucc(SuccBB);
- BBStates[SuccBB].addPred(CurrBB);
- }
- }
- OnStack.erase(CurrBB);
- PostOrder.push_back(CurrBB);
- SuccStack.pop_back();
- } while (!SuccStack.empty());
- Visited.clear();
- // Do reverse-CFG DFS, computing the reverse-CFG PostOrder.
- // Functions may have many exits, and there also blocks which we treat
- // as exits due to ignored edges.
- SmallVector<std::pair<BasicBlock *, BBState::edge_iterator>, 16> PredStack;
- for (BasicBlock &ExitBB : F) {
- BBState &MyStates = BBStates[&ExitBB];
- if (!MyStates.isExit())
- continue;
- MyStates.SetAsExit();
- PredStack.push_back(std::make_pair(&ExitBB, MyStates.pred_begin()));
- Visited.insert(&ExitBB);
- while (!PredStack.empty()) {
- reverse_dfs_next_succ:
- BBState::edge_iterator PE = BBStates[PredStack.back().first].pred_end();
- while (PredStack.back().second != PE) {
- BasicBlock *BB = *PredStack.back().second++;
- if (Visited.insert(BB).second) {
- PredStack.push_back(std::make_pair(BB, BBStates[BB].pred_begin()));
- goto reverse_dfs_next_succ;
- }
- }
- ReverseCFGPostOrder.push_back(PredStack.pop_back_val().first);
- }
- }
- }
- // Visit the function both top-down and bottom-up.
- bool ObjCARCOpt::Visit(Function &F,
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases) {
- // Use reverse-postorder traversals, because we magically know that loops
- // will be well behaved, i.e. they won't repeatedly call retain on a single
- // pointer without doing a release. We can't use the ReversePostOrderTraversal
- // class here because we want the reverse-CFG postorder to consider each
- // function exit point, and we want to ignore selected cycle edges.
- SmallVector<BasicBlock *, 16> PostOrder;
- SmallVector<BasicBlock *, 16> ReverseCFGPostOrder;
- ComputePostOrders(F, PostOrder, ReverseCFGPostOrder,
- MDKindCache.get(ARCMDKindID::NoObjCARCExceptions),
- BBStates);
- // Use reverse-postorder on the reverse CFG for bottom-up.
- bool BottomUpNestingDetected = false;
- for (BasicBlock *BB : llvm::reverse(ReverseCFGPostOrder)) {
- BottomUpNestingDetected |= VisitBottomUp(BB, BBStates, Retains);
- if (DisableRetainReleasePairing)
- return false;
- }
- DenseMap<const Instruction *, SmallPtrSet<const Value *, 2>>
- ReleaseInsertPtToRCIdentityRoots;
- collectReleaseInsertPts(Retains, ReleaseInsertPtToRCIdentityRoots);
- // Use reverse-postorder for top-down.
- bool TopDownNestingDetected = false;
- for (BasicBlock *BB : llvm::reverse(PostOrder)) {
- TopDownNestingDetected |=
- VisitTopDown(BB, BBStates, Releases, ReleaseInsertPtToRCIdentityRoots);
- if (DisableRetainReleasePairing)
- return false;
- }
- return TopDownNestingDetected && BottomUpNestingDetected;
- }
- /// Move the calls in RetainsToMove and ReleasesToMove.
- void ObjCARCOpt::MoveCalls(Value *Arg, RRInfo &RetainsToMove,
- RRInfo &ReleasesToMove,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases,
- SmallVectorImpl<Instruction *> &DeadInsts,
- Module *M) {
- Type *ArgTy = Arg->getType();
- Type *ParamTy = PointerType::getUnqual(Type::getInt8Ty(ArgTy->getContext()));
- LLVM_DEBUG(dbgs() << "== ObjCARCOpt::MoveCalls ==\n");
- // Insert the new retain and release calls.
- for (Instruction *InsertPt : ReleasesToMove.ReverseInsertPts) {
- Value *MyArg = ArgTy == ParamTy ? Arg :
- new BitCastInst(Arg, ParamTy, "", InsertPt);
- Function *Decl = EP.get(ARCRuntimeEntryPointKind::Retain);
- SmallVector<OperandBundleDef, 1> BundleList;
- addOpBundleForFunclet(InsertPt->getParent(), BundleList);
- CallInst *Call = CallInst::Create(Decl, MyArg, BundleList, "", InsertPt);
- Call->setDoesNotThrow();
- Call->setTailCall();
- LLVM_DEBUG(dbgs() << "Inserting new Retain: " << *Call
- << "\n"
- "At insertion point: "
- << *InsertPt << "\n");
- }
- for (Instruction *InsertPt : RetainsToMove.ReverseInsertPts) {
- Value *MyArg = ArgTy == ParamTy ? Arg :
- new BitCastInst(Arg, ParamTy, "", InsertPt);
- Function *Decl = EP.get(ARCRuntimeEntryPointKind::Release);
- SmallVector<OperandBundleDef, 1> BundleList;
- addOpBundleForFunclet(InsertPt->getParent(), BundleList);
- CallInst *Call = CallInst::Create(Decl, MyArg, BundleList, "", InsertPt);
- // Attach a clang.imprecise_release metadata tag, if appropriate.
- if (MDNode *M = ReleasesToMove.ReleaseMetadata)
- Call->setMetadata(MDKindCache.get(ARCMDKindID::ImpreciseRelease), M);
- Call->setDoesNotThrow();
- if (ReleasesToMove.IsTailCallRelease)
- Call->setTailCall();
- LLVM_DEBUG(dbgs() << "Inserting new Release: " << *Call
- << "\n"
- "At insertion point: "
- << *InsertPt << "\n");
- }
- // Delete the original retain and release calls.
- for (Instruction *OrigRetain : RetainsToMove.Calls) {
- Retains.blot(OrigRetain);
- DeadInsts.push_back(OrigRetain);
- LLVM_DEBUG(dbgs() << "Deleting retain: " << *OrigRetain << "\n");
- }
- for (Instruction *OrigRelease : ReleasesToMove.Calls) {
- Releases.erase(OrigRelease);
- DeadInsts.push_back(OrigRelease);
- LLVM_DEBUG(dbgs() << "Deleting release: " << *OrigRelease << "\n");
- }
- }
- bool ObjCARCOpt::PairUpRetainsAndReleases(
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases, Module *M,
- Instruction *Retain,
- SmallVectorImpl<Instruction *> &DeadInsts, RRInfo &RetainsToMove,
- RRInfo &ReleasesToMove, Value *Arg, bool KnownSafe,
- bool &AnyPairsCompletelyEliminated) {
- // If a pair happens in a region where it is known that the reference count
- // is already incremented, we can similarly ignore possible decrements unless
- // we are dealing with a retainable object with multiple provenance sources.
- bool KnownSafeTD = true, KnownSafeBU = true;
- bool CFGHazardAfflicted = false;
- // Connect the dots between the top-down-collected RetainsToMove and
- // bottom-up-collected ReleasesToMove to form sets of related calls.
- // This is an iterative process so that we connect multiple releases
- // to multiple retains if needed.
- unsigned OldDelta = 0;
- unsigned NewDelta = 0;
- unsigned OldCount = 0;
- unsigned NewCount = 0;
- bool FirstRelease = true;
- for (SmallVector<Instruction *, 4> NewRetains{Retain};;) {
- SmallVector<Instruction *, 4> NewReleases;
- for (Instruction *NewRetain : NewRetains) {
- auto It = Retains.find(NewRetain);
- assert(It != Retains.end());
- const RRInfo &NewRetainRRI = It->second;
- KnownSafeTD &= NewRetainRRI.KnownSafe;
- CFGHazardAfflicted |= NewRetainRRI.CFGHazardAfflicted;
- for (Instruction *NewRetainRelease : NewRetainRRI.Calls) {
- auto Jt = Releases.find(NewRetainRelease);
- if (Jt == Releases.end())
- return false;
- const RRInfo &NewRetainReleaseRRI = Jt->second;
- // If the release does not have a reference to the retain as well,
- // something happened which is unaccounted for. Do not do anything.
- //
- // This can happen if we catch an additive overflow during path count
- // merging.
- if (!NewRetainReleaseRRI.Calls.count(NewRetain))
- return false;
- if (ReleasesToMove.Calls.insert(NewRetainRelease).second) {
- // If we overflow when we compute the path count, don't remove/move
- // anything.
- const BBState &NRRBBState = BBStates[NewRetainRelease->getParent()];
- unsigned PathCount = BBState::OverflowOccurredValue;
- if (NRRBBState.GetAllPathCountWithOverflow(PathCount))
- return false;
- assert(PathCount != BBState::OverflowOccurredValue &&
- "PathCount at this point can not be "
- "OverflowOccurredValue.");
- OldDelta -= PathCount;
- // Merge the ReleaseMetadata and IsTailCallRelease values.
- if (FirstRelease) {
- ReleasesToMove.ReleaseMetadata =
- NewRetainReleaseRRI.ReleaseMetadata;
- ReleasesToMove.IsTailCallRelease =
- NewRetainReleaseRRI.IsTailCallRelease;
- FirstRelease = false;
- } else {
- if (ReleasesToMove.ReleaseMetadata !=
- NewRetainReleaseRRI.ReleaseMetadata)
- ReleasesToMove.ReleaseMetadata = nullptr;
- if (ReleasesToMove.IsTailCallRelease !=
- NewRetainReleaseRRI.IsTailCallRelease)
- ReleasesToMove.IsTailCallRelease = false;
- }
- // Collect the optimal insertion points.
- if (!KnownSafe)
- for (Instruction *RIP : NewRetainReleaseRRI.ReverseInsertPts) {
- if (ReleasesToMove.ReverseInsertPts.insert(RIP).second) {
- // If we overflow when we compute the path count, don't
- // remove/move anything.
- const BBState &RIPBBState = BBStates[RIP->getParent()];
- PathCount = BBState::OverflowOccurredValue;
- if (RIPBBState.GetAllPathCountWithOverflow(PathCount))
- return false;
- assert(PathCount != BBState::OverflowOccurredValue &&
- "PathCount at this point can not be "
- "OverflowOccurredValue.");
- NewDelta -= PathCount;
- }
- }
- NewReleases.push_back(NewRetainRelease);
- }
- }
- }
- NewRetains.clear();
- if (NewReleases.empty()) break;
- // Back the other way.
- for (Instruction *NewRelease : NewReleases) {
- auto It = Releases.find(NewRelease);
- assert(It != Releases.end());
- const RRInfo &NewReleaseRRI = It->second;
- KnownSafeBU &= NewReleaseRRI.KnownSafe;
- CFGHazardAfflicted |= NewReleaseRRI.CFGHazardAfflicted;
- for (Instruction *NewReleaseRetain : NewReleaseRRI.Calls) {
- auto Jt = Retains.find(NewReleaseRetain);
- if (Jt == Retains.end())
- return false;
- const RRInfo &NewReleaseRetainRRI = Jt->second;
- // If the retain does not have a reference to the release as well,
- // something happened which is unaccounted for. Do not do anything.
- //
- // This can happen if we catch an additive overflow during path count
- // merging.
- if (!NewReleaseRetainRRI.Calls.count(NewRelease))
- return false;
- if (RetainsToMove.Calls.insert(NewReleaseRetain).second) {
- // If we overflow when we compute the path count, don't remove/move
- // anything.
- const BBState &NRRBBState = BBStates[NewReleaseRetain->getParent()];
- unsigned PathCount = BBState::OverflowOccurredValue;
- if (NRRBBState.GetAllPathCountWithOverflow(PathCount))
- return false;
- assert(PathCount != BBState::OverflowOccurredValue &&
- "PathCount at this point can not be "
- "OverflowOccurredValue.");
- OldDelta += PathCount;
- OldCount += PathCount;
- // Collect the optimal insertion points.
- if (!KnownSafe)
- for (Instruction *RIP : NewReleaseRetainRRI.ReverseInsertPts) {
- if (RetainsToMove.ReverseInsertPts.insert(RIP).second) {
- // If we overflow when we compute the path count, don't
- // remove/move anything.
- const BBState &RIPBBState = BBStates[RIP->getParent()];
- PathCount = BBState::OverflowOccurredValue;
- if (RIPBBState.GetAllPathCountWithOverflow(PathCount))
- return false;
- assert(PathCount != BBState::OverflowOccurredValue &&
- "PathCount at this point can not be "
- "OverflowOccurredValue.");
- NewDelta += PathCount;
- NewCount += PathCount;
- }
- }
- NewRetains.push_back(NewReleaseRetain);
- }
- }
- }
- if (NewRetains.empty()) break;
- }
- // We can only remove pointers if we are known safe in both directions.
- bool UnconditionallySafe = KnownSafeTD && KnownSafeBU;
- if (UnconditionallySafe) {
- RetainsToMove.ReverseInsertPts.clear();
- ReleasesToMove.ReverseInsertPts.clear();
- NewCount = 0;
- } else {
- // Determine whether the new insertion points we computed preserve the
- // balance of retain and release calls through the program.
- // TODO: If the fully aggressive solution isn't valid, try to find a
- // less aggressive solution which is.
- if (NewDelta != 0)
- return false;
- // At this point, we are not going to remove any RR pairs, but we still are
- // able to move RR pairs. If one of our pointers is afflicted with
- // CFGHazards, we cannot perform such code motion so exit early.
- const bool WillPerformCodeMotion =
- !RetainsToMove.ReverseInsertPts.empty() ||
- !ReleasesToMove.ReverseInsertPts.empty();
- if (CFGHazardAfflicted && WillPerformCodeMotion)
- return false;
- }
- // Determine whether the original call points are balanced in the retain and
- // release calls through the program. If not, conservatively don't touch
- // them.
- // TODO: It's theoretically possible to do code motion in this case, as
- // long as the existing imbalances are maintained.
- if (OldDelta != 0)
- return false;
- Changed = true;
- assert(OldCount != 0 && "Unreachable code?");
- NumRRs += OldCount - NewCount;
- // Set to true if we completely removed any RR pairs.
- AnyPairsCompletelyEliminated = NewCount == 0;
- // We can move calls!
- return true;
- }
- /// Identify pairings between the retains and releases, and delete and/or move
- /// them.
- bool ObjCARCOpt::PerformCodePlacement(
- DenseMap<const BasicBlock *, BBState> &BBStates,
- BlotMapVector<Value *, RRInfo> &Retains,
- DenseMap<Value *, RRInfo> &Releases, Module *M) {
- LLVM_DEBUG(dbgs() << "\n== ObjCARCOpt::PerformCodePlacement ==\n");
- bool AnyPairsCompletelyEliminated = false;
- SmallVector<Instruction *, 8> DeadInsts;
- // Visit each retain.
- for (BlotMapVector<Value *, RRInfo>::const_iterator I = Retains.begin(),
- E = Retains.end();
- I != E; ++I) {
- Value *V = I->first;
- if (!V) continue; // blotted
- Instruction *Retain = cast<Instruction>(V);
- LLVM_DEBUG(dbgs() << "Visiting: " << *Retain << "\n");
- Value *Arg = GetArgRCIdentityRoot(Retain);
- // If the object being released is in static or stack storage, we know it's
- // not being managed by ObjC reference counting, so we can delete pairs
- // regardless of what possible decrements or uses lie between them.
- bool KnownSafe = isa<Constant>(Arg) || isa<AllocaInst>(Arg);
- // A constant pointer can't be pointing to an object on the heap. It may
- // be reference-counted, but it won't be deleted.
- if (const LoadInst *LI = dyn_cast<LoadInst>(Arg))
- if (const GlobalVariable *GV =
- dyn_cast<GlobalVariable>(
- GetRCIdentityRoot(LI->getPointerOperand())))
- if (GV->isConstant())
- KnownSafe = true;
- // Connect the dots between the top-down-collected RetainsToMove and
- // bottom-up-collected ReleasesToMove to form sets of related calls.
- RRInfo RetainsToMove, ReleasesToMove;
- bool PerformMoveCalls = PairUpRetainsAndReleases(
- BBStates, Retains, Releases, M, Retain, DeadInsts,
- RetainsToMove, ReleasesToMove, Arg, KnownSafe,
- AnyPairsCompletelyEliminated);
- if (PerformMoveCalls) {
- // Ok, everything checks out and we're all set. Let's move/delete some
- // code!
- MoveCalls(Arg, RetainsToMove, ReleasesToMove,
- Retains, Releases, DeadInsts, M);
- }
- }
- // Now that we're done moving everything, we can delete the newly dead
- // instructions, as we no longer need them as insert points.
- while (!DeadInsts.empty())
- EraseInstruction(DeadInsts.pop_back_val());
- return AnyPairsCompletelyEliminated;
- }
- /// Weak pointer optimizations.
- void ObjCARCOpt::OptimizeWeakCalls(Function &F) {
- LLVM_DEBUG(dbgs() << "\n== ObjCARCOpt::OptimizeWeakCalls ==\n");
- // First, do memdep-style RLE and S2L optimizations. We can't use memdep
- // itself because it uses AliasAnalysis and we need to do provenance
- // queries instead.
- for (inst_iterator I = inst_begin(&F), E = inst_end(&F); I != E; ) {
- Instruction *Inst = &*I++;
- LLVM_DEBUG(dbgs() << "Visiting: " << *Inst << "\n");
- ARCInstKind Class = GetBasicARCInstKind(Inst);
- if (Class != ARCInstKind::LoadWeak &&
- Class != ARCInstKind::LoadWeakRetained)
- continue;
- // Delete objc_loadWeak calls with no users.
- if (Class == ARCInstKind::LoadWeak && Inst->use_empty()) {
- Inst->eraseFromParent();
- Changed = true;
- continue;
- }
- // TODO: For now, just look for an earlier available version of this value
- // within the same block. Theoretically, we could do memdep-style non-local
- // analysis too, but that would want caching. A better approach would be to
- // use the technique that EarlyCSE uses.
- inst_iterator Current = std::prev(I);
- BasicBlock *CurrentBB = &*Current.getBasicBlockIterator();
- for (BasicBlock::iterator B = CurrentBB->begin(),
- J = Current.getInstructionIterator();
- J != B; --J) {
- Instruction *EarlierInst = &*std::prev(J);
- ARCInstKind EarlierClass = GetARCInstKind(EarlierInst);
- switch (EarlierClass) {
- case ARCInstKind::LoadWeak:
- case ARCInstKind::LoadWeakRetained: {
- // If this is loading from the same pointer, replace this load's value
- // with that one.
- CallInst *Call = cast<CallInst>(Inst);
- CallInst *EarlierCall = cast<CallInst>(EarlierInst);
- Value *Arg = Call->getArgOperand(0);
- Value *EarlierArg = EarlierCall->getArgOperand(0);
- switch (PA.getAA()->alias(Arg, EarlierArg)) {
- case AliasResult::MustAlias:
- Changed = true;
- // If the load has a builtin retain, insert a plain retain for it.
- if (Class == ARCInstKind::LoadWeakRetained) {
- Function *Decl = EP.get(ARCRuntimeEntryPointKind::Retain);
- CallInst *CI = CallInst::Create(Decl, EarlierCall, "", Call);
- CI->setTailCall();
- }
- // Zap the fully redundant load.
- Call->replaceAllUsesWith(EarlierCall);
- Call->eraseFromParent();
- goto clobbered;
- case AliasResult::MayAlias:
- case AliasResult::PartialAlias:
- goto clobbered;
- case AliasResult::NoAlias:
- break;
- }
- break;
- }
- case ARCInstKind::StoreWeak:
- case ARCInstKind::InitWeak: {
- // If this is storing to the same pointer and has the same size etc.
- // replace this load's value with the stored value.
- CallInst *Call = cast<CallInst>(Inst);
- CallInst *EarlierCall = cast<CallInst>(EarlierInst);
- Value *Arg = Call->getArgOperand(0);
- Value *EarlierArg = EarlierCall->getArgOperand(0);
- switch (PA.getAA()->alias(Arg, EarlierArg)) {
- case AliasResult::MustAlias:
- Changed = true;
- // If the load has a builtin retain, insert a plain retain for it.
- if (Class == ARCInstKind::LoadWeakRetained) {
- Function *Decl = EP.get(ARCRuntimeEntryPointKind::Retain);
- CallInst *CI = CallInst::Create(Decl, EarlierCall, "", Call);
- CI->setTailCall();
- }
- // Zap the fully redundant load.
- Call->replaceAllUsesWith(EarlierCall->getArgOperand(1));
- Call->eraseFromParent();
- goto clobbered;
- case AliasResult::MayAlias:
- case AliasResult::PartialAlias:
- goto clobbered;
- case AliasResult::NoAlias:
- break;
- }
- break;
- }
- case ARCInstKind::MoveWeak:
- case ARCInstKind::CopyWeak:
- // TOOD: Grab the copied value.
- goto clobbered;
- case ARCInstKind::AutoreleasepoolPush:
- case ARCInstKind::None:
- case ARCInstKind::IntrinsicUser:
- case ARCInstKind::User:
- // Weak pointers are only modified through the weak entry points
- // (and arbitrary calls, which could call the weak entry points).
- break;
- default:
- // Anything else could modify the weak pointer.
- goto clobbered;
- }
- }
- clobbered:;
- }
- // Then, for each destroyWeak with an alloca operand, check to see if
- // the alloca and all its users can be zapped.
- for (Instruction &Inst : llvm::make_early_inc_range(instructions(F))) {
- ARCInstKind Class = GetBasicARCInstKind(&Inst);
- if (Class != ARCInstKind::DestroyWeak)
- continue;
- CallInst *Call = cast<CallInst>(&Inst);
- Value *Arg = Call->getArgOperand(0);
- if (AllocaInst *Alloca = dyn_cast<AllocaInst>(Arg)) {
- for (User *U : Alloca->users()) {
- const Instruction *UserInst = cast<Instruction>(U);
- switch (GetBasicARCInstKind(UserInst)) {
- case ARCInstKind::InitWeak:
- case ARCInstKind::StoreWeak:
- case ARCInstKind::DestroyWeak:
- continue;
- default:
- goto done;
- }
- }
- Changed = true;
- for (User *U : llvm::make_early_inc_range(Alloca->users())) {
- CallInst *UserInst = cast<CallInst>(U);
- switch (GetBasicARCInstKind(UserInst)) {
- case ARCInstKind::InitWeak:
- case ARCInstKind::StoreWeak:
- // These functions return their second argument.
- UserInst->replaceAllUsesWith(UserInst->getArgOperand(1));
- break;
- case ARCInstKind::DestroyWeak:
- // No return value.
- break;
- default:
- llvm_unreachable("alloca really is used!");
- }
- UserInst->eraseFromParent();
- }
- Alloca->eraseFromParent();
- done:;
- }
- }
- }
- /// Identify program paths which execute sequences of retains and releases which
- /// can be eliminated.
- bool ObjCARCOpt::OptimizeSequences(Function &F) {
- // Releases, Retains - These are used to store the results of the main flow
- // analysis. These use Value* as the key instead of Instruction* so that the
- // map stays valid when we get around to rewriting code and calls get
- // replaced by arguments.
- DenseMap<Value *, RRInfo> Releases;
- BlotMapVector<Value *, RRInfo> Retains;
- // This is used during the traversal of the function to track the
- // states for each identified object at each block.
- DenseMap<const BasicBlock *, BBState> BBStates;
- // Analyze the CFG of the function, and all instructions.
- bool NestingDetected = Visit(F, BBStates, Retains, Releases);
- if (DisableRetainReleasePairing)
- return false;
- // Transform.
- bool AnyPairsCompletelyEliminated = PerformCodePlacement(BBStates, Retains,
- Releases,
- F.getParent());
- return AnyPairsCompletelyEliminated && NestingDetected;
- }
- /// Check if there is a dependent call earlier that does not have anything in
- /// between the Retain and the call that can affect the reference count of their
- /// shared pointer argument. Note that Retain need not be in BB.
- static CallInst *HasSafePathToPredecessorCall(const Value *Arg,
- Instruction *Retain,
- ProvenanceAnalysis &PA) {
- auto *Call = dyn_cast_or_null<CallInst>(findSingleDependency(
- CanChangeRetainCount, Arg, Retain->getParent(), Retain, PA));
- // Check that the pointer is the return value of the call.
- if (!Call || Arg != Call)
- return nullptr;
- // Check that the call is a regular call.
- ARCInstKind Class = GetBasicARCInstKind(Call);
- return Class == ARCInstKind::CallOrUser || Class == ARCInstKind::Call
- ? Call
- : nullptr;
- }
- /// Find a dependent retain that precedes the given autorelease for which there
- /// is nothing in between the two instructions that can affect the ref count of
- /// Arg.
- static CallInst *
- FindPredecessorRetainWithSafePath(const Value *Arg, BasicBlock *BB,
- Instruction *Autorelease,
- ProvenanceAnalysis &PA) {
- auto *Retain = dyn_cast_or_null<CallInst>(
- findSingleDependency(CanChangeRetainCount, Arg, BB, Autorelease, PA));
- // Check that we found a retain with the same argument.
- if (!Retain || !IsRetain(GetBasicARCInstKind(Retain)) ||
- GetArgRCIdentityRoot(Retain) != Arg) {
- return nullptr;
- }
- return Retain;
- }
- /// Look for an ``autorelease'' instruction dependent on Arg such that there are
- /// no instructions dependent on Arg that need a positive ref count in between
- /// the autorelease and the ret.
- static CallInst *
- FindPredecessorAutoreleaseWithSafePath(const Value *Arg, BasicBlock *BB,
- ReturnInst *Ret,
- ProvenanceAnalysis &PA) {
- SmallPtrSet<Instruction *, 4> DepInsts;
- auto *Autorelease = dyn_cast_or_null<CallInst>(
- findSingleDependency(NeedsPositiveRetainCount, Arg, BB, Ret, PA));
- if (!Autorelease)
- return nullptr;
- ARCInstKind AutoreleaseClass = GetBasicARCInstKind(Autorelease);
- if (!IsAutorelease(AutoreleaseClass))
- return nullptr;
- if (GetArgRCIdentityRoot(Autorelease) != Arg)
- return nullptr;
- return Autorelease;
- }
- /// Look for this pattern:
- /// \code
- /// %call = call i8* @something(...)
- /// %2 = call i8* @objc_retain(i8* %call)
- /// %3 = call i8* @objc_autorelease(i8* %2)
- /// ret i8* %3
- /// \endcode
- /// And delete the retain and autorelease.
- void ObjCARCOpt::OptimizeReturns(Function &F) {
- if (!F.getReturnType()->isPointerTy())
- return;
- LLVM_DEBUG(dbgs() << "\n== ObjCARCOpt::OptimizeReturns ==\n");
- for (BasicBlock &BB: F) {
- ReturnInst *Ret = dyn_cast<ReturnInst>(&BB.back());
- if (!Ret)
- continue;
- LLVM_DEBUG(dbgs() << "Visiting: " << *Ret << "\n");
- const Value *Arg = GetRCIdentityRoot(Ret->getOperand(0));
- // Look for an ``autorelease'' instruction that is a predecessor of Ret and
- // dependent on Arg such that there are no instructions dependent on Arg
- // that need a positive ref count in between the autorelease and Ret.
- CallInst *Autorelease =
- FindPredecessorAutoreleaseWithSafePath(Arg, &BB, Ret, PA);
- if (!Autorelease)
- continue;
- CallInst *Retain = FindPredecessorRetainWithSafePath(
- Arg, Autorelease->getParent(), Autorelease, PA);
- if (!Retain)
- continue;
- // Check that there is nothing that can affect the reference count
- // between the retain and the call. Note that Retain need not be in BB.
- CallInst *Call = HasSafePathToPredecessorCall(Arg, Retain, PA);
- // Don't remove retainRV/autoreleaseRV pairs if the call isn't a tail call.
- if (!Call ||
- (!Call->isTailCall() &&
- GetBasicARCInstKind(Retain) == ARCInstKind::RetainRV &&
- GetBasicARCInstKind(Autorelease) == ARCInstKind::AutoreleaseRV))
- continue;
- // If so, we can zap the retain and autorelease.
- Changed = true;
- ++NumRets;
- LLVM_DEBUG(dbgs() << "Erasing: " << *Retain << "\nErasing: " << *Autorelease
- << "\n");
- BundledInsts->eraseInst(Retain);
- EraseInstruction(Autorelease);
- }
- }
- #ifndef NDEBUG
- void
- ObjCARCOpt::GatherStatistics(Function &F, bool AfterOptimization) {
- Statistic &NumRetains =
- AfterOptimization ? NumRetainsAfterOpt : NumRetainsBeforeOpt;
- Statistic &NumReleases =
- AfterOptimization ? NumReleasesAfterOpt : NumReleasesBeforeOpt;
- for (inst_iterator I = inst_begin(&F), E = inst_end(&F); I != E; ) {
- Instruction *Inst = &*I++;
- switch (GetBasicARCInstKind(Inst)) {
- default:
- break;
- case ARCInstKind::Retain:
- ++NumRetains;
- break;
- case ARCInstKind::Release:
- ++NumReleases;
- break;
- }
- }
- }
- #endif
- void ObjCARCOpt::init(Function &F) {
- if (!EnableARCOpts)
- return;
- // Intuitively, objc_retain and others are nocapture, however in practice
- // they are not, because they return their argument value. And objc_release
- // calls finalizers which can have arbitrary side effects.
- MDKindCache.init(F.getParent());
- // Initialize our runtime entry point cache.
- EP.init(F.getParent());
- // Compute which blocks are in which funclet.
- if (F.hasPersonalityFn() &&
- isScopedEHPersonality(classifyEHPersonality(F.getPersonalityFn())))
- BlockEHColors = colorEHFunclets(F);
- }
- bool ObjCARCOpt::run(Function &F, AAResults &AA) {
- if (!EnableARCOpts)
- return false;
- Changed = CFGChanged = false;
- BundledRetainClaimRVs BRV(/*ContractPass=*/false);
- BundledInsts = &BRV;
- LLVM_DEBUG(dbgs() << "<<< ObjCARCOpt: Visiting Function: " << F.getName()
- << " >>>"
- "\n");
- std::pair<bool, bool> R = BundledInsts->insertAfterInvokes(F, nullptr);
- Changed |= R.first;
- CFGChanged |= R.second;
- PA.setAA(&AA);
- #ifndef NDEBUG
- if (AreStatisticsEnabled()) {
- GatherStatistics(F, false);
- }
- #endif
- // This pass performs several distinct transformations. As a compile-time aid
- // when compiling code that isn't ObjC, skip these if the relevant ObjC
- // library functions aren't declared.
- // Preliminary optimizations. This also computes UsedInThisFunction.
- OptimizeIndividualCalls(F);
- // Optimizations for weak pointers.
- if (UsedInThisFunction & ((1 << unsigned(ARCInstKind::LoadWeak)) |
- (1 << unsigned(ARCInstKind::LoadWeakRetained)) |
- (1 << unsigned(ARCInstKind::StoreWeak)) |
- (1 << unsigned(ARCInstKind::InitWeak)) |
- (1 << unsigned(ARCInstKind::CopyWeak)) |
- (1 << unsigned(ARCInstKind::MoveWeak)) |
- (1 << unsigned(ARCInstKind::DestroyWeak))))
- OptimizeWeakCalls(F);
- // Optimizations for retain+release pairs.
- if (UsedInThisFunction & ((1 << unsigned(ARCInstKind::Retain)) |
- (1 << unsigned(ARCInstKind::RetainRV)) |
- (1 << unsigned(ARCInstKind::RetainBlock))))
- if (UsedInThisFunction & (1 << unsigned(ARCInstKind::Release)))
- // Run OptimizeSequences until it either stops making changes or
- // no retain+release pair nesting is detected.
- while (OptimizeSequences(F)) {}
- // Optimizations if objc_autorelease is used.
- if (UsedInThisFunction & ((1 << unsigned(ARCInstKind::Autorelease)) |
- (1 << unsigned(ARCInstKind::AutoreleaseRV))))
- OptimizeReturns(F);
- // Gather statistics after optimization.
- #ifndef NDEBUG
- if (AreStatisticsEnabled()) {
- GatherStatistics(F, true);
- }
- #endif
- LLVM_DEBUG(dbgs() << "\n");
- return Changed;
- }
- /// @}
- ///
- PreservedAnalyses ObjCARCOptPass::run(Function &F,
- FunctionAnalysisManager &AM) {
- ObjCARCOpt OCAO;
- OCAO.init(F);
- bool Changed = OCAO.run(F, AM.getResult<AAManager>(F));
- bool CFGChanged = OCAO.hasCFGChanged();
- if (Changed) {
- PreservedAnalyses PA;
- if (!CFGChanged)
- PA.preserveSet<CFGAnalyses>();
- return PA;
- }
- return PreservedAnalyses::all();
- }
|