fix-unused.patch 3.8 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485
  1. --- a/cpp/src/arrow/array/builder_binary.h
  2. +++ b/cpp/src/arrow/array/builder_binary.h
  3. @@ -53,7 +53,7 @@ class BaseBinaryBuilder : public ArrayBuilder {
  4. explicit BaseBinaryBuilder(MemoryPool* pool = default_memory_pool())
  5. : ArrayBuilder(pool), offsets_builder_(pool), value_data_builder_(pool) {}
  6. - BaseBinaryBuilder(const std::shared_ptr<DataType>& type, MemoryPool* pool)
  7. + BaseBinaryBuilder(const std::shared_ptr<DataType>& /*type*/, MemoryPool* pool)
  8. : BaseBinaryBuilder(pool) {}
  9. Status Append(const uint8_t* value, offset_type length) {
  10. --- a/cpp/src/arrow/array/builder_dict.h
  11. +++ b/cpp/src/arrow/array/builder_dict.h
  12. @@ -400,11 +400,11 @@ class DictionaryBuilderBase<BuilderType, NullType> : public ArrayBuilder {
  13. DictionaryBuilderBase(
  14. enable_if_t<std::is_base_of<AdaptiveIntBuilderBase, B>::value, uint8_t>
  15. start_int_size,
  16. - const std::shared_ptr<DataType>& value_type,
  17. + const std::shared_ptr<DataType>& /*value_type*/,
  18. MemoryPool* pool = default_memory_pool())
  19. : ArrayBuilder(pool), indices_builder_(start_int_size, pool) {}
  20. - explicit DictionaryBuilderBase(const std::shared_ptr<DataType>& value_type,
  21. + explicit DictionaryBuilderBase(const std::shared_ptr<DataType>& /*value_type*/,
  22. MemoryPool* pool = default_memory_pool())
  23. : ArrayBuilder(pool), indices_builder_(pool) {}
  24. @@ -418,7 +418,7 @@ class DictionaryBuilderBase<BuilderType, NullType> : public ArrayBuilder {
  25. explicit DictionaryBuilderBase(MemoryPool* pool = default_memory_pool())
  26. : ArrayBuilder(pool), indices_builder_(pool) {}
  27. - explicit DictionaryBuilderBase(const std::shared_ptr<Array>& dictionary,
  28. + explicit DictionaryBuilderBase(const std::shared_ptr<Array>& /*dictionary*/,
  29. MemoryPool* pool = default_memory_pool())
  30. : ArrayBuilder(pool), indices_builder_(pool) {}
  31. --- a/cpp/src/arrow/array/builder_primitive.h
  32. +++ b/cpp/src/arrow/array/builder_primitive.h
  33. @@ -31,7 +31,7 @@ namespace arrow {
  34. class ARROW_EXPORT NullBuilder : public ArrayBuilder {
  35. public:
  36. explicit NullBuilder(MemoryPool* pool = default_memory_pool()) : ArrayBuilder(pool) {}
  37. - explicit NullBuilder(const std::shared_ptr<DataType>& type,
  38. + explicit NullBuilder(const std::shared_ptr<DataType>& /*type*/,
  39. MemoryPool* pool = default_memory_pool())
  40. : NullBuilder(pool) {}
  41. --- a/cpp/src/arrow/util/mutex.h
  42. +++ b/cpp/src/arrow/util/mutex.h
  43. @@ -37,7 +37,7 @@ class ARROW_EXPORT Mutex {
  44. /// A Guard is falsy if a lock could not be acquired.
  45. class ARROW_EXPORT Guard {
  46. public:
  47. - Guard() : locked_(NULLPTR, [](Mutex* mutex) {}) {}
  48. + Guard() : locked_(NULLPTR, [](Mutex* /* mutex */) {}) {}
  49. Guard(Guard&&) = default;
  50. Guard& operator=(Guard&&) = default;
  51. --- a/cpp/src/arrow/util/variant.h
  52. +++ b/cpp/src/arrow/util/variant.h
  53. @@ -144,11 +144,11 @@ struct VariantImpl<Variant<T...>> : VariantStorage<T...> {
  54. void copy_to(...) const {}
  55. template <typename R, typename Visitor>
  56. - [[noreturn]] R visit_const(Visitor&& visitor) const {
  57. + [[noreturn]] R visit_const(Visitor&& /* visitor */) const {
  58. std::terminate();
  59. }
  60. template <typename R, typename Visitor>
  61. - [[noreturn]] R visit_mutable(Visitor&& visitor) {
  62. + [[noreturn]] R visit_mutable(Visitor&& /* visitor */) {
  63. std::terminate();
  64. }
  65. };
  66. --- a/cpp/src/arrow/util/value_parsing.h
  67. +++ b/cpp/src/arrow/util/value_parsing.h
  68. @@ -717,7 +717,7 @@ struct StringConverter<DATE_TYPE, enable_if_date<DATE_TYPE>> {
  69. arrow_vendored::date::days,
  70. std::chrono::milliseconds>::type;
  71. - static bool Convert(const DATE_TYPE& type, const char* s, size_t length,
  72. + static bool Convert(const DATE_TYPE& /* type */, const char* s, size_t length,
  73. value_type* out) {
  74. if (length != 10) return false;