backend.yml 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385
  1. name: backend
  2. on:
  3. push:
  4. branches:
  5. - master
  6. pull_request:
  7. # Cancel in progress workflows on pull_requests.
  8. # https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
  9. concurrency:
  10. group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
  11. cancel-in-progress: true
  12. # hack for https://github.com/actions/cache/issues/810#issuecomment-1222550359
  13. env:
  14. SEGMENT_DOWNLOAD_TIMEOUT_MINS: 3
  15. jobs:
  16. files-changed:
  17. name: detect what files changed
  18. runs-on: ubuntu-22.04
  19. timeout-minutes: 3
  20. # Map a step output to a job output
  21. outputs:
  22. api_docs: ${{ steps.changes.outputs.api_docs }}
  23. backend: ${{ steps.changes.outputs.backend_all }}
  24. backend_dependencies: ${{ steps.changes.outputs.backend_dependencies }}
  25. backend_any_type: ${{ steps.changes.outputs.backend_any_type }}
  26. migration_lockfile: ${{ steps.changes.outputs.migration_lockfile }}
  27. steps:
  28. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  29. - name: Check for backend file changes
  30. uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
  31. id: changes
  32. with:
  33. token: ${{ github.token }}
  34. filters: .github/file-filters.yml
  35. api-docs:
  36. if: needs.files-changed.outputs.api_docs == 'true'
  37. needs: files-changed
  38. name: api docs test
  39. runs-on: ubuntu-22.04
  40. steps:
  41. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  42. - uses: getsentry/action-setup-volta@e4939d337b83760d13a9d7030a6f68c9d0ee7581 # v2.0.0
  43. - name: Setup sentry python env
  44. uses: ./.github/actions/setup-sentry
  45. id: setup
  46. with:
  47. snuba: true
  48. - name: Run API docs tests
  49. # install ts-node for ts build scripts to execute properly without potentially installing
  50. # conflicting deps when running scripts locally
  51. # see: https://github.com/getsentry/sentry/pull/32328/files
  52. run: |
  53. yarn add ts-node && make test-api-docs
  54. backend-test:
  55. if: needs.files-changed.outputs.backend == 'true'
  56. needs: files-changed
  57. name: backend test
  58. runs-on: ubuntu-22.04
  59. timeout-minutes: 60
  60. permissions:
  61. contents: read
  62. id-token: write
  63. strategy:
  64. # This helps not having to run multiple jobs because one fails, thus, reducing resource usage
  65. # and reducing the risk that one of many runs would turn red again (read: intermittent tests)
  66. fail-fast: false
  67. matrix:
  68. # XXX: When updating this, make sure you also update MATRIX_INSTANCE_TOTAL.
  69. instance: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
  70. pg-version: ['14']
  71. env:
  72. # XXX: `MATRIX_INSTANCE_TOTAL` must be hardcoded to the length of `strategy.matrix.instance`.
  73. # If this increases, make sure to also increase `flags.backend.after_n_builds` in `codecov.yml`.
  74. MATRIX_INSTANCE_TOTAL: 11
  75. steps:
  76. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  77. with:
  78. # Avoid codecov error message related to SHA resolution:
  79. # https://github.com/codecov/codecov-bash/blob/7100762afbc822b91806a6574658129fe0d23a7d/codecov#L891
  80. fetch-depth: '2'
  81. - name: Setup sentry env
  82. uses: ./.github/actions/setup-sentry
  83. id: setup
  84. with:
  85. redis_cluster: true
  86. kafka: true
  87. snuba: true
  88. symbolicator: true
  89. peanutbutter: true
  90. # Right now, we run so few bigtable related tests that the
  91. # overhead of running bigtable in all backend tests
  92. # is way smaller than the time it would take to run in its own job.
  93. bigtable: true
  94. pg-version: ${{ matrix.pg-version }}
  95. - name: Run backend test (${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }})
  96. run: |
  97. make test-python-ci
  98. - name: Collect test data
  99. uses: ./.github/actions/collect-test-data
  100. if: ${{ !cancelled() }}
  101. with:
  102. artifact_path: .artifacts/pytest.json
  103. gcs_bucket: ${{ secrets.COLLECT_TEST_DATA_GCS_BUCKET }}
  104. gcp_project_id: ${{ secrets.COLLECT_TEST_DATA_GCP_PROJECT_ID }}
  105. workload_identity_provider: ${{ secrets.SENTRY_GCP_DEV_WORKLOAD_IDENTITY_POOL }}
  106. service_account_email: ${{ secrets.COLLECT_TEST_DATA_SERVICE_ACCOUNT_EMAIL }}
  107. matrix_instance_number: ${{ steps.setup.outputs.matrix-instance-number }}
  108. # Upload coverage data even if running the tests step fails since
  109. # it reduces large coverage fluctuations
  110. - name: Handle artifacts
  111. if: ${{ always() }}
  112. uses: ./.github/actions/artifacts
  113. with:
  114. token: ${{ secrets.CODECOV_TOKEN }}
  115. backend-migration-tests:
  116. if: needs.files-changed.outputs.backend == 'true'
  117. needs: files-changed
  118. name: backend migration tests
  119. runs-on: ubuntu-22.04
  120. timeout-minutes: 30
  121. strategy:
  122. matrix:
  123. pg-version: ['14']
  124. steps:
  125. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  126. with:
  127. # Avoid codecov error message related to SHA resolution:
  128. # https://github.com/codecov/codecov-bash/blob/7100762afbc822b91806a6574658129fe0d23a7d/codecov#L891
  129. fetch-depth: '2'
  130. - name: Setup sentry env
  131. uses: ./.github/actions/setup-sentry
  132. id: setup
  133. with:
  134. snuba: true
  135. pg-version: ${{ matrix.pg-version }}
  136. - name: run tests
  137. run: |
  138. PYTEST_ADDOPTS="$PYTEST_ADDOPTS -m migrations --migrations --reruns 0" make test-python-ci
  139. # Upload coverage data even if running the tests step fails since
  140. # it reduces large coverage fluctuations
  141. - name: Handle artifacts
  142. if: ${{ always() }}
  143. uses: ./.github/actions/artifacts
  144. with:
  145. token: ${{ secrets.CODECOV_TOKEN }}
  146. cli:
  147. if: needs.files-changed.outputs.backend == 'true'
  148. needs: files-changed
  149. name: cli test
  150. runs-on: ubuntu-22.04
  151. timeout-minutes: 10
  152. strategy:
  153. matrix:
  154. pg-version: ['14']
  155. steps:
  156. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  157. - name: Setup sentry env
  158. uses: ./.github/actions/setup-sentry
  159. id: setup
  160. with:
  161. pg-version: ${{ matrix.pg-version }}
  162. - name: Run test
  163. run: |
  164. make test-cli
  165. # Upload coverage data even if running the tests step fails since
  166. # it reduces large coverage fluctuations
  167. - name: Handle artifacts
  168. if: ${{ always() }}
  169. uses: ./.github/actions/artifacts
  170. with:
  171. token: ${{ secrets.CODECOV_TOKEN }}
  172. requirements:
  173. if: needs.files-changed.outputs.backend_dependencies == 'true'
  174. needs: files-changed
  175. name: requirements check
  176. runs-on: ubuntu-22.04
  177. timeout-minutes: 3
  178. steps:
  179. - uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
  180. id: token
  181. continue-on-error: true
  182. with:
  183. app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
  184. private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
  185. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  186. - uses: getsentry/action-setup-venv@a133e6fd5fa6abd3f590a1c106abda344f5df69f # v2.1.0
  187. with:
  188. python-version: 3.11.8
  189. cache-dependency-path: requirements-dev-frozen.txt
  190. install-cmd: python3 -m tools.hack_pip && pip install -q --constraint requirements-dev-frozen.txt pip-tools
  191. - name: check requirements
  192. run: |
  193. python -S -m tools.freeze_requirements
  194. if ! git diff --exit-code; then
  195. echo $'\n\nrun `make freeze-requirements` locally to update requirements'
  196. exit 1
  197. fi
  198. - name: apply any requirements changes
  199. if: steps.token.outcome == 'success' && github.ref != 'refs/heads/master' && always()
  200. uses: getsentry/action-github-commit@31f6706ca1a7b9ad6d22c1b07bf3a92eabb05632 # v2.0.0
  201. with:
  202. github-token: ${{ steps.token.outputs.token }}
  203. message: ':snowflake: re-freeze requirements'
  204. migration:
  205. if: needs.files-changed.outputs.migration_lockfile == 'true'
  206. needs: files-changed
  207. name: check migration
  208. runs-on: ubuntu-22.04
  209. strategy:
  210. matrix:
  211. pg-version: ['14']
  212. steps:
  213. - name: Checkout sentry
  214. uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  215. - name: Setup sentry env
  216. uses: ./.github/actions/setup-sentry
  217. id: setup
  218. with:
  219. pg-version: ${{ matrix.pg-version }}
  220. - name: Migration & lockfile checks
  221. env:
  222. SENTRY_LOG_LEVEL: ERROR
  223. PGPASSWORD: postgres
  224. run: |
  225. ./.github/workflows/scripts/migration-check.sh
  226. monolith-dbs:
  227. if: needs.files-changed.outputs.backend == 'true'
  228. needs: files-changed
  229. name: monolith-dbs test
  230. runs-on: ubuntu-22.04
  231. timeout-minutes: 20
  232. permissions:
  233. contents: read
  234. id-token: write
  235. steps:
  236. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  237. with:
  238. # Avoid codecov error message related to SHA resolution:
  239. # https://github.com/codecov/codecov-bash/blob/7100762afbc822b91806a6574658129fe0d23a7d/codecov#L891
  240. fetch-depth: '2'
  241. - name: Setup sentry env
  242. uses: ./.github/actions/setup-sentry
  243. id: setup
  244. - name: Run test
  245. run: |
  246. make test-monolith-dbs
  247. - name: Collect test data
  248. uses: ./.github/actions/collect-test-data
  249. if: ${{ !cancelled() }}
  250. with:
  251. artifact_path: .artifacts/pytest.monolith-dbs.json
  252. gcs_bucket: ${{ secrets.COLLECT_TEST_DATA_GCS_BUCKET }}
  253. gcp_project_id: ${{ secrets.COLLECT_TEST_DATA_GCP_PROJECT_ID }}
  254. workload_identity_provider: ${{ secrets.SENTRY_GCP_DEV_WORKLOAD_IDENTITY_POOL }}
  255. service_account_email: ${{ secrets.COLLECT_TEST_DATA_SERVICE_ACCOUNT_EMAIL }}
  256. # Upload coverage data even if running the tests step fails since
  257. # it reduces large coverage fluctuations
  258. - name: Handle artifacts
  259. if: ${{ always() }}
  260. uses: ./.github/actions/artifacts
  261. with:
  262. token: ${{ secrets.CODECOV_TOKEN }}
  263. typing:
  264. if: needs.files-changed.outputs.backend == 'true'
  265. needs: files-changed
  266. name: backend typing
  267. runs-on: ubuntu-22.04
  268. timeout-minutes: 20
  269. steps:
  270. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  271. - uses: getsentry/action-setup-venv@a133e6fd5fa6abd3f590a1c106abda344f5df69f # v2.1.0
  272. with:
  273. python-version: 3.11.8
  274. cache-dependency-path: requirements-dev-frozen.txt
  275. install-cmd: python3 -m tools.hack_pip && pip install -r requirements-dev-frozen.txt
  276. - name: setup sentry (lite)
  277. run: |
  278. python3 -m tools.fast_editable --path .
  279. sentry init
  280. - run: mypy
  281. id: run
  282. - uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
  283. id: token
  284. continue-on-error: true
  285. with:
  286. app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
  287. private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
  288. # only if `mypy` succeeds should we try and trim the blocklist
  289. - run: python3 -m tools.mypy_helpers.make_module_ignores
  290. id: regen-blocklist
  291. - run: git diff --exit-code
  292. - run: |
  293. # mypy does not have granular codes so don't allow specific messages to regress
  294. ! grep "'Settings' object has no attribute" .artifacts/mypy-all
  295. ! grep 'Cannot override class variable' .artifacts/mypy-all
  296. ! grep 'Exception type must be derived from BaseException' .artifacts/mypy-all
  297. ! grep 'Incompatible default for argument' .artifacts/mypy-all
  298. ! grep 'Incompatible return value type (got "HttpResponseBase"' .artifacts/mypy-all
  299. ! grep 'Incompatible types in "yield"' .artifacts/mypy-all
  300. ! grep 'Module "sentry.*has no attribute' .artifacts/mypy-all
  301. ! grep 'base class .* defined the type as.*Permission' .artifacts/mypy-all
  302. ! grep 'does not explicitly export attribute' .artifacts/mypy-all
  303. - name: apply blocklist changes
  304. if: |
  305. steps.token.outcome == 'success' &&
  306. steps.run.outcome == 'success' &&
  307. steps.regen-blocklist.outcome == 'success' &&
  308. github.ref != 'refs/heads/master' &&
  309. always()
  310. uses: getsentry/action-github-commit@31f6706ca1a7b9ad6d22c1b07bf3a92eabb05632 # v2.0.0
  311. with:
  312. github-token: ${{ steps.token.outputs.token }}
  313. message: ':knife: regenerate mypy module blocklist'
  314. # This check runs once all dependent jobs have passed
  315. # It symbolizes that all required Backend checks have succesfully passed (Or skipped)
  316. # This step is the only required backend check
  317. backend-required-check:
  318. needs:
  319. [
  320. api-docs,
  321. backend-test,
  322. backend-migration-tests,
  323. cli,
  324. files-changed,
  325. requirements,
  326. migration,
  327. monolith-dbs,
  328. typing,
  329. ]
  330. name: Backend
  331. # This is necessary since a failed/skipped dependent job would cause this job to be skipped
  332. if: always()
  333. runs-on: ubuntu-22.04
  334. steps:
  335. # If any jobs we depend on fail, we will fail since this is a required check
  336. # NOTE: A timeout is considered a failure
  337. - name: Check for failures
  338. if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
  339. run: |
  340. echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1