assigneeSelector.spec.jsx 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405
  1. import {act, render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
  2. import {openInviteMembersModal} from 'sentry/actionCreators/modal';
  3. import {Client} from 'sentry/api';
  4. import AssigneeSelectorComponent from 'sentry/components/assigneeSelector';
  5. import {putSessionUserFirst} from 'sentry/components/assigneeSelectorDropdown';
  6. import ConfigStore from 'sentry/stores/configStore';
  7. import GroupStore from 'sentry/stores/groupStore';
  8. import IndicatorStore from 'sentry/stores/indicatorStore';
  9. import MemberListStore from 'sentry/stores/memberListStore';
  10. import ProjectsStore from 'sentry/stores/projectsStore';
  11. import TeamStore from 'sentry/stores/teamStore';
  12. jest.mock('sentry/actionCreators/modal', () => ({
  13. openInviteMembersModal: jest.fn(),
  14. }));
  15. describe('AssigneeSelector', () => {
  16. let assignMock;
  17. let assignGroup2Mock;
  18. let USER_1, USER_2, USER_3, USER_4;
  19. let TEAM_1;
  20. let PROJECT_1;
  21. let GROUP_1;
  22. let GROUP_2;
  23. beforeEach(() => {
  24. USER_1 = TestStubs.User({
  25. id: '1',
  26. name: 'Jane Bloggs',
  27. email: 'janebloggs@example.com',
  28. });
  29. USER_2 = TestStubs.User({
  30. id: '2',
  31. name: 'John Smith',
  32. email: 'johnsmith@example.com',
  33. });
  34. USER_3 = TestStubs.User({
  35. id: '3',
  36. name: 'J J',
  37. email: 'jj@example.com',
  38. });
  39. USER_4 = TestStubs.Member({
  40. id: '4',
  41. name: 'Jane Doe',
  42. email: 'janedoe@example.com',
  43. team_slug: 'cool-team2',
  44. });
  45. TEAM_1 = TestStubs.Team({
  46. id: '3',
  47. name: 'COOL TEAM',
  48. slug: 'cool-team',
  49. });
  50. PROJECT_1 = TestStubs.Project({
  51. teams: [TEAM_1],
  52. });
  53. GROUP_1 = TestStubs.Group({
  54. id: '1337',
  55. project: {
  56. id: PROJECT_1.id,
  57. slug: PROJECT_1.slug,
  58. },
  59. });
  60. GROUP_2 = TestStubs.Group({
  61. id: '1338',
  62. project: {
  63. id: PROJECT_1.id,
  64. slug: PROJECT_1.slug,
  65. },
  66. owners: [
  67. {
  68. type: 'suspectCommit',
  69. owner: `user:${USER_1.id}`,
  70. date_added: '',
  71. },
  72. ],
  73. });
  74. TeamStore.reset();
  75. TeamStore.setTeams([TEAM_1]);
  76. GroupStore.reset();
  77. GroupStore.loadInitialData([GROUP_1, GROUP_2]);
  78. jest.spyOn(MemberListStore, 'getAll').mockImplementation(() => null);
  79. jest.spyOn(ProjectsStore, 'getAll').mockImplementation(() => [PROJECT_1]);
  80. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_1);
  81. assignMock = Client.addMockResponse({
  82. method: 'PUT',
  83. url: `/issues/${GROUP_1.id}/`,
  84. body: {
  85. ...GROUP_1,
  86. assignedTo: {...USER_1, type: 'user'},
  87. },
  88. });
  89. assignGroup2Mock = Client.addMockResponse({
  90. method: 'PUT',
  91. url: `/issues/${GROUP_2.id}/`,
  92. body: {
  93. ...GROUP_2,
  94. assignedTo: {...USER_1, type: 'user'},
  95. },
  96. });
  97. MemberListStore.reset();
  98. });
  99. // Doesn't need to always be async, but it was easier to prevent flakes this way
  100. const openMenu = async () => {
  101. await userEvent.click(await screen.findByTestId('assignee-selector'), undefined, {
  102. // Skip hover to prevent tooltip from rendering
  103. skipHover: true,
  104. });
  105. };
  106. afterEach(() => {
  107. Client.clearMockResponses();
  108. });
  109. describe('render with props', () => {
  110. it('renders members from the prop when present', async () => {
  111. MemberListStore.loadInitialData([USER_1]);
  112. render(<AssigneeSelectorComponent id={GROUP_1.id} memberList={[USER_2, USER_3]} />);
  113. await openMenu();
  114. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  115. // 3 total items
  116. expect(screen.getAllByTestId('assignee-option')).toHaveLength(3);
  117. // 1 team
  118. expect(screen.getByText(`#${TEAM_1.slug}`)).toBeInTheDocument();
  119. // 2 Users
  120. expect(screen.getByText(USER_2.name)).toBeInTheDocument();
  121. expect(screen.getByText(USER_3.name)).toBeInTheDocument();
  122. });
  123. });
  124. describe('putSessionUserFirst()', () => {
  125. it('should place the session user at the top of the member list if present', () => {
  126. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  127. jest.spyOn(ConfigStore, 'get').mockImplementation(() => USER_2);
  128. expect(putSessionUserFirst([USER_1, USER_2])).toEqual([USER_2, USER_1]);
  129. ConfigStore.get.mockRestore();
  130. });
  131. it("should return the same member list if the session user isn't present", () => {
  132. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  133. jest.spyOn(ConfigStore, 'get').mockImplementation(() => ({
  134. id: '555',
  135. name: 'Here Comes a New Challenger',
  136. email: 'guile@mail.us.af.mil',
  137. }));
  138. expect(putSessionUserFirst([USER_1, USER_2])).toEqual([USER_1, USER_2]);
  139. ConfigStore.get.mockRestore();
  140. });
  141. });
  142. it('should initially have loading state', async () => {
  143. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  144. await openMenu();
  145. expect(screen.getByTestId('loading-indicator')).toBeInTheDocument();
  146. });
  147. it('does not have loading state and shows member list after calling MemberListStore.loadInitialData', async () => {
  148. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  149. act(() => MemberListStore.loadInitialData([USER_1, USER_2]));
  150. await openMenu();
  151. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  152. // 3 total items
  153. expect(screen.getAllByTestId('assignee-option')).toHaveLength(3);
  154. // 1 team
  155. expect(screen.getByText(`#${TEAM_1.slug}`)).toBeInTheDocument();
  156. // 2 Users including self
  157. expect(screen.getByText(`${USER_1.name} (You)`)).toBeInTheDocument();
  158. expect(screen.getByText(USER_2.name)).toBeInTheDocument();
  159. });
  160. it('does NOT update member list after initial load', async () => {
  161. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  162. act(() => MemberListStore.loadInitialData([USER_1, USER_2]));
  163. await openMenu();
  164. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  165. expect(screen.getByText(`${USER_1.name} (You)`)).toBeInTheDocument();
  166. expect(screen.getByText(USER_2.name)).toBeInTheDocument();
  167. act(() => MemberListStore.loadInitialData([USER_1, USER_2, USER_3]));
  168. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  169. expect(screen.getByText(`${USER_1.name} (You)`)).toBeInTheDocument();
  170. expect(screen.getByText(USER_2.name)).toBeInTheDocument();
  171. expect(screen.queryByText(USER_3.name)).not.toBeInTheDocument();
  172. });
  173. it('successfully assigns users', async () => {
  174. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  175. act(() => MemberListStore.loadInitialData([USER_1, USER_2]));
  176. await openMenu();
  177. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  178. await userEvent.click(screen.getByText(`${USER_1.name} (You)`));
  179. expect(assignMock).toHaveBeenLastCalledWith(
  180. '/issues/1337/',
  181. expect.objectContaining({
  182. data: {assignedTo: 'user:1', assignedBy: 'assignee_selector'},
  183. })
  184. );
  185. expect(await screen.findByTestId('letter_avatar-avatar')).toBeInTheDocument();
  186. // USER_1 initials
  187. expect(screen.getByTestId('assignee-selector')).toHaveTextContent('JB');
  188. });
  189. it('successfully assigns teams', async () => {
  190. Client.clearMockResponses();
  191. assignMock = Client.addMockResponse({
  192. method: 'PUT',
  193. url: `/issues/${GROUP_1.id}/`,
  194. body: {
  195. ...GROUP_1,
  196. assignedTo: {...TEAM_1, type: 'team'},
  197. },
  198. });
  199. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  200. act(() => MemberListStore.loadInitialData([USER_1, USER_2]));
  201. await openMenu();
  202. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  203. await userEvent.click(screen.getByText(`#${TEAM_1.slug}`));
  204. await waitFor(() =>
  205. expect(assignMock).toHaveBeenCalledWith(
  206. '/issues/1337/',
  207. expect.objectContaining({
  208. data: {assignedTo: 'team:3', assignedBy: 'assignee_selector'},
  209. })
  210. )
  211. );
  212. expect(await screen.findByTestId('letter_avatar-avatar')).toBeInTheDocument();
  213. // TEAM_1 initials
  214. expect(screen.getByTestId('assignee-selector')).toHaveTextContent('CT');
  215. });
  216. it('successfully clears assignment', async () => {
  217. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  218. act(() => MemberListStore.loadInitialData([USER_1, USER_2]));
  219. await openMenu();
  220. // Assign first item in list, which is TEAM_1
  221. await userEvent.click(screen.getByText(`#${TEAM_1.slug}`));
  222. await waitFor(() =>
  223. expect(assignMock).toHaveBeenCalledWith(
  224. '/issues/1337/',
  225. expect.objectContaining({
  226. data: {assignedTo: 'team:3', assignedBy: 'assignee_selector'},
  227. })
  228. )
  229. );
  230. await openMenu();
  231. await userEvent.click(screen.getByRole('button', {name: 'Clear Assignee'}));
  232. // api was called with empty string, clearing assignment
  233. await waitFor(() =>
  234. expect(assignMock).toHaveBeenLastCalledWith(
  235. '/issues/1337/',
  236. expect.objectContaining({
  237. data: {assignedTo: '', assignedBy: 'assignee_selector'},
  238. })
  239. )
  240. );
  241. });
  242. it('shows invite member button', async () => {
  243. MemberListStore.loadInitialData([USER_1, USER_2]);
  244. render(<AssigneeSelectorComponent id={GROUP_1.id} />, {
  245. context: TestStubs.routerContext(),
  246. });
  247. jest.spyOn(ConfigStore, 'get').mockImplementation(() => true);
  248. await openMenu();
  249. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  250. await userEvent.click(await screen.findByRole('link', {name: 'Invite Member'}));
  251. expect(openInviteMembersModal).toHaveBeenCalled();
  252. ConfigStore.get.mockRestore();
  253. });
  254. it('filters user by email and selects with keyboard', async () => {
  255. render(<AssigneeSelectorComponent id={GROUP_2.id} />);
  256. act(() => MemberListStore.loadInitialData([USER_1, USER_2]));
  257. await openMenu();
  258. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  259. await userEvent.type(screen.getByRole('textbox'), 'JohnSmith@example.com');
  260. // 1 total item
  261. expect(screen.getByTestId('assignee-option')).toBeInTheDocument();
  262. expect(screen.getByText(`${USER_2.name}`)).toBeInTheDocument();
  263. await userEvent.keyboard('{enter}');
  264. await waitFor(() =>
  265. expect(assignGroup2Mock).toHaveBeenLastCalledWith(
  266. '/issues/1338/',
  267. expect.objectContaining({
  268. data: {assignedTo: `user:${USER_2.id}`, assignedBy: 'assignee_selector'},
  269. })
  270. )
  271. );
  272. expect(await screen.findByTestId('letter_avatar-avatar')).toBeInTheDocument();
  273. // USER_2 initials
  274. expect(screen.getByTestId('assignee-selector')).toHaveTextContent('JB');
  275. });
  276. it('shows the correct toast for assigning to a non-team member', async () => {
  277. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_2);
  278. const addMessageSpy = jest.spyOn(IndicatorStore, 'addMessage');
  279. render(<AssigneeSelectorComponent id={GROUP_2.id} />);
  280. act(() => MemberListStore.loadInitialData([USER_1, USER_2, USER_3, USER_4]));
  281. assignMock = Client.addMockResponse({
  282. method: 'PUT',
  283. url: `/issues/${GROUP_2.id}/`,
  284. statusCode: 400,
  285. body: {detail: 'Cannot assign to non-team member'},
  286. });
  287. expect(screen.getByTestId('suggested-avatar-stack')).toBeInTheDocument();
  288. await openMenu();
  289. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  290. expect(screen.getByText(`#${TEAM_1.slug}`)).toBeInTheDocument();
  291. expect(await screen.findByText('Suggested Assignees')).toBeInTheDocument();
  292. const options = screen.getAllByTestId('assignee-option');
  293. expect(options[5]).toHaveTextContent('JD');
  294. await userEvent.click(options[4]);
  295. await waitFor(() => {
  296. expect(addMessageSpy).toHaveBeenCalledWith(
  297. 'Cannot assign to non-team member',
  298. 'error',
  299. {duration: 4000}
  300. );
  301. });
  302. });
  303. it('successfully shows suggested assignees', async () => {
  304. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_2);
  305. const onAssign = jest.fn();
  306. render(<AssigneeSelectorComponent id={GROUP_2.id} onAssign={onAssign} />);
  307. act(() => MemberListStore.loadInitialData([USER_1, USER_2, USER_3]));
  308. expect(screen.getByTestId('suggested-avatar-stack')).toBeInTheDocument();
  309. // Hover over avatar
  310. await userEvent.hover(screen.getByTestId('letter_avatar-avatar'));
  311. expect(await screen.findByText('Suggestion: Jane Bloggs')).toBeInTheDocument();
  312. expect(screen.getByText('commit data')).toBeInTheDocument();
  313. await openMenu();
  314. expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
  315. expect(await screen.findByText('Suggested Assignees')).toBeInTheDocument();
  316. const options = screen.getAllByTestId('assignee-option');
  317. // Suggested assignee initials
  318. expect(options[0]).toHaveTextContent('JB');
  319. await userEvent.click(options[0]);
  320. await waitFor(() =>
  321. expect(assignGroup2Mock).toHaveBeenCalledWith(
  322. '/issues/1338/',
  323. expect.objectContaining({
  324. data: {assignedTo: `user:${USER_1.id}`, assignedBy: 'assignee_selector'},
  325. })
  326. )
  327. );
  328. // Suggested assignees shouldn't show anymore because we assigned to the suggested actor
  329. expect(screen.queryByTestId('suggested-avatar-stack')).not.toBeInTheDocument();
  330. expect(onAssign).toHaveBeenCalledWith(
  331. 'member',
  332. expect.objectContaining({id: USER_1.id}),
  333. expect.objectContaining({id: USER_1.id})
  334. );
  335. });
  336. it('renders unassigned', async () => {
  337. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_1);
  338. render(<AssigneeSelectorComponent id={GROUP_1.id} />);
  339. await userEvent.hover(screen.getByTestId('unassigned'));
  340. expect(await screen.findByText('Unassigned')).toBeInTheDocument();
  341. });
  342. });