1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035 |
- import selectEvent from 'react-select-event';
- import {urlEncode} from '@sentry/utils';
- import {MetricsFieldFixture} from 'sentry-fixture/metrics';
- import {ReleaseFixture} from 'sentry-fixture/release';
- import {SessionsFieldFixture} from 'sentry-fixture/sessions';
- import {TagsFixture} from 'sentry-fixture/tags';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- act,
- fireEvent,
- render,
- renderGlobalModal,
- screen,
- userEvent,
- waitFor,
- } from 'sentry-test/reactTestingLibrary';
- import * as modals from 'sentry/actionCreators/modal';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import TagStore from 'sentry/stores/tagStore';
- import {TOP_N} from 'sentry/utils/discover/types';
- import {
- DashboardDetails,
- DashboardWidgetSource,
- DisplayType,
- Widget,
- WidgetType,
- } from 'sentry/views/dashboards/types';
- import WidgetBuilder, {WidgetBuilderProps} from 'sentry/views/dashboards/widgetBuilder';
- const defaultOrgFeatures = [
- 'performance-view',
- 'dashboards-edit',
- 'global-views',
- 'dashboards-mep',
- ];
- function mockDashboard(dashboard: Partial<DashboardDetails>): DashboardDetails {
- return {
- id: '1',
- title: 'Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- ...dashboard,
- };
- }
- function renderTestComponent({
- dashboard,
- query,
- orgFeatures,
- onSave,
- params,
- }: {
- dashboard?: WidgetBuilderProps['dashboard'];
- onSave?: WidgetBuilderProps['onSave'];
- orgFeatures?: string[];
- params?: Partial<WidgetBuilderProps['params']>;
- query?: Record<string, any>;
- } = {}) {
- const {organization, router, routerContext} = initializeOrg({
- organization: {
- features: orgFeatures ?? defaultOrgFeatures,
- },
- router: {
- location: {
- query: {
- source: DashboardWidgetSource.DASHBOARDS,
- ...query,
- },
- },
- },
- });
- ProjectsStore.loadInitialData(organization.projects);
- render(
- <WidgetBuilder
- route={{}}
- router={router}
- routes={router.routes}
- routeParams={router.params}
- location={router.location}
- dashboard={{
- id: 'new',
- title: 'Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- ...dashboard,
- }}
- onSave={onSave ?? jest.fn()}
- params={{
- orgId: organization.slug,
- dashboardId: dashboard?.id ?? 'new',
- ...params,
- }}
- />,
- {
- context: routerContext,
- organization,
- }
- );
- return {router};
- }
- /**
- * This test suite contains tests that test the generic interactions
- * between most components in the WidgetBuilder. Tests for the
- * SortBy step can be found in (and should be added to)
- * ./widgetBuilderSortBy.spec.tsx and tests for specific dataset
- * behaviour can be found (and should be added to) ./widgetBuilderDataset.spec.tsx.
- * The test files are broken up to allow better parallelization
- * in CI (we currently parallelize files).
- */
- describe('WidgetBuilder', function () {
- const untitledDashboard: DashboardDetails = {
- id: '1',
- title: 'Untitled Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- };
- const testDashboard: DashboardDetails = {
- id: '2',
- title: 'Test Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- };
- let eventsStatsMock: jest.Mock | undefined;
- let eventsMock: jest.Mock | undefined;
- let tagsMock: jest.Mock | undefined;
- beforeEach(function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- {...untitledDashboard, widgetDisplay: [DisplayType.TABLE]},
- {...testDashboard, widgetDisplay: [DisplayType.AREA]},
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/widgets/',
- method: 'POST',
- statusCode: 200,
- body: [],
- });
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {fields: {}},
- data: [],
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/recent-searches/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/recent-searches/',
- method: 'POST',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/issues/',
- method: 'GET',
- body: [],
- });
- eventsStatsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/event.type/values/',
- body: [{count: 2, name: 'Nvidia 1080ti'}],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/sessions/',
- body: SessionsFieldFixture(`sum(session)`),
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/metrics/data/',
- body: MetricsFieldFixture('session.all'),
- });
- tagsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- method: 'GET',
- body: TagsFixture(),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/is/values/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/transaction.duration/values/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- TagStore.reset();
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- jest.useRealTimers();
- });
- it('no feature access', function () {
- renderTestComponent({orgFeatures: []});
- expect(screen.getByText("You don't have access to this feature")).toBeInTheDocument();
- });
- it('widget not found', function () {
- const widget: Widget = {
- displayType: DisplayType.AREA,
- interval: '1d',
- queries: [
- {
- name: 'Known Users',
- fields: [],
- columns: [],
- aggregates: [],
- conditions: '',
- orderby: '-time',
- },
- {
- name: 'Anonymous Users',
- fields: [],
- columns: [],
- aggregates: [],
- conditions: '',
- orderby: '-time',
- },
- ],
- title: 'Transactions',
- id: '1',
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- dashboard,
- orgFeatures: ['dashboards-edit'],
- params: {
- widgetIndex: '2', // Out of bounds, only one widget
- },
- });
- expect(
- screen.getByText('The widget you want to edit was not found.')
- ).toBeInTheDocument();
- });
- it('renders a widget not found message if the widget index url is not an integer', function () {
- const widget: Widget = {
- displayType: DisplayType.AREA,
- interval: '1d',
- queries: [
- {
- name: 'Known Users',
- fields: [],
- columns: [],
- aggregates: [],
- conditions: '',
- orderby: '-time',
- },
- ],
- title: 'Transactions',
- id: '1',
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- dashboard,
- orgFeatures: ['dashboards-edit'],
- params: {
- widgetIndex: '0.5', // Invalid index
- },
- });
- expect(
- screen.getByText('The widget you want to edit was not found.')
- ).toBeInTheDocument();
- });
- it('renders', async function () {
- renderTestComponent();
- // Header - Breadcrumbs
- expect(await screen.findByRole('link', {name: 'Dashboards'})).toHaveAttribute(
- 'href',
- '/organizations/org-slug/dashboards/'
- );
- expect(screen.getByRole('link', {name: 'Dashboard'})).toHaveAttribute(
- 'href',
- '/organizations/org-slug/dashboards/new/'
- );
- expect(screen.getByText('Widget Builder')).toBeInTheDocument();
- // Header - Widget Title
- expect(screen.getByText('Custom Widget')).toBeInTheDocument();
- // Footer - Actions
- expect(screen.getByLabelText('Cancel')).toBeInTheDocument();
- expect(screen.getByLabelText('Add Widget')).toBeInTheDocument();
- // Content - Step 1
- expect(
- screen.getByRole('heading', {name: 'Choose your dataset'})
- ).toBeInTheDocument();
- expect(screen.getByLabelText('Errors and Transactions')).toBeChecked();
- // Content - Step 2
- expect(
- screen.getByRole('heading', {name: 'Choose your visualization'})
- ).toBeInTheDocument();
- // Content - Step 3
- expect(
- screen.getByRole('heading', {name: 'Choose your columns'})
- ).toBeInTheDocument();
- // Content - Step 4
- expect(
- screen.getByRole('heading', {name: 'Filter your results'})
- ).toBeInTheDocument();
- // Content - Step 5
- expect(screen.getByRole('heading', {name: 'Sort by a column'})).toBeInTheDocument();
- });
- it('has links back to the new dashboard if creating', async function () {
- // Dashboard has undefined dashboardId when creating from a new dashboard
- // because of route setup
- renderTestComponent({params: {dashboardId: undefined}});
- expect(await screen.findByLabelText('Cancel')).toHaveAttribute(
- 'href',
- '/organizations/org-slug/dashboards/new/'
- );
- });
- it('renders new design', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- });
- // Switch to line chart for time series
- await userEvent.click(screen.getByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- // Header - Breadcrumbs
- expect(await screen.findByRole('link', {name: 'Dashboards'})).toHaveAttribute(
- 'href',
- '/organizations/org-slug/dashboards/'
- );
- expect(screen.getByRole('link', {name: 'Dashboard'})).toHaveAttribute(
- 'href',
- '/organizations/org-slug/dashboards/new/'
- );
- expect(screen.getByText('Widget Builder')).toBeInTheDocument();
- // Header - Widget Title
- expect(screen.getByText('Custom Widget')).toBeInTheDocument();
- // Footer - Actions
- expect(screen.getByLabelText('Cancel')).toBeInTheDocument();
- expect(screen.getByLabelText('Add Widget')).toBeInTheDocument();
- // Content - Step 1
- expect(
- screen.getByRole('heading', {name: 'Choose your dataset'})
- ).toBeInTheDocument();
- expect(screen.getByLabelText('Errors and Transactions')).toBeChecked();
- // Content - Step 2
- expect(
- screen.getByRole('heading', {name: 'Choose your visualization'})
- ).toBeInTheDocument();
- // Content - Step 3
- expect(
- screen.getByRole('heading', {name: 'Choose what to plot in the y-axis'})
- ).toBeInTheDocument();
- // Content - Step 4
- expect(
- screen.getByRole('heading', {name: 'Filter your results'})
- ).toBeInTheDocument();
- // Content - Step 5
- expect(screen.getByRole('heading', {name: 'Group your results'})).toBeInTheDocument();
- });
- it('can update the title', async function () {
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- });
- const customWidgetLabels = await screen.findByText('Custom Widget');
- // EditableText and chart title
- expect(customWidgetLabels).toBeInTheDocument();
- await userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.click(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.paste('Unique Users');
- await userEvent.keyboard('{enter}');
- expect(screen.queryByText('Custom Widget')).not.toBeInTheDocument();
- expect(screen.getByText('Unique Users')).toBeInTheDocument();
- });
- it('can add query conditions', async function () {
- const {router} = renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- });
- const search = await screen.findByTestId(/smart-search-input/);
- await userEvent.click(search);
- // Use fireEvent for performance reasons as this test suite is slow
- fireEvent.paste(search, {
- target: {value: 'color:blue'},
- clipboardData: {getData: () => 'color:blue'},
- });
- await userEvent.keyboard('{enter}');
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/2/',
- query: {
- displayType: 'table',
- interval: '5m',
- title: 'Custom Widget',
- queryNames: [''],
- queryConditions: ['color:blue'],
- queryFields: ['count()'],
- queryOrderby: '-count()',
- start: null,
- end: null,
- statsPeriod: '24h',
- utc: null,
- project: [],
- environment: [],
- },
- })
- );
- });
- });
- it('can choose a field', async function () {
- const {router} = renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- });
- expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
- // No delete button as there is only one query.
- expect(screen.queryByLabelText('Remove query')).not.toBeInTheDocument();
- // 1 in the table header, 1 in the column selector, 1 in the sort field
- const countFields = screen.getAllByText('count()');
- expect(countFields).toHaveLength(3);
- await selectEvent.select(countFields[1], ['last_seen()']);
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/2/',
- query: {
- displayType: 'table',
- interval: '5m',
- title: 'Custom Widget',
- queryNames: [''],
- queryConditions: [''],
- queryFields: ['last_seen()'],
- queryOrderby: '-last_seen()',
- start: null,
- end: null,
- statsPeriod: '24h',
- utc: null,
- project: [],
- environment: [],
- },
- })
- );
- });
- });
- it('can add additional fields', async function () {
- const handleSave = jest.fn();
- renderTestComponent({onSave: handleSave});
- await userEvent.click(await screen.findByText('Table'));
- // Select line chart display
- await userEvent.click(screen.getByText('Line Chart'));
- // Click the add overlay button
- await userEvent.click(screen.getByLabelText('Add Overlay'));
- await selectEvent.select(screen.getByText('(Required)'), ['count_unique(…)']);
- await userEvent.click(screen.getByLabelText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- title: 'Custom Widget',
- displayType: DisplayType.LINE,
- interval: '5m',
- widgetType: WidgetType.DISCOVER,
- queries: [
- {
- conditions: '',
- fields: ['count()', 'count_unique(user)'],
- aggregates: ['count()', 'count_unique(user)'],
- fieldAliases: [],
- columns: [],
- orderby: '',
- name: '',
- },
- ],
- }),
- ]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('can add equation fields', async function () {
- const handleSave = jest.fn();
- renderTestComponent({onSave: handleSave});
- await userEvent.click(await screen.findByText('Table'));
- // Select line chart display
- await userEvent.click(screen.getByText('Line Chart'));
- // Click the add an equation button
- await userEvent.click(screen.getByLabelText('Add an Equation'));
- expect(screen.getByPlaceholderText('Equation')).toBeInTheDocument();
- await userEvent.click(screen.getByPlaceholderText('Equation'));
- await userEvent.paste('count() + 100');
- await userEvent.click(screen.getByLabelText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- title: 'Custom Widget',
- displayType: DisplayType.LINE,
- interval: '5m',
- widgetType: WidgetType.DISCOVER,
- queries: [
- {
- name: '',
- fields: ['count()', 'equation|count() + 100'],
- aggregates: ['count()', 'equation|count() + 100'],
- columns: [],
- fieldAliases: [],
- conditions: '',
- orderby: '',
- },
- ],
- }),
- ]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('can respond to validation feedback', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/widgets/',
- method: 'POST',
- statusCode: 400,
- body: {
- title: ['This field may not be blank.'],
- },
- });
- renderTestComponent();
- await userEvent.click(await screen.findByText('Table'));
- const customWidgetLabels = await screen.findByText('Custom Widget');
- // EditableText and chart title
- expect(customWidgetLabels).toBeInTheDocument();
- await userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.click(screen.getByText('Add Widget'));
- await screen.findByText('This field may not be blank.');
- });
- it('sets up widget data in edit correctly', async function () {
- const widget: Widget = {
- id: '1',
- title: 'Errors over time',
- interval: '5m',
- displayType: DisplayType.LINE,
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- {
- name: 'csp',
- conditions: 'event.type:csp',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({dashboard, params: {widgetIndex: '0'}});
- await screen.findByText('Line Chart');
- // Should be in edit 'mode'
- expect(await screen.findByText('Update Widget')).toBeInTheDocument();
- // Should set widget data up.
- expect(screen.getByText('Update Widget')).toBeInTheDocument();
- // Filters
- expect(
- screen.getAllByPlaceholderText('Search for events, users, tags, and more')
- ).toHaveLength(2);
- expect(screen.getByText('event.type:csp')).toBeInTheDocument();
- expect(screen.getByText('event.type:error')).toBeInTheDocument();
- // Y-axis
- expect(screen.getAllByRole('button', {name: 'Remove query'})).toHaveLength(2);
- expect(screen.getByText('count()')).toBeInTheDocument();
- expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
- expect(screen.getByText('id')).toBeInTheDocument();
- // Expect events-stats endpoint to be called for each search conditions with
- // the same y-axis parameters
- expect(eventsStatsMock).toHaveBeenNthCalledWith(
- 1,
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: 'event.type:error',
- yAxis: ['count()', 'count_unique(id)'],
- }),
- })
- );
- expect(eventsStatsMock).toHaveBeenNthCalledWith(
- 2,
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: 'event.type:csp',
- yAxis: ['count()', 'count_unique(id)'],
- }),
- })
- );
- });
- it('can edit a widget', async function () {
- const widget: Widget = {
- id: '1',
- title: 'Errors over time',
- interval: '5m',
- displayType: DisplayType.LINE,
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- {
- name: 'csp',
- conditions: 'event.type:csp',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- const handleSave = jest.fn();
- renderTestComponent({onSave: handleSave, dashboard, params: {widgetIndex: '0'}});
- await screen.findByText('Line Chart');
- // Should be in edit 'mode'
- expect(screen.getByText('Update Widget')).toBeInTheDocument();
- const customWidgetLabels = screen.getByText(widget.title);
- // EditableText and chart title
- expect(customWidgetLabels).toBeInTheDocument();
- await userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.click(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.paste('New Title');
- await userEvent.click(screen.getByRole('button', {name: 'Update Widget'}));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- ...widget,
- title: 'New Title',
- }),
- ]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('renders column inputs for table widgets', async function () {
- const widget: Widget = {
- id: '0',
- title: 'sdk usage',
- interval: '5m',
- displayType: DisplayType.TABLE,
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['sdk.name', 'count()'],
- columns: ['sdk.name'],
- aggregates: ['count()'],
- orderby: '',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({dashboard, params: {widgetIndex: '0'}});
- // Should be in edit 'mode'
- expect(await screen.findByText('Update Widget')).toBeInTheDocument();
- // Should set widget data up.
- expect(screen.getByText(widget.title)).toBeInTheDocument();
- expect(screen.getByText('Table')).toBeInTheDocument();
- expect(screen.getByLabelText('Search events')).toBeInTheDocument();
- // Should have an orderby select
- expect(screen.getByText('Sort by a column')).toBeInTheDocument();
- // Add a column, and choose a value,
- expect(screen.getByLabelText('Add a Column')).toBeInTheDocument();
- });
- it('can save table widgets', async function () {
- const widget: Widget = {
- id: '0',
- title: 'sdk usage',
- interval: '5m',
- displayType: DisplayType.TABLE,
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['sdk.name', 'count()'],
- columns: ['sdk.name'],
- aggregates: ['count()'],
- orderby: '-count()',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- const handleSave = jest.fn();
- renderTestComponent({dashboard, onSave: handleSave, params: {widgetIndex: '0'}});
- // Should be in edit 'mode'
- expect(await screen.findByText('Update Widget')).toBeInTheDocument();
- // Add a column, and choose a value,
- await userEvent.click(screen.getByLabelText('Add a Column'));
- await selectEvent.select(screen.getByText('(Required)'), 'trace');
- // Save widget
- await userEvent.click(screen.getByLabelText('Update Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- id: '0',
- title: 'sdk usage',
- displayType: DisplayType.TABLE,
- interval: '5m',
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['sdk.name', 'count()', 'trace'],
- aggregates: ['count()'],
- columns: ['sdk.name', 'trace'],
- orderby: '-count()',
- fieldAliases: ['', '', ''],
- },
- ],
- widgetType: WidgetType.DISCOVER,
- }),
- ]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('should properly query for table fields', async function () {
- const defaultWidgetQuery = {
- name: '',
- fields: ['title', 'count()'],
- columns: ['title'],
- aggregates: ['count()'],
- conditions: '',
- orderby: '',
- };
- const defaultTableColumns = ['title', 'count()', 'count_unique(user)', 'epm()'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.LINE,
- defaultTableColumns,
- },
- });
- expect(await screen.findByText('Line Chart')).toBeInTheDocument();
- await userEvent.click(screen.getByText('Line Chart'));
- await userEvent.click(screen.getByText('Table'));
- await waitFor(() => {
- expect(eventsMock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events/',
- expect.objectContaining({
- query: expect.objectContaining({
- field: defaultTableColumns,
- }),
- })
- );
- });
- });
- it('should use defaultWidgetQuery Y-Axis and Conditions if given a defaultWidgetQuery', async function () {
- const defaultWidgetQuery = {
- name: '',
- fields: ['count()', 'failure_count()', 'count_unique(user)'],
- columns: [],
- aggregates: ['count()', 'failure_count()', 'count_unique(user)'],
- conditions: 'tag:value',
- orderby: '',
- };
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- },
- });
- expect(await screen.findByText('tag:value')).toBeInTheDocument();
- // Table display, column, and sort field
- expect(screen.getAllByText('count()')).toHaveLength(3);
- // Table display and column
- expect(screen.getAllByText('failure_count()')).toHaveLength(2);
- // Table display
- expect(screen.getByText('count_unique(user)')).toBeInTheDocument();
- // Column
- expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
- // Column
- expect(screen.getByText('user')).toBeInTheDocument();
- });
- it('uses displayType if given a displayType', async function () {
- renderTestComponent({
- query: {
- displayType: DisplayType.BAR,
- },
- });
- expect(await screen.findByText('Bar Chart')).toBeInTheDocument();
- });
- it('deletes the widget when the modal is confirmed', async () => {
- const handleSave = jest.fn();
- const widget: Widget = {
- id: '1',
- title: 'Errors over time',
- interval: '5m',
- displayType: DisplayType.LINE,
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- {
- name: 'csp',
- conditions: 'event.type:csp',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({onSave: handleSave, dashboard, params: {widgetIndex: '0'}});
- await userEvent.click(await screen.findByText('Delete'));
- renderGlobalModal();
- await userEvent.click(await screen.findByText('Confirm'));
- await waitFor(() => {
- // The only widget was deleted
- expect(handleSave).toHaveBeenCalledWith([]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('persists the page filter period when updating a widget', async () => {
- const widget: Widget = {
- id: '1',
- title: 'Errors over time',
- interval: '5m',
- displayType: DisplayType.LINE,
- queries: [
- {
- name: 'errors',
- conditions: 'event.type:error',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- const {router} = renderTestComponent({
- dashboard,
- params: {orgId: 'org-slug', widgetIndex: '0'},
- query: {statsPeriod: '90d'},
- });
- await userEvent.click(screen.getByText('Update Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenLastCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/1/',
- query: expect.objectContaining({
- statsPeriod: '90d',
- }),
- })
- );
- });
- });
- it('renders page filters in the filter step', async () => {
- const mockReleases = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [ReleaseFixture()],
- });
- renderTestComponent({
- params: {orgId: 'org-slug'},
- query: {statsPeriod: '90d'},
- orgFeatures: defaultOrgFeatures,
- });
- expect(await screen.findByTestId('page-filter-timerange-selector')).toBeDisabled();
- expect(screen.getByTestId('page-filter-environment-selector')).toBeDisabled();
- expect(screen.getByTestId('page-filter-project-selector')).toBeDisabled();
- expect(mockReleases).toHaveBeenCalled();
- expect(screen.getByRole('button', {name: /all releases/i})).toBeDisabled();
- });
- it('appends dashboard filters to widget builder fetch data request', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [ReleaseFixture()],
- });
- const mock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- body: [],
- });
- renderTestComponent({
- dashboard: {
- id: 'new',
- title: 'Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {release: ['abc@1.2.0']},
- },
- params: {orgId: 'org-slug'},
- query: {statsPeriod: '90d'},
- orgFeatures: defaultOrgFeatures,
- });
- await waitFor(() => {
- expect(mock).toHaveBeenCalledWith(
- '/organizations/org-slug/events/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: ' release:"abc@1.2.0" ',
- }),
- })
- );
- });
- });
- it('does not error when query conditions field is blurred', async function () {
- jest.useFakeTimers();
- const widget: Widget = {
- id: '0',
- title: 'sdk usage',
- interval: '5m',
- displayType: DisplayType.BAR,
- queries: [
- {
- name: 'filled in',
- conditions: 'event.type:error',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '-count()',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- const handleSave = jest.fn();
- renderTestComponent({dashboard, onSave: handleSave, params: {widgetIndex: '0'}});
- await userEvent.click(await screen.findByLabelText('Add Query'), {delay: null});
- // Triggering the onBlur of the new field should not error
- await userEvent.click(
- screen.getAllByPlaceholderText('Search for events, users, tags, and more')[1],
- {delay: null}
- );
- await userEvent.keyboard('{Escape}', {delay: null});
- // Run all timers because the handleBlur contains a setTimeout
- jest.runAllTimers();
- });
- it('does not wipe column changes when filters are modified', async function () {
- jest.useFakeTimers();
- // widgetIndex: undefined means creating a new widget
- renderTestComponent({params: {widgetIndex: undefined}});
- await userEvent.click(await screen.findByLabelText('Add a Column'), {delay: null});
- await selectEvent.select(screen.getByText('(Required)'), /project/);
- // Triggering the onBlur of the filter should not error
- await userEvent.click(
- screen.getByPlaceholderText('Search for events, users, tags, and more'),
- {delay: null}
- );
- await userEvent.keyboard('{enter}', {delay: null});
- expect(await screen.findAllByText('project')).toHaveLength(2);
- });
- it('renders fields with commas properly', async () => {
- const defaultWidgetQuery = {
- conditions: '',
- fields: ['equation|count_if(transaction.duration,equals,300)*2'],
- aggregates: ['equation|count_if(transaction.duration,equals,300)*2'],
- columns: [],
- orderby: '',
- name: '',
- };
- const defaultTableColumns = [
- 'count_if(transaction.duration,equals,300)',
- 'equation|count_if(transaction.duration,equals,300)*2',
- ];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- defaultTableColumns,
- yAxis: ['equation|count_if(transaction.duration,equals,300)*2'],
- },
- });
- expect(
- await screen.findByText('count_if(transaction.duration,equals,300)*2')
- ).toBeInTheDocument();
- });
- it('sets the correct fields for a top n widget', async () => {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures, 'performance-view'],
- query: {
- displayType: DisplayType.TOP_N,
- },
- });
- // Top N now opens as Area Chart
- expect(await screen.findByText('Area Chart')).toBeInTheDocument();
- // Add a group by
- await userEvent.click(screen.getByText('Add Overlay'));
- await selectEvent.select(screen.getByText('Select group'), /project/);
- // Change the y-axis
- await selectEvent.select(screen.getAllByText('count()')[0], 'eps()');
- await waitFor(() => {
- expect(eventsStatsMock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: '',
- yAxis: ['eps()'],
- field: ['project', 'eps()'],
- topEvents: TOP_N,
- orderby: '-eps()',
- }),
- })
- );
- });
- });
- it('fetches tags when tag store is empty', async function () {
- renderTestComponent();
- await waitFor(() => {
- expect(tagsMock).toHaveBeenCalled();
- });
- });
- it('does not fetch tags when tag store is not empty', async function () {
- await act(async () => {
- TagStore.loadTagsSuccess(TagsFixture());
- renderTestComponent();
- await tick();
- });
- expect(tagsMock).not.toHaveBeenCalled();
- });
- it('excludes the Other series when grouping and using multiple y-axes', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- query: {
- displayType: DisplayType.LINE,
- },
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- await userEvent.click(screen.getByText('Add Overlay'));
- await selectEvent.select(screen.getByText('(Required)'), /count_unique/);
- await waitFor(() => {
- expect(eventsStatsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({excludeOther: '1'}),
- })
- );
- });
- });
- it('excludes the Other series when grouping and using multiple queries', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- query: {
- displayType: DisplayType.LINE,
- },
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- await userEvent.click(screen.getByText('Add Query'));
- await waitFor(() => {
- expect(eventsStatsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({excludeOther: '1'}),
- })
- );
- });
- });
- it('includes Other series when there is only one query and one y-axis', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- query: {
- displayType: DisplayType.LINE,
- },
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- await waitFor(() => {
- expect(eventsStatsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.not.objectContaining({excludeOther: '1'}),
- })
- );
- });
- });
- it('decreases the limit when more y-axes and queries are added', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- query: {
- displayType: DisplayType.LINE,
- },
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- screen.getByText('Limit to 5 results');
- await userEvent.click(screen.getByText('Add Query'));
- await userEvent.click(screen.getByText('Add Overlay'));
- expect(screen.getByText('Limit to 2 results')).toBeInTheDocument();
- });
- it('alerts the user if there are unsaved title changes', async function () {
- const {router} = renderTestComponent();
- const alertMock = jest.fn();
- const setRouteLeaveHookMock = jest.spyOn(router, 'setRouteLeaveHook');
- setRouteLeaveHookMock.mockImplementationOnce((_route, _callback) => {
- alertMock();
- });
- const customWidgetLabels = await screen.findByText('Custom Widget');
- // EditableText and chart title
- expect(customWidgetLabels).toBeInTheDocument();
- // Change title text
- await userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.click(screen.getByRole('textbox', {name: 'Widget title'}));
- await userEvent.paste('Unique Users');
- await userEvent.keyboard('{Enter}');
- // Click Cancel
- await userEvent.click(screen.getByText('Cancel'));
- // Assert an alert was triggered
- expect(alertMock).toHaveBeenCalled();
- });
- it('alerts the user if there are unsaved description changes', async function () {
- const {router} = renderTestComponent();
- const alertMock = jest.fn();
- const setRouteLeaveHookMock = jest.spyOn(router, 'setRouteLeaveHook');
- setRouteLeaveHookMock.mockImplementationOnce((_route, _callback) => {
- alertMock();
- });
- const descriptionTextArea = await screen.findByRole('textbox', {
- name: 'Widget Description',
- });
- expect(descriptionTextArea).toBeInTheDocument();
- expect(descriptionTextArea).toHaveAttribute(
- 'placeholder',
- 'Enter description (Optional)'
- );
- // Change description text
- await userEvent.clear(descriptionTextArea);
- await userEvent.click(descriptionTextArea);
- await userEvent.paste('This is a description');
- await userEvent.keyboard('{Enter}');
- // Click Cancel
- await userEvent.click(screen.getByText('Cancel'));
- // Assert an alert was triggered
- expect(alertMock).toHaveBeenCalled();
- });
- it('does not trigger alert dialog if no changes', async function () {
- const {router} = renderTestComponent();
- const alertMock = jest.fn();
- const setRouteLeaveHookMock = jest.spyOn(router, 'setRouteLeaveHook');
- setRouteLeaveHookMock.mockImplementationOnce((_route, _callback) => {
- alertMock();
- });
- // Click Cancel
- await userEvent.click(await screen.findByText('Cancel'));
- // Assert an alert was triggered
- expect(alertMock).not.toHaveBeenCalled();
- });
- describe('Widget creation coming from other verticals', function () {
- it('redirects correctly when creating a new dashboard', async function () {
- const {router} = renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- });
- await userEvent.click(await screen.findByText('Add Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboards/new/',
- query: {
- displayType: 'table',
- interval: '5m',
- title: 'Custom Widget',
- queryNames: [''],
- queryConditions: [''],
- queryFields: ['count()'],
- queryOrderby: '-count()',
- start: null,
- end: null,
- statsPeriod: '24h',
- utc: null,
- project: [],
- environment: [],
- },
- })
- );
- });
- });
- it('redirects correctly when choosing an existing dashboard', async function () {
- const {router} = renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- });
- await userEvent.click(await screen.findByText('Add Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/2/',
- query: {
- displayType: 'table',
- interval: '5m',
- title: 'Custom Widget',
- queryNames: [''],
- queryConditions: [''],
- queryFields: ['count()'],
- queryOrderby: '-count()',
- start: null,
- end: null,
- statsPeriod: '24h',
- utc: null,
- project: [],
- environment: [],
- },
- })
- );
- });
- });
- it('shows the correct orderby when switching from a line chart to table', async function () {
- const defaultWidgetQuery = {
- name: '',
- fields: ['count_unique(user)'],
- columns: [],
- aggregates: ['count_unique(user)'],
- conditions: '',
- orderby: 'count_unique(user)',
- };
- const defaultTableColumns = ['title', 'count_unique(user)'];
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.LINE,
- defaultTableColumns,
- },
- });
- await userEvent.click(await screen.findByText('Line Chart'));
- await userEvent.click(screen.getByText('Table'));
- expect(screen.getAllByText('count_unique(user)')[0]).toBeInTheDocument();
- await waitFor(() => {
- expect(eventsMock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events/',
- expect.objectContaining({
- query: expect.objectContaining({
- field: defaultTableColumns,
- sort: ['count_unique(user)'],
- }),
- })
- );
- });
- });
- it('does not send request with orderby if a timeseries chart without grouping', async function () {
- const defaultWidgetQuery = {
- name: '',
- fields: ['count_unique(user)'],
- columns: [],
- aggregates: ['count_unique(user)'],
- conditions: '',
- orderby: 'count_unique(user)',
- };
- const defaultTableColumns = ['title', 'count_unique(user)'];
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.LINE,
- defaultTableColumns,
- },
- });
- await waitFor(() => {
- expect(eventsStatsMock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- orderby: '',
- }),
- })
- );
- });
- });
- });
- it('opens top-N widgets as area display', async function () {
- const widget: Widget = {
- id: '1',
- title: 'Errors over time',
- interval: '5m',
- displayType: DisplayType.TOP_N,
- queries: [
- {
- name: '',
- conditions: '',
- fields: ['count()', 'count_unique(id)'],
- aggregates: ['count()', 'count_unique(id)'],
- columns: [],
- orderby: '-count()',
- },
- ],
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- dashboard,
- params: {
- widgetIndex: '0',
- },
- });
- expect(await screen.findByText('Area Chart')).toBeInTheDocument();
- });
- it('Update table header values (field alias)', async function () {
- const handleSave = jest.fn();
- renderTestComponent({
- onSave: handleSave,
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(screen.getByPlaceholderText('Alias'));
- await userEvent.paste('First Alias');
- await userEvent.click(screen.getByLabelText('Add a Column'));
- await userEvent.click(screen.getAllByPlaceholderText('Alias')[1]);
- await userEvent.paste('Second Alias');
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- queries: [
- expect.objectContaining({fieldAliases: ['First Alias', 'Second Alias']}),
- ],
- }),
- ]);
- });
- });
- it('does not wipe equation aliases when a column alias is updated', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(screen.getByText('Add an Equation'));
- await userEvent.click(screen.getAllByPlaceholderText('Alias')[1]);
- await userEvent.paste('This should persist');
- await userEvent.type(screen.getAllByPlaceholderText('Alias')[0], 'A');
- expect(await screen.findByText('This should persist')).toBeInTheDocument();
- });
- it('does not wipe equation aliases when a column selection is made', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(screen.getByText('Add an Equation'));
- await userEvent.click(screen.getAllByPlaceholderText('Alias')[1]);
- await userEvent.paste('This should persist');
- // 1 for the table, 1 for the the column selector, 1 for the sort
- await waitFor(() => expect(screen.getAllByText('count()')).toHaveLength(3));
- await selectEvent.select(screen.getAllByText('count()')[1], /count_unique/);
- expect(screen.getByText('This should persist')).toBeInTheDocument();
- });
- it('copies over the orderby from the previous query if adding another', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(await screen.findByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- await selectEvent.select(screen.getByText('Select group'), 'project');
- await selectEvent.select(screen.getAllByText('count()')[1], 'count_unique(…)');
- MockApiClient.clearMockResponses();
- eventsStatsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- await userEvent.click(screen.getByText('Add Query'));
- // Assert on two calls, one for each query
- const expectedArgs = expect.objectContaining({
- query: expect.objectContaining({
- orderby: '-count_unique(user)',
- }),
- });
- expect(eventsStatsMock).toHaveBeenNthCalledWith(
- 1,
- '/organizations/org-slug/events-stats/',
- expectedArgs
- );
- expect(eventsStatsMock).toHaveBeenNthCalledWith(
- 2,
- '/organizations/org-slug/events-stats/',
- expectedArgs
- );
- });
- it('disables add widget button and prevents widget previewing from firing widget query if widget query condition is invalid', async function () {
- renderTestComponent({
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(await screen.findByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(eventsStatsMock).toHaveBeenCalledTimes(1);
- await userEvent.type(
- screen.getByTestId('smart-search-input'),
- 'transaction.duration:123a'
- );
- // Unfocus input
- await userEvent.click(screen.getByText('Filter your results'));
- expect(screen.getByText('Add Widget').closest('button')).toBeDisabled();
- expect(screen.getByText('Widget query condition is invalid.')).toBeInTheDocument();
- expect(eventsStatsMock).toHaveBeenCalledTimes(1);
- });
- describe('Widget Library', function () {
- it('only opens the modal when the query data is changed', async function () {
- const mockModal = jest.spyOn(modals, 'openWidgetBuilderOverwriteModal');
- renderTestComponent();
- await screen.findByText('Widget Library');
- await userEvent.click(screen.getByText('Duration Distribution'));
- // Widget Library, Builder title, and Chart title
- expect(screen.getAllByText('Duration Distribution')).toHaveLength(2);
- // Confirm modal doesn't open because no changes were made
- expect(mockModal).not.toHaveBeenCalled();
- await userEvent.click(screen.getAllByLabelText('Remove this Y-Axis')[0]);
- await userEvent.click(screen.getByText('High Throughput Transactions'));
- // Should not have overwritten widget data, and confirm modal should open
- expect(screen.getAllByText('Duration Distribution')).toHaveLength(2);
- expect(mockModal).toHaveBeenCalled();
- });
- });
- describe('group by field', function () {
- it('does not contain functions as options', async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(await screen.findByText('Select group')).toBeInTheDocument();
- await userEvent.click(screen.getByText('Select group'));
- // Only one f(x) field set in the y-axis selector
- expect(screen.getByText('f(x)')).toBeInTheDocument();
- });
- it('adds more fields when Add Group is clicked', async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(await screen.findByText('Add Group'));
- expect(await screen.findAllByText('Select group')).toHaveLength(2);
- });
- it("doesn't reset group by when changing y-axis", async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- await userEvent.click(screen.getAllByText('count()')[0], {
- skipHover: true,
- });
- await userEvent.click(screen.getByText(/count_unique/), {
- skipHover: true,
- });
- expect(await screen.findByText('project')).toBeInTheDocument();
- });
- it("doesn't erase the selection when switching to another time series", async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- await userEvent.click(screen.getByText('Line Chart'));
- await userEvent.click(screen.getByText('Area Chart'));
- expect(await screen.findByText('project')).toBeInTheDocument();
- });
- it('sends a top N request when a grouping is selected', async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(await screen.findByText('Group your results'));
- await userEvent.type(screen.getByText('Select group'), 'project{enter}');
- await waitFor(() =>
- expect(eventsStatsMock).toHaveBeenNthCalledWith(
- 2,
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: '',
- yAxis: ['count()'],
- field: ['project', 'count()'],
- topEvents: TOP_N,
- orderby: '-count()',
- }),
- })
- )
- );
- });
- it('allows deleting groups until there is one left', async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await userEvent.click(await screen.findByText('Add Group'));
- expect(screen.getAllByLabelText('Remove group')).toHaveLength(2);
- await userEvent.click(screen.getAllByLabelText('Remove group')[1]);
- await waitFor(() =>
- expect(screen.queryByLabelText('Remove group')).not.toBeInTheDocument()
- );
- });
- it("display 'remove' and 'drag to reorder' buttons", async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(screen.queryByLabelText('Remove group')).not.toBeInTheDocument();
- await selectEvent.select(screen.getByText('Select group'), 'project');
- expect(screen.getByLabelText('Remove group')).toBeInTheDocument();
- expect(screen.queryByLabelText('Drag to reorder')).not.toBeInTheDocument();
- await userEvent.click(screen.getByText('Add Group'));
- expect(screen.getAllByLabelText('Remove group')).toHaveLength(2);
- expect(screen.getAllByLabelText('Drag to reorder')).toHaveLength(2);
- });
- it.todo(
- 'Since simulate drag and drop with RTL is not recommended because of browser layout, remember to create acceptance test for this'
- );
- });
- describe('limit field', function () {
- it('renders if groupBy value is present', async function () {
- const handleSave = jest.fn();
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- onSave: handleSave,
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() =>
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- limit: 5,
- }),
- ])
- );
- });
- it('update value', async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- await userEvent.click(screen.getByText('Limit to 5 results'));
- await userEvent.click(screen.getByText('Limit to 2 results'));
- await waitFor(() =>
- expect(eventsStatsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: '',
- yAxis: ['count()'],
- field: ['project', 'count()'],
- topEvents: 2,
- orderby: '-count()',
- }),
- })
- )
- );
- });
- it('gets removed if no groupBy value', async function () {
- renderTestComponent({
- query: {displayType: 'line'},
- orgFeatures: [...defaultOrgFeatures],
- });
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
- await userEvent.click(screen.getByLabelText('Remove group'));
- await waitFor(() =>
- expect(screen.queryByText('Limit to 5 results')).not.toBeInTheDocument()
- );
- });
- it('applies a limit when switching from a table to timeseries chart with grouping', async function () {
- const widget: Widget = {
- displayType: DisplayType.TABLE,
- interval: '1d',
- queries: [
- {
- name: 'Test Widget',
- fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
- columns: ['project'],
- aggregates: ['count()', 'count_unique(user)', 'epm()'],
- conditions: '',
- orderby: '',
- },
- ],
- title: 'Transactions',
- id: '1',
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- dashboard,
- orgFeatures: [...defaultOrgFeatures],
- params: {
- widgetIndex: '0',
- },
- });
- await userEvent.click(await screen.findByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(screen.getByText('Limit to 3 results')).toBeInTheDocument();
- expect(eventsStatsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- topEvents: 3,
- }),
- })
- );
- });
- it('persists the limit when switching between timeseries charts', async function () {
- const widget: Widget = {
- displayType: DisplayType.AREA,
- interval: '1d',
- queries: [
- {
- name: 'Test Widget',
- fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
- columns: ['project'],
- aggregates: ['count()', 'count_unique(user)', 'epm()'],
- conditions: '',
- orderby: '',
- },
- ],
- title: 'Transactions',
- id: '1',
- limit: 1,
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- dashboard,
- orgFeatures: [...defaultOrgFeatures],
- params: {
- widgetIndex: '0',
- },
- });
- await userEvent.click(await screen.findByText('Area Chart'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(screen.getByText('Limit to 1 result')).toBeInTheDocument();
- expect(eventsStatsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- topEvents: 1,
- }),
- })
- );
- });
- it('unsets the limit when going from timeseries to table', async function () {
- const widget: Widget = {
- displayType: DisplayType.AREA,
- interval: '1d',
- queries: [
- {
- name: 'Test Widget',
- fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
- columns: ['project'],
- aggregates: ['count()', 'count_unique(user)', 'epm()'],
- conditions: '',
- orderby: '',
- },
- ],
- title: 'Transactions',
- id: '1',
- limit: 1,
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- dashboard,
- orgFeatures: [...defaultOrgFeatures],
- params: {
- widgetIndex: '0',
- },
- });
- await userEvent.click(await screen.findByText('Area Chart'));
- await userEvent.click(screen.getByText('Table'));
- expect(screen.queryByText('Limit to 1 result')).not.toBeInTheDocument();
- expect(eventsMock).toHaveBeenCalledWith(
- '/organizations/org-slug/events/',
- expect.objectContaining({
- query: expect.objectContaining({
- topEvents: undefined,
- }),
- })
- );
- });
- });
- });
|