1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549 |
- import {browserHistory} from 'react-router';
- import {Organization} from 'sentry-fixture/organization';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- act,
- render,
- screen,
- userEvent,
- waitFor,
- within,
- } from 'sentry-test/reactTestingLibrary';
- import * as modals from 'sentry/actionCreators/modal';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import CreateDashboard from 'sentry/views/dashboards/create';
- import * as types from 'sentry/views/dashboards/types';
- import ViewEditDashboard from 'sentry/views/dashboards/view';
- import {OrganizationContext} from 'sentry/views/organizationContext';
- describe('Dashboards > Detail', function () {
- const organization = Organization({
- features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
- });
- const projects = [TestStubs.Project()];
- describe('prebuilt dashboards', function () {
- let initialData;
- beforeEach(function () {
- act(() => ProjectsStore.loadInitialData(projects));
- initialData = initializeOrg({organization});
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [TestStubs.Project()],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- TestStubs.Dashboard([], {id: 'default-overview', title: 'Default'}),
- TestStubs.Dashboard([], {id: '1', title: 'Custom Errors'}),
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/default-overview/',
- body: TestStubs.Dashboard([], {id: 'default-overview', title: 'Default'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/visit/',
- method: 'POST',
- body: [],
- statusCode: 200,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/sdk-updates/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/prompts-activity/',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/issues/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- });
- it('assigns unique IDs to all widgets so grid keys are unique', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/default-overview/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'Default Widget 1',
- interval: '1d',
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:transaction',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'Default Widget 2',
- interval: '1d',
- }
- ),
- ],
- {id: 'default-overview', title: 'Default'}
- ),
- });
- initialData = initializeOrg({
- organization: Organization({
- features: ['global-views', 'dashboards-basic', 'discover-query'],
- projects: [TestStubs.Project()],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: 'default-overview'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- expect(await screen.findByText('Default Widget 1')).toBeInTheDocument();
- expect(screen.getByText('Default Widget 2')).toBeInTheDocument();
- });
- it('opens the widget viewer modal in a prebuilt dashboard using the widget id specified in the url', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- render(
- <CreateDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{templateId: 'default-template', widgetId: '2'}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/2/'}}
- >
- {null}
- </CreateDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- organization: initialData.organization,
- widget: expect.objectContaining({
- displayType: 'line',
- interval: '5m',
- queries: [
- {
- aggregates: ['count()'],
- columns: [],
- conditions: '!event.type:transaction',
- fields: ['count()'],
- name: 'Events',
- orderby: 'count()',
- },
- ],
- title: 'Events',
- widgetType: 'discover',
- }),
- onClose: expect.anything(),
- })
- );
- });
- });
- });
- describe('custom dashboards', function () {
- let initialData, widgets, mockVisit, mockPut;
- beforeEach(function () {
- window.confirm = jest.fn();
- initialData = initializeOrg({
- organization,
- router: {
- location: TestStubs.location(),
- },
- });
- widgets = [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- columns: [],
- aggregates: ['count()'],
- },
- ],
- {
- title: 'Errors',
- interval: '1d',
- widgetType: 'discover',
- id: '1',
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:transaction',
- fields: ['count()'],
- columns: [],
- aggregates: ['count()'],
- },
- ],
- {
- title: 'Transactions',
- interval: '1d',
- widgetType: 'discover',
- id: '2',
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:transaction transaction:/api/cats',
- fields: ['p50()'],
- columns: [],
- aggregates: ['p50()'],
- },
- ],
- {
- title: 'p50 of /api/cats',
- interval: '1d',
- id: '3',
- }
- ),
- ];
- mockVisit = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/visit/',
- method: 'POST',
- body: [],
- statusCode: 200,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [TestStubs.Project()],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- TestStubs.Dashboard([], {
- id: 'default-overview',
- title: 'Default',
- widgetDisplay: ['area'],
- }),
- TestStubs.Dashboard([], {
- id: '1',
- title: 'Custom Errors',
- widgetDisplay: ['area'],
- }),
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {},
- }),
- });
- mockPut = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: TestStubs.Dashboard(widgets, {id: '1', title: 'Custom Errors'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- method: 'POST',
- url: '/organizations/org-slug/dashboards/widgets/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/recent-searches/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/issues/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/sdk-updates/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/prompts-activity/',
- body: {},
- });
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- });
- it('can remove widgets', async function () {
- const updateMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: TestStubs.Dashboard([widgets[0]], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- await waitFor(() => expect(mockVisit).toHaveBeenCalledTimes(1));
- // Enter edit mode.
- await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
- // Remove the second and third widgets
- await userEvent.click(screen.getAllByRole('button', {name: 'Delete Widget'})[1]);
- await userEvent.click(screen.getAllByRole('button', {name: 'Delete Widget'})[1]);
- // Save changes
- await userEvent.click(screen.getByRole('button', {name: 'Save and Finish'}));
- expect(updateMock).toHaveBeenCalled();
- expect(updateMock).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- title: 'Custom Errors',
- widgets: [expect.objectContaining(widgets[0])],
- }),
- })
- );
- // Visit should not be called again on dashboard update
- expect(mockVisit).toHaveBeenCalledTimes(1);
- });
- it('appends dashboard-level filters to series request', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {release: ['abc@1.2.0']},
- }),
- });
- const mock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- await waitFor(() =>
- expect(mock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: 'event.type:transaction transaction:/api/cats release:abc@1.2.0 ',
- }),
- })
- )
- );
- });
- it('shows add widget option', async function () {
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- // Enter edit mode.
- await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
- expect(await screen.findByRole('button', {name: 'Add widget'})).toBeInTheDocument();
- });
- it('shows top level release filter', async function () {
- const mockReleases = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [TestStubs.Release()],
- });
- initialData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- projects: [TestStubs.Project()],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- expect(await screen.findByText('All Releases')).toBeInTheDocument();
- expect(mockReleases).toHaveBeenCalledTimes(1);
- });
- it('hides add widget option', async function () {
- // @ts-expect-error this is assigning to readonly property...
- types.MAX_WIDGETS = 1;
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- // Enter edit mode.
- await userEvent.click(await screen.findByRole('button', {name: 'Edit Dashboard'}));
- expect(screen.queryByRole('button', {name: 'Add widget'})).not.toBeInTheDocument();
- });
- it('renders successfully if more widgets than stored layouts', async function () {
- // A case where someone has async added widgets to a dashboard
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {i: 'grid-item-1', x: 0, y: 0, w: 2, h: 6},
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'Second Widget',
- interval: '1d',
- id: '2',
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- expect(await screen.findByText('First Widget')).toBeInTheDocument();
- expect(await screen.findByText('Second Widget')).toBeInTheDocument();
- });
- it('does not trigger request if layout not updated', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {i: 'grid-item-1', x: 0, y: 0, w: 2, h: 6},
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- await userEvent.click(await screen.findByText('Save and Finish'));
- expect(screen.getByText('Edit Dashboard')).toBeInTheDocument();
- expect(mockPut).not.toHaveBeenCalled();
- });
- it('renders the custom resize handler for a widget', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {i: 'grid-item-1', x: 0, y: 0, w: 2, h: 6},
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- const widget = screen
- .getByText('First Widget')
- .closest('.react-grid-item') as HTMLElement;
- const resizeHandle = within(widget).getByTestId('custom-resize-handle');
- expect(resizeHandle).toBeVisible();
- });
- it('does not trigger an alert when the widgets have no layout and user cancels without changes', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: null,
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- await userEvent.click(await screen.findByText('Cancel'));
- expect(window.confirm).not.toHaveBeenCalled();
- });
- it('opens the widget viewer modal using the widget id specified in the url', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- const widget = TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '',
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: null,
- }
- );
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard([widget], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/123/'}}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- organization: initialData.organization,
- widget,
- onClose: expect.anything(),
- })
- );
- });
- });
- it('redirects user to dashboard url if widget is not found', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard([], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 123}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/123/'}}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- expect(await screen.findByText('All Releases')).toBeInTheDocument();
- expect(openWidgetViewerModal).not.toHaveBeenCalled();
- expect(initialData.router.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/1/',
- query: {},
- })
- );
- });
- it('saves a new dashboard with the page filters', async () => {
- const mockPOST = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- method: 'POST',
- body: [],
- });
- render(
- <CreateDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{templateId: undefined}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- query: {
- ...initialData.router.location.query,
- statsPeriod: '7d',
- project: [2],
- environment: ['alpha', 'beta'],
- },
- }}
- >
- {null}
- </CreateDashboard>,
- {
- context: initialData.routerContext,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('Save and Finish'));
- expect(mockPOST).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/',
- expect.objectContaining({
- data: expect.objectContaining({
- projects: [2],
- environment: ['alpha', 'beta'],
- period: '7d',
- }),
- })
- );
- });
- it('saves a template with the page filters', async () => {
- const mockPOST = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- method: 'POST',
- body: [],
- });
- render(
- <CreateDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{templateId: 'default-template'}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- query: {
- ...initialData.router.location.query,
- statsPeriod: '7d',
- project: [2],
- environment: ['alpha', 'beta'],
- },
- }}
- >
- {null}
- </CreateDashboard>,
- {
- context: initialData.routerContext,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('Add Dashboard'));
- expect(mockPOST).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/',
- expect.objectContaining({
- data: expect.objectContaining({
- projects: [2],
- environment: ['alpha', 'beta'],
- period: '7d',
- }),
- })
- );
- });
- it('does not render save and cancel buttons on templates', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- render(
- <CreateDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{templateId: 'default-template'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </CreateDashboard>,
- {
- context: initialData.routerContext,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('24H'));
- await userEvent.click(screen.getByText('Last 7 days'));
- await screen.findByText('7D');
- expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
- expect(screen.queryByText('Save')).not.toBeInTheDocument();
- });
- it('opens the widget viewer with saved dashboard filters', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/1/'}}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- dashboardFilters: {release: ['sentry-android-shop@1.2.0']},
- })
- );
- });
- });
- it('opens the widget viewer with unsaved dashboard filters', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- pathname: '/widget/1/',
- query: {release: ['unsaved-release-filter@1.2.0']},
- }}
- >
- {null}
- </ViewEditDashboard>,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- dashboardFilters: {release: ['unsaved-release-filter@1.2.0']},
- })
- );
- });
- });
- it('can save dashboard filters in existing dashboard', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- release: ['sentry-android-shop@1.2.0'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('Save'));
- expect(mockPut).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- period: '7d',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- })
- );
- });
- it('can clear dashboard filters in compact select', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText('7D');
- await userEvent.click(await screen.findByText('sentry-android-shop@1.2.0'));
- await userEvent.click(screen.getAllByText('Clear')[1]);
- screen.getByText('All Releases');
- await userEvent.click(document.body);
- expect(browserHistory.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- release: '',
- }),
- })
- );
- });
- it('can save absolute time range in existing dashboard', async () => {
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- start: '2022-07-14T07:00:00',
- end: '2022-07-19T23:59:59',
- utc: 'true',
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('Save'));
- expect(mockPut).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- start: '2022-07-14T07:00:00.000',
- end: '2022-07-19T23:59:59.000',
- utc: true,
- }),
- })
- );
- });
- it('can clear dashboard filters in existing dashboard', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- environment: ['alpha', 'beta'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText('7D');
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
- await userEvent.keyboard('{Escape}');
- await userEvent.click(screen.getByText('Cancel'));
- screen.getByText('All Releases');
- expect(browserHistory.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- project: undefined,
- statsPeriod: undefined,
- environment: undefined,
- }),
- })
- );
- });
- it('disables the Edit Dashboard button when there are unsaved filters', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-basic',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- environment: ['alpha', 'beta'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- expect(await screen.findByText('Save')).toBeInTheDocument();
- expect(screen.getByText('Cancel')).toBeInTheDocument();
- expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
- });
- it('ignores the order of selection of page filters to render unsaved filters', async () => {
- const testProjects = [
- TestStubs.Project({id: '1', name: 'first', environments: ['alpha', 'beta']}),
- TestStubs.Project({id: '2', name: 'second', environments: ['alpha', 'beta']}),
- ];
- act(() => ProjectsStore.loadInitialData(testProjects));
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: testProjects,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {},
- environment: ['alpha', 'beta'],
- }),
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- environment: ['beta', 'alpha'], // Reversed order from saved dashboard
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await waitFor(() => expect(screen.queryAllByText('Loading\u2026')).toEqual([]));
- await userEvent.click(screen.getByRole('button', {name: 'All Envs'}));
- expect(screen.getByRole('row', {name: 'alpha'})).toHaveAttribute(
- 'aria-selected',
- 'true'
- );
- expect(screen.getByRole('row', {name: 'beta'})).toHaveAttribute(
- 'aria-selected',
- 'true'
- );
- // Save and Cancel should not appear because alpha, beta is the same as beta, alpha
- expect(screen.queryByText('Save')).not.toBeInTheDocument();
- expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
- });
- it('uses releases from the URL query params', async function () {
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- release: ['not-selected-1'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText(/not-selected-1/);
- screen.getByText('Save');
- screen.getByText('Cancel');
- });
- it('resets release in URL params', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {
- release: ['abc'],
- },
- }),
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- release: ['not-selected-1'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText(/not-selected-1/);
- await userEvent.click(screen.getByText('Cancel'));
- // release isn't used in the redirect
- expect(browserHistory.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- query: {
- end: undefined,
- environment: undefined,
- project: undefined,
- start: undefined,
- statsPeriod: undefined,
- utc: undefined,
- },
- })
- );
- });
- it('reflects selections in the release filter in the query params', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: TestStubs.location(),
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
- await userEvent.click(document.body);
- expect(browserHistory.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- release: ['sentry-android-shop@1.2.0'],
- }),
- })
- );
- });
- it('persists release selections made during search requests that do not appear in default query', async function () {
- // Default response
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- // Mocked search results
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- id: '9',
- shortVersion: 'search-result',
- version: 'search-result',
- }),
- ],
- match: [MockApiClient.matchData({query: 's'})],
- });
- const testData = initializeOrg({
- organization: Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-basic',
- 'discover-query',
- ],
- }),
- router: {
- location: TestStubs.location(),
- },
- });
- render(
- <ViewEditDashboard
- {...TestStubs.routeComponentProps()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.type(screen.getAllByPlaceholderText('Search\u2026')[2], 's');
- await userEvent.click(await screen.findByRole('option', {name: 'search-result'}));
- // Validate that after search is cleared, search result still appears
- expect(await screen.findByText('Latest Release(s)')).toBeInTheDocument();
- expect(screen.getByRole('option', {name: 'search-result'})).toBeInTheDocument();
- });
- });
- });
|