spanOperationTable.tsx 7.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201
  1. import * as qs from 'query-string';
  2. import {getInterval} from 'sentry/components/charts/utils';
  3. import Duration from 'sentry/components/duration';
  4. import Link from 'sentry/components/links/link';
  5. import {t} from 'sentry/locale';
  6. import type {NewQuery} from 'sentry/types/organization';
  7. import EventView from 'sentry/utils/discover/eventView';
  8. import {NumberContainer} from 'sentry/utils/discover/styles';
  9. import {DiscoverDatasets} from 'sentry/utils/discover/types';
  10. import {decodeScalar} from 'sentry/utils/queryString';
  11. import {MutableSearch} from 'sentry/utils/tokenizeSearch';
  12. import {useLocation} from 'sentry/utils/useLocation';
  13. import useOrganization from 'sentry/utils/useOrganization';
  14. import usePageFilters from 'sentry/utils/usePageFilters';
  15. import {normalizeUrl} from 'sentry/utils/withDomainRequired';
  16. import {APP_START_SPANS} from 'sentry/views/performance/mobile/appStarts/screenSummary/spanOpSelector';
  17. import type {SpanOperationTableProps} from 'sentry/views/performance/mobile/components/samplesTables';
  18. import {ScreensTable} from 'sentry/views/performance/mobile/components/screensTable';
  19. import {MobileCursors} from 'sentry/views/performance/mobile/screenload/screens/constants';
  20. import {useTableQuery} from 'sentry/views/performance/mobile/screenload/screens/screensTable';
  21. import {Referrer} from 'sentry/views/performance/mobile/ui/referrers';
  22. import {
  23. PRIMARY_RELEASE_ALIAS,
  24. SECONDARY_RELEASE_ALIAS,
  25. } from 'sentry/views/starfish/components/releaseSelector';
  26. import {OverflowEllipsisTextContainer} from 'sentry/views/starfish/components/textAlign';
  27. import {SpanMetricsField} from 'sentry/views/starfish/types';
  28. import {STARFISH_CHART_INTERVAL_FIDELITY} from 'sentry/views/starfish/utils/constants';
  29. import {appendReleaseFilters} from 'sentry/views/starfish/utils/releaseComparison';
  30. const {SPAN_DESCRIPTION, SPAN_GROUP, SPAN_OP, PROJECT_ID} = SpanMetricsField;
  31. const VALID_SPAN_OPS = APP_START_SPANS;
  32. export function SpanOperationTable({
  33. transaction,
  34. primaryRelease,
  35. secondaryRelease,
  36. }: SpanOperationTableProps) {
  37. const location = useLocation();
  38. const {selection} = usePageFilters();
  39. const organization = useOrganization();
  40. const cursor = decodeScalar(location.query?.[MobileCursors.SPANS_TABLE]);
  41. const spanOp = decodeScalar(location.query[SpanMetricsField.SPAN_OP]) ?? '';
  42. const deviceClass = decodeScalar(location.query[SpanMetricsField.DEVICE_CLASS]) ?? '';
  43. // TODO: These filters seem to be too aggressive, check that they are ingesting properly
  44. const searchQuery = new MutableSearch([
  45. // 'has:span.description',
  46. // 'transaction.op:ui.load',
  47. `transaction:${transaction}`,
  48. `${SpanMetricsField.SPAN_OP}:${spanOp ? spanOp : `[${VALID_SPAN_OPS.join(',')}]`}`,
  49. ...(spanOp ? [`${SpanMetricsField.SPAN_OP}:${spanOp}`] : []),
  50. ...(deviceClass ? [`${SpanMetricsField.DEVICE_CLASS}:${deviceClass}`] : []),
  51. ]);
  52. const queryStringPrimary = appendReleaseFilters(
  53. searchQuery,
  54. primaryRelease,
  55. secondaryRelease
  56. );
  57. const orderby = decodeScalar(location.query.sort, '');
  58. const newQuery: NewQuery = {
  59. name: '',
  60. fields: [
  61. PROJECT_ID,
  62. SPAN_OP,
  63. SPAN_GROUP,
  64. SPAN_DESCRIPTION,
  65. `avg_if(mobile.slow_frames,release,${primaryRelease})`,
  66. `avg_if(mobile.slow_frames,release,${secondaryRelease})`,
  67. `avg_compare(mobile.slow_frames,release,${primaryRelease},${secondaryRelease})`,
  68. `avg_if(mobile.frozen_frames,release,${primaryRelease})`,
  69. `avg_if(mobile.frozen_frames,release,${secondaryRelease})`,
  70. `avg_compare(mobile.frozen_frames,release,${primaryRelease},${secondaryRelease})`,
  71. `avg_if(mobile.frames_delay,release,${primaryRelease})`,
  72. `avg_if(mobile.frames_delay,release,${secondaryRelease})`,
  73. `avg_compare(mobile.frames_delay,release,${primaryRelease},${secondaryRelease})`,
  74. ],
  75. query: queryStringPrimary,
  76. orderby,
  77. dataset: DiscoverDatasets.SPANS_METRICS,
  78. version: 2,
  79. projects: selection.projects,
  80. interval: getInterval(selection.datetime, STARFISH_CHART_INTERVAL_FIDELITY),
  81. };
  82. const eventView = EventView.fromNewQueryWithLocation(newQuery, location);
  83. const {data, isLoading, pageLinks} = useTableQuery({
  84. eventView,
  85. enabled: true,
  86. referrer: Referrer.SPAN_OPERATION_TABLE,
  87. cursor,
  88. });
  89. const columnNameMap = {
  90. [SPAN_OP]: t('Operation'),
  91. [SPAN_DESCRIPTION]: t('Span Description'),
  92. [`avg_if(mobile.slow_frames,release,${primaryRelease})`]: t(
  93. 'Slow (%s)',
  94. PRIMARY_RELEASE_ALIAS
  95. ),
  96. [`avg_if(mobile.slow_frames,release,${secondaryRelease})`]: t(
  97. 'Slow (%s)',
  98. SECONDARY_RELEASE_ALIAS
  99. ),
  100. [`avg_compare(mobile.slow_frames,release,${primaryRelease},${secondaryRelease})`]:
  101. t('Change'),
  102. [`avg_if(mobile.frozen_frames,release,${primaryRelease})`]: t(
  103. 'Frozen (%s)',
  104. PRIMARY_RELEASE_ALIAS
  105. ),
  106. [`avg_if(mobile.frozen_frames,release,${secondaryRelease})`]: t(
  107. 'Frozen (%s)',
  108. SECONDARY_RELEASE_ALIAS
  109. ),
  110. [`avg_compare(mobile.frozen_frames,release,${primaryRelease},${secondaryRelease})`]:
  111. t('Change'),
  112. [`avg_if(mobile.frames_delay,release,${primaryRelease})`]: t(
  113. 'Delay (%s)',
  114. PRIMARY_RELEASE_ALIAS
  115. ),
  116. [`avg_if(mobile.frames_delay,release,${secondaryRelease})`]: t(
  117. 'Delay (%s)',
  118. SECONDARY_RELEASE_ALIAS
  119. ),
  120. [`avg_compare(mobile.frames_delay,release,${primaryRelease},${secondaryRelease})`]:
  121. t('Change'),
  122. };
  123. function renderBodyCell(column, row) {
  124. if (column.key === SPAN_DESCRIPTION) {
  125. const label = row[SpanMetricsField.SPAN_DESCRIPTION];
  126. const pathname = normalizeUrl(
  127. `/organizations/${organization.slug}/performance/mobile/ui/spans/`
  128. );
  129. const query = {
  130. ...location.query,
  131. transaction,
  132. spanOp: row[SpanMetricsField.SPAN_OP],
  133. spanGroup: row[SpanMetricsField.SPAN_GROUP],
  134. spanDescription: row[SpanMetricsField.SPAN_DESCRIPTION],
  135. };
  136. return (
  137. <Link to={`${pathname}?${qs.stringify(query)}`}>
  138. <OverflowEllipsisTextContainer>{label}</OverflowEllipsisTextContainer>
  139. </Link>
  140. );
  141. }
  142. if (column.key.startsWith('avg_if(mobile.frames_delay')) {
  143. return (
  144. <NumberContainer>
  145. {typeof row[column.key] === 'number' ? (
  146. <Duration seconds={row[column.key]} fixedDigits={2} abbreviation />
  147. ) : (
  148. '-'
  149. )}
  150. </NumberContainer>
  151. );
  152. }
  153. return null;
  154. }
  155. return (
  156. <ScreensTable
  157. columnNameMap={columnNameMap}
  158. data={data}
  159. eventView={eventView}
  160. isLoading={isLoading}
  161. pageLinks={pageLinks}
  162. columnOrder={[
  163. String(SPAN_OP),
  164. String(SPAN_DESCRIPTION),
  165. `avg_if(mobile.slow_frames,release,${primaryRelease})`,
  166. `avg_if(mobile.slow_frames,release,${secondaryRelease})`,
  167. `avg_compare(mobile.slow_frames,release,${primaryRelease},${secondaryRelease})`,
  168. `avg_if(mobile.frozen_frames,release,${primaryRelease})`,
  169. `avg_if(mobile.frozen_frames,release,${secondaryRelease})`,
  170. `avg_compare(mobile.frozen_frames,release,${primaryRelease},${secondaryRelease})`,
  171. `avg_if(mobile.frames_delay,release,${primaryRelease})`,
  172. `avg_if(mobile.frames_delay,release,${secondaryRelease})`,
  173. `avg_compare(mobile.frames_delay,release,${primaryRelease},${secondaryRelease})`,
  174. ]}
  175. defaultSort={[
  176. {
  177. key: `avg_compare(mobile.frames_delay,release,${primaryRelease},${secondaryRelease})`,
  178. order: 'desc',
  179. },
  180. ]}
  181. customBodyCellRenderer={renderBodyCell}
  182. />
  183. );
  184. }