1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300 |
- import selectEvent from 'react-select-event';
- import {urlEncode} from '@sentry/utils';
- import {MetricsField} from 'sentry-fixture/metrics';
- import {SessionsField} from 'sentry-fixture/sessions';
- import {Tags} from 'sentry-fixture/tags';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- render,
- screen,
- userEvent,
- waitFor,
- within,
- } from 'sentry-test/reactTestingLibrary';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import TagStore from 'sentry/stores/tagStore';
- import {
- DashboardDetails,
- DashboardWidgetSource,
- DisplayType,
- // Widget,
- WidgetType,
- } from 'sentry/views/dashboards/types';
- import WidgetBuilder, {WidgetBuilderProps} from 'sentry/views/dashboards/widgetBuilder';
- const defaultOrgFeatures = [
- 'performance-view',
- 'dashboards-edit',
- 'global-views',
- 'dashboards-mep',
- 'dashboards-rh-widget',
- ];
- // function mockDashboard(dashboard: Partial<DashboardDetails>): DashboardDetails {
- // return {
- // id: '1',
- // title: 'Dashboard',
- // createdBy: undefined,
- // dateCreated: '2020-01-01T00:00:00.000Z',
- // widgets: [],
- // projects: [],
- // filters: {},
- // ...dashboard,
- // };
- // }
- function renderTestComponent({
- dashboard,
- query,
- orgFeatures,
- onSave,
- params,
- }: {
- dashboard?: WidgetBuilderProps['dashboard'];
- onSave?: WidgetBuilderProps['onSave'];
- orgFeatures?: string[];
- params?: Partial<WidgetBuilderProps['params']>;
- query?: Record<string, any>;
- } = {}) {
- const {organization, router, routerContext} = initializeOrg({
- organization: {
- features: orgFeatures ?? defaultOrgFeatures,
- },
- router: {
- location: {
- query: {
- source: DashboardWidgetSource.DASHBOARDS,
- ...query,
- },
- },
- },
- });
- ProjectsStore.loadInitialData(organization.projects);
- render(
- <WidgetBuilder
- route={{}}
- router={router}
- routes={router.routes}
- routeParams={router.params}
- location={router.location}
- dashboard={{
- id: 'new',
- title: 'Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- ...dashboard,
- }}
- onSave={onSave ?? jest.fn()}
- params={{
- orgId: organization.slug,
- dashboardId: dashboard?.id ?? 'new',
- ...params,
- }}
- />,
- {
- context: routerContext,
- organization,
- }
- );
- return {router};
- }
- describe('WidgetBuilder', function () {
- const untitledDashboard: DashboardDetails = {
- id: '1',
- title: 'Untitled Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- };
- const testDashboard: DashboardDetails = {
- id: '2',
- title: 'Test Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- };
- let eventsMock: jest.Mock | undefined;
- let sessionsDataMock: jest.Mock | undefined;
- let metricsDataMock: jest.Mock | undefined;
- let measurementsMetaMock: jest.Mock | undefined;
- beforeEach(function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- {...untitledDashboard, widgetDisplay: [DisplayType.TABLE]},
- {...testDashboard, widgetDisplay: [DisplayType.AREA]},
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/widgets/',
- method: 'POST',
- statusCode: 200,
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/eventsv2/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {},
- data: [],
- },
- });
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {fields: {}},
- data: [],
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/recent-searches/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/recent-searches/',
- method: 'POST',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/issues/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/event.type/values/',
- body: [{count: 2, name: 'Nvidia 1080ti'}],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- body: [],
- });
- sessionsDataMock = MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/sessions/',
- body: SessionsField(`sum(session)`),
- });
- metricsDataMock = MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/metrics/data/',
- body: MetricsField('session.all'),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- method: 'GET',
- body: Tags(),
- });
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/is/values/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/metrics-compatibility/',
- method: 'GET',
- body: {
- incompatible_projects: [],
- compatible_projects: [1],
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/metrics-compatibility-sums/',
- method: 'GET',
- body: {
- sum: {
- metrics: 988803,
- metrics_null: 0,
- metrics_unparam: 132,
- },
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- TagStore.reset();
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- jest.useRealTimers();
- });
- describe('Release Widgets', function () {
- it('shows the Release Health dataset', async function () {
- renderTestComponent();
- expect(await screen.findByText('Errors and Transactions')).toBeInTheDocument();
- expect(screen.getByText('Releases (Sessions, Crash rates)')).toBeInTheDocument();
- });
- it('maintains the selected dataset when display type is changed', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- expect(screen.getByRole('radio', {name: /Releases/i})).not.toBeChecked();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- await waitFor(() =>
- expect(screen.getByRole('radio', {name: /Releases/i})).toBeChecked()
- );
- await userEvent.click(screen.getByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- await waitFor(() =>
- expect(screen.getByRole('radio', {name: /Releases/i})).toBeChecked()
- );
- });
- it('displays releases tags', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
- expect(screen.getByText('session')).toBeInTheDocument();
- await userEvent.click(screen.getByText('crash_free_rate(…)'));
- expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
- expect(screen.getByText('release')).toBeInTheDocument();
- expect(screen.getByText('environment')).toBeInTheDocument();
- expect(screen.getByText('session.status')).toBeInTheDocument();
- await userEvent.click(screen.getByText('count_unique(…)'));
- expect(screen.getByText('user')).toBeInTheDocument();
- });
- it('does not display tags as params', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
- await selectEvent.select(screen.getByText('crash_free_rate(…)'), 'count_unique(…)');
- await userEvent.click(screen.getByText('user'));
- expect(screen.queryByText('release')).not.toBeInTheDocument();
- expect(screen.queryByText('environment')).not.toBeInTheDocument();
- expect(screen.queryByText('session.status')).not.toBeInTheDocument();
- });
- it('does not allow sort by when session.status is selected', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- expect(screen.getByText('High to low')).toBeEnabled();
- expect(screen.getByText('crash_free_rate(session)')).toBeInTheDocument();
- await userEvent.click(screen.getByLabelText('Add a Column'));
- await selectEvent.select(screen.getByText('(Required)'), 'session.status');
- expect(screen.getByRole('textbox', {name: 'Sort direction'})).toBeDisabled();
- expect(screen.getByRole('textbox', {name: 'Sort by'})).toBeDisabled();
- });
- it('does not allow sort on tags except release', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- expect(
- within(screen.getByTestId('sort-by-step')).getByText('High to low')
- ).toBeEnabled();
- expect(
- within(screen.getByTestId('sort-by-step')).getByText('crash_free_rate(session)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByLabelText('Add a Column'), {delay: null});
- await selectEvent.select(screen.getByText('(Required)'), 'release');
- await userEvent.click(screen.getByLabelText('Add a Column'), {delay: null});
- await selectEvent.select(screen.getByText('(Required)'), 'environment');
- expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
- // Selector "sortDirection"
- expect(screen.getByText('High to low')).toBeInTheDocument();
- // Selector "sortBy"
- await userEvent.click(screen.getAllByText('crash_free_rate(session)')[1], {
- delay: null,
- });
- // release exists in sort by selector
- expect(screen.getAllByText('release')).toHaveLength(3);
- // environment does not exist in sort by selector
- expect(screen.getAllByText('environment')).toHaveLength(2);
- });
- it('makes the appropriate sessions call', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- await userEvent.click(screen.getByText('Table'), {delay: null});
- await userEvent.click(screen.getByText('Line Chart'), {delay: null});
- await waitFor(() =>
- expect(metricsDataMock).toHaveBeenLastCalledWith(
- `/organizations/org-slug/metrics/data/`,
- expect.objectContaining({
- query: expect.objectContaining({
- environment: [],
- field: [`session.crash_free_rate`],
- groupBy: [],
- interval: '5m',
- project: [],
- statsPeriod: '24h',
- }),
- })
- )
- );
- });
- it('calls the session endpoint with the right limit', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- await userEvent.click(screen.getByText('Table'), {delay: null});
- await userEvent.click(screen.getByText('Line Chart'), {delay: null});
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
- await waitFor(() =>
- expect(metricsDataMock).toHaveBeenLastCalledWith(
- `/organizations/org-slug/metrics/data/`,
- expect.objectContaining({
- query: expect.objectContaining({
- environment: [],
- field: ['session.crash_free_rate'],
- groupBy: ['project_id'],
- interval: '5m',
- orderBy: '-session.crash_free_rate',
- per_page: 5,
- project: [],
- statsPeriod: '24h',
- }),
- })
- )
- );
- });
- it('calls sessions api when session.status is selected as a groupby', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- await userEvent.click(screen.getByText('Table'), {delay: null});
- await userEvent.click(screen.getByText('Line Chart'), {delay: null});
- await selectEvent.select(await screen.findByText('Select group'), 'session.status');
- expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
- await waitFor(() =>
- expect(sessionsDataMock).toHaveBeenLastCalledWith(
- `/organizations/org-slug/sessions/`,
- expect.objectContaining({
- query: expect.objectContaining({
- environment: [],
- field: ['crash_free_rate(session)'],
- groupBy: ['session.status'],
- interval: '5m',
- project: [],
- statsPeriod: '24h',
- }),
- })
- )
- );
- });
- it('displays the correct options for area chart', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- // change dataset to releases
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- await userEvent.click(screen.getByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
- expect(screen.getByText(`session`)).toBeInTheDocument();
- await userEvent.click(screen.getByText('crash_free_rate(…)'));
- expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
- await userEvent.click(screen.getByText('count_unique(…)'));
- expect(screen.getByText('user')).toBeInTheDocument();
- });
- it('sets widgetType to release', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- await userEvent.click(await screen.findByText('Releases (Sessions, Crash rates)'), {
- delay: null,
- });
- expect(metricsDataMock).toHaveBeenCalled();
- expect(screen.getByRole('radio', {name: /Releases/i})).toBeChecked();
- });
- // TODO(ddm): check why this test fails
- // it('does not display "add an equation" button', async function () {
- // const widget: Widget = {
- // title: 'Release Widget',
- // displayType: DisplayType.TABLE,
- // widgetType: WidgetType.RELEASE,
- // queries: [
- // {
- // name: 'errors',
- // conditions: '',
- // fields: ['session.crash_free_rate'],
- // columns: ['scount_abnormal(session)'],
- // aggregates: ['session.crash_free_rate'],
- // orderby: '-session.crash_free_rate',
- // },
- // ],
- // interval: '1d',
- // id: '1',
- // };
- // const dashboard = mockDashboard({widgets: [widget]});
- // renderTestComponent({
- // dashboard,
- // params: {
- // widgetIndex: '0',
- // },
- // });
- // // Select line chart display
- // await userEvent.click(await screen.findByText('Table'));
- // await userEvent.click(screen.getByText('Line Chart'));
- // await waitFor(() =>
- // expect(screen.queryByLabelText('Add an Equation')).not.toBeInTheDocument()
- // );
- // });
- it('renders with a release search bar', async function () {
- renderTestComponent();
- await userEvent.type(
- await screen.findByPlaceholderText('Search for events, users, tags, and more'),
- 'session.status:'
- );
- await waitFor(() => {
- expect(screen.getByText("The field isn't supported here.")).toBeInTheDocument();
- });
- await userEvent.click(screen.getByText('Releases (Sessions, Crash rates)'));
- await userEvent.click(
- screen.getByPlaceholderText(
- 'Search for release version, session status, and more'
- )
- );
- expect(await screen.findByText('environment')).toBeInTheDocument();
- expect(screen.getByText('project')).toBeInTheDocument();
- expect(screen.getByText('release')).toBeInTheDocument();
- });
- it('adds a function when the only column chosen in a table is a tag', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- await userEvent.click(await screen.findByText('Releases (Sessions, Crash rates)'), {
- delay: null,
- });
- await selectEvent.select(screen.getByText('crash_free_rate(…)'), 'environment');
- // 1 in the table header, 1 in the column selector, and 1 in the sort by
- expect(screen.getAllByText(/crash_free_rate/)).toHaveLength(3);
- expect(screen.getAllByText('environment')).toHaveLength(2);
- });
- });
- describe('Issue Widgets', function () {
- it('sets widgetType to issues', async function () {
- const handleSave = jest.fn();
- renderTestComponent({onSave: handleSave});
- await userEvent.click(
- await screen.findByText('Issues (States, Assignment, Time, etc.)')
- );
- await userEvent.click(screen.getByLabelText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- title: 'Custom Widget',
- displayType: DisplayType.TABLE,
- interval: '5m',
- widgetType: WidgetType.ISSUE,
- queries: [
- {
- conditions: '',
- fields: ['issue', 'assignee', 'title'],
- columns: ['issue', 'assignee', 'title'],
- aggregates: [],
- fieldAliases: [],
- name: '',
- orderby: 'date',
- },
- ],
- }),
- ]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('render issues dataset disabled when the display type is not set to table', async function () {
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- },
- });
- await userEvent.click(await screen.findByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(
- screen.getByRole('radio', {
- name: 'Errors and Transactions',
- })
- ).toBeEnabled();
- expect(
- screen.getByRole('radio', {
- name: 'Issues (States, Assignment, Time, etc.)',
- })
- ).toBeDisabled();
- });
- it('disables moving and deleting issue column', async function () {
- renderTestComponent();
- await userEvent.click(
- await screen.findByText('Issues (States, Assignment, Time, etc.)')
- );
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('issue')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('assignee')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('title')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).getAllByLabelText(
- 'Remove column'
- )
- ).toHaveLength(2);
- expect(
- within(screen.getByTestId('choose-column-step')).getAllByLabelText(
- 'Drag to reorder'
- )
- ).toHaveLength(3);
- await userEvent.click(screen.getAllByLabelText('Remove column')[1]);
- await userEvent.click(screen.getAllByLabelText('Remove column')[0]);
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('issue')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByText('assignee')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByText('title')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByLabelText('Remove column')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByLabelText(
- 'Drag to reorder'
- )
- ).not.toBeInTheDocument();
- });
- it('issue query does not work on default search bar', async function () {
- renderTestComponent();
- const input = (await screen.findByPlaceholderText(
- 'Search for events, users, tags, and more'
- )) as HTMLTextAreaElement;
- await userEvent.type(input, 'bookmarks');
- input.setSelectionRange(9, 9);
- expect(await screen.findByText('No items found')).toBeInTheDocument();
- });
- it('renders with an issues search bar when selected in dataset selection', async function () {
- renderTestComponent();
- await userEvent.click(
- await screen.findByText('Issues (States, Assignment, Time, etc.)')
- );
- const input = (await screen.findByPlaceholderText(
- 'Search for issues, status, assigned, and more'
- )) as HTMLTextAreaElement;
- await userEvent.type(input, 'is:');
- input.setSelectionRange(3, 3);
- expect(await screen.findByText('resolved')).toBeInTheDocument();
- });
- it('Update table header values (field alias)', async function () {
- const handleSave = jest.fn();
- renderTestComponent({
- onSave: handleSave,
- });
- await screen.findByText('Table');
- await userEvent.click(screen.getByText('Issues (States, Assignment, Time, etc.)'));
- await userEvent.type(screen.getAllByPlaceholderText('Alias')[0], 'First Alias');
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- queries: [
- expect.objectContaining({
- fieldAliases: ['First Alias', '', ''],
- }),
- ],
- }),
- ]);
- });
- });
- });
- describe('Events Widgets', function () {
- describe('Custom Performance Metrics', function () {
- it('can choose a custom measurement', async function () {
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {'measurements.custom.measurement': {functions: ['p99']}},
- });
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.total.db.calls)': 'duration'},
- isMetricsData: true,
- },
- data: [{'p99(measurements.total.db.calls)': 10}],
- },
- });
- const {router} = renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
- // 1 in the table header, 1 in the column selector, 1 in the sort field
- const countFields = screen.getAllByText('count()');
- expect(countFields).toHaveLength(3);
- await selectEvent.select(countFields[1], ['p99(…)']);
- await selectEvent.select(screen.getByText('transaction.duration'), [
- 'measurements.custom.measurement',
- ]);
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/2/',
- query: {
- displayType: 'table',
- interval: '5m',
- title: 'Custom Widget',
- queryNames: [''],
- queryConditions: [''],
- queryFields: ['p99(measurements.custom.measurement)'],
- queryOrderby: '-p99(measurements.custom.measurement)',
- start: null,
- end: null,
- statsPeriod: '24h',
- utc: null,
- project: [],
- environment: [],
- },
- })
- );
- });
- });
- it('raises an alert banner but allows saving widget if widget result is not metrics data and widget is using custom measurements', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'duration'},
- isMetricsData: false,
- },
- data: [{'p99(measurements.custom.measurement)': 10}],
- },
- });
- const defaultWidgetQuery = {
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- conditions: 'user:test.user@sentry.io',
- orderby: '',
- };
- const defaultTableColumns = ['p99(measurements.custom.measurement)'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.TABLE,
- defaultTableColumns,
- },
- orgFeatures: [
- ...defaultOrgFeatures,
- 'dashboards-mep',
- 'dynamic-sampling',
- 'mep-rollout-flag',
- ],
- });
- await waitFor(() => {
- expect(measurementsMetaMock).toHaveBeenCalled();
- });
- await waitFor(() => {
- expect(eventsMock).toHaveBeenCalled();
- });
- screen.getByText('Your selection is only applicable to', {exact: false});
- expect(screen.getByText('Add Widget').closest('button')).toBeEnabled();
- });
- it('raises an alert banner if widget result is not metrics data', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.lcp)': 'duration'},
- isMetricsData: false,
- },
- data: [{'p99(measurements.lcp)': 10}],
- },
- });
- const defaultWidgetQuery = {
- name: '',
- fields: ['p99(measurements.lcp)'],
- columns: [],
- aggregates: ['p99(measurements.lcp)'],
- conditions: 'user:test.user@sentry.io',
- orderby: '',
- };
- const defaultTableColumns = ['p99(measurements.lcp)'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.TABLE,
- defaultTableColumns,
- },
- orgFeatures: [
- ...defaultOrgFeatures,
- 'dashboards-mep',
- 'dynamic-sampling',
- 'mep-rollout-flag',
- ],
- });
- await waitFor(() => {
- expect(measurementsMetaMock).toHaveBeenCalled();
- });
- await waitFor(() => {
- expect(eventsMock).toHaveBeenCalled();
- });
- screen.getByText('Your selection is only applicable to', {exact: false});
- });
- it('does not raise an alert banner if widget result is not metrics data but widget contains error fields', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.lcp)': 'duration'},
- isMetricsData: false,
- },
- data: [{'p99(measurements.lcp)': 10}],
- },
- });
- const defaultWidgetQuery = {
- name: '',
- fields: ['p99(measurements.lcp)'],
- columns: ['error.handled'],
- aggregates: ['p99(measurements.lcp)'],
- conditions: 'user:test.user@sentry.io',
- orderby: '',
- };
- const defaultTableColumns = ['p99(measurements.lcp)'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.TABLE,
- defaultTableColumns,
- },
- orgFeatures: [...defaultOrgFeatures, 'dashboards-mep'],
- });
- await waitFor(() => {
- expect(measurementsMetaMock).toHaveBeenCalled();
- });
- await waitFor(() => {
- expect(eventsMock).toHaveBeenCalled();
- });
- expect(
- screen.queryByText('Your selection is only applicable to', {exact: false})
- ).not.toBeInTheDocument();
- });
- it('only displays custom measurements in supported functions', async function () {
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {
- 'measurements.custom.measurement': {functions: ['p99']},
- 'measurements.another.custom.measurement': {functions: ['p95']},
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
- await selectEvent.select(screen.getAllByText('count()')[1], ['p99(…)']);
- await userEvent.click(screen.getByText('transaction.duration'));
- screen.getByText('measurements.custom.measurement');
- expect(
- screen.queryByText('measurements.another.custom.measurement')
- ).not.toBeInTheDocument();
- await selectEvent.select(screen.getAllByText('p99(…)')[0], ['p95(…)']);
- await userEvent.click(screen.getByText('transaction.duration'));
- screen.getByText('measurements.another.custom.measurement');
- expect(
- screen.queryByText('measurements.custom.measurement')
- ).not.toBeInTheDocument();
- });
- it('renders custom performance metric using duration units from events meta', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'duration'},
- isMetricsData: true,
- units: {'p99(measurements.custom.measurement)': 'hour'},
- },
- data: [{'p99(measurements.custom.measurement)': 12}],
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('12.00hr');
- });
- it('renders custom performance metric using size units from events meta', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'size'},
- isMetricsData: true,
- units: {'p99(measurements.custom.measurement)': 'kibibyte'},
- },
- data: [{'p99(measurements.custom.measurement)': 12}],
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('12.0 KiB');
- });
- it('renders custom performance metric using abyte format size units from events meta', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'size'},
- isMetricsData: true,
- units: {'p99(measurements.custom.measurement)': 'kilobyte'},
- },
- data: [{'p99(measurements.custom.measurement)': 12000}],
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('12 MB');
- });
- it('displays saved custom performance metric in column select', async function () {
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('measurements.custom.measurement');
- });
- it('displays custom performance metric in column select dropdown', async function () {
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {'measurements.custom.measurement': {functions: ['p99']}},
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['transaction', 'count()'],
- columns: ['transaction'],
- aggregates: ['count()'],
- orderby: '-count()',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('transaction');
- await userEvent.click(screen.getAllByText('count()')[1]);
- expect(screen.getByText('measurements.custom.measurement')).toBeInTheDocument();
- });
- it('does not default to sorting by transaction when columns change', async function () {
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: [
- 'p99(measurements.custom.measurement)',
- 'transaction',
- 'count()',
- ],
- columns: ['transaction'],
- aggregates: ['p99(measurements.custom.measurement)', 'count()'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(
- await screen.findByText('p99(measurements.custom.measurement)')
- ).toBeInTheDocument();
- // Delete p99(measurements.custom.measurement) column
- await userEvent.click(screen.getAllByLabelText('Remove column')[0]);
- expect(
- screen.queryByText('p99(measurements.custom.measurement)')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('sort-by-step')).queryByText('transaction')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('sort-by-step')).getByText('count()')
- ).toBeInTheDocument();
- });
- });
- });
- });
|