widgetBuilder.spec.tsx 125 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865
  1. import selectEvent from 'react-select-event';
  2. import {urlEncode} from '@sentry/utils';
  3. import {initializeOrg} from 'sentry-test/initializeOrg';
  4. import {mountGlobalModal} from 'sentry-test/modal';
  5. import {act, render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
  6. import * as indicators from 'sentry/actionCreators/indicator';
  7. import * as modals from 'sentry/actionCreators/modal';
  8. import TagStore from 'sentry/stores/tagStore';
  9. import {TOP_N} from 'sentry/utils/discover/types';
  10. import {
  11. DashboardDetails,
  12. DashboardWidgetSource,
  13. DisplayType,
  14. Widget,
  15. WidgetType,
  16. } from 'sentry/views/dashboardsV2/types';
  17. import WidgetBuilder, {WidgetBuilderProps} from 'sentry/views/dashboardsV2/widgetBuilder';
  18. const defaultOrgFeatures = [
  19. 'performance-view',
  20. 'new-widget-builder-experience-design',
  21. 'dashboards-edit',
  22. 'global-views',
  23. 'dashboards-mep',
  24. ];
  25. // Mocking worldMapChart to avoid act warnings
  26. jest.mock('sentry/components/charts/worldMapChart');
  27. function mockDashboard(dashboard: Partial<DashboardDetails>): DashboardDetails {
  28. return {
  29. id: '1',
  30. title: 'Dashboard',
  31. createdBy: undefined,
  32. dateCreated: '2020-01-01T00:00:00.000Z',
  33. widgets: [],
  34. projects: [],
  35. filters: {},
  36. ...dashboard,
  37. };
  38. }
  39. function renderTestComponent({
  40. dashboard,
  41. query,
  42. orgFeatures,
  43. onSave,
  44. params,
  45. }: {
  46. dashboard?: WidgetBuilderProps['dashboard'];
  47. onSave?: WidgetBuilderProps['onSave'];
  48. orgFeatures?: string[];
  49. params?: Partial<WidgetBuilderProps['params']>;
  50. query?: Record<string, any>;
  51. } = {}) {
  52. const {organization, router, routerContext} = initializeOrg({
  53. ...initializeOrg(),
  54. organization: {
  55. features: orgFeatures ?? defaultOrgFeatures,
  56. },
  57. router: {
  58. location: {
  59. query: {
  60. source: DashboardWidgetSource.DASHBOARDS,
  61. ...query,
  62. },
  63. },
  64. },
  65. });
  66. render(
  67. <WidgetBuilder
  68. route={{}}
  69. router={router}
  70. routes={router.routes}
  71. routeParams={router.params}
  72. location={router.location}
  73. dashboard={{
  74. id: 'new',
  75. title: 'Dashboard',
  76. createdBy: undefined,
  77. dateCreated: '2020-01-01T00:00:00.000Z',
  78. widgets: [],
  79. projects: [],
  80. filters: {},
  81. ...dashboard,
  82. }}
  83. onSave={onSave ?? jest.fn()}
  84. params={{
  85. orgId: organization.slug,
  86. dashboardId: dashboard?.id ?? 'new',
  87. ...params,
  88. }}
  89. />,
  90. {
  91. context: routerContext,
  92. organization,
  93. }
  94. );
  95. return {router};
  96. }
  97. describe('WidgetBuilder', function () {
  98. const untitledDashboard: DashboardDetails = {
  99. id: '1',
  100. title: 'Untitled Dashboard',
  101. createdBy: undefined,
  102. dateCreated: '2020-01-01T00:00:00.000Z',
  103. widgets: [],
  104. projects: [],
  105. filters: {},
  106. };
  107. const testDashboard: DashboardDetails = {
  108. id: '2',
  109. title: 'Test Dashboard',
  110. createdBy: undefined,
  111. dateCreated: '2020-01-01T00:00:00.000Z',
  112. widgets: [],
  113. projects: [],
  114. filters: {},
  115. };
  116. let eventsStatsMock: jest.Mock | undefined;
  117. let eventsv2Mock: jest.Mock | undefined;
  118. let eventsMock: jest.Mock | undefined;
  119. let sessionsDataMock: jest.Mock | undefined;
  120. let metricsDataMock: jest.Mock | undefined;
  121. let tagsMock: jest.Mock | undefined;
  122. let measurementsMetaMock: jest.Mock | undefined;
  123. beforeEach(function () {
  124. MockApiClient.addMockResponse({
  125. url: '/organizations/org-slug/dashboards/',
  126. body: [
  127. {...untitledDashboard, widgetDisplay: [DisplayType.TABLE]},
  128. {...testDashboard, widgetDisplay: [DisplayType.AREA]},
  129. ],
  130. });
  131. MockApiClient.addMockResponse({
  132. url: '/organizations/org-slug/dashboards/widgets/',
  133. method: 'POST',
  134. statusCode: 200,
  135. body: [],
  136. });
  137. eventsv2Mock = MockApiClient.addMockResponse({
  138. url: '/organizations/org-slug/eventsv2/',
  139. method: 'GET',
  140. statusCode: 200,
  141. body: {
  142. meta: {},
  143. data: [],
  144. },
  145. });
  146. eventsMock = MockApiClient.addMockResponse({
  147. url: '/organizations/org-slug/events/',
  148. method: 'GET',
  149. statusCode: 200,
  150. body: {
  151. meta: {fields: {}},
  152. data: [],
  153. },
  154. });
  155. MockApiClient.addMockResponse({
  156. url: '/organizations/org-slug/projects/',
  157. method: 'GET',
  158. body: [],
  159. });
  160. MockApiClient.addMockResponse({
  161. url: '/organizations/org-slug/recent-searches/',
  162. method: 'GET',
  163. body: [],
  164. });
  165. MockApiClient.addMockResponse({
  166. url: '/organizations/org-slug/recent-searches/',
  167. method: 'POST',
  168. body: [],
  169. });
  170. MockApiClient.addMockResponse({
  171. url: '/organizations/org-slug/issues/',
  172. method: 'GET',
  173. body: [],
  174. });
  175. eventsStatsMock = MockApiClient.addMockResponse({
  176. url: '/organizations/org-slug/events-stats/',
  177. body: [],
  178. });
  179. MockApiClient.addMockResponse({
  180. url: '/organizations/org-slug/tags/event.type/values/',
  181. body: [{count: 2, name: 'Nvidia 1080ti'}],
  182. });
  183. MockApiClient.addMockResponse({
  184. url: '/organizations/org-slug/events-geo/',
  185. body: {data: [], meta: {}},
  186. });
  187. MockApiClient.addMockResponse({
  188. url: '/organizations/org-slug/users/',
  189. body: [],
  190. });
  191. sessionsDataMock = MockApiClient.addMockResponse({
  192. method: 'GET',
  193. url: '/organizations/org-slug/sessions/',
  194. body: TestStubs.SessionsField({
  195. field: `sum(session)`,
  196. }),
  197. });
  198. metricsDataMock = MockApiClient.addMockResponse({
  199. method: 'GET',
  200. url: '/organizations/org-slug/metrics/data/',
  201. body: TestStubs.MetricsField({
  202. field: 'sum(sentry.sessions.session)',
  203. }),
  204. });
  205. tagsMock = MockApiClient.addMockResponse({
  206. url: '/organizations/org-slug/tags/',
  207. method: 'GET',
  208. body: TestStubs.Tags(),
  209. });
  210. measurementsMetaMock = MockApiClient.addMockResponse({
  211. url: '/organizations/org-slug/measurements-meta/',
  212. method: 'GET',
  213. body: {},
  214. });
  215. MockApiClient.addMockResponse({
  216. url: '/organizations/org-slug/tags/is/values/',
  217. method: 'GET',
  218. body: [],
  219. });
  220. TagStore.reset();
  221. });
  222. afterEach(function () {
  223. MockApiClient.clearMockResponses();
  224. jest.clearAllMocks();
  225. jest.useRealTimers();
  226. });
  227. describe('with eventsv2', function () {
  228. it('no feature access', function () {
  229. renderTestComponent({orgFeatures: []});
  230. expect(
  231. screen.getByText("You don't have access to this feature")
  232. ).toBeInTheDocument();
  233. });
  234. it('widget not found', function () {
  235. const widget: Widget = {
  236. displayType: DisplayType.AREA,
  237. interval: '1d',
  238. queries: [
  239. {
  240. name: 'Known Users',
  241. fields: [],
  242. columns: [],
  243. aggregates: [],
  244. conditions: '',
  245. orderby: '-time',
  246. },
  247. {
  248. name: 'Anonymous Users',
  249. fields: [],
  250. columns: [],
  251. aggregates: [],
  252. conditions: '',
  253. orderby: '-time',
  254. },
  255. ],
  256. title: 'Transactions',
  257. id: '1',
  258. };
  259. const dashboard = mockDashboard({widgets: [widget]});
  260. renderTestComponent({
  261. dashboard,
  262. orgFeatures: ['new-widget-builder-experience-design', 'dashboards-edit'],
  263. params: {
  264. widgetIndex: '2', // Out of bounds, only one widget
  265. },
  266. });
  267. expect(
  268. screen.getByText('The widget you want to edit was not found.')
  269. ).toBeInTheDocument();
  270. });
  271. it('renders a widget not found message if the widget index url is not an integer', function () {
  272. const widget: Widget = {
  273. displayType: DisplayType.AREA,
  274. interval: '1d',
  275. queries: [
  276. {
  277. name: 'Known Users',
  278. fields: [],
  279. columns: [],
  280. aggregates: [],
  281. conditions: '',
  282. orderby: '-time',
  283. },
  284. ],
  285. title: 'Transactions',
  286. id: '1',
  287. };
  288. const dashboard = mockDashboard({widgets: [widget]});
  289. renderTestComponent({
  290. dashboard,
  291. orgFeatures: ['new-widget-builder-experience-design', 'dashboards-edit'],
  292. params: {
  293. widgetIndex: '0.5', // Invalid index
  294. },
  295. });
  296. expect(
  297. screen.getByText('The widget you want to edit was not found.')
  298. ).toBeInTheDocument();
  299. });
  300. it('renders', async function () {
  301. renderTestComponent();
  302. // Header - Breadcrumbs
  303. expect(await screen.findByRole('link', {name: 'Dashboards'})).toHaveAttribute(
  304. 'href',
  305. '/organizations/org-slug/dashboards/'
  306. );
  307. expect(screen.getByRole('link', {name: 'Dashboard'})).toHaveAttribute(
  308. 'href',
  309. '/organizations/org-slug/dashboards/new/'
  310. );
  311. expect(screen.getByText('Widget Builder')).toBeInTheDocument();
  312. // Header - Widget Title
  313. expect(screen.getByRole('heading', {name: 'Custom Widget'})).toBeInTheDocument();
  314. // Footer - Actions
  315. expect(screen.getByLabelText('Cancel')).toBeInTheDocument();
  316. expect(screen.getByLabelText('Add Widget')).toBeInTheDocument();
  317. // Content - Step 1
  318. expect(
  319. screen.getByRole('heading', {name: 'Choose your dataset'})
  320. ).toBeInTheDocument();
  321. expect(screen.getByLabelText('Select Errors and Transactions')).toBeChecked();
  322. // Content - Step 2
  323. expect(
  324. screen.getByRole('heading', {name: 'Choose your visualization'})
  325. ).toBeInTheDocument();
  326. // Content - Step 3
  327. expect(
  328. screen.getByRole('heading', {name: 'Choose your columns'})
  329. ).toBeInTheDocument();
  330. // Content - Step 4
  331. expect(
  332. screen.getByRole('heading', {name: 'Filter your results'})
  333. ).toBeInTheDocument();
  334. // Content - Step 5
  335. expect(screen.getByRole('heading', {name: 'Sort by a column'})).toBeInTheDocument();
  336. });
  337. it('has links back to the new dashboard if creating', async function () {
  338. // Dashboard has undefined dashboardId when creating from a new dashboard
  339. // because of route setup
  340. renderTestComponent({params: {dashboardId: undefined}});
  341. expect(await screen.findByRole('link', {name: 'Dashboard'})).toHaveAttribute(
  342. 'href',
  343. '/organizations/org-slug/dashboards/new/'
  344. );
  345. expect(screen.getByLabelText('Cancel')).toHaveAttribute(
  346. 'href',
  347. '/organizations/org-slug/dashboards/new/'
  348. );
  349. });
  350. it('renders new design', async function () {
  351. renderTestComponent({
  352. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  353. });
  354. // Switch to line chart for time series
  355. userEvent.click(await screen.findByText('Table'));
  356. userEvent.click(screen.getByText('Line Chart'));
  357. // Header - Breadcrumbs
  358. expect(await screen.findByRole('link', {name: 'Dashboards'})).toHaveAttribute(
  359. 'href',
  360. '/organizations/org-slug/dashboards/'
  361. );
  362. expect(screen.getByRole('link', {name: 'Dashboard'})).toHaveAttribute(
  363. 'href',
  364. '/organizations/org-slug/dashboards/new/'
  365. );
  366. expect(screen.getByText('Widget Builder')).toBeInTheDocument();
  367. // Header - Widget Title
  368. expect(screen.getByRole('heading', {name: 'Custom Widget'})).toBeInTheDocument();
  369. // Footer - Actions
  370. expect(screen.getByLabelText('Cancel')).toBeInTheDocument();
  371. expect(screen.getByLabelText('Add Widget')).toBeInTheDocument();
  372. // Content - Step 1
  373. expect(
  374. screen.getByRole('heading', {name: 'Choose your dataset'})
  375. ).toBeInTheDocument();
  376. expect(screen.getByLabelText('Select Errors and Transactions')).toBeChecked();
  377. // Content - Step 2
  378. expect(
  379. screen.getByRole('heading', {name: 'Choose your visualization'})
  380. ).toBeInTheDocument();
  381. // Content - Step 3
  382. expect(
  383. screen.getByRole('heading', {name: 'Choose what to plot in the y-axis'})
  384. ).toBeInTheDocument();
  385. // Content - Step 4
  386. expect(
  387. screen.getByRole('heading', {name: 'Filter your results'})
  388. ).toBeInTheDocument();
  389. // Content - Step 5
  390. expect(
  391. screen.getByRole('heading', {name: 'Group your results'})
  392. ).toBeInTheDocument();
  393. });
  394. it('can update the title', async function () {
  395. renderTestComponent({
  396. query: {source: DashboardWidgetSource.DISCOVERV2},
  397. });
  398. const customWidgetLabels = await screen.findAllByText('Custom Widget');
  399. // EditableText and chart title
  400. expect(customWidgetLabels).toHaveLength(2);
  401. userEvent.click(customWidgetLabels[0]);
  402. userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
  403. userEvent.paste(
  404. screen.getByRole('textbox', {name: 'Widget title'}),
  405. 'Unique Users'
  406. );
  407. userEvent.keyboard('{enter}');
  408. expect(screen.queryByText('Custom Widget')).not.toBeInTheDocument();
  409. expect(screen.getAllByText('Unique Users')).toHaveLength(2);
  410. });
  411. it('can add query conditions', async function () {
  412. const {router} = renderTestComponent({
  413. query: {source: DashboardWidgetSource.DISCOVERV2},
  414. dashboard: testDashboard,
  415. });
  416. userEvent.type(
  417. await screen.findByRole('textbox', {name: 'Search events'}),
  418. 'color:blue{enter}'
  419. );
  420. userEvent.click(screen.getByText('Add Widget'));
  421. await waitFor(() => {
  422. expect(router.push).toHaveBeenCalledWith(
  423. expect.objectContaining({
  424. pathname: '/organizations/org-slug/dashboard/2/',
  425. query: {
  426. displayType: 'table',
  427. interval: '5m',
  428. title: 'Custom Widget',
  429. queryNames: [''],
  430. queryConditions: ['color:blue'],
  431. queryFields: ['count()'],
  432. queryOrderby: '-count()',
  433. start: null,
  434. end: null,
  435. statsPeriod: '24h',
  436. utc: null,
  437. project: [],
  438. environment: [],
  439. },
  440. })
  441. );
  442. });
  443. });
  444. it('can choose a field', async function () {
  445. const {router} = renderTestComponent({
  446. query: {source: DashboardWidgetSource.DISCOVERV2},
  447. dashboard: testDashboard,
  448. });
  449. expect(await screen.findAllByText('Custom Widget')).toHaveLength(2);
  450. // No delete button as there is only one query.
  451. expect(screen.queryByLabelText('Remove query')).not.toBeInTheDocument();
  452. // 1 in the table header, 1 in the column selector, 1 in the sort field
  453. const countFields = screen.getAllByText('count()');
  454. expect(countFields).toHaveLength(3);
  455. await selectEvent.select(countFields[1], ['last_seen()']);
  456. userEvent.click(screen.getByText('Add Widget'));
  457. await waitFor(() => {
  458. expect(router.push).toHaveBeenCalledWith(
  459. expect.objectContaining({
  460. pathname: '/organizations/org-slug/dashboard/2/',
  461. query: {
  462. displayType: 'table',
  463. interval: '5m',
  464. title: 'Custom Widget',
  465. queryNames: [''],
  466. queryConditions: [''],
  467. queryFields: ['last_seen()'],
  468. queryOrderby: '-last_seen()',
  469. start: null,
  470. end: null,
  471. statsPeriod: '24h',
  472. utc: null,
  473. project: [],
  474. environment: [],
  475. },
  476. })
  477. );
  478. });
  479. });
  480. it('can add additional fields', async function () {
  481. const handleSave = jest.fn();
  482. renderTestComponent({onSave: handleSave});
  483. userEvent.click(await screen.findByText('Table'));
  484. // Select line chart display
  485. userEvent.click(screen.getByText('Line Chart'));
  486. // Click the add overlay button
  487. userEvent.click(screen.getByLabelText('Add Overlay'));
  488. await selectEvent.select(screen.getByText('(Required)'), ['count_unique(…)']);
  489. userEvent.click(screen.getByLabelText('Add Widget'));
  490. await waitFor(() => {
  491. expect(handleSave).toHaveBeenCalledWith([
  492. expect.objectContaining({
  493. title: 'Custom Widget',
  494. displayType: DisplayType.LINE,
  495. interval: '5m',
  496. widgetType: WidgetType.DISCOVER,
  497. queries: [
  498. {
  499. conditions: '',
  500. fields: ['count()', 'count_unique(user)'],
  501. aggregates: ['count()', 'count_unique(user)'],
  502. fieldAliases: [],
  503. columns: [],
  504. orderby: '',
  505. name: '',
  506. },
  507. ],
  508. }),
  509. ]);
  510. });
  511. expect(handleSave).toHaveBeenCalledTimes(1);
  512. });
  513. it('can add equation fields', async function () {
  514. const handleSave = jest.fn();
  515. renderTestComponent({onSave: handleSave});
  516. userEvent.click(await screen.findByText('Table'));
  517. // Select line chart display
  518. userEvent.click(screen.getByText('Line Chart'));
  519. // Click the add an equation button
  520. userEvent.click(screen.getByLabelText('Add an Equation'));
  521. expect(screen.getByPlaceholderText('Equation')).toBeInTheDocument();
  522. userEvent.paste(screen.getByPlaceholderText('Equation'), 'count() + 100');
  523. userEvent.click(screen.getByLabelText('Add Widget'));
  524. await waitFor(() => {
  525. expect(handleSave).toHaveBeenCalledWith([
  526. expect.objectContaining({
  527. title: 'Custom Widget',
  528. displayType: DisplayType.LINE,
  529. interval: '5m',
  530. widgetType: WidgetType.DISCOVER,
  531. queries: [
  532. {
  533. name: '',
  534. fields: ['count()', 'equation|count() + 100'],
  535. aggregates: ['count()', 'equation|count() + 100'],
  536. columns: [],
  537. fieldAliases: [],
  538. conditions: '',
  539. orderby: '',
  540. },
  541. ],
  542. }),
  543. ]);
  544. });
  545. expect(handleSave).toHaveBeenCalledTimes(1);
  546. });
  547. it('can respond to validation feedback', async function () {
  548. jest.spyOn(indicators, 'addErrorMessage');
  549. renderTestComponent();
  550. userEvent.click(await screen.findByText('Table'));
  551. const customWidgetLabels = await screen.findAllByText('Custom Widget');
  552. // EditableText and chart title
  553. expect(customWidgetLabels).toHaveLength(2);
  554. userEvent.click(customWidgetLabels[0]);
  555. userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
  556. userEvent.keyboard('{enter}');
  557. expect(indicators.addErrorMessage).toHaveBeenCalledWith('Widget title is required');
  558. });
  559. it('sets up widget data in edit correctly', async function () {
  560. const widget: Widget = {
  561. id: '1',
  562. title: 'Errors over time',
  563. interval: '5m',
  564. displayType: DisplayType.LINE,
  565. queries: [
  566. {
  567. name: 'errors',
  568. conditions: 'event.type:error',
  569. fields: ['count()', 'count_unique(id)'],
  570. aggregates: ['count()', 'count_unique(id)'],
  571. columns: [],
  572. orderby: '',
  573. },
  574. {
  575. name: 'csp',
  576. conditions: 'event.type:csp',
  577. fields: ['count()', 'count_unique(id)'],
  578. aggregates: ['count()', 'count_unique(id)'],
  579. columns: [],
  580. orderby: '',
  581. },
  582. ],
  583. };
  584. const dashboard = mockDashboard({widgets: [widget]});
  585. renderTestComponent({dashboard, params: {widgetIndex: '0'}});
  586. await screen.findByText('Line Chart');
  587. // Should be in edit 'mode'
  588. expect(await screen.findByText('Update Widget')).toBeInTheDocument();
  589. // Should set widget data up.
  590. expect(screen.getByText('Update Widget')).toBeInTheDocument();
  591. // Filters
  592. expect(
  593. screen.getAllByPlaceholderText('Search for events, users, tags, and more')
  594. ).toHaveLength(2);
  595. expect(screen.getByText('event.type:csp')).toBeInTheDocument();
  596. expect(screen.getByText('event.type:error')).toBeInTheDocument();
  597. // Y-axis
  598. expect(screen.getAllByRole('button', {name: 'Remove query'})).toHaveLength(2);
  599. expect(screen.getByText('count()')).toBeInTheDocument();
  600. expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
  601. expect(screen.getByText('id')).toBeInTheDocument();
  602. // Expect events-stats endpoint to be called for each search conditions with
  603. // the same y-axis parameters
  604. expect(eventsStatsMock).toHaveBeenNthCalledWith(
  605. 1,
  606. '/organizations/org-slug/events-stats/',
  607. expect.objectContaining({
  608. query: expect.objectContaining({
  609. query: 'event.type:error',
  610. yAxis: ['count()', 'count_unique(id)'],
  611. }),
  612. })
  613. );
  614. expect(eventsStatsMock).toHaveBeenNthCalledWith(
  615. 2,
  616. '/organizations/org-slug/events-stats/',
  617. expect.objectContaining({
  618. query: expect.objectContaining({
  619. query: 'event.type:csp',
  620. yAxis: ['count()', 'count_unique(id)'],
  621. }),
  622. })
  623. );
  624. });
  625. it('can edit a widget', async function () {
  626. const widget: Widget = {
  627. id: '1',
  628. title: 'Errors over time',
  629. interval: '5m',
  630. displayType: DisplayType.LINE,
  631. queries: [
  632. {
  633. name: 'errors',
  634. conditions: 'event.type:error',
  635. fields: ['count()', 'count_unique(id)'],
  636. aggregates: ['count()', 'count_unique(id)'],
  637. columns: [],
  638. orderby: '',
  639. },
  640. {
  641. name: 'csp',
  642. conditions: 'event.type:csp',
  643. fields: ['count()', 'count_unique(id)'],
  644. aggregates: ['count()', 'count_unique(id)'],
  645. columns: [],
  646. orderby: '',
  647. },
  648. ],
  649. };
  650. const dashboard = mockDashboard({widgets: [widget]});
  651. const handleSave = jest.fn();
  652. renderTestComponent({onSave: handleSave, dashboard, params: {widgetIndex: '0'}});
  653. await screen.findByText('Line Chart');
  654. // Should be in edit 'mode'
  655. expect(await screen.findByText('Update Widget')).toBeInTheDocument();
  656. const customWidgetLabels = await screen.findAllByText(widget.title);
  657. // EditableText and chart title
  658. expect(customWidgetLabels).toHaveLength(2);
  659. userEvent.click(customWidgetLabels[0]);
  660. userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
  661. userEvent.paste(screen.getByRole('textbox', {name: 'Widget title'}), 'New Title');
  662. userEvent.click(screen.getByRole('button', {name: 'Update Widget'}));
  663. await waitFor(() => {
  664. expect(handleSave).toHaveBeenCalledWith([
  665. expect.objectContaining({
  666. ...widget,
  667. title: 'New Title',
  668. }),
  669. ]);
  670. });
  671. expect(handleSave).toHaveBeenCalledTimes(1);
  672. });
  673. it('renders column inputs for table widgets', async function () {
  674. const widget: Widget = {
  675. id: '0',
  676. title: 'sdk usage',
  677. interval: '5m',
  678. displayType: DisplayType.TABLE,
  679. queries: [
  680. {
  681. name: 'errors',
  682. conditions: 'event.type:error',
  683. fields: ['sdk.name', 'count()'],
  684. columns: ['sdk.name'],
  685. aggregates: ['count()'],
  686. orderby: '',
  687. },
  688. ],
  689. };
  690. const dashboard = mockDashboard({widgets: [widget]});
  691. renderTestComponent({dashboard, params: {widgetIndex: '0'}});
  692. // Should be in edit 'mode'
  693. expect(await screen.findByText('Update Widget')).toBeInTheDocument();
  694. // Should set widget data up.
  695. expect(screen.getByRole('heading', {name: widget.title})).toBeInTheDocument();
  696. expect(screen.getByText('Table')).toBeInTheDocument();
  697. expect(screen.getByLabelText('Search events')).toBeInTheDocument();
  698. // Should have an orderby select
  699. expect(screen.getByText('Sort by a column')).toBeInTheDocument();
  700. // Add a column, and choose a value,
  701. expect(screen.getByLabelText('Add a Column')).toBeInTheDocument();
  702. });
  703. it('can save table widgets', async function () {
  704. const widget: Widget = {
  705. id: '0',
  706. title: 'sdk usage',
  707. interval: '5m',
  708. displayType: DisplayType.TABLE,
  709. queries: [
  710. {
  711. name: 'errors',
  712. conditions: 'event.type:error',
  713. fields: ['sdk.name', 'count()'],
  714. columns: ['sdk.name'],
  715. aggregates: ['count()'],
  716. orderby: '-count()',
  717. },
  718. ],
  719. };
  720. const dashboard = mockDashboard({widgets: [widget]});
  721. const handleSave = jest.fn();
  722. renderTestComponent({dashboard, onSave: handleSave, params: {widgetIndex: '0'}});
  723. // Should be in edit 'mode'
  724. expect(await screen.findByText('Update Widget')).toBeInTheDocument();
  725. // Add a column, and choose a value,
  726. userEvent.click(screen.getByLabelText('Add a Column'));
  727. await selectEvent.select(screen.getByText('(Required)'), 'trace');
  728. // Save widget
  729. userEvent.click(screen.getByLabelText('Update Widget'));
  730. await waitFor(() => {
  731. expect(handleSave).toHaveBeenCalledWith([
  732. expect.objectContaining({
  733. id: '0',
  734. title: 'sdk usage',
  735. displayType: DisplayType.TABLE,
  736. interval: '5m',
  737. queries: [
  738. {
  739. name: 'errors',
  740. conditions: 'event.type:error',
  741. fields: ['sdk.name', 'count()', 'trace'],
  742. aggregates: ['count()'],
  743. columns: ['sdk.name', 'trace'],
  744. orderby: '-count()',
  745. fieldAliases: ['', '', ''],
  746. },
  747. ],
  748. widgetType: WidgetType.DISCOVER,
  749. }),
  750. ]);
  751. });
  752. expect(handleSave).toHaveBeenCalledTimes(1);
  753. });
  754. it('should properly query for table fields', async function () {
  755. const defaultWidgetQuery = {
  756. name: '',
  757. fields: ['title', 'count()'],
  758. columns: ['title'],
  759. aggregates: ['count()'],
  760. conditions: '',
  761. orderby: '',
  762. };
  763. const defaultTableColumns = ['title', 'count()', 'count_unique(user)', 'epm()'];
  764. renderTestComponent({
  765. query: {
  766. source: DashboardWidgetSource.DISCOVERV2,
  767. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  768. displayType: DisplayType.LINE,
  769. defaultTableColumns,
  770. },
  771. });
  772. expect(await screen.findByText('Line Chart')).toBeInTheDocument();
  773. userEvent.click(screen.getByText('Line Chart'));
  774. userEvent.click(screen.getByText('Table'));
  775. await waitFor(() => {
  776. expect(eventsv2Mock).toHaveBeenLastCalledWith(
  777. '/organizations/org-slug/eventsv2/',
  778. expect.objectContaining({
  779. query: expect.objectContaining({
  780. field: defaultTableColumns,
  781. }),
  782. })
  783. );
  784. });
  785. });
  786. it('should use defaultWidgetQuery Y-Axis and Conditions if given a defaultWidgetQuery', async function () {
  787. const defaultWidgetQuery = {
  788. name: '',
  789. fields: ['count()', 'failure_count()', 'count_unique(user)'],
  790. columns: [],
  791. aggregates: ['count()', 'failure_count()', 'count_unique(user)'],
  792. conditions: 'tag:value',
  793. orderby: '',
  794. };
  795. renderTestComponent({
  796. query: {
  797. source: DashboardWidgetSource.DISCOVERV2,
  798. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  799. },
  800. });
  801. expect(await screen.findByText('tag:value')).toBeInTheDocument();
  802. // Table display, column, and sort field
  803. expect(screen.getAllByText('count()')).toHaveLength(3);
  804. // Table display and column
  805. expect(screen.getAllByText('failure_count()')).toHaveLength(2);
  806. // Table display
  807. expect(screen.getByText('count_unique(user)')).toBeInTheDocument();
  808. // Column
  809. expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
  810. // Column
  811. expect(screen.getByText('user')).toBeInTheDocument();
  812. });
  813. it('uses displayType if given a displayType', async function () {
  814. renderTestComponent({
  815. query: {
  816. displayType: DisplayType.BAR,
  817. },
  818. });
  819. expect(await screen.findByText('Bar Chart')).toBeInTheDocument();
  820. });
  821. it('deletes the widget when the modal is confirmed', async () => {
  822. const handleSave = jest.fn();
  823. const widget: Widget = {
  824. id: '1',
  825. title: 'Errors over time',
  826. interval: '5m',
  827. displayType: DisplayType.LINE,
  828. queries: [
  829. {
  830. name: 'errors',
  831. conditions: 'event.type:error',
  832. fields: ['count()', 'count_unique(id)'],
  833. aggregates: ['count()', 'count_unique(id)'],
  834. columns: [],
  835. orderby: '',
  836. },
  837. {
  838. name: 'csp',
  839. conditions: 'event.type:csp',
  840. fields: ['count()', 'count_unique(id)'],
  841. aggregates: ['count()', 'count_unique(id)'],
  842. columns: [],
  843. orderby: '',
  844. },
  845. ],
  846. };
  847. const dashboard = mockDashboard({widgets: [widget]});
  848. renderTestComponent({onSave: handleSave, dashboard, params: {widgetIndex: '0'}});
  849. userEvent.click(await screen.findByText('Delete'));
  850. await mountGlobalModal();
  851. userEvent.click(await screen.findByText('Confirm'));
  852. await waitFor(() => {
  853. // The only widget was deleted
  854. expect(handleSave).toHaveBeenCalledWith([]);
  855. });
  856. expect(handleSave).toHaveBeenCalledTimes(1);
  857. });
  858. it('persists the page filter period when updating a widget', async () => {
  859. const widget: Widget = {
  860. id: '1',
  861. title: 'Errors over time',
  862. interval: '5m',
  863. displayType: DisplayType.LINE,
  864. queries: [
  865. {
  866. name: 'errors',
  867. conditions: 'event.type:error',
  868. fields: ['count()', 'count_unique(id)'],
  869. aggregates: ['count()', 'count_unique(id)'],
  870. columns: [],
  871. orderby: '',
  872. },
  873. ],
  874. };
  875. const dashboard = mockDashboard({widgets: [widget]});
  876. const {router} = renderTestComponent({
  877. dashboard,
  878. params: {orgId: 'org-slug', widgetIndex: '0'},
  879. query: {statsPeriod: '90d'},
  880. });
  881. await screen.findByText('Update Widget');
  882. await screen.findByText('90D');
  883. expect(screen.getByTestId('page-filter-timerange-selector')).toBeEnabled();
  884. userEvent.click(screen.getByText('Update Widget'));
  885. await waitFor(() => {
  886. expect(router.push).toHaveBeenLastCalledWith(
  887. expect.objectContaining({
  888. pathname: '/organizations/org-slug/dashboard/1/',
  889. query: expect.objectContaining({
  890. statsPeriod: '90d',
  891. }),
  892. })
  893. );
  894. });
  895. });
  896. it('renders page filters in the filter step', async () => {
  897. const mockReleases = MockApiClient.addMockResponse({
  898. url: '/organizations/org-slug/releases/',
  899. body: [TestStubs.Release()],
  900. });
  901. renderTestComponent({
  902. params: {orgId: 'org-slug'},
  903. query: {statsPeriod: '90d'},
  904. orgFeatures: [...defaultOrgFeatures, 'dashboards-top-level-filter'],
  905. });
  906. await screen.findByText('90D');
  907. expect(screen.getByTestId('page-filter-timerange-selector')).toBeDisabled();
  908. expect(screen.getByTestId('page-filter-environment-selector')).toBeDisabled();
  909. expect(screen.getByTestId('page-filter-project-selector-loading')).toBeDisabled();
  910. await waitFor(() => {
  911. expect(mockReleases).toHaveBeenCalled();
  912. });
  913. expect(screen.getByRole('button', {name: /all releases/i})).toBeDisabled();
  914. });
  915. it('appends dashboard filters to widget builder fetch data request', async () => {
  916. MockApiClient.addMockResponse({
  917. url: '/organizations/org-slug/releases/',
  918. body: [TestStubs.Release()],
  919. });
  920. const mock = MockApiClient.addMockResponse({
  921. url: '/organizations/org-slug/eventsv2/',
  922. body: [],
  923. });
  924. renderTestComponent({
  925. dashboard: {
  926. id: 'new',
  927. title: 'Dashboard',
  928. createdBy: undefined,
  929. dateCreated: '2020-01-01T00:00:00.000Z',
  930. widgets: [],
  931. projects: [],
  932. filters: {release: ['abc@1.2.0']},
  933. },
  934. params: {orgId: 'org-slug'},
  935. query: {statsPeriod: '90d'},
  936. orgFeatures: [...defaultOrgFeatures, 'dashboards-top-level-filter'],
  937. });
  938. await waitFor(() => {
  939. expect(mock).toHaveBeenCalledWith(
  940. '/organizations/org-slug/eventsv2/',
  941. expect.objectContaining({
  942. query: expect.objectContaining({
  943. query: ' release:abc@1.2.0 ',
  944. }),
  945. })
  946. );
  947. });
  948. });
  949. it('does not error when query conditions field is blurred', async function () {
  950. jest.useFakeTimers();
  951. const widget: Widget = {
  952. id: '0',
  953. title: 'sdk usage',
  954. interval: '5m',
  955. displayType: DisplayType.BAR,
  956. queries: [
  957. {
  958. name: 'filled in',
  959. conditions: 'event.type:error',
  960. fields: ['count()', 'count_unique(id)'],
  961. aggregates: ['count()', 'count_unique(id)'],
  962. columns: [],
  963. orderby: '-count()',
  964. },
  965. ],
  966. };
  967. const dashboard = mockDashboard({widgets: [widget]});
  968. const handleSave = jest.fn();
  969. renderTestComponent({dashboard, onSave: handleSave, params: {widgetIndex: '0'}});
  970. userEvent.click(await screen.findByLabelText('Add Query'));
  971. // Triggering the onBlur of the new field should not error
  972. userEvent.click(
  973. screen.getAllByPlaceholderText('Search for events, users, tags, and more')[1]
  974. );
  975. userEvent.keyboard('{esc}');
  976. act(() => {
  977. // Run all timers because the handleBlur contains a setTimeout
  978. jest.runAllTimers();
  979. });
  980. });
  981. it('does not wipe column changes when filters are modified', async function () {
  982. jest.useFakeTimers();
  983. // widgetIndex: undefined means creating a new widget
  984. renderTestComponent({params: {widgetIndex: undefined}});
  985. userEvent.click(await screen.findByLabelText('Add a Column'));
  986. await selectEvent.select(screen.getByText('(Required)'), /project/);
  987. // Triggering the onBlur of the filter should not error
  988. userEvent.click(
  989. screen.getByPlaceholderText('Search for events, users, tags, and more')
  990. );
  991. userEvent.keyboard('{enter}');
  992. act(() => {
  993. // Run all timers because the handleBlur contains a setTimeout
  994. jest.runAllTimers();
  995. });
  996. expect(await screen.findAllByText('project')).toHaveLength(2);
  997. });
  998. it('renders fields with commas properly', async () => {
  999. const defaultWidgetQuery = {
  1000. conditions: '',
  1001. fields: ['equation|count_if(transaction.duration,equals,300)*2'],
  1002. aggregates: ['equation|count_if(transaction.duration,equals,300)*2'],
  1003. columns: [],
  1004. orderby: '',
  1005. name: '',
  1006. };
  1007. const defaultTableColumns = [
  1008. 'count_if(transaction.duration,equals,300)',
  1009. 'equation|count_if(transaction.duration,equals,300)*2',
  1010. ];
  1011. renderTestComponent({
  1012. query: {
  1013. source: DashboardWidgetSource.DISCOVERV2,
  1014. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  1015. defaultTableColumns,
  1016. yAxis: ['equation|count_if(transaction.duration,equals,300)*2'],
  1017. },
  1018. });
  1019. expect(
  1020. await screen.findByText('count_if(transaction.duration,equals,300)*2')
  1021. ).toBeInTheDocument();
  1022. });
  1023. it('sets the correct fields for a top n widget', async () => {
  1024. renderTestComponent({
  1025. orgFeatures: [...defaultOrgFeatures, 'performance-view'],
  1026. query: {
  1027. displayType: DisplayType.TOP_N,
  1028. },
  1029. });
  1030. // Top N now opens as Area Chart
  1031. await screen.findByText('Area Chart');
  1032. // Add a group by
  1033. userEvent.click(screen.getByText('Add Overlay'));
  1034. await selectEvent.select(screen.getByText('Select group'), /project/);
  1035. // Change the y-axis
  1036. await selectEvent.select(screen.getAllByText('count()')[0], 'eps()');
  1037. await waitFor(() => {
  1038. expect(eventsStatsMock).toHaveBeenLastCalledWith(
  1039. '/organizations/org-slug/events-stats/',
  1040. expect.objectContaining({
  1041. query: expect.objectContaining({
  1042. query: '',
  1043. yAxis: ['eps()'],
  1044. field: ['project', 'eps()'],
  1045. topEvents: TOP_N,
  1046. orderby: '-eps()',
  1047. }),
  1048. })
  1049. );
  1050. });
  1051. });
  1052. it('fetches tags when tag store is empty', function () {
  1053. renderTestComponent();
  1054. expect(tagsMock).toHaveBeenCalled();
  1055. });
  1056. it('does not fetch tags when tag store is not empty', function () {
  1057. TagStore.loadTagsSuccess(TestStubs.Tags());
  1058. renderTestComponent();
  1059. expect(tagsMock).not.toHaveBeenCalled();
  1060. });
  1061. it('excludes the Other series when grouping and using multiple y-axes', async function () {
  1062. renderTestComponent({
  1063. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1064. query: {
  1065. displayType: DisplayType.LINE,
  1066. },
  1067. });
  1068. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1069. userEvent.click(screen.getByText('Add Overlay'));
  1070. await selectEvent.select(screen.getByText('(Required)'), /count_unique/);
  1071. await waitFor(() => {
  1072. expect(eventsStatsMock).toBeCalledWith(
  1073. '/organizations/org-slug/events-stats/',
  1074. expect.objectContaining({
  1075. query: expect.objectContaining({excludeOther: '1'}),
  1076. })
  1077. );
  1078. });
  1079. });
  1080. it('excludes the Other series when grouping and using multiple queries', async function () {
  1081. renderTestComponent({
  1082. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1083. query: {
  1084. displayType: DisplayType.LINE,
  1085. },
  1086. });
  1087. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1088. userEvent.click(screen.getByText('Add Query'));
  1089. await waitFor(() => {
  1090. expect(eventsStatsMock).toBeCalledWith(
  1091. '/organizations/org-slug/events-stats/',
  1092. expect.objectContaining({
  1093. query: expect.objectContaining({excludeOther: '1'}),
  1094. })
  1095. );
  1096. });
  1097. });
  1098. it('includes Other series when there is only one query and one y-axis', async function () {
  1099. renderTestComponent({
  1100. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1101. query: {
  1102. displayType: DisplayType.LINE,
  1103. },
  1104. });
  1105. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1106. await waitFor(() => {
  1107. expect(eventsStatsMock).toBeCalledWith(
  1108. '/organizations/org-slug/events-stats/',
  1109. expect.objectContaining({
  1110. query: expect.not.objectContaining({excludeOther: '1'}),
  1111. })
  1112. );
  1113. });
  1114. });
  1115. it('decreases the limit when more y-axes and queries are added', async function () {
  1116. renderTestComponent({
  1117. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1118. query: {
  1119. displayType: DisplayType.LINE,
  1120. },
  1121. });
  1122. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1123. screen.getByText('Limit to 5 results');
  1124. userEvent.click(screen.getByText('Add Query'));
  1125. userEvent.click(screen.getByText('Add Overlay'));
  1126. await screen.findByText('Limit to 2 results');
  1127. });
  1128. it('alerts the user if there are unsaved changes', async function () {
  1129. const {router} = renderTestComponent();
  1130. const alertMock = jest.fn();
  1131. const setRouteLeaveHookMock = jest.spyOn(router, 'setRouteLeaveHook');
  1132. setRouteLeaveHookMock.mockImplementationOnce((_route, _callback) => {
  1133. alertMock();
  1134. });
  1135. const customWidgetLabels = await screen.findAllByText('Custom Widget');
  1136. // EditableText and chart title
  1137. expect(customWidgetLabels).toHaveLength(2);
  1138. // Change title text
  1139. userEvent.click(customWidgetLabels[0]);
  1140. userEvent.clear(screen.getByRole('textbox', {name: 'Widget title'}));
  1141. userEvent.paste(
  1142. screen.getByRole('textbox', {name: 'Widget title'}),
  1143. 'Unique Users'
  1144. );
  1145. userEvent.keyboard('{enter}');
  1146. // Click Cancel
  1147. userEvent.click(screen.getByText('Cancel'));
  1148. // Assert an alert was triggered
  1149. expect(alertMock).toHaveBeenCalled();
  1150. });
  1151. it('does not trigger alert dialog if no changes', async function () {
  1152. const {router} = renderTestComponent();
  1153. const alertMock = jest.fn();
  1154. const setRouteLeaveHookMock = jest.spyOn(router, 'setRouteLeaveHook');
  1155. setRouteLeaveHookMock.mockImplementationOnce((_route, _callback) => {
  1156. alertMock();
  1157. });
  1158. await screen.findAllByText('Custom Widget');
  1159. // Click Cancel
  1160. userEvent.click(screen.getByText('Cancel'));
  1161. // Assert an alert was triggered
  1162. expect(alertMock).not.toHaveBeenCalled();
  1163. });
  1164. describe('Sort by selectors', function () {
  1165. it('renders', async function () {
  1166. renderTestComponent({
  1167. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1168. });
  1169. expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
  1170. expect(
  1171. screen.getByText("Choose one of the columns you've created to sort by.")
  1172. ).toBeInTheDocument();
  1173. // Selector "sortDirection"
  1174. expect(screen.getByText('High to low')).toBeInTheDocument();
  1175. // Selector "sortBy"
  1176. expect(screen.getAllByText('count()')).toHaveLength(3);
  1177. });
  1178. it('ordering by column uses field form when selecting orderby', async function () {
  1179. const widget: Widget = {
  1180. id: '1',
  1181. title: 'Test Widget',
  1182. interval: '5m',
  1183. displayType: DisplayType.TABLE,
  1184. queries: [
  1185. {
  1186. name: 'errors',
  1187. conditions: 'event.type:error',
  1188. fields: ['count()'],
  1189. aggregates: ['count()'],
  1190. columns: ['project'],
  1191. orderby: '-project',
  1192. },
  1193. ],
  1194. };
  1195. const dashboard = mockDashboard({widgets: [widget]});
  1196. renderTestComponent({
  1197. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1198. dashboard,
  1199. params: {
  1200. widgetIndex: '0',
  1201. },
  1202. });
  1203. await waitFor(async () => {
  1204. expect(await screen.findAllByText('project')).toHaveLength(3);
  1205. });
  1206. await selectEvent.select(screen.getAllByText('project')[2], 'count()');
  1207. await waitFor(() => {
  1208. expect(eventsv2Mock).toHaveBeenCalledWith(
  1209. '/organizations/org-slug/eventsv2/',
  1210. expect.objectContaining({
  1211. query: expect.objectContaining({
  1212. sort: ['-count()'],
  1213. }),
  1214. })
  1215. );
  1216. });
  1217. });
  1218. it('sortBy defaults to the first field value when changing display type to table', async function () {
  1219. const widget: Widget = {
  1220. id: '1',
  1221. title: 'Errors over time',
  1222. interval: '5m',
  1223. displayType: DisplayType.LINE,
  1224. queries: [
  1225. {
  1226. name: 'errors',
  1227. conditions: 'event.type:error',
  1228. fields: ['count()', 'count_unique(id)'],
  1229. aggregates: ['count()', 'count_unique(id)'],
  1230. columns: [],
  1231. orderby: '',
  1232. },
  1233. {
  1234. name: 'csp',
  1235. conditions: 'event.type:csp',
  1236. fields: ['count()', 'count_unique(id)'],
  1237. aggregates: ['count()', 'count_unique(id)'],
  1238. columns: [],
  1239. orderby: '',
  1240. },
  1241. ],
  1242. };
  1243. const dashboard = mockDashboard({widgets: [widget]});
  1244. renderTestComponent({
  1245. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1246. dashboard,
  1247. params: {
  1248. widgetIndex: '0',
  1249. },
  1250. });
  1251. // Click on the displayType selector
  1252. userEvent.click(await screen.findByText('Line Chart'));
  1253. // Choose the table visualization
  1254. userEvent.click(screen.getByText('Table'));
  1255. expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
  1256. // Selector "sortDirection"
  1257. expect(screen.getByText('High to low')).toBeInTheDocument();
  1258. // Selector "sortBy"
  1259. expect(screen.getAllByText('count()')).toHaveLength(3);
  1260. });
  1261. it('can update selectors values', async function () {
  1262. const handleSave = jest.fn();
  1263. const widget: Widget = {
  1264. id: '1',
  1265. title: 'Errors over time',
  1266. interval: '5m',
  1267. displayType: DisplayType.TABLE,
  1268. queries: [
  1269. {
  1270. name: '',
  1271. conditions: '',
  1272. fields: ['count()', 'count_unique(id)'],
  1273. aggregates: ['count()', 'count_unique(id)'],
  1274. columns: [],
  1275. orderby: '-count()',
  1276. },
  1277. ],
  1278. };
  1279. const dashboard = mockDashboard({widgets: [widget]});
  1280. renderTestComponent({
  1281. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1282. dashboard,
  1283. onSave: handleSave,
  1284. params: {
  1285. widgetIndex: '0',
  1286. },
  1287. });
  1288. expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
  1289. // Selector "sortDirection"
  1290. expect(screen.getByText('High to low')).toBeInTheDocument();
  1291. // Selector "sortBy"
  1292. expect(screen.getAllByText('count()')).toHaveLength(3);
  1293. await selectEvent.select(screen.getAllByText('count()')[2], 'count_unique(id)');
  1294. // Wait for the Builder update the widget values
  1295. await waitFor(() => {
  1296. expect(screen.getAllByText('count()')).toHaveLength(2);
  1297. });
  1298. // Now count_unique(id) is selected in the "sortBy" selector
  1299. expect(screen.getAllByText('count_unique(id)')).toHaveLength(2);
  1300. await selectEvent.select(screen.getByText('High to low'), 'Low to high');
  1301. // Saves the widget
  1302. userEvent.click(screen.getByText('Update Widget'));
  1303. await waitFor(() => {
  1304. expect(handleSave).toHaveBeenCalledWith([
  1305. expect.objectContaining({
  1306. queries: [expect.objectContaining({orderby: 'count_unique(id)'})],
  1307. }),
  1308. ]);
  1309. });
  1310. });
  1311. it('sortBy defaults to the first field value when coming from discover', async function () {
  1312. const defaultWidgetQuery = {
  1313. name: '',
  1314. fields: ['title', 'count()', 'count_unique(user)', 'epm()', 'count()'],
  1315. columns: ['title'],
  1316. aggregates: ['count()', 'count_unique(user)', 'epm()', 'count()'],
  1317. conditions: 'tag:value',
  1318. orderby: '',
  1319. };
  1320. const {router} = renderTestComponent({
  1321. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1322. query: {
  1323. source: DashboardWidgetSource.DISCOVERV2,
  1324. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  1325. displayType: DisplayType.TABLE,
  1326. defaultTableColumns: ['title', 'count()', 'count_unique(user)', 'epm()'],
  1327. },
  1328. });
  1329. expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
  1330. // Selector "sortDirection"
  1331. expect(screen.getByText('Low to high')).toBeInTheDocument();
  1332. // Selector "sortBy"
  1333. expect(screen.getAllByText('title')).toHaveLength(2);
  1334. // Saves the widget
  1335. userEvent.click(screen.getByText('Add Widget'));
  1336. await waitFor(() => {
  1337. expect(router.push).toHaveBeenCalledWith(
  1338. expect.objectContaining({
  1339. query: expect.objectContaining({queryOrderby: 'count()'}),
  1340. })
  1341. );
  1342. });
  1343. });
  1344. it('sortBy is only visible on tabular visualizations or when there is a groupBy value selected on time-series visualizations', async function () {
  1345. renderTestComponent({
  1346. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1347. });
  1348. // Sort by shall be visible on table visualization
  1349. expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
  1350. // Update visualization to be a time-series
  1351. userEvent.click(screen.getByText('Table'));
  1352. userEvent.click(screen.getByText('Line Chart'));
  1353. // Time-series visualizations display GroupBy step
  1354. expect(await screen.findByText('Group your results')).toBeInTheDocument();
  1355. // Do not show sortBy when empty columns (groupBys) are added
  1356. userEvent.click(screen.getByText('Add Group'));
  1357. expect(screen.getAllByText('Select group')).toHaveLength(2);
  1358. // SortBy step shall not be visible
  1359. expect(screen.queryByText('Sort by a y-axis')).not.toBeInTheDocument();
  1360. // Select GroupBy value
  1361. await selectEvent.select(screen.getAllByText('Select group')[0], 'project');
  1362. // Now that at least one groupBy value is selected, the SortBy step shall be visible
  1363. expect(screen.getByText('Sort by a y-axis')).toBeInTheDocument();
  1364. // Remove selected GroupBy value
  1365. userEvent.click(screen.getAllByLabelText('Remove group')[0]);
  1366. // SortBy step shall no longer be visible
  1367. expect(screen.queryByText('Sort by a y-axis')).not.toBeInTheDocument();
  1368. });
  1369. it('allows for sorting by a custom equation', async function () {
  1370. renderTestComponent({
  1371. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1372. query: {
  1373. source: DashboardWidgetSource.DASHBOARDS,
  1374. displayType: DisplayType.LINE,
  1375. },
  1376. });
  1377. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1378. expect(screen.getAllByText('count()')).toHaveLength(2);
  1379. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  1380. userEvent.paste(
  1381. screen.getByPlaceholderText('Enter Equation'),
  1382. 'count_unique(user) * 2'
  1383. );
  1384. userEvent.keyboard('{enter}');
  1385. await waitFor(() => {
  1386. expect(eventsStatsMock).toHaveBeenCalledWith(
  1387. '/organizations/org-slug/events-stats/',
  1388. expect.objectContaining({
  1389. query: expect.objectContaining({
  1390. field: expect.arrayContaining(['equation|count_unique(user) * 2']),
  1391. orderby: '-equation[0]',
  1392. }),
  1393. })
  1394. );
  1395. });
  1396. }, 10000);
  1397. it('persists the state when toggling between sorting options', async function () {
  1398. renderTestComponent({
  1399. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1400. query: {
  1401. source: DashboardWidgetSource.DASHBOARDS,
  1402. displayType: DisplayType.LINE,
  1403. },
  1404. });
  1405. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1406. expect(screen.getAllByText('count()')).toHaveLength(2);
  1407. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  1408. userEvent.paste(
  1409. screen.getByPlaceholderText('Enter Equation'),
  1410. 'count_unique(user) * 2'
  1411. );
  1412. userEvent.keyboard('{enter}');
  1413. // Switch away from the Custom Equation
  1414. expect(screen.getByText('project')).toBeInTheDocument();
  1415. await selectEvent.select(screen.getByText('Custom Equation'), 'project');
  1416. expect(screen.getAllByText('project')).toHaveLength(2);
  1417. // Switch back, the equation should still be visible
  1418. await selectEvent.select(screen.getAllByText('project')[1], 'Custom Equation');
  1419. expect(screen.getByPlaceholderText('Enter Equation')).toHaveValue(
  1420. 'count_unique(user) * 2'
  1421. );
  1422. });
  1423. it('persists the state when updating y-axes', async function () {
  1424. renderTestComponent({
  1425. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1426. query: {
  1427. source: DashboardWidgetSource.DASHBOARDS,
  1428. displayType: DisplayType.LINE,
  1429. },
  1430. });
  1431. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1432. expect(screen.getAllByText('count()')).toHaveLength(2);
  1433. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  1434. userEvent.paste(
  1435. screen.getByPlaceholderText('Enter Equation'),
  1436. 'count_unique(user) * 2'
  1437. );
  1438. userEvent.keyboard('{enter}');
  1439. // Add a y-axis
  1440. userEvent.click(screen.getByText('Add Overlay'));
  1441. // The equation should still be visible
  1442. expect(screen.getByPlaceholderText('Enter Equation')).toHaveValue(
  1443. 'count_unique(user) * 2'
  1444. );
  1445. });
  1446. it('displays the custom equation if the widget has it saved', async function () {
  1447. const widget: Widget = {
  1448. id: '1',
  1449. title: 'Test Widget',
  1450. interval: '5m',
  1451. displayType: DisplayType.LINE,
  1452. queries: [
  1453. {
  1454. name: '',
  1455. conditions: '',
  1456. fields: ['count()', 'project'],
  1457. aggregates: ['count()'],
  1458. columns: ['project'],
  1459. orderby: '-equation|count_unique(user) * 2',
  1460. },
  1461. ],
  1462. };
  1463. const dashboard = mockDashboard({widgets: [widget]});
  1464. renderTestComponent({
  1465. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1466. query: {
  1467. source: DashboardWidgetSource.DASHBOARDS,
  1468. displayType: DisplayType.LINE,
  1469. },
  1470. params: {
  1471. widgetIndex: '0',
  1472. },
  1473. dashboard,
  1474. });
  1475. expect(await screen.findByPlaceholderText('Enter Equation')).toHaveValue(
  1476. 'count_unique(user) * 2'
  1477. );
  1478. });
  1479. it('displays Operators in the input dropdown', async function () {
  1480. renderTestComponent({
  1481. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1482. query: {
  1483. source: DashboardWidgetSource.DASHBOARDS,
  1484. displayType: DisplayType.LINE,
  1485. },
  1486. });
  1487. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1488. expect(screen.getAllByText('count()')).toHaveLength(2);
  1489. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  1490. selectEvent.openMenu(screen.getByPlaceholderText('Enter Equation'));
  1491. expect(screen.getByText('Operators')).toBeInTheDocument();
  1492. expect(screen.queryByText('Fields')).not.toBeInTheDocument();
  1493. });
  1494. it('hides Custom Equation input and resets orderby when switching to table', async function () {
  1495. renderTestComponent({
  1496. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1497. query: {
  1498. source: DashboardWidgetSource.DASHBOARDS,
  1499. displayType: DisplayType.LINE,
  1500. },
  1501. });
  1502. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1503. expect(screen.getAllByText('count()')).toHaveLength(2);
  1504. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  1505. userEvent.paste(
  1506. screen.getByPlaceholderText('Enter Equation'),
  1507. 'count_unique(user) * 2'
  1508. );
  1509. userEvent.keyboard('{enter}');
  1510. // Switch the display type to Table
  1511. userEvent.click(screen.getByText('Line Chart'));
  1512. userEvent.click(screen.getByText('Table'));
  1513. expect(screen.getAllByText('count()')).toHaveLength(2);
  1514. expect(screen.queryByPlaceholderText('Enter Equation')).not.toBeInTheDocument();
  1515. await waitFor(() => {
  1516. expect(eventsv2Mock).toHaveBeenCalledWith(
  1517. '/organizations/org-slug/eventsv2/',
  1518. expect.objectContaining({
  1519. query: expect.objectContaining({
  1520. sort: ['-count()'],
  1521. }),
  1522. })
  1523. );
  1524. });
  1525. });
  1526. it('does not show the Custom Equation input if the only y-axis left is an empty equation', async function () {
  1527. renderTestComponent({
  1528. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1529. query: {
  1530. source: DashboardWidgetSource.DASHBOARDS,
  1531. displayType: DisplayType.LINE,
  1532. },
  1533. });
  1534. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1535. userEvent.click(screen.getByText('Add an Equation'));
  1536. userEvent.click(screen.getAllByLabelText('Remove this Y-Axis')[0]);
  1537. expect(screen.queryByPlaceholderText('Enter Equation')).not.toBeInTheDocument();
  1538. });
  1539. it('persists a sort by a grouping when changing y-axes', async function () {
  1540. renderTestComponent({
  1541. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1542. query: {
  1543. source: DashboardWidgetSource.DASHBOARDS,
  1544. displayType: DisplayType.LINE,
  1545. },
  1546. });
  1547. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1548. expect(screen.getAllByText('count()')).toHaveLength(2);
  1549. // Change the sort option to a grouping field, and then change a y-axis
  1550. await selectEvent.select(screen.getAllByText('count()')[1], 'project');
  1551. await selectEvent.select(screen.getAllByText('count()')[0], /count_unique/);
  1552. // project should appear in the group by field, as well as the sort field
  1553. expect(screen.getAllByText('project')).toHaveLength(2);
  1554. });
  1555. it('persists sort by a y-axis when grouping changes', async function () {
  1556. renderTestComponent({
  1557. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1558. query: {
  1559. source: DashboardWidgetSource.DASHBOARDS,
  1560. displayType: DisplayType.LINE,
  1561. },
  1562. });
  1563. userEvent.click(await screen.findByText('Add Overlay'));
  1564. await selectEvent.select(screen.getByText('Select group'), 'project');
  1565. // Change the sort by to count_unique
  1566. await selectEvent.select(screen.getAllByText('count()')[1], /count_unique/);
  1567. // Change the grouping
  1568. await selectEvent.select(screen.getByText('project'), 'environment');
  1569. // count_unique(user) should still be the sorting field
  1570. expect(screen.getByText(/count_unique/)).toBeInTheDocument();
  1571. expect(screen.getByText('user')).toBeInTheDocument();
  1572. });
  1573. it('does not remove the Custom Equation field if a grouping is updated', async function () {
  1574. renderTestComponent({
  1575. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1576. query: {
  1577. source: DashboardWidgetSource.DASHBOARDS,
  1578. displayType: DisplayType.LINE,
  1579. },
  1580. });
  1581. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1582. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  1583. userEvent.paste(
  1584. screen.getByPlaceholderText('Enter Equation'),
  1585. 'count_unique(user) * 2'
  1586. );
  1587. userEvent.keyboard('{enter}');
  1588. userEvent.click(screen.getByText('Add Group'));
  1589. expect(screen.getByPlaceholderText('Enter Equation')).toHaveValue(
  1590. 'count_unique(user) * 2'
  1591. );
  1592. });
  1593. it.each`
  1594. directionPrefix | expectedOrderSelection | displayType
  1595. ${'-'} | ${'High to low'} | ${DisplayType.TABLE}
  1596. ${''} | ${'Low to high'} | ${DisplayType.TABLE}
  1597. ${'-'} | ${'High to low'} | ${DisplayType.LINE}
  1598. ${''} | ${'Low to high'} | ${DisplayType.LINE}
  1599. `(
  1600. `opens a widget with the '$expectedOrderSelection' sort order when the widget was saved with that direction`,
  1601. async function ({directionPrefix, expectedOrderSelection}) {
  1602. const widget: Widget = {
  1603. id: '1',
  1604. title: 'Test Widget',
  1605. interval: '5m',
  1606. displayType: DisplayType.LINE,
  1607. queries: [
  1608. {
  1609. name: '',
  1610. conditions: '',
  1611. fields: ['count_unique(user)'],
  1612. aggregates: ['count_unique(user)'],
  1613. columns: ['project'],
  1614. orderby: `${directionPrefix}count_unique(user)`,
  1615. },
  1616. ],
  1617. };
  1618. const dashboard = mockDashboard({widgets: [widget]});
  1619. renderTestComponent({
  1620. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1621. dashboard,
  1622. params: {
  1623. widgetIndex: '0',
  1624. },
  1625. });
  1626. await screen.findByText(expectedOrderSelection);
  1627. }
  1628. );
  1629. it('saved widget with aggregate alias as orderby should persist alias when y-axes change', async function () {
  1630. const widget: Widget = {
  1631. id: '1',
  1632. title: 'Test Widget',
  1633. interval: '5m',
  1634. displayType: DisplayType.TABLE,
  1635. queries: [
  1636. {
  1637. name: '',
  1638. conditions: '',
  1639. fields: ['project', 'count_unique(user)'],
  1640. aggregates: ['count_unique(user)'],
  1641. columns: ['project'],
  1642. orderby: 'count_unique(user)',
  1643. },
  1644. ],
  1645. };
  1646. const dashboard = mockDashboard({widgets: [widget]});
  1647. renderTestComponent({
  1648. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1649. dashboard,
  1650. params: {
  1651. widgetIndex: '0',
  1652. },
  1653. });
  1654. await screen.findByText('Sort by a column');
  1655. // Assert for length 2 since one in the table header and one in sort by
  1656. expect(screen.getAllByText('count_unique(user)')).toHaveLength(2);
  1657. userEvent.click(screen.getByText('Add a Column'));
  1658. // The sort by should still have count_unique(user)
  1659. await waitFor(() =>
  1660. expect(screen.getAllByText('count_unique(user)')).toHaveLength(2)
  1661. );
  1662. });
  1663. it('will reset the sort field when going from line to table when sorting by a value not in fields', async function () {
  1664. renderTestComponent({
  1665. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1666. query: {
  1667. displayType: DisplayType.LINE,
  1668. },
  1669. });
  1670. await selectEvent.select(await screen.findByText('Select group'), 'project');
  1671. expect(screen.getAllByText('count()')).toHaveLength(2);
  1672. await selectEvent.select(screen.getAllByText('count()')[1], /count_unique/);
  1673. userEvent.click(screen.getByText('Line Chart'));
  1674. userEvent.click(screen.getByText('Table'));
  1675. // 1 for table header, 1 for column selection, and 1 for sorting
  1676. await waitFor(() => {
  1677. expect(screen.getAllByText('count()')).toHaveLength(3);
  1678. });
  1679. });
  1680. it('equations in y-axis appear in sort by field for grouped timeseries', async function () {
  1681. renderTestComponent({
  1682. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1683. query: {
  1684. displayType: DisplayType.LINE,
  1685. },
  1686. });
  1687. userEvent.click(await screen.findByText('Add an Equation'));
  1688. userEvent.paste(screen.getByPlaceholderText('Equation'), 'count() * 100');
  1689. userEvent.keyboard('{enter}');
  1690. await selectEvent.select(screen.getByText('Select group'), 'project');
  1691. expect(screen.getAllByText('count()')).toHaveLength(2);
  1692. await selectEvent.select(screen.getAllByText('count()')[1], 'count() * 100');
  1693. });
  1694. it('does not reset the orderby when ordered by an equation in table', async function () {
  1695. const widget: Widget = {
  1696. id: '1',
  1697. title: 'Errors over time',
  1698. interval: '5m',
  1699. displayType: DisplayType.TABLE,
  1700. queries: [
  1701. {
  1702. name: '',
  1703. conditions: '',
  1704. fields: [
  1705. 'count()',
  1706. 'count_unique(id)',
  1707. 'equation|count() + count_unique(id)',
  1708. ],
  1709. aggregates: [
  1710. 'count()',
  1711. 'count_unique(id)',
  1712. 'equation|count() + count_unique(id)',
  1713. ],
  1714. columns: [],
  1715. orderby: '-equation[0]',
  1716. },
  1717. ],
  1718. };
  1719. const dashboard = mockDashboard({widgets: [widget]});
  1720. renderTestComponent({
  1721. dashboard,
  1722. params: {
  1723. widgetIndex: '0',
  1724. },
  1725. });
  1726. await screen.findByText('Sort by a column');
  1727. // 1 in the column selector, 1 in the sort by field
  1728. expect(screen.getAllByText('count() + count_unique(id)')).toHaveLength(2);
  1729. });
  1730. });
  1731. describe('Widget creation coming from other verticals', function () {
  1732. it('redirects correctly when creating a new dashboard', async function () {
  1733. const {router} = renderTestComponent({
  1734. query: {source: DashboardWidgetSource.DISCOVERV2},
  1735. });
  1736. userEvent.click(await screen.findByText('Add Widget'));
  1737. await waitFor(() => {
  1738. expect(router.push).toHaveBeenCalledWith(
  1739. expect.objectContaining({
  1740. pathname: '/organizations/org-slug/dashboards/new/',
  1741. query: {
  1742. displayType: 'table',
  1743. interval: '5m',
  1744. title: 'Custom Widget',
  1745. queryNames: [''],
  1746. queryConditions: [''],
  1747. queryFields: ['count()'],
  1748. queryOrderby: '-count()',
  1749. start: null,
  1750. end: null,
  1751. statsPeriod: '24h',
  1752. utc: null,
  1753. project: [],
  1754. environment: [],
  1755. },
  1756. })
  1757. );
  1758. });
  1759. });
  1760. it('redirects correctly when choosing an existing dashboard', async function () {
  1761. const {router} = renderTestComponent({
  1762. query: {source: DashboardWidgetSource.DISCOVERV2},
  1763. dashboard: testDashboard,
  1764. });
  1765. userEvent.click(await screen.findByText('Add Widget'));
  1766. await waitFor(() => {
  1767. expect(router.push).toHaveBeenCalledWith(
  1768. expect.objectContaining({
  1769. pathname: '/organizations/org-slug/dashboard/2/',
  1770. query: {
  1771. displayType: 'table',
  1772. interval: '5m',
  1773. title: 'Custom Widget',
  1774. queryNames: [''],
  1775. queryConditions: [''],
  1776. queryFields: ['count()'],
  1777. queryOrderby: '-count()',
  1778. start: null,
  1779. end: null,
  1780. statsPeriod: '24h',
  1781. utc: null,
  1782. project: [],
  1783. environment: [],
  1784. },
  1785. })
  1786. );
  1787. });
  1788. });
  1789. it('shows the correct orderby when switching from a line chart to table', async function () {
  1790. const defaultWidgetQuery = {
  1791. name: '',
  1792. fields: ['count_unique(user)'],
  1793. columns: [],
  1794. aggregates: ['count_unique(user)'],
  1795. conditions: '',
  1796. orderby: 'count_unique(user)',
  1797. };
  1798. const defaultTableColumns = ['title', 'count_unique(user)'];
  1799. renderTestComponent({
  1800. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1801. query: {
  1802. source: DashboardWidgetSource.DISCOVERV2,
  1803. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  1804. displayType: DisplayType.LINE,
  1805. defaultTableColumns,
  1806. },
  1807. });
  1808. userEvent.click(await screen.findByText('Line Chart'));
  1809. userEvent.click(screen.getByText('Table'));
  1810. expect(screen.getByText('count_unique(user)')).toBeInTheDocument();
  1811. await waitFor(() => {
  1812. expect(eventsv2Mock).toHaveBeenLastCalledWith(
  1813. '/organizations/org-slug/eventsv2/',
  1814. expect.objectContaining({
  1815. query: expect.objectContaining({
  1816. field: defaultTableColumns,
  1817. sort: ['count_unique(user)'],
  1818. }),
  1819. })
  1820. );
  1821. });
  1822. });
  1823. it('does not send request with orderby if a timeseries chart without grouping', async function () {
  1824. const defaultWidgetQuery = {
  1825. name: '',
  1826. fields: ['count_unique(user)'],
  1827. columns: [],
  1828. aggregates: ['count_unique(user)'],
  1829. conditions: '',
  1830. orderby: 'count_unique(user)',
  1831. };
  1832. const defaultTableColumns = ['title', 'count_unique(user)'];
  1833. renderTestComponent({
  1834. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1835. query: {
  1836. source: DashboardWidgetSource.DISCOVERV2,
  1837. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  1838. displayType: DisplayType.LINE,
  1839. defaultTableColumns,
  1840. },
  1841. });
  1842. await waitFor(() => {
  1843. expect(eventsStatsMock).toHaveBeenLastCalledWith(
  1844. '/organizations/org-slug/events-stats/',
  1845. expect.objectContaining({
  1846. query: expect.objectContaining({
  1847. orderby: '',
  1848. }),
  1849. })
  1850. );
  1851. });
  1852. });
  1853. });
  1854. it('opens top-N widgets as area display', async function () {
  1855. const widget: Widget = {
  1856. id: '1',
  1857. title: 'Errors over time',
  1858. interval: '5m',
  1859. displayType: DisplayType.TOP_N,
  1860. queries: [
  1861. {
  1862. name: '',
  1863. conditions: '',
  1864. fields: ['count()', 'count_unique(id)'],
  1865. aggregates: ['count()', 'count_unique(id)'],
  1866. columns: [],
  1867. orderby: '-count()',
  1868. },
  1869. ],
  1870. };
  1871. const dashboard = mockDashboard({widgets: [widget]});
  1872. renderTestComponent({
  1873. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1874. dashboard,
  1875. params: {
  1876. widgetIndex: '0',
  1877. },
  1878. });
  1879. expect(await screen.findByText('Area Chart')).toBeInTheDocument();
  1880. });
  1881. it('Update table header values (field alias)', async function () {
  1882. const handleSave = jest.fn();
  1883. renderTestComponent({
  1884. onSave: handleSave,
  1885. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1886. });
  1887. await screen.findByText('Table');
  1888. userEvent.paste(screen.getByPlaceholderText('Alias'), 'First Alias');
  1889. userEvent.click(screen.getByLabelText('Add a Column'));
  1890. userEvent.paste(screen.getAllByPlaceholderText('Alias')[1], 'Second Alias');
  1891. userEvent.click(screen.getByText('Add Widget'));
  1892. await waitFor(() => {
  1893. expect(handleSave).toHaveBeenCalledWith([
  1894. expect.objectContaining({
  1895. queries: [
  1896. expect.objectContaining({fieldAliases: ['First Alias', 'Second Alias']}),
  1897. ],
  1898. }),
  1899. ]);
  1900. });
  1901. });
  1902. it('does not wipe equation aliases when a column alias is updated', async function () {
  1903. renderTestComponent({
  1904. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1905. });
  1906. await screen.findByText('Table');
  1907. userEvent.click(screen.getByText('Add an Equation'));
  1908. userEvent.paste(screen.getAllByPlaceholderText('Alias')[1], 'This should persist');
  1909. userEvent.type(screen.getAllByPlaceholderText('Alias')[0], 'A');
  1910. expect(await screen.findByText('This should persist')).toBeInTheDocument();
  1911. });
  1912. it('does not wipe equation aliases when a column selection is made', async function () {
  1913. renderTestComponent({
  1914. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1915. });
  1916. await screen.findByText('Table');
  1917. userEvent.click(screen.getByText('Add an Equation'));
  1918. userEvent.paste(screen.getAllByPlaceholderText('Alias')[1], 'This should persist');
  1919. // 1 for the table, 1 for the the column selector, 1 for the sort
  1920. await waitFor(() => expect(screen.getAllByText('count()')).toHaveLength(3));
  1921. await selectEvent.select(screen.getAllByText('count()')[1], /count_unique/);
  1922. expect(screen.getByText('This should persist')).toBeInTheDocument();
  1923. });
  1924. it('copies over the orderby from the previous query if adding another', async function () {
  1925. renderTestComponent({
  1926. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  1927. });
  1928. userEvent.click(await screen.findByText('Table'));
  1929. userEvent.click(screen.getByText('Line Chart'));
  1930. await selectEvent.select(screen.getByText('Select group'), 'project');
  1931. await selectEvent.select(screen.getAllByText('count()')[1], 'count_unique(…)');
  1932. MockApiClient.clearMockResponses();
  1933. eventsStatsMock = MockApiClient.addMockResponse({
  1934. url: '/organizations/org-slug/events-stats/',
  1935. body: [],
  1936. });
  1937. userEvent.click(screen.getByText('Add Query'));
  1938. // Assert on two calls, one for each query
  1939. const expectedArgs = expect.objectContaining({
  1940. query: expect.objectContaining({
  1941. orderby: '-count_unique(user)',
  1942. }),
  1943. });
  1944. expect(eventsStatsMock).toHaveBeenNthCalledWith(
  1945. 1,
  1946. '/organizations/org-slug/events-stats/',
  1947. expectedArgs
  1948. );
  1949. expect(eventsStatsMock).toHaveBeenNthCalledWith(
  1950. 2,
  1951. '/organizations/org-slug/events-stats/',
  1952. expectedArgs
  1953. );
  1954. });
  1955. describe('Issue Widgets', function () {
  1956. it('sets widgetType to issues', async function () {
  1957. const handleSave = jest.fn();
  1958. renderTestComponent({onSave: handleSave});
  1959. userEvent.click(
  1960. await screen.findByText('Issues (States, Assignment, Time, etc.)')
  1961. );
  1962. userEvent.click(screen.getByLabelText('Add Widget'));
  1963. await waitFor(() => {
  1964. expect(handleSave).toHaveBeenCalledWith([
  1965. expect.objectContaining({
  1966. title: 'Custom Widget',
  1967. displayType: DisplayType.TABLE,
  1968. interval: '5m',
  1969. widgetType: WidgetType.ISSUE,
  1970. queries: [
  1971. {
  1972. conditions: '',
  1973. fields: ['issue', 'assignee', 'title'],
  1974. columns: ['issue', 'assignee', 'title'],
  1975. aggregates: [],
  1976. fieldAliases: [],
  1977. name: '',
  1978. orderby: 'date',
  1979. },
  1980. ],
  1981. }),
  1982. ]);
  1983. });
  1984. expect(handleSave).toHaveBeenCalledTimes(1);
  1985. });
  1986. it('render issues dataset disabled when the display type is not set to table', async function () {
  1987. renderTestComponent({
  1988. query: {
  1989. source: DashboardWidgetSource.DISCOVERV2,
  1990. },
  1991. });
  1992. userEvent.click(await screen.findByText('Table'));
  1993. userEvent.click(screen.getByText('Line Chart'));
  1994. expect(
  1995. screen.getByRole('radio', {
  1996. name: 'Select Errors and Transactions',
  1997. })
  1998. ).toBeEnabled();
  1999. expect(
  2000. screen.getByRole('radio', {
  2001. name: 'Select Issues (States, Assignment, Time, etc.)',
  2002. })
  2003. ).toBeDisabled();
  2004. });
  2005. it('disables moving and deleting issue column', async function () {
  2006. renderTestComponent();
  2007. userEvent.click(
  2008. await screen.findByText('Issues (States, Assignment, Time, etc.)')
  2009. );
  2010. expect(screen.getByText('issue')).toBeInTheDocument();
  2011. expect(screen.getByText('assignee')).toBeInTheDocument();
  2012. expect(screen.getByText('title')).toBeInTheDocument();
  2013. expect(screen.getAllByLabelText('Remove column')).toHaveLength(2);
  2014. expect(screen.getAllByLabelText('Drag to reorder')).toHaveLength(3);
  2015. userEvent.click(screen.getAllByLabelText('Remove column')[1]);
  2016. userEvent.click(screen.getAllByLabelText('Remove column')[0]);
  2017. expect(screen.getByText('issue')).toBeInTheDocument();
  2018. expect(screen.queryByText('assignee')).not.toBeInTheDocument();
  2019. expect(screen.queryByText('title')).not.toBeInTheDocument();
  2020. expect(screen.queryByLabelText('Remove column')).not.toBeInTheDocument();
  2021. expect(screen.queryByLabelText('Drag to reorder')).not.toBeInTheDocument();
  2022. });
  2023. it('issue query does not work on default search bar', async function () {
  2024. renderTestComponent();
  2025. const input = (await screen.findByPlaceholderText(
  2026. 'Search for events, users, tags, and more'
  2027. )) as HTMLTextAreaElement;
  2028. userEvent.paste(input, 'bookmarks', {
  2029. clipboardData: {getData: () => ''},
  2030. } as unknown as React.ClipboardEvent<HTMLTextAreaElement>);
  2031. input.setSelectionRange(9, 9);
  2032. expect(await screen.findByText('No items found')).toBeInTheDocument();
  2033. });
  2034. it('renders with an issues search bar when selected in dataset selection', async function () {
  2035. renderTestComponent();
  2036. userEvent.click(
  2037. await screen.findByText('Issues (States, Assignment, Time, etc.)')
  2038. );
  2039. const input = (await screen.findByPlaceholderText(
  2040. 'Search for issues, status, assigned, and more'
  2041. )) as HTMLTextAreaElement;
  2042. userEvent.paste(input, 'is:', {
  2043. clipboardData: {getData: () => ''},
  2044. } as unknown as React.ClipboardEvent<HTMLTextAreaElement>);
  2045. input.setSelectionRange(3, 3);
  2046. expect(await screen.findByText('resolved')).toBeInTheDocument();
  2047. });
  2048. it('Update table header values (field alias)', async function () {
  2049. const handleSave = jest.fn();
  2050. renderTestComponent({
  2051. onSave: handleSave,
  2052. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2053. });
  2054. await screen.findByText('Table');
  2055. userEvent.click(screen.getByText('Issues (States, Assignment, Time, etc.)'));
  2056. userEvent.paste(screen.getAllByPlaceholderText('Alias')[0], 'First Alias');
  2057. userEvent.click(screen.getByText('Add Widget'));
  2058. await waitFor(() => {
  2059. expect(handleSave).toHaveBeenCalledWith([
  2060. expect.objectContaining({
  2061. queries: [
  2062. expect.objectContaining({
  2063. fieldAliases: ['First Alias', '', ''],
  2064. }),
  2065. ],
  2066. }),
  2067. ]);
  2068. });
  2069. });
  2070. });
  2071. describe('Release Widgets', function () {
  2072. const releaseHealthFeatureFlags = [
  2073. ...defaultOrgFeatures,
  2074. 'new-widget-builder-experience-design',
  2075. 'dashboards-releases',
  2076. ];
  2077. it('does not show the Release Health dataset if there is no dashboards-releases flag', async function () {
  2078. renderTestComponent({
  2079. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2080. });
  2081. expect(await screen.findByText('Errors and Transactions')).toBeInTheDocument();
  2082. expect(
  2083. screen.queryByText('Releases (Sessions, Crash rates)')
  2084. ).not.toBeInTheDocument();
  2085. });
  2086. it('shows the Release Health dataset if there is the dashboards-releases flag', async function () {
  2087. renderTestComponent({
  2088. orgFeatures: releaseHealthFeatureFlags,
  2089. });
  2090. expect(await screen.findByText('Errors and Transactions')).toBeInTheDocument();
  2091. expect(screen.getByText('Releases (Sessions, Crash rates)')).toBeInTheDocument();
  2092. });
  2093. it('maintains the selected dataset when display type is changed', async function () {
  2094. renderTestComponent({
  2095. orgFeatures: releaseHealthFeatureFlags,
  2096. });
  2097. expect(
  2098. await screen.findByText('Releases (Sessions, Crash rates)')
  2099. ).toBeInTheDocument();
  2100. expect(screen.getByLabelText(/releases/i)).not.toBeChecked();
  2101. userEvent.click(screen.getByLabelText(/releases/i));
  2102. await waitFor(() => expect(screen.getByLabelText(/releases/i)).toBeChecked());
  2103. userEvent.click(screen.getByText('Table'));
  2104. userEvent.click(screen.getByText('Line Chart'));
  2105. await waitFor(() => expect(screen.getByLabelText(/releases/i)).toBeChecked());
  2106. });
  2107. it('displays releases tags', async function () {
  2108. renderTestComponent({
  2109. orgFeatures: releaseHealthFeatureFlags,
  2110. });
  2111. expect(
  2112. await screen.findByText('Releases (Sessions, Crash rates)')
  2113. ).toBeInTheDocument();
  2114. userEvent.click(screen.getByLabelText(/releases/i));
  2115. expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
  2116. expect(screen.getByText('session')).toBeInTheDocument();
  2117. userEvent.click(screen.getByText('crash_free_rate(…)'));
  2118. expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
  2119. expect(screen.getByText('release')).toBeInTheDocument();
  2120. expect(screen.getByText('environment')).toBeInTheDocument();
  2121. expect(screen.getByText('session.status')).toBeInTheDocument();
  2122. userEvent.click(screen.getByText('count_unique(…)'));
  2123. expect(screen.getByText('user')).toBeInTheDocument();
  2124. });
  2125. it('does not display tags as params', async function () {
  2126. renderTestComponent({
  2127. orgFeatures: releaseHealthFeatureFlags,
  2128. });
  2129. expect(
  2130. await screen.findByText('Releases (Sessions, Crash rates)')
  2131. ).toBeInTheDocument();
  2132. userEvent.click(screen.getByLabelText(/releases/i));
  2133. expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
  2134. await selectEvent.select(
  2135. screen.getByText('crash_free_rate(…)'),
  2136. 'count_unique(…)'
  2137. );
  2138. userEvent.click(screen.getByText('user'));
  2139. expect(screen.queryByText('release')).not.toBeInTheDocument();
  2140. expect(screen.queryByText('environment')).not.toBeInTheDocument();
  2141. expect(screen.queryByText('session.status')).not.toBeInTheDocument();
  2142. });
  2143. it('does not allow sort by when session.status is selected', async function () {
  2144. renderTestComponent({
  2145. orgFeatures: releaseHealthFeatureFlags,
  2146. });
  2147. expect(
  2148. await screen.findByText('Releases (Sessions, Crash rates)')
  2149. ).toBeInTheDocument();
  2150. userEvent.click(screen.getByLabelText(/releases/i));
  2151. expect(screen.getByText('High to low')).toBeEnabled();
  2152. expect(screen.getByText('crash_free_rate(session)')).toBeInTheDocument();
  2153. userEvent.click(screen.getByLabelText('Add a Column'));
  2154. await selectEvent.select(screen.getByText('(Required)'), 'session.status');
  2155. expect(screen.getByRole('textbox', {name: 'Sort direction'})).toBeDisabled();
  2156. expect(screen.getByRole('textbox', {name: 'Sort by'})).toBeDisabled();
  2157. });
  2158. it('does not allow sort on tags except release', async function () {
  2159. jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
  2160. renderTestComponent({
  2161. orgFeatures: releaseHealthFeatureFlags,
  2162. });
  2163. expect(
  2164. await screen.findByText('Releases (Sessions, Crash rates)')
  2165. ).toBeInTheDocument();
  2166. userEvent.click(screen.getByLabelText(/releases/i));
  2167. expect(screen.getByText('High to low')).toBeEnabled();
  2168. expect(screen.getByText('crash_free_rate(session)')).toBeInTheDocument();
  2169. userEvent.click(screen.getByLabelText('Add a Column'));
  2170. await selectEvent.select(screen.getByText('(Required)'), 'release');
  2171. userEvent.click(screen.getByLabelText('Add a Column'));
  2172. await selectEvent.select(screen.getByText('(Required)'), 'environment');
  2173. expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
  2174. // Selector "sortDirection"
  2175. expect(screen.getByText('High to low')).toBeInTheDocument();
  2176. // Selector "sortBy"
  2177. userEvent.click(screen.getAllByText('crash_free_rate(session)')[1]);
  2178. // release exists in sort by selector
  2179. expect(screen.getAllByText('release')).toHaveLength(3);
  2180. // environment does not exist in sort by selector
  2181. expect(screen.getAllByText('environment')).toHaveLength(2);
  2182. });
  2183. it('makes the appropriate sessions call', async function () {
  2184. jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
  2185. renderTestComponent({
  2186. orgFeatures: releaseHealthFeatureFlags,
  2187. });
  2188. expect(
  2189. await screen.findByText('Releases (Sessions, Crash rates)')
  2190. ).toBeInTheDocument();
  2191. userEvent.click(screen.getByLabelText(/releases/i));
  2192. userEvent.click(screen.getByText('Table'));
  2193. userEvent.click(screen.getByText('Line Chart'));
  2194. await waitFor(() =>
  2195. expect(metricsDataMock).toHaveBeenLastCalledWith(
  2196. `/organizations/org-slug/metrics/data/`,
  2197. expect.objectContaining({
  2198. query: expect.objectContaining({
  2199. environment: [],
  2200. field: [`session.crash_free_rate`],
  2201. groupBy: [],
  2202. interval: '5m',
  2203. project: [],
  2204. statsPeriod: '24h',
  2205. }),
  2206. })
  2207. )
  2208. );
  2209. });
  2210. it('calls the session endpoint with the right limit', async function () {
  2211. jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
  2212. renderTestComponent({
  2213. orgFeatures: releaseHealthFeatureFlags,
  2214. });
  2215. expect(
  2216. await screen.findByText('Releases (Sessions, Crash rates)')
  2217. ).toBeInTheDocument();
  2218. userEvent.click(screen.getByLabelText(/releases/i));
  2219. userEvent.click(screen.getByText('Table'));
  2220. userEvent.click(screen.getByText('Line Chart'));
  2221. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2222. expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
  2223. await waitFor(() =>
  2224. expect(metricsDataMock).toHaveBeenLastCalledWith(
  2225. `/organizations/org-slug/metrics/data/`,
  2226. expect.objectContaining({
  2227. query: expect.objectContaining({
  2228. environment: [],
  2229. field: ['session.crash_free_rate'],
  2230. groupBy: ['project_id'],
  2231. interval: '5m',
  2232. orderBy: '-session.crash_free_rate',
  2233. per_page: 5,
  2234. project: [],
  2235. statsPeriod: '24h',
  2236. }),
  2237. })
  2238. )
  2239. );
  2240. });
  2241. it('calls sessions api when session.status is selected as a groupby', async function () {
  2242. jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
  2243. renderTestComponent({
  2244. orgFeatures: releaseHealthFeatureFlags,
  2245. });
  2246. expect(
  2247. await screen.findByText('Releases (Sessions, Crash rates)')
  2248. ).toBeInTheDocument();
  2249. userEvent.click(screen.getByLabelText(/releases/i));
  2250. userEvent.click(screen.getByText('Table'));
  2251. userEvent.click(screen.getByText('Line Chart'));
  2252. await selectEvent.select(
  2253. await screen.findByText('Select group'),
  2254. 'session.status'
  2255. );
  2256. expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
  2257. await waitFor(() =>
  2258. expect(sessionsDataMock).toHaveBeenLastCalledWith(
  2259. `/organizations/org-slug/sessions/`,
  2260. expect.objectContaining({
  2261. query: expect.objectContaining({
  2262. environment: [],
  2263. field: ['crash_free_rate(session)'],
  2264. groupBy: ['session.status'],
  2265. interval: '5m',
  2266. project: [],
  2267. statsPeriod: '24h',
  2268. }),
  2269. })
  2270. )
  2271. );
  2272. });
  2273. it('displays the correct options for area chart', async function () {
  2274. renderTestComponent({
  2275. orgFeatures: releaseHealthFeatureFlags,
  2276. });
  2277. expect(
  2278. await screen.findByText('Releases (Sessions, Crash rates)')
  2279. ).toBeInTheDocument();
  2280. // change dataset to releases
  2281. userEvent.click(screen.getByLabelText(/releases/i));
  2282. userEvent.click(screen.getByText('Table'));
  2283. userEvent.click(screen.getByText('Line Chart'));
  2284. expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
  2285. expect(screen.getByText(`session`)).toBeInTheDocument();
  2286. userEvent.click(screen.getByText('crash_free_rate(…)'));
  2287. expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
  2288. userEvent.click(screen.getByText('count_unique(…)'));
  2289. expect(screen.getByText('user')).toBeInTheDocument();
  2290. });
  2291. it('sets widgetType to release', async function () {
  2292. jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
  2293. renderTestComponent({
  2294. orgFeatures: releaseHealthFeatureFlags,
  2295. });
  2296. userEvent.click(await screen.findByText('Releases (Sessions, Crash rates)'));
  2297. expect(metricsDataMock).toHaveBeenCalled();
  2298. expect(screen.getByLabelText(/Releases/i)).toBeChecked();
  2299. });
  2300. it('does not display "add an equation" button', async function () {
  2301. const widget: Widget = {
  2302. title: 'Release Widget',
  2303. displayType: DisplayType.TABLE,
  2304. widgetType: WidgetType.RELEASE,
  2305. queries: [
  2306. {
  2307. name: 'errors',
  2308. conditions: 'event.type:error',
  2309. fields: ['sdk.name', 'count()'],
  2310. columns: ['sdk.name'],
  2311. aggregates: ['count()'],
  2312. orderby: '-sdk.name',
  2313. },
  2314. ],
  2315. interval: '1d',
  2316. id: '1',
  2317. };
  2318. const dashboard = mockDashboard({widgets: [widget]});
  2319. renderTestComponent({
  2320. orgFeatures: releaseHealthFeatureFlags,
  2321. dashboard,
  2322. params: {
  2323. widgetIndex: '0',
  2324. },
  2325. });
  2326. // Select line chart display
  2327. userEvent.click(await screen.findByText('Table'));
  2328. userEvent.click(screen.getByText('Line Chart'));
  2329. await waitFor(() =>
  2330. expect(screen.queryByLabelText('Add an Equation')).not.toBeInTheDocument()
  2331. );
  2332. });
  2333. it('render release dataset disabled when the display type is world map', async function () {
  2334. renderTestComponent({
  2335. query: {
  2336. source: DashboardWidgetSource.DISCOVERV2,
  2337. },
  2338. orgFeatures: releaseHealthFeatureFlags,
  2339. });
  2340. userEvent.click(await screen.findByText('Table'));
  2341. userEvent.click(screen.getByText('World Map'));
  2342. await waitFor(() => expect(screen.getByLabelText(/Releases/)).toBeDisabled());
  2343. expect(
  2344. screen.getByRole('radio', {
  2345. name: 'Select Errors and Transactions',
  2346. })
  2347. ).toBeEnabled();
  2348. expect(
  2349. screen.getByRole('radio', {
  2350. name: 'Select Issues (States, Assignment, Time, etc.)',
  2351. })
  2352. ).toBeDisabled();
  2353. });
  2354. it('renders with a release search bar', async function () {
  2355. renderTestComponent({
  2356. orgFeatures: releaseHealthFeatureFlags,
  2357. });
  2358. userEvent.type(
  2359. await screen.findByPlaceholderText('Search for events, users, tags, and more'),
  2360. 'session.status:'
  2361. );
  2362. await waitFor(() => {
  2363. expect(screen.getByText("isn't supported here.")).toBeInTheDocument();
  2364. });
  2365. userEvent.click(screen.getByText('Releases (Sessions, Crash rates)'));
  2366. userEvent.click(
  2367. screen.getByPlaceholderText(
  2368. 'Search for release version, session status, and more'
  2369. )
  2370. );
  2371. expect(await screen.findByText('environment')).toBeInTheDocument();
  2372. expect(screen.getByText('project')).toBeInTheDocument();
  2373. expect(screen.getByText('release')).toBeInTheDocument();
  2374. });
  2375. it('adds a function when the only column chosen in a table is a tag', async function () {
  2376. jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
  2377. renderTestComponent({
  2378. orgFeatures: releaseHealthFeatureFlags,
  2379. });
  2380. userEvent.click(await screen.findByText('Releases (Sessions, Crash rates)'));
  2381. await selectEvent.select(screen.getByText('crash_free_rate(…)'), 'environment');
  2382. // 1 in the table header, 1 in the column selector, and 1 in the sort by
  2383. expect(screen.getAllByText(/crash_free_rate/)).toHaveLength(3);
  2384. expect(screen.getAllByText('environment')).toHaveLength(2);
  2385. });
  2386. });
  2387. describe('Widget Library', function () {
  2388. it('renders', async function () {
  2389. renderTestComponent();
  2390. expect(await screen.findByText('Widget Library')).toBeInTheDocument();
  2391. });
  2392. it('only opens the modal when the query data is changed', async function () {
  2393. const mockModal = jest.spyOn(modals, 'openWidgetBuilderOverwriteModal');
  2394. renderTestComponent();
  2395. await screen.findByText('Widget Library');
  2396. userEvent.click(screen.getByText('Duration Distribution'));
  2397. // Widget Library, Builder title, and Chart title
  2398. expect(await screen.findAllByText('Duration Distribution')).toHaveLength(3);
  2399. // Confirm modal doesn't open because no changes were made
  2400. expect(mockModal).not.toHaveBeenCalled();
  2401. userEvent.click(screen.getAllByLabelText('Remove this Y-Axis')[0]);
  2402. userEvent.click(screen.getByText('High Throughput Transactions'));
  2403. // Should not have overwritten widget data, and confirm modal should open
  2404. expect(await screen.findAllByText('Duration Distribution')).toHaveLength(3);
  2405. expect(mockModal).toHaveBeenCalled();
  2406. });
  2407. });
  2408. describe('group by field', function () {
  2409. it('does not contain functions as options', async function () {
  2410. renderTestComponent({
  2411. query: {displayType: 'line'},
  2412. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2413. });
  2414. await screen.findByText('Group your results');
  2415. expect(screen.getByText('Select group')).toBeInTheDocument();
  2416. userEvent.click(screen.getByText('Select group'));
  2417. // Only one f(x) field set in the y-axis selector
  2418. expect(screen.getByText('f(x)')).toBeInTheDocument();
  2419. });
  2420. it('adds more fields when Add Group is clicked', async function () {
  2421. renderTestComponent({
  2422. query: {displayType: 'line'},
  2423. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2424. });
  2425. await screen.findByText('Group your results');
  2426. userEvent.click(screen.getByText('Add Group'));
  2427. expect(await screen.findAllByText('Select group')).toHaveLength(2);
  2428. });
  2429. it("doesn't reset group by when changing y-axis", async function () {
  2430. renderTestComponent({
  2431. query: {displayType: 'line'},
  2432. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2433. });
  2434. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2435. userEvent.click(screen.getAllByText('count()')[0], undefined, {skipHover: true});
  2436. userEvent.click(screen.getByText(/count_unique/), undefined, {skipHover: true});
  2437. expect(await screen.findByText('project')).toBeInTheDocument();
  2438. });
  2439. it("doesn't erase the selection when switching to another time series", async function () {
  2440. renderTestComponent({
  2441. query: {displayType: 'line'},
  2442. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2443. });
  2444. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2445. userEvent.click(screen.getByText('Line Chart'));
  2446. userEvent.click(screen.getByText('Area Chart'));
  2447. expect(await screen.findByText('project')).toBeInTheDocument();
  2448. });
  2449. it('sends a top N request when a grouping is selected', async function () {
  2450. renderTestComponent({
  2451. query: {displayType: 'line'},
  2452. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2453. });
  2454. userEvent.click(await screen.findByText('Group your results'));
  2455. userEvent.type(screen.getByText('Select group'), 'project{enter}');
  2456. await waitFor(() =>
  2457. expect(eventsStatsMock).toHaveBeenNthCalledWith(
  2458. 2,
  2459. '/organizations/org-slug/events-stats/',
  2460. expect.objectContaining({
  2461. query: expect.objectContaining({
  2462. query: '',
  2463. yAxis: ['count()'],
  2464. field: ['project', 'count()'],
  2465. topEvents: TOP_N,
  2466. orderby: '-count()',
  2467. }),
  2468. })
  2469. )
  2470. );
  2471. });
  2472. it('allows deleting groups until there is one left', async function () {
  2473. renderTestComponent({
  2474. query: {displayType: 'line'},
  2475. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2476. });
  2477. await screen.findByText('Group your results');
  2478. userEvent.click(screen.getByText('Add Group'));
  2479. expect(screen.getAllByLabelText('Remove group')).toHaveLength(2);
  2480. userEvent.click(screen.getAllByLabelText('Remove group')[1]);
  2481. await waitFor(() =>
  2482. expect(screen.queryByLabelText('Remove group')).not.toBeInTheDocument()
  2483. );
  2484. });
  2485. it("display 'remove' and 'drag to reorder' buttons", async function () {
  2486. renderTestComponent({
  2487. query: {displayType: 'line'},
  2488. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2489. });
  2490. await screen.findByText('Select group');
  2491. expect(screen.queryByLabelText('Remove group')).not.toBeInTheDocument();
  2492. await selectEvent.select(screen.getByText('Select group'), 'project');
  2493. expect(screen.getByLabelText('Remove group')).toBeInTheDocument();
  2494. expect(screen.queryByLabelText('Drag to reorder')).not.toBeInTheDocument();
  2495. userEvent.click(screen.getByText('Add Group'));
  2496. expect(screen.getAllByLabelText('Remove group')).toHaveLength(2);
  2497. expect(screen.getAllByLabelText('Drag to reorder')).toHaveLength(2);
  2498. });
  2499. it.todo(
  2500. 'Since simulate drag and drop with RTL is not recommended because of browser layout, remember to create acceptance test for this'
  2501. );
  2502. });
  2503. describe('limit field', function () {
  2504. it('renders if groupBy value is present', async function () {
  2505. const handleSave = jest.fn();
  2506. renderTestComponent({
  2507. query: {displayType: 'line'},
  2508. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2509. onSave: handleSave,
  2510. });
  2511. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2512. expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
  2513. userEvent.click(screen.getByText('Add Widget'));
  2514. await waitFor(() =>
  2515. expect(handleSave).toHaveBeenCalledWith([
  2516. expect.objectContaining({
  2517. limit: 5,
  2518. }),
  2519. ])
  2520. );
  2521. });
  2522. it('update value', async function () {
  2523. renderTestComponent({
  2524. query: {displayType: 'line'},
  2525. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2526. });
  2527. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2528. userEvent.click(screen.getByText('Limit to 5 results'));
  2529. userEvent.click(screen.getByText('Limit to 2 results'));
  2530. await waitFor(() =>
  2531. expect(eventsStatsMock).toHaveBeenCalledWith(
  2532. '/organizations/org-slug/events-stats/',
  2533. expect.objectContaining({
  2534. query: expect.objectContaining({
  2535. query: '',
  2536. yAxis: ['count()'],
  2537. field: ['project', 'count()'],
  2538. topEvents: 2,
  2539. orderby: '-count()',
  2540. }),
  2541. })
  2542. )
  2543. );
  2544. });
  2545. it('gets removed if no groupBy value', async function () {
  2546. renderTestComponent({
  2547. query: {displayType: 'line'},
  2548. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2549. });
  2550. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2551. expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
  2552. userEvent.click(screen.getByLabelText('Remove group'));
  2553. await waitFor(() =>
  2554. expect(screen.queryByText('Limit to 5 results')).not.toBeInTheDocument()
  2555. );
  2556. });
  2557. it('applies a limit when switching from a table to timeseries chart with grouping', async function () {
  2558. const widget: Widget = {
  2559. displayType: DisplayType.TABLE,
  2560. interval: '1d',
  2561. queries: [
  2562. {
  2563. name: 'Test Widget',
  2564. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  2565. columns: ['project'],
  2566. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  2567. conditions: '',
  2568. orderby: '',
  2569. },
  2570. ],
  2571. title: 'Transactions',
  2572. id: '1',
  2573. };
  2574. const dashboard = mockDashboard({widgets: [widget]});
  2575. renderTestComponent({
  2576. dashboard,
  2577. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2578. params: {
  2579. widgetIndex: '0',
  2580. },
  2581. });
  2582. userEvent.click(await screen.findByText('Table'));
  2583. userEvent.click(screen.getByText('Line Chart'));
  2584. expect(screen.getByText('Limit to 3 results')).toBeInTheDocument();
  2585. expect(eventsStatsMock).toHaveBeenCalledWith(
  2586. '/organizations/org-slug/events-stats/',
  2587. expect.objectContaining({
  2588. query: expect.objectContaining({
  2589. topEvents: 3,
  2590. }),
  2591. })
  2592. );
  2593. });
  2594. it('persists the limit when switching between timeseries charts', async function () {
  2595. const widget: Widget = {
  2596. displayType: DisplayType.AREA,
  2597. interval: '1d',
  2598. queries: [
  2599. {
  2600. name: 'Test Widget',
  2601. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  2602. columns: ['project'],
  2603. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  2604. conditions: '',
  2605. orderby: '',
  2606. },
  2607. ],
  2608. title: 'Transactions',
  2609. id: '1',
  2610. limit: 1,
  2611. };
  2612. const dashboard = mockDashboard({widgets: [widget]});
  2613. renderTestComponent({
  2614. dashboard,
  2615. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2616. params: {
  2617. widgetIndex: '0',
  2618. },
  2619. });
  2620. userEvent.click(await screen.findByText('Area Chart'));
  2621. userEvent.click(screen.getByText('Line Chart'));
  2622. expect(screen.getByText('Limit to 1 result')).toBeInTheDocument();
  2623. expect(eventsStatsMock).toHaveBeenCalledWith(
  2624. '/organizations/org-slug/events-stats/',
  2625. expect.objectContaining({
  2626. query: expect.objectContaining({
  2627. topEvents: 1,
  2628. }),
  2629. })
  2630. );
  2631. });
  2632. it('unsets the limit when going from timeseries to table', async function () {
  2633. const widget: Widget = {
  2634. displayType: DisplayType.AREA,
  2635. interval: '1d',
  2636. queries: [
  2637. {
  2638. name: 'Test Widget',
  2639. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  2640. columns: ['project'],
  2641. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  2642. conditions: '',
  2643. orderby: '',
  2644. },
  2645. ],
  2646. title: 'Transactions',
  2647. id: '1',
  2648. limit: 1,
  2649. };
  2650. const dashboard = mockDashboard({widgets: [widget]});
  2651. renderTestComponent({
  2652. dashboard,
  2653. orgFeatures: [...defaultOrgFeatures, 'new-widget-builder-experience-design'],
  2654. params: {
  2655. widgetIndex: '0',
  2656. },
  2657. });
  2658. userEvent.click(await screen.findByText('Area Chart'));
  2659. userEvent.click(screen.getByText('Table'));
  2660. expect(screen.queryByText('Limit to 1 result')).not.toBeInTheDocument();
  2661. expect(eventsv2Mock).toHaveBeenCalledWith(
  2662. '/organizations/org-slug/eventsv2/',
  2663. expect.objectContaining({
  2664. query: expect.objectContaining({
  2665. topEvents: undefined,
  2666. }),
  2667. })
  2668. );
  2669. });
  2670. });
  2671. });
  2672. describe('with events', function () {
  2673. it('should properly query for table fields', async function () {
  2674. const defaultWidgetQuery = {
  2675. name: '',
  2676. fields: ['title', 'count()'],
  2677. columns: ['title'],
  2678. aggregates: ['count()'],
  2679. conditions: '',
  2680. orderby: '',
  2681. };
  2682. const defaultTableColumns = ['title', 'count()', 'count_unique(user)', 'epm()'];
  2683. renderTestComponent({
  2684. query: {
  2685. source: DashboardWidgetSource.DISCOVERV2,
  2686. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  2687. displayType: DisplayType.LINE,
  2688. defaultTableColumns,
  2689. },
  2690. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  2691. });
  2692. expect(await screen.findByText('Line Chart')).toBeInTheDocument();
  2693. userEvent.click(screen.getByText('Line Chart'));
  2694. userEvent.click(screen.getByText('Table'));
  2695. await waitFor(() => {
  2696. expect(eventsMock).toHaveBeenLastCalledWith(
  2697. '/organizations/org-slug/events/',
  2698. expect.objectContaining({
  2699. query: expect.objectContaining({
  2700. field: defaultTableColumns,
  2701. }),
  2702. })
  2703. );
  2704. });
  2705. });
  2706. describe('Sort by selectors', function () {
  2707. it('ordering by column uses field form when selecting orderby', async function () {
  2708. const widget: Widget = {
  2709. id: '1',
  2710. title: 'Test Widget',
  2711. interval: '5m',
  2712. displayType: DisplayType.TABLE,
  2713. queries: [
  2714. {
  2715. name: 'errors',
  2716. conditions: 'event.type:error',
  2717. fields: ['count()'],
  2718. aggregates: ['count()'],
  2719. columns: ['project'],
  2720. orderby: '-project',
  2721. },
  2722. ],
  2723. };
  2724. const dashboard = mockDashboard({widgets: [widget]});
  2725. renderTestComponent({
  2726. orgFeatures: [
  2727. ...defaultOrgFeatures,
  2728. 'new-widget-builder-experience-design',
  2729. 'discover-frontend-use-events-endpoint',
  2730. ],
  2731. dashboard,
  2732. params: {
  2733. widgetIndex: '0',
  2734. },
  2735. });
  2736. await waitFor(async () => {
  2737. expect(await screen.findAllByText('project')).toHaveLength(3);
  2738. });
  2739. await selectEvent.select(screen.getAllByText('project')[2], 'count()');
  2740. await waitFor(() => {
  2741. expect(eventsMock).toHaveBeenCalledWith(
  2742. '/organizations/org-slug/events/',
  2743. expect.objectContaining({
  2744. query: expect.objectContaining({
  2745. sort: ['-count()'],
  2746. }),
  2747. })
  2748. );
  2749. });
  2750. });
  2751. it('hides Custom Equation input and resets orderby when switching to table', async function () {
  2752. renderTestComponent({
  2753. orgFeatures: [
  2754. ...defaultOrgFeatures,
  2755. 'new-widget-builder-experience-design',
  2756. 'discover-frontend-use-events-endpoint',
  2757. ],
  2758. query: {
  2759. source: DashboardWidgetSource.DASHBOARDS,
  2760. displayType: DisplayType.LINE,
  2761. },
  2762. });
  2763. await selectEvent.select(await screen.findByText('Select group'), 'project');
  2764. expect(screen.getAllByText('count()')).toHaveLength(2);
  2765. await selectEvent.select(screen.getAllByText('count()')[1], 'Custom Equation');
  2766. userEvent.paste(
  2767. screen.getByPlaceholderText('Enter Equation'),
  2768. 'count_unique(user) * 2'
  2769. );
  2770. userEvent.keyboard('{enter}');
  2771. // Switch the display type to Table
  2772. userEvent.click(screen.getByText('Line Chart'));
  2773. userEvent.click(screen.getByText('Table'));
  2774. expect(screen.getAllByText('count()')).toHaveLength(2);
  2775. expect(screen.queryByPlaceholderText('Enter Equation')).not.toBeInTheDocument();
  2776. await waitFor(() => {
  2777. expect(eventsMock).toHaveBeenCalledWith(
  2778. '/organizations/org-slug/events/',
  2779. expect.objectContaining({
  2780. query: expect.objectContaining({
  2781. sort: ['-count()'],
  2782. }),
  2783. })
  2784. );
  2785. });
  2786. });
  2787. });
  2788. describe('Widget creation coming from other verticals', function () {
  2789. it('shows the correct orderby when switching from a line chart to table', async function () {
  2790. const defaultWidgetQuery = {
  2791. name: '',
  2792. fields: ['count_unique(user)'],
  2793. columns: [],
  2794. aggregates: ['count_unique(user)'],
  2795. conditions: '',
  2796. orderby: 'count_unique(user)',
  2797. };
  2798. const defaultTableColumns = ['title', 'count_unique(user)'];
  2799. renderTestComponent({
  2800. orgFeatures: [
  2801. ...defaultOrgFeatures,
  2802. 'new-widget-builder-experience-design',
  2803. 'discover-frontend-use-events-endpoint',
  2804. ],
  2805. query: {
  2806. source: DashboardWidgetSource.DISCOVERV2,
  2807. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  2808. displayType: DisplayType.LINE,
  2809. defaultTableColumns,
  2810. },
  2811. });
  2812. userEvent.click(await screen.findByText('Line Chart'));
  2813. userEvent.click(screen.getByText('Table'));
  2814. expect(screen.getByText('count_unique(user)')).toBeInTheDocument();
  2815. await waitFor(() => {
  2816. expect(eventsMock).toHaveBeenLastCalledWith(
  2817. '/organizations/org-slug/events/',
  2818. expect.objectContaining({
  2819. query: expect.objectContaining({
  2820. field: defaultTableColumns,
  2821. sort: ['count_unique(user)'],
  2822. }),
  2823. })
  2824. );
  2825. });
  2826. });
  2827. });
  2828. describe('Custom Performance Metrics', function () {
  2829. it('can choose a custom measurement', async function () {
  2830. measurementsMetaMock = MockApiClient.addMockResponse({
  2831. url: '/organizations/org-slug/measurements-meta/',
  2832. method: 'GET',
  2833. body: {'measurements.custom.measurement': {functions: ['p99']}},
  2834. });
  2835. eventsMock = MockApiClient.addMockResponse({
  2836. url: '/organizations/org-slug/events/',
  2837. method: 'GET',
  2838. statusCode: 200,
  2839. body: {
  2840. meta: {
  2841. fields: {'p99(measurements.total.db.calls)': 'duration'},
  2842. isMetricsData: true,
  2843. },
  2844. data: [{'p99(measurements.total.db.calls)': 10}],
  2845. },
  2846. });
  2847. const {router} = renderTestComponent({
  2848. query: {source: DashboardWidgetSource.DISCOVERV2},
  2849. dashboard: testDashboard,
  2850. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  2851. });
  2852. expect(await screen.findAllByText('Custom Widget')).toHaveLength(2);
  2853. // 1 in the table header, 1 in the column selector, 1 in the sort field
  2854. const countFields = screen.getAllByText('count()');
  2855. expect(countFields).toHaveLength(3);
  2856. await selectEvent.select(countFields[1], ['p99(…)']);
  2857. await selectEvent.select(screen.getByText('transaction.duration'), [
  2858. 'measurements.custom.measurement',
  2859. ]);
  2860. userEvent.click(screen.getByText('Add Widget'));
  2861. await waitFor(() => {
  2862. expect(router.push).toHaveBeenCalledWith(
  2863. expect.objectContaining({
  2864. pathname: '/organizations/org-slug/dashboard/2/',
  2865. query: {
  2866. displayType: 'table',
  2867. interval: '5m',
  2868. title: 'Custom Widget',
  2869. queryNames: [''],
  2870. queryConditions: [''],
  2871. queryFields: ['p99(measurements.custom.measurement)'],
  2872. queryOrderby: '-p99(measurements.custom.measurement)',
  2873. start: null,
  2874. end: null,
  2875. statsPeriod: '24h',
  2876. utc: null,
  2877. project: [],
  2878. environment: [],
  2879. },
  2880. })
  2881. );
  2882. });
  2883. });
  2884. it('raises an alert banner and disables saving widget if widget result is not metrics data and widget is using custom measurements', async function () {
  2885. eventsMock = MockApiClient.addMockResponse({
  2886. url: '/organizations/org-slug/events/',
  2887. method: 'GET',
  2888. statusCode: 200,
  2889. body: {
  2890. meta: {
  2891. fields: {'p99(measurements.custom.measurement)': 'duration'},
  2892. isMetricsData: false,
  2893. },
  2894. data: [{'p99(measurements.custom.measurement)': 10}],
  2895. },
  2896. });
  2897. const defaultWidgetQuery = {
  2898. name: '',
  2899. fields: ['p99(measurements.custom.measurement)'],
  2900. columns: [],
  2901. aggregates: ['p99(measurements.custom.measurement)'],
  2902. conditions: 'user:test.user@sentry.io',
  2903. orderby: '',
  2904. };
  2905. const defaultTableColumns = ['p99(measurements.custom.measurement)'];
  2906. renderTestComponent({
  2907. query: {
  2908. source: DashboardWidgetSource.DISCOVERV2,
  2909. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  2910. displayType: DisplayType.TABLE,
  2911. defaultTableColumns,
  2912. },
  2913. orgFeatures: [
  2914. ...defaultOrgFeatures,
  2915. 'discover-frontend-use-events-endpoint',
  2916. 'dashboards-mep',
  2917. ],
  2918. });
  2919. await waitFor(() => {
  2920. expect(measurementsMetaMock).toHaveBeenCalled();
  2921. });
  2922. await waitFor(() => {
  2923. expect(eventsMock).toHaveBeenCalled();
  2924. });
  2925. screen.getByText('You have inputs that are incompatible with');
  2926. expect(screen.getByText('Add Widget').closest('button')).toBeDisabled();
  2927. });
  2928. it('raises an alert banner if widget result is not metrics data', async function () {
  2929. eventsMock = MockApiClient.addMockResponse({
  2930. url: '/organizations/org-slug/events/',
  2931. method: 'GET',
  2932. statusCode: 200,
  2933. body: {
  2934. meta: {
  2935. fields: {'p99(measurements.lcp)': 'duration'},
  2936. isMetricsData: false,
  2937. },
  2938. data: [{'p99(measurements.lcp)': 10}],
  2939. },
  2940. });
  2941. const defaultWidgetQuery = {
  2942. name: '',
  2943. fields: ['p99(measurements.lcp)'],
  2944. columns: [],
  2945. aggregates: ['p99(measurements.lcp)'],
  2946. conditions: 'user:test.user@sentry.io',
  2947. orderby: '',
  2948. };
  2949. const defaultTableColumns = ['p99(measurements.lcp)'];
  2950. renderTestComponent({
  2951. query: {
  2952. source: DashboardWidgetSource.DISCOVERV2,
  2953. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  2954. displayType: DisplayType.TABLE,
  2955. defaultTableColumns,
  2956. },
  2957. orgFeatures: [
  2958. ...defaultOrgFeatures,
  2959. 'discover-frontend-use-events-endpoint',
  2960. 'dashboards-mep',
  2961. ],
  2962. });
  2963. await waitFor(() => {
  2964. expect(measurementsMetaMock).toHaveBeenCalled();
  2965. });
  2966. await waitFor(() => {
  2967. expect(eventsMock).toHaveBeenCalled();
  2968. });
  2969. screen.getByText('Your selection is only applicable to');
  2970. });
  2971. it('does not raise an alert banner if widget result is not metrics data but widget contains error fields', async function () {
  2972. eventsMock = MockApiClient.addMockResponse({
  2973. url: '/organizations/org-slug/events/',
  2974. method: 'GET',
  2975. statusCode: 200,
  2976. body: {
  2977. meta: {
  2978. fields: {'p99(measurements.lcp)': 'duration'},
  2979. isMetricsData: false,
  2980. },
  2981. data: [{'p99(measurements.lcp)': 10}],
  2982. },
  2983. });
  2984. const defaultWidgetQuery = {
  2985. name: '',
  2986. fields: ['p99(measurements.lcp)'],
  2987. columns: ['error.handled'],
  2988. aggregates: ['p99(measurements.lcp)'],
  2989. conditions: 'user:test.user@sentry.io',
  2990. orderby: '',
  2991. };
  2992. const defaultTableColumns = ['p99(measurements.lcp)'];
  2993. renderTestComponent({
  2994. query: {
  2995. source: DashboardWidgetSource.DISCOVERV2,
  2996. defaultWidgetQuery: urlEncode(defaultWidgetQuery),
  2997. displayType: DisplayType.TABLE,
  2998. defaultTableColumns,
  2999. },
  3000. orgFeatures: [
  3001. ...defaultOrgFeatures,
  3002. 'discover-frontend-use-events-endpoint',
  3003. 'dashboards-mep',
  3004. ],
  3005. });
  3006. await waitFor(() => {
  3007. expect(measurementsMetaMock).toHaveBeenCalled();
  3008. });
  3009. await waitFor(() => {
  3010. expect(eventsMock).toHaveBeenCalled();
  3011. });
  3012. expect(
  3013. screen.queryByText('Your selection is only applicable to')
  3014. ).not.toBeInTheDocument();
  3015. });
  3016. it('only displays custom measurements in supported functions', async function () {
  3017. measurementsMetaMock = MockApiClient.addMockResponse({
  3018. url: '/organizations/org-slug/measurements-meta/',
  3019. method: 'GET',
  3020. body: {
  3021. 'measurements.custom.measurement': {functions: ['p99']},
  3022. 'measurements.another.custom.measurement': {functions: ['p95']},
  3023. },
  3024. });
  3025. renderTestComponent({
  3026. query: {source: DashboardWidgetSource.DISCOVERV2},
  3027. dashboard: testDashboard,
  3028. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  3029. });
  3030. expect(await screen.findAllByText('Custom Widget')).toHaveLength(2);
  3031. await selectEvent.select(screen.getAllByText('count()')[1], ['p99(…)']);
  3032. userEvent.click(screen.getByText('transaction.duration'));
  3033. screen.getByText('measurements.custom.measurement');
  3034. expect(
  3035. screen.queryByText('measurements.another.custom.measurement')
  3036. ).not.toBeInTheDocument();
  3037. await selectEvent.select(screen.getAllByText('p99(…)')[0], ['p95(…)']);
  3038. userEvent.click(screen.getByText('transaction.duration'));
  3039. screen.getByText('measurements.another.custom.measurement');
  3040. expect(
  3041. screen.queryByText('measurements.custom.measurement')
  3042. ).not.toBeInTheDocument();
  3043. });
  3044. it('renders custom performance metric using duration units from events meta', async function () {
  3045. eventsMock = MockApiClient.addMockResponse({
  3046. url: '/organizations/org-slug/events/',
  3047. method: 'GET',
  3048. statusCode: 200,
  3049. body: {
  3050. meta: {
  3051. fields: {'p99(measurements.custom.measurement)': 'duration'},
  3052. isMetricsData: true,
  3053. units: {'p99(measurements.custom.measurement)': 'hour'},
  3054. },
  3055. data: [{'p99(measurements.custom.measurement)': 12}],
  3056. },
  3057. });
  3058. renderTestComponent({
  3059. query: {source: DashboardWidgetSource.DISCOVERV2},
  3060. dashboard: {
  3061. ...testDashboard,
  3062. widgets: [
  3063. {
  3064. title: 'Custom Measurement Widget',
  3065. interval: '1d',
  3066. id: '1',
  3067. widgetType: WidgetType.DISCOVER,
  3068. displayType: DisplayType.TABLE,
  3069. queries: [
  3070. {
  3071. conditions: '',
  3072. name: '',
  3073. fields: ['p99(measurements.custom.measurement)'],
  3074. columns: [],
  3075. aggregates: ['p99(measurements.custom.measurement)'],
  3076. orderby: '-p99(measurements.custom.measurement)',
  3077. },
  3078. ],
  3079. },
  3080. ],
  3081. },
  3082. params: {
  3083. widgetIndex: '0',
  3084. },
  3085. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  3086. });
  3087. await screen.findByText('12.00hr');
  3088. });
  3089. it('renders custom performance metric using size units from events meta', async function () {
  3090. eventsMock = MockApiClient.addMockResponse({
  3091. url: '/organizations/org-slug/events/',
  3092. method: 'GET',
  3093. statusCode: 200,
  3094. body: {
  3095. meta: {
  3096. fields: {'p99(measurements.custom.measurement)': 'size'},
  3097. isMetricsData: true,
  3098. units: {'p99(measurements.custom.measurement)': 'kibibyte'},
  3099. },
  3100. data: [{'p99(measurements.custom.measurement)': 12}],
  3101. },
  3102. });
  3103. renderTestComponent({
  3104. query: {source: DashboardWidgetSource.DISCOVERV2},
  3105. dashboard: {
  3106. ...testDashboard,
  3107. widgets: [
  3108. {
  3109. title: 'Custom Measurement Widget',
  3110. interval: '1d',
  3111. id: '1',
  3112. widgetType: WidgetType.DISCOVER,
  3113. displayType: DisplayType.TABLE,
  3114. queries: [
  3115. {
  3116. conditions: '',
  3117. name: '',
  3118. fields: ['p99(measurements.custom.measurement)'],
  3119. columns: [],
  3120. aggregates: ['p99(measurements.custom.measurement)'],
  3121. orderby: '-p99(measurements.custom.measurement)',
  3122. },
  3123. ],
  3124. },
  3125. ],
  3126. },
  3127. params: {
  3128. widgetIndex: '0',
  3129. },
  3130. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  3131. });
  3132. await screen.findByText('12.0 KiB');
  3133. });
  3134. it('renders custom performance metric using abyte format size units from events meta', async function () {
  3135. eventsMock = MockApiClient.addMockResponse({
  3136. url: '/organizations/org-slug/events/',
  3137. method: 'GET',
  3138. statusCode: 200,
  3139. body: {
  3140. meta: {
  3141. fields: {'p99(measurements.custom.measurement)': 'size'},
  3142. isMetricsData: true,
  3143. units: {'p99(measurements.custom.measurement)': 'kilobyte'},
  3144. },
  3145. data: [{'p99(measurements.custom.measurement)': 12000}],
  3146. },
  3147. });
  3148. renderTestComponent({
  3149. query: {source: DashboardWidgetSource.DISCOVERV2},
  3150. dashboard: {
  3151. ...testDashboard,
  3152. widgets: [
  3153. {
  3154. title: 'Custom Measurement Widget',
  3155. interval: '1d',
  3156. id: '1',
  3157. widgetType: WidgetType.DISCOVER,
  3158. displayType: DisplayType.TABLE,
  3159. queries: [
  3160. {
  3161. conditions: '',
  3162. name: '',
  3163. fields: ['p99(measurements.custom.measurement)'],
  3164. columns: [],
  3165. aggregates: ['p99(measurements.custom.measurement)'],
  3166. orderby: '-p99(measurements.custom.measurement)',
  3167. },
  3168. ],
  3169. },
  3170. ],
  3171. },
  3172. params: {
  3173. widgetIndex: '0',
  3174. },
  3175. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  3176. });
  3177. await screen.findByText('12 MB');
  3178. });
  3179. it('displays custom performance metric in column select', async function () {
  3180. renderTestComponent({
  3181. query: {source: DashboardWidgetSource.DISCOVERV2},
  3182. dashboard: {
  3183. ...testDashboard,
  3184. widgets: [
  3185. {
  3186. title: 'Custom Measurement Widget',
  3187. interval: '1d',
  3188. id: '1',
  3189. widgetType: WidgetType.DISCOVER,
  3190. displayType: DisplayType.TABLE,
  3191. queries: [
  3192. {
  3193. conditions: '',
  3194. name: '',
  3195. fields: ['p99(measurements.custom.measurement)'],
  3196. columns: [],
  3197. aggregates: ['p99(measurements.custom.measurement)'],
  3198. orderby: '-p99(measurements.custom.measurement)',
  3199. },
  3200. ],
  3201. },
  3202. ],
  3203. },
  3204. params: {
  3205. widgetIndex: '0',
  3206. },
  3207. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  3208. });
  3209. await screen.findByText('measurements.custom.measurement');
  3210. });
  3211. it('does not default to sorting by transaction when columns change', async function () {
  3212. renderTestComponent({
  3213. query: {source: DashboardWidgetSource.DISCOVERV2},
  3214. dashboard: {
  3215. ...testDashboard,
  3216. widgets: [
  3217. {
  3218. title: 'Custom Measurement Widget',
  3219. interval: '1d',
  3220. id: '1',
  3221. widgetType: WidgetType.DISCOVER,
  3222. displayType: DisplayType.TABLE,
  3223. queries: [
  3224. {
  3225. conditions: '',
  3226. name: '',
  3227. fields: [
  3228. 'p99(measurements.custom.measurement)',
  3229. 'transaction',
  3230. 'count()',
  3231. ],
  3232. columns: ['transaction'],
  3233. aggregates: ['p99(measurements.custom.measurement)', 'count()'],
  3234. orderby: '-p99(measurements.custom.measurement)',
  3235. },
  3236. ],
  3237. },
  3238. ],
  3239. },
  3240. params: {
  3241. widgetIndex: '0',
  3242. },
  3243. orgFeatures: [...defaultOrgFeatures, 'discover-frontend-use-events-endpoint'],
  3244. });
  3245. expect(
  3246. await screen.findByText('p99(measurements.custom.measurement)')
  3247. ).toBeInTheDocument();
  3248. // Delete p99(measurements.custom.measurement) column
  3249. userEvent.click(screen.getAllByLabelText('Remove column')[0]);
  3250. expect(
  3251. screen.queryByText('p99(measurements.custom.measurement)')
  3252. ).not.toBeInTheDocument();
  3253. expect(screen.getAllByText('transaction').length).toEqual(1);
  3254. expect(screen.getAllByText('count()').length).toEqual(2);
  3255. });
  3256. });
  3257. });
  3258. });