12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966 |
- import os.path
- import zipfile
- from base64 import b64encode
- from io import BytesIO
- from unittest.mock import patch
- from uuid import uuid4
- import pytest
- import responses
- from django.utils.encoding import force_bytes
- from sentry.models import (
- ArtifactBundle,
- DebugIdArtifactBundle,
- File,
- ProjectArtifactBundle,
- Release,
- ReleaseArtifactBundle,
- ReleaseFile,
- SourceFileType,
- )
- from sentry.models.releasefile import update_artifact_index
- from sentry.testutils import RelayStoreHelper
- from sentry.testutils.helpers.datetime import before_now, iso_format
- from sentry.testutils.skips import requires_symbolicator
- from sentry.utils import json
- # IMPORTANT:
- #
- # This test suite requires Symbolicator in order to run correctly.
- # Set `symbolicator.enabled: true` in your `~/.sentry/config.yml` and run `sentry devservices up`
- #
- # If you are using a local instance of Symbolicator, you need to either change `system.url-prefix` to `system.internal-url-prefix`
- # inside `process_with_symbolicator` fixture inside `src/sentry/utils/pytest/fixtures.py`,
- # or add `127.0.0.1 host.docker.internal` entry to your `/etc/hosts`
- BASE64_SOURCEMAP = "data:application/json;base64," + (
- b64encode(
- b'{"version":3,"file":"generated.js","sources":["/test.js"],"names":[],"mappings":"AAAA","sourcesContent":['
- b'"console.log(\\"hello, World!\\")"]}'
- )
- .decode("utf-8")
- .replace("\n", "")
- )
- INVALID_BASE64_SOURCEMAP = "data:application/json;base64,A"
- def get_fixture_path(name):
- return os.path.join(os.path.dirname(__file__), "fixtures", name)
- def load_fixture(name):
- with open(get_fixture_path(name), "rb") as fp:
- return fp.read()
- @pytest.mark.django_db(transaction=True)
- class TestJavascriptIntegration(RelayStoreHelper):
- @pytest.fixture(autouse=True)
- def initialize(self, default_projectkey, default_project):
- self.project = default_project
- self.projectkey = default_projectkey
- self.organization = self.project.organization
- self.min_ago = iso_format(before_now(minutes=1))
- # We disable scraping per-test when necessary.
- self.project.update_option("sentry:scrape_javascript", True)
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_adds_contexts_without_device(self, process_with_symbolicator):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "request": {
- "url": "http://example.com",
- "headers": [
- [
- "User-Agent",
- "Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) "
- "Chrome/28.0.1500.72 Safari/537.36",
- ]
- ],
- },
- }
- event = self.post_and_retrieve_event(data)
- contexts = event.interfaces["contexts"].to_json()
- assert contexts.get("os") == {"name": "Windows", "version": "8", "type": "os"}
- assert contexts.get("device") is None
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_adds_contexts_with_device(self, process_with_symbolicator):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "request": {
- "url": "http://example.com",
- "headers": [
- [
- "User-Agent",
- "Mozilla/5.0 (Linux; U; Android 4.3; en-us; SCH-R530U Build/JSS15J) AppleWebKit/534.30 ("
- "KHTML, like Gecko) Version/4.0 Mobile Safari/534.30 USCC-R530U",
- ]
- ],
- },
- }
- event = self.post_and_retrieve_event(data)
- contexts = event.interfaces["contexts"].to_json()
- assert contexts.get("os") == {"name": "Android", "type": "os", "version": "4.3"}
- assert contexts.get("browser") == {"name": "Android", "type": "browser", "version": "4.3"}
- assert contexts.get("device") == {
- "family": "Samsung SCH-R530U",
- "type": "device",
- "model": "SCH-R530U",
- "name": "Galaxy S3",
- "brand": "Samsung",
- }
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_adds_contexts_with_ps4_device(self, process_with_symbolicator):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "request": {
- "url": "http://example.com",
- "headers": [
- [
- "User-Agent",
- "Mozilla/5.0 (PlayStation 4 3.55) AppleWebKit/537.78 (KHTML, like Gecko)",
- ]
- ],
- },
- }
- event = self.post_and_retrieve_event(data)
- contexts = event.interfaces["contexts"].to_json()
- assert contexts.get("os") is None
- assert contexts.get("browser") is None
- assert contexts.get("device") == {
- "family": "PlayStation 4",
- "type": "device",
- "model": "PlayStation 4",
- "brand": "Sony",
- }
- @patch("sentry.lang.javascript.processor.Fetcher.fetch_by_url")
- def test_source_expansion(self, mock_fetch_by_url):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/foo.js",
- "filename": "foo.js",
- "lineno": 4,
- "colno": 0,
- },
- {
- "abs_path": "http://example.com/foo.js",
- "filename": "foo.js",
- "lineno": 1,
- "colno": 0,
- },
- ]
- },
- }
- ]
- },
- }
- mock_fetch_by_url.return_value.body = force_bytes("\n".join("hello world"))
- mock_fetch_by_url.return_value.encoding = None
- mock_fetch_by_url.return_value.headers = {}
- event = self.post_and_retrieve_event(data)
- mock_fetch_by_url.assert_called_once_with("http://example.com/foo.js")
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- assert frame.pre_context == ["h", "e", "l"]
- assert frame.context_line == "l"
- assert frame.post_context == ["o", " ", "w", "o", "r"]
- frame = frame_list[1]
- assert not frame.pre_context
- assert frame.context_line == "h"
- assert frame.post_context == ["e", "l", "l", "o", " "]
- # no source map means no raw_stacktrace
- assert exception.values[0].raw_stacktrace is None
- @patch("sentry.lang.javascript.processor.Fetcher.fetch_by_url")
- @patch("sentry.lang.javascript.processor.discover_sourcemap")
- def test_inlined_sources(self, mock_discover_sourcemap, mock_fetch_by_url):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/test.min.js",
- "filename": "test.js",
- "lineno": 1,
- "colno": 1,
- }
- ]
- },
- }
- ]
- },
- }
- mock_discover_sourcemap.return_value = BASE64_SOURCEMAP
- mock_fetch_by_url.return_value.url = "http://example.com/test.min.js"
- mock_fetch_by_url.return_value.body = force_bytes("\n".join("<generated source>"))
- mock_fetch_by_url.return_value.encoding = None
- event = self.post_and_retrieve_event(data)
- mock_fetch_by_url.assert_called_once_with("http://example.com/test.min.js")
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- assert not frame.pre_context
- assert frame.context_line == 'console.log("hello, World!")'
- assert not frame.post_context
- assert frame.data["sourcemap"] == "http://example.com/test.min.js"
- @patch("sentry.lang.javascript.processor.Fetcher.fetch_by_url")
- @patch("sentry.lang.javascript.processor.discover_sourcemap")
- def test_invalid_base64_sourcemap_returns_an_error(
- self, mock_discover_sourcemap, mock_fetch_by_url
- ):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/test.min.js",
- "filename": "test.js",
- "lineno": 1,
- "colno": 1,
- },
- ]
- },
- }
- ]
- },
- }
- mock_discover_sourcemap.return_value = INVALID_BASE64_SOURCEMAP
- mock_fetch_by_url.return_value.url = "http://example.com/test.min.js"
- mock_fetch_by_url.return_value.body = force_bytes("\n".join("<generated source>"))
- mock_fetch_by_url.return_value.encoding = None
- event = self.post_and_retrieve_event(data)
- mock_fetch_by_url.assert_called_once_with("http://example.com/test.min.js")
- assert len(event.data["errors"]) == 1
- assert event.data["errors"][0] == {
- "url": "<base64>",
- "reason": "Invalid base64-encoded string: "
- "number of data characters (1) cannot be 1 more than a multiple of 4",
- "type": "js_invalid_source",
- }
- @patch("sentry.lang.javascript.processor.SmCache.from_bytes")
- @patch("sentry.lang.javascript.processor.Fetcher.fetch_by_url")
- @patch("sentry.lang.javascript.processor.discover_sourcemap")
- def test_sourcemap_cache_is_constructed_only_once_if_an_error_is_raised(
- self, mock_discover_sourcemap, mock_fetch_by_url, mock_from_bytes
- ):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/test.min.js",
- "filename": "test.js",
- "lineno": 1,
- "colno": 1,
- },
- {
- "abs_path": "http://example.com/test.min.js",
- "filename": "test.js",
- "lineno": 1,
- "colno": 1,
- },
- {
- "abs_path": "http://example.com/test.min.js",
- "filename": "test.js",
- "lineno": 1,
- "colno": 1,
- },
- ]
- },
- }
- ]
- },
- }
- mock_discover_sourcemap.return_value = BASE64_SOURCEMAP
- mock_fetch_by_url.return_value.url = "http://example.com/test.min.js"
- mock_fetch_by_url.return_value.body = force_bytes("\n".join("<generated source>"))
- mock_fetch_by_url.return_value.encoding = None
- mock_from_bytes.side_effect = Exception()
- self.post_and_retrieve_event(data)
- mock_fetch_by_url.assert_called_once_with("http://example.com/test.min.js")
- mock_from_bytes.assert_called_once()
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_error_message_translations(self, process_with_symbolicator):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "logentry": {
- "formatted": "ReferenceError: Impossible de d\xe9finir une propri\xe9t\xe9 \xab foo \xbb : objet non "
- "extensible"
- },
- "exception": {
- "values": [
- {"type": "Error", "value": "P\u0159\xedli\u0161 mnoho soubor\u016f"},
- {
- "type": "Error",
- "value": "foo: wyst\u0105pi\u0142 nieoczekiwany b\u0142\u0105d podczas pr\xf3by uzyskania "
- "informacji o metadanych",
- },
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- message = event.interfaces["logentry"]
- assert (
- message.formatted
- == "ReferenceError: Cannot define property 'foo': object is not extensible"
- )
- exception = event.interfaces["exception"]
- assert exception.values[0].value == "Too many files"
- assert (
- exception.values[1].value
- == "foo: an unexpected failure occurred while trying to obtain metadata information"
- )
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_nonhandled_frames_inapp_normalization(self, process_with_symbolicator):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "node",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "native",
- "lineno": 1,
- "colno": 1,
- "in_app": True,
- },
- {
- "abs_path": "[native code]",
- "lineno": 1,
- "colno": 1,
- "in_app": True,
- },
- {
- "abs_path": "app://dist/bundle/file.min.js",
- "lineno": 1,
- "colno": 1,
- "in_app": True,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- exception = event.interfaces["exception"]
- if process_with_symbolicator:
- frame_list = exception.values[0].stacktrace.frames
- assert not frame_list[0].in_app # should be overwritten due to `native` abs_path
- assert not frame_list[1].in_app # should be overwritten due to `[native code]` abs_path
- assert frame_list[2].in_app # should not be touched and retain `in_app: true`
- raw_frame_list = exception.values[0].raw_stacktrace.frames
- # none of the raw frames should be altered
- assert raw_frame_list[0].in_app
- assert raw_frame_list[1].in_app
- assert raw_frame_list[2].in_app
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_sourcemap_source_expansion(self, process_with_symbolicator):
- self.project.update_option("sentry:scrape_javascript", False)
- release = Release.objects.create(
- organization_id=self.project.organization_id, version="abc"
- )
- release.add_project(self.project)
- for file in ["file.min.js", "file1.js", "file2.js", "file.sourcemap.js"]:
- with open(get_fixture_path(file), "rb") as f:
- f1 = File.objects.create(
- name=file,
- type="release.file",
- headers={},
- )
- f1.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f1.name}",
- release_id=release.id,
- organization_id=self.project.organization_id,
- file=f1,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- # NOTE: Intentionally source is not retrieved from this HTML file
- {
- "function": 'function: "HTMLDocument.<anonymous>"',
- "abs_path": "http//example.com/index.html",
- "filename": "index.html",
- "lineno": 283,
- "colno": 17,
- "in_app": False,
- },
- # NOTE: a mixed stack trace with a native frame:
- {
- "instruction_addr": "0xd10349",
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert event.data["errors"] == [
- {"type": "js_no_source", "url": "http//example.com/index.html"}
- ]
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- expected = "\treturn a + b; // fôo"
- assert frame.context_line == expected
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- raw_frame_list = exception.values[0].raw_stacktrace.frames
- raw_frame = raw_frame_list[0]
- assert not raw_frame.pre_context
- assert (
- raw_frame.context_line
- == 'function add(a,b){"use strict";return a+b}function multiply(a,b){"use strict";return a*b}function '
- 'divide(a,b){"use strict";try{return multip {snip}'
- )
- if process_with_symbolicator:
- assert raw_frame.post_context == ["//@ sourceMappingURL=file.sourcemap.js"]
- else:
- assert raw_frame.post_context == ["//@ sourceMappingURL=file.sourcemap.js", ""]
- assert raw_frame.lineno == 1
- # Since we couldn't expand source for the 2nd frame, both
- # its raw and original form should be identical
- assert raw_frame_list[1] == frame_list[1]
- # The second non-js frame should be untouched
- assert raw_frame_list[2] == frame_list[2]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_sourcemap_webpack(self, process_with_symbolicator):
- self.project.update_option("sentry:scrape_javascript", False)
- release = Release.objects.create(
- organization_id=self.project.organization_id, version="abc"
- )
- release.add_project(self.project)
- for file in [
- "webpack1.min.js",
- "webpack2.min.js",
- "webpack1.min.js.map",
- "webpack2.min.js.map",
- ]:
- with open(get_fixture_path(file), "rb") as f:
- f1 = File.objects.create(
- name=file,
- type="release.file",
- headers={},
- )
- f1.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f1.name}",
- release_id=release.id,
- organization_id=self.project.organization_id,
- file=f1,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/webpack1.min.js",
- "filename": "webpack1.min.js",
- "lineno": 1,
- "colno": 183,
- "function": "i",
- },
- {
- "abs_path": "http://example.com/webpack2.min.js",
- "filename": "webpack2.min.js",
- "lineno": 1,
- "colno": 183,
- "function": "i",
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- # The first frame should be in_app.
- first_frame = frame_list[0]
- assert first_frame.in_app
- assert first_frame.function == "test"
- assert first_frame.pre_context == [
- " cb(data);",
- " }",
- "",
- " function test() {",
- " var data = {failed: true, value: 42};",
- ]
- assert first_frame.context_line == " invoke(data);"
- if process_with_symbolicator:
- assert first_frame.post_context == [
- " }",
- "",
- " return test;",
- "})();",
- ]
- else:
- assert first_frame.post_context == [" }", "", " return test;", "})();", ""]
- # The second frame should be identical to the first, except not in_app.
- second_frame = frame_list[1]
- assert not second_frame.in_app
- assert second_frame.function == first_frame.function
- assert second_frame.context_line == first_frame.context_line
- assert second_frame.pre_context == first_frame.pre_context
- assert second_frame.post_context == first_frame.post_context
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_sourcemap_embedded_source_expansion(self, process_with_symbolicator):
- self.project.update_option("sentry:scrape_javascript", False)
- release = Release.objects.create(
- organization_id=self.project.organization_id, version="abc"
- )
- release.add_project(self.project)
- for file in ["embedded.js", "embedded.js.map"]:
- with open(get_fixture_path(file), "rb") as f:
- f1 = File.objects.create(
- name=file,
- type="release.file",
- headers={},
- )
- f1.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f1.name}",
- release_id=release.id,
- organization_id=self.project.organization_id,
- file=f1,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/embedded.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- # NOTE: Intentionally source is not retrieved from this HTML file
- {
- "function": 'function: "HTMLDocument.<anonymous>"',
- "abs_path": "http//example.com/index.html",
- "filename": "index.html",
- "lineno": 283,
- "colno": 17,
- "in_app": False,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert event.data["errors"] == [
- {"type": "js_no_source", "url": "http//example.com/index.html"}
- ]
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- expected = "\treturn a + b; // fôo"
- assert frame.context_line == expected
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_sourcemap_nofiles_source_expansion(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- with open(get_fixture_path("nofiles.js"), "rb") as f:
- f_minified = File.objects.create(
- name="nofiles.js", type="release.file", headers={"Content-Type": "application/json"}
- )
- f_minified.putfile(f)
- ReleaseFile.objects.create(
- name=f"~/{f_minified.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f_minified,
- )
- with open(get_fixture_path("nofiles.js.map"), "rb") as f:
- f_sourcemap = File.objects.create(
- name="nofiles.js.map",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f_sourcemap.putfile(f)
- ReleaseFile.objects.create(
- name=f"app:///{f_sourcemap.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f_sourcemap,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [{"abs_path": "app:///nofiles.js", "lineno": 1, "colno": 39}]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- assert len(frame_list) == 1
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.abs_path == "app:///nofiles.js"
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_indexed_sourcemap_source_expansion(self, process_with_symbolicator):
- self.project.update_option("sentry:scrape_javascript", False)
- release = Release.objects.create(
- organization_id=self.project.organization_id, version="abc"
- )
- release.add_project(self.project)
- for file in ["indexed.min.js", "file1.js", "file2.js", "indexed.sourcemap.js"]:
- with open(get_fixture_path(file), "rb") as f:
- f1 = File.objects.create(
- name=file,
- type="release.file",
- headers={},
- )
- f1.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f1.name}",
- release_id=release.id,
- organization_id=self.project.organization_id,
- file=f1,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/indexed.min.js",
- "filename": "indexed.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/indexed.min.js",
- "filename": "indexed.min.js",
- "lineno": 2,
- "colno": 44,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- expected = "\treturn a + b; // fôo"
- assert frame.context_line == expected
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- raw_frame_list = exception.values[0].raw_stacktrace.frames
- raw_frame = raw_frame_list[0]
- assert not raw_frame.pre_context
- assert raw_frame.context_line == 'function add(a,b){"use strict";return a+b}'
- if process_with_symbolicator:
- assert raw_frame.post_context == [
- 'function multiply(a,b){"use strict";return a*b}function divide(a,b){"use strict";try{return multiply('
- "add(a,b),a,b)/c}catch(e){Raven.captureE {snip}",
- "//# sourceMappingURL=indexed.sourcemap.js",
- ]
- else:
- assert raw_frame.post_context == [
- 'function multiply(a,b){"use strict";return a*b}function divide(a,b){"use strict";try{return multiply('
- "add(a,b),a,b)/c}catch(e){Raven.captureE {snip}",
- "//# sourceMappingURL=indexed.sourcemap.js",
- "",
- ]
- assert raw_frame.lineno == 1
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- raw_frame = raw_frame_list[1]
- assert raw_frame.pre_context == ['function add(a,b){"use strict";return a+b}']
- assert (
- raw_frame.context_line
- == 'function multiply(a,b){"use strict";return a*b}function divide(a,b){"use strict";try{return multiply('
- "add(a,b),a,b)/c}catch(e){Raven.captureE {snip}"
- )
- if process_with_symbolicator:
- assert raw_frame.post_context == ["//# sourceMappingURL=indexed.sourcemap.js"]
- else:
- assert raw_frame.post_context == ["//# sourceMappingURL=indexed.sourcemap.js", ""]
- assert raw_frame.lineno == 2
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_via_debug(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- # file.min.js
- # ------------
- with open(get_fixture_path("file.min.js"), "rb") as f:
- f_minified = File.objects.create(
- name="file.min.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f_minified.putfile(f)
- # Intentionally omit hostname - use alternate artifact path lookup instead
- # /file1.js vs http://example.com/file1.js
- ReleaseFile.objects.create(
- name=f"~/{f_minified.name}?foo=bar",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f_minified,
- )
- # file1.js
- # ---------
- with open(get_fixture_path("file1.js"), "rb") as f:
- f1 = File.objects.create(
- name="file1.js", type="release.file", headers={"Content-Type": "application/json"}
- )
- f1.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f1.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f1,
- )
- # file2.js
- # ----------
- with open(get_fixture_path("file2.js"), "rb") as f:
- f2 = File.objects.create(
- name="file2.js", type="release.file", headers={"Content-Type": "application/json"}
- )
- f2.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f2.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f2,
- )
- # To verify that the full url has priority over the relative url,
- # we will also add a second ReleaseFile alias for file2.js (f3) w/o
- # hostname that points to an empty file. If the processor chooses
- # this empty file over the correct file2.js, it will not locate
- # context for the 2nd frame.
- with open(get_fixture_path("empty.js"), "rb") as f:
- f2_empty = File.objects.create(
- name="empty.js", type="release.file", headers={"Content-Type": "application/json"}
- )
- f2_empty.putfile(f)
- ReleaseFile.objects.create(
- name=f"~/{f2.name}", # intentionally using f2.name ("file2.js")
- release_id=release.id,
- organization_id=project.organization_id,
- file=f2_empty,
- )
- # sourcemap
- # ----------
- with open(get_fixture_path("file.sourcemap.js"), "rb") as f:
- f_sourcemap = File.objects.create(
- name="file.sourcemap.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f_sourcemap.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f_sourcemap.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f_sourcemap,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js?foo=bar",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js?foo=bar",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_via_distribution_release_artifacts(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- dist = release.add_dist("foo")
- # file.min.js
- # ------------
- with open(get_fixture_path("file.min.js"), "rb") as f:
- f_minified = File.objects.create(
- name="file.min.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f_minified.putfile(f)
- # Intentionally omit hostname - use alternate artifact path lookup instead
- # /file1.js vs http://example.com/file1.js
- ReleaseFile.objects.create(
- name=f"~/{f_minified.name}?foo=bar",
- release_id=release.id,
- dist_id=dist.id,
- organization_id=project.organization_id,
- file=f_minified,
- )
- # file1.js
- # ---------
- with open(get_fixture_path("file1.js"), "rb") as f:
- f1 = File.objects.create(
- name="file1.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f1.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f1.name}",
- release_id=release.id,
- dist_id=dist.id,
- organization_id=project.organization_id,
- file=f1,
- )
- # file2.js
- # ----------
- with open(get_fixture_path("file2.js"), "rb") as f:
- f2 = File.objects.create(
- name="file2.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f2.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f2.name}",
- release_id=release.id,
- dist_id=dist.id,
- organization_id=project.organization_id,
- file=f2,
- )
- # To verify that the full url has priority over the relative url,
- # we will also add a second ReleaseFile alias for file2.js (f3) w/o
- # hostname that points to an empty file. If the processor chooses
- # this empty file over the correct file2.js, it will not locate
- # context for the 2nd frame.
- with open(get_fixture_path("empty.js"), "rb") as f:
- f2_empty = File.objects.create(
- name="empty.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f2_empty.putfile(f)
- ReleaseFile.objects.create(
- name=f"~/{f2.name}", # intentionally using f2.name ("file2.js")
- release_id=release.id,
- dist_id=dist.id,
- organization_id=project.organization_id,
- file=f2_empty,
- )
- # sourcemap
- # ----------
- with open(get_fixture_path("file.sourcemap.js"), "rb") as f:
- f_sourcemap = File.objects.create(
- name="file.sourcemap.js",
- type="release.file",
- headers={"Content-Type": "application/json"},
- )
- f_sourcemap.putfile(f)
- ReleaseFile.objects.create(
- name=f"http://example.com/{f_sourcemap.name}",
- release_id=release.id,
- dist_id=dist.id,
- organization_id=project.organization_id,
- file=f_sourcemap,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "dist": "foo",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js?foo=bar",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js?foo=bar",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- @responses.activate
- def test_sourcemap_expansion_with_missing_source(self):
- """
- Tests a successful sourcemap expansion that points to source files
- that are not found.
- """
- responses.add(
- responses.GET,
- "http://example.com/file.min.js",
- body=load_fixture("file.min.js"),
- content_type="application/javascript; charset=utf-8",
- )
- responses.add(
- responses.GET,
- "http://example.com/file.sourcemap.js",
- body=load_fixture("file.sourcemap.js"),
- content_type="application/json; charset=utf-8",
- )
- responses.add(responses.GET, "http://example.com/file1.js", body="Not Found", status=404)
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- # Add two frames. We only want to see the
- # error once though.
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert event.data["errors"] == [
- {"url": "http://example.com/file1.js", "type": "fetch_invalid_http_code", "value": 404}
- ]
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- # no context information ...
- assert not frame.pre_context
- assert not frame.context_line
- assert not frame.post_context
- # ... but line, column numbers are still correctly mapped
- assert frame.lineno == 3
- assert frame.colno == 9
- @responses.activate
- def test_failed_sourcemap_expansion(self):
- """
- Tests attempting to parse an indexed source map where each section has a "url"
- property - this is unsupported and should fail.
- """
- responses.add(
- responses.GET,
- "http://example.com/unsupported.min.js",
- body=load_fixture("unsupported.min.js"),
- content_type="application/javascript; charset=utf-8",
- )
- responses.add(
- responses.GET,
- "http://example.com/unsupported.sourcemap.js",
- body=load_fixture("unsupported.sourcemap.js"),
- content_type="application/json; charset=utf-8",
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/unsupported.min.js",
- "filename": "indexed.min.js",
- "lineno": 1,
- "colno": 39,
- }
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert event.data["errors"] == [
- {"url": "http://example.com/unsupported.sourcemap.js", "type": "js_invalid_source"}
- ]
- def test_failed_sourcemap_expansion_data_url(self):
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "data:application/javascript,base46,asfasf",
- "filename": "indexed.min.js",
- "lineno": 1,
- "colno": 39,
- }
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert event.data["errors"] == [{"url": "<data url>", "type": "js_no_source"}]
- @responses.activate
- def test_failed_sourcemap_expansion_missing_location_entirely(self):
- responses.add(
- responses.GET,
- "http://example.com/indexed.min.js",
- body="//# sourceMappingURL=indexed.sourcemap.js",
- )
- responses.add(responses.GET, "http://example.com/indexed.sourcemap.js", body="{}")
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/indexed.min.js",
- "filename": "indexed.min.js",
- "lineno": 1,
- "colno": 1,
- },
- {
- "abs_path": "http://example.com/indexed.min.js",
- "filename": "indexed.min.js",
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- @responses.activate
- def test_html_response_for_js(self):
- responses.add(
- responses.GET,
- "http://example.com/invalid_file1.js",
- body=" <!DOCTYPE html><html><head></head><body></body></html>",
- )
- responses.add(
- responses.GET,
- "http://example.com/invalid_file2.js",
- body="<!doctype html><html><head></head><body></body></html>",
- )
- responses.add(
- responses.GET,
- "http://example.com/valid_file.html",
- body=(
- "<!doctype html><html><head></head><body><script>/*legit case*/</script></body></html>"
- ),
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/invalid_file1.js",
- "filename": "invalid_file1.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/invalid_file2.js",
- "filename": "invalid_file2.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/valid_file.html",
- "filename": "valid_file.html",
- "lineno": 1,
- "colno": 1,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert event.data["errors"] == [
- {"url": "http://example.com/invalid_file1.js", "type": "js_invalid_content"},
- {"url": "http://example.com/invalid_file2.js", "type": "js_invalid_content"},
- ]
- def _test_expansion_via_release_archive(
- self, link_sourcemaps: bool, process_with_symbolicator: bool
- ):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- manifest = {
- "org": self.organization.slug,
- "release": release.version,
- "files": {
- "files/_/_/file.min.js": {
- "url": "http://example.com/file.min.js",
- "type": "minified_source",
- },
- "files/_/_/file1.js": {
- "url": "http://example.com/file1.js",
- "type": "source",
- },
- "files/_/_/file2.js": {
- "url": "http://example.com/file2.js",
- "type": "source",
- },
- "files/_/_/file.sourcemap.js": {
- "url": "http://example.com/file.sourcemap.js",
- "type": "source_map",
- },
- },
- }
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- for rel_path, entry in manifest["files"].items():
- name = os.path.basename(rel_path)
- content = load_fixture(name)
- if name == "file.min.js" and not link_sourcemaps:
- # Remove link to source map, add to header instead
- content = content.replace(b"//@ sourceMappingURL=file.sourcemap.js", b"")
- entry["headers"] = {"Sourcemap": "file.sourcemap.js"}
- zip_file.writestr(rel_path, content)
- zip_file.writestr("manifest.json", json.dumps(manifest))
- compressed.seek(0)
- file = File.objects.create(name="doesnt_matter", type="release.bundle")
- file.putfile(compressed)
- update_artifact_index(release, None, file)
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release-old"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_via_release_archive(self, process_with_symbolicator):
- self._test_expansion_via_release_archive(
- link_sourcemaps=True, process_with_symbolicator=process_with_symbolicator
- )
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_via_release_archive_no_sourcemap_link(self, process_with_symbolicator):
- self._test_expansion_via_release_archive(
- link_sourcemaps=False, process_with_symbolicator=process_with_symbolicator
- )
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_node_processing(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(
- organization_id=project.organization_id, version="nodeabc123"
- )
- release.add_project(project)
- with open(get_fixture_path("dist.bundle.js"), "rb") as f:
- f_minified = File.objects.create(
- name="dist.bundle.js",
- type="release.file",
- headers={"Content-Type": "application/javascript"},
- )
- f_minified.putfile(f)
- ReleaseFile.objects.create(
- name=f"~/{f_minified.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f_minified,
- )
- with open(get_fixture_path("dist.bundle.js.map"), "rb") as f:
- f_sourcemap = File.objects.create(
- name="dist.bundle.js.map",
- type="release.file",
- headers={"Content-Type": "application/javascript"},
- )
- f_sourcemap.putfile(f)
- ReleaseFile.objects.create(
- name=f"~/{f_sourcemap.name}",
- release_id=release.id,
- organization_id=project.organization_id,
- file=f_sourcemap,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "node",
- "release": "nodeabc123",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "filename": "app:///dist.bundle.js",
- "function": "bar",
- "lineno": 9,
- "colno": 2321,
- },
- {
- "filename": "app:///dist.bundle.js",
- "function": "foo",
- "lineno": 3,
- "colno": 2308,
- },
- {
- "filename": "app:///dist.bundle.js",
- "function": "App",
- "lineno": 3,
- "colno": 1011,
- },
- {
- "filename": "app:///dist.bundle.js",
- "function": "Object.<anonymous>",
- "lineno": 1,
- "colno": 1014,
- },
- {
- "filename": "app:///dist.bundle.js",
- "function": "__webpack_require__",
- "lineno": 20,
- "colno": 30,
- },
- {
- "filename": "app:///dist.bundle.js",
- "function": "<unknown>",
- "lineno": 18,
- "colno": 63,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- assert len(frame_list) == 6
- def assert_abs_path(abs_path):
- # This makes the test assertion forward compatible with percent-encoded URLs
- # See https://github.com/getsentry/symbolicator/pull/1137
- assert abs_path in (
- "webpack:///webpack/bootstrap d9a5a31d9276b73873d3",
- "webpack:///webpack/bootstrap%20d9a5a31d9276b73873d3",
- )
- assert_abs_path(frame_list[0].abs_path)
- assert frame_list[0].function == "bar"
- assert frame_list[0].lineno == 8
- assert_abs_path(frame_list[1].abs_path)
- assert frame_list[1].function == "foo"
- assert frame_list[1].lineno == 2
- assert_abs_path(frame_list[2].abs_path)
- assert frame_list[2].function == "App"
- assert frame_list[2].lineno == 2
- assert_abs_path(frame_list[3].abs_path)
- assert frame_list[3].function == "Object.<anonymous>"
- assert frame_list[3].lineno == 1
- assert_abs_path(frame_list[4].abs_path)
- assert frame_list[4].function == "__webpack_require__"
- assert frame_list[4].lineno == 19
- assert_abs_path(frame_list[5].abs_path)
- assert frame_list[5].function == "<unknown>"
- assert frame_list[5].lineno == 16
- @responses.activate
- def test_no_fetch_from_http(self):
- responses.add(
- responses.GET,
- "http://example.com/node_app.min.js",
- body=load_fixture("node_app.min.js"),
- content_type="application/javascript; charset=utf-8",
- )
- responses.add(
- responses.GET,
- "http://example.com/node_app.min.js.map",
- body=load_fixture("node_app.min.js.map"),
- content_type="application/javascript; charset=utf-8",
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "node",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "node_bootstrap.js",
- "filename": "node_bootstrap.js",
- "lineno": 1,
- "colno": 38,
- },
- {
- "abs_path": "timers.js",
- "filename": "timers.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "webpack:///internal",
- "filename": "internal",
- "lineno": 1,
- "colno": 43,
- },
- {
- "abs_path": "webpack:///~/some_dep/file.js",
- "filename": "file.js",
- "lineno": 1,
- "colno": 41,
- },
- {
- "abs_path": "webpack:///./node_modules/file.js",
- "filename": "file.js",
- "lineno": 1,
- "colno": 42,
- },
- {
- "abs_path": "http://example.com/node_app.min.js",
- "filename": "node_app.min.js",
- "lineno": 1,
- "colno": 40,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- # This one should not process, so this one should be none.
- assert exception.values[0].raw_stacktrace is None
- # None of the in app should update
- for x in range(6):
- assert not frame_list[x].in_app
- @responses.activate
- def test_html_file_with_query_param_ending_with_js_extension(self):
- responses.add(
- responses.GET,
- "http://example.com/file.html",
- body=(
- "<!doctype html><html><head></head><body><script>/*legit case*/</script></body></html>"
- ),
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.html?sw=iddqd1337.js",
- "filename": "file.html",
- "lineno": 1,
- "colno": 1,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- def test_expansion_with_allow_scraping_false(self):
- project = self.project
- project.organization.update_option("sentry:scrape_javascript", False)
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "1.0",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert len(event.data["errors"]) == 1
- assert event.data["errors"][0] == {
- "type": "js_scraping_disabled",
- "url": "http://example.com/file.min.js",
- }
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_debug_id(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
- zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
- zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
- zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
- zip_file.writestr(
- "files/_/_/file.wc.sourcemap.js", load_fixture("file.wc.sourcemap.js")
- )
- zip_file.writestr(
- "manifest.json",
- json.dumps(
- {
- "org": self.organization.slug,
- "release": release.version,
- "files": {
- "files/_/_/file.min.js": {
- "url": "~/file.min.js",
- "type": "minified_source",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- "sourcemap": "file.sourcemap.js",
- },
- },
- "files/_/_/file1.js": {
- "url": "~/file1.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file2.js": {
- "url": "~/file2.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/empty.js": {
- "url": "~/empty.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file.wc.sourcemap.js": {
- "url": "~/file.wc.sourcemap.js",
- "type": "source_map",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- },
- },
- },
- }
- ),
- )
- compressed.seek(0)
- file = File.objects.create(name="bundle.zip", type="artifact.bundle")
- file.putfile(compressed)
- # We want to also store the release files for this bundle, to check if they work together.
- compressed.seek(0)
- file_for_release = File.objects.create(name="bundle.zip", type="release.bundle")
- file_for_release.putfile(compressed)
- update_artifact_index(release, None, file_for_release)
- artifact_bundle = ArtifactBundle.objects.create(
- organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
- )
- ProjectArtifactBundle.objects.create(
- organization_id=self.organization.id,
- project_id=self.project.id,
- artifact_bundle=artifact_bundle,
- )
- DebugIdArtifactBundle.objects.create(
- organization_id=self.organization.id,
- debug_id=debug_id,
- artifact_bundle=artifact_bundle,
- source_file_type=SourceFileType.MINIFIED_SOURCE.value,
- )
- DebugIdArtifactBundle.objects.create(
- organization_id=self.organization.id,
- debug_id=debug_id,
- artifact_bundle=artifact_bundle,
- source_file_type=SourceFileType.SOURCE_MAP.value,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- # We want also to test the source without minification.
- {
- "abs_path": "http://example.com/file1.js",
- "filename": "file1.js",
- "lineno": 3,
- "colno": 12,
- },
- ]
- },
- }
- ]
- },
- "debug_meta": {
- "images": [
- {
- "type": "sourcemap",
- "debug_id": debug_id,
- "code_file": "http://example.com/file.min.js",
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "debug-id"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "debug-id"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- frame = frame_list[2]
- if process_with_symbolicator:
- assert "resolved_with" not in frame.data
- assert "symbolicated" not in frame.data
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_debug_id_and_sourcemap_without_sources_content(
- self, process_with_symbolicator
- ):
- debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
- zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
- zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
- zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
- zip_file.writestr("files/_/_/file.sourcemap.js", load_fixture("file.sourcemap.js"))
- zip_file.writestr(
- "manifest.json",
- json.dumps(
- {
- "files": {
- "files/_/_/file.min.js": {
- "url": "~/file.min.js",
- "type": "minified_source",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- "sourcemap": "file.sourcemap.js",
- },
- },
- "files/_/_/file1.js": {
- "url": "~/file1.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file2.js": {
- "url": "~/file2.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/empty.js": {
- "url": "~/empty.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file.sourcemap.js": {
- "url": "~/file.sourcemap.js",
- "type": "source_map",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- },
- },
- }
- }
- ),
- )
- compressed.seek(0)
- file = File.objects.create(name="bundle.zip", type="artifact.bundle")
- file.putfile(compressed)
- artifact_bundle = ArtifactBundle.objects.create(
- organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
- )
- ProjectArtifactBundle.objects.create(
- organization_id=self.organization.id,
- project_id=self.project.id,
- artifact_bundle=artifact_bundle,
- )
- DebugIdArtifactBundle.objects.create(
- organization_id=self.organization.id,
- debug_id=debug_id,
- artifact_bundle=artifact_bundle,
- source_file_type=SourceFileType.MINIFIED_SOURCE.value,
- )
- DebugIdArtifactBundle.objects.create(
- organization_id=self.organization.id,
- debug_id=debug_id,
- artifact_bundle=artifact_bundle,
- source_file_type=SourceFileType.SOURCE_MAP.value,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- "debug_meta": {
- "images": [
- {
- "type": "sourcemap",
- "debug_id": debug_id,
- "code_file": "http://example.com/file.min.js",
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- # NOTE: Symbolicator processor has a better fallback to pull specific files for source context
- if process_with_symbolicator:
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "debug-id"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "debug-id"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- else:
- assert len(event.data["errors"]) == 3
- assert event.data["errors"][0] == {
- "type": "js_missing_sources_content",
- "source": "http://example.com/file.min.js",
- "sourcemap": f"debug-id://{debug_id}/~/file.sourcemap.js",
- }
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_debug_id_and_malformed_sourcemap(self, process_with_symbolicator):
- debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
- zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
- zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
- zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
- zip_file.writestr(
- "files/_/_/file.malformed.sourcemap.js", load_fixture("file.malformed.sourcemap.js")
- )
- zip_file.writestr(
- "manifest.json",
- json.dumps(
- {
- "files": {
- "files/_/_/file.min.js": {
- "url": "~/file.min.js",
- "type": "minified_source",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- "sourcemap": "file.malformed.sourcemap.js",
- },
- },
- "files/_/_/file1.js": {
- "url": "~/file1.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file2.js": {
- "url": "~/file2.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/empty.js": {
- "url": "~/empty.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file.malformed.sourcemap.js": {
- "url": "~/file.malformed.sourcemap.js",
- "type": "source_map",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- },
- },
- }
- }
- ),
- )
- compressed.seek(0)
- file = File.objects.create(name="bundle.zip", type="artifact.bundle")
- file.putfile(compressed)
- artifact_bundle = ArtifactBundle.objects.create(
- organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
- )
- ProjectArtifactBundle.objects.create(
- organization_id=self.organization.id,
- project_id=self.project.id,
- artifact_bundle=artifact_bundle,
- )
- DebugIdArtifactBundle.objects.create(
- organization_id=self.organization.id,
- debug_id=debug_id,
- artifact_bundle=artifact_bundle,
- source_file_type=SourceFileType.MINIFIED_SOURCE.value,
- )
- DebugIdArtifactBundle.objects.create(
- organization_id=self.organization.id,
- debug_id=debug_id,
- artifact_bundle=artifact_bundle,
- source_file_type=SourceFileType.SOURCE_MAP.value,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- "debug_meta": {
- "images": [
- {
- "type": "sourcemap",
- "debug_id": debug_id,
- "code_file": "http://example.com/file.min.js",
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert len(event.data["errors"]) == 1
- # NOTE: Its not obvious what data we want here yet.
- if process_with_symbolicator:
- assert event.data["errors"][0] == {
- "type": "js_invalid_source",
- "url": "http://example.com/file.malformed.sourcemap.js",
- }
- else:
- assert event.data["errors"][0] == {
- "type": "js_invalid_source",
- "debug_id": f"debug-id://{debug_id}/~/file.malformed.sourcemap.js",
- }
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_debug_id_not_found(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- manifest = {
- "org": self.organization.slug,
- "release": release.version,
- "files": {
- "files/_/_/file.min.js": {
- "url": "http://example.com/file.min.js",
- "type": "minified_source",
- },
- "files/_/_/file1.js": {
- "url": "http://example.com/file1.js",
- "type": "source",
- },
- "files/_/_/file2.js": {
- "url": "http://example.com/file2.js",
- "type": "source",
- },
- "files/_/_/file.sourcemap.js": {
- "url": "http://example.com/file.sourcemap.js",
- "type": "source_map",
- },
- },
- }
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- for rel_path, entry in manifest["files"].items():
- name = os.path.basename(rel_path)
- content = load_fixture(name)
- if name == "file.min.js":
- # Remove link to source map, add to header instead
- content = content.replace(b"//@ sourceMappingURL=file.sourcemap.js", b"")
- entry["headers"] = {"Sourcemap": "file.sourcemap.js"}
- zip_file.writestr(rel_path, content)
- zip_file.writestr("manifest.json", json.dumps(manifest))
- compressed.seek(0)
- file = File.objects.create(name="release_bundle.zip", type="release.bundle")
- file.putfile(compressed)
- update_artifact_index(release, None, file)
- debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": "abc",
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- # We want also to test the source without minification.
- {
- "abs_path": "http://example.com/file1.js",
- "filename": "file1.js",
- "lineno": 3,
- "colno": 12,
- },
- ]
- },
- }
- ]
- },
- "debug_meta": {
- "images": [
- {
- "type": "sourcemap",
- "debug_id": debug_id,
- "code_file": "http://example.com/file.min.js",
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- frame = frame_list[2]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_release_dist_pair_x(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- dist = release.add_dist("android")
- # We want to also add debug_id information inside the manifest but not in the stack trace to replicate a
- # real edge case that we can incur in.
- debug_id = "c941d872-af1f-4f0c-a7ff-ad3d295fe153"
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
- zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
- zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
- zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
- zip_file.writestr(
- "files/_/_/file.wc.sourcemap.js", load_fixture("file.wc.sourcemap.js")
- )
- zip_file.writestr(
- "manifest.json",
- json.dumps(
- {
- "files": {
- "files/_/_/file.min.js": {
- "url": "~/file.min.js",
- "type": "minified_source",
- "headers": {
- "content-type": "application/json",
- "sourcemap": "file.wc.sourcemap.js",
- "debug-id": debug_id,
- },
- },
- "files/_/_/file1.js": {
- "url": "~/file1.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file2.js": {
- "url": "~/file2.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/empty.js": {
- "url": "~/empty.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file.wc.sourcemap.js": {
- "url": "~/file.wc.sourcemap.js",
- "type": "source_map",
- "headers": {
- "content-type": "application/json",
- "debug-id": debug_id,
- },
- },
- },
- }
- ),
- )
- compressed.seek(0)
- file = File.objects.create(name="bundle.zip", type="artifact.bundle")
- file.putfile(compressed)
- artifact_bundle = ArtifactBundle.objects.create(
- organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
- )
- ProjectArtifactBundle.objects.create(
- organization_id=self.organization.id,
- project_id=self.project.id,
- artifact_bundle=artifact_bundle,
- )
- ReleaseArtifactBundle.objects.create(
- organization_id=self.organization.id,
- release_name=release.version,
- dist_name=dist.name,
- artifact_bundle=artifact_bundle,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": release.version,
- "dist": dist.name,
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- # We want also to test the source without minification.
- {
- "abs_path": "http://example.com/file1.js",
- "filename": "file1.js",
- "lineno": 3,
- "colno": 12,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- frame = frame_list[2]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_release_dist_pair_and_sourcemap_without_sources_content(
- self, process_with_symbolicator
- ):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- dist = release.add_dist("android")
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
- zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
- zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
- zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
- zip_file.writestr("files/_/_/file.sourcemap.js", load_fixture("file.sourcemap.js"))
- zip_file.writestr(
- "manifest.json",
- json.dumps(
- {
- "files": {
- "files/_/_/file.min.js": {
- "url": "~/file.min.js",
- "type": "minified_source",
- "headers": {
- "content-type": "application/json",
- "sourcemap": "file.sourcemap.js",
- },
- },
- "files/_/_/file1.js": {
- "url": "~/file1.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file2.js": {
- "url": "~/file2.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/empty.js": {
- "url": "~/empty.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file.sourcemap.js": {
- "url": "~/file.sourcemap.js",
- "type": "source_map",
- "headers": {
- "content-type": "application/json",
- },
- },
- }
- }
- ),
- )
- compressed.seek(0)
- file = File.objects.create(name="bundle.zip", type="artifact.bundle")
- file.putfile(compressed)
- artifact_bundle = ArtifactBundle.objects.create(
- organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
- )
- ProjectArtifactBundle.objects.create(
- organization_id=self.organization.id,
- project_id=self.project.id,
- artifact_bundle=artifact_bundle,
- )
- ReleaseArtifactBundle.objects.create(
- organization_id=self.organization.id,
- release_name=release.version,
- dist_name=dist.name,
- artifact_bundle=artifact_bundle,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": release.version,
- "dist": dist.name,
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- # NOTE: Symbolicator processor has a better fallback to pull specific files for source context
- if process_with_symbolicator:
- assert "errors" not in event.data
- exception = event.interfaces["exception"]
- frame_list = exception.values[0].stacktrace.frames
- frame = frame_list[0]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function add(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a + b; // fôo"
- if process_with_symbolicator:
- assert frame.post_context == ["}"]
- else:
- assert frame.post_context == ["}", ""]
- frame = frame_list[1]
- if process_with_symbolicator:
- assert frame.data["resolved_with"] == "release"
- assert frame.data["symbolicated"]
- assert frame.pre_context == ["function multiply(a, b) {", '\t"use strict";']
- assert frame.context_line == "\treturn a * b;"
- assert frame.post_context == [
- "}",
- "function divide(a, b) {",
- '\t"use strict";',
- "\ttry {",
- "\t\treturn multiply(add(a, b), a, b) / c;",
- ]
- else:
- assert len(event.data["errors"]) == 3
- assert event.data["errors"][0] == {
- "type": "js_missing_sources_content",
- "source": "http://example.com/file.min.js",
- "sourcemap": "http://example.com/file.sourcemap.js",
- }
- @requires_symbolicator
- @pytest.mark.symbolicator
- def test_expansion_with_release_and_malformed_sourcemap(self, process_with_symbolicator):
- project = self.project
- release = Release.objects.create(organization_id=project.organization_id, version="abc")
- release.add_project(project)
- compressed = BytesIO(b"SYSB")
- with zipfile.ZipFile(compressed, "a") as zip_file:
- zip_file.writestr("files/_/_/file.min.js", load_fixture("file.min.js"))
- zip_file.writestr("files/_/_/file1.js", load_fixture("file1.js"))
- zip_file.writestr("files/_/_/file2.js", load_fixture("file2.js"))
- zip_file.writestr("files/_/_/empty.js", load_fixture("empty.js"))
- zip_file.writestr(
- "files/_/_/file.malformed.sourcemap.js", load_fixture("file.malformed.sourcemap.js")
- )
- zip_file.writestr(
- "manifest.json",
- json.dumps(
- {
- "files": {
- "files/_/_/file.min.js": {
- "url": "~/file.min.js",
- "type": "minified_source",
- "headers": {
- "content-type": "application/json",
- "sourcemap": "file.malformed.sourcemap.js",
- },
- },
- "files/_/_/file1.js": {
- "url": "~/file1.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file2.js": {
- "url": "~/file2.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/empty.js": {
- "url": "~/empty.js",
- "type": "source",
- "headers": {
- "content-type": "application/json",
- },
- },
- "files/_/_/file.malformed.sourcemap.js": {
- "url": "~/file.malformed.sourcemap.js",
- "type": "source_map",
- "headers": {
- "content-type": "application/json",
- },
- },
- }
- }
- ),
- )
- compressed.seek(0)
- file = File.objects.create(name="bundle.zip", type="artifact.bundle")
- file.putfile(compressed)
- artifact_bundle = ArtifactBundle.objects.create(
- organization_id=self.organization.id, bundle_id=uuid4(), file=file, artifact_count=5
- )
- ProjectArtifactBundle.objects.create(
- organization_id=self.organization.id,
- project_id=self.project.id,
- artifact_bundle=artifact_bundle,
- )
- ReleaseArtifactBundle.objects.create(
- organization_id=self.organization.id,
- release_name=release.version,
- artifact_bundle=artifact_bundle,
- )
- data = {
- "timestamp": self.min_ago,
- "message": "hello",
- "platform": "javascript",
- "release": release.version,
- "exception": {
- "values": [
- {
- "type": "Error",
- "stacktrace": {
- "frames": [
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 39,
- },
- {
- "abs_path": "http://example.com/file.min.js",
- "filename": "file.min.js",
- "lineno": 1,
- "colno": 79,
- },
- ]
- },
- }
- ]
- },
- }
- event = self.post_and_retrieve_event(data)
- assert len(event.data["errors"]) == 1
- assert event.data["errors"][0] == {
- "type": "js_invalid_source",
- "url": "http://example.com/file.malformed.sourcemap.js",
- }
|