assigneeSelector.spec.jsx 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377
  1. import {mountWithTheme} from 'sentry-test/enzyme';
  2. import {openInviteMembersModal} from 'app/actionCreators/modal';
  3. import {Client} from 'app/api';
  4. import AssigneeSelectorComponent, {
  5. putSessionUserFirst,
  6. } from 'app/components/assigneeSelector';
  7. import ConfigStore from 'app/stores/configStore';
  8. import GroupStore from 'app/stores/groupStore';
  9. import MemberListStore from 'app/stores/memberListStore';
  10. import ProjectsStore from 'app/stores/projectsStore';
  11. import TeamStore from 'app/stores/teamStore';
  12. jest.mock('app/actionCreators/modal', () => ({
  13. openInviteMembersModal: jest.fn(),
  14. }));
  15. describe('AssigneeSelector', function () {
  16. let assigneeSelector;
  17. let assignMock;
  18. let assignGroup2Mock;
  19. let openMenu;
  20. let USER_1, USER_2, USER_3;
  21. let TEAM_1;
  22. let PROJECT_1;
  23. let GROUP_1;
  24. let GROUP_2;
  25. beforeEach(function () {
  26. USER_1 = TestStubs.User({
  27. id: '1',
  28. name: 'Jane Bloggs',
  29. email: 'janebloggs@example.com',
  30. });
  31. USER_2 = TestStubs.User({
  32. id: '2',
  33. name: 'John Smith',
  34. email: 'johnsmith@example.com',
  35. });
  36. USER_3 = TestStubs.User({
  37. id: '3',
  38. name: 'J J',
  39. email: 'jj@example.com',
  40. });
  41. TEAM_1 = TestStubs.Team({
  42. id: '3',
  43. name: 'COOL TEAM',
  44. slug: 'cool-team',
  45. });
  46. PROJECT_1 = TestStubs.Project({
  47. teams: [TEAM_1],
  48. });
  49. GROUP_1 = TestStubs.Group({
  50. id: '1337',
  51. project: {
  52. id: PROJECT_1.id,
  53. slug: PROJECT_1.slug,
  54. },
  55. });
  56. GROUP_2 = TestStubs.Group({
  57. id: '1338',
  58. project: {
  59. id: PROJECT_1.id,
  60. slug: PROJECT_1.slug,
  61. },
  62. owners: [
  63. {
  64. type: 'suspectCommit',
  65. owner: 'user:1',
  66. date_added: '',
  67. },
  68. ],
  69. });
  70. jest.spyOn(MemberListStore, 'getAll').mockImplementation(() => null);
  71. jest.spyOn(TeamStore, 'getAll').mockImplementation(() => [TEAM_1]);
  72. jest.spyOn(ProjectsStore, 'getAll').mockImplementation(() => [PROJECT_1]);
  73. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_1);
  74. assignMock = Client.addMockResponse({
  75. method: 'PUT',
  76. url: `/issues/${GROUP_1.id}/`,
  77. body: {
  78. ...GROUP_1,
  79. assignedTo: USER_1,
  80. },
  81. });
  82. assignGroup2Mock = Client.addMockResponse({
  83. method: 'PUT',
  84. url: `/issues/${GROUP_2.id}/`,
  85. body: {
  86. ...GROUP_2,
  87. assignedTo: USER_1,
  88. },
  89. });
  90. MemberListStore.state = [];
  91. MemberListStore.loaded = false;
  92. assigneeSelector = mountWithTheme(
  93. <AssigneeSelectorComponent id={GROUP_1.id} />,
  94. TestStubs.routerContext()
  95. );
  96. openMenu = () => assigneeSelector.find('DropdownButton').simulate('click');
  97. });
  98. afterEach(function () {
  99. Client.clearMockResponses();
  100. });
  101. describe('render with props', function () {
  102. it('renders members from the prop when present', async function () {
  103. assigneeSelector = mountWithTheme(
  104. <AssigneeSelectorComponent id={GROUP_1.id} memberList={[USER_2, USER_3]} />,
  105. TestStubs.routerContext()
  106. );
  107. MemberListStore.loadInitialData([USER_1]);
  108. openMenu();
  109. assigneeSelector.update();
  110. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(0);
  111. expect(assigneeSelector.find('UserAvatar')).toHaveLength(2);
  112. expect(assigneeSelector.find('TeamAvatar')).toHaveLength(1);
  113. const names = assigneeSelector
  114. .find('MenuItemWrapper Label Highlight')
  115. .map(el => el.text());
  116. expect(names).toEqual([`#${TEAM_1.slug}`, USER_2.name, USER_3.name]);
  117. });
  118. });
  119. describe('putSessionUserFirst()', function () {
  120. it('should place the session user at the top of the member list if present', function () {
  121. jest.spyOn(ConfigStore, 'get').mockImplementation(() => ({
  122. id: '2',
  123. name: 'John Smith',
  124. email: 'johnsmith@example.com',
  125. }));
  126. expect(putSessionUserFirst([USER_1, USER_2])).toEqual([USER_2, USER_1]);
  127. ConfigStore.get.mockRestore();
  128. });
  129. it("should return the same member list if the session user isn't present", function () {
  130. jest.spyOn(ConfigStore, 'get').mockImplementation(() => ({
  131. id: '555',
  132. name: 'Here Comes a New Challenger',
  133. email: 'guile@mail.us.af.mil',
  134. }));
  135. expect(putSessionUserFirst([USER_1, USER_2])).toEqual([USER_1, USER_2]);
  136. ConfigStore.get.mockRestore();
  137. });
  138. });
  139. it('should initially have loading state', function () {
  140. openMenu();
  141. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(1);
  142. });
  143. it('does not have loading state and shows member list after calling MemberListStore.loadInitialData', async function () {
  144. openMenu();
  145. MemberListStore.loadInitialData([USER_1, USER_2]);
  146. assigneeSelector.update();
  147. expect(assigneeSelector.instance().assignableTeams()).toHaveLength(1);
  148. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(0);
  149. expect(assigneeSelector.find('UserAvatar')).toHaveLength(2);
  150. expect(assigneeSelector.find('TeamAvatar')).toHaveLength(1);
  151. });
  152. it('does NOT update member list after initial load', function () {
  153. openMenu();
  154. MemberListStore.loadInitialData([USER_1, USER_2]);
  155. assigneeSelector.update();
  156. expect(assigneeSelector.find('UserAvatar')).toHaveLength(2);
  157. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  158. MemberListStore.loadInitialData([USER_1, USER_2, USER_3]);
  159. assigneeSelector.update();
  160. expect(assigneeSelector.find('UserAvatar')).toHaveLength(2);
  161. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  162. });
  163. it('successfully assigns users', async function () {
  164. openMenu();
  165. MemberListStore.loadInitialData([USER_1, USER_2]);
  166. assigneeSelector.update();
  167. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  168. assigneeSelector.find('UserAvatar').first().simulate('click');
  169. expect(assignMock).toHaveBeenLastCalledWith(
  170. '/issues/1337/',
  171. expect.objectContaining({
  172. data: {assignedTo: 'user:1'},
  173. })
  174. );
  175. assigneeSelector.update();
  176. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(1);
  177. // Flakey with 1 tick
  178. await tick();
  179. await tick();
  180. assigneeSelector.update();
  181. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(0);
  182. expect(assigneeSelector.find('ActorAvatar')).toHaveLength(1);
  183. });
  184. it('successfully assigns teams', async function () {
  185. openMenu();
  186. MemberListStore.loadInitialData([USER_1, USER_2]);
  187. assigneeSelector.update();
  188. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  189. assigneeSelector.find('TeamAvatar').first().simulate('click');
  190. assigneeSelector.update();
  191. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(true);
  192. expect(assignMock).toHaveBeenCalledWith(
  193. '/issues/1337/',
  194. expect.objectContaining({
  195. data: {assignedTo: 'team:3'},
  196. })
  197. );
  198. // Flakey with 1 tick
  199. await tick();
  200. await tick();
  201. assigneeSelector.update();
  202. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  203. expect(assigneeSelector.find('ActorAvatar')).toHaveLength(1);
  204. });
  205. it('successfully clears assignment', async function () {
  206. openMenu();
  207. MemberListStore.loadInitialData([USER_1, USER_2]);
  208. // Assign first item in list, which is TEAM_1
  209. assigneeSelector.update();
  210. assigneeSelector.find('TeamAvatar').first().simulate('click');
  211. assigneeSelector.update();
  212. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(true);
  213. expect(assignMock).toHaveBeenCalledWith(
  214. '/issues/1337/',
  215. expect.objectContaining({
  216. data: {assignedTo: 'team:3'},
  217. })
  218. );
  219. // Waiting for assignment to finish updating
  220. // Flakey with 1 tick
  221. await tick();
  222. await tick();
  223. assigneeSelector.update();
  224. openMenu();
  225. assigneeSelector
  226. .find('MenuItemWrapper[data-test-id="clear-assignee"]')
  227. .simulate('click');
  228. // api was called with empty string, clearing assignment
  229. expect(assignMock).toHaveBeenLastCalledWith(
  230. '/issues/1337/',
  231. expect.objectContaining({
  232. data: {assignedTo: ''},
  233. })
  234. );
  235. });
  236. it('shows invite member button', async function () {
  237. jest.spyOn(ConfigStore, 'get').mockImplementation(() => true);
  238. openMenu();
  239. MemberListStore.loadInitialData([USER_1, USER_2]);
  240. assigneeSelector.update();
  241. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  242. assigneeSelector
  243. .find('InviteMemberLink[data-test-id="invite-member"]')
  244. .simulate('click');
  245. expect(openInviteMembersModal).toHaveBeenCalled();
  246. ConfigStore.get.mockRestore();
  247. });
  248. it('filters user by email and selects with keyboard', async function () {
  249. openMenu();
  250. MemberListStore.loadInitialData([USER_1, USER_2]);
  251. assigneeSelector.update();
  252. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  253. assigneeSelector
  254. .find('StyledInput')
  255. .simulate('change', {target: {value: 'JohnSmith@example.com'}});
  256. expect(assigneeSelector.find('UserAvatar')).toHaveLength(1);
  257. expect(assigneeSelector.find('UserAvatar').prop('user')).toEqual(USER_2);
  258. assigneeSelector.find('StyledInput').simulate('keyDown', {key: 'Enter'});
  259. assigneeSelector.update();
  260. expect(assignMock).toHaveBeenLastCalledWith(
  261. '/issues/1337/',
  262. expect.objectContaining({
  263. data: {assignedTo: 'user:2'},
  264. })
  265. );
  266. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(1);
  267. await tick();
  268. await tick();
  269. assigneeSelector.update();
  270. expect(assigneeSelector.find('LoadingIndicator')).toHaveLength(0);
  271. expect(assigneeSelector.find('ActorAvatar')).toHaveLength(1);
  272. });
  273. it('successfully shows suggested assignees', async function () {
  274. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_2);
  275. const onAssign = jest.fn();
  276. assigneeSelector = mountWithTheme(
  277. <AssigneeSelectorComponent id={GROUP_2.id} onAssign={onAssign} />,
  278. TestStubs.routerContext()
  279. );
  280. MemberListStore.loadInitialData([USER_1, USER_2, USER_3]);
  281. await tick();
  282. assigneeSelector.update();
  283. const avatarTooltip = mountWithTheme(assigneeSelector.find('Tooltip').prop('title'));
  284. expect(avatarTooltip.text()).toContain('Suggestion: Jane Bloggs');
  285. expect(avatarTooltip.text()).toContain('Based on commit data');
  286. openMenu();
  287. expect(assigneeSelector.find('LoadingIndicator').exists()).toBe(false);
  288. expect(assigneeSelector.find('SuggestedAvatarStack').exists()).toBe(true);
  289. expect(assigneeSelector.find('GroupHeader').first().text()).toEqual('Suggested');
  290. assigneeSelector.find('UserAvatar').at(1).simulate('click');
  291. assigneeSelector.update();
  292. expect(assignGroup2Mock).toHaveBeenCalledWith(
  293. '/issues/1338/',
  294. expect.objectContaining({
  295. data: {assignedTo: 'user:1'},
  296. })
  297. );
  298. // Suggested assignees shouldn't show anymore because we assigned to the suggested actor
  299. assigneeSelector.update();
  300. expect(assigneeSelector.find('SuggestedAvatarStack').exists()).toBe(false);
  301. expect(onAssign).toHaveBeenCalledWith(
  302. 'member',
  303. expect.objectContaining({id: '1'}),
  304. expect.objectContaining({id: '1'})
  305. );
  306. });
  307. it('renders unassigned', async function () {
  308. jest.spyOn(GroupStore, 'get').mockImplementation(() => GROUP_2);
  309. assigneeSelector = mountWithTheme(
  310. <AssigneeSelectorComponent id={GROUP_2.id} />,
  311. TestStubs.routerContext()
  312. );
  313. const avatarTooltip = mountWithTheme(assigneeSelector.find('Tooltip').prop('title'));
  314. expect(avatarTooltip.text()).toContain('Unassigned');
  315. });
  316. });