organizationMembersList.spec.tsx 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642
  1. import {browserHistory} from 'react-router';
  2. import selectEvent from 'react-select-event';
  3. import {
  4. render,
  5. renderGlobalModal,
  6. screen,
  7. userEvent,
  8. waitFor,
  9. within,
  10. } from 'sentry-test/reactTestingLibrary';
  11. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  12. import {setIntersectionObserver} from 'sentry/components/carousel.spec';
  13. import ConfigStore from 'sentry/stores/configStore';
  14. import OrganizationsStore from 'sentry/stores/organizationsStore';
  15. import {trackAnalytics} from 'sentry/utils/analytics';
  16. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  17. jest.mock('sentry/utils/analytics');
  18. jest.mock('sentry/api');
  19. jest.mock('sentry/actionCreators/indicator');
  20. const roles = [
  21. {
  22. id: 'admin',
  23. name: 'Admin',
  24. desc: 'This is the admin role',
  25. allowed: true,
  26. },
  27. {
  28. id: 'member',
  29. name: 'Member',
  30. desc: 'This is the member role',
  31. allowed: true,
  32. },
  33. {
  34. id: 'owner',
  35. name: 'Owner',
  36. desc: 'This is the owner role',
  37. allowed: true,
  38. },
  39. ];
  40. const missingMembers = [
  41. {
  42. integration: 'github',
  43. users: TestStubs.MissingMembers(),
  44. },
  45. ];
  46. describe('OrganizationMembersList', function () {
  47. const members = TestStubs.Members();
  48. const ownerTeam = TestStubs.Team({slug: 'owner-team', orgRole: 'owner'});
  49. const member = TestStubs.Member({
  50. id: '5',
  51. email: 'member@sentry.io',
  52. teams: [ownerTeam.slug],
  53. teamRoles: [
  54. {
  55. teamSlug: ownerTeam.slug,
  56. role: null,
  57. },
  58. ],
  59. flags: {
  60. 'sso:linked': true,
  61. },
  62. groupOrgRoles: [
  63. {
  64. teamSlug: ownerTeam.slug,
  65. role: {id: 'owner'},
  66. },
  67. ],
  68. });
  69. const currentUser = members[1];
  70. const organization = TestStubs.Organization({
  71. access: ['member:admin', 'org:admin', 'member:write'],
  72. status: {
  73. id: 'active',
  74. },
  75. });
  76. const router = TestStubs.router();
  77. const defaultProps = {
  78. organization,
  79. router,
  80. location: router.location,
  81. routes: router.routes,
  82. route: router.routes[0],
  83. params: router.params,
  84. routeParams: router.params,
  85. };
  86. jest.spyOn(ConfigStore, 'get').mockImplementation(() => currentUser);
  87. afterAll(function () {
  88. (ConfigStore.get as jest.Mock).mockRestore();
  89. });
  90. beforeEach(function () {
  91. MockApiClient.clearMockResponses();
  92. MockApiClient.addMockResponse({
  93. url: '/organizations/org-slug/members/me/',
  94. method: 'GET',
  95. body: {roles},
  96. });
  97. MockApiClient.addMockResponse({
  98. url: '/organizations/org-slug/members/',
  99. method: 'GET',
  100. body: [...TestStubs.Members(), member],
  101. });
  102. MockApiClient.addMockResponse({
  103. url: `/organizations/org-slug/members/${member.id}/`,
  104. body: member,
  105. });
  106. MockApiClient.addMockResponse({
  107. url: '/organizations/org-slug/access-requests/',
  108. method: 'GET',
  109. body: [
  110. {
  111. id: 'pending-id',
  112. member: {
  113. id: 'pending-member-id',
  114. email: '',
  115. name: '',
  116. role: '',
  117. roleName: '',
  118. user: {
  119. id: '',
  120. name: 'sentry@test.com',
  121. },
  122. },
  123. team: TestStubs.Team(),
  124. },
  125. ],
  126. });
  127. MockApiClient.addMockResponse({
  128. url: '/organizations/org-slug/auth-provider/',
  129. method: 'GET',
  130. body: {
  131. ...TestStubs.AuthProvider(),
  132. require_link: true,
  133. },
  134. });
  135. MockApiClient.addMockResponse({
  136. url: '/organizations/org-slug/teams/',
  137. method: 'GET',
  138. body: [TestStubs.Team(), ownerTeam],
  139. });
  140. MockApiClient.addMockResponse({
  141. url: '/organizations/org-slug/invite-requests/',
  142. method: 'GET',
  143. body: [],
  144. });
  145. MockApiClient.addMockResponse({
  146. url: '/organizations/org-slug/missing-members/',
  147. method: 'GET',
  148. body: [],
  149. });
  150. MockApiClient.addMockResponse({
  151. url: '/prompts-activity/',
  152. method: 'GET',
  153. body: {
  154. dismissed_ts: undefined,
  155. snoozed_ts: undefined,
  156. },
  157. });
  158. setIntersectionObserver([
  159. {target: {id: 'left-anchor'}, isIntersecting: true},
  160. {target: {id: 'right-anchor'}, isIntersecting: true},
  161. ]);
  162. (browserHistory.push as jest.Mock).mockReset();
  163. OrganizationsStore.load([organization]);
  164. });
  165. it('can remove a member', async function () {
  166. const deleteMock = MockApiClient.addMockResponse({
  167. url: `/organizations/org-slug/members/${members[0].id}/`,
  168. method: 'DELETE',
  169. });
  170. render(<OrganizationMembersList {...defaultProps} />, {
  171. context: TestStubs.routerContext([{organization}]),
  172. });
  173. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  174. renderGlobalModal();
  175. await userEvent.click(screen.getByTestId('confirm-button'));
  176. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  177. expect(deleteMock).toHaveBeenCalled();
  178. expect(browserHistory.push).not.toHaveBeenCalled();
  179. expect(OrganizationsStore.getAll()).toEqual([organization]);
  180. });
  181. it('displays error message when failing to remove member', async function () {
  182. const deleteMock = MockApiClient.addMockResponse({
  183. url: `/organizations/org-slug/members/${members[0].id}/`,
  184. method: 'DELETE',
  185. statusCode: 500,
  186. });
  187. render(<OrganizationMembersList {...defaultProps} />, {
  188. context: TestStubs.routerContext([{organization}]),
  189. });
  190. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  191. renderGlobalModal();
  192. await userEvent.click(screen.getByTestId('confirm-button'));
  193. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  194. expect(deleteMock).toHaveBeenCalled();
  195. expect(browserHistory.push).not.toHaveBeenCalled();
  196. expect(OrganizationsStore.getAll()).toEqual([organization]);
  197. });
  198. it('can leave org', async function () {
  199. const deleteMock = MockApiClient.addMockResponse({
  200. url: `/organizations/org-slug/members/${members[1].id}/`,
  201. method: 'DELETE',
  202. });
  203. render(<OrganizationMembersList {...defaultProps} />, {
  204. context: TestStubs.routerContext([{organization}]),
  205. });
  206. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  207. renderGlobalModal();
  208. await userEvent.click(screen.getByTestId('confirm-button'));
  209. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  210. expect(deleteMock).toHaveBeenCalled();
  211. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  212. expect(browserHistory.push).toHaveBeenCalledWith('/organizations/new/');
  213. });
  214. it('can redirect to remaining org after leaving', async function () {
  215. const deleteMock = MockApiClient.addMockResponse({
  216. url: `/organizations/org-slug/members/${members[1].id}/`,
  217. method: 'DELETE',
  218. });
  219. const secondOrg = TestStubs.Organization({
  220. slug: 'org-two',
  221. status: {
  222. id: 'active',
  223. },
  224. });
  225. OrganizationsStore.addOrReplace(secondOrg);
  226. render(<OrganizationMembersList {...defaultProps} />, {
  227. context: TestStubs.routerContext([{organization}]),
  228. });
  229. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  230. renderGlobalModal();
  231. await userEvent.click(screen.getByTestId('confirm-button'));
  232. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  233. expect(deleteMock).toHaveBeenCalled();
  234. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  235. expect(browserHistory.push).toHaveBeenCalledWith(
  236. `/organizations/${secondOrg.slug}/issues/`
  237. );
  238. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  239. });
  240. it('displays error message when failing to leave org', async function () {
  241. const deleteMock = MockApiClient.addMockResponse({
  242. url: `/organizations/org-slug/members/${members[1].id}/`,
  243. method: 'DELETE',
  244. statusCode: 500,
  245. });
  246. render(<OrganizationMembersList {...defaultProps} />, {
  247. context: TestStubs.routerContext([{organization}]),
  248. });
  249. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  250. renderGlobalModal();
  251. await userEvent.click(screen.getByTestId('confirm-button'));
  252. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  253. expect(deleteMock).toHaveBeenCalled();
  254. expect(browserHistory.push).not.toHaveBeenCalled();
  255. expect(OrganizationsStore.getAll()).toEqual([organization]);
  256. });
  257. it('can re-send SSO link to member', async function () {
  258. const inviteMock = MockApiClient.addMockResponse({
  259. url: `/organizations/org-slug/members/${members[0].id}/`,
  260. method: 'PUT',
  261. body: {
  262. id: '1234',
  263. },
  264. });
  265. render(<OrganizationMembersList {...defaultProps} />, {
  266. context: TestStubs.routerContext([{organization}]),
  267. });
  268. expect(inviteMock).not.toHaveBeenCalled();
  269. await userEvent.click(screen.getByRole('button', {name: 'Resend SSO link'}));
  270. expect(inviteMock).toHaveBeenCalled();
  271. });
  272. it('can re-send invite to member', async function () {
  273. const inviteMock = MockApiClient.addMockResponse({
  274. url: `/organizations/org-slug/members/${members[1].id}/`,
  275. method: 'PUT',
  276. body: {
  277. id: '1234',
  278. },
  279. });
  280. render(<OrganizationMembersList {...defaultProps} />, {
  281. context: TestStubs.routerContext([{organization}]),
  282. });
  283. expect(inviteMock).not.toHaveBeenCalled();
  284. await userEvent.click(screen.getByRole('button', {name: 'Resend invite'}));
  285. expect(inviteMock).toHaveBeenCalled();
  286. });
  287. it('can search organization members', async function () {
  288. const searchMock = MockApiClient.addMockResponse({
  289. url: '/organizations/org-slug/members/',
  290. body: [],
  291. });
  292. const routerContext = TestStubs.routerContext();
  293. render(<OrganizationMembersList {...defaultProps} />, {
  294. context: routerContext,
  295. });
  296. await userEvent.type(screen.getByPlaceholderText('Search Members'), 'member');
  297. expect(searchMock).toHaveBeenLastCalledWith(
  298. '/organizations/org-slug/members/',
  299. expect.objectContaining({
  300. method: 'GET',
  301. query: {
  302. query: 'member',
  303. },
  304. })
  305. );
  306. await userEvent.keyboard('{enter}');
  307. expect(routerContext.context.router.push).toHaveBeenCalledTimes(1);
  308. });
  309. it('can filter members', async function () {
  310. const searchMock = MockApiClient.addMockResponse({
  311. url: '/organizations/org-slug/members/',
  312. body: [],
  313. });
  314. const routerContext = TestStubs.routerContext();
  315. render(<OrganizationMembersList {...defaultProps} />, {
  316. context: routerContext,
  317. });
  318. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  319. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  320. expect(searchMock).toHaveBeenLastCalledWith(
  321. '/organizations/org-slug/members/',
  322. expect.objectContaining({
  323. method: 'GET',
  324. query: {query: 'role:member'},
  325. })
  326. );
  327. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  328. for (const [filter, label] of [
  329. ['isInvited', 'Invited'],
  330. ['has2fa', '2FA'],
  331. ['ssoLinked', 'SSO Linked'],
  332. ]) {
  333. const filterSection = screen.getByRole('listbox', {name: label});
  334. await userEvent.click(
  335. within(filterSection).getByRole('option', {
  336. name: 'True',
  337. })
  338. );
  339. expect(searchMock).toHaveBeenLastCalledWith(
  340. '/organizations/org-slug/members/',
  341. expect.objectContaining({
  342. method: 'GET',
  343. query: {query: `${filter}:true`},
  344. })
  345. );
  346. await userEvent.click(
  347. within(filterSection).getByRole('option', {
  348. name: 'False',
  349. })
  350. );
  351. expect(searchMock).toHaveBeenLastCalledWith(
  352. '/organizations/org-slug/members/',
  353. expect.objectContaining({
  354. method: 'GET',
  355. query: {query: `${filter}:false`},
  356. })
  357. );
  358. await userEvent.click(
  359. within(filterSection).getByRole('option', {
  360. name: 'All',
  361. })
  362. );
  363. }
  364. });
  365. it('can filter members with org roles from team membership', async function () {
  366. const routerContext = TestStubs.routerContext();
  367. render(<OrganizationMembersList {...defaultProps} />, {
  368. context: routerContext,
  369. });
  370. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  371. await userEvent.click(screen.getByRole('option', {name: 'Owner'}));
  372. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  373. const owners = screen.queryAllByText('Owner');
  374. expect(owners).toHaveLength(3);
  375. });
  376. describe('OrganizationInviteRequests', function () {
  377. const inviteRequest = TestStubs.Member({
  378. id: '123',
  379. user: null,
  380. inviteStatus: 'requested_to_be_invited',
  381. inviter: TestStubs.User(),
  382. role: 'member',
  383. teams: [],
  384. });
  385. const joinRequest = TestStubs.Member({
  386. id: '456',
  387. user: null,
  388. email: 'test@gmail.com',
  389. inviteStatus: 'requested_to_join',
  390. role: 'member',
  391. teams: [],
  392. });
  393. it('disable buttons for no access', function () {
  394. const org = TestStubs.Organization({
  395. status: {
  396. id: 'active',
  397. },
  398. });
  399. MockApiClient.addMockResponse({
  400. url: '/organizations/org-slug/invite-requests/',
  401. method: 'GET',
  402. body: [inviteRequest],
  403. });
  404. MockApiClient.addMockResponse({
  405. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  406. method: 'PUT',
  407. });
  408. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  409. context: TestStubs.routerContext([{organization: org}]),
  410. });
  411. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  412. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  413. });
  414. it('can approve invite request and update', async function () {
  415. const org = TestStubs.Organization({
  416. access: ['member:admin', 'org:admin', 'member:write'],
  417. status: {
  418. id: 'active',
  419. },
  420. });
  421. MockApiClient.addMockResponse({
  422. url: '/organizations/org-slug/invite-requests/',
  423. method: 'GET',
  424. body: [inviteRequest],
  425. });
  426. MockApiClient.addMockResponse({
  427. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  428. method: 'PUT',
  429. });
  430. render(<OrganizationMembersList {...defaultProps} />, {
  431. context: TestStubs.routerContext([{organization: org}]),
  432. });
  433. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  434. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  435. renderGlobalModal();
  436. await userEvent.click(screen.getByTestId('confirm-button'));
  437. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  438. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.approved', {
  439. invite_status: inviteRequest.inviteStatus,
  440. member_id: parseInt(inviteRequest.id, 10),
  441. organization: org,
  442. });
  443. });
  444. it('can deny invite request and remove', async function () {
  445. const org = TestStubs.Organization({
  446. access: ['member:admin', 'org:admin', 'member:write'],
  447. status: {
  448. id: 'active',
  449. },
  450. });
  451. MockApiClient.addMockResponse({
  452. url: '/organizations/org-slug/invite-requests/',
  453. method: 'GET',
  454. body: [joinRequest],
  455. });
  456. MockApiClient.addMockResponse({
  457. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  458. method: 'DELETE',
  459. });
  460. render(<OrganizationMembersList {...defaultProps} />, {
  461. context: TestStubs.routerContext([{organization: org}]),
  462. });
  463. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  464. await userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  465. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  466. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.denied', {
  467. invite_status: joinRequest.inviteStatus,
  468. member_id: parseInt(joinRequest.id, 10),
  469. organization: org,
  470. });
  471. });
  472. it('can update invite requests', async function () {
  473. const org = TestStubs.Organization({
  474. access: ['member:admin', 'org:admin', 'member:write'],
  475. status: {
  476. id: 'active',
  477. },
  478. });
  479. MockApiClient.addMockResponse({
  480. url: '/organizations/org-slug/invite-requests/',
  481. method: 'GET',
  482. body: [inviteRequest],
  483. });
  484. const updateWithApprove = MockApiClient.addMockResponse({
  485. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  486. method: 'PUT',
  487. });
  488. render(<OrganizationMembersList {...defaultProps} />, {
  489. context: TestStubs.routerContext([{organization: org}]),
  490. });
  491. await selectEvent.select(screen.getAllByRole('textbox')[1], ['Admin']);
  492. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  493. renderGlobalModal();
  494. await userEvent.click(screen.getByTestId('confirm-button'));
  495. expect(updateWithApprove).toHaveBeenCalledWith(
  496. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  497. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  498. );
  499. });
  500. });
  501. describe('inviteBanner', function () {
  502. it('invites member from banner', async function () {
  503. MockApiClient.addMockResponse({
  504. url: '/organizations/org-slug/missing-members/',
  505. method: 'GET',
  506. body: missingMembers,
  507. });
  508. const newMember = TestStubs.Member({
  509. id: '6',
  510. email: 'hello@sentry.io',
  511. teams: [],
  512. teamRoles: [],
  513. flags: {
  514. 'sso:linked': true,
  515. 'idp:provisioned': false,
  516. },
  517. });
  518. MockApiClient.addMockResponse({
  519. url: '/organizations/org-slug/members/',
  520. method: 'POST',
  521. body: newMember,
  522. });
  523. const org = TestStubs.Organization({
  524. features: ['integrations-gh-invite'],
  525. });
  526. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  527. context: TestStubs.routerContext([{organization: org}]),
  528. });
  529. expect(
  530. await screen.findByRole('heading', {
  531. name: 'Bring your full GitHub team on board in Sentry',
  532. })
  533. ).toBeInTheDocument();
  534. expect(screen.queryAllByTestId('invite-missing-member')).toHaveLength(5);
  535. expect(screen.getByText('See all 5 missing members')).toBeInTheDocument();
  536. const inviteButton = screen.queryAllByTestId('invite-missing-member')[0];
  537. await userEvent.click(inviteButton);
  538. expect(screen.queryAllByTestId('invite-missing-member')).toHaveLength(4);
  539. expect(screen.getByText('See all 4 missing members')).toBeInTheDocument();
  540. });
  541. });
  542. });