overview.actions.spec.tsx 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497
  1. import {Fragment} from 'react';
  2. import {GroupFixture} from 'sentry-fixture/group';
  3. import {GroupStatsFixture} from 'sentry-fixture/groupStats';
  4. import {OrganizationFixture} from 'sentry-fixture/organization';
  5. import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
  6. import {
  7. render,
  8. renderGlobalModal,
  9. screen,
  10. userEvent,
  11. waitFor,
  12. within,
  13. } from 'sentry-test/reactTestingLibrary';
  14. import Indicators from 'sentry/components/indicators';
  15. import GroupStore from 'sentry/stores/groupStore';
  16. import IssueListCacheStore from 'sentry/stores/IssueListCacheStore';
  17. import SelectedGroupStore from 'sentry/stores/selectedGroupStore';
  18. import TagStore from 'sentry/stores/tagStore';
  19. import {PriorityLevel} from 'sentry/types/group';
  20. import IssueListOverview from 'sentry/views/issueList/overview';
  21. const DEFAULT_LINKS_HEADER =
  22. '<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575731:0:1>; rel="previous"; results="false"; cursor="1443575731:0:1", ' +
  23. '<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575000:0:0>; rel="next"; results="true"; cursor="1443575000:0:0"';
  24. describe('IssueListOverview (actions)', function () {
  25. const groupStats = GroupStatsFixture();
  26. const organization = OrganizationFixture();
  27. beforeEach(function () {
  28. MockApiClient.clearMockResponses();
  29. GroupStore.reset();
  30. SelectedGroupStore.reset();
  31. IssueListCacheStore.reset();
  32. MockApiClient.addMockResponse({
  33. url: '/organizations/org-slug/issues-stats/',
  34. body: [groupStats],
  35. });
  36. MockApiClient.addMockResponse({
  37. url: '/organizations/org-slug/searches/',
  38. body: [],
  39. });
  40. MockApiClient.addMockResponse({
  41. url: '/organizations/org-slug/recent-searches/',
  42. body: [],
  43. });
  44. MockApiClient.addMockResponse({
  45. url: '/organizations/org-slug/recent-searches/',
  46. method: 'POST',
  47. body: [],
  48. });
  49. MockApiClient.addMockResponse({
  50. url: '/organizations/org-slug/issues-count/',
  51. method: 'GET',
  52. body: [{}],
  53. });
  54. MockApiClient.addMockResponse({
  55. url: '/organizations/org-slug/processingissues/',
  56. method: 'GET',
  57. body: [],
  58. });
  59. MockApiClient.addMockResponse({
  60. url: '/organizations/org-slug/tags/',
  61. method: 'GET',
  62. body: [],
  63. });
  64. MockApiClient.addMockResponse({
  65. url: '/organizations/org-slug/users/',
  66. method: 'GET',
  67. body: [],
  68. });
  69. MockApiClient.addMockResponse({
  70. url: '/organizations/org-slug/sent-first-event/',
  71. body: {sentFirstEvent: true},
  72. });
  73. MockApiClient.addMockResponse({
  74. url: '/organizations/org-slug/projects/',
  75. body: [],
  76. });
  77. TagStore.init?.();
  78. });
  79. const defaultProps = RouteComponentPropsFixture();
  80. describe('status', function () {
  81. const group1 = GroupFixture({
  82. id: '1',
  83. culprit: 'Group 1',
  84. shortId: 'JAVASCRIPT-1',
  85. });
  86. const group2 = GroupFixture({
  87. id: '2',
  88. culprit: 'Group 2',
  89. shortId: 'JAVASCRIPT-2',
  90. });
  91. const group3 = GroupFixture({
  92. id: '3',
  93. culprit: 'Group 3',
  94. shortId: 'JAVASCRIPT-3',
  95. });
  96. beforeEach(() => {
  97. MockApiClient.addMockResponse({
  98. url: '/organizations/org-slug/issues/',
  99. body: [group1, group2],
  100. headers: {Link: DEFAULT_LINKS_HEADER},
  101. });
  102. });
  103. it('removes issues after resolving', async function () {
  104. const updateIssueMock = MockApiClient.addMockResponse({
  105. url: '/organizations/org-slug/issues/',
  106. method: 'PUT',
  107. });
  108. render(<IssueListOverview {...defaultProps} />, {organization});
  109. const groups = await screen.findAllByTestId('group');
  110. await userEvent.click(
  111. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  112. );
  113. expect(screen.getByText('Group 1')).toBeInTheDocument();
  114. expect(screen.getByText('Group 2')).toBeInTheDocument();
  115. // After action, will refetch so need to mock that response
  116. MockApiClient.addMockResponse({
  117. url: '/organizations/org-slug/issues/',
  118. body: [group2],
  119. headers: {Link: DEFAULT_LINKS_HEADER},
  120. });
  121. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  122. expect(updateIssueMock).toHaveBeenCalledWith(
  123. '/organizations/org-slug/issues/',
  124. expect.objectContaining({
  125. query: expect.objectContaining({id: ['1']}),
  126. data: {status: 'resolved', statusDetails: {}, substatus: null},
  127. })
  128. );
  129. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  130. expect(screen.getByText('Group 2')).toBeInTheDocument();
  131. });
  132. it('refreshes after resolving all issues on page', async function () {
  133. const updateIssueMock = MockApiClient.addMockResponse({
  134. url: '/organizations/org-slug/issues/',
  135. method: 'PUT',
  136. });
  137. render(<IssueListOverview {...defaultProps} />, {
  138. organization,
  139. disableRouterMocks: true,
  140. initialRouterConfig: {
  141. route: '/organizations/:orgId/issues/',
  142. location: {
  143. pathname: '/organizations/org-slug/issues/',
  144. query: {query: 'is:unresolved'},
  145. },
  146. },
  147. });
  148. renderGlobalModal();
  149. await userEvent.click(screen.getByRole('checkbox', {name: /select all/i}));
  150. expect(screen.getByText('Group 1')).toBeInTheDocument();
  151. expect(screen.getByText('Group 2')).toBeInTheDocument();
  152. // After action, will refetch so need to mock that response
  153. MockApiClient.addMockResponse({
  154. url: '/organizations/org-slug/issues/',
  155. body: [group3],
  156. headers: {Link: DEFAULT_LINKS_HEADER},
  157. });
  158. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  159. const confirmationModal = await screen.findByRole('dialog');
  160. expect(
  161. within(confirmationModal).getByText(
  162. 'Are you sure you want to resolve these 2 issues?'
  163. )
  164. ).toBeInTheDocument();
  165. await userEvent.click(
  166. within(confirmationModal).getByRole('button', {name: 'Resolve 2 selected issues'})
  167. );
  168. await waitFor(() => {
  169. expect(updateIssueMock).toHaveBeenCalledWith(
  170. '/organizations/org-slug/issues/',
  171. expect.objectContaining({
  172. query: expect.objectContaining({id: ['1', '2']}),
  173. data: {status: 'resolved', statusDetails: {}, substatus: null},
  174. })
  175. );
  176. });
  177. // After refetch, should only see group 3
  178. expect(await screen.findByText('Group 3')).toBeInTheDocument();
  179. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  180. expect(screen.queryByText('Group 2')).not.toBeInTheDocument();
  181. });
  182. it('can undo resolve action', async function () {
  183. const updateIssueMock = MockApiClient.addMockResponse({
  184. url: '/organizations/org-slug/issues/',
  185. method: 'PUT',
  186. });
  187. render(
  188. <Fragment>
  189. <IssueListOverview {...defaultProps} />
  190. <Indicators />
  191. </Fragment>,
  192. {organization}
  193. );
  194. const groups = await screen.findAllByTestId('group');
  195. await userEvent.click(
  196. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  197. );
  198. expect(screen.getByText('Group 1')).toBeInTheDocument();
  199. expect(screen.getByText('Group 2')).toBeInTheDocument();
  200. // After action, will refetch so need to mock that response
  201. MockApiClient.addMockResponse({
  202. url: '/organizations/org-slug/issues/',
  203. body: [group2],
  204. headers: {Link: DEFAULT_LINKS_HEADER},
  205. });
  206. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  207. expect(updateIssueMock).toHaveBeenCalledWith(
  208. '/organizations/org-slug/issues/',
  209. expect.objectContaining({
  210. query: expect.objectContaining({id: ['1']}),
  211. data: {status: 'resolved', statusDetails: {}, substatus: null},
  212. })
  213. );
  214. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  215. expect(screen.getByText('Group 2')).toBeInTheDocument();
  216. // Should show a toast message
  217. expect(screen.getByText('Resolved JAVASCRIPT-1')).toBeInTheDocument();
  218. // Clicking the undo button makes a call to set the status back to unresolved
  219. MockApiClient.addMockResponse({
  220. url: '/organizations/org-slug/issues/',
  221. body: [group1, group2],
  222. headers: {Link: DEFAULT_LINKS_HEADER},
  223. });
  224. await userEvent.click(screen.getByRole('button', {name: 'Undo'}));
  225. expect(updateIssueMock).toHaveBeenLastCalledWith(
  226. '/organizations/org-slug/issues/',
  227. expect.objectContaining({
  228. query: expect.objectContaining({id: ['1']}),
  229. data: {status: 'unresolved', statusDetails: {}},
  230. })
  231. );
  232. expect(await screen.findByText('Group 1')).toBeInTheDocument();
  233. });
  234. });
  235. describe('mark reviewed', function () {
  236. const group1 = GroupFixture({
  237. id: '1',
  238. culprit: 'Group 1',
  239. shortId: 'JAVASCRIPT-1',
  240. inbox: {},
  241. });
  242. const group2 = GroupFixture({
  243. id: '2',
  244. culprit: 'Group 2',
  245. shortId: 'JAVASCRIPT-2',
  246. inbox: {},
  247. });
  248. beforeEach(() => {
  249. MockApiClient.addMockResponse({
  250. url: '/organizations/org-slug/issues/',
  251. body: [group1, group2],
  252. headers: {Link: DEFAULT_LINKS_HEADER},
  253. });
  254. });
  255. it('removes issues after making reviewed (when on for review tab)', async function () {
  256. const updateIssueMock = MockApiClient.addMockResponse({
  257. url: '/organizations/org-slug/issues/',
  258. method: 'PUT',
  259. });
  260. render(<IssueListOverview {...defaultProps} />, {
  261. organization,
  262. disableRouterMocks: true,
  263. initialRouterConfig: {
  264. route: '/organizations/:orgId/issues/',
  265. location: {
  266. pathname: '/organizations/org-slug/issues/',
  267. query: {query: 'is:for_review'},
  268. },
  269. },
  270. });
  271. const groups = await screen.findAllByTestId('group');
  272. await userEvent.click(
  273. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  274. );
  275. expect(screen.getByText('Group 1')).toBeInTheDocument();
  276. expect(screen.getByText('Group 2')).toBeInTheDocument();
  277. // After action, will refetch so need to mock that response
  278. MockApiClient.addMockResponse({
  279. url: '/organizations/org-slug/issues/',
  280. body: [group2],
  281. headers: {Link: DEFAULT_LINKS_HEADER},
  282. });
  283. await userEvent.click(
  284. await screen.findByRole('button', {name: 'More issue actions'})
  285. );
  286. await userEvent.click(screen.getByRole('menuitemradio', {name: 'Mark Reviewed'}));
  287. expect(updateIssueMock).toHaveBeenCalledWith(
  288. '/organizations/org-slug/issues/',
  289. expect.objectContaining({
  290. query: expect.objectContaining({id: ['1']}),
  291. data: {inbox: false},
  292. })
  293. );
  294. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  295. expect(screen.getByText('Group 2')).toBeInTheDocument();
  296. });
  297. });
  298. describe('priority', function () {
  299. const medPriorityGroup = GroupFixture({
  300. id: '1',
  301. priority: PriorityLevel.MEDIUM,
  302. culprit: 'Medium priority issue',
  303. });
  304. const highPriorityGroup = GroupFixture({
  305. id: '2',
  306. priority: PriorityLevel.HIGH,
  307. culprit: 'High priority issue',
  308. });
  309. beforeEach(() => {
  310. MockApiClient.addMockResponse({
  311. url: '/organizations/org-slug/issues/',
  312. body: [medPriorityGroup, highPriorityGroup],
  313. headers: {Link: DEFAULT_LINKS_HEADER},
  314. });
  315. });
  316. it('removes issues after bulk reprioritizing (when excluding priorities)', async function () {
  317. const updateIssueMock = MockApiClient.addMockResponse({
  318. url: '/organizations/org-slug/issues/',
  319. method: 'PUT',
  320. });
  321. render(<IssueListOverview {...defaultProps} />, {
  322. organization,
  323. disableRouterMocks: true,
  324. });
  325. const groups = await screen.findAllByTestId('group');
  326. await userEvent.click(
  327. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  328. );
  329. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  330. // After action, will refetch so need to mock that response
  331. MockApiClient.addMockResponse({
  332. url: '/organizations/org-slug/issues/',
  333. body: [highPriorityGroup],
  334. headers: {Link: DEFAULT_LINKS_HEADER},
  335. });
  336. await userEvent.click(await screen.findByRole('button', {name: /set priority/i}));
  337. await userEvent.click(screen.getByRole('menuitemradio', {name: /low/i}));
  338. expect(updateIssueMock).toHaveBeenCalledWith(
  339. '/organizations/org-slug/issues/',
  340. expect.objectContaining({
  341. query: expect.objectContaining({id: ['1']}),
  342. data: {priority: PriorityLevel.LOW},
  343. })
  344. );
  345. expect(screen.queryByText('Medium priority issue')).not.toBeInTheDocument();
  346. });
  347. it('removes issues after reprioritizing single issue (when excluding priorities)', async function () {
  348. MockApiClient.addMockResponse({
  349. url: '/organizations/org-slug/prompts-activity/',
  350. body: {data: {dismissed_ts: null}},
  351. });
  352. const updateIssueMock = MockApiClient.addMockResponse({
  353. url: '/organizations/org-slug/issues/',
  354. method: 'PUT',
  355. });
  356. render(<IssueListOverview {...defaultProps} />, {
  357. organization,
  358. disableRouterMocks: true,
  359. initialRouterConfig: {
  360. route: '/organizations/:orgId/issues/',
  361. location: {
  362. pathname: '/organizations/org-slug/issues/',
  363. query: {query: 'is:unresolved issue.priority:[medium,high]'},
  364. },
  365. },
  366. });
  367. expect(await screen.findByText('Medium priority issue')).toBeInTheDocument();
  368. // After action, will refetch so need to mock that response
  369. MockApiClient.addMockResponse({
  370. url: '/organizations/org-slug/issues/',
  371. body: [highPriorityGroup],
  372. headers: {Link: DEFAULT_LINKS_HEADER},
  373. });
  374. await userEvent.click(screen.getByText('Med'));
  375. await userEvent.click(screen.getByRole('menuitemradio', {name: 'Low'}));
  376. await waitFor(() => {
  377. expect(updateIssueMock).toHaveBeenCalledWith(
  378. '/organizations/org-slug/issues/',
  379. expect.objectContaining({
  380. query: expect.objectContaining({id: ['1']}),
  381. data: {priority: PriorityLevel.LOW},
  382. })
  383. );
  384. });
  385. expect(screen.queryByText('Medium priority issue')).not.toBeInTheDocument();
  386. });
  387. it('does not remove issues after bulk reprioritizing (when query includes all priorities)', async function () {
  388. const updateIssueMock = MockApiClient.addMockResponse({
  389. url: '/organizations/org-slug/issues/',
  390. method: 'PUT',
  391. });
  392. render(<IssueListOverview {...defaultProps} />, {
  393. organization,
  394. disableRouterMocks: true,
  395. initialRouterConfig: {
  396. route: '/organizations/:orgId/issues/',
  397. location: {
  398. pathname: '/organizations/org-slug/issues/',
  399. query: {query: 'is:unresolved issue.priority:[medium,high]'},
  400. },
  401. },
  402. });
  403. const groups = await screen.findAllByTestId('group');
  404. await userEvent.click(
  405. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  406. );
  407. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  408. await userEvent.click(await screen.findByRole('button', {name: /set priority/i}));
  409. await userEvent.click(screen.getByRole('menuitemradio', {name: /low/i}));
  410. expect(updateIssueMock).toHaveBeenCalledWith(
  411. '/organizations/org-slug/issues/',
  412. expect.objectContaining({
  413. query: expect.objectContaining({id: ['1']}),
  414. data: {priority: PriorityLevel.LOW},
  415. })
  416. );
  417. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  418. });
  419. });
  420. });