12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283 |
- import logging
- from collections.abc import MutableMapping
- from datetime import datetime, timezone
- import pytest
- import sentry_kafka_schemas
- from arroyo.backends.kafka import KafkaPayload
- from arroyo.processing.strategies.decoder.json import JsonCodec
- from arroyo.types import BrokerValue, Message, Partition, Topic, Value
- from sentry.sentry_metrics.configuration import UseCaseKey
- from sentry.sentry_metrics.consumers.indexer.batch import IndexerBatch, PartitionIdxOffset
- from sentry.sentry_metrics.indexer.base import FetchType, FetchTypeExt, Metadata
- from sentry.snuba.metrics.naming_layer.mri import SessionMRI
- from sentry.utils import json
- pytestmark = pytest.mark.sentry_metrics
- ts = int(datetime.now(tz=timezone.utc).timestamp())
- counter_payload = {
- "name": SessionMRI.SESSION.value,
- "tags": {
- "environment": "production",
- "session.status": "init",
- },
- "timestamp": ts,
- "type": "c",
- "value": 1,
- "org_id": 1,
- "retention_days": 90,
- "project_id": 3,
- }
- distribution_payload = {
- "name": SessionMRI.RAW_DURATION.value,
- "tags": {
- "environment": "production",
- "session.status": "healthy",
- },
- "timestamp": ts,
- "type": "d",
- "value": [4, 5, 6],
- "org_id": 1,
- "retention_days": 90,
- "project_id": 3,
- }
- set_payload = {
- "name": SessionMRI.ERROR.value,
- "tags": {
- "environment": "production",
- "session.status": "errored",
- },
- "timestamp": ts,
- "type": "s",
- "value": [3],
- "org_id": 1,
- "retention_days": 90,
- "project_id": 3,
- }
- extracted_string_output = {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- _INGEST_SCHEMA = JsonCodec(sentry_kafka_schemas.get_schema("ingest-metrics")["schema"])
- def _construct_messages(payloads):
- message_batch = []
- for i, (payload, headers) in enumerate(payloads):
- message_batch.append(
- Message(
- BrokerValue(
- KafkaPayload(None, json.dumps(payload).encode("utf-8"), headers or []),
- Partition(Topic("topic"), 0),
- i,
- datetime.now(),
- )
- )
- )
- return message_batch
- def _construct_outer_message(payloads):
- message_batch = _construct_messages(payloads)
- # the outer message uses the last message's partition, offset, and timestamp
- last = message_batch[-1]
- outer_message = Message(Value(message_batch, last.committable))
- return outer_message
- def _deconstruct_messages(snuba_messages, kafka_logical_topic="snuba-metrics"):
- """
- Convert a list of messages returned by `reconstruct_messages` into python
- primitives, to run assertions on:
- assert _deconstruct_messages(batch.reconstruct_messages(...)) == [ ... ]
- This is slightly nicer to work with than:
- assert batch.reconstruct_messages(...) == _construct_messages([ ... ])
- ...because pytest's assertion diffs work better with python primitives.
- """
- rv = []
- codec = JsonCodec(sentry_kafka_schemas.get_schema(kafka_logical_topic)["schema"])
- for msg in snuba_messages:
- decoded = json.loads(msg.payload.value.decode("utf-8"))
- codec.validate(decoded)
- rv.append((decoded, msg.payload.headers))
- return rv
- def _deconstruct_routing_messages(snuba_messages):
- """
- Similar to `_deconstruct_messages`, but for routing messages.
- """
- all_messages = []
- for msg in snuba_messages:
- headers: MutableMapping[str, str] = {}
- for key, value in msg.payload.routing_header.items():
- headers.update({key: value})
- payload = json.loads(msg.payload.routing_message.value.decode("utf-8"))
- all_messages.append((headers, payload, msg.payload.routing_message.headers))
- return all_messages
- def _get_string_indexer_log_records(caplog):
- """
- Get all log records and relevant extra arguments for easy snapshotting.
- """
- return [
- (
- rec.message,
- {
- k: v
- for k, v in rec.__dict__.items()
- if k
- in (
- "string_type",
- "is_global_quota",
- "num_global_quotas",
- "num_global_quotas",
- "org_batch_size",
- )
- },
- )
- for rec in caplog.records
- ]
- @pytest.mark.parametrize(
- "should_index_tag_values, expected",
- [
- pytest.param(
- True,
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- },
- },
- id="index tag values true",
- ),
- pytest.param(
- False,
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "s:sessions/error@none",
- "session.status",
- },
- },
- id="index tag values false",
- ),
- ],
- )
- def test_extract_strings_with_rollout(should_index_tag_values, expected):
- """
- Test that the indexer batch extracts the correct strings from the messages
- based on whether tag values should be indexed or not.
- """
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- should_index_tag_values,
- False,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- assert batch.extract_strings() == expected
- def test_all_resolved(caplog, settings):
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- True,
- False,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "d:sessions/duration@second": 2,
- "environment": 3,
- "errored": 4,
- "healthy": 5,
- "init": 6,
- "production": 7,
- "s:sessions/error@none": 8,
- "session.status": 9,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "d:sessions/duration@second": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "errored": Metadata(id=4, fetch_type=FetchType.DB_READ),
- "healthy": Metadata(id=5, fetch_type=FetchType.HARDCODED),
- "init": Metadata(id=6, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=7, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=8, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=9, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _get_string_indexer_log_records(caplog) == []
- assert _deconstruct_messages(snuba_payloads) == [
- (
- {
- "mapping_meta": {
- "c": {
- "1": "c:sessions/session@none",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"6": "init"},
- },
- "metric_id": 1,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 6},
- "timestamp": ts,
- "type": "c",
- "use_case_id": "performance",
- "value": 1.0,
- },
- [("mapping_sources", b"ch"), ("metric_type", "c")],
- ),
- (
- {
- "mapping_meta": {
- "c": {
- "2": "d:sessions/duration@second",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"5": "healthy"},
- },
- "metric_id": 2,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 5},
- "timestamp": ts,
- "type": "d",
- "use_case_id": "performance",
- "value": [4, 5, 6],
- },
- [("mapping_sources", b"ch"), ("metric_type", "d")],
- ),
- (
- {
- "mapping_meta": {
- "c": {
- "3": "environment",
- "7": "production",
- "8": "s:sessions/error@none",
- "9": "session.status",
- },
- "d": {"4": "errored"},
- },
- "metric_id": 8,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 4},
- "timestamp": ts,
- "type": "s",
- "use_case_id": "performance",
- "value": [3],
- },
- [("mapping_sources", b"cd"), ("metric_type", "s")],
- ),
- ]
- def test_all_resolved_with_routing_information(caplog, settings):
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- True,
- True,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "d:sessions/duration@second": 2,
- "environment": 3,
- "errored": 4,
- "healthy": 5,
- "init": 6,
- "production": 7,
- "s:sessions/error@none": 8,
- "session.status": 9,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "d:sessions/duration@second": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "errored": Metadata(id=4, fetch_type=FetchType.DB_READ),
- "healthy": Metadata(id=5, fetch_type=FetchType.HARDCODED),
- "init": Metadata(id=6, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=7, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=8, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=9, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _get_string_indexer_log_records(caplog) == []
- assert _deconstruct_routing_messages(snuba_payloads) == [
- (
- {"org_id": 1},
- {
- "mapping_meta": {
- "c": {
- "1": "c:sessions/session@none",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"6": "init"},
- },
- "metric_id": 1,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 6},
- "timestamp": ts,
- "type": "c",
- "use_case_id": "performance",
- "value": 1.0,
- },
- [("mapping_sources", b"ch"), ("metric_type", "c")],
- ),
- (
- {"org_id": 1},
- {
- "mapping_meta": {
- "c": {
- "2": "d:sessions/duration@second",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"5": "healthy"},
- },
- "metric_id": 2,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 5},
- "timestamp": ts,
- "type": "d",
- "use_case_id": "performance",
- "value": [4, 5, 6],
- },
- [("mapping_sources", b"ch"), ("metric_type", "d")],
- ),
- (
- {"org_id": 1},
- {
- "mapping_meta": {
- "c": {
- "3": "environment",
- "7": "production",
- "8": "s:sessions/error@none",
- "9": "session.status",
- },
- "d": {"4": "errored"},
- },
- "metric_id": 8,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 4},
- "timestamp": ts,
- "type": "s",
- "use_case_id": "performance",
- "value": [3],
- },
- [("mapping_sources", b"cd"), ("metric_type", "s")],
- ),
- ]
- def test_all_resolved_retention_days_honored(caplog, settings):
- """
- Tests that the indexer batch honors the incoming retention_days values
- from Relay or falls back to 90.
- """
- distribution_payload_modified = distribution_payload.copy()
- distribution_payload_modified["retention_days"] = 30
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload_modified, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- True,
- False,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "d:sessions/duration@second": 2,
- "environment": 3,
- "errored": 4,
- "healthy": 5,
- "init": 6,
- "production": 7,
- "s:sessions/error@none": 8,
- "session.status": 9,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "d:sessions/duration@second": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "errored": Metadata(id=4, fetch_type=FetchType.DB_READ),
- "healthy": Metadata(id=5, fetch_type=FetchType.HARDCODED),
- "init": Metadata(id=6, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=7, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=8, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=9, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _get_string_indexer_log_records(caplog) == []
- assert _deconstruct_messages(snuba_payloads) == [
- (
- {
- "mapping_meta": {
- "c": {
- "1": "c:sessions/session@none",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"6": "init"},
- },
- "metric_id": 1,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 6},
- "timestamp": ts,
- "type": "c",
- "use_case_id": "performance",
- "value": 1.0,
- },
- [("mapping_sources", b"ch"), ("metric_type", "c")],
- ),
- (
- {
- "mapping_meta": {
- "c": {
- "2": "d:sessions/duration@second",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"5": "healthy"},
- },
- "metric_id": 2,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 30,
- "tags": {"3": 7, "9": 5},
- "timestamp": ts,
- "type": "d",
- "use_case_id": "performance",
- "value": [4, 5, 6],
- },
- [("mapping_sources", b"ch"), ("metric_type", "d")],
- ),
- (
- {
- "mapping_meta": {
- "c": {
- "3": "environment",
- "7": "production",
- "8": "s:sessions/error@none",
- "9": "session.status",
- },
- "d": {"4": "errored"},
- },
- "metric_id": 8,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 4},
- "timestamp": ts,
- "type": "s",
- "use_case_id": "performance",
- "value": [3],
- },
- [("mapping_sources", b"cd"), ("metric_type", "s")],
- ),
- ]
- def test_batch_resolve_with_values_not_indexed(caplog, settings):
- """
- Tests that the indexer batch skips resolving tag values for indexing and
- sends the raw tag value to Snuba.
- The difference between this test and test_all_resolved is that the tag values are
- strings instead of integers. Because of that indexed tag keys are
- different and mapping_meta is smaller. The payload also contains the
- version field to specify that the tag values are not indexed.
- """
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- False,
- False,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "d:sessions/duration@second": 2,
- "environment": 3,
- "s:sessions/error@none": 4,
- "session.status": 5,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "d:sessions/duration@second": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=4, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=5, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _get_string_indexer_log_records(caplog) == []
- assert _deconstruct_messages(snuba_payloads, kafka_logical_topic="snuba-generic-metrics") == [
- (
- {
- "version": 2,
- "mapping_meta": {
- "c": {
- "1": "c:sessions/session@none",
- "3": "environment",
- "5": "session.status",
- },
- },
- "metric_id": 1,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": "production", "5": "init"},
- "timestamp": ts,
- "type": "c",
- "use_case_id": "performance",
- "value": 1.0,
- },
- [("mapping_sources", b"c"), ("metric_type", "c")],
- ),
- (
- {
- "version": 2,
- "mapping_meta": {
- "c": {
- "2": "d:sessions/duration@second",
- "3": "environment",
- "5": "session.status",
- },
- },
- "metric_id": 2,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": "production", "5": "healthy"},
- "timestamp": ts,
- "type": "d",
- "use_case_id": "performance",
- "value": [4, 5, 6],
- },
- [("mapping_sources", b"c"), ("metric_type", "d")],
- ),
- (
- {
- "version": 2,
- "mapping_meta": {
- "c": {
- "3": "environment",
- "4": "s:sessions/error@none",
- "5": "session.status",
- },
- },
- "metric_id": 4,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": "production", "5": "errored"},
- "timestamp": ts,
- "type": "s",
- "use_case_id": "performance",
- "value": [3],
- },
- [("mapping_sources", b"c"), ("metric_type", "s")],
- ),
- ]
- def test_metric_id_rate_limited(caplog, settings):
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE, outer_message, True, False, arroyo_input_codec=_INGEST_SCHEMA
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": None,
- "d:sessions/duration@second": None,
- "environment": 3,
- "errored": 4,
- "healthy": 5,
- "init": 6,
- "production": 7,
- "s:sessions/error@none": 8,
- "session.status": 9,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(
- id=None,
- fetch_type=FetchType.RATE_LIMITED,
- fetch_type_ext=FetchTypeExt(is_global=False),
- ),
- "d:sessions/duration@second": Metadata(
- id=None, fetch_type=FetchType.RATE_LIMITED, fetch_type_ext=None
- ),
- "environment": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "errored": Metadata(id=4, fetch_type=FetchType.DB_READ),
- "healthy": Metadata(id=5, fetch_type=FetchType.HARDCODED),
- "init": Metadata(id=6, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=7, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=None, fetch_type=FetchType.DB_READ),
- "session.status": Metadata(id=9, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _deconstruct_messages(snuba_payloads) == [
- (
- {
- "mapping_meta": {
- "c": {"3": "environment", "7": "production", "9": "session.status"},
- "d": {"4": "errored", "None": "s:sessions/error@none"},
- },
- "metric_id": 8,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 4},
- "timestamp": ts,
- "type": "s",
- "use_case_id": "performance",
- "value": [3],
- },
- [("mapping_sources", b"cd"), ("metric_type", "s")],
- ),
- ]
- assert _get_string_indexer_log_records(caplog) == [
- (
- "process_messages.dropped_message",
- {"org_batch_size": 9, "is_global_quota": False, "string_type": "metric_id"},
- ),
- (
- "process_messages.dropped_message",
- {"org_batch_size": 9, "is_global_quota": False, "string_type": "metric_id"},
- ),
- ]
- def test_tag_key_rate_limited(caplog, settings):
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE, outer_message, True, False, arroyo_input_codec=_INGEST_SCHEMA
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "d:sessions/duration@second": 2,
- "environment": None,
- "errored": 4,
- "healthy": 5,
- "init": 6,
- "production": 7,
- "s:sessions/error@none": 8,
- "session.status": 9,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "d:sessions/duration@second": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(
- id=None,
- fetch_type=FetchType.RATE_LIMITED,
- fetch_type_ext=FetchTypeExt(is_global=False),
- ),
- "errored": Metadata(id=4, fetch_type=FetchType.DB_READ),
- "healthy": Metadata(id=5, fetch_type=FetchType.HARDCODED),
- "init": Metadata(id=6, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=7, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=8, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=9, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _get_string_indexer_log_records(caplog) == [
- (
- "process_messages.dropped_message",
- {"num_global_quotas": 0, "org_batch_size": 9, "string_type": "tags"},
- ),
- (
- "process_messages.dropped_message",
- {"num_global_quotas": 0, "org_batch_size": 9, "string_type": "tags"},
- ),
- (
- "process_messages.dropped_message",
- {"num_global_quotas": 0, "org_batch_size": 9, "string_type": "tags"},
- ),
- ]
- assert _deconstruct_messages(snuba_payloads) == []
- def test_tag_value_rate_limited(caplog, settings):
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE, outer_message, True, False, arroyo_input_codec=_INGEST_SCHEMA
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "d:sessions/duration@second",
- "environment",
- "errored",
- "healthy",
- "init",
- "production",
- "s:sessions/error@none",
- "session.status",
- }
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "d:sessions/duration@second": 2,
- "environment": 3,
- "errored": None,
- "healthy": 5,
- "init": 6,
- "production": 7,
- "s:sessions/error@none": 8,
- "session.status": 9,
- }
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "d:sessions/duration@second": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "errored": Metadata(
- id=None,
- fetch_type=FetchType.RATE_LIMITED,
- fetch_type_ext=FetchTypeExt(is_global=False),
- ),
- "healthy": Metadata(id=5, fetch_type=FetchType.HARDCODED),
- "init": Metadata(id=6, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=7, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=8, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=9, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _get_string_indexer_log_records(caplog) == [
- (
- "process_messages.dropped_message",
- {"num_global_quotas": 0, "org_batch_size": 9, "string_type": "tags"},
- ),
- ]
- assert _deconstruct_messages(snuba_payloads) == [
- (
- {
- "mapping_meta": {
- "c": {
- "1": "c:sessions/session@none",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"6": "init"},
- },
- "metric_id": 1,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 6},
- "timestamp": ts,
- "type": "c",
- "use_case_id": "performance",
- "value": 1.0,
- },
- [("mapping_sources", b"ch"), ("metric_type", "c")],
- ),
- (
- {
- "mapping_meta": {
- "c": {
- "2": "d:sessions/duration@second",
- "3": "environment",
- "7": "production",
- "9": "session.status",
- },
- "h": {"5": "healthy"},
- },
- "metric_id": 2,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"3": 7, "9": 5},
- "timestamp": ts,
- "type": "d",
- "use_case_id": "performance",
- "value": [4, 5, 6],
- },
- [("mapping_sources", b"ch"), ("metric_type", "d")],
- ),
- ]
- def test_one_org_limited(caplog, settings):
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- ({**distribution_payload, "org_id": 2}, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- True,
- False,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- assert batch.extract_strings() == (
- {
- 1: {
- "c:sessions/session@none",
- "environment",
- "init",
- "production",
- "session.status",
- },
- 2: {
- "d:sessions/duration@second",
- "environment",
- "healthy",
- "production",
- "session.status",
- },
- }
- )
- caplog.set_level(logging.ERROR)
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "c:sessions/session@none": 1,
- "environment": None,
- "init": 3,
- "production": 4,
- "session.status": 5,
- },
- 2: {
- "d:sessions/duration@second": 1,
- "environment": 2,
- "healthy": 3,
- "production": 4,
- "session.status": 5,
- },
- },
- {
- 1: {
- "c:sessions/session@none": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(
- id=None,
- fetch_type=FetchType.RATE_LIMITED,
- fetch_type_ext=FetchTypeExt(is_global=False),
- ),
- "init": Metadata(id=3, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=4, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=5, fetch_type=FetchType.CACHE_HIT),
- },
- 2: {
- "d:sessions/duration@second": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "environment": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "healthy": Metadata(id=3, fetch_type=FetchType.HARDCODED),
- "production": Metadata(id=4, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=5, fetch_type=FetchType.CACHE_HIT),
- },
- },
- )
- assert _get_string_indexer_log_records(caplog) == [
- (
- "process_messages.dropped_message",
- {"num_global_quotas": 0, "org_batch_size": 5, "string_type": "tags"},
- ),
- ]
- assert _deconstruct_messages(snuba_payloads) == [
- (
- {
- "mapping_meta": {
- "c": {
- "1": "d:sessions/duration@second",
- "2": "environment",
- "4": "production",
- "5": "session.status",
- },
- "h": {"3": "healthy"},
- },
- "metric_id": 1,
- "org_id": 2,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"2": 4, "5": 3},
- "timestamp": ts,
- "type": "d",
- "use_case_id": "performance",
- "value": [4, 5, 6],
- },
- [("mapping_sources", b"ch"), ("metric_type", "d")],
- ),
- ]
- def test_cardinality_limiter(caplog, settings):
- """
- Test functionality of the indexer batch related to cardinality-limiting. More concretely, assert that `IndexerBatch.filter_messages`:
- 1. removes the messages from the outgoing batch
- 2. prevents strings from filtered messages from being extracted & indexed
- 3. does not crash when strings from filtered messages are not passed into reconstruct_messages
- 4. still extracts strings that exist both in filtered and unfiltered messages (eg "environment")
- """
- settings.SENTRY_METRICS_INDEXER_DEBUG_LOG_SAMPLE_RATE = 1.0
- outer_message = _construct_outer_message(
- [
- (counter_payload, []),
- (distribution_payload, []),
- (set_payload, []),
- ]
- )
- batch = IndexerBatch(
- UseCaseKey.PERFORMANCE,
- outer_message,
- True,
- False,
- arroyo_input_codec=_INGEST_SCHEMA,
- )
- keys_to_remove = list(batch.parsed_payloads_by_offset)[:2]
- # the messages come in a certain order, and Python dictionaries preserve
- # their insertion order. So we can hardcode offsets here.
- assert keys_to_remove == [
- PartitionIdxOffset(partition_idx=0, offset=0),
- PartitionIdxOffset(partition_idx=0, offset=1),
- ]
- batch.filter_messages(keys_to_remove)
- assert batch.extract_strings() == {
- 1: {
- "environment",
- "errored",
- "production",
- # Note, we only extracted one MRI, of the one metric that we didn't
- # drop
- "s:sessions/error@none",
- "session.status",
- },
- }
- snuba_payloads = batch.reconstruct_messages(
- {
- 1: {
- "environment": 1,
- "errored": 2,
- "production": 3,
- "s:sessions/error@none": 4,
- "session.status": 5,
- },
- },
- {
- 1: {
- "environment": Metadata(id=1, fetch_type=FetchType.CACHE_HIT),
- "errored": Metadata(id=2, fetch_type=FetchType.CACHE_HIT),
- "production": Metadata(id=3, fetch_type=FetchType.CACHE_HIT),
- "s:sessions/error@none": Metadata(id=4, fetch_type=FetchType.CACHE_HIT),
- "session.status": Metadata(id=5, fetch_type=FetchType.CACHE_HIT),
- }
- },
- )
- assert _deconstruct_messages(snuba_payloads) == [
- (
- {
- "mapping_meta": {
- "c": {
- "1": "environment",
- "2": "errored",
- "3": "production",
- "4": "s:sessions/error@none",
- "5": "session.status",
- },
- },
- "metric_id": 4,
- "org_id": 1,
- "project_id": 3,
- "retention_days": 90,
- "tags": {"1": 3, "5": 2},
- "timestamp": ts,
- "type": "s",
- "use_case_id": "performance",
- "value": [3],
- },
- [
- ("mapping_sources", b"c"),
- ("metric_type", "s"),
- ],
- )
- ]
|