overview.actions.spec.tsx 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466
  1. import {Fragment} from 'react';
  2. import {GlobalSelectionFixture} from 'sentry-fixture/globalSelection';
  3. import {GroupFixture} from 'sentry-fixture/group';
  4. import {GroupStatsFixture} from 'sentry-fixture/groupStats';
  5. import {LocationFixture} from 'sentry-fixture/locationFixture';
  6. import {OrganizationFixture} from 'sentry-fixture/organization';
  7. import {ProjectFixture} from 'sentry-fixture/project';
  8. import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
  9. import {TagsFixture} from 'sentry-fixture/tags';
  10. import {
  11. render,
  12. screen,
  13. userEvent,
  14. waitFor,
  15. within,
  16. } from 'sentry-test/reactTestingLibrary';
  17. import Indicators from 'sentry/components/indicators';
  18. import GroupStore from 'sentry/stores/groupStore';
  19. import IssueListCacheStore from 'sentry/stores/IssueListCacheStore';
  20. import SelectedGroupStore from 'sentry/stores/selectedGroupStore';
  21. import TagStore from 'sentry/stores/tagStore';
  22. import {PriorityLevel} from 'sentry/types/group';
  23. import IssueListOverview from 'sentry/views/issueList/overview';
  24. const DEFAULT_LINKS_HEADER =
  25. '<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575731:0:1>; rel="previous"; results="false"; cursor="1443575731:0:1", ' +
  26. '<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575000:0:0>; rel="next"; results="true"; cursor="1443575000:0:0"';
  27. describe('IssueListOverview (actions)', function () {
  28. const project = ProjectFixture({
  29. id: '3559',
  30. name: 'Foo Project',
  31. slug: 'project-slug',
  32. firstEvent: new Date().toISOString(),
  33. });
  34. const tags = TagsFixture();
  35. const groupStats = GroupStatsFixture();
  36. const api = new MockApiClient();
  37. const organization = OrganizationFixture();
  38. beforeEach(function () {
  39. MockApiClient.clearMockResponses();
  40. GroupStore.reset();
  41. SelectedGroupStore.reset();
  42. IssueListCacheStore.reset();
  43. MockApiClient.addMockResponse({
  44. url: '/organizations/org-slug/issues-stats/',
  45. body: [groupStats],
  46. });
  47. MockApiClient.addMockResponse({
  48. url: '/organizations/org-slug/searches/',
  49. body: [],
  50. });
  51. MockApiClient.addMockResponse({
  52. url: '/organizations/org-slug/recent-searches/',
  53. body: [],
  54. });
  55. MockApiClient.addMockResponse({
  56. url: '/organizations/org-slug/recent-searches/',
  57. method: 'POST',
  58. body: [],
  59. });
  60. MockApiClient.addMockResponse({
  61. url: '/organizations/org-slug/issues-count/',
  62. method: 'GET',
  63. body: [{}],
  64. });
  65. MockApiClient.addMockResponse({
  66. url: '/organizations/org-slug/processingissues/',
  67. method: 'GET',
  68. body: [],
  69. });
  70. MockApiClient.addMockResponse({
  71. url: '/organizations/org-slug/tags/',
  72. method: 'GET',
  73. body: [],
  74. });
  75. MockApiClient.addMockResponse({
  76. url: '/organizations/org-slug/users/',
  77. method: 'GET',
  78. body: [],
  79. });
  80. MockApiClient.addMockResponse({
  81. url: '/organizations/org-slug/sent-first-event/',
  82. body: {sentFirstEvent: true},
  83. });
  84. MockApiClient.addMockResponse({
  85. url: '/organizations/org-slug/projects/',
  86. body: [],
  87. });
  88. TagStore.init?.();
  89. });
  90. const defaultProps = {
  91. api,
  92. savedSearchLoading: false,
  93. savedSearches: [],
  94. useOrgSavedSearches: true,
  95. selection: GlobalSelectionFixture(),
  96. organization,
  97. tags: [
  98. tags.reduce((acc, tag) => {
  99. // @ts-expect-error TS(7053): Element implicitly has an any type because
  100. acc[tag.key] = tag;
  101. return acc;
  102. }),
  103. ],
  104. savedSearch: null,
  105. selectedSearchId: null,
  106. ...RouteComponentPropsFixture<
  107. {orgId: string; projectId: string},
  108. {searchId?: string}
  109. >({
  110. location: LocationFixture({
  111. query: {query: 'is:unresolved issue.priority:[high,medium]'},
  112. }),
  113. params: {orgId: organization.slug, projectId: project.slug, searchId: undefined},
  114. }),
  115. };
  116. describe('status', function () {
  117. const group1 = GroupFixture({
  118. id: '1',
  119. culprit: 'Group 1',
  120. shortId: 'JAVASCRIPT-1',
  121. });
  122. const group2 = GroupFixture({
  123. id: '2',
  124. culprit: 'Group 2',
  125. shortId: 'JAVASCRIPT-2',
  126. });
  127. beforeEach(() => {
  128. MockApiClient.addMockResponse({
  129. url: '/organizations/org-slug/issues/',
  130. body: [group1, group2],
  131. headers: {Link: DEFAULT_LINKS_HEADER},
  132. });
  133. });
  134. it('removes issues after resolving', async function () {
  135. const updateIssueMock = MockApiClient.addMockResponse({
  136. url: '/organizations/org-slug/issues/',
  137. method: 'PUT',
  138. });
  139. render(<IssueListOverview {...defaultProps} />, {organization});
  140. const groups = await screen.findAllByTestId('group');
  141. await userEvent.click(
  142. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  143. );
  144. expect(screen.getByText('Group 1')).toBeInTheDocument();
  145. expect(screen.getByText('Group 2')).toBeInTheDocument();
  146. // After action, will refetch so need to mock that response
  147. MockApiClient.addMockResponse({
  148. url: '/organizations/org-slug/issues/',
  149. body: [group2],
  150. headers: {Link: DEFAULT_LINKS_HEADER},
  151. });
  152. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  153. expect(updateIssueMock).toHaveBeenCalledWith(
  154. '/organizations/org-slug/issues/',
  155. expect.objectContaining({
  156. query: expect.objectContaining({id: ['1']}),
  157. data: {status: 'resolved', statusDetails: {}, substatus: null},
  158. })
  159. );
  160. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  161. expect(screen.getByText('Group 2')).toBeInTheDocument();
  162. });
  163. it('can undo resolve action', async function () {
  164. const updateIssueMock = MockApiClient.addMockResponse({
  165. url: '/organizations/org-slug/issues/',
  166. method: 'PUT',
  167. });
  168. render(
  169. <Fragment>
  170. <IssueListOverview {...defaultProps} />
  171. <Indicators />
  172. </Fragment>,
  173. {organization}
  174. );
  175. const groups = await screen.findAllByTestId('group');
  176. await userEvent.click(
  177. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  178. );
  179. expect(screen.getByText('Group 1')).toBeInTheDocument();
  180. expect(screen.getByText('Group 2')).toBeInTheDocument();
  181. // After action, will refetch so need to mock that response
  182. MockApiClient.addMockResponse({
  183. url: '/organizations/org-slug/issues/',
  184. body: [group2],
  185. headers: {Link: DEFAULT_LINKS_HEADER},
  186. });
  187. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  188. expect(updateIssueMock).toHaveBeenCalledWith(
  189. '/organizations/org-slug/issues/',
  190. expect.objectContaining({
  191. query: expect.objectContaining({id: ['1']}),
  192. data: {status: 'resolved', statusDetails: {}, substatus: null},
  193. })
  194. );
  195. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  196. expect(screen.getByText('Group 2')).toBeInTheDocument();
  197. // Should show a toast message
  198. expect(screen.getByText('Resolved JAVASCRIPT-1')).toBeInTheDocument();
  199. // Clicking the undo button makes a call to set the status back to unresolved
  200. MockApiClient.addMockResponse({
  201. url: '/organizations/org-slug/issues/',
  202. body: [group1, group2],
  203. headers: {Link: DEFAULT_LINKS_HEADER},
  204. });
  205. await userEvent.click(screen.getByRole('button', {name: 'Undo'}));
  206. expect(updateIssueMock).toHaveBeenLastCalledWith(
  207. '/organizations/org-slug/issues/',
  208. expect.objectContaining({
  209. query: expect.objectContaining({id: ['1']}),
  210. data: {status: 'unresolved', statusDetails: {}},
  211. })
  212. );
  213. expect(await screen.findByText('Group 1')).toBeInTheDocument();
  214. });
  215. });
  216. describe('mark reviewed', function () {
  217. const group1 = GroupFixture({
  218. id: '1',
  219. culprit: 'Group 1',
  220. shortId: 'JAVASCRIPT-1',
  221. inbox: {},
  222. });
  223. const group2 = GroupFixture({
  224. id: '2',
  225. culprit: 'Group 2',
  226. shortId: 'JAVASCRIPT-2',
  227. inbox: {},
  228. });
  229. beforeEach(() => {
  230. MockApiClient.addMockResponse({
  231. url: '/organizations/org-slug/issues/',
  232. body: [group1, group2],
  233. headers: {Link: DEFAULT_LINKS_HEADER},
  234. });
  235. });
  236. it('removes issues after making reviewed (when on for review tab)', async function () {
  237. const updateIssueMock = MockApiClient.addMockResponse({
  238. url: '/organizations/org-slug/issues/',
  239. method: 'PUT',
  240. });
  241. render(
  242. <IssueListOverview
  243. {...defaultProps}
  244. {...RouteComponentPropsFixture({
  245. location: LocationFixture({
  246. query: {query: 'is:for_review'},
  247. }),
  248. params: {
  249. orgId: organization.slug,
  250. projectId: project.slug,
  251. searchId: undefined,
  252. },
  253. })}
  254. />,
  255. {organization}
  256. );
  257. const groups = await screen.findAllByTestId('group');
  258. await userEvent.click(
  259. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  260. );
  261. expect(screen.getByText('Group 1')).toBeInTheDocument();
  262. expect(screen.getByText('Group 2')).toBeInTheDocument();
  263. // After action, will refetch so need to mock that response
  264. MockApiClient.addMockResponse({
  265. url: '/organizations/org-slug/issues/',
  266. body: [group2],
  267. headers: {Link: DEFAULT_LINKS_HEADER},
  268. });
  269. await userEvent.click(
  270. await screen.findByRole('button', {name: 'More issue actions'})
  271. );
  272. await userEvent.click(screen.getByRole('menuitemradio', {name: 'Mark Reviewed'}));
  273. expect(updateIssueMock).toHaveBeenCalledWith(
  274. '/organizations/org-slug/issues/',
  275. expect.objectContaining({
  276. query: expect.objectContaining({id: ['1']}),
  277. data: {inbox: false},
  278. })
  279. );
  280. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  281. expect(screen.getByText('Group 2')).toBeInTheDocument();
  282. });
  283. });
  284. describe('priority', function () {
  285. const medPriorityGroup = GroupFixture({
  286. id: '1',
  287. priority: PriorityLevel.MEDIUM,
  288. culprit: 'Medium priority issue',
  289. });
  290. const highPriorityGroup = GroupFixture({
  291. id: '2',
  292. priority: PriorityLevel.HIGH,
  293. culprit: 'High priority issue',
  294. });
  295. beforeEach(() => {
  296. MockApiClient.addMockResponse({
  297. url: '/organizations/org-slug/issues/',
  298. body: [medPriorityGroup, highPriorityGroup],
  299. headers: {Link: DEFAULT_LINKS_HEADER},
  300. });
  301. });
  302. it('removes issues after bulk reprioritizing (when excluding priorities)', async function () {
  303. const updateIssueMock = MockApiClient.addMockResponse({
  304. url: '/organizations/org-slug/issues/',
  305. method: 'PUT',
  306. });
  307. render(<IssueListOverview {...defaultProps} />, {organization});
  308. const groups = await screen.findAllByTestId('group');
  309. await userEvent.click(
  310. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  311. );
  312. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  313. // After action, will refetch so need to mock that response
  314. MockApiClient.addMockResponse({
  315. url: '/organizations/org-slug/issues/',
  316. body: [highPriorityGroup],
  317. headers: {Link: DEFAULT_LINKS_HEADER},
  318. });
  319. await userEvent.click(await screen.findByRole('button', {name: /set priority/i}));
  320. await userEvent.click(screen.getByRole('menuitemradio', {name: /low/i}));
  321. expect(updateIssueMock).toHaveBeenCalledWith(
  322. '/organizations/org-slug/issues/',
  323. expect.objectContaining({
  324. query: expect.objectContaining({id: ['1']}),
  325. data: {priority: PriorityLevel.LOW},
  326. })
  327. );
  328. expect(screen.queryByText('Medium priority issue')).not.toBeInTheDocument();
  329. });
  330. it('removes issues after reprioritizing single issue (when excluding priorities)', async function () {
  331. MockApiClient.addMockResponse({
  332. url: '/organizations/org-slug/prompts-activity/',
  333. body: {data: {dismissed_ts: null}},
  334. });
  335. const updateIssueMock = MockApiClient.addMockResponse({
  336. url: '/organizations/org-slug/issues/',
  337. method: 'PUT',
  338. });
  339. render(<IssueListOverview {...defaultProps} />, {organization});
  340. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  341. // After action, will refetch so need to mock that response
  342. MockApiClient.addMockResponse({
  343. url: '/organizations/org-slug/issues/',
  344. body: [highPriorityGroup],
  345. headers: {Link: DEFAULT_LINKS_HEADER},
  346. });
  347. await userEvent.click(screen.getByText('Med'));
  348. await userEvent.click(screen.getByRole('menuitemradio', {name: 'Low'}));
  349. await waitFor(() => {
  350. expect(updateIssueMock).toHaveBeenCalledWith(
  351. '/organizations/org-slug/issues/',
  352. expect.objectContaining({
  353. query: expect.objectContaining({id: ['1']}),
  354. data: {priority: PriorityLevel.LOW},
  355. })
  356. );
  357. });
  358. expect(screen.queryByText('Medium priority issue')).not.toBeInTheDocument();
  359. });
  360. it('does not remove issues after bulk reprioritizing (when query includes all priorities)', async function () {
  361. const updateIssueMock = MockApiClient.addMockResponse({
  362. url: '/organizations/org-slug/issues/',
  363. method: 'PUT',
  364. });
  365. render(
  366. <IssueListOverview
  367. {...defaultProps}
  368. {...RouteComponentPropsFixture({
  369. location: LocationFixture({
  370. query: {query: 'is:unresolved'},
  371. }),
  372. params: {
  373. orgId: organization.slug,
  374. projectId: project.slug,
  375. searchId: undefined,
  376. },
  377. })}
  378. />,
  379. {organization}
  380. );
  381. const groups = await screen.findAllByTestId('group');
  382. await userEvent.click(
  383. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  384. );
  385. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  386. await userEvent.click(await screen.findByRole('button', {name: /set priority/i}));
  387. await userEvent.click(screen.getByRole('menuitemradio', {name: /low/i}));
  388. expect(updateIssueMock).toHaveBeenCalledWith(
  389. '/organizations/org-slug/issues/',
  390. expect.objectContaining({
  391. query: expect.objectContaining({id: ['1']}),
  392. data: {priority: PriorityLevel.LOW},
  393. })
  394. );
  395. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  396. });
  397. });
  398. });