detail.spec.tsx 79 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471
  1. import {DashboardFixture} from 'sentry-fixture/dashboard';
  2. import {LocationFixture} from 'sentry-fixture/locationFixture';
  3. import {OrganizationFixture} from 'sentry-fixture/organization';
  4. import {ProjectFixture} from 'sentry-fixture/project';
  5. import {ReleaseFixture} from 'sentry-fixture/release';
  6. import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
  7. import {TeamFixture} from 'sentry-fixture/team';
  8. import {UserFixture} from 'sentry-fixture/user';
  9. import {WidgetFixture} from 'sentry-fixture/widget';
  10. import {initializeOrg} from 'sentry-test/initializeOrg';
  11. import {
  12. act,
  13. render,
  14. screen,
  15. userEvent,
  16. waitFor,
  17. within,
  18. } from 'sentry-test/reactTestingLibrary';
  19. import * as dashboardActions from 'sentry/actionCreators/dashboards';
  20. import * as modals from 'sentry/actionCreators/modal';
  21. import ConfigStore from 'sentry/stores/configStore';
  22. import PageFiltersStore from 'sentry/stores/pageFiltersStore';
  23. import ProjectsStore from 'sentry/stores/projectsStore';
  24. import TeamStore from 'sentry/stores/teamStore';
  25. import CreateDashboard from 'sentry/views/dashboards/create';
  26. import DashboardDetail, {
  27. handleUpdateDashboardSplit,
  28. } from 'sentry/views/dashboards/detail';
  29. import EditAccessSelector from 'sentry/views/dashboards/editAccessSelector';
  30. import * as types from 'sentry/views/dashboards/types';
  31. import {DashboardState} from 'sentry/views/dashboards/types';
  32. import ViewEditDashboard from 'sentry/views/dashboards/view';
  33. import useWidgetBuilderState from 'sentry/views/dashboards/widgetBuilder/hooks/useWidgetBuilderState';
  34. import {OrganizationContext} from 'sentry/views/organizationContext';
  35. jest.mock('sentry/views/dashboards/widgetBuilder/hooks/useWidgetBuilderState');
  36. describe('Dashboards > Detail', function () {
  37. const organization = OrganizationFixture({
  38. features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
  39. });
  40. const projects = [ProjectFixture()];
  41. describe('prebuilt dashboards', function () {
  42. let initialData!: ReturnType<typeof initializeOrg>;
  43. beforeEach(function () {
  44. act(() => ProjectsStore.loadInitialData(projects));
  45. initialData = initializeOrg({organization});
  46. MockApiClient.addMockResponse({
  47. url: '/organizations/org-slug/tags/',
  48. body: [],
  49. });
  50. MockApiClient.addMockResponse({
  51. url: '/organizations/org-slug/projects/',
  52. body: [ProjectFixture()],
  53. });
  54. MockApiClient.addMockResponse({
  55. url: '/organizations/org-slug/dashboards/',
  56. body: [
  57. DashboardFixture([], {id: 'default-overview', title: 'Default'}),
  58. DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  59. ],
  60. });
  61. MockApiClient.addMockResponse({
  62. url: '/organizations/org-slug/dashboards/default-overview/',
  63. body: DashboardFixture([], {id: 'default-overview', title: 'Default'}),
  64. });
  65. MockApiClient.addMockResponse({
  66. url: '/organizations/org-slug/dashboards/1/visit/',
  67. method: 'POST',
  68. body: [],
  69. statusCode: 200,
  70. });
  71. MockApiClient.addMockResponse({
  72. url: '/organizations/org-slug/users/',
  73. method: 'GET',
  74. body: [],
  75. });
  76. MockApiClient.addMockResponse({
  77. url: '/organizations/org-slug/sdk-updates/',
  78. body: [],
  79. });
  80. MockApiClient.addMockResponse({
  81. url: '/organizations/org-slug/prompts-activity/',
  82. body: {},
  83. });
  84. MockApiClient.addMockResponse({
  85. url: '/organizations/org-slug/events/',
  86. method: 'GET',
  87. body: [],
  88. });
  89. MockApiClient.addMockResponse({
  90. url: '/organizations/org-slug/events-stats/',
  91. body: {data: []},
  92. });
  93. MockApiClient.addMockResponse({
  94. method: 'GET',
  95. url: '/organizations/org-slug/issues/',
  96. body: [],
  97. });
  98. MockApiClient.addMockResponse({
  99. url: '/organizations/org-slug/releases/',
  100. body: [],
  101. });
  102. MockApiClient.addMockResponse({
  103. url: '/organizations/org-slug/releases/stats/',
  104. body: [],
  105. });
  106. MockApiClient.addMockResponse({
  107. url: '/organizations/org-slug/metrics/meta/',
  108. body: [],
  109. });
  110. });
  111. afterEach(function () {
  112. MockApiClient.clearMockResponses();
  113. });
  114. it('assigns unique IDs to all widgets so grid keys are unique', async function () {
  115. MockApiClient.addMockResponse({
  116. url: '/organizations/org-slug/events-stats/',
  117. body: {data: []},
  118. });
  119. MockApiClient.addMockResponse({
  120. url: '/organizations/org-slug/dashboards/default-overview/',
  121. body: DashboardFixture(
  122. [
  123. WidgetFixture({
  124. queries: [
  125. {
  126. name: '',
  127. conditions: 'event.type:error',
  128. fields: ['count()'],
  129. aggregates: ['count()'],
  130. columns: [],
  131. orderby: '-count()',
  132. },
  133. ],
  134. title: 'Default Widget 1',
  135. interval: '1d',
  136. }),
  137. WidgetFixture({
  138. queries: [
  139. {
  140. name: '',
  141. conditions: 'event.type:transaction',
  142. fields: ['count()'],
  143. aggregates: ['count()'],
  144. columns: [],
  145. orderby: '-count()',
  146. },
  147. ],
  148. title: 'Default Widget 2',
  149. interval: '1d',
  150. }),
  151. ],
  152. {id: 'default-overview', title: 'Default'}
  153. ),
  154. });
  155. initialData = initializeOrg({
  156. organization: OrganizationFixture({
  157. features: ['global-views', 'dashboards-basic', 'discover-query'],
  158. }),
  159. });
  160. render(
  161. <OrganizationContext.Provider value={initialData.organization}>
  162. <ViewEditDashboard
  163. {...RouteComponentPropsFixture()}
  164. organization={initialData.organization}
  165. params={{orgId: 'org-slug', dashboardId: 'default-overview'}}
  166. router={initialData.router}
  167. location={initialData.router.location}
  168. >
  169. {null}
  170. </ViewEditDashboard>
  171. </OrganizationContext.Provider>,
  172. {router: initialData.router}
  173. );
  174. expect(await screen.findByText('Default Widget 1')).toBeInTheDocument();
  175. expect(screen.getByText('Default Widget 2')).toBeInTheDocument();
  176. });
  177. it('opens the widget viewer modal in a prebuilt dashboard using the widget id specified in the url', async () => {
  178. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  179. render(
  180. <CreateDashboard
  181. {...RouteComponentPropsFixture()}
  182. organization={initialData.organization}
  183. params={{templateId: 'default-template', widgetId: '2'}}
  184. router={initialData.router}
  185. location={{...initialData.router.location, pathname: '/widget/2/'}}
  186. >
  187. {null}
  188. </CreateDashboard>,
  189. {router: initialData.router, organization: initialData.organization}
  190. );
  191. await waitFor(() => {
  192. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  193. expect.objectContaining({
  194. organization: initialData.organization,
  195. widget: expect.objectContaining({
  196. displayType: 'line',
  197. interval: '5m',
  198. queries: [
  199. {
  200. aggregates: ['count()'],
  201. columns: [],
  202. conditions: '!event.type:transaction',
  203. fields: ['count()'],
  204. name: 'Events',
  205. orderby: 'count()',
  206. },
  207. ],
  208. title: 'Events',
  209. widgetType: types.WidgetType.DISCOVER,
  210. }),
  211. onClose: expect.anything(),
  212. })
  213. );
  214. });
  215. });
  216. });
  217. describe('custom dashboards', function () {
  218. let initialData!: ReturnType<typeof initializeOrg>;
  219. let widgets!: Array<ReturnType<typeof WidgetFixture>>;
  220. let mockVisit!: jest.Mock;
  221. let mockPut!: jest.Mock;
  222. beforeEach(function () {
  223. window.confirm = jest.fn();
  224. initialData = initializeOrg({
  225. organization,
  226. router: {
  227. location: LocationFixture(),
  228. },
  229. });
  230. PageFiltersStore.init();
  231. PageFiltersStore.onInitializeUrlState(
  232. {
  233. projects: [],
  234. environments: [],
  235. datetime: {start: null, end: null, period: '14d', utc: null},
  236. },
  237. new Set()
  238. );
  239. widgets = [
  240. WidgetFixture({
  241. queries: [
  242. {
  243. name: '',
  244. conditions: 'event.type:error',
  245. fields: ['count()'],
  246. columns: [],
  247. aggregates: ['count()'],
  248. orderby: '-count()',
  249. },
  250. ],
  251. title: 'Errors',
  252. interval: '1d',
  253. widgetType: types.WidgetType.DISCOVER,
  254. id: '1',
  255. }),
  256. WidgetFixture({
  257. queries: [
  258. {
  259. name: '',
  260. conditions: 'event.type:transaction',
  261. fields: ['count()'],
  262. columns: [],
  263. aggregates: ['count()'],
  264. orderby: '-count()',
  265. },
  266. ],
  267. title: 'Transactions',
  268. interval: '1d',
  269. widgetType: types.WidgetType.DISCOVER,
  270. id: '2',
  271. }),
  272. WidgetFixture({
  273. queries: [
  274. {
  275. name: '',
  276. conditions: 'event.type:transaction transaction:/api/cats',
  277. fields: ['p50()'],
  278. columns: [],
  279. aggregates: ['p50()'],
  280. orderby: '-p50()',
  281. },
  282. ],
  283. title: 'p50 of /api/cats',
  284. interval: '1d',
  285. id: '3',
  286. }),
  287. ];
  288. mockVisit = MockApiClient.addMockResponse({
  289. url: '/organizations/org-slug/dashboards/1/visit/',
  290. method: 'POST',
  291. body: [],
  292. statusCode: 200,
  293. });
  294. MockApiClient.addMockResponse({
  295. url: '/organizations/org-slug/tags/',
  296. body: [],
  297. });
  298. MockApiClient.addMockResponse({
  299. url: '/organizations/org-slug/projects/',
  300. body: [ProjectFixture()],
  301. });
  302. MockApiClient.addMockResponse({
  303. url: '/organizations/org-slug/dashboards/',
  304. body: [
  305. {
  306. ...DashboardFixture([], {
  307. id: 'default-overview',
  308. title: 'Default',
  309. }),
  310. widgetDisplay: ['area'],
  311. },
  312. {
  313. ...DashboardFixture([], {
  314. id: '1',
  315. title: 'Custom Errors',
  316. }),
  317. widgetDisplay: ['area'],
  318. },
  319. ],
  320. });
  321. MockApiClient.addMockResponse({
  322. url: '/organizations/org-slug/dashboards/1/',
  323. body: DashboardFixture(widgets, {
  324. id: '1',
  325. title: 'Custom Errors',
  326. filters: {},
  327. createdBy: UserFixture({id: '1'}),
  328. }),
  329. });
  330. mockPut = MockApiClient.addMockResponse({
  331. url: '/organizations/org-slug/dashboards/1/',
  332. method: 'PUT',
  333. body: DashboardFixture(widgets, {id: '1', title: 'Custom Errors'}),
  334. });
  335. MockApiClient.addMockResponse({
  336. url: '/organizations/org-slug/events-stats/',
  337. body: {data: []},
  338. });
  339. MockApiClient.addMockResponse({
  340. method: 'POST',
  341. url: '/organizations/org-slug/dashboards/widgets/',
  342. body: [],
  343. });
  344. MockApiClient.addMockResponse({
  345. method: 'GET',
  346. url: '/organizations/org-slug/recent-searches/',
  347. body: [],
  348. });
  349. MockApiClient.addMockResponse({
  350. method: 'GET',
  351. url: '/organizations/org-slug/issues/',
  352. body: [],
  353. });
  354. MockApiClient.addMockResponse({
  355. url: '/organizations/org-slug/events/',
  356. method: 'GET',
  357. body: [],
  358. });
  359. MockApiClient.addMockResponse({
  360. url: '/organizations/org-slug/users/',
  361. method: 'GET',
  362. body: [],
  363. });
  364. MockApiClient.addMockResponse({
  365. url: '/organizations/org-slug/releases/',
  366. body: [],
  367. });
  368. MockApiClient.addMockResponse({
  369. url: '/organizations/org-slug/releases/stats/',
  370. body: [],
  371. });
  372. MockApiClient.addMockResponse({
  373. url: '/organizations/org-slug/sdk-updates/',
  374. body: [],
  375. });
  376. MockApiClient.addMockResponse({
  377. url: '/organizations/org-slug/prompts-activity/',
  378. body: {},
  379. });
  380. MockApiClient.addMockResponse({
  381. url: '/organizations/org-slug/metrics/meta/',
  382. body: [],
  383. });
  384. MockApiClient.addMockResponse({
  385. url: '/organizations/org-slug/measurements-meta/',
  386. body: [],
  387. });
  388. });
  389. afterEach(function () {
  390. MockApiClient.clearMockResponses();
  391. jest.clearAllMocks();
  392. });
  393. it('can remove widgets', async function () {
  394. const updateMock = MockApiClient.addMockResponse({
  395. url: '/organizations/org-slug/dashboards/1/',
  396. method: 'PUT',
  397. body: DashboardFixture([widgets[0]!], {id: '1', title: 'Custom Errors'}),
  398. });
  399. render(
  400. <OrganizationContext.Provider value={initialData.organization}>
  401. <ViewEditDashboard
  402. {...RouteComponentPropsFixture()}
  403. organization={initialData.organization}
  404. params={{orgId: 'org-slug', dashboardId: '1'}}
  405. router={initialData.router}
  406. location={initialData.router.location}
  407. >
  408. {null}
  409. </ViewEditDashboard>
  410. </OrganizationContext.Provider>,
  411. {router: initialData.router}
  412. );
  413. await waitFor(() => expect(mockVisit).toHaveBeenCalledTimes(1));
  414. // Enter edit mode.
  415. await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
  416. // Remove the second and third widgets
  417. await userEvent.click(
  418. (await screen.findAllByRole('button', {name: 'Delete Widget'}))[1]!
  419. );
  420. await userEvent.click(
  421. (await screen.findAllByRole('button', {name: 'Delete Widget'}))[1]!
  422. );
  423. // Save changes
  424. await userEvent.click(screen.getByRole('button', {name: 'Save and Finish'}));
  425. expect(updateMock).toHaveBeenCalled();
  426. expect(updateMock).toHaveBeenCalledWith(
  427. '/organizations/org-slug/dashboards/1/',
  428. expect.objectContaining({
  429. data: expect.objectContaining({
  430. title: 'Custom Errors',
  431. widgets: [expect.objectContaining(widgets[0])],
  432. }),
  433. })
  434. );
  435. // Visit should not be called again on dashboard update
  436. expect(mockVisit).toHaveBeenCalledTimes(1);
  437. });
  438. it('appends dashboard-level filters to series request', async function () {
  439. MockApiClient.addMockResponse({
  440. url: '/organizations/org-slug/dashboards/1/',
  441. body: DashboardFixture(widgets, {
  442. id: '1',
  443. title: 'Custom Errors',
  444. filters: {release: ['abc@1.2.0']},
  445. }),
  446. });
  447. const mock = MockApiClient.addMockResponse({
  448. url: '/organizations/org-slug/events-stats/',
  449. body: [],
  450. });
  451. render(
  452. <OrganizationContext.Provider value={initialData.organization}>
  453. <ViewEditDashboard
  454. {...RouteComponentPropsFixture()}
  455. organization={initialData.organization}
  456. params={{orgId: 'org-slug', dashboardId: '1'}}
  457. router={initialData.router}
  458. location={initialData.router.location}
  459. >
  460. {null}
  461. </ViewEditDashboard>
  462. </OrganizationContext.Provider>,
  463. {router: initialData.router}
  464. );
  465. await waitFor(() =>
  466. expect(mock).toHaveBeenLastCalledWith(
  467. '/organizations/org-slug/events-stats/',
  468. expect.objectContaining({
  469. query: expect.objectContaining({
  470. query:
  471. '(event.type:transaction transaction:/api/cats) release:"abc@1.2.0" ',
  472. }),
  473. })
  474. )
  475. );
  476. });
  477. it('shows add widget option', async function () {
  478. render(
  479. <OrganizationContext.Provider value={initialData.organization}>
  480. <ViewEditDashboard
  481. {...RouteComponentPropsFixture()}
  482. organization={initialData.organization}
  483. params={{orgId: 'org-slug', dashboardId: '1'}}
  484. router={initialData.router}
  485. location={initialData.router.location}
  486. >
  487. {null}
  488. </ViewEditDashboard>
  489. </OrganizationContext.Provider>,
  490. {router: initialData.router}
  491. );
  492. // Enter edit mode.
  493. await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
  494. expect(await screen.findByRole('button', {name: 'Add widget'})).toBeInTheDocument();
  495. });
  496. it('shows add widget option with dataset selector flag', async function () {
  497. initialData = initializeOrg({
  498. organization: OrganizationFixture({
  499. features: [
  500. 'global-views',
  501. 'dashboards-basic',
  502. 'dashboards-edit',
  503. 'discover-query',
  504. 'custom-metrics',
  505. 'performance-discover-dataset-selector',
  506. ],
  507. }),
  508. });
  509. render(
  510. <OrganizationContext.Provider value={initialData.organization}>
  511. <ViewEditDashboard
  512. {...RouteComponentPropsFixture()}
  513. organization={initialData.organization}
  514. params={{orgId: 'org-slug', dashboardId: '1'}}
  515. router={initialData.router}
  516. location={initialData.router.location}
  517. >
  518. {null}
  519. </ViewEditDashboard>
  520. </OrganizationContext.Provider>,
  521. {router: initialData.router}
  522. );
  523. await userEvent.click(screen.getAllByText('Add Widget')[0]!);
  524. const menuOptions = await screen.findAllByTestId('menu-list-item-label');
  525. expect(menuOptions.map(e => e.textContent)).toEqual([
  526. 'Errors',
  527. 'Transactions',
  528. 'Issues',
  529. 'Releases',
  530. 'Metrics',
  531. ]);
  532. });
  533. it('shows add widget option without dataset selector flag', async function () {
  534. initialData = initializeOrg({
  535. organization: OrganizationFixture({
  536. features: [
  537. 'global-views',
  538. 'dashboards-basic',
  539. 'dashboards-edit',
  540. 'discover-query',
  541. 'custom-metrics',
  542. ],
  543. }),
  544. });
  545. render(
  546. <OrganizationContext.Provider value={initialData.organization}>
  547. <ViewEditDashboard
  548. {...RouteComponentPropsFixture()}
  549. organization={initialData.organization}
  550. params={{orgId: 'org-slug', dashboardId: '1'}}
  551. router={initialData.router}
  552. location={initialData.router.location}
  553. >
  554. {null}
  555. </ViewEditDashboard>
  556. </OrganizationContext.Provider>,
  557. {router: initialData.router}
  558. );
  559. await userEvent.click(screen.getAllByText('Add Widget')[0]!);
  560. const menuOptions = await screen.findAllByTestId('menu-list-item-label');
  561. expect(menuOptions.map(e => e.textContent)).toEqual([
  562. 'Errors and Transactions',
  563. 'Issues',
  564. 'Releases',
  565. 'Metrics',
  566. ]);
  567. });
  568. it('shows top level release filter', async function () {
  569. const mockReleases = MockApiClient.addMockResponse({
  570. url: '/organizations/org-slug/releases/',
  571. body: [ReleaseFixture()],
  572. });
  573. initialData = initializeOrg({
  574. organization: OrganizationFixture({
  575. features: [
  576. 'global-views',
  577. 'dashboards-basic',
  578. 'dashboards-edit',
  579. 'discover-query',
  580. ],
  581. }),
  582. });
  583. render(
  584. <OrganizationContext.Provider value={initialData.organization}>
  585. <ViewEditDashboard
  586. {...RouteComponentPropsFixture()}
  587. organization={initialData.organization}
  588. params={{orgId: 'org-slug', dashboardId: '1'}}
  589. router={initialData.router}
  590. location={initialData.router.location}
  591. >
  592. {null}
  593. </ViewEditDashboard>
  594. </OrganizationContext.Provider>,
  595. {router: initialData.router}
  596. );
  597. expect(await screen.findByText('All Releases')).toBeInTheDocument();
  598. expect(mockReleases).toHaveBeenCalledTimes(2); // Called once when PageFiltersStore is initialized
  599. });
  600. it('hides add widget option', async function () {
  601. // @ts-expect-error this is assigning to readonly property...
  602. types.MAX_WIDGETS = 1;
  603. render(
  604. <OrganizationContext.Provider value={initialData.organization}>
  605. <ViewEditDashboard
  606. {...RouteComponentPropsFixture()}
  607. organization={initialData.organization}
  608. params={{orgId: 'org-slug', dashboardId: '1'}}
  609. router={initialData.router}
  610. location={initialData.router.location}
  611. >
  612. {null}
  613. </ViewEditDashboard>
  614. </OrganizationContext.Provider>,
  615. {router: initialData.router}
  616. );
  617. // Enter edit mode.
  618. await userEvent.click(await screen.findByRole('button', {name: 'Edit Dashboard'}));
  619. expect(screen.queryByRole('button', {name: 'Add widget'})).not.toBeInTheDocument();
  620. });
  621. it('renders successfully if more widgets than stored layouts', async function () {
  622. // A case where someone has async added widgets to a dashboard
  623. MockApiClient.addMockResponse({
  624. url: '/organizations/org-slug/dashboards/1/',
  625. body: DashboardFixture(
  626. [
  627. WidgetFixture({
  628. queries: [
  629. {
  630. name: '',
  631. conditions: 'event.type:error',
  632. fields: ['count()'],
  633. aggregates: ['count()'],
  634. columns: [],
  635. orderby: '-count()',
  636. },
  637. ],
  638. title: 'First Widget',
  639. interval: '1d',
  640. id: '1',
  641. layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
  642. }),
  643. WidgetFixture({
  644. queries: [
  645. {
  646. name: '',
  647. conditions: 'event.type:error',
  648. fields: ['count()'],
  649. aggregates: ['count()'],
  650. columns: [],
  651. orderby: '-count()',
  652. },
  653. ],
  654. title: 'Second Widget',
  655. interval: '1d',
  656. id: '2',
  657. }),
  658. ],
  659. {id: '1', title: 'Custom Errors'}
  660. ),
  661. });
  662. render(
  663. <ViewEditDashboard
  664. {...RouteComponentPropsFixture()}
  665. organization={initialData.organization}
  666. params={{orgId: 'org-slug', dashboardId: '1'}}
  667. router={initialData.router}
  668. location={initialData.router.location}
  669. >
  670. {null}
  671. </ViewEditDashboard>,
  672. {router: initialData.router, organization: initialData.organization}
  673. );
  674. expect(await screen.findByText('First Widget')).toBeInTheDocument();
  675. expect(await screen.findByText('Second Widget')).toBeInTheDocument();
  676. });
  677. it('does not trigger request if layout not updated', async () => {
  678. MockApiClient.addMockResponse({
  679. url: '/organizations/org-slug/dashboards/1/',
  680. body: DashboardFixture(
  681. [
  682. WidgetFixture({
  683. queries: [
  684. {
  685. name: '',
  686. conditions: 'event.type:error',
  687. fields: ['count()'],
  688. aggregates: ['count()'],
  689. columns: [],
  690. orderby: '-count()',
  691. },
  692. ],
  693. title: 'First Widget',
  694. interval: '1d',
  695. id: '1',
  696. layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
  697. }),
  698. ],
  699. {id: '1', title: 'Custom Errors'}
  700. ),
  701. });
  702. render(
  703. <ViewEditDashboard
  704. {...RouteComponentPropsFixture()}
  705. organization={initialData.organization}
  706. params={{orgId: 'org-slug', dashboardId: '1'}}
  707. router={initialData.router}
  708. location={initialData.router.location}
  709. >
  710. {null}
  711. </ViewEditDashboard>,
  712. {router: initialData.router, organization: initialData.organization}
  713. );
  714. await userEvent.click(await screen.findByText('Edit Dashboard'));
  715. await userEvent.click(await screen.findByText('Save and Finish'));
  716. expect(screen.getByText('Edit Dashboard')).toBeInTheDocument();
  717. expect(mockPut).not.toHaveBeenCalled();
  718. });
  719. it('renders the custom resize handler for a widget', async () => {
  720. MockApiClient.addMockResponse({
  721. url: '/organizations/org-slug/dashboards/1/',
  722. body: DashboardFixture(
  723. [
  724. WidgetFixture({
  725. queries: [
  726. {
  727. name: '',
  728. conditions: 'event.type:error',
  729. fields: ['count()'],
  730. aggregates: ['count()'],
  731. columns: [],
  732. orderby: '-count()',
  733. },
  734. ],
  735. title: 'First Widget',
  736. interval: '1d',
  737. id: '1',
  738. layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
  739. }),
  740. ],
  741. {id: '1', title: 'Custom Errors'}
  742. ),
  743. });
  744. render(
  745. <ViewEditDashboard
  746. {...RouteComponentPropsFixture()}
  747. organization={initialData.organization}
  748. params={{orgId: 'org-slug', dashboardId: '1'}}
  749. router={initialData.router}
  750. location={initialData.router.location}
  751. >
  752. {null}
  753. </ViewEditDashboard>,
  754. {router: initialData.router, organization: initialData.organization}
  755. );
  756. await userEvent.click(await screen.findByText('Edit Dashboard'));
  757. const widget = (await screen.findByText('First Widget')).closest(
  758. '.react-grid-item'
  759. ) as HTMLElement;
  760. const resizeHandle = within(widget).getByTestId('custom-resize-handle');
  761. expect(resizeHandle).toBeVisible();
  762. });
  763. it('does not trigger an alert when the widgets have no layout and user cancels without changes', async () => {
  764. MockApiClient.addMockResponse({
  765. url: '/organizations/org-slug/dashboards/1/',
  766. body: DashboardFixture(
  767. [
  768. WidgetFixture({
  769. queries: [
  770. {
  771. name: '',
  772. conditions: 'event.type:error',
  773. fields: ['count()'],
  774. aggregates: ['count()'],
  775. columns: [],
  776. orderby: '-count()',
  777. },
  778. ],
  779. title: 'First Widget',
  780. interval: '1d',
  781. id: '1',
  782. layout: null,
  783. }),
  784. ],
  785. {id: '1', title: 'Custom Errors'}
  786. ),
  787. });
  788. render(
  789. <ViewEditDashboard
  790. {...RouteComponentPropsFixture()}
  791. organization={initialData.organization}
  792. params={{orgId: 'org-slug', dashboardId: '1'}}
  793. router={initialData.router}
  794. location={initialData.router.location}
  795. >
  796. {null}
  797. </ViewEditDashboard>,
  798. {router: initialData.router, organization: initialData.organization}
  799. );
  800. await userEvent.click(await screen.findByText('Edit Dashboard'));
  801. await userEvent.click(await screen.findByText('Cancel'));
  802. expect(window.confirm).not.toHaveBeenCalled();
  803. });
  804. it('opens the widget viewer modal using the widget id specified in the url', async () => {
  805. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  806. const widget = WidgetFixture({
  807. queries: [
  808. {
  809. name: '',
  810. conditions: 'event.type:error',
  811. fields: ['count()'],
  812. aggregates: ['count()'],
  813. columns: [],
  814. orderby: '',
  815. },
  816. ],
  817. title: 'First Widget',
  818. interval: '1d',
  819. id: '1',
  820. layout: null,
  821. });
  822. MockApiClient.addMockResponse({
  823. url: '/organizations/org-slug/dashboards/1/',
  824. body: DashboardFixture([widget], {id: '1', title: 'Custom Errors'}),
  825. });
  826. render(
  827. <ViewEditDashboard
  828. {...RouteComponentPropsFixture()}
  829. organization={initialData.organization}
  830. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
  831. router={initialData.router}
  832. location={{...initialData.router.location, pathname: '/widget/123/'}}
  833. >
  834. {null}
  835. </ViewEditDashboard>,
  836. {router: initialData.router, organization: initialData.organization}
  837. );
  838. await waitFor(() => {
  839. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  840. expect.objectContaining({
  841. organization: initialData.organization,
  842. widget,
  843. onClose: expect.anything(),
  844. })
  845. );
  846. });
  847. });
  848. it('redirects user to dashboard url if widget is not found', async () => {
  849. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  850. MockApiClient.addMockResponse({
  851. url: '/organizations/org-slug/dashboards/1/',
  852. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  853. });
  854. render(
  855. <ViewEditDashboard
  856. {...RouteComponentPropsFixture()}
  857. organization={initialData.organization}
  858. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 123}}
  859. router={initialData.router}
  860. location={{...initialData.router.location, pathname: '/widget/123/'}}
  861. >
  862. {null}
  863. </ViewEditDashboard>,
  864. {router: initialData.router, organization: initialData.organization}
  865. );
  866. expect(await screen.findByText('All Releases')).toBeInTheDocument();
  867. expect(openWidgetViewerModal).not.toHaveBeenCalled();
  868. expect(initialData.router.replace).toHaveBeenCalledWith(
  869. expect.objectContaining({
  870. pathname: '/organizations/org-slug/dashboard/1/',
  871. query: {},
  872. })
  873. );
  874. });
  875. it('saves a new dashboard with the page filters', async () => {
  876. const mockPOST = MockApiClient.addMockResponse({
  877. url: '/organizations/org-slug/dashboards/',
  878. method: 'POST',
  879. body: [],
  880. });
  881. render(
  882. <CreateDashboard
  883. {...RouteComponentPropsFixture()}
  884. organization={initialData.organization}
  885. params={{templateId: undefined}}
  886. router={initialData.router}
  887. location={{
  888. ...initialData.router.location,
  889. query: {
  890. ...initialData.router.location.query,
  891. statsPeriod: '7d',
  892. project: [2],
  893. environment: ['alpha', 'beta'],
  894. },
  895. }}
  896. >
  897. {null}
  898. </CreateDashboard>,
  899. {
  900. router: initialData.router,
  901. organization: initialData.organization,
  902. }
  903. );
  904. await userEvent.click(await screen.findByText('Save and Finish'));
  905. expect(mockPOST).toHaveBeenCalledWith(
  906. '/organizations/org-slug/dashboards/',
  907. expect.objectContaining({
  908. data: expect.objectContaining({
  909. projects: [2],
  910. environment: ['alpha', 'beta'],
  911. period: '7d',
  912. }),
  913. })
  914. );
  915. });
  916. it('saves a template with the page filters', async () => {
  917. const mockPOST = MockApiClient.addMockResponse({
  918. url: '/organizations/org-slug/dashboards/',
  919. method: 'POST',
  920. body: [],
  921. });
  922. render(
  923. <CreateDashboard
  924. {...RouteComponentPropsFixture()}
  925. organization={initialData.organization}
  926. params={{templateId: 'default-template'}}
  927. router={initialData.router}
  928. location={{
  929. ...initialData.router.location,
  930. query: {
  931. ...initialData.router.location.query,
  932. statsPeriod: '7d',
  933. project: [2],
  934. environment: ['alpha', 'beta'],
  935. },
  936. }}
  937. >
  938. {null}
  939. </CreateDashboard>,
  940. {
  941. router: initialData.router,
  942. organization: initialData.organization,
  943. }
  944. );
  945. await userEvent.click(await screen.findByText('Add Dashboard'));
  946. expect(mockPOST).toHaveBeenCalledWith(
  947. '/organizations/org-slug/dashboards/',
  948. expect.objectContaining({
  949. data: expect.objectContaining({
  950. projects: [2],
  951. environment: ['alpha', 'beta'],
  952. period: '7d',
  953. }),
  954. })
  955. );
  956. });
  957. it('does not render save and cancel buttons on templates', async () => {
  958. MockApiClient.addMockResponse({
  959. url: '/organizations/org-slug/releases/',
  960. body: [
  961. ReleaseFixture({
  962. shortVersion: 'sentry-android-shop@1.2.0',
  963. version: 'sentry-android-shop@1.2.0',
  964. }),
  965. ],
  966. });
  967. render(
  968. <CreateDashboard
  969. {...RouteComponentPropsFixture()}
  970. organization={initialData.organization}
  971. params={{templateId: 'default-template'}}
  972. router={initialData.router}
  973. location={initialData.router.location}
  974. >
  975. {null}
  976. </CreateDashboard>,
  977. {
  978. router: initialData.router,
  979. organization: initialData.organization,
  980. }
  981. );
  982. await userEvent.click(await screen.findByText('24H'));
  983. await userEvent.click(screen.getByText('Last 7 days'));
  984. await screen.findByText('7D');
  985. expect(screen.queryByTestId('filter-bar-cancel')).not.toBeInTheDocument();
  986. expect(screen.queryByText('Save')).not.toBeInTheDocument();
  987. });
  988. it('opens the widget viewer with saved dashboard filters', async () => {
  989. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  990. MockApiClient.addMockResponse({
  991. url: '/organizations/org-slug/dashboards/1/',
  992. body: DashboardFixture(widgets, {
  993. id: '1',
  994. filters: {release: ['sentry-android-shop@1.2.0']},
  995. }),
  996. });
  997. render(
  998. <ViewEditDashboard
  999. {...RouteComponentPropsFixture()}
  1000. organization={initialData.organization}
  1001. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
  1002. router={initialData.router}
  1003. location={{...initialData.router.location, pathname: '/widget/1/'}}
  1004. >
  1005. {null}
  1006. </ViewEditDashboard>,
  1007. {router: initialData.router, organization: initialData.organization}
  1008. );
  1009. await waitFor(() => {
  1010. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  1011. expect.objectContaining({
  1012. dashboardFilters: {release: ['sentry-android-shop@1.2.0']},
  1013. })
  1014. );
  1015. });
  1016. });
  1017. it('opens the widget viewer with unsaved dashboard filters', async () => {
  1018. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  1019. MockApiClient.addMockResponse({
  1020. url: '/organizations/org-slug/dashboards/1/',
  1021. body: DashboardFixture(widgets, {
  1022. id: '1',
  1023. filters: {release: ['sentry-android-shop@1.2.0']},
  1024. }),
  1025. });
  1026. render(
  1027. <ViewEditDashboard
  1028. {...RouteComponentPropsFixture()}
  1029. organization={initialData.organization}
  1030. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
  1031. router={initialData.router}
  1032. location={{
  1033. ...initialData.router.location,
  1034. pathname: '/widget/1/',
  1035. query: {release: ['unsaved-release-filter@1.2.0']},
  1036. }}
  1037. >
  1038. {null}
  1039. </ViewEditDashboard>,
  1040. {router: initialData.router, organization: initialData.organization}
  1041. );
  1042. await waitFor(() => {
  1043. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  1044. expect.objectContaining({
  1045. dashboardFilters: {release: ['unsaved-release-filter@1.2.0']},
  1046. })
  1047. );
  1048. });
  1049. });
  1050. it('can save dashboard filters in existing dashboard', async () => {
  1051. MockApiClient.addMockResponse({
  1052. url: '/organizations/org-slug/releases/',
  1053. body: [
  1054. ReleaseFixture({
  1055. shortVersion: 'sentry-android-shop@1.2.0',
  1056. version: 'sentry-android-shop@1.2.0',
  1057. }),
  1058. ],
  1059. });
  1060. const testData = initializeOrg({
  1061. organization: OrganizationFixture({
  1062. features: [
  1063. 'global-views',
  1064. 'dashboards-basic',
  1065. 'dashboards-edit',
  1066. 'discover-query',
  1067. ],
  1068. }),
  1069. router: {
  1070. location: {
  1071. ...LocationFixture(),
  1072. query: {
  1073. statsPeriod: '7d',
  1074. release: ['sentry-android-shop@1.2.0'],
  1075. },
  1076. },
  1077. },
  1078. });
  1079. render(
  1080. <ViewEditDashboard
  1081. {...RouteComponentPropsFixture()}
  1082. organization={testData.organization}
  1083. params={{orgId: 'org-slug', dashboardId: '1'}}
  1084. router={testData.router}
  1085. location={testData.router.location}
  1086. >
  1087. {null}
  1088. </ViewEditDashboard>,
  1089. {router: testData.router, organization: testData.organization}
  1090. );
  1091. await userEvent.click(await screen.findByText('Save'));
  1092. expect(mockPut).toHaveBeenCalledWith(
  1093. '/organizations/org-slug/dashboards/1/',
  1094. expect.objectContaining({
  1095. data: expect.objectContaining({
  1096. period: '7d',
  1097. filters: {release: ['sentry-android-shop@1.2.0']},
  1098. }),
  1099. })
  1100. );
  1101. });
  1102. it('can clear dashboard filters in compact select', async () => {
  1103. MockApiClient.addMockResponse({
  1104. url: '/organizations/org-slug/dashboards/1/',
  1105. body: DashboardFixture(widgets, {
  1106. id: '1',
  1107. title: 'Custom Errors',
  1108. filters: {release: ['sentry-android-shop@1.2.0']},
  1109. }),
  1110. });
  1111. MockApiClient.addMockResponse({
  1112. url: '/organizations/org-slug/releases/',
  1113. body: [
  1114. ReleaseFixture({
  1115. shortVersion: 'sentry-android-shop@1.2.0',
  1116. version: 'sentry-android-shop@1.2.0',
  1117. }),
  1118. ],
  1119. });
  1120. const testData = initializeOrg({
  1121. organization: OrganizationFixture({
  1122. features: [
  1123. 'global-views',
  1124. 'dashboards-basic',
  1125. 'dashboards-edit',
  1126. 'discover-query',
  1127. ],
  1128. }),
  1129. router: {
  1130. location: {
  1131. ...LocationFixture(),
  1132. query: {
  1133. statsPeriod: '7d',
  1134. },
  1135. },
  1136. },
  1137. });
  1138. render(
  1139. <ViewEditDashboard
  1140. {...RouteComponentPropsFixture()}
  1141. organization={testData.organization}
  1142. params={{orgId: 'org-slug', dashboardId: '1'}}
  1143. router={testData.router}
  1144. location={testData.router.location}
  1145. >
  1146. {null}
  1147. </ViewEditDashboard>,
  1148. {router: testData.router, organization: testData.organization}
  1149. );
  1150. await screen.findByText('7D');
  1151. await userEvent.click(await screen.findByText('sentry-android-shop@1.2.0'));
  1152. await userEvent.click(screen.getAllByText('Clear')[0]!);
  1153. screen.getByText('All Releases');
  1154. await userEvent.click(document.body);
  1155. await waitFor(() => {
  1156. expect(testData.router.push).toHaveBeenCalledWith(
  1157. expect.objectContaining({
  1158. query: expect.objectContaining({
  1159. release: '',
  1160. }),
  1161. })
  1162. );
  1163. });
  1164. });
  1165. it('can save absolute time range in existing dashboard', async () => {
  1166. const testData = initializeOrg({
  1167. organization: OrganizationFixture({
  1168. features: [
  1169. 'global-views',
  1170. 'dashboards-basic',
  1171. 'dashboards-edit',
  1172. 'discover-query',
  1173. ],
  1174. }),
  1175. router: {
  1176. location: {
  1177. ...LocationFixture(),
  1178. query: {
  1179. start: '2022-07-14T07:00:00',
  1180. end: '2022-07-19T23:59:59',
  1181. utc: 'true',
  1182. },
  1183. },
  1184. },
  1185. });
  1186. render(
  1187. <ViewEditDashboard
  1188. {...RouteComponentPropsFixture()}
  1189. organization={testData.organization}
  1190. params={{orgId: 'org-slug', dashboardId: '1'}}
  1191. router={testData.router}
  1192. location={testData.router.location}
  1193. >
  1194. {null}
  1195. </ViewEditDashboard>,
  1196. {router: testData.router, organization: testData.organization}
  1197. );
  1198. await userEvent.click(await screen.findByText('Save'));
  1199. expect(mockPut).toHaveBeenCalledWith(
  1200. '/organizations/org-slug/dashboards/1/',
  1201. expect.objectContaining({
  1202. data: expect.objectContaining({
  1203. start: '2022-07-14T07:00:00.000',
  1204. end: '2022-07-19T23:59:59.000',
  1205. utc: true,
  1206. }),
  1207. })
  1208. );
  1209. });
  1210. it('can clear dashboard filters in existing dashboard', async () => {
  1211. MockApiClient.addMockResponse({
  1212. url: '/organizations/org-slug/releases/',
  1213. body: [
  1214. ReleaseFixture({
  1215. shortVersion: 'sentry-android-shop@1.2.0',
  1216. version: 'sentry-android-shop@1.2.0',
  1217. }),
  1218. ],
  1219. });
  1220. const testData = initializeOrg({
  1221. organization: OrganizationFixture({
  1222. features: [
  1223. 'global-views',
  1224. 'dashboards-basic',
  1225. 'dashboards-edit',
  1226. 'discover-query',
  1227. ],
  1228. }),
  1229. router: {
  1230. location: {
  1231. ...LocationFixture(),
  1232. query: {
  1233. statsPeriod: '7d',
  1234. environment: ['alpha', 'beta'],
  1235. },
  1236. },
  1237. },
  1238. });
  1239. render(
  1240. <ViewEditDashboard
  1241. {...RouteComponentPropsFixture()}
  1242. organization={testData.organization}
  1243. params={{orgId: 'org-slug', dashboardId: '1'}}
  1244. router={testData.router}
  1245. location={testData.router.location}
  1246. >
  1247. {null}
  1248. </ViewEditDashboard>,
  1249. {router: testData.router, organization: testData.organization}
  1250. );
  1251. await screen.findByText('7D');
  1252. await userEvent.click(await screen.findByText('All Releases'));
  1253. await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
  1254. await userEvent.keyboard('{Escape}');
  1255. await userEvent.click(screen.getByTestId('filter-bar-cancel'));
  1256. screen.getByText('All Releases');
  1257. expect(testData.router.replace).toHaveBeenCalledWith(
  1258. expect.objectContaining({
  1259. query: expect.objectContaining({
  1260. project: undefined,
  1261. statsPeriod: undefined,
  1262. environment: undefined,
  1263. }),
  1264. })
  1265. );
  1266. });
  1267. it('disables the Edit Dashboard button when there are unsaved filters', async () => {
  1268. MockApiClient.addMockResponse({
  1269. url: '/organizations/org-slug/releases/',
  1270. body: [
  1271. ReleaseFixture({
  1272. shortVersion: 'sentry-android-shop@1.2.0',
  1273. version: 'sentry-android-shop@1.2.0',
  1274. }),
  1275. ],
  1276. });
  1277. const testData = initializeOrg({
  1278. organization: OrganizationFixture({
  1279. features: [
  1280. 'global-views',
  1281. 'dashboards-basic',
  1282. 'dashboards-edit',
  1283. 'discover-basic',
  1284. 'discover-query',
  1285. ],
  1286. }),
  1287. router: {
  1288. location: {
  1289. ...LocationFixture(),
  1290. query: {
  1291. statsPeriod: '7d',
  1292. environment: ['alpha', 'beta'],
  1293. },
  1294. },
  1295. },
  1296. });
  1297. render(
  1298. <ViewEditDashboard
  1299. {...RouteComponentPropsFixture()}
  1300. organization={testData.organization}
  1301. params={{orgId: 'org-slug', dashboardId: '1'}}
  1302. router={testData.router}
  1303. location={testData.router.location}
  1304. >
  1305. {null}
  1306. </ViewEditDashboard>,
  1307. {router: testData.router, organization: testData.organization}
  1308. );
  1309. expect(await screen.findByText('Save')).toBeInTheDocument();
  1310. expect(screen.getByTestId('filter-bar-cancel')).toBeInTheDocument();
  1311. expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
  1312. });
  1313. it('ignores the order of selection of page filters to render unsaved filters', async () => {
  1314. const testProjects = [
  1315. ProjectFixture({id: '1', name: 'first', environments: ['alpha', 'beta']}),
  1316. ProjectFixture({id: '2', name: 'second', environments: ['alpha', 'beta']}),
  1317. ];
  1318. act(() => ProjectsStore.loadInitialData(testProjects));
  1319. MockApiClient.addMockResponse({
  1320. url: '/organizations/org-slug/projects/',
  1321. body: testProjects,
  1322. });
  1323. MockApiClient.addMockResponse({
  1324. url: '/organizations/org-slug/dashboards/1/',
  1325. body: DashboardFixture(widgets, {
  1326. id: '1',
  1327. title: 'Custom Errors',
  1328. filters: {},
  1329. environment: ['alpha', 'beta'],
  1330. }),
  1331. });
  1332. const testData = initializeOrg({
  1333. organization: OrganizationFixture({
  1334. features: [
  1335. 'global-views',
  1336. 'dashboards-basic',
  1337. 'dashboards-edit',
  1338. 'discover-query',
  1339. ],
  1340. }),
  1341. router: {
  1342. location: {
  1343. ...LocationFixture(),
  1344. query: {
  1345. environment: ['beta', 'alpha'], // Reversed order from saved dashboard
  1346. },
  1347. },
  1348. },
  1349. });
  1350. render(
  1351. <ViewEditDashboard
  1352. {...RouteComponentPropsFixture()}
  1353. organization={testData.organization}
  1354. params={{orgId: 'org-slug', dashboardId: '1'}}
  1355. router={testData.router}
  1356. location={testData.router.location}
  1357. >
  1358. {null}
  1359. </ViewEditDashboard>,
  1360. {router: testData.router, organization: testData.organization}
  1361. );
  1362. await waitFor(() => expect(screen.queryAllByText('Loading\u2026')).toEqual([]));
  1363. await userEvent.click(screen.getByRole('button', {name: 'All Envs'}));
  1364. expect(screen.getByRole('row', {name: 'alpha'})).toHaveAttribute(
  1365. 'aria-selected',
  1366. 'true'
  1367. );
  1368. expect(screen.getByRole('row', {name: 'beta'})).toHaveAttribute(
  1369. 'aria-selected',
  1370. 'true'
  1371. );
  1372. // Save and Cancel should not appear because alpha, beta is the same as beta, alpha
  1373. expect(screen.queryByText('Save')).not.toBeInTheDocument();
  1374. expect(screen.queryByTestId('filter-bar-cancel')).not.toBeInTheDocument();
  1375. });
  1376. it('uses releases from the URL query params', async function () {
  1377. const testData = initializeOrg({
  1378. organization: OrganizationFixture({
  1379. features: [
  1380. 'global-views',
  1381. 'dashboards-basic',
  1382. 'dashboards-edit',
  1383. 'discover-query',
  1384. ],
  1385. }),
  1386. router: {
  1387. location: {
  1388. ...LocationFixture(),
  1389. query: {
  1390. release: ['not-selected-1'],
  1391. },
  1392. },
  1393. },
  1394. });
  1395. render(
  1396. <ViewEditDashboard
  1397. {...RouteComponentPropsFixture()}
  1398. organization={testData.organization}
  1399. params={{orgId: 'org-slug', dashboardId: '1'}}
  1400. router={testData.router}
  1401. location={testData.router.location}
  1402. >
  1403. {null}
  1404. </ViewEditDashboard>,
  1405. {router: testData.router, organization: testData.organization}
  1406. );
  1407. await screen.findByText(/not-selected-1/);
  1408. screen.getByText('Save');
  1409. screen.getByTestId('filter-bar-cancel');
  1410. });
  1411. it('resets release in URL params', async function () {
  1412. MockApiClient.addMockResponse({
  1413. url: '/organizations/org-slug/dashboards/1/',
  1414. body: DashboardFixture(widgets, {
  1415. id: '1',
  1416. title: 'Custom Errors',
  1417. filters: {
  1418. release: ['abc'],
  1419. },
  1420. }),
  1421. });
  1422. const testData = initializeOrg({
  1423. organization: OrganizationFixture({
  1424. features: [
  1425. 'global-views',
  1426. 'dashboards-basic',
  1427. 'dashboards-edit',
  1428. 'discover-query',
  1429. ],
  1430. }),
  1431. router: {
  1432. location: {
  1433. ...LocationFixture(),
  1434. query: {
  1435. release: ['not-selected-1'],
  1436. },
  1437. },
  1438. },
  1439. });
  1440. render(
  1441. <ViewEditDashboard
  1442. {...RouteComponentPropsFixture()}
  1443. organization={testData.organization}
  1444. params={{orgId: 'org-slug', dashboardId: '1'}}
  1445. router={testData.router}
  1446. location={testData.router.location}
  1447. >
  1448. {null}
  1449. </ViewEditDashboard>,
  1450. {router: testData.router, organization: testData.organization}
  1451. );
  1452. await screen.findByText(/not-selected-1/);
  1453. await userEvent.click(screen.getByTestId('filter-bar-cancel'));
  1454. // release isn't used in the redirect
  1455. expect(testData.router.replace).toHaveBeenCalledWith(
  1456. expect.objectContaining({
  1457. query: {
  1458. end: undefined,
  1459. environment: undefined,
  1460. project: undefined,
  1461. start: undefined,
  1462. statsPeriod: undefined,
  1463. utc: undefined,
  1464. },
  1465. })
  1466. );
  1467. });
  1468. it('reflects selections in the release filter in the query params', async function () {
  1469. MockApiClient.addMockResponse({
  1470. url: '/organizations/org-slug/releases/',
  1471. body: [
  1472. ReleaseFixture({
  1473. shortVersion: 'sentry-android-shop@1.2.0',
  1474. version: 'sentry-android-shop@1.2.0',
  1475. }),
  1476. ],
  1477. });
  1478. const testData = initializeOrg({
  1479. organization: OrganizationFixture({
  1480. features: [
  1481. 'global-views',
  1482. 'dashboards-basic',
  1483. 'dashboards-edit',
  1484. 'discover-query',
  1485. ],
  1486. }),
  1487. router: {
  1488. location: LocationFixture(),
  1489. },
  1490. });
  1491. render(
  1492. <ViewEditDashboard
  1493. {...RouteComponentPropsFixture()}
  1494. organization={testData.organization}
  1495. params={{orgId: 'org-slug', dashboardId: '1'}}
  1496. router={testData.router}
  1497. location={testData.router.location}
  1498. >
  1499. {null}
  1500. </ViewEditDashboard>,
  1501. {router: testData.router, organization: testData.organization}
  1502. );
  1503. await userEvent.click(await screen.findByText('All Releases'));
  1504. await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
  1505. await userEvent.click(document.body);
  1506. await waitFor(() => {
  1507. expect(testData.router.push).toHaveBeenCalledWith(
  1508. expect.objectContaining({
  1509. query: expect.objectContaining({
  1510. release: ['sentry-android-shop@1.2.0'],
  1511. }),
  1512. })
  1513. );
  1514. });
  1515. });
  1516. it('persists release selections made during search requests that do not appear in default query', async function () {
  1517. // Default response
  1518. MockApiClient.addMockResponse({
  1519. url: '/organizations/org-slug/releases/',
  1520. body: [
  1521. ReleaseFixture({
  1522. shortVersion: 'sentry-android-shop@1.2.0',
  1523. version: 'sentry-android-shop@1.2.0',
  1524. }),
  1525. ],
  1526. });
  1527. // Mocked search results
  1528. MockApiClient.addMockResponse({
  1529. url: '/organizations/org-slug/releases/',
  1530. body: [
  1531. ReleaseFixture({
  1532. id: '9',
  1533. shortVersion: 'search-result',
  1534. version: 'search-result',
  1535. }),
  1536. ],
  1537. match: [MockApiClient.matchData({query: 's'})],
  1538. });
  1539. const testData = initializeOrg({
  1540. organization: OrganizationFixture({
  1541. features: [
  1542. 'global-views',
  1543. 'dashboards-basic',
  1544. 'dashboards-edit',
  1545. 'discover-basic',
  1546. 'discover-query',
  1547. ],
  1548. }),
  1549. router: {
  1550. location: LocationFixture(),
  1551. },
  1552. });
  1553. render(
  1554. <ViewEditDashboard
  1555. {...RouteComponentPropsFixture()}
  1556. organization={testData.organization}
  1557. params={{orgId: 'org-slug', dashboardId: '1'}}
  1558. router={testData.router}
  1559. location={testData.router.location}
  1560. >
  1561. {null}
  1562. </ViewEditDashboard>,
  1563. {router: testData.router, organization: testData.organization}
  1564. );
  1565. await userEvent.click(await screen.findByText('All Releases'));
  1566. await userEvent.type(screen.getAllByPlaceholderText('Search\u2026')[2]!, 's');
  1567. await userEvent.click(await screen.findByRole('option', {name: 'search-result'}));
  1568. // Validate that after search is cleared, search result still appears
  1569. expect(await screen.findByText('Latest Release(s)')).toBeInTheDocument();
  1570. expect(screen.getByRole('option', {name: 'search-result'})).toBeInTheDocument();
  1571. });
  1572. it('renders edit access selector', async function () {
  1573. render(
  1574. <EditAccessSelector
  1575. dashboard={DashboardFixture([], {id: '1', title: 'Custom Errors'})}
  1576. onChangeEditAccess={jest.fn()}
  1577. />,
  1578. {
  1579. router: initialData.router,
  1580. organization: initialData.organization,
  1581. }
  1582. );
  1583. await userEvent.click(await screen.findByText('Edit Access:'));
  1584. expect(screen.getByText('Creator')).toBeInTheDocument();
  1585. expect(screen.getByText('All users')).toBeInTheDocument();
  1586. });
  1587. it('creates and updates new permissions for dashboard with no edit perms initialized', async function () {
  1588. const mockPUT = MockApiClient.addMockResponse({
  1589. url: '/organizations/org-slug/dashboards/1/',
  1590. method: 'PUT',
  1591. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  1592. });
  1593. render(
  1594. <ViewEditDashboard
  1595. {...RouteComponentPropsFixture()}
  1596. organization={initialData.organization}
  1597. params={{orgId: 'org-slug', dashboardId: '1'}}
  1598. router={initialData.router}
  1599. location={initialData.router.location}
  1600. >
  1601. {null}
  1602. </ViewEditDashboard>,
  1603. {
  1604. router: initialData.router,
  1605. organization: initialData.organization,
  1606. }
  1607. );
  1608. await userEvent.click(await screen.findByText('Edit Access:'));
  1609. // deselects 'All users' so only creator has edit access
  1610. expect(await screen.findByText('All users')).toBeEnabled();
  1611. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1612. 'aria-selected',
  1613. 'true'
  1614. );
  1615. await userEvent.click(screen.getByRole('option', {name: 'All users'}));
  1616. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1617. 'aria-selected',
  1618. 'false'
  1619. );
  1620. await userEvent.click(await screen.findByText('Save Changes'));
  1621. await waitFor(() => {
  1622. expect(mockPUT).toHaveBeenCalledTimes(1);
  1623. });
  1624. expect(mockPUT).toHaveBeenCalledWith(
  1625. '/organizations/org-slug/dashboards/1/',
  1626. expect.objectContaining({
  1627. data: expect.objectContaining({
  1628. permissions: {isEditableByEveryone: false, teamsWithEditAccess: []},
  1629. }),
  1630. })
  1631. );
  1632. });
  1633. it('creator can update permissions for dashboard', async function () {
  1634. const mockPUT = MockApiClient.addMockResponse({
  1635. url: '/organizations/org-slug/dashboards/1/',
  1636. method: 'PUT',
  1637. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  1638. });
  1639. MockApiClient.addMockResponse({
  1640. url: '/organizations/org-slug/dashboards/1/',
  1641. body: DashboardFixture([], {
  1642. id: '1',
  1643. title: 'Custom Errors',
  1644. createdBy: UserFixture({id: '781629'}),
  1645. permissions: {isEditableByEveryone: false},
  1646. }),
  1647. });
  1648. const currentUser = UserFixture({id: '781629'});
  1649. ConfigStore.set('user', currentUser);
  1650. render(
  1651. <ViewEditDashboard
  1652. {...RouteComponentPropsFixture()}
  1653. organization={initialData.organization}
  1654. params={{orgId: 'org-slug', dashboardId: '1'}}
  1655. router={initialData.router}
  1656. location={initialData.router.location}
  1657. >
  1658. {null}
  1659. </ViewEditDashboard>,
  1660. {
  1661. router: initialData.router,
  1662. organization: initialData.organization,
  1663. }
  1664. );
  1665. await userEvent.click(await screen.findByText('Edit Access:'));
  1666. // selects 'All users' so everyone has edit access
  1667. expect(await screen.findByText('All users')).toBeEnabled();
  1668. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1669. 'aria-selected',
  1670. 'false'
  1671. );
  1672. await userEvent.click(screen.getByRole('option', {name: 'All users'}));
  1673. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1674. 'aria-selected',
  1675. 'true'
  1676. );
  1677. await userEvent.click(await screen.findByText('Save Changes'));
  1678. await waitFor(() => {
  1679. expect(mockPUT).toHaveBeenCalledTimes(1);
  1680. });
  1681. expect(mockPUT).toHaveBeenCalledWith(
  1682. '/organizations/org-slug/dashboards/1/',
  1683. expect.objectContaining({
  1684. data: expect.objectContaining({
  1685. permissions: {isEditableByEveryone: true, teamsWithEditAccess: []},
  1686. }),
  1687. })
  1688. );
  1689. });
  1690. it('creator can update permissions with teams for dashboard', async function () {
  1691. const mockPUT = MockApiClient.addMockResponse({
  1692. url: '/organizations/org-slug/dashboards/1/',
  1693. method: 'PUT',
  1694. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  1695. });
  1696. MockApiClient.addMockResponse({
  1697. url: '/organizations/org-slug/dashboards/1/',
  1698. body: DashboardFixture([], {
  1699. id: '1',
  1700. title: 'Custom Errors',
  1701. createdBy: UserFixture({id: '781629'}),
  1702. permissions: {isEditableByEveryone: false},
  1703. }),
  1704. });
  1705. const currentUser = UserFixture({id: '781629'});
  1706. ConfigStore.set('user', currentUser);
  1707. const teamData = [
  1708. {
  1709. id: '1',
  1710. slug: 'team1',
  1711. name: 'Team 1',
  1712. },
  1713. {
  1714. id: '2',
  1715. slug: 'team2',
  1716. name: 'Team 2',
  1717. },
  1718. {
  1719. id: '3',
  1720. slug: 'team3',
  1721. name: 'Team 3',
  1722. },
  1723. ];
  1724. const teams = teamData.map(data => TeamFixture(data));
  1725. TeamStore.loadInitialData(teams);
  1726. render(
  1727. <ViewEditDashboard
  1728. {...RouteComponentPropsFixture()}
  1729. organization={initialData.organization}
  1730. params={{orgId: 'org-slug', dashboardId: '1'}}
  1731. router={initialData.router}
  1732. location={initialData.router.location}
  1733. >
  1734. {null}
  1735. </ViewEditDashboard>,
  1736. {
  1737. router: initialData.router,
  1738. organization: initialData.organization,
  1739. }
  1740. );
  1741. await userEvent.click(await screen.findByText('Edit Access:'));
  1742. expect(await screen.findByText('All users')).toBeEnabled();
  1743. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1744. 'aria-selected',
  1745. 'false'
  1746. );
  1747. await userEvent.click(screen.getByRole('option', {name: '#team1'}));
  1748. await userEvent.click(screen.getByRole('option', {name: '#team2'}));
  1749. await userEvent.click(await screen.findByText('Save Changes'));
  1750. await waitFor(() => {
  1751. expect(mockPUT).toHaveBeenCalledTimes(1);
  1752. });
  1753. expect(mockPUT).toHaveBeenCalledWith(
  1754. '/organizations/org-slug/dashboards/1/',
  1755. expect.objectContaining({
  1756. data: expect.objectContaining({
  1757. permissions: {isEditableByEveryone: false, teamsWithEditAccess: [1, 2]},
  1758. }),
  1759. })
  1760. );
  1761. });
  1762. it('disables edit dashboard and add widget button if user cannot edit dashboard', async function () {
  1763. MockApiClient.addMockResponse({
  1764. url: '/organizations/org-slug/dashboards/',
  1765. body: [
  1766. DashboardFixture([], {
  1767. id: '1',
  1768. title: 'Custom Errors',
  1769. createdBy: UserFixture({id: '238900'}),
  1770. permissions: {isEditableByEveryone: false},
  1771. }),
  1772. ],
  1773. });
  1774. MockApiClient.addMockResponse({
  1775. url: '/organizations/org-slug/dashboards/1/',
  1776. body: DashboardFixture([], {
  1777. id: '1',
  1778. title: 'Custom Errors',
  1779. createdBy: UserFixture({id: '238900'}),
  1780. permissions: {isEditableByEveryone: false},
  1781. }),
  1782. });
  1783. const currentUser = UserFixture({id: '781629', isSuperuser: false});
  1784. ConfigStore.set('user', currentUser);
  1785. render(
  1786. <ViewEditDashboard
  1787. {...RouteComponentPropsFixture()}
  1788. organization={{
  1789. ...initialData.organization,
  1790. features: initialData.organization.features,
  1791. access: ['org:read'],
  1792. }}
  1793. params={{orgId: 'org-slug', dashboardId: '1'}}
  1794. router={initialData.router}
  1795. location={initialData.router.location}
  1796. >
  1797. {null}
  1798. </ViewEditDashboard>,
  1799. {
  1800. router: initialData.router,
  1801. organization: {
  1802. features: initialData.organization.features,
  1803. access: ['org:read'],
  1804. },
  1805. }
  1806. );
  1807. await screen.findByText('Edit Access:');
  1808. expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
  1809. expect(screen.getByRole('button', {name: 'Add Widget'})).toBeDisabled();
  1810. });
  1811. it('disables widget edit, duplicate, and delete button when user does not have edit perms', async function () {
  1812. const widget = {
  1813. displayType: types.DisplayType.TABLE,
  1814. interval: '1d',
  1815. queries: [
  1816. {
  1817. name: 'Test Widget',
  1818. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  1819. columns: ['project'],
  1820. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  1821. conditions: '',
  1822. orderby: '',
  1823. },
  1824. ],
  1825. title: 'Transactions',
  1826. id: '1',
  1827. widgetType: types.WidgetType.DISCOVER,
  1828. };
  1829. const mockDashboard = DashboardFixture([widget], {
  1830. id: '1',
  1831. title: 'Custom Errors',
  1832. createdBy: UserFixture({id: '238900'}),
  1833. permissions: {isEditableByEveryone: false},
  1834. });
  1835. MockApiClient.addMockResponse({
  1836. url: '/organizations/org-slug/dashboards/',
  1837. body: mockDashboard,
  1838. });
  1839. MockApiClient.addMockResponse({
  1840. url: '/organizations/org-slug/dashboards/1/',
  1841. body: mockDashboard,
  1842. });
  1843. const currentUser = UserFixture({id: '781629'});
  1844. ConfigStore.set('user', currentUser);
  1845. render(
  1846. <ViewEditDashboard
  1847. {...RouteComponentPropsFixture()}
  1848. organization={{
  1849. ...initialData.organization,
  1850. features: initialData.organization.features,
  1851. access: ['org:read'],
  1852. }}
  1853. params={{orgId: 'org-slug', dashboardId: '1'}}
  1854. router={initialData.router}
  1855. location={initialData.router.location}
  1856. >
  1857. {null}
  1858. </ViewEditDashboard>,
  1859. {
  1860. router: initialData.router,
  1861. organization: {
  1862. features: initialData.organization.features,
  1863. access: ['org:read'],
  1864. },
  1865. }
  1866. );
  1867. await screen.findByText('Edit Access:');
  1868. expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
  1869. expect(screen.getByRole('button', {name: 'Add Widget'})).toBeDisabled();
  1870. await userEvent.click(await screen.findByLabelText('Widget actions'));
  1871. expect(
  1872. screen.getByRole('menuitemradio', {name: 'Duplicate Widget'})
  1873. ).toHaveAttribute('aria-disabled', 'true');
  1874. expect(screen.getByRole('menuitemradio', {name: 'Delete Widget'})).toHaveAttribute(
  1875. 'aria-disabled',
  1876. 'true'
  1877. );
  1878. expect(screen.getByRole('menuitemradio', {name: 'Edit Widget'})).toHaveAttribute(
  1879. 'aria-disabled',
  1880. 'true'
  1881. );
  1882. });
  1883. it('renders favorite button in unfavorited state', async function () {
  1884. MockApiClient.addMockResponse({
  1885. url: '/organizations/org-slug/dashboards/1/',
  1886. body: DashboardFixture([], {id: '1', title: 'Custom Errors', isFavorited: false}),
  1887. });
  1888. render(
  1889. <ViewEditDashboard
  1890. {...RouteComponentPropsFixture()}
  1891. organization={initialData.organization}
  1892. params={{orgId: 'org-slug', dashboardId: '1'}}
  1893. router={initialData.router}
  1894. location={initialData.router.location}
  1895. >
  1896. {null}
  1897. </ViewEditDashboard>,
  1898. {
  1899. router: initialData.router,
  1900. organization: {
  1901. features: ['dashboards-favourite', ...initialData.organization.features],
  1902. },
  1903. }
  1904. );
  1905. const favoriteButton = await screen.findByLabelText('dashboards-favourite');
  1906. expect(favoriteButton).toBeInTheDocument();
  1907. expect(await screen.findByLabelText('Favorite')).toBeInTheDocument();
  1908. });
  1909. it('renders favorite button in favorited state', async function () {
  1910. MockApiClient.addMockResponse({
  1911. url: '/organizations/org-slug/dashboards/1/',
  1912. body: DashboardFixture([], {id: '1', title: 'Custom Errors', isFavorited: true}),
  1913. });
  1914. render(
  1915. <ViewEditDashboard
  1916. {...RouteComponentPropsFixture()}
  1917. organization={initialData.organization}
  1918. params={{orgId: 'org-slug', dashboardId: '1'}}
  1919. router={initialData.router}
  1920. location={initialData.router.location}
  1921. >
  1922. {null}
  1923. </ViewEditDashboard>,
  1924. {
  1925. router: initialData.router,
  1926. organization: {
  1927. features: ['dashboards-favourite', ...initialData.organization.features],
  1928. },
  1929. }
  1930. );
  1931. const favoriteButton = await screen.findByLabelText('dashboards-favourite');
  1932. expect(favoriteButton).toBeInTheDocument();
  1933. expect(await screen.findByLabelText('UnFavorite')).toBeInTheDocument();
  1934. });
  1935. it('toggles favorite button', async function () {
  1936. MockApiClient.addMockResponse({
  1937. url: '/organizations/org-slug/dashboards/1/',
  1938. body: DashboardFixture([], {id: '1', title: 'Custom Errors', isFavorited: true}),
  1939. });
  1940. MockApiClient.addMockResponse({
  1941. url: '/organizations/org-slug/dashboards/1/favorite/',
  1942. method: 'PUT',
  1943. body: {isFavorited: false},
  1944. });
  1945. render(
  1946. <ViewEditDashboard
  1947. {...RouteComponentPropsFixture()}
  1948. organization={initialData.organization}
  1949. params={{orgId: 'org-slug', dashboardId: '1'}}
  1950. router={initialData.router}
  1951. location={initialData.router.location}
  1952. >
  1953. {null}
  1954. </ViewEditDashboard>,
  1955. {
  1956. router: initialData.router,
  1957. organization: {
  1958. features: ['dashboards-favourite', ...initialData.organization.features],
  1959. },
  1960. }
  1961. );
  1962. const favoriteButton = await screen.findByLabelText('dashboards-favourite');
  1963. expect(favoriteButton).toBeInTheDocument();
  1964. expect(await screen.findByLabelText('UnFavorite')).toBeInTheDocument();
  1965. await userEvent.click(favoriteButton);
  1966. expect(await screen.findByLabelText('Favorite')).toBeInTheDocument();
  1967. });
  1968. describe('widget builder redesign', function () {
  1969. let mockUpdateDashboard!: jest.SpyInstance;
  1970. beforeEach(function () {
  1971. initialData = initializeOrg({
  1972. organization: OrganizationFixture({
  1973. features: [
  1974. 'global-views',
  1975. 'dashboards-basic',
  1976. 'dashboards-edit',
  1977. 'discover-query',
  1978. 'performance-discover-dataset-selector',
  1979. 'dashboards-widget-builder-redesign',
  1980. ],
  1981. }),
  1982. });
  1983. // Mock just the updateDashboard function
  1984. mockUpdateDashboard = jest
  1985. .spyOn(dashboardActions, 'updateDashboard')
  1986. .mockResolvedValue({
  1987. ...DashboardFixture([WidgetFixture({id: '1', title: 'Custom Widget'})]),
  1988. });
  1989. jest.mocked(useWidgetBuilderState).mockReturnValue({
  1990. dispatch: jest.fn(),
  1991. state: {},
  1992. });
  1993. });
  1994. afterEach(() => {
  1995. mockUpdateDashboard.mockRestore();
  1996. });
  1997. it('opens the widget builder slideout when clicking add widget', async function () {
  1998. render(
  1999. <DashboardDetail
  2000. {...RouteComponentPropsFixture()}
  2001. initialState={DashboardState.VIEW}
  2002. dashboard={DashboardFixture([])}
  2003. dashboards={[]}
  2004. onDashboardUpdate={jest.fn()}
  2005. newWidget={undefined}
  2006. onSetNewWidget={() => {}}
  2007. />,
  2008. {organization: initialData.organization}
  2009. );
  2010. await userEvent.click(await screen.findByRole('button', {name: 'Add Widget'}));
  2011. await userEvent.click(
  2012. await screen.findByRole('menuitemradio', {name: 'Create Custom Widget'})
  2013. );
  2014. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2015. });
  2016. it('opens the widget builder library slideout when clicking add widget from widget library', async function () {
  2017. render(
  2018. <DashboardDetail
  2019. {...RouteComponentPropsFixture()}
  2020. initialState={DashboardState.VIEW}
  2021. dashboard={DashboardFixture([])}
  2022. dashboards={[]}
  2023. onDashboardUpdate={jest.fn()}
  2024. newWidget={undefined}
  2025. onSetNewWidget={() => {}}
  2026. />,
  2027. {organization: initialData.organization}
  2028. );
  2029. await userEvent.click(await screen.findByRole('button', {name: 'Add Widget'}));
  2030. await userEvent.click(
  2031. await screen.findByRole('menuitemradio', {name: 'From Widget Library'})
  2032. );
  2033. expect(await screen.findByText('Add from Widget Library')).toBeInTheDocument();
  2034. });
  2035. it('opens the widget builder slideout when clicking add widget in edit mode', async function () {
  2036. render(
  2037. <DashboardDetail
  2038. {...RouteComponentPropsFixture()}
  2039. initialState={DashboardState.EDIT}
  2040. dashboard={DashboardFixture([])}
  2041. dashboards={[]}
  2042. onDashboardUpdate={jest.fn()}
  2043. newWidget={undefined}
  2044. onSetNewWidget={() => {}}
  2045. />,
  2046. {organization: initialData.organization}
  2047. );
  2048. await userEvent.click(await screen.findByLabelText('Add Widget'));
  2049. await userEvent.click(
  2050. await screen.findByRole('menuitemradio', {name: 'Create Custom Widget'})
  2051. );
  2052. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2053. });
  2054. it('opens the widget builder library slideout when clicking add widget from widget library in edit mode', async function () {
  2055. render(
  2056. <DashboardDetail
  2057. {...RouteComponentPropsFixture()}
  2058. initialState={DashboardState.EDIT}
  2059. dashboard={DashboardFixture([])}
  2060. dashboards={[]}
  2061. onDashboardUpdate={jest.fn()}
  2062. newWidget={undefined}
  2063. onSetNewWidget={() => {}}
  2064. />,
  2065. {organization: initialData.organization}
  2066. );
  2067. await userEvent.click(await screen.findByLabelText('Add Widget'));
  2068. await userEvent.click(
  2069. await screen.findByRole('menuitemradio', {name: 'From Widget Library'})
  2070. );
  2071. expect(await screen.findByText('Add from Widget Library')).toBeInTheDocument();
  2072. });
  2073. it('allows for editing a widget in edit mode', async function () {
  2074. const mockWidget = WidgetFixture({id: '1', title: 'Custom Widget'});
  2075. const mockDashboard = DashboardFixture([mockWidget], {
  2076. id: '1',
  2077. title: 'Custom Errors',
  2078. });
  2079. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2080. dispatch: jest.fn(),
  2081. state: {
  2082. title: 'Updated Widget',
  2083. },
  2084. });
  2085. render(
  2086. <DashboardDetail
  2087. {...RouteComponentPropsFixture()}
  2088. initialState={DashboardState.EDIT}
  2089. dashboard={mockDashboard}
  2090. dashboards={[]}
  2091. onDashboardUpdate={jest.fn()}
  2092. newWidget={undefined}
  2093. onSetNewWidget={() => {}}
  2094. />,
  2095. {
  2096. organization: initialData.organization,
  2097. // Mock the widgetIndex param so it's available when the widget builder opens
  2098. router: {...initialData.router, params: {widgetIndex: '0'}},
  2099. }
  2100. );
  2101. expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
  2102. await userEvent.click(await screen.findByRole('button', {name: 'Edit Widget'}));
  2103. expect(await screen.findByText('Edit Widget')).toBeInTheDocument();
  2104. await userEvent.click(screen.getByText('Update Widget'));
  2105. // The widget builder is closed after the widget is updated
  2106. await waitFor(() => {
  2107. expect(screen.queryByText('Edit Widget')).not.toBeInTheDocument();
  2108. });
  2109. // The widget is updated in the dashboard
  2110. expect(screen.getByText('Updated Widget')).toBeInTheDocument();
  2111. });
  2112. it('allows for creating a widget in edit mode', async function () {
  2113. const mockDashboard = DashboardFixture([], {
  2114. id: '1',
  2115. title: 'Custom Errors',
  2116. });
  2117. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2118. dispatch: jest.fn(),
  2119. state: {
  2120. title: 'Totally new widget',
  2121. },
  2122. });
  2123. render(
  2124. <DashboardDetail
  2125. {...RouteComponentPropsFixture()}
  2126. initialState={DashboardState.EDIT}
  2127. dashboard={mockDashboard}
  2128. dashboards={[]}
  2129. onDashboardUpdate={jest.fn()}
  2130. newWidget={undefined}
  2131. onSetNewWidget={() => {}}
  2132. />,
  2133. {
  2134. organization: initialData.organization,
  2135. }
  2136. );
  2137. await userEvent.click(await screen.findByLabelText('Add Widget'));
  2138. await userEvent.click(
  2139. await screen.findByRole('menuitemradio', {name: 'Create Custom Widget'})
  2140. );
  2141. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2142. await userEvent.click(screen.getByText('Add Widget'));
  2143. // The widget builder is closed after the widget is updated
  2144. await waitFor(() => {
  2145. expect(screen.queryByText('Create Custom Widget')).not.toBeInTheDocument();
  2146. });
  2147. // The widget is added in the dashboard
  2148. expect(screen.getByText('Totally new widget')).toBeInTheDocument();
  2149. });
  2150. it('allows for editing a widget in view mode', async function () {
  2151. const mockWidget = WidgetFixture({id: '1', title: 'Custom Widget'});
  2152. const mockDashboard = DashboardFixture([mockWidget], {
  2153. id: '1',
  2154. title: 'Custom Errors',
  2155. });
  2156. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2157. dispatch: jest.fn(),
  2158. state: {
  2159. title: 'Updated Widget Title',
  2160. },
  2161. });
  2162. render(
  2163. <DashboardDetail
  2164. {...RouteComponentPropsFixture()}
  2165. initialState={DashboardState.VIEW}
  2166. dashboard={mockDashboard}
  2167. dashboards={[]}
  2168. onDashboardUpdate={jest.fn()}
  2169. newWidget={undefined}
  2170. onSetNewWidget={() => {}}
  2171. />,
  2172. {
  2173. organization: initialData.organization,
  2174. // Mock the widgetIndex param so it's available when the widget builder opens
  2175. router: {...initialData.router, params: {widgetIndex: '0'}},
  2176. }
  2177. );
  2178. expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
  2179. await userEvent.click(await screen.findByLabelText('Widget actions'));
  2180. await userEvent.click(
  2181. await screen.findByRole('menuitemradio', {name: 'Edit Widget'})
  2182. );
  2183. expect(await screen.findByText('Edit Widget')).toBeInTheDocument();
  2184. await userEvent.click(screen.getByText('Update Widget'));
  2185. // The widget builder is closed after the widget is updated
  2186. await waitFor(() => {
  2187. expect(screen.queryByText('Edit Widget')).not.toBeInTheDocument();
  2188. });
  2189. // The update action is called with the updated widget
  2190. expect(mockUpdateDashboard).toHaveBeenCalledWith(
  2191. expect.anything(),
  2192. expect.anything(),
  2193. expect.objectContaining({
  2194. widgets: [expect.objectContaining({title: 'Updated Widget Title'})],
  2195. })
  2196. );
  2197. });
  2198. it('allows for creating a widget in view mode', async function () {
  2199. const mockDashboard = DashboardFixture([], {
  2200. id: '1',
  2201. title: 'Custom Errors',
  2202. });
  2203. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2204. dispatch: jest.fn(),
  2205. state: {
  2206. title: 'Totally new widget',
  2207. },
  2208. });
  2209. render(
  2210. <DashboardDetail
  2211. {...RouteComponentPropsFixture()}
  2212. initialState={DashboardState.VIEW}
  2213. dashboard={mockDashboard}
  2214. dashboards={[]}
  2215. onDashboardUpdate={jest.fn()}
  2216. newWidget={undefined}
  2217. onSetNewWidget={() => {}}
  2218. />,
  2219. {
  2220. organization: initialData.organization,
  2221. }
  2222. );
  2223. await userEvent.click(await screen.findByRole('button', {name: 'Add Widget'}));
  2224. await userEvent.click(
  2225. await screen.findByRole('menuitemradio', {name: 'Create Custom Widget'})
  2226. );
  2227. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2228. await userEvent.click(
  2229. await within(screen.getByTestId('widget-slideout')).findByText('Add Widget')
  2230. );
  2231. // The widget builder is closed after the widget is updated
  2232. await waitFor(() => {
  2233. expect(screen.queryByText('Create Custom Widget')).not.toBeInTheDocument();
  2234. });
  2235. // The update action is called with the new widget
  2236. expect(mockUpdateDashboard).toHaveBeenCalledWith(
  2237. expect.anything(),
  2238. expect.anything(),
  2239. expect.objectContaining({
  2240. widgets: [expect.objectContaining({title: 'Totally new widget'})],
  2241. })
  2242. );
  2243. });
  2244. });
  2245. describe('discover split', function () {
  2246. it('calls the dashboard callbacks with the correct widgetType for discover split', function () {
  2247. const widget = {
  2248. displayType: types.DisplayType.TABLE,
  2249. interval: '1d',
  2250. queries: [
  2251. {
  2252. name: 'Test Widget',
  2253. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  2254. columns: ['project'],
  2255. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  2256. conditions: '',
  2257. orderby: '',
  2258. },
  2259. ],
  2260. title: 'Transactions',
  2261. id: '1',
  2262. widgetType: types.WidgetType.DISCOVER,
  2263. };
  2264. const mockDashboard = DashboardFixture([widget], {
  2265. id: '1',
  2266. title: 'Custom Errors',
  2267. });
  2268. const mockModifiedDashboard = DashboardFixture([widget], {
  2269. id: '1',
  2270. title: 'Custom Errors',
  2271. });
  2272. const mockOnDashboardUpdate = jest.fn();
  2273. const mockStateSetter = jest
  2274. .fn()
  2275. .mockImplementation(fn => fn({modifiedDashboard: mockModifiedDashboard}));
  2276. handleUpdateDashboardSplit({
  2277. widgetId: '1',
  2278. splitDecision: types.WidgetType.ERRORS,
  2279. dashboard: mockDashboard,
  2280. modifiedDashboard: mockModifiedDashboard,
  2281. onDashboardUpdate: mockOnDashboardUpdate,
  2282. stateSetter: mockStateSetter,
  2283. });
  2284. expect(mockOnDashboardUpdate).toHaveBeenCalledWith({
  2285. ...mockDashboard,
  2286. widgets: [{...widget, widgetType: types.WidgetType.ERRORS}],
  2287. });
  2288. expect(mockStateSetter).toHaveReturnedWith({
  2289. modifiedDashboard: {
  2290. ...mockModifiedDashboard,
  2291. widgets: [{...widget, widgetType: types.WidgetType.ERRORS}],
  2292. },
  2293. });
  2294. });
  2295. });
  2296. });
  2297. });