organizationMembersList.spec.tsx 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601
  1. import {browserHistory} from 'react-router';
  2. import selectEvent from 'react-select-event';
  3. import {AuthProvider} from 'sentry-fixture/authProvider';
  4. import {Members} from 'sentry-fixture/members';
  5. import {Organization} from 'sentry-fixture/organization';
  6. import RouterContextFixture from 'sentry-fixture/routerContextFixture';
  7. import {Team} from 'sentry-fixture/team';
  8. import {User} from 'sentry-fixture/user';
  9. import {
  10. render,
  11. renderGlobalModal,
  12. screen,
  13. userEvent,
  14. waitFor,
  15. within,
  16. } from 'sentry-test/reactTestingLibrary';
  17. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  18. import ConfigStore from 'sentry/stores/configStore';
  19. import OrganizationsStore from 'sentry/stores/organizationsStore';
  20. import {trackAnalytics} from 'sentry/utils/analytics';
  21. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  22. jest.mock('sentry/utils/analytics');
  23. jest.mock('sentry/api');
  24. jest.mock('sentry/actionCreators/indicator');
  25. const roles = [
  26. {
  27. id: 'admin',
  28. name: 'Admin',
  29. desc: 'This is the admin role',
  30. allowed: true,
  31. },
  32. {
  33. id: 'member',
  34. name: 'Member',
  35. desc: 'This is the member role',
  36. allowed: true,
  37. },
  38. {
  39. id: 'owner',
  40. name: 'Owner',
  41. desc: 'This is the owner role',
  42. allowed: true,
  43. },
  44. ];
  45. // const missingMembers = [
  46. // {
  47. // integration: 'github',
  48. // users: TestStubs.MissingMembers(),
  49. // },
  50. // ];
  51. describe('OrganizationMembersList', function () {
  52. const members = TestStubs.Members();
  53. const ownerTeam = Team({slug: 'owner-team', orgRole: 'owner'});
  54. const member = TestStubs.Member({
  55. id: '5',
  56. email: 'member@sentry.io',
  57. teams: [ownerTeam.slug],
  58. teamRoles: [
  59. {
  60. teamSlug: ownerTeam.slug,
  61. role: null,
  62. },
  63. ],
  64. flags: {
  65. 'sso:linked': true,
  66. },
  67. groupOrgRoles: [
  68. {
  69. teamSlug: ownerTeam.slug,
  70. role: {id: 'owner'},
  71. },
  72. ],
  73. });
  74. const currentUser = members[1];
  75. const organization = Organization({
  76. access: ['member:admin', 'org:admin', 'member:write'],
  77. status: {
  78. id: 'active',
  79. name: 'active',
  80. },
  81. });
  82. const router = TestStubs.router();
  83. const defaultProps = {
  84. organization,
  85. router,
  86. location: router.location,
  87. routes: router.routes,
  88. route: router.routes[0],
  89. params: router.params,
  90. routeParams: router.params,
  91. };
  92. jest.spyOn(ConfigStore, 'get').mockImplementation(() => currentUser);
  93. afterAll(function () {
  94. (ConfigStore.get as jest.Mock).mockRestore();
  95. });
  96. beforeEach(function () {
  97. MockApiClient.clearMockResponses();
  98. MockApiClient.addMockResponse({
  99. url: '/organizations/org-slug/members/me/',
  100. method: 'GET',
  101. body: {roles},
  102. });
  103. MockApiClient.addMockResponse({
  104. url: '/organizations/org-slug/members/',
  105. method: 'GET',
  106. body: [...Members(), member],
  107. });
  108. MockApiClient.addMockResponse({
  109. url: `/organizations/org-slug/members/${member.id}/`,
  110. body: member,
  111. });
  112. MockApiClient.addMockResponse({
  113. url: '/organizations/org-slug/access-requests/',
  114. method: 'GET',
  115. body: [
  116. {
  117. id: 'pending-id',
  118. member: {
  119. id: 'pending-member-id',
  120. email: '',
  121. name: '',
  122. role: '',
  123. roleName: '',
  124. user: {
  125. id: '',
  126. name: 'sentry@test.com',
  127. },
  128. },
  129. team: Team(),
  130. },
  131. ],
  132. });
  133. MockApiClient.addMockResponse({
  134. url: '/organizations/org-slug/auth-provider/',
  135. method: 'GET',
  136. body: {
  137. ...AuthProvider(),
  138. require_link: true,
  139. },
  140. });
  141. MockApiClient.addMockResponse({
  142. url: '/organizations/org-slug/teams/',
  143. method: 'GET',
  144. body: [Team(), ownerTeam],
  145. });
  146. MockApiClient.addMockResponse({
  147. url: '/organizations/org-slug/invite-requests/',
  148. method: 'GET',
  149. body: [],
  150. });
  151. MockApiClient.addMockResponse({
  152. url: '/organizations/org-slug/missing-members/',
  153. method: 'GET',
  154. body: [],
  155. });
  156. MockApiClient.addMockResponse({
  157. url: '/prompts-activity/',
  158. method: 'GET',
  159. body: {
  160. dismissed_ts: undefined,
  161. snoozed_ts: undefined,
  162. },
  163. });
  164. (browserHistory.push as jest.Mock).mockReset();
  165. OrganizationsStore.load([organization]);
  166. });
  167. it('can remove a member', async function () {
  168. const deleteMock = MockApiClient.addMockResponse({
  169. url: `/organizations/org-slug/members/${members[0].id}/`,
  170. method: 'DELETE',
  171. });
  172. render(<OrganizationMembersList {...defaultProps} />, {
  173. context: RouterContextFixture([{organization}]),
  174. });
  175. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  176. renderGlobalModal();
  177. await userEvent.click(screen.getByTestId('confirm-button'));
  178. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  179. expect(deleteMock).toHaveBeenCalled();
  180. expect(browserHistory.push).not.toHaveBeenCalled();
  181. expect(OrganizationsStore.getAll()).toEqual([organization]);
  182. });
  183. it('displays error message when failing to remove member', async function () {
  184. const deleteMock = MockApiClient.addMockResponse({
  185. url: `/organizations/org-slug/members/${members[0].id}/`,
  186. method: 'DELETE',
  187. statusCode: 500,
  188. });
  189. render(<OrganizationMembersList {...defaultProps} />, {
  190. context: RouterContextFixture([{organization}]),
  191. });
  192. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  193. renderGlobalModal();
  194. await userEvent.click(screen.getByTestId('confirm-button'));
  195. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  196. expect(deleteMock).toHaveBeenCalled();
  197. expect(browserHistory.push).not.toHaveBeenCalled();
  198. expect(OrganizationsStore.getAll()).toEqual([organization]);
  199. });
  200. it('can leave org', async function () {
  201. const deleteMock = MockApiClient.addMockResponse({
  202. url: `/organizations/org-slug/members/${members[1].id}/`,
  203. method: 'DELETE',
  204. });
  205. render(<OrganizationMembersList {...defaultProps} />, {
  206. context: RouterContextFixture([{organization}]),
  207. });
  208. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  209. renderGlobalModal();
  210. await userEvent.click(screen.getByTestId('confirm-button'));
  211. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  212. expect(deleteMock).toHaveBeenCalled();
  213. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  214. expect(browserHistory.push).toHaveBeenCalledWith('/organizations/new/');
  215. });
  216. it('can redirect to remaining org after leaving', async function () {
  217. const deleteMock = MockApiClient.addMockResponse({
  218. url: `/organizations/org-slug/members/${members[1].id}/`,
  219. method: 'DELETE',
  220. });
  221. const secondOrg = Organization({
  222. slug: 'org-two',
  223. status: {
  224. id: 'active',
  225. name: 'active',
  226. },
  227. });
  228. OrganizationsStore.addOrReplace(secondOrg);
  229. render(<OrganizationMembersList {...defaultProps} />, {
  230. context: RouterContextFixture([{organization}]),
  231. });
  232. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  233. renderGlobalModal();
  234. await userEvent.click(screen.getByTestId('confirm-button'));
  235. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  236. expect(deleteMock).toHaveBeenCalled();
  237. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  238. expect(browserHistory.push).toHaveBeenCalledWith(
  239. `/organizations/${secondOrg.slug}/issues/`
  240. );
  241. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  242. });
  243. it('displays error message when failing to leave org', async function () {
  244. const deleteMock = MockApiClient.addMockResponse({
  245. url: `/organizations/org-slug/members/${members[1].id}/`,
  246. method: 'DELETE',
  247. statusCode: 500,
  248. });
  249. render(<OrganizationMembersList {...defaultProps} />, {
  250. context: RouterContextFixture([{organization}]),
  251. });
  252. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  253. renderGlobalModal();
  254. await userEvent.click(screen.getByTestId('confirm-button'));
  255. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  256. expect(deleteMock).toHaveBeenCalled();
  257. expect(browserHistory.push).not.toHaveBeenCalled();
  258. expect(OrganizationsStore.getAll()).toEqual([organization]);
  259. });
  260. it('can re-send SSO link to member', async function () {
  261. const inviteMock = MockApiClient.addMockResponse({
  262. url: `/organizations/org-slug/members/${members[0].id}/`,
  263. method: 'PUT',
  264. body: {
  265. id: '1234',
  266. },
  267. });
  268. render(<OrganizationMembersList {...defaultProps} />, {
  269. context: RouterContextFixture([{organization}]),
  270. });
  271. expect(inviteMock).not.toHaveBeenCalled();
  272. await userEvent.click(screen.getByRole('button', {name: 'Resend SSO link'}));
  273. expect(inviteMock).toHaveBeenCalled();
  274. });
  275. it('can re-send invite to member', async function () {
  276. const inviteMock = MockApiClient.addMockResponse({
  277. url: `/organizations/org-slug/members/${members[1].id}/`,
  278. method: 'PUT',
  279. body: {
  280. id: '1234',
  281. },
  282. });
  283. render(<OrganizationMembersList {...defaultProps} />, {
  284. context: RouterContextFixture([{organization}]),
  285. });
  286. expect(inviteMock).not.toHaveBeenCalled();
  287. await userEvent.click(screen.getByRole('button', {name: 'Resend invite'}));
  288. expect(inviteMock).toHaveBeenCalled();
  289. });
  290. it('can search organization members', async function () {
  291. const searchMock = MockApiClient.addMockResponse({
  292. url: '/organizations/org-slug/members/',
  293. body: [],
  294. });
  295. const routerContext = RouterContextFixture();
  296. render(<OrganizationMembersList {...defaultProps} />, {
  297. context: routerContext,
  298. });
  299. await userEvent.type(screen.getByPlaceholderText('Search Members'), 'member');
  300. expect(searchMock).toHaveBeenLastCalledWith(
  301. '/organizations/org-slug/members/',
  302. expect.objectContaining({
  303. method: 'GET',
  304. query: {
  305. query: 'member',
  306. },
  307. })
  308. );
  309. await userEvent.keyboard('{enter}');
  310. expect(routerContext.context.router.push).toHaveBeenCalledTimes(1);
  311. });
  312. it('can filter members', async function () {
  313. const searchMock = MockApiClient.addMockResponse({
  314. url: '/organizations/org-slug/members/',
  315. body: [],
  316. });
  317. const routerContext = RouterContextFixture();
  318. render(<OrganizationMembersList {...defaultProps} />, {
  319. context: routerContext,
  320. });
  321. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  322. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  323. expect(searchMock).toHaveBeenLastCalledWith(
  324. '/organizations/org-slug/members/',
  325. expect.objectContaining({
  326. method: 'GET',
  327. query: {query: 'role:member'},
  328. })
  329. );
  330. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  331. for (const [filter, label] of [
  332. ['isInvited', 'Invited'],
  333. ['has2fa', '2FA'],
  334. ['ssoLinked', 'SSO Linked'],
  335. ]) {
  336. const filterSection = screen.getByRole('listbox', {name: label});
  337. await userEvent.click(
  338. within(filterSection).getByRole('option', {
  339. name: 'True',
  340. })
  341. );
  342. expect(searchMock).toHaveBeenLastCalledWith(
  343. '/organizations/org-slug/members/',
  344. expect.objectContaining({
  345. method: 'GET',
  346. query: {query: `${filter}:true`},
  347. })
  348. );
  349. await userEvent.click(
  350. within(filterSection).getByRole('option', {
  351. name: 'False',
  352. })
  353. );
  354. expect(searchMock).toHaveBeenLastCalledWith(
  355. '/organizations/org-slug/members/',
  356. expect.objectContaining({
  357. method: 'GET',
  358. query: {query: `${filter}:false`},
  359. })
  360. );
  361. await userEvent.click(
  362. within(filterSection).getByRole('option', {
  363. name: 'All',
  364. })
  365. );
  366. }
  367. });
  368. it('can filter members with org roles from team membership', async function () {
  369. const routerContext = RouterContextFixture();
  370. render(<OrganizationMembersList {...defaultProps} />, {
  371. context: routerContext,
  372. });
  373. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  374. await userEvent.click(screen.getByRole('option', {name: 'Owner'}));
  375. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  376. const owners = screen.queryAllByText('Owner');
  377. expect(owners).toHaveLength(3);
  378. });
  379. describe('OrganizationInviteRequests', function () {
  380. const inviteRequest = TestStubs.Member({
  381. id: '123',
  382. user: null,
  383. inviteStatus: 'requested_to_be_invited',
  384. inviter: User(),
  385. role: 'member',
  386. teams: [],
  387. });
  388. const joinRequest = TestStubs.Member({
  389. id: '456',
  390. user: null,
  391. email: 'test@gmail.com',
  392. inviteStatus: 'requested_to_join',
  393. role: 'member',
  394. teams: [],
  395. });
  396. it('disable buttons for no access', function () {
  397. const org = Organization({
  398. status: {
  399. id: 'active',
  400. name: 'active',
  401. },
  402. });
  403. MockApiClient.addMockResponse({
  404. url: '/organizations/org-slug/invite-requests/',
  405. method: 'GET',
  406. body: [inviteRequest],
  407. });
  408. MockApiClient.addMockResponse({
  409. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  410. method: 'PUT',
  411. });
  412. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  413. context: RouterContextFixture([{organization: org}]),
  414. });
  415. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  416. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  417. });
  418. it('can approve invite request and update', async function () {
  419. const org = Organization({
  420. access: ['member:admin', 'org:admin', 'member:write'],
  421. status: {
  422. id: 'active',
  423. name: 'active',
  424. },
  425. });
  426. MockApiClient.addMockResponse({
  427. url: '/organizations/org-slug/invite-requests/',
  428. method: 'GET',
  429. body: [inviteRequest],
  430. });
  431. MockApiClient.addMockResponse({
  432. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  433. method: 'PUT',
  434. });
  435. render(<OrganizationMembersList {...defaultProps} />, {
  436. context: RouterContextFixture([{organization: org}]),
  437. });
  438. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  439. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  440. renderGlobalModal();
  441. await userEvent.click(screen.getByTestId('confirm-button'));
  442. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  443. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.approved', {
  444. invite_status: inviteRequest.inviteStatus,
  445. member_id: parseInt(inviteRequest.id, 10),
  446. organization: org,
  447. });
  448. });
  449. it('can deny invite request and remove', async function () {
  450. const org = Organization({
  451. access: ['member:admin', 'org:admin', 'member:write'],
  452. status: {
  453. id: 'active',
  454. name: 'active',
  455. },
  456. });
  457. MockApiClient.addMockResponse({
  458. url: '/organizations/org-slug/invite-requests/',
  459. method: 'GET',
  460. body: [joinRequest],
  461. });
  462. MockApiClient.addMockResponse({
  463. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  464. method: 'DELETE',
  465. });
  466. render(<OrganizationMembersList {...defaultProps} />, {
  467. context: RouterContextFixture([{organization: org}]),
  468. });
  469. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  470. await userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  471. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  472. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.denied', {
  473. invite_status: joinRequest.inviteStatus,
  474. member_id: parseInt(joinRequest.id, 10),
  475. organization: org,
  476. });
  477. });
  478. it('can update invite requests', async function () {
  479. const org = Organization({
  480. access: ['member:admin', 'org:admin', 'member:write'],
  481. status: {
  482. id: 'active',
  483. name: 'active',
  484. },
  485. });
  486. MockApiClient.addMockResponse({
  487. url: '/organizations/org-slug/invite-requests/',
  488. method: 'GET',
  489. body: [inviteRequest],
  490. });
  491. const updateWithApprove = MockApiClient.addMockResponse({
  492. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  493. method: 'PUT',
  494. });
  495. render(<OrganizationMembersList {...defaultProps} />, {
  496. context: RouterContextFixture([{organization: org}]),
  497. });
  498. await selectEvent.select(screen.getAllByRole('textbox')[1], ['Admin']);
  499. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  500. renderGlobalModal();
  501. await userEvent.click(screen.getByTestId('confirm-button'));
  502. expect(updateWithApprove).toHaveBeenCalledWith(
  503. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  504. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  505. );
  506. });
  507. });
  508. });