123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407 |
- import {browserHistory} from 'react-router';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- act,
- render,
- screen,
- userEvent,
- waitFor,
- within,
- } from 'sentry-test/reactTestingLibrary';
- import * as modals from 'sentry/actionCreators/modal';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import CreateDashboard from 'sentry/views/dashboards/create';
- import * as types from 'sentry/views/dashboards/types';
- import ViewEditDashboard from 'sentry/views/dashboards/view';
- import {OrganizationContext} from 'sentry/views/organizationContext';
- jest.mock('sentry/components/charts/worldMapChart', () => ({
- WorldMapChart: () => null,
- }));
- describe('Dashboards > Detail', function () {
- const organization = TestStubs.Organization({
- features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
- });
- const projects = [TestStubs.Project()];
- describe('prebuilt dashboards', function () {
- let initialData;
- beforeEach(function () {
- act(() => ProjectsStore.loadInitialData(projects));
- initialData = initializeOrg({organization});
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [TestStubs.Project()],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- TestStubs.Dashboard([], {id: 'default-overview', title: 'Default'}),
- TestStubs.Dashboard([], {id: '1', title: 'Custom Errors'}),
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/default-overview/',
- body: TestStubs.Dashboard([], {id: 'default-overview', title: 'Default'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/visit/',
- method: 'POST',
- body: [],
- statusCode: 200,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/sdk-updates/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/prompts-activity/',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-geo/',
- body: {data: [], meta: {}},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/issues/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- });
- it('assigns unique IDs to all widgets so grid keys are unique', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/default-overview/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'Default Widget 1',
- interval: '1d',
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:transaction',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'Default Widget 2',
- interval: '1d',
- }
- ),
- ],
- {id: 'default-overview', title: 'Default'}
- ),
- });
- initialData = initializeOrg({
- organization: TestStubs.Organization({
- features: ['global-views', 'dashboards-basic', 'discover-query'],
- projects: [TestStubs.Project()],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: 'default-overview'}}
- router={initialData.router}
- location={initialData.router.location}
- />
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- expect(await screen.findByText('Default Widget 1')).toBeInTheDocument();
- expect(screen.getByText('Default Widget 2')).toBeInTheDocument();
- });
- it('opens the widget viewer modal in a prebuilt dashboard using the widget id specified in the url', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- render(
- <CreateDashboard
- organization={initialData.organization}
- params={{templateId: 'default-template', widgetId: '2'}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/2/'}}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- organization: initialData.organization,
- widget: expect.objectContaining({
- displayType: 'line',
- interval: '5m',
- queries: [
- {
- aggregates: ['count()'],
- columns: [],
- conditions: '!event.type:transaction',
- fields: ['count()'],
- name: 'Events',
- orderby: 'count()',
- },
- ],
- title: 'Events',
- widgetType: 'discover',
- }),
- onClose: expect.anything(),
- })
- );
- });
- });
- });
- describe('custom dashboards', function () {
- let initialData, widgets, mockVisit, mockPut;
- beforeEach(function () {
- window.confirm = jest.fn();
- initialData = initializeOrg({
- organization,
- router: {
- location: TestStubs.location(),
- },
- });
- widgets = [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- columns: [],
- aggregates: ['count()'],
- },
- ],
- {
- title: 'Errors',
- interval: '1d',
- widgetType: 'discover',
- id: '1',
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:transaction',
- fields: ['count()'],
- columns: [],
- aggregates: ['count()'],
- },
- ],
- {
- title: 'Transactions',
- interval: '1d',
- widgetType: 'discover',
- id: '2',
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:transaction transaction:/api/cats',
- fields: ['p50()'],
- columns: [],
- aggregates: ['p50()'],
- },
- ],
- {
- title: 'p50 of /api/cats',
- interval: '1d',
- id: '3',
- }
- ),
- ];
- mockVisit = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/visit/',
- method: 'POST',
- body: [],
- statusCode: 200,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [TestStubs.Project()],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- TestStubs.Dashboard([], {
- id: 'default-overview',
- title: 'Default',
- widgetDisplay: ['area'],
- }),
- TestStubs.Dashboard([], {
- id: '1',
- title: 'Custom Errors',
- widgetDisplay: ['area'],
- }),
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {},
- }),
- });
- mockPut = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: TestStubs.Dashboard(widgets, {id: '1', title: 'Custom Errors'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- method: 'POST',
- url: '/organizations/org-slug/dashboards/widgets/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/recent-searches/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/issues/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-geo/',
- body: {data: [], meta: {}},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/sdk-updates/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/prompts-activity/',
- body: {},
- });
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- });
- it('can remove widgets', async function () {
- const updateMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: TestStubs.Dashboard([widgets[0]], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- await waitFor(() => expect(mockVisit).toHaveBeenCalledTimes(1));
- // Enter edit mode.
- await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
- // Remove the second and third widgets
- await userEvent.click(screen.getAllByRole('button', {name: 'Delete Widget'})[1]);
- await userEvent.click(screen.getAllByRole('button', {name: 'Delete Widget'})[1]);
- // Save changes
- await userEvent.click(screen.getByRole('button', {name: 'Save and Finish'}));
- expect(updateMock).toHaveBeenCalled();
- expect(updateMock).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- title: 'Custom Errors',
- widgets: [expect.objectContaining(widgets[0])],
- }),
- })
- );
- // Visit should not be called again on dashboard update
- expect(mockVisit).toHaveBeenCalledTimes(1);
- });
- it('appends dashboard-level filters to series request', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {release: ['abc@1.2.0']},
- }),
- });
- const mock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- await waitFor(() =>
- expect(mock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query: 'event.type:transaction transaction:/api/cats release:abc@1.2.0 ',
- }),
- })
- )
- );
- });
- it('shows add widget option', async function () {
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- // Enter edit mode.
- await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
- expect(await screen.findByRole('button', {name: 'Add widget'})).toBeInTheDocument();
- });
- it('shows top level release filter', async function () {
- const mockReleases = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [TestStubs.Release()],
- });
- initialData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- projects: [TestStubs.Project()],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- expect(await screen.findByText('All Releases')).toBeInTheDocument();
- expect(mockReleases).toHaveBeenCalledTimes(1);
- });
- it('hides add widget option', async function () {
- types.MAX_WIDGETS = 1;
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />
- </OrganizationContext.Provider>,
- {context: initialData.routerContext}
- );
- // Enter edit mode.
- await userEvent.click(await screen.findByRole('button', {name: 'Edit Dashboard'}));
- expect(screen.queryByRole('button', {name: 'Add widget'})).not.toBeInTheDocument();
- });
- it('renders successfully if more widgets than stored layouts', async function () {
- // A case where someone has async added widgets to a dashboard
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {i: 'grid-item-1', x: 0, y: 0, w: 2, h: 6},
- }
- ),
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'Second Widget',
- interval: '1d',
- id: '2',
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- expect(await screen.findByText('First Widget')).toBeInTheDocument();
- expect(await screen.findByText('Second Widget')).toBeInTheDocument();
- });
- it('does not trigger request if layout not updated', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {i: 'grid-item-1', x: 0, y: 0, w: 2, h: 6},
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- await userEvent.click(await screen.findByText('Save and Finish'));
- expect(screen.getByText('Edit Dashboard')).toBeInTheDocument();
- expect(mockPut).not.toHaveBeenCalled();
- });
- it('renders the custom resize handler for a widget', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {i: 'grid-item-1', x: 0, y: 0, w: 2, h: 6},
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- const widget = screen.getByText('First Widget').closest('.react-grid-item');
- const resizeHandle = within(widget).getByTestId('custom-resize-handle');
- expect(resizeHandle).toBeVisible();
- });
- it('does not trigger an alert when the widgets have no layout and user cancels without changes', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(
- [
- TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: null,
- }
- ),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- await userEvent.click(await screen.findByText('Cancel'));
- expect(window.confirm).not.toHaveBeenCalled();
- });
- it('opens the widget viewer modal using the widget id specified in the url', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- const widget = TestStubs.Widget(
- [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '',
- },
- ],
- {
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: null,
- }
- );
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard([widget], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: '1'}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/123/'}}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- organization: initialData.organization,
- widget,
- onClose: expect.anything(),
- })
- );
- });
- });
- it('redirects user to dashboard url if widget is not found', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard([], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: '123'}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/123/'}}
- />,
- {context: initialData.routerContext, organization: initialData.organization}
- );
- expect(await screen.findByText('All Releases')).toBeInTheDocument();
- expect(openWidgetViewerModal).not.toHaveBeenCalled();
- expect(initialData.router.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/1/',
- query: {},
- })
- );
- });
- it('saves a new dashboard with the page filters', async () => {
- const mockPOST = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- method: 'POST',
- body: [],
- });
- render(
- <CreateDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug'}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- query: {
- ...initialData.router.location.query,
- statsPeriod: '7d',
- project: [2],
- environment: ['alpha', 'beta'],
- },
- }}
- />,
- {
- context: initialData.routerContext,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('Save and Finish'));
- expect(mockPOST).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/',
- expect.objectContaining({
- data: expect.objectContaining({
- projects: [2],
- environment: ['alpha', 'beta'],
- period: '7d',
- }),
- })
- );
- });
- it('saves a template with the page filters', async () => {
- const mockPOST = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- method: 'POST',
- body: [],
- });
- render(
- <CreateDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', templateId: 'default-template'}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- query: {
- ...initialData.router.location.query,
- statsPeriod: '7d',
- project: [2],
- environment: ['alpha', 'beta'],
- },
- }}
- />,
- {
- context: initialData.routerContext,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('Add Dashboard'));
- expect(mockPOST).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/',
- expect.objectContaining({
- data: expect.objectContaining({
- projects: [2],
- environment: ['alpha', 'beta'],
- period: '7d',
- }),
- })
- );
- });
- it('does not render save and cancel buttons on templates', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- render(
- <CreateDashboard
- organization={initialData.organization}
- params={{orgId: 'org-slug', templateId: 'default-template'}}
- router={initialData.router}
- location={initialData.router.location}
- />,
- {
- context: initialData.routerContext,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('24H'));
- await userEvent.click(screen.getByText('Last 7 days'));
- await screen.findByText('7D');
- expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
- expect(screen.queryByText('Save')).not.toBeInTheDocument();
- });
- it('can save dashboard filters in existing dashboard', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- release: ['sentry-android-shop@1.2.0'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('Save'));
- expect(mockPut).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- period: '7d',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- })
- );
- });
- it('can clear dashboard filters in compact select', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText('7D');
- await userEvent.click(await screen.findByText('sentry-android-shop@1.2.0'));
- await userEvent.click(screen.getByText('Clear'));
- screen.getByText('All Releases');
- await userEvent.click(document.body);
- expect(browserHistory.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- release: '',
- }),
- })
- );
- });
- it('can save absolute time range in existing dashboard', async () => {
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- start: '2022-07-14T07:00:00',
- end: '2022-07-19T23:59:59',
- utc: 'true',
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('Save'));
- expect(mockPut).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- start: '2022-07-14T07:00:00.000',
- end: '2022-07-19T23:59:59.000',
- utc: true,
- }),
- })
- );
- });
- it('can clear dashboard filters in existing dashboard', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- project: [1, 2],
- environment: ['alpha', 'beta'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText('7D');
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
- await userEvent.keyboard('{Escape}');
- await userEvent.click(screen.getByText('Cancel'));
- screen.getByText('All Releases');
- expect(browserHistory.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- project: undefined,
- statsPeriod: undefined,
- environment: undefined,
- }),
- })
- );
- });
- it('disables the Edit Dashboard button when there are unsaved filters', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-basic',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- statsPeriod: '7d',
- project: [1, 2],
- environment: ['alpha', 'beta'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- expect(await screen.findByText('Save')).toBeInTheDocument();
- expect(screen.getByText('Cancel')).toBeInTheDocument();
- expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
- });
- it('ignores the order of selection of page filters to render unsaved filters', async () => {
- const testProjects = [
- TestStubs.Project({id: '1', name: 'first', environments: ['alpha', 'beta']}),
- TestStubs.Project({id: '2', name: 'second', environments: ['alpha', 'beta']}),
- ];
- act(() => ProjectsStore.loadInitialData(testProjects));
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: testProjects,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {},
- environment: ['alpha', 'beta'],
- }),
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- environment: ['beta', 'alpha'], // Reversed order from saved dashboard
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await waitFor(() => expect(screen.queryAllByText('Loading\u2026')).toEqual([]));
- await screen.findByText(/beta, alpha/);
- // Save and Cancel should not appear because alpha, beta is the same as beta, alpha
- expect(screen.queryByText('Save')).not.toBeInTheDocument();
- expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
- });
- it('uses releases from the URL query params', async function () {
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- release: ['not-selected-1'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText(/not-selected-1/);
- screen.getByText('Save');
- screen.getByText('Cancel');
- });
- it('resets release in URL params', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: TestStubs.Dashboard(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {
- release: ['abc'],
- },
- }),
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...TestStubs.location(),
- query: {
- release: ['not-selected-1'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await screen.findByText(/not-selected-1/);
- await userEvent.click(screen.getByText('Cancel'));
- // release isn't used in the redirect
- expect(browserHistory.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- query: {
- end: undefined,
- environment: undefined,
- project: undefined,
- start: undefined,
- statsPeriod: undefined,
- utc: undefined,
- },
- })
- );
- });
- it('reflects selections in the release filter in the query params', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: TestStubs.location(),
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
- await userEvent.click(document.body);
- expect(browserHistory.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- release: ['sentry-android-shop@1.2.0'],
- }),
- })
- );
- });
- it('persists release selections made during search requests that do not appear in default query', async function () {
- // Default response
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- // Mocked search results
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- TestStubs.Release({
- id: '9',
- shortVersion: 'search-result',
- version: 'search-result',
- }),
- ],
- match: [MockApiClient.matchData({query: 's'})],
- });
- const testData = initializeOrg({
- organization: TestStubs.Organization({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-basic',
- 'discover-query',
- ],
- }),
- router: {
- location: TestStubs.location(),
- },
- });
- render(
- <ViewEditDashboard
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- />,
- {context: testData.routerContext, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.type(screen.getByPlaceholderText('Search\u2026'), 's');
- await userEvent.click(await screen.findByRole('option', {name: 'search-result'}));
- // Validate that after search is cleared, search result still appears
- expect(await screen.findByText('Latest Release(s)')).toBeInTheDocument();
- expect(screen.getByRole('option', {name: 'search-result'})).toBeInTheDocument();
- });
- });
- });
|