backend.yml 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356
  1. name: backend
  2. on:
  3. push:
  4. branches:
  5. - master
  6. pull_request:
  7. # Cancel in progress workflows on pull_requests.
  8. # https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
  9. concurrency:
  10. group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
  11. cancel-in-progress: true
  12. # hack for https://github.com/actions/cache/issues/810#issuecomment-1222550359
  13. env:
  14. SEGMENT_DOWNLOAD_TIMEOUT_MINS: 3
  15. jobs:
  16. files-changed:
  17. name: detect what files changed
  18. runs-on: ubuntu-22.04
  19. timeout-minutes: 3
  20. # Map a step output to a job output
  21. outputs:
  22. api_docs: ${{ steps.changes.outputs.api_docs }}
  23. backend: ${{ steps.changes.outputs.backend_all }}
  24. backend_dependencies: ${{ steps.changes.outputs.backend_dependencies }}
  25. backend_any_type: ${{ steps.changes.outputs.backend_any_type }}
  26. migration_lockfile: ${{ steps.changes.outputs.migration_lockfile }}
  27. steps:
  28. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  29. - name: Check for backend file changes
  30. uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
  31. id: changes
  32. with:
  33. token: ${{ github.token }}
  34. filters: .github/file-filters.yml
  35. api-docs:
  36. if: needs.files-changed.outputs.api_docs == 'true'
  37. needs: files-changed
  38. name: api docs test
  39. runs-on: ubuntu-22.04
  40. steps:
  41. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  42. - uses: getsentry/action-setup-volta@c52be2ea13cfdc084edb806e81958c13e445941e # v1.2.0
  43. - name: Setup sentry python env
  44. uses: ./.github/actions/setup-sentry
  45. id: setup
  46. with:
  47. snuba: true
  48. - name: Run API docs tests
  49. # install ts-node for ts build scripts to execute properly without potentially installing
  50. # conflicting deps when running scripts locally
  51. # see: https://github.com/getsentry/sentry/pull/32328/files
  52. run: |
  53. yarn add ts-node && make test-api-docs
  54. backend-test:
  55. if: needs.files-changed.outputs.backend == 'true'
  56. needs: files-changed
  57. name: backend test
  58. runs-on: ubuntu-22.04
  59. timeout-minutes: 60
  60. strategy:
  61. # This helps not having to run multiple jobs because one fails, thus, reducing resource usage
  62. # and reducing the risk that one of many runs would turn red again (read: intermittent tests)
  63. fail-fast: false
  64. matrix:
  65. # XXX: When updating this, make sure you also update MATRIX_INSTANCE_TOTAL.
  66. instance: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
  67. pg-version: ['14']
  68. env:
  69. # XXX: `MATRIX_INSTANCE_TOTAL` must be hardcoded to the length of `strategy.matrix.instance`.
  70. # If this increases, make sure to also increase `flags.backend.after_n_builds` in `codecov.yml`.
  71. MATRIX_INSTANCE_TOTAL: 11
  72. steps:
  73. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  74. with:
  75. # Avoid codecov error message related to SHA resolution:
  76. # https://github.com/codecov/codecov-bash/blob/7100762afbc822b91806a6574658129fe0d23a7d/codecov#L891
  77. fetch-depth: '2'
  78. - name: Setup sentry env
  79. uses: ./.github/actions/setup-sentry
  80. id: setup
  81. with:
  82. kafka: true
  83. snuba: true
  84. symbolicator: true
  85. # Right now, we run so few bigtable related tests that the
  86. # overhead of running bigtable in all backend tests
  87. # is way smaller than the time it would take to run in its own job.
  88. bigtable: true
  89. pg-version: ${{ matrix.pg-version }}
  90. - name: Run backend test (${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }})
  91. run: |
  92. make test-python-ci
  93. # Upload coverage data even if running the tests step fails since
  94. # it reduces large coverage fluctuations
  95. - name: Handle artifacts
  96. if: ${{ always() }}
  97. uses: ./.github/actions/artifacts
  98. with:
  99. token: ${{ secrets.CODECOV_TOKEN }}
  100. backend-migration-tests:
  101. if: needs.files-changed.outputs.backend == 'true'
  102. needs: files-changed
  103. name: backend migration tests
  104. runs-on: ubuntu-22.04
  105. timeout-minutes: 30
  106. strategy:
  107. matrix:
  108. pg-version: ['14']
  109. steps:
  110. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  111. with:
  112. # Avoid codecov error message related to SHA resolution:
  113. # https://github.com/codecov/codecov-bash/blob/7100762afbc822b91806a6574658129fe0d23a7d/codecov#L891
  114. fetch-depth: '2'
  115. - name: Setup sentry env
  116. uses: ./.github/actions/setup-sentry
  117. id: setup
  118. with:
  119. snuba: true
  120. pg-version: ${{ matrix.pg-version }}
  121. - name: run tests
  122. run: |
  123. # historic migrations trigger some warnings
  124. PYTEST_ADDOPTS="$PYTEST_ADDOPTS -m migrations --migrations" make test-python-ci
  125. # Upload coverage data even if running the tests step fails since
  126. # it reduces large coverage fluctuations
  127. - name: Handle artifacts
  128. if: ${{ always() }}
  129. uses: ./.github/actions/artifacts
  130. with:
  131. token: ${{ secrets.CODECOV_TOKEN }}
  132. cli:
  133. if: needs.files-changed.outputs.backend == 'true'
  134. needs: files-changed
  135. name: cli test
  136. runs-on: ubuntu-22.04
  137. timeout-minutes: 10
  138. strategy:
  139. matrix:
  140. pg-version: ['14']
  141. steps:
  142. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  143. - name: Setup sentry env
  144. uses: ./.github/actions/setup-sentry
  145. id: setup
  146. with:
  147. pg-version: ${{ matrix.pg-version }}
  148. - name: Run test
  149. run: |
  150. make test-cli
  151. # Upload coverage data even if running the tests step fails since
  152. # it reduces large coverage fluctuations
  153. - name: Handle artifacts
  154. if: ${{ always() }}
  155. uses: ./.github/actions/artifacts
  156. with:
  157. token: ${{ secrets.CODECOV_TOKEN }}
  158. requirements:
  159. if: needs.files-changed.outputs.backend_dependencies == 'true'
  160. needs: files-changed
  161. name: requirements check
  162. runs-on: ubuntu-22.04
  163. timeout-minutes: 3
  164. steps:
  165. - uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
  166. id: token
  167. continue-on-error: true
  168. with:
  169. app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
  170. private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
  171. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  172. - uses: getsentry/action-setup-venv@9e3bbae3836b1b6f129955bf55a19e1d99a61c67 # v1.0.5
  173. with:
  174. python-version: 3.11.6
  175. cache-dependency-path: requirements-dev-frozen.txt
  176. install-cmd: python3 -m tools.hack_pip && pip install -q --constraint requirements-dev-frozen.txt pip-tools
  177. - name: check requirements
  178. run: |
  179. python -S -m tools.freeze_requirements
  180. if ! git diff --exit-code; then
  181. echo $'\n\nrun `make freeze-requirements` locally to update requirements'
  182. exit 1
  183. fi
  184. - name: apply any requirements changes
  185. if: steps.token.outcome == 'success' && github.ref != 'refs/heads/master' && always()
  186. uses: getsentry/action-github-commit@748c31dd78cffe76f51bef49a0be856b6effeda7 # v1.1.0
  187. with:
  188. github-token: ${{ steps.token.outputs.token }}
  189. message: ':snowflake: re-freeze requirements'
  190. migration:
  191. if: needs.files-changed.outputs.migration_lockfile == 'true'
  192. needs: files-changed
  193. name: check migration
  194. runs-on: ubuntu-22.04
  195. strategy:
  196. matrix:
  197. pg-version: ['14']
  198. steps:
  199. - name: Checkout sentry
  200. uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  201. - name: Setup sentry env
  202. uses: ./.github/actions/setup-sentry
  203. id: setup
  204. with:
  205. pg-version: ${{ matrix.pg-version }}
  206. - name: Migration & lockfile checks
  207. env:
  208. SENTRY_LOG_LEVEL: ERROR
  209. PGPASSWORD: postgres
  210. run: |
  211. ./.github/workflows/scripts/migration-check.sh
  212. monolith-dbs:
  213. if: needs.files-changed.outputs.backend == 'true'
  214. needs: files-changed
  215. name: monolith-dbs test
  216. runs-on: ubuntu-22.04
  217. timeout-minutes: 20
  218. steps:
  219. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  220. with:
  221. # Avoid codecov error message related to SHA resolution:
  222. # https://github.com/codecov/codecov-bash/blob/7100762afbc822b91806a6574658129fe0d23a7d/codecov#L891
  223. fetch-depth: '2'
  224. - name: Setup sentry env
  225. uses: ./.github/actions/setup-sentry
  226. id: setup
  227. - name: Run test
  228. run: |
  229. make test-monolith-dbs
  230. # Upload coverage data even if running the tests step fails since
  231. # it reduces large coverage fluctuations
  232. - name: Handle artifacts
  233. if: ${{ always() }}
  234. uses: ./.github/actions/artifacts
  235. with:
  236. token: ${{ secrets.CODECOV_TOKEN }}
  237. typing:
  238. if: needs.files-changed.outputs.backend == 'true'
  239. needs: files-changed
  240. name: backend typing
  241. runs-on: ubuntu-22.04
  242. timeout-minutes: 20
  243. steps:
  244. - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  245. - uses: getsentry/action-setup-venv@9e3bbae3836b1b6f129955bf55a19e1d99a61c67 # v1.0.5
  246. with:
  247. python-version: 3.11.6
  248. cache-dependency-path: requirements-dev-frozen.txt
  249. install-cmd: python3 -m tools.hack_pip && pip install -r requirements-dev-frozen.txt
  250. - name: setup sentry (lite)
  251. run: |
  252. python3 -m tools.fast_editable --path .
  253. sentry init
  254. - run: mypy
  255. id: run
  256. - uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
  257. id: token
  258. continue-on-error: true
  259. with:
  260. app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
  261. private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
  262. # only if `mypy` succeeds should we try and trim the blocklist
  263. - run: python3 -m tools.mypy_helpers.make_module_ignores
  264. id: regen-blocklist
  265. - run: git diff --exit-code
  266. - run: |
  267. # mypy does not have granular codes so don't allow specific messages to regress
  268. ! grep "'Settings' object has no attribute" .artifacts/mypy-all
  269. ! grep 'Cannot override class variable' .artifacts/mypy-all
  270. ! grep 'Exception type must be derived from BaseException' .artifacts/mypy-all
  271. ! grep 'Incompatible return value type (got "HttpResponseBase"' .artifacts/mypy-all
  272. ! grep 'Incompatible types in "yield"' .artifacts/mypy-all
  273. ! grep 'Module "sentry.*has no attribute' .artifacts/mypy-all
  274. ! grep 'base class .* defined the type as.*Permission' .artifacts/mypy-all
  275. ! grep 'does not explicitly export attribute' .artifacts/mypy-all
  276. - name: apply blocklist changes
  277. if: |
  278. steps.token.outcome == 'success' &&
  279. steps.run.outcome == 'success' &&
  280. steps.regen-blocklist.outcome == 'success' &&
  281. github.ref != 'refs/heads/master' &&
  282. always()
  283. uses: getsentry/action-github-commit@748c31dd78cffe76f51bef49a0be856b6effeda7 # v1.1.0
  284. with:
  285. github-token: ${{ steps.token.outputs.token }}
  286. message: ':knife: regenerate mypy module blocklist'
  287. # This check runs once all dependent jobs have passed
  288. # It symbolizes that all required Backend checks have succesfully passed (Or skipped)
  289. # This step is the only required backend check
  290. backend-required-check:
  291. needs:
  292. [
  293. api-docs,
  294. backend-test,
  295. backend-migration-tests,
  296. cli,
  297. files-changed,
  298. requirements,
  299. migration,
  300. monolith-dbs,
  301. typing,
  302. ]
  303. name: Backend
  304. # This is necessary since a failed/skipped dependent job would cause this job to be skipped
  305. if: always()
  306. runs-on: ubuntu-22.04
  307. steps:
  308. # If any jobs we depend on fail, we will fail since this is a required check
  309. # NOTE: A timeout is considered a failure
  310. - name: Check for failures
  311. if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
  312. run: |
  313. echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1