test_organization_events_v2.py 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624
  1. import copy
  2. from datetime import timedelta
  3. from urllib.parse import urlencode
  4. import pytest
  5. import pytz
  6. from selenium.webdriver.common.keys import Keys
  7. from sentry.discover.models import DiscoverSavedQuery
  8. from sentry.testutils import AcceptanceTestCase, SnubaTestCase
  9. from sentry.testutils.helpers.datetime import before_now, iso_format, timestamp_format
  10. from sentry.utils.compat.mock import patch
  11. from sentry.utils.samples import load_data
  12. FEATURE_NAMES = [
  13. "organizations:discover-basic",
  14. "organizations:discover-query",
  15. "organizations:performance-view",
  16. ]
  17. def all_events_query(**kwargs):
  18. options = {
  19. "sort": ["-timestamp"],
  20. "field": ["title", "event.type", "project", "user.display", "timestamp"],
  21. "name": ["All Events"],
  22. }
  23. options.update(kwargs)
  24. return urlencode(options, doseq=True)
  25. def errors_query(**kwargs):
  26. options = {
  27. "sort": ["-title"],
  28. "name": ["Errors"],
  29. "field": ["title", "count(id)", "count_unique(user)", "project"],
  30. "query": ["event.type:error"],
  31. }
  32. options.update(kwargs)
  33. return urlencode(options, doseq=True)
  34. def transactions_query(**kwargs):
  35. options = {
  36. "sort": ["-count"],
  37. "name": ["Transactions"],
  38. "field": ["transaction", "project", "count()"],
  39. "statsPeriod": ["14d"],
  40. "query": ["event.type:transaction"],
  41. }
  42. options.update(kwargs)
  43. return urlencode(options, doseq=True)
  44. def generate_transaction(trace=None, span=None):
  45. start_datetime = before_now(minutes=1, milliseconds=500)
  46. end_datetime = before_now(minutes=1)
  47. event_data = load_data(
  48. "transaction",
  49. timestamp=end_datetime,
  50. start_timestamp=start_datetime,
  51. trace=trace,
  52. span_id=span,
  53. )
  54. event_data.update({"event_id": "a" * 32})
  55. # generate and build up span tree
  56. reference_span = event_data["spans"][0]
  57. parent_span_id = reference_span["parent_span_id"]
  58. span_tree_blueprint = {
  59. "a": {},
  60. "b": {"bb": {"bbb": {"bbbb": "bbbbb"}}},
  61. "c": {},
  62. "d": {},
  63. "e": {},
  64. }
  65. time_offsets = {
  66. "a": (timedelta(), timedelta(milliseconds=10)),
  67. "b": (timedelta(milliseconds=120), timedelta(milliseconds=250)),
  68. "bb": (timedelta(milliseconds=130), timedelta(milliseconds=10)),
  69. "bbb": (timedelta(milliseconds=140), timedelta(milliseconds=10)),
  70. "bbbb": (timedelta(milliseconds=150), timedelta(milliseconds=10)),
  71. "bbbbb": (timedelta(milliseconds=160), timedelta(milliseconds=90)),
  72. "c": (timedelta(milliseconds=260), timedelta(milliseconds=100)),
  73. "d": (timedelta(milliseconds=375), timedelta(milliseconds=50)),
  74. "e": (timedelta(milliseconds=400), timedelta(milliseconds=100)),
  75. }
  76. def build_span_tree(span_tree, spans, parent_span_id):
  77. for span_id, child in sorted(span_tree.items(), key=lambda item: item[0]):
  78. span = copy.deepcopy(reference_span)
  79. # non-leaf node span
  80. span["parent_span_id"] = parent_span_id.ljust(16, "0")
  81. span["span_id"] = span_id.ljust(16, "0")
  82. (start_delta, span_length) = time_offsets.get(span_id, (timedelta(), timedelta()))
  83. span_start_time = start_datetime + start_delta
  84. span["start_timestamp"] = timestamp_format(span_start_time)
  85. span["timestamp"] = timestamp_format(span_start_time + span_length)
  86. spans.append(span)
  87. if isinstance(child, dict):
  88. spans = build_span_tree(child, spans, span_id)
  89. elif isinstance(child, str):
  90. parent_span_id = span_id
  91. span_id = child
  92. span = copy.deepcopy(reference_span)
  93. # leaf node span
  94. span["parent_span_id"] = parent_span_id.ljust(16, "0")
  95. span["span_id"] = span_id.ljust(16, "0")
  96. (start_delta, span_length) = time_offsets.get(span_id, (timedelta(), timedelta()))
  97. span_start_time = start_datetime + start_delta
  98. span["start_timestamp"] = timestamp_format(span_start_time)
  99. span["timestamp"] = timestamp_format(span_start_time + span_length)
  100. spans.append(span)
  101. return spans
  102. event_data["spans"] = build_span_tree(span_tree_blueprint, [], parent_span_id)
  103. return event_data
  104. class OrganizationEventsV2Test(AcceptanceTestCase, SnubaTestCase):
  105. def setUp(self):
  106. super().setUp()
  107. self.user = self.create_user("foo@example.com", is_superuser=True)
  108. self.org = self.create_organization(name="Rowdy Tiger")
  109. self.team = self.create_team(organization=self.org, name="Mariachi Band")
  110. self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
  111. self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
  112. self.login_as(self.user)
  113. self.landing_path = f"/organizations/{self.org.slug}/discover/queries/"
  114. self.result_path = f"/organizations/{self.org.slug}/discover/results/"
  115. def wait_until_loaded(self):
  116. self.browser.wait_until_not(".loading-indicator")
  117. self.browser.wait_until_not('[data-test-id="loading-placeholder"]')
  118. def test_events_default_landing(self):
  119. with self.feature(FEATURE_NAMES):
  120. self.browser.get(self.landing_path)
  121. self.wait_until_loaded()
  122. self.browser.snapshot("events-v2 - default landing")
  123. def test_all_events_query_empty_state(self):
  124. with self.feature(FEATURE_NAMES):
  125. self.browser.get(self.result_path + "?" + all_events_query())
  126. self.wait_until_loaded()
  127. self.browser.snapshot("events-v2 - all events query - empty state")
  128. with self.feature(FEATURE_NAMES):
  129. # expect table to expand to the right when no tags are provided
  130. self.browser.get(self.result_path + "?" + all_events_query(tag=[]))
  131. self.wait_until_loaded()
  132. self.browser.snapshot("events-v2 - all events query - empty state - no tags")
  133. @patch("django.utils.timezone.now")
  134. def test_all_events_query(self, mock_now):
  135. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  136. min_ago = iso_format(before_now(minutes=1))
  137. two_min_ago = iso_format(before_now(minutes=2))
  138. self.store_event(
  139. data={
  140. "event_id": "a" * 32,
  141. "message": "oh no",
  142. "timestamp": min_ago,
  143. "fingerprint": ["group-1"],
  144. },
  145. project_id=self.project.id,
  146. assert_no_errors=False,
  147. )
  148. self.store_event(
  149. data={
  150. "event_id": "b" * 32,
  151. "message": "this is bad.",
  152. "timestamp": two_min_ago,
  153. "fingerprint": ["group-2"],
  154. "user": {
  155. "id": "123",
  156. "email": "someone@example.com",
  157. "username": "haveibeenpwned",
  158. "ip_address": "8.8.8.8",
  159. "name": "Someone",
  160. },
  161. },
  162. project_id=self.project.id,
  163. assert_no_errors=False,
  164. )
  165. self.wait_for_event_count(self.project.id, 2)
  166. with self.feature(FEATURE_NAMES):
  167. self.browser.get(self.result_path + "?" + all_events_query())
  168. self.wait_until_loaded()
  169. # This test is flakey in that we sometimes load this page before the event is processed
  170. # depend on pytest-retry to reload the page
  171. self.browser.wait_until_not(
  172. '[data-test-id="grid-editable"] [data-test-id="empty-state"]', timeout=2
  173. )
  174. self.browser.snapshot("events-v2 - all events query - list")
  175. with self.feature(FEATURE_NAMES):
  176. # expect table to expand to the right when no tags are provided
  177. self.browser.get(self.result_path + "?" + all_events_query(tag=[]))
  178. self.wait_until_loaded()
  179. self.browser.snapshot("events-v2 - all events query - list - no tags")
  180. def test_errors_query_empty_state(self):
  181. with self.feature(FEATURE_NAMES):
  182. self.browser.get(self.result_path + "?" + errors_query())
  183. self.wait_until_loaded()
  184. self.browser.snapshot("events-v2 - errors query - empty state")
  185. self.browser.click_when_visible('[data-test-id="grid-edit-enable"]')
  186. self.browser.snapshot(
  187. "events-v2 - errors query - empty state - querybuilder - column edit state"
  188. )
  189. @patch("django.utils.timezone.now")
  190. def test_errors_query(self, mock_now):
  191. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  192. min_ago = iso_format(before_now(minutes=1))
  193. self.store_event(
  194. data={
  195. "event_id": "a" * 32,
  196. "message": "oh no",
  197. "timestamp": min_ago,
  198. "fingerprint": ["group-1"],
  199. "type": "error",
  200. },
  201. project_id=self.project.id,
  202. assert_no_errors=False,
  203. )
  204. self.store_event(
  205. data={
  206. "event_id": "b" * 32,
  207. "message": "oh no",
  208. "timestamp": min_ago,
  209. "fingerprint": ["group-1"],
  210. "type": "error",
  211. },
  212. project_id=self.project.id,
  213. assert_no_errors=False,
  214. )
  215. self.store_event(
  216. data={
  217. "event_id": "c" * 32,
  218. "message": "this is bad.",
  219. "timestamp": min_ago,
  220. "fingerprint": ["group-2"],
  221. "type": "error",
  222. },
  223. project_id=self.project.id,
  224. assert_no_errors=False,
  225. )
  226. with self.feature(FEATURE_NAMES):
  227. self.browser.get(self.result_path + "?" + errors_query())
  228. self.wait_until_loaded()
  229. self.browser.snapshot("events-v2 - errors")
  230. def test_transactions_query_empty_state(self):
  231. with self.feature(FEATURE_NAMES):
  232. self.browser.get(self.result_path + "?" + transactions_query())
  233. self.wait_until_loaded()
  234. self.browser.snapshot("events-v2 - transactions query - empty state")
  235. with self.feature(FEATURE_NAMES):
  236. # expect table to expand to the right when no tags are provided
  237. self.browser.get(self.result_path + "?" + transactions_query(tag=[]))
  238. self.wait_until_loaded()
  239. self.browser.snapshot("events-v2 - transactions query - empty state - no tags")
  240. @patch("django.utils.timezone.now")
  241. def test_transactions_query(self, mock_now):
  242. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  243. event_data = generate_transaction()
  244. self.store_event(data=event_data, project_id=self.project.id, assert_no_errors=True)
  245. with self.feature(FEATURE_NAMES):
  246. self.browser.get(self.result_path + "?" + transactions_query())
  247. self.wait_until_loaded()
  248. self.browser.wait_until_not(
  249. '[data-test-id="grid-editable"] [data-test-id="empty-state"]', timeout=2
  250. )
  251. self.browser.snapshot("events-v2 - transactions query - list")
  252. @patch("django.utils.timezone.now")
  253. def test_event_detail_view_from_all_events(self, mock_now):
  254. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  255. min_ago = iso_format(before_now(minutes=1))
  256. event_data = load_data("python")
  257. event_data.update(
  258. {
  259. "event_id": "a" * 32,
  260. "timestamp": min_ago,
  261. "received": min_ago,
  262. "fingerprint": ["group-1"],
  263. }
  264. )
  265. self.store_event(data=event_data, project_id=self.project.id, assert_no_errors=False)
  266. with self.feature(FEATURE_NAMES):
  267. # Get the list page.
  268. self.browser.get(self.result_path + "?" + all_events_query())
  269. self.wait_until_loaded()
  270. # View Event
  271. self.browser.elements('[data-test-id="view-event"]')[0].click()
  272. self.wait_until_loaded()
  273. # header = self.browser.element('[data-test-id="event-header"] div div span')
  274. # assert event_data["message"] in header.text
  275. self.browser.snapshot("events-v2 - single error details view")
  276. @patch("django.utils.timezone.now")
  277. def test_event_detail_view_from_errors_view(self, mock_now):
  278. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  279. event_data = load_data("javascript")
  280. event_data.update(
  281. {
  282. "timestamp": iso_format(before_now(minutes=5)),
  283. "event_id": "d" * 32,
  284. "fingerprint": ["group-1"],
  285. }
  286. )
  287. self.store_event(data=event_data, project_id=self.project.id)
  288. self.wait_for_event_count(self.project.id, 1)
  289. with self.feature(FEATURE_NAMES):
  290. # Get the list page
  291. self.browser.get(self.result_path + "?" + errors_query() + "&statsPeriod=24h")
  292. self.wait_until_loaded()
  293. # Open the stack
  294. self.browser.element('[data-test-id="open-group"]').click()
  295. self.wait_until_loaded()
  296. # View Event
  297. self.browser.elements('[data-test-id="view-event"]')[0].click()
  298. self.wait_until_loaded()
  299. self.browser.snapshot("events-v2 - error event detail view")
  300. @patch("django.utils.timezone.now")
  301. def test_event_detail_view_from_transactions_query(self, mock_now):
  302. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  303. event_data = generate_transaction(trace="a" * 32, span="ab" * 8)
  304. self.store_event(data=event_data, project_id=self.project.id, assert_no_errors=True)
  305. # Create a child event that is linked to the parent so we have coverage
  306. # of traversal buttons.
  307. child_event = generate_transaction(
  308. trace=event_data["contexts"]["trace"]["trace_id"], span="bc" * 8
  309. )
  310. child_event["event_id"] = "b" * 32
  311. child_event["contexts"]["trace"]["parent_span_id"] = event_data["spans"][4]["span_id"]
  312. child_event["transaction"] = "z-child-transaction"
  313. child_event["spans"] = child_event["spans"][0:3]
  314. self.store_event(data=child_event, project_id=self.project.id, assert_no_errors=True)
  315. with self.feature(FEATURE_NAMES):
  316. # Get the list page
  317. self.browser.get(self.result_path + "?" + transactions_query())
  318. self.wait_until_loaded()
  319. # Open the stack
  320. self.browser.elements('[data-test-id="open-group"]')[0].click()
  321. self.wait_until_loaded()
  322. # View Event
  323. self.browser.elements('[data-test-id="view-event"]')[0].click()
  324. self.wait_until_loaded()
  325. # Open a span detail so we can check the search by trace link.
  326. # Click on the 6th one as a missing instrumentation span is inserted.
  327. self.browser.elements('[data-test-id="span-row"]')[6].click()
  328. # Wait until the child event loads.
  329. child_button = '[data-test-id="view-child-transaction"]'
  330. self.browser.wait_until(child_button)
  331. self.browser.snapshot("events-v2 - transactions event detail view")
  332. # Click on the child transaction.
  333. self.browser.click(child_button)
  334. self.wait_until_loaded()
  335. @patch("django.utils.timezone.now")
  336. def test_transaction_event_detail_view_ops_filtering(self, mock_now):
  337. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  338. event_data = generate_transaction(trace="a" * 32, span="ab" * 8)
  339. self.store_event(data=event_data, project_id=self.project.id, assert_no_errors=True)
  340. with self.feature(FEATURE_NAMES):
  341. # Get the list page
  342. self.browser.get(self.result_path + "?" + transactions_query())
  343. self.wait_until_loaded()
  344. # Open the stack
  345. self.browser.elements('[data-test-id="open-group"]')[0].click()
  346. self.wait_until_loaded()
  347. # View Event
  348. self.browser.elements('[data-test-id="view-event"]')[0].click()
  349. self.wait_until_loaded()
  350. # Interact with ops filter dropdown
  351. self.browser.elements('[data-test-id="filter-button"]')[0].click()
  352. # select all ops
  353. self.browser.elements(
  354. '[data-test-id="op-filter-dropdown"] [data-test-id="checkbox-fancy"]'
  355. )[0].click()
  356. # un-select django.middleware
  357. self.browser.elements(
  358. '[data-test-id="op-filter-dropdown"] [data-test-id="checkbox-fancy"]'
  359. )[1].click()
  360. self.browser.snapshot("events-v2 - transactions event detail view - ops filtering")
  361. def test_create_saved_query(self):
  362. # Simulate a custom query
  363. query = {"field": ["project.id", "count()"], "query": "event.type:error"}
  364. query_name = "A new custom query"
  365. with self.feature(FEATURE_NAMES):
  366. # Go directly to the query builder view
  367. self.browser.get(self.result_path + "?" + urlencode(query, doseq=True))
  368. self.wait_until_loaded()
  369. # Open the save as drawer
  370. self.browser.element('[aria-label="Save as"]').click()
  371. # Fill out name and submit form.
  372. self.browser.element('input[name="query_name"]').send_keys(query_name)
  373. self.browser.element('[aria-label="Save"]').click()
  374. self.browser.wait_until(f'[data-test-id="discover2-query-name-{query_name}"]')
  375. # Page title should update.
  376. editable_text_label = self.browser.element('[data-test-id="editable-text-label"]').text
  377. assert editable_text_label == query_name
  378. # Saved query should exist.
  379. assert DiscoverSavedQuery.objects.filter(name=query_name).exists()
  380. def test_view_and_rename_saved_query(self):
  381. # Create saved query to rename
  382. query = DiscoverSavedQuery.objects.create(
  383. name="Custom query",
  384. organization=self.org,
  385. version=2,
  386. query={"fields": ["title", "project.id", "count()"], "query": "event.type:error"},
  387. )
  388. with self.feature(FEATURE_NAMES):
  389. # View the query list
  390. self.browser.get(self.landing_path)
  391. self.wait_until_loaded()
  392. # Look at the results for our query.
  393. self.browser.element(f'[data-test-id="card-{query.name}"]').click()
  394. self.wait_until_loaded()
  395. self.browser.element('[data-test-id="editable-text-label"]').click()
  396. self.browser.wait_until('[data-test-id="editable-text-input"]')
  397. editable_text_input = self.browser.element('[data-test-id="editable-text-input"] input')
  398. editable_text_input.click()
  399. editable_text_input.send_keys(Keys.END + "updated!")
  400. # Move focus somewhere else to trigger a blur and update the query
  401. self.browser.element("table").click()
  402. self.browser.wait_until('[data-test-id="editable-text-label"]')
  403. new_name = "Custom queryupdated!"
  404. # new_card_selector = f'div[name="discover2-query-name"][value="{new_name}"]'
  405. # self.browser.wait_until(new_card_selector)
  406. self.browser.wait_until(f'[data-test-id="discover2-query-name-{new_name}"]')
  407. # Assert the name was updated.
  408. assert DiscoverSavedQuery.objects.filter(name=new_name).exists()
  409. def test_delete_saved_query(self):
  410. # Create saved query with ORM
  411. query = DiscoverSavedQuery.objects.create(
  412. name="Custom query",
  413. organization=self.org,
  414. version=2,
  415. query={"fields": ["title", "project.id", "count()"], "query": "event.type:error"},
  416. )
  417. with self.feature(FEATURE_NAMES):
  418. # View the query list
  419. self.browser.get(self.landing_path)
  420. self.wait_until_loaded()
  421. # Get the card with the new query
  422. card_selector = f'[data-test-id="card-{query.name}"]'
  423. card = self.browser.element(card_selector)
  424. # Open the context menu
  425. card.find_element_by_css_selector('[data-test-id="context-menu"]').click()
  426. # Delete the query
  427. card.find_element_by_css_selector('[data-test-id="delete-query"]').click()
  428. # Wait for card to clear
  429. self.browser.wait_until_not(card_selector)
  430. assert DiscoverSavedQuery.objects.filter(name=query.name).exists() is False
  431. def test_duplicate_query(self):
  432. # Create saved query with ORM
  433. query = DiscoverSavedQuery.objects.create(
  434. name="Custom query",
  435. organization=self.org,
  436. version=2,
  437. query={"fields": ["title", "project.id", "count()"], "query": "event.type:error"},
  438. )
  439. with self.feature(FEATURE_NAMES):
  440. # View the query list
  441. self.browser.get(self.landing_path)
  442. self.wait_until_loaded()
  443. # Get the card with the new query
  444. card_selector = f'[data-test-id="card-{query.name}"]'
  445. card = self.browser.element(card_selector)
  446. # Open the context menu, and duplicate
  447. card.find_element_by_css_selector('[data-test-id="context-menu"]').click()
  448. card.find_element_by_css_selector('[data-test-id="duplicate-query"]').click()
  449. duplicate_name = f"{query.name} copy"
  450. # Wait for new element to show up.
  451. self.browser.element(f'[data-test-id="card-{duplicate_name}"]')
  452. # Assert the new query exists and has 'copy' added to the name.
  453. assert DiscoverSavedQuery.objects.filter(name=duplicate_name).exists()
  454. @pytest.mark.skip(reason="causing timeouts in github actions and travis")
  455. @patch("django.utils.timezone.now")
  456. def test_drilldown_result(self, mock_now):
  457. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  458. min_ago = iso_format(before_now(minutes=1))
  459. events = (
  460. ("a" * 32, "oh no", "group-1"),
  461. ("b" * 32, "oh no", "group-1"),
  462. ("c" * 32, "this is bad", "group-2"),
  463. )
  464. for event in events:
  465. self.store_event(
  466. data={
  467. "event_id": event[0],
  468. "message": event[1],
  469. "timestamp": min_ago,
  470. "fingerprint": [event[2]],
  471. "type": "error",
  472. },
  473. project_id=self.project.id,
  474. )
  475. query = {"field": ["message", "project", "count()"], "query": "event.type:error"}
  476. with self.feature(FEATURE_NAMES):
  477. # Go directly to the query builder view
  478. self.browser.get(self.result_path + "?" + urlencode(query, doseq=True))
  479. self.wait_until_loaded()
  480. # Click the first drilldown
  481. self.browser.element('[data-test-id="expand-count"]').click()
  482. self.wait_until_loaded()
  483. assert self.browser.element_exists_by_test_id("grid-editable"), "table should exist."
  484. headers = self.browser.elements('[data-test-id="grid-editable"] thead th')
  485. expected = ["", "MESSAGE", "PROJECT", "ID"]
  486. actual = [header.text for header in headers]
  487. assert expected == actual
  488. @pytest.mark.skip(reason="not done")
  489. @patch("django.utils.timezone.now")
  490. def test_usage(self, mock_now):
  491. mock_now.return_value = before_now().replace(tzinfo=pytz.utc)
  492. # TODO: load events
  493. # go to landing
  494. # go to a precanned query
  495. # save query 1
  496. # add environment column
  497. # update query
  498. # add condition from facet map
  499. # delete a column
  500. # click and drag a column
  501. # save as query 2
  502. # load save query 1
  503. # sort column
  504. # update query
  505. # delete save query 1