overview.actions.spec.tsx 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431
  1. import {Fragment} from 'react';
  2. import {GroupFixture} from 'sentry-fixture/group';
  3. import {GroupStatsFixture} from 'sentry-fixture/groupStats';
  4. import {OrganizationFixture} from 'sentry-fixture/organization';
  5. import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
  6. import {
  7. render,
  8. screen,
  9. userEvent,
  10. waitFor,
  11. within,
  12. } from 'sentry-test/reactTestingLibrary';
  13. import Indicators from 'sentry/components/indicators';
  14. import GroupStore from 'sentry/stores/groupStore';
  15. import IssueListCacheStore from 'sentry/stores/IssueListCacheStore';
  16. import SelectedGroupStore from 'sentry/stores/selectedGroupStore';
  17. import TagStore from 'sentry/stores/tagStore';
  18. import {PriorityLevel} from 'sentry/types/group';
  19. import IssueListOverview from 'sentry/views/issueList/overview';
  20. const DEFAULT_LINKS_HEADER =
  21. '<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575731:0:1>; rel="previous"; results="false"; cursor="1443575731:0:1", ' +
  22. '<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575000:0:0>; rel="next"; results="true"; cursor="1443575000:0:0"';
  23. describe('IssueListOverview (actions)', function () {
  24. const groupStats = GroupStatsFixture();
  25. const organization = OrganizationFixture();
  26. beforeEach(function () {
  27. MockApiClient.clearMockResponses();
  28. GroupStore.reset();
  29. SelectedGroupStore.reset();
  30. IssueListCacheStore.reset();
  31. MockApiClient.addMockResponse({
  32. url: '/organizations/org-slug/issues-stats/',
  33. body: [groupStats],
  34. });
  35. MockApiClient.addMockResponse({
  36. url: '/organizations/org-slug/searches/',
  37. body: [],
  38. });
  39. MockApiClient.addMockResponse({
  40. url: '/organizations/org-slug/recent-searches/',
  41. body: [],
  42. });
  43. MockApiClient.addMockResponse({
  44. url: '/organizations/org-slug/recent-searches/',
  45. method: 'POST',
  46. body: [],
  47. });
  48. MockApiClient.addMockResponse({
  49. url: '/organizations/org-slug/issues-count/',
  50. method: 'GET',
  51. body: [{}],
  52. });
  53. MockApiClient.addMockResponse({
  54. url: '/organizations/org-slug/processingissues/',
  55. method: 'GET',
  56. body: [],
  57. });
  58. MockApiClient.addMockResponse({
  59. url: '/organizations/org-slug/tags/',
  60. method: 'GET',
  61. body: [],
  62. });
  63. MockApiClient.addMockResponse({
  64. url: '/organizations/org-slug/users/',
  65. method: 'GET',
  66. body: [],
  67. });
  68. MockApiClient.addMockResponse({
  69. url: '/organizations/org-slug/sent-first-event/',
  70. body: {sentFirstEvent: true},
  71. });
  72. MockApiClient.addMockResponse({
  73. url: '/organizations/org-slug/projects/',
  74. body: [],
  75. });
  76. TagStore.init?.();
  77. });
  78. const defaultProps = RouteComponentPropsFixture();
  79. describe('status', function () {
  80. const group1 = GroupFixture({
  81. id: '1',
  82. culprit: 'Group 1',
  83. shortId: 'JAVASCRIPT-1',
  84. });
  85. const group2 = GroupFixture({
  86. id: '2',
  87. culprit: 'Group 2',
  88. shortId: 'JAVASCRIPT-2',
  89. });
  90. beforeEach(() => {
  91. MockApiClient.addMockResponse({
  92. url: '/organizations/org-slug/issues/',
  93. body: [group1, group2],
  94. headers: {Link: DEFAULT_LINKS_HEADER},
  95. });
  96. });
  97. it('removes issues after resolving', async function () {
  98. const updateIssueMock = MockApiClient.addMockResponse({
  99. url: '/organizations/org-slug/issues/',
  100. method: 'PUT',
  101. });
  102. render(<IssueListOverview {...defaultProps} />, {organization});
  103. const groups = await screen.findAllByTestId('group');
  104. await userEvent.click(
  105. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  106. );
  107. expect(screen.getByText('Group 1')).toBeInTheDocument();
  108. expect(screen.getByText('Group 2')).toBeInTheDocument();
  109. // After action, will refetch so need to mock that response
  110. MockApiClient.addMockResponse({
  111. url: '/organizations/org-slug/issues/',
  112. body: [group2],
  113. headers: {Link: DEFAULT_LINKS_HEADER},
  114. });
  115. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  116. expect(updateIssueMock).toHaveBeenCalledWith(
  117. '/organizations/org-slug/issues/',
  118. expect.objectContaining({
  119. query: expect.objectContaining({id: ['1']}),
  120. data: {status: 'resolved', statusDetails: {}, substatus: null},
  121. })
  122. );
  123. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  124. expect(screen.getByText('Group 2')).toBeInTheDocument();
  125. });
  126. it('can undo resolve action', async function () {
  127. const updateIssueMock = MockApiClient.addMockResponse({
  128. url: '/organizations/org-slug/issues/',
  129. method: 'PUT',
  130. });
  131. render(
  132. <Fragment>
  133. <IssueListOverview {...defaultProps} />
  134. <Indicators />
  135. </Fragment>,
  136. {organization}
  137. );
  138. const groups = await screen.findAllByTestId('group');
  139. await userEvent.click(
  140. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  141. );
  142. expect(screen.getByText('Group 1')).toBeInTheDocument();
  143. expect(screen.getByText('Group 2')).toBeInTheDocument();
  144. // After action, will refetch so need to mock that response
  145. MockApiClient.addMockResponse({
  146. url: '/organizations/org-slug/issues/',
  147. body: [group2],
  148. headers: {Link: DEFAULT_LINKS_HEADER},
  149. });
  150. await userEvent.click(await screen.findByRole('button', {name: 'Resolve'}));
  151. expect(updateIssueMock).toHaveBeenCalledWith(
  152. '/organizations/org-slug/issues/',
  153. expect.objectContaining({
  154. query: expect.objectContaining({id: ['1']}),
  155. data: {status: 'resolved', statusDetails: {}, substatus: null},
  156. })
  157. );
  158. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  159. expect(screen.getByText('Group 2')).toBeInTheDocument();
  160. // Should show a toast message
  161. expect(screen.getByText('Resolved JAVASCRIPT-1')).toBeInTheDocument();
  162. // Clicking the undo button makes a call to set the status back to unresolved
  163. MockApiClient.addMockResponse({
  164. url: '/organizations/org-slug/issues/',
  165. body: [group1, group2],
  166. headers: {Link: DEFAULT_LINKS_HEADER},
  167. });
  168. await userEvent.click(screen.getByRole('button', {name: 'Undo'}));
  169. expect(updateIssueMock).toHaveBeenLastCalledWith(
  170. '/organizations/org-slug/issues/',
  171. expect.objectContaining({
  172. query: expect.objectContaining({id: ['1']}),
  173. data: {status: 'unresolved', statusDetails: {}},
  174. })
  175. );
  176. expect(await screen.findByText('Group 1')).toBeInTheDocument();
  177. });
  178. });
  179. describe('mark reviewed', function () {
  180. const group1 = GroupFixture({
  181. id: '1',
  182. culprit: 'Group 1',
  183. shortId: 'JAVASCRIPT-1',
  184. inbox: {},
  185. });
  186. const group2 = GroupFixture({
  187. id: '2',
  188. culprit: 'Group 2',
  189. shortId: 'JAVASCRIPT-2',
  190. inbox: {},
  191. });
  192. beforeEach(() => {
  193. MockApiClient.addMockResponse({
  194. url: '/organizations/org-slug/issues/',
  195. body: [group1, group2],
  196. headers: {Link: DEFAULT_LINKS_HEADER},
  197. });
  198. });
  199. it('removes issues after making reviewed (when on for review tab)', async function () {
  200. const updateIssueMock = MockApiClient.addMockResponse({
  201. url: '/organizations/org-slug/issues/',
  202. method: 'PUT',
  203. });
  204. render(<IssueListOverview {...defaultProps} />, {
  205. organization,
  206. disableRouterMocks: true,
  207. initialRouterConfig: {
  208. route: '/organizations/:orgId/issues/',
  209. location: {
  210. pathname: '/organizations/org-slug/issues/',
  211. query: {query: 'is:for_review'},
  212. },
  213. },
  214. });
  215. const groups = await screen.findAllByTestId('group');
  216. await userEvent.click(
  217. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  218. );
  219. expect(screen.getByText('Group 1')).toBeInTheDocument();
  220. expect(screen.getByText('Group 2')).toBeInTheDocument();
  221. // After action, will refetch so need to mock that response
  222. MockApiClient.addMockResponse({
  223. url: '/organizations/org-slug/issues/',
  224. body: [group2],
  225. headers: {Link: DEFAULT_LINKS_HEADER},
  226. });
  227. await userEvent.click(
  228. await screen.findByRole('button', {name: 'More issue actions'})
  229. );
  230. await userEvent.click(screen.getByRole('menuitemradio', {name: 'Mark Reviewed'}));
  231. expect(updateIssueMock).toHaveBeenCalledWith(
  232. '/organizations/org-slug/issues/',
  233. expect.objectContaining({
  234. query: expect.objectContaining({id: ['1']}),
  235. data: {inbox: false},
  236. })
  237. );
  238. expect(screen.queryByText('Group 1')).not.toBeInTheDocument();
  239. expect(screen.getByText('Group 2')).toBeInTheDocument();
  240. });
  241. });
  242. describe('priority', function () {
  243. const medPriorityGroup = GroupFixture({
  244. id: '1',
  245. priority: PriorityLevel.MEDIUM,
  246. culprit: 'Medium priority issue',
  247. });
  248. const highPriorityGroup = GroupFixture({
  249. id: '2',
  250. priority: PriorityLevel.HIGH,
  251. culprit: 'High priority issue',
  252. });
  253. beforeEach(() => {
  254. MockApiClient.addMockResponse({
  255. url: '/organizations/org-slug/issues/',
  256. body: [medPriorityGroup, highPriorityGroup],
  257. headers: {Link: DEFAULT_LINKS_HEADER},
  258. });
  259. });
  260. it('removes issues after bulk reprioritizing (when excluding priorities)', async function () {
  261. const updateIssueMock = MockApiClient.addMockResponse({
  262. url: '/organizations/org-slug/issues/',
  263. method: 'PUT',
  264. });
  265. render(<IssueListOverview {...defaultProps} />, {
  266. organization,
  267. disableRouterMocks: true,
  268. });
  269. const groups = await screen.findAllByTestId('group');
  270. await userEvent.click(
  271. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  272. );
  273. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  274. // After action, will refetch so need to mock that response
  275. MockApiClient.addMockResponse({
  276. url: '/organizations/org-slug/issues/',
  277. body: [highPriorityGroup],
  278. headers: {Link: DEFAULT_LINKS_HEADER},
  279. });
  280. await userEvent.click(await screen.findByRole('button', {name: /set priority/i}));
  281. await userEvent.click(screen.getByRole('menuitemradio', {name: /low/i}));
  282. expect(updateIssueMock).toHaveBeenCalledWith(
  283. '/organizations/org-slug/issues/',
  284. expect.objectContaining({
  285. query: expect.objectContaining({id: ['1']}),
  286. data: {priority: PriorityLevel.LOW},
  287. })
  288. );
  289. expect(screen.queryByText('Medium priority issue')).not.toBeInTheDocument();
  290. });
  291. it('removes issues after reprioritizing single issue (when excluding priorities)', async function () {
  292. MockApiClient.addMockResponse({
  293. url: '/organizations/org-slug/prompts-activity/',
  294. body: {data: {dismissed_ts: null}},
  295. });
  296. const updateIssueMock = MockApiClient.addMockResponse({
  297. url: '/organizations/org-slug/issues/',
  298. method: 'PUT',
  299. });
  300. render(<IssueListOverview {...defaultProps} />, {
  301. organization,
  302. disableRouterMocks: true,
  303. initialRouterConfig: {
  304. route: '/organizations/:orgId/issues/',
  305. location: {
  306. pathname: '/organizations/org-slug/issues/',
  307. query: {query: 'is:unresolved issue.priority:[medium,high]'},
  308. },
  309. },
  310. });
  311. expect(await screen.findByText('Medium priority issue')).toBeInTheDocument();
  312. // After action, will refetch so need to mock that response
  313. MockApiClient.addMockResponse({
  314. url: '/organizations/org-slug/issues/',
  315. body: [highPriorityGroup],
  316. headers: {Link: DEFAULT_LINKS_HEADER},
  317. });
  318. await userEvent.click(screen.getByText('Med'));
  319. await userEvent.click(screen.getByRole('menuitemradio', {name: 'Low'}));
  320. await waitFor(() => {
  321. expect(updateIssueMock).toHaveBeenCalledWith(
  322. '/organizations/org-slug/issues/',
  323. expect.objectContaining({
  324. query: expect.objectContaining({id: ['1']}),
  325. data: {priority: PriorityLevel.LOW},
  326. })
  327. );
  328. });
  329. expect(screen.queryByText('Medium priority issue')).not.toBeInTheDocument();
  330. });
  331. it('does not remove issues after bulk reprioritizing (when query includes all priorities)', async function () {
  332. const updateIssueMock = MockApiClient.addMockResponse({
  333. url: '/organizations/org-slug/issues/',
  334. method: 'PUT',
  335. });
  336. render(<IssueListOverview {...defaultProps} />, {
  337. organization,
  338. disableRouterMocks: true,
  339. initialRouterConfig: {
  340. route: '/organizations/:orgId/issues/',
  341. location: {
  342. pathname: '/organizations/org-slug/issues/',
  343. query: {query: 'is:unresolved issue.priority:[medium,high]'},
  344. },
  345. },
  346. });
  347. const groups = await screen.findAllByTestId('group');
  348. await userEvent.click(
  349. within(groups[0]!).getByRole('checkbox', {name: /select issue/i})
  350. );
  351. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  352. await userEvent.click(await screen.findByRole('button', {name: /set priority/i}));
  353. await userEvent.click(screen.getByRole('menuitemradio', {name: /low/i}));
  354. expect(updateIssueMock).toHaveBeenCalledWith(
  355. '/organizations/org-slug/issues/',
  356. expect.objectContaining({
  357. query: expect.objectContaining({id: ['1']}),
  358. data: {priority: PriorityLevel.LOW},
  359. })
  360. );
  361. expect(screen.getByText('Medium priority issue')).toBeInTheDocument();
  362. });
  363. });
  364. });