12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075 |
- import {DashboardFixture} from 'sentry-fixture/dashboard';
- import {LocationFixture} from 'sentry-fixture/locationFixture';
- import {OrganizationFixture} from 'sentry-fixture/organization';
- import {ProjectFixture} from 'sentry-fixture/project';
- import {ReleaseFixture} from 'sentry-fixture/release';
- import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
- import {TeamFixture} from 'sentry-fixture/team';
- import {UserFixture} from 'sentry-fixture/user';
- import {WidgetFixture} from 'sentry-fixture/widget';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- act,
- render,
- screen,
- userEvent,
- waitFor,
- within,
- } from 'sentry-test/reactTestingLibrary';
- import * as modals from 'sentry/actionCreators/modal';
- import ConfigStore from 'sentry/stores/configStore';
- import PageFiltersStore from 'sentry/stores/pageFiltersStore';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import TeamStore from 'sentry/stores/teamStore';
- import {browserHistory} from 'sentry/utils/browserHistory';
- import CreateDashboard from 'sentry/views/dashboards/create';
- import {handleUpdateDashboardSplit} from 'sentry/views/dashboards/detail';
- import EditAccessSelector from 'sentry/views/dashboards/editAccessSelector';
- import * as types from 'sentry/views/dashboards/types';
- import ViewEditDashboard from 'sentry/views/dashboards/view';
- import {OrganizationContext} from 'sentry/views/organizationContext';
- describe('Dashboards > Detail', function () {
- const organization = OrganizationFixture({
- features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
- });
- const projects = [ProjectFixture()];
- describe('prebuilt dashboards', function () {
- let initialData;
- beforeEach(function () {
- act(() => ProjectsStore.loadInitialData(projects));
- initialData = initializeOrg({organization});
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [ProjectFixture()],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- DashboardFixture([], {id: 'default-overview', title: 'Default'}),
- DashboardFixture([], {id: '1', title: 'Custom Errors'}),
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/default-overview/',
- body: DashboardFixture([], {id: 'default-overview', title: 'Default'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/visit/',
- method: 'POST',
- body: [],
- statusCode: 200,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/sdk-updates/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/prompts-activity/',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/issues/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/stats/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/metrics/meta/',
- body: [],
- });
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- });
- it('assigns unique IDs to all widgets so grid keys are unique', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/default-overview/',
- body: DashboardFixture(
- [
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'Default Widget 1',
- interval: '1d',
- }),
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:transaction',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'Default Widget 2',
- interval: '1d',
- }),
- ],
- {id: 'default-overview', title: 'Default'}
- ),
- });
- initialData = initializeOrg({
- organization: OrganizationFixture({
- features: ['global-views', 'dashboards-basic', 'discover-query'],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: 'default-overview'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- expect(await screen.findByText('Default Widget 1')).toBeInTheDocument();
- expect(screen.getByText('Default Widget 2')).toBeInTheDocument();
- });
- it('opens the widget viewer modal in a prebuilt dashboard using the widget id specified in the url', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- render(
- <CreateDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{templateId: 'default-template', widgetId: '2'}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/2/'}}
- >
- {null}
- </CreateDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- organization: initialData.organization,
- widget: expect.objectContaining({
- displayType: 'line',
- interval: '5m',
- queries: [
- {
- aggregates: ['count()'],
- columns: [],
- conditions: '!event.type:transaction',
- fields: ['count()'],
- name: 'Events',
- orderby: 'count()',
- },
- ],
- title: 'Events',
- widgetType: types.WidgetType.DISCOVER,
- }),
- onClose: expect.anything(),
- })
- );
- });
- });
- });
- describe('custom dashboards', function () {
- let initialData, widgets, mockVisit, mockPut;
- beforeEach(function () {
- window.confirm = jest.fn();
- initialData = initializeOrg({
- organization,
- router: {
- location: LocationFixture(),
- },
- });
- PageFiltersStore.init();
- PageFiltersStore.onInitializeUrlState(
- {
- projects: [],
- environments: [],
- datetime: {start: null, end: null, period: '14d', utc: null},
- },
- new Set()
- );
- widgets = [
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- columns: [],
- aggregates: ['count()'],
- orderby: '-count()',
- },
- ],
- title: 'Errors',
- interval: '1d',
- widgetType: types.WidgetType.DISCOVER,
- id: '1',
- }),
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:transaction',
- fields: ['count()'],
- columns: [],
- aggregates: ['count()'],
- orderby: '-count()',
- },
- ],
- title: 'Transactions',
- interval: '1d',
- widgetType: types.WidgetType.DISCOVER,
- id: '2',
- }),
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:transaction transaction:/api/cats',
- fields: ['p50()'],
- columns: [],
- aggregates: ['p50()'],
- orderby: '-p50()',
- },
- ],
- title: 'p50 of /api/cats',
- interval: '1d',
- id: '3',
- }),
- ];
- mockVisit = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/visit/',
- method: 'POST',
- body: [],
- statusCode: 200,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [ProjectFixture()],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- {
- ...DashboardFixture([], {
- id: 'default-overview',
- title: 'Default',
- }),
- widgetDisplay: ['area'],
- },
- {
- ...DashboardFixture([], {
- id: '1',
- title: 'Custom Errors',
- }),
- widgetDisplay: ['area'],
- },
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {},
- createdBy: UserFixture({id: '1'}),
- }),
- });
- mockPut = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: DashboardFixture(widgets, {id: '1', title: 'Custom Errors'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: {data: []},
- });
- MockApiClient.addMockResponse({
- method: 'POST',
- url: '/organizations/org-slug/dashboards/widgets/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/recent-searches/',
- body: [],
- });
- MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/issues/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/stats/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/sdk-updates/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/prompts-activity/',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/metrics/meta/',
- body: [],
- });
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- });
- it('can remove widgets', async function () {
- const updateMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: DashboardFixture([widgets[0]], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- await waitFor(() => expect(mockVisit).toHaveBeenCalledTimes(1));
- // Enter edit mode.
- await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
- // Remove the second and third widgets
- await userEvent.click(
- (await screen.findAllByRole('button', {name: 'Delete Widget'}))[1]
- );
- await userEvent.click(
- (await screen.findAllByRole('button', {name: 'Delete Widget'}))[1]
- );
- // Save changes
- await userEvent.click(screen.getByRole('button', {name: 'Save and Finish'}));
- expect(updateMock).toHaveBeenCalled();
- expect(updateMock).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- title: 'Custom Errors',
- widgets: [expect.objectContaining(widgets[0])],
- }),
- })
- );
- // Visit should not be called again on dashboard update
- expect(mockVisit).toHaveBeenCalledTimes(1);
- });
- it('appends dashboard-level filters to series request', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {release: ['abc@1.2.0']},
- }),
- });
- const mock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- await waitFor(() =>
- expect(mock).toHaveBeenLastCalledWith(
- '/organizations/org-slug/events-stats/',
- expect.objectContaining({
- query: expect.objectContaining({
- query:
- '(event.type:transaction transaction:/api/cats) release:"abc@1.2.0" ',
- }),
- })
- )
- );
- });
- it('shows add widget option', async function () {
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- // Enter edit mode.
- await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
- expect(await screen.findByRole('button', {name: 'Add widget'})).toBeInTheDocument();
- });
- it('shows add widget option with dataset selector flag', async function () {
- initialData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- 'custom-metrics',
- 'performance-discover-dataset-selector',
- ],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- await userEvent.click(screen.getAllByText('Add Widget')[0]);
- const menuOptions = await screen.findAllByTestId('menu-list-item-label');
- expect(menuOptions.map(e => e.textContent)).toEqual([
- 'Errors',
- 'Transactions',
- 'Issues',
- 'Releases',
- 'Metrics',
- ]);
- });
- it('shows add widget option without dataset selector flag', async function () {
- initialData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- 'custom-metrics',
- ],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- await userEvent.click(screen.getAllByText('Add Widget')[0]);
- const menuOptions = await screen.findAllByTestId('menu-list-item-label');
- expect(menuOptions.map(e => e.textContent)).toEqual([
- 'Errors and Transactions',
- 'Issues',
- 'Releases',
- 'Metrics',
- ]);
- });
- it('shows top level release filter', async function () {
- const mockReleases = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [ReleaseFixture()],
- });
- initialData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- });
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- expect(await screen.findByText('All Releases')).toBeInTheDocument();
- expect(mockReleases).toHaveBeenCalledTimes(2); // Called once when PageFiltersStore is initialized
- });
- it('hides add widget option', async function () {
- // @ts-expect-error this is assigning to readonly property...
- types.MAX_WIDGETS = 1;
- render(
- <OrganizationContext.Provider value={initialData.organization}>
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>
- </OrganizationContext.Provider>,
- {router: initialData.router}
- );
- // Enter edit mode.
- await userEvent.click(await screen.findByRole('button', {name: 'Edit Dashboard'}));
- expect(screen.queryByRole('button', {name: 'Add widget'})).not.toBeInTheDocument();
- });
- it('renders successfully if more widgets than stored layouts', async function () {
- // A case where someone has async added widgets to a dashboard
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(
- [
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
- }),
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'Second Widget',
- interval: '1d',
- id: '2',
- }),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- expect(await screen.findByText('First Widget')).toBeInTheDocument();
- expect(await screen.findByText('Second Widget')).toBeInTheDocument();
- });
- it('does not trigger request if layout not updated', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(
- [
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
- }),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- await userEvent.click(await screen.findByText('Save and Finish'));
- expect(screen.getByText('Edit Dashboard')).toBeInTheDocument();
- expect(mockPut).not.toHaveBeenCalled();
- });
- it('renders the custom resize handler for a widget', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(
- [
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
- }),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- const widget = (await screen.findByText('First Widget')).closest(
- '.react-grid-item'
- ) as HTMLElement;
- const resizeHandle = within(widget).getByTestId('custom-resize-handle');
- expect(resizeHandle).toBeVisible();
- });
- it('does not trigger an alert when the widgets have no layout and user cancels without changes', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(
- [
- WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '-count()',
- },
- ],
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: null,
- }),
- ],
- {id: '1', title: 'Custom Errors'}
- ),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await userEvent.click(await screen.findByText('Edit Dashboard'));
- await userEvent.click(await screen.findByText('Cancel'));
- expect(window.confirm).not.toHaveBeenCalled();
- });
- it('opens the widget viewer modal using the widget id specified in the url', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- const widget = WidgetFixture({
- queries: [
- {
- name: '',
- conditions: 'event.type:error',
- fields: ['count()'],
- aggregates: ['count()'],
- columns: [],
- orderby: '',
- },
- ],
- title: 'First Widget',
- interval: '1d',
- id: '1',
- layout: null,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture([widget], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/123/'}}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- organization: initialData.organization,
- widget,
- onClose: expect.anything(),
- })
- );
- });
- });
- it('redirects user to dashboard url if widget is not found', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 123}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/123/'}}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- expect(await screen.findByText('All Releases')).toBeInTheDocument();
- expect(openWidgetViewerModal).not.toHaveBeenCalled();
- expect(initialData.router.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/1/',
- query: {},
- })
- );
- });
- it('saves a new dashboard with the page filters', async () => {
- const mockPOST = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- method: 'POST',
- body: [],
- });
- render(
- <CreateDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{templateId: undefined}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- query: {
- ...initialData.router.location.query,
- statsPeriod: '7d',
- project: [2],
- environment: ['alpha', 'beta'],
- },
- }}
- >
- {null}
- </CreateDashboard>,
- {
- router: initialData.router,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('Save and Finish'));
- expect(mockPOST).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/',
- expect.objectContaining({
- data: expect.objectContaining({
- projects: [2],
- environment: ['alpha', 'beta'],
- period: '7d',
- }),
- })
- );
- });
- it('saves a template with the page filters', async () => {
- const mockPOST = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- method: 'POST',
- body: [],
- });
- render(
- <CreateDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{templateId: 'default-template'}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- query: {
- ...initialData.router.location.query,
- statsPeriod: '7d',
- project: [2],
- environment: ['alpha', 'beta'],
- },
- }}
- >
- {null}
- </CreateDashboard>,
- {
- router: initialData.router,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('Add Dashboard'));
- expect(mockPOST).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/',
- expect.objectContaining({
- data: expect.objectContaining({
- projects: [2],
- environment: ['alpha', 'beta'],
- period: '7d',
- }),
- })
- );
- });
- it('does not render save and cancel buttons on templates', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- render(
- <CreateDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{templateId: 'default-template'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </CreateDashboard>,
- {
- router: initialData.router,
- organization: initialData.organization,
- }
- );
- await userEvent.click(await screen.findByText('24H'));
- await userEvent.click(screen.getByText('Last 7 days'));
- await screen.findByText('7D');
- expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
- expect(screen.queryByText('Save')).not.toBeInTheDocument();
- });
- it('opens the widget viewer with saved dashboard filters', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
- router={initialData.router}
- location={{...initialData.router.location, pathname: '/widget/1/'}}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- dashboardFilters: {release: ['sentry-android-shop@1.2.0']},
- })
- );
- });
- });
- it('opens the widget viewer with unsaved dashboard filters', async () => {
- const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={initialData.organization}
- params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
- router={initialData.router}
- location={{
- ...initialData.router.location,
- pathname: '/widget/1/',
- query: {release: ['unsaved-release-filter@1.2.0']},
- }}
- >
- {null}
- </ViewEditDashboard>,
- {router: initialData.router, organization: initialData.organization}
- );
- await waitFor(() => {
- expect(openWidgetViewerModal).toHaveBeenCalledWith(
- expect.objectContaining({
- dashboardFilters: {release: ['unsaved-release-filter@1.2.0']},
- })
- );
- });
- });
- it('can save dashboard filters in existing dashboard', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- statsPeriod: '7d',
- release: ['sentry-android-shop@1.2.0'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('Save'));
- expect(mockPut).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- period: '7d',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- })
- );
- });
- it('can clear dashboard filters in compact select', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {release: ['sentry-android-shop@1.2.0']},
- }),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- statsPeriod: '7d',
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await screen.findByText('7D');
- await userEvent.click(await screen.findByText('sentry-android-shop@1.2.0'));
- await userEvent.click(screen.getAllByText('Clear')[0]);
- screen.getByText('All Releases');
- await userEvent.click(document.body);
- await waitFor(() => {
- expect(browserHistory.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- release: '',
- }),
- })
- );
- });
- });
- it('can save absolute time range in existing dashboard', async () => {
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- start: '2022-07-14T07:00:00',
- end: '2022-07-19T23:59:59',
- utc: 'true',
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('Save'));
- expect(mockPut).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- start: '2022-07-14T07:00:00.000',
- end: '2022-07-19T23:59:59.000',
- utc: true,
- }),
- })
- );
- });
- it('can clear dashboard filters in existing dashboard', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- statsPeriod: '7d',
- environment: ['alpha', 'beta'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await screen.findByText('7D');
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
- await userEvent.keyboard('{Escape}');
- await userEvent.click(screen.getByText('Cancel'));
- screen.getByText('All Releases');
- expect(browserHistory.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- project: undefined,
- statsPeriod: undefined,
- environment: undefined,
- }),
- })
- );
- });
- it('disables the Edit Dashboard button when there are unsaved filters', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-basic',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- statsPeriod: '7d',
- environment: ['alpha', 'beta'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- expect(await screen.findByText('Save')).toBeInTheDocument();
- expect(screen.getByText('Cancel')).toBeInTheDocument();
- expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
- });
- it('ignores the order of selection of page filters to render unsaved filters', async () => {
- const testProjects = [
- ProjectFixture({id: '1', name: 'first', environments: ['alpha', 'beta']}),
- ProjectFixture({id: '2', name: 'second', environments: ['alpha', 'beta']}),
- ];
- act(() => ProjectsStore.loadInitialData(testProjects));
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: testProjects,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {},
- environment: ['alpha', 'beta'],
- }),
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- environment: ['beta', 'alpha'], // Reversed order from saved dashboard
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await waitFor(() => expect(screen.queryAllByText('Loading\u2026')).toEqual([]));
- await userEvent.click(screen.getByRole('button', {name: 'All Envs'}));
- expect(screen.getByRole('row', {name: 'alpha'})).toHaveAttribute(
- 'aria-selected',
- 'true'
- );
- expect(screen.getByRole('row', {name: 'beta'})).toHaveAttribute(
- 'aria-selected',
- 'true'
- );
- // Save and Cancel should not appear because alpha, beta is the same as beta, alpha
- expect(screen.queryByText('Save')).not.toBeInTheDocument();
- expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
- });
- it('uses releases from the URL query params', async function () {
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- release: ['not-selected-1'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await screen.findByText(/not-selected-1/);
- screen.getByText('Save');
- screen.getByText('Cancel');
- });
- it('resets release in URL params', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture(widgets, {
- id: '1',
- title: 'Custom Errors',
- filters: {
- release: ['abc'],
- },
- }),
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: {
- ...LocationFixture(),
- query: {
- release: ['not-selected-1'],
- },
- },
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await screen.findByText(/not-selected-1/);
- await userEvent.click(screen.getByText('Cancel'));
- // release isn't used in the redirect
- expect(browserHistory.replace).toHaveBeenCalledWith(
- expect.objectContaining({
- query: {
- end: undefined,
- environment: undefined,
- project: undefined,
- start: undefined,
- statsPeriod: undefined,
- utc: undefined,
- },
- })
- );
- });
- it('reflects selections in the release filter in the query params', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-query',
- ],
- }),
- router: {
- location: LocationFixture(),
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
- await userEvent.click(document.body);
- await waitFor(() => {
- expect(browserHistory.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: expect.objectContaining({
- release: ['sentry-android-shop@1.2.0'],
- }),
- })
- );
- });
- });
- it('persists release selections made during search requests that do not appear in default query', async function () {
- // Default response
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- shortVersion: 'sentry-android-shop@1.2.0',
- version: 'sentry-android-shop@1.2.0',
- }),
- ],
- });
- // Mocked search results
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [
- ReleaseFixture({
- id: '9',
- shortVersion: 'search-result',
- version: 'search-result',
- }),
- ],
- match: [MockApiClient.matchData({query: 's'})],
- });
- const testData = initializeOrg({
- organization: OrganizationFixture({
- features: [
- 'global-views',
- 'dashboards-basic',
- 'dashboards-edit',
- 'discover-basic',
- 'discover-query',
- ],
- }),
- router: {
- location: LocationFixture(),
- },
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={testData.organization}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={testData.router}
- location={testData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {router: testData.router, organization: testData.organization}
- );
- await userEvent.click(await screen.findByText('All Releases'));
- await userEvent.type(screen.getAllByPlaceholderText('Search\u2026')[2], 's');
- await userEvent.click(await screen.findByRole('option', {name: 'search-result'}));
- // Validate that after search is cleared, search result still appears
- expect(await screen.findByText('Latest Release(s)')).toBeInTheDocument();
- expect(screen.getByRole('option', {name: 'search-result'})).toBeInTheDocument();
- });
- it('renders edit access selector', async function () {
- render(
- <EditAccessSelector
- dashboard={DashboardFixture([], {id: '1', title: 'Custom Errors'})}
- onChangeEditAccess={jest.fn()}
- />,
- {
- router: initialData.router,
- organization: {
- features: ['dashboards-edit-access'],
- ...initialData.organization,
- },
- }
- );
- await userEvent.click(await screen.findByText('Edit Access:'));
- expect(screen.getByText('Creator')).toBeInTheDocument();
- expect(screen.getByText('All users')).toBeInTheDocument();
- });
- it('creates and updates new permissions for dashboard with no edit perms initialized', async function () {
- const mockPUT = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
- });
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={{
- ...initialData.organization,
- features: ['dashboards-edit-access', ...initialData.organization.features],
- }}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {
- router: initialData.router,
- organization: {
- features: ['dashboards-edit-access', ...initialData.organization.features],
- },
- }
- );
- await userEvent.click(await screen.findByText('Edit Access:'));
- // deselects 'All users' so only creator has edit access
- expect(await screen.findByText('All users')).toBeEnabled();
- expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
- 'aria-selected',
- 'true'
- );
- await userEvent.click(screen.getByRole('option', {name: 'All users'}));
- expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
- 'aria-selected',
- 'false'
- );
- await userEvent.click(await screen.findByText('Save Changes'));
- await waitFor(() => {
- expect(mockPUT).toHaveBeenCalledTimes(1);
- expect(mockPUT).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- permissions: {isEditableByEveryone: false, teamsWithEditAccess: []},
- }),
- })
- );
- });
- });
- it('creator can update permissions for dashboard', async function () {
- const mockPUT = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture([], {
- id: '1',
- title: 'Custom Errors',
- createdBy: UserFixture({id: '781629'}),
- permissions: {isEditableByEveryone: false},
- }),
- });
- const currentUser = UserFixture({id: '781629'});
- ConfigStore.set('user', currentUser);
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={{
- ...initialData.organization,
- features: ['dashboards-edit-access', ...initialData.organization.features],
- }}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {
- router: initialData.router,
- organization: {
- features: ['dashboards-edit-access', ...initialData.organization.features],
- },
- }
- );
- await userEvent.click(await screen.findByText('Edit Access:'));
- // selects 'All users' so everyone has edit access
- expect(await screen.findByText('All users')).toBeEnabled();
- expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
- 'aria-selected',
- 'false'
- );
- await userEvent.click(screen.getByRole('option', {name: 'All users'}));
- expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
- 'aria-selected',
- 'true'
- );
- await userEvent.click(await screen.findByText('Save Changes'));
- await waitFor(() => {
- expect(mockPUT).toHaveBeenCalledTimes(1);
- expect(mockPUT).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- permissions: {isEditableByEveryone: true, teamsWithEditAccess: []},
- }),
- })
- );
- });
- });
- it('creator can update permissions with teams for dashboard', async function () {
- const mockPUT = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- method: 'PUT',
- body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture([], {
- id: '1',
- title: 'Custom Errors',
- createdBy: UserFixture({id: '781629'}),
- permissions: {isEditableByEveryone: false},
- }),
- });
- const currentUser = UserFixture({id: '781629'});
- ConfigStore.set('user', currentUser);
- const teamData = [
- {
- id: '1',
- slug: 'team1',
- name: 'Team 1',
- },
- {
- id: '2',
- slug: 'team2',
- name: 'Team 2',
- },
- {
- id: '3',
- slug: 'team3',
- name: 'Team 3',
- },
- ];
- const teams = teamData.map(data => TeamFixture(data));
- TeamStore.loadInitialData(teams);
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={{
- ...initialData.organization,
- features: ['dashboards-edit-access', ...initialData.organization.features],
- }}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {
- router: initialData.router,
- organization: {
- features: ['dashboards-edit-access', ...initialData.organization.features],
- },
- }
- );
- await userEvent.click(await screen.findByText('Edit Access:'));
- expect(await screen.findByText('All users')).toBeEnabled();
- expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
- 'aria-selected',
- 'false'
- );
- await userEvent.click(screen.getByRole('option', {name: '#team1'}));
- await userEvent.click(screen.getByRole('option', {name: '#team2'}));
- await userEvent.click(await screen.findByText('Save Changes'));
- await waitFor(() => {
- expect(mockPUT).toHaveBeenCalledTimes(1);
- expect(mockPUT).toHaveBeenCalledWith(
- '/organizations/org-slug/dashboards/1/',
- expect.objectContaining({
- data: expect.objectContaining({
- permissions: {isEditableByEveryone: false, teamsWithEditAccess: [1, 2]},
- }),
- })
- );
- });
- });
- it('disables edit dashboard and add widget button if user cannot edit dashboard', async function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- DashboardFixture([], {
- id: '1',
- title: 'Custom Errors',
- createdBy: UserFixture({id: '238900'}),
- permissions: {isEditableByEveryone: false},
- }),
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: DashboardFixture([], {
- id: '1',
- title: 'Custom Errors',
- createdBy: UserFixture({id: '238900'}),
- permissions: {isEditableByEveryone: false},
- }),
- });
- const currentUser = UserFixture({id: '781629', isSuperuser: false});
- ConfigStore.set('user', currentUser);
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={{
- ...initialData.organization,
- features: ['dashboards-edit-access', ...initialData.organization.features],
- access: ['org:read'],
- }}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {
- router: initialData.router,
- organization: {
- features: ['dashboards-edit-access', ...initialData.organization.features],
- access: ['org:read'],
- },
- }
- );
- await screen.findByText('Edit Access:');
- expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
- expect(screen.getByRole('button', {name: 'Add Widget'})).toBeDisabled();
- });
- it('disables widget edit, duplicate, and delete button when user does not have edit perms', async function () {
- const widget = {
- displayType: types.DisplayType.TABLE,
- interval: '1d',
- queries: [
- {
- name: 'Test Widget',
- fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
- columns: ['project'],
- aggregates: ['count()', 'count_unique(user)', 'epm()'],
- conditions: '',
- orderby: '',
- },
- ],
- title: 'Transactions',
- id: '1',
- widgetType: types.WidgetType.DISCOVER,
- };
- const mockDashboard = DashboardFixture([widget], {
- id: '1',
- title: 'Custom Errors',
- createdBy: UserFixture({id: '238900'}),
- permissions: {isEditableByEveryone: false},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: mockDashboard,
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/1/',
- body: mockDashboard,
- });
- const currentUser = UserFixture({id: '781629'});
- ConfigStore.set('user', currentUser);
- render(
- <ViewEditDashboard
- {...RouteComponentPropsFixture()}
- organization={{
- ...initialData.organization,
- features: ['dashboards-edit-access', ...initialData.organization.features],
- access: ['org:read'],
- }}
- params={{orgId: 'org-slug', dashboardId: '1'}}
- router={initialData.router}
- location={initialData.router.location}
- >
- {null}
- </ViewEditDashboard>,
- {
- router: initialData.router,
- organization: {
- features: ['dashboards-edit-access', ...initialData.organization.features],
- access: ['org:read'],
- },
- }
- );
- await screen.findByText('Edit Access:');
- expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
- expect(screen.getByRole('button', {name: 'Add Widget'})).toBeDisabled();
- await userEvent.click(await screen.findByLabelText('Widget actions'));
- expect(
- screen.getByRole('menuitemradio', {name: 'Duplicate Widget'})
- ).toHaveAttribute('aria-disabled', 'true');
- expect(screen.getByRole('menuitemradio', {name: 'Delete Widget'})).toHaveAttribute(
- 'aria-disabled',
- 'true'
- );
- expect(screen.getByRole('menuitemradio', {name: 'Edit Widget'})).toHaveAttribute(
- 'aria-disabled',
- 'true'
- );
- });
- describe('discover split', function () {
- it('calls the dashboard callbacks with the correct widgetType for discover split', function () {
- const widget = {
- displayType: types.DisplayType.TABLE,
- interval: '1d',
- queries: [
- {
- name: 'Test Widget',
- fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
- columns: ['project'],
- aggregates: ['count()', 'count_unique(user)', 'epm()'],
- conditions: '',
- orderby: '',
- },
- ],
- title: 'Transactions',
- id: '1',
- widgetType: types.WidgetType.DISCOVER,
- };
- const mockDashboard = DashboardFixture([widget], {
- id: '1',
- title: 'Custom Errors',
- });
- const mockModifiedDashboard = DashboardFixture([widget], {
- id: '1',
- title: 'Custom Errors',
- });
- const mockOnDashboardUpdate = jest.fn();
- const mockStateSetter = jest
- .fn()
- .mockImplementation(fn => fn({modifiedDashboard: mockModifiedDashboard}));
- handleUpdateDashboardSplit({
- widgetId: '1',
- splitDecision: types.WidgetType.ERRORS,
- dashboard: mockDashboard,
- modifiedDashboard: mockModifiedDashboard,
- onDashboardUpdate: mockOnDashboardUpdate,
- stateSetter: mockStateSetter,
- });
- expect(mockOnDashboardUpdate).toHaveBeenCalledWith({
- ...mockDashboard,
- widgets: [{...widget, widgetType: types.WidgetType.ERRORS}],
- });
- expect(mockStateSetter).toHaveReturnedWith({
- modifiedDashboard: {
- ...mockModifiedDashboard,
- widgets: [{...widget, widgetType: types.WidgetType.ERRORS}],
- },
- });
- });
- });
- });
- });
|