organizationMembersList.spec.tsx 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603
  1. import {browserHistory} from 'react-router';
  2. import selectEvent from 'react-select-event';
  3. import {AuthProvider} from 'sentry-fixture/authProvider';
  4. import {Member as MemberFixture} from 'sentry-fixture/member';
  5. import {Members as MembersFixture} from 'sentry-fixture/members';
  6. import {Organization} from 'sentry-fixture/organization';
  7. import {RouterContextFixture} from 'sentry-fixture/routerContextFixture';
  8. import {RouterFixture} from 'sentry-fixture/routerFixture';
  9. import {Team} from 'sentry-fixture/team';
  10. import {User} from 'sentry-fixture/user';
  11. import {
  12. render,
  13. renderGlobalModal,
  14. screen,
  15. userEvent,
  16. waitFor,
  17. within,
  18. } from 'sentry-test/reactTestingLibrary';
  19. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  20. import ConfigStore from 'sentry/stores/configStore';
  21. import OrganizationsStore from 'sentry/stores/organizationsStore';
  22. import {OrgRoleFixture} from 'sentry/types/role';
  23. import {trackAnalytics} from 'sentry/utils/analytics';
  24. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  25. jest.mock('sentry/utils/analytics');
  26. jest.mock('sentry/api');
  27. jest.mock('sentry/actionCreators/indicator');
  28. const roles = [
  29. {
  30. id: 'admin',
  31. name: 'Admin',
  32. desc: 'This is the admin role',
  33. allowed: true,
  34. },
  35. {
  36. id: 'member',
  37. name: 'Member',
  38. desc: 'This is the member role',
  39. allowed: true,
  40. },
  41. {
  42. id: 'owner',
  43. name: 'Owner',
  44. desc: 'This is the owner role',
  45. allowed: true,
  46. },
  47. ];
  48. describe('OrganizationMembersList', function () {
  49. const members = MembersFixture();
  50. const ownerTeam = Team({slug: 'owner-team', orgRole: 'owner'});
  51. const member = MemberFixture({
  52. id: '5',
  53. email: 'member@sentry.io',
  54. teams: [ownerTeam.slug],
  55. teamRoles: [
  56. {
  57. teamSlug: ownerTeam.slug,
  58. role: null,
  59. },
  60. ],
  61. flags: {
  62. 'sso:linked': true,
  63. 'idp:provisioned': false,
  64. 'idp:role-restricted': false,
  65. 'member-limit:restricted': false,
  66. 'partnership:restricted': false,
  67. 'sso:invalid': false,
  68. },
  69. groupOrgRoles: [
  70. {
  71. teamSlug: ownerTeam.slug,
  72. role: OrgRoleFixture({id: 'owner'}),
  73. },
  74. ],
  75. });
  76. const currentUser = members[1];
  77. currentUser.user = User({...currentUser, flags: {newsletter_consent_prompt: true}});
  78. const organization = Organization({
  79. access: ['member:admin', 'org:admin', 'member:write'],
  80. status: {
  81. id: 'active',
  82. name: 'active',
  83. },
  84. });
  85. const router = RouterFixture();
  86. const defaultProps = {
  87. organization,
  88. router,
  89. location: router.location,
  90. routes: router.routes,
  91. route: router.routes[0],
  92. params: router.params,
  93. routeParams: router.params,
  94. };
  95. jest.spyOn(ConfigStore, 'get').mockImplementation(() => currentUser.user);
  96. afterAll(function () {
  97. (ConfigStore.get as jest.Mock).mockRestore();
  98. });
  99. beforeEach(function () {
  100. MockApiClient.clearMockResponses();
  101. MockApiClient.addMockResponse({
  102. url: '/organizations/org-slug/members/me/',
  103. method: 'GET',
  104. body: {roles},
  105. });
  106. MockApiClient.addMockResponse({
  107. url: '/organizations/org-slug/members/',
  108. method: 'GET',
  109. body: [...MembersFixture(), member],
  110. });
  111. MockApiClient.addMockResponse({
  112. url: `/organizations/org-slug/members/${member.id}/`,
  113. body: member,
  114. });
  115. MockApiClient.addMockResponse({
  116. url: '/organizations/org-slug/access-requests/',
  117. method: 'GET',
  118. body: [
  119. {
  120. id: 'pending-id',
  121. member: {
  122. id: 'pending-member-id',
  123. email: '',
  124. name: '',
  125. role: '',
  126. roleName: '',
  127. user: {
  128. id: '',
  129. name: 'sentry@test.com',
  130. },
  131. },
  132. team: Team(),
  133. },
  134. ],
  135. });
  136. MockApiClient.addMockResponse({
  137. url: '/organizations/org-slug/auth-provider/',
  138. method: 'GET',
  139. body: {
  140. ...AuthProvider(),
  141. require_link: true,
  142. },
  143. });
  144. MockApiClient.addMockResponse({
  145. url: '/organizations/org-slug/teams/',
  146. method: 'GET',
  147. body: [Team(), ownerTeam],
  148. });
  149. MockApiClient.addMockResponse({
  150. url: '/organizations/org-slug/invite-requests/',
  151. method: 'GET',
  152. body: [],
  153. });
  154. MockApiClient.addMockResponse({
  155. url: '/organizations/org-slug/missing-members/',
  156. method: 'GET',
  157. body: [],
  158. });
  159. MockApiClient.addMockResponse({
  160. url: '/prompts-activity/',
  161. method: 'GET',
  162. body: {
  163. dismissed_ts: undefined,
  164. snoozed_ts: undefined,
  165. },
  166. });
  167. (browserHistory.push as jest.Mock).mockReset();
  168. OrganizationsStore.load([organization]);
  169. });
  170. it('can remove a member', async function () {
  171. const deleteMock = MockApiClient.addMockResponse({
  172. url: `/organizations/org-slug/members/${members[0].id}/`,
  173. method: 'DELETE',
  174. });
  175. render(<OrganizationMembersList {...defaultProps} />, {
  176. context: RouterContextFixture([{organization}]),
  177. });
  178. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  179. renderGlobalModal();
  180. await userEvent.click(screen.getByTestId('confirm-button'));
  181. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  182. expect(deleteMock).toHaveBeenCalled();
  183. expect(browserHistory.push).not.toHaveBeenCalled();
  184. expect(OrganizationsStore.getAll()).toEqual([organization]);
  185. });
  186. it('displays error message when failing to remove member', async function () {
  187. const deleteMock = MockApiClient.addMockResponse({
  188. url: `/organizations/org-slug/members/${members[0].id}/`,
  189. method: 'DELETE',
  190. statusCode: 500,
  191. });
  192. render(<OrganizationMembersList {...defaultProps} />, {
  193. context: RouterContextFixture([{organization}]),
  194. });
  195. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  196. renderGlobalModal();
  197. await userEvent.click(screen.getByTestId('confirm-button'));
  198. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  199. expect(deleteMock).toHaveBeenCalled();
  200. expect(browserHistory.push).not.toHaveBeenCalled();
  201. expect(OrganizationsStore.getAll()).toEqual([organization]);
  202. });
  203. it('can leave org', async function () {
  204. const deleteMock = MockApiClient.addMockResponse({
  205. url: `/organizations/org-slug/members/${members[1].id}/`,
  206. method: 'DELETE',
  207. });
  208. render(<OrganizationMembersList {...defaultProps} />, {
  209. context: RouterContextFixture([{organization}]),
  210. });
  211. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  212. renderGlobalModal();
  213. await userEvent.click(screen.getByTestId('confirm-button'));
  214. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  215. expect(deleteMock).toHaveBeenCalled();
  216. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  217. expect(browserHistory.push).toHaveBeenCalledWith('/organizations/new/');
  218. });
  219. it('can redirect to remaining org after leaving', async function () {
  220. const deleteMock = MockApiClient.addMockResponse({
  221. url: `/organizations/org-slug/members/${members[1].id}/`,
  222. method: 'DELETE',
  223. });
  224. const secondOrg = Organization({
  225. slug: 'org-two',
  226. status: {
  227. id: 'active',
  228. name: 'active',
  229. },
  230. });
  231. OrganizationsStore.addOrReplace(secondOrg);
  232. render(<OrganizationMembersList {...defaultProps} />, {
  233. context: RouterContextFixture([{organization}]),
  234. });
  235. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  236. renderGlobalModal();
  237. await userEvent.click(screen.getByTestId('confirm-button'));
  238. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  239. expect(deleteMock).toHaveBeenCalled();
  240. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  241. expect(browserHistory.push).toHaveBeenCalledWith(
  242. `/organizations/${secondOrg.slug}/issues/`
  243. );
  244. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  245. });
  246. it('displays error message when failing to leave org', async function () {
  247. const deleteMock = MockApiClient.addMockResponse({
  248. url: `/organizations/org-slug/members/${members[1].id}/`,
  249. method: 'DELETE',
  250. statusCode: 500,
  251. });
  252. render(<OrganizationMembersList {...defaultProps} />, {
  253. context: RouterContextFixture([{organization}]),
  254. });
  255. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  256. renderGlobalModal();
  257. await userEvent.click(screen.getByTestId('confirm-button'));
  258. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  259. expect(deleteMock).toHaveBeenCalled();
  260. expect(browserHistory.push).not.toHaveBeenCalled();
  261. expect(OrganizationsStore.getAll()).toEqual([organization]);
  262. });
  263. it('can re-send SSO link to member', async function () {
  264. const inviteMock = MockApiClient.addMockResponse({
  265. url: `/organizations/org-slug/members/${members[0].id}/`,
  266. method: 'PUT',
  267. body: {
  268. id: '1234',
  269. },
  270. });
  271. render(<OrganizationMembersList {...defaultProps} />, {
  272. context: RouterContextFixture([{organization}]),
  273. });
  274. expect(inviteMock).not.toHaveBeenCalled();
  275. await userEvent.click(screen.getByRole('button', {name: 'Resend SSO link'}));
  276. expect(inviteMock).toHaveBeenCalled();
  277. });
  278. it('can re-send invite to member', async function () {
  279. const inviteMock = MockApiClient.addMockResponse({
  280. url: `/organizations/org-slug/members/${members[1].id}/`,
  281. method: 'PUT',
  282. body: {
  283. id: '1234',
  284. },
  285. });
  286. render(<OrganizationMembersList {...defaultProps} />, {
  287. context: RouterContextFixture([{organization}]),
  288. });
  289. expect(inviteMock).not.toHaveBeenCalled();
  290. await userEvent.click(screen.getByRole('button', {name: 'Resend invite'}));
  291. expect(inviteMock).toHaveBeenCalled();
  292. });
  293. it('can search organization members', async function () {
  294. const searchMock = MockApiClient.addMockResponse({
  295. url: '/organizations/org-slug/members/',
  296. body: [],
  297. });
  298. const routerContext = RouterContextFixture();
  299. render(<OrganizationMembersList {...defaultProps} />, {
  300. context: routerContext,
  301. });
  302. await userEvent.type(screen.getByPlaceholderText('Search Members'), 'member');
  303. expect(searchMock).toHaveBeenLastCalledWith(
  304. '/organizations/org-slug/members/',
  305. expect.objectContaining({
  306. method: 'GET',
  307. query: {
  308. query: 'member',
  309. },
  310. })
  311. );
  312. await userEvent.keyboard('{enter}');
  313. expect(routerContext.context.router.push).toHaveBeenCalledTimes(1);
  314. });
  315. it('can filter members', async function () {
  316. const searchMock = MockApiClient.addMockResponse({
  317. url: '/organizations/org-slug/members/',
  318. body: [],
  319. });
  320. const routerContext = RouterContextFixture();
  321. render(<OrganizationMembersList {...defaultProps} />, {
  322. context: routerContext,
  323. });
  324. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  325. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  326. expect(searchMock).toHaveBeenLastCalledWith(
  327. '/organizations/org-slug/members/',
  328. expect.objectContaining({
  329. method: 'GET',
  330. query: {query: 'role:member'},
  331. })
  332. );
  333. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  334. for (const [filter, label] of [
  335. ['isInvited', 'Invited'],
  336. ['has2fa', '2FA'],
  337. ['ssoLinked', 'SSO Linked'],
  338. ]) {
  339. const filterSection = screen.getByRole('listbox', {name: label});
  340. await userEvent.click(
  341. within(filterSection).getByRole('option', {
  342. name: 'True',
  343. })
  344. );
  345. expect(searchMock).toHaveBeenLastCalledWith(
  346. '/organizations/org-slug/members/',
  347. expect.objectContaining({
  348. method: 'GET',
  349. query: {query: `${filter}:true`},
  350. })
  351. );
  352. await userEvent.click(
  353. within(filterSection).getByRole('option', {
  354. name: 'False',
  355. })
  356. );
  357. expect(searchMock).toHaveBeenLastCalledWith(
  358. '/organizations/org-slug/members/',
  359. expect.objectContaining({
  360. method: 'GET',
  361. query: {query: `${filter}:false`},
  362. })
  363. );
  364. await userEvent.click(
  365. within(filterSection).getByRole('option', {
  366. name: 'All',
  367. })
  368. );
  369. }
  370. });
  371. it('can filter members with org roles from team membership', async function () {
  372. const routerContext = RouterContextFixture();
  373. render(<OrganizationMembersList {...defaultProps} />, {
  374. context: routerContext,
  375. });
  376. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  377. await userEvent.click(screen.getByRole('option', {name: 'Owner'}));
  378. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  379. const owners = screen.queryAllByText('Owner');
  380. expect(owners).toHaveLength(3);
  381. });
  382. describe('OrganizationInviteRequests', function () {
  383. const inviteRequest = MemberFixture({
  384. id: '123',
  385. user: null,
  386. inviteStatus: 'requested_to_be_invited',
  387. inviterName: User().name,
  388. role: 'member',
  389. teams: [],
  390. });
  391. const joinRequest = MemberFixture({
  392. id: '456',
  393. user: null,
  394. email: 'test@gmail.com',
  395. inviteStatus: 'requested_to_join',
  396. role: 'member',
  397. teams: [],
  398. });
  399. it('disable buttons for no access', function () {
  400. const org = Organization({
  401. status: {
  402. id: 'active',
  403. name: 'active',
  404. },
  405. });
  406. MockApiClient.addMockResponse({
  407. url: '/organizations/org-slug/invite-requests/',
  408. method: 'GET',
  409. body: [inviteRequest],
  410. });
  411. MockApiClient.addMockResponse({
  412. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  413. method: 'PUT',
  414. });
  415. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  416. context: RouterContextFixture([{organization: org}]),
  417. });
  418. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  419. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  420. });
  421. it('can approve invite request and update', async function () {
  422. const org = Organization({
  423. access: ['member:admin', 'org:admin', 'member:write'],
  424. status: {
  425. id: 'active',
  426. name: 'active',
  427. },
  428. });
  429. MockApiClient.addMockResponse({
  430. url: '/organizations/org-slug/invite-requests/',
  431. method: 'GET',
  432. body: [inviteRequest],
  433. });
  434. MockApiClient.addMockResponse({
  435. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  436. method: 'PUT',
  437. });
  438. render(<OrganizationMembersList {...defaultProps} />, {
  439. context: RouterContextFixture([{organization: org}]),
  440. });
  441. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  442. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  443. renderGlobalModal();
  444. await userEvent.click(screen.getByTestId('confirm-button'));
  445. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  446. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.approved', {
  447. invite_status: inviteRequest.inviteStatus,
  448. member_id: parseInt(inviteRequest.id, 10),
  449. organization: org,
  450. });
  451. });
  452. it('can deny invite request and remove', async function () {
  453. const org = Organization({
  454. access: ['member:admin', 'org:admin', 'member:write'],
  455. status: {
  456. id: 'active',
  457. name: 'active',
  458. },
  459. });
  460. MockApiClient.addMockResponse({
  461. url: '/organizations/org-slug/invite-requests/',
  462. method: 'GET',
  463. body: [joinRequest],
  464. });
  465. MockApiClient.addMockResponse({
  466. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  467. method: 'DELETE',
  468. });
  469. render(<OrganizationMembersList {...defaultProps} />, {
  470. context: RouterContextFixture([{organization: org}]),
  471. });
  472. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  473. await userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  474. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  475. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.denied', {
  476. invite_status: joinRequest.inviteStatus,
  477. member_id: parseInt(joinRequest.id, 10),
  478. organization: org,
  479. });
  480. });
  481. it('can update invite requests', async function () {
  482. const org = Organization({
  483. access: ['member:admin', 'org:admin', 'member:write'],
  484. status: {
  485. id: 'active',
  486. name: 'active',
  487. },
  488. });
  489. MockApiClient.addMockResponse({
  490. url: '/organizations/org-slug/invite-requests/',
  491. method: 'GET',
  492. body: [inviteRequest],
  493. });
  494. const updateWithApprove = MockApiClient.addMockResponse({
  495. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  496. method: 'PUT',
  497. });
  498. render(<OrganizationMembersList {...defaultProps} />, {
  499. context: RouterContextFixture([{organization: org}]),
  500. });
  501. await selectEvent.select(screen.getAllByRole('textbox')[1], ['Admin']);
  502. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  503. renderGlobalModal();
  504. await userEvent.click(screen.getByTestId('confirm-button'));
  505. expect(updateWithApprove).toHaveBeenCalledWith(
  506. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  507. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  508. );
  509. });
  510. });
  511. });