123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490 |
- import {IncidentFixture} from 'sentry-fixture/incident';
- import {LocationFixture} from 'sentry-fixture/locationFixture';
- import {MetricRuleFixture} from 'sentry-fixture/metricRule';
- import {OrganizationFixture} from 'sentry-fixture/organization';
- import {ProjectFixture} from 'sentry-fixture/project';
- import {ProjectAlertRuleFixture} from 'sentry-fixture/projectAlertRule';
- import {TeamFixture} from 'sentry-fixture/team';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- act,
- render,
- renderGlobalModal,
- screen,
- userEvent,
- within,
- } from 'sentry-test/reactTestingLibrary';
- import OrganizationStore from 'sentry/stores/organizationStore';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import TeamStore from 'sentry/stores/teamStore';
- import {IncidentStatus} from 'sentry/views/alerts/types';
- import AlertRulesList from './alertRulesList';
- jest.mock('sentry/utils/analytics');
- describe('AlertRulesList', () => {
- const defaultOrg = OrganizationFixture({
- access: ['alerts:write'],
- });
- TeamStore.loadInitialData([TeamFixture()], false, null);
- let rulesMock!: jest.Mock;
- let projectMock!: jest.Mock;
- const pageLinks =
- '<https://sentry.io/api/0/organizations/org-slug/combined-rules/?cursor=0:0:1>; rel="previous"; results="false"; cursor="0:0:1", ' +
- '<https://sentry.io/api/0/organizations/org-slug/combined-rules/?cursor=0:100:0>; rel="next"; results="true"; cursor="0:100:0"';
- beforeEach(() => {
- rulesMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- ProjectAlertRuleFixture({
- id: '123',
- name: 'First Issue Alert',
- projects: ['earth'],
- createdBy: {name: 'Samwise', id: 1, email: ''},
- }),
- MetricRuleFixture({
- id: '345',
- projects: ['earth'],
- latestIncident: IncidentFixture({
- status: IncidentStatus.CRITICAL,
- }),
- }),
- MetricRuleFixture({
- id: '678',
- projects: ['earth'],
- latestIncident: null,
- }),
- ],
- });
- projectMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- body: [
- ProjectFixture({
- slug: 'earth',
- platform: 'javascript',
- teams: [TeamFixture()],
- }),
- ],
- });
- act(() => OrganizationStore.onUpdate(defaultOrg, {replace: true}));
- act(() => ProjectsStore.loadInitialData([]));
- });
- afterEach(() => {
- act(() => ProjectsStore.reset());
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- });
- it('displays list', async () => {
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- expect(projectMock).toHaveBeenLastCalledWith(
- expect.anything(),
- expect.objectContaining({
- query: expect.objectContaining({query: 'slug:earth'}),
- })
- );
- expect(screen.getAllByTestId('badge-display-name')[0]).toHaveTextContent('earth');
- });
- it('displays empty state', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- body: [],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(
- await screen.findByText('No alert rules found for the current query.')
- ).toBeInTheDocument();
- expect(rulesMock).toHaveBeenCalledTimes(0);
- });
- it('displays team dropdown context if unassigned', async () => {
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- const assignee = (await screen.findAllByTestId('alert-row-assignee'))[0];
- const btn = within(assignee).getAllByRole('button')[0];
- expect(assignee).toBeInTheDocument();
- expect(btn).toBeInTheDocument();
- await userEvent.click(btn, {skipHover: true});
- expect(screen.getByText('#team-slug')).toBeInTheDocument();
- expect(within(assignee).getByText('Unassigned')).toBeInTheDocument();
- });
- it('assigns rule to team from unassigned', async () => {
- const assignMock = MockApiClient.addMockResponse({
- method: 'PUT',
- url: '/projects/org-slug/earth/rules/123/',
- body: [],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- const assignee = (await screen.findAllByTestId('alert-row-assignee'))[0];
- const btn = within(assignee).getAllByRole('button')[0];
- expect(assignee).toBeInTheDocument();
- expect(btn).toBeInTheDocument();
- await userEvent.click(btn, {skipHover: true});
- await userEvent.click(screen.getByText('#team-slug'));
- expect(assignMock).toHaveBeenCalledWith(
- '/projects/org-slug/earth/rules/123/',
- expect.objectContaining({
- data: expect.objectContaining({owner: 'team:1'}),
- })
- );
- });
- it('displays dropdown context menu with actions', async () => {
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- const actions = (await screen.findAllByRole('button', {name: 'Actions'}))[0];
- expect(actions).toBeInTheDocument();
- await userEvent.click(actions);
- expect(screen.getByText('Edit')).toBeInTheDocument();
- expect(screen.getByText('Delete')).toBeInTheDocument();
- expect(screen.getByText('Duplicate')).toBeInTheDocument();
- });
- it('deletes a rule', async () => {
- const {routerContext, organization} = initializeOrg({
- organization: defaultOrg,
- });
- const deletedRuleName = 'First Issue Alert';
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- ProjectAlertRuleFixture({
- id: '123',
- name: deletedRuleName,
- projects: ['earth'],
- createdBy: {name: 'Samwise', id: 1, email: ''},
- }),
- ],
- });
- const deleteMock = MockApiClient.addMockResponse({
- url: `/projects/${organization.slug}/earth/rules/123/`,
- method: 'DELETE',
- body: {},
- });
- render(<AlertRulesList />, {context: routerContext, organization});
- renderGlobalModal();
- const actions = (await screen.findAllByRole('button', {name: 'Actions'}))[0];
- // Add a new response to the mock with no rules
- const emptyListMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [],
- });
- expect(screen.queryByText(deletedRuleName)).toBeInTheDocument();
- await userEvent.click(actions);
- await userEvent.click(screen.getByText('Delete'));
- await userEvent.click(screen.getByRole('button', {name: 'Delete Rule'}));
- expect(deleteMock).toHaveBeenCalledTimes(1);
- expect(emptyListMock).toHaveBeenCalledTimes(1);
- expect(screen.queryByText(deletedRuleName)).not.toBeInTheDocument();
- });
- it('sends user to new alert page on duplicate action', async () => {
- const {routerContext, organization, router} = initializeOrg({
- organization: defaultOrg,
- });
- render(<AlertRulesList />, {context: routerContext, organization});
- const actions = (await screen.findAllByRole('button', {name: 'Actions'}))[0];
- expect(actions).toBeInTheDocument();
- await userEvent.click(actions);
- const duplicate = await screen.findByText('Duplicate');
- expect(duplicate).toBeInTheDocument();
- await userEvent.click(duplicate);
- expect(router.push).toHaveBeenCalledWith({
- pathname: '/organizations/org-slug/alerts/new/issue/',
- query: {
- createFromDuplicate: true,
- duplicateRuleId: '123',
- project: 'earth',
- referrer: 'alert_stream',
- },
- });
- });
- it('sorts by name', async () => {
- const {routerContext, organization} = initializeOrg({
- organization: defaultOrg,
- router: {
- location: LocationFixture({
- query: {asc: '1', sort: 'name'},
- // Sort by the name column
- search: '?asc=1&sort=name`',
- }),
- },
- });
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('Alert Rule')).toHaveAttribute(
- 'aria-sort',
- 'ascending'
- );
- expect(rulesMock).toHaveBeenCalledTimes(1);
- expect(rulesMock).toHaveBeenCalledWith(
- '/organizations/org-slug/combined-rules/',
- expect.objectContaining({
- query: expect.objectContaining({sort: 'name', asc: '1'}),
- })
- );
- });
- it('disables the new alert button for members', async () => {
- const noAccessOrg = {
- ...defaultOrg,
- access: [],
- };
- const {routerContext, organization} = initializeOrg({organization: noAccessOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByLabelText('Create Alert')).toBeDisabled();
- });
- it('searches by name', async () => {
- const {routerContext, organization, router} = initializeOrg();
- render(<AlertRulesList />, {context: routerContext, organization});
- const search = await screen.findByPlaceholderText('Search by name');
- expect(search).toBeInTheDocument();
- const testQuery = 'test name';
- await userEvent.type(search, `${testQuery}{enter}`);
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: {
- name: testQuery,
- },
- })
- );
- });
- it('uses empty team query parameter when removing all teams', async () => {
- const {routerContext, organization, router} = initializeOrg({
- router: {
- location: LocationFixture({
- query: {team: 'myteams'},
- search: '?team=myteams`',
- }),
- },
- });
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- await userEvent.click(await screen.findByRole('button', {name: 'My Teams'}));
- // Uncheck myteams
- const myTeams = await screen.findAllByText('My Teams');
- await userEvent.click(myTeams[1]);
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: {
- team: '',
- },
- })
- );
- });
- it('displays metric alert status', async () => {
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- const rules = await screen.findAllByText('My Incident Rule');
- expect(rules[0]).toBeInTheDocument();
- expect(screen.getByText('Triggered')).toBeInTheDocument();
- expect(screen.getByText('Above 70')).toBeInTheDocument();
- expect(screen.getByText('Below 36')).toBeInTheDocument();
- expect(screen.getAllByTestId('alert-badge')[0]).toBeInTheDocument();
- });
- it('displays issue alert disabled', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- ProjectAlertRuleFixture({
- name: 'First Issue Alert',
- projects: ['earth'],
- status: 'disabled',
- }),
- ],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- expect(screen.getByText('Disabled')).toBeInTheDocument();
- });
- it('displays issue alert disabled instead of muted', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- ProjectAlertRuleFixture({
- name: 'First Issue Alert',
- projects: ['earth'],
- // both disabled and muted
- status: 'disabled',
- snooze: true,
- }),
- ],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- expect(screen.getByText('Disabled')).toBeInTheDocument();
- expect(screen.queryByText('Muted')).not.toBeInTheDocument();
- });
- it('displays issue alert muted', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- ProjectAlertRuleFixture({
- name: 'First Issue Alert',
- projects: ['earth'],
- snooze: true,
- }),
- ],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- expect(screen.getByText('Muted')).toBeInTheDocument();
- });
- it('displays metric alert muted', async () => {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- MetricRuleFixture({
- projects: ['earth'],
- snooze: true,
- }),
- ],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('My Incident Rule')).toBeInTheDocument();
- expect(screen.getByText('Muted')).toBeInTheDocument();
- });
- it('sorts by alert rule', async () => {
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- expect(rulesMock).toHaveBeenCalledWith(
- '/organizations/org-slug/combined-rules/',
- expect.objectContaining({
- query: {
- expand: ['latestIncident', 'lastTriggered'],
- sort: ['incident_status', 'date_triggered'],
- team: ['myteams', 'unassigned'],
- },
- })
- );
- });
- it('preserves empty team query parameter on pagination', async () => {
- const {routerContext, organization, router} = initializeOrg({
- organization: defaultOrg,
- });
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- await userEvent.click(screen.getByLabelText('Next'));
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- query: {
- team: '',
- cursor: '0:100:0',
- },
- })
- );
- });
- it('does not display ACTIVATED Metric Alerts', async () => {
- rulesMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/combined-rules/',
- headers: {Link: pageLinks},
- body: [
- ProjectAlertRuleFixture({
- id: '123',
- name: 'First Issue Alert',
- projects: ['earth'],
- createdBy: {name: 'Samwise', id: 1, email: ''},
- }),
- MetricRuleFixture({
- id: '345',
- projects: ['earth'],
- name: 'Omitted Test Metric Alert',
- monitorType: 1,
- latestIncident: IncidentFixture({
- status: IncidentStatus.CRITICAL,
- }),
- }),
- MetricRuleFixture({
- id: '678',
- name: 'Test Metric Alert 2',
- monitorType: 0,
- projects: ['earth'],
- latestIncident: null,
- }),
- ],
- });
- const {routerContext, organization} = initializeOrg({organization: defaultOrg});
- render(<AlertRulesList />, {context: routerContext, organization});
- expect(await screen.findByText('Test Metric Alert 2')).toBeInTheDocument();
- expect(await screen.findByText('First Issue Alert')).toBeInTheDocument();
- expect(screen.queryByText('Omitted Test Metric Alert')).not.toBeInTheDocument();
- });
- });
|