test_releases.py 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280
  1. from hashlib import sha1
  2. from unittest.mock import patch
  3. from uuid import uuid4
  4. from sentry.buffer import Buffer
  5. from sentry.models import (
  6. Activity,
  7. Commit,
  8. CommitAuthor,
  9. Group,
  10. GroupAssignee,
  11. GroupHistory,
  12. GroupHistoryStatus,
  13. GroupInbox,
  14. GroupInboxReason,
  15. GroupLink,
  16. GroupStatus,
  17. GroupSubscription,
  18. OrganizationMember,
  19. Release,
  20. ReleaseActivity,
  21. ReleaseProject,
  22. Repository,
  23. UserEmail,
  24. UserOption,
  25. add_group_to_inbox,
  26. )
  27. from sentry.signals import buffer_incr_complete
  28. from sentry.testutils import TestCase
  29. from sentry.types.activity import ActivityType
  30. from sentry.types.releaseactivity import ReleaseActivityType
  31. class ResolveGroupResolutionsTest(TestCase):
  32. @patch("sentry.tasks.clear_expired_resolutions.clear_expired_resolutions.delay")
  33. def test_simple(self, mock_delay):
  34. with self.capture_on_commit_callbacks(execute=True):
  35. release = Release.objects.create(
  36. version="a", organization_id=self.project.organization_id
  37. )
  38. release.add_project(self.project)
  39. mock_delay.assert_called_once_with(release_id=release.id)
  40. class ResolvedInCommitTest(TestCase):
  41. def assertResolvedFromCommit(self, group, commit):
  42. assert GroupLink.objects.filter(
  43. group_id=group.id, linked_type=GroupLink.LinkedType.commit, linked_id=commit.id
  44. ).exists()
  45. assert Group.objects.filter(
  46. id=group.id, status=GroupStatus.RESOLVED, resolved_at__isnull=False
  47. ).exists()
  48. assert not GroupInbox.objects.filter(group=group).exists()
  49. assert GroupHistory.objects.filter(
  50. group=group,
  51. status=GroupHistoryStatus.SET_RESOLVED_IN_COMMIT,
  52. ).exists()
  53. def assertNotResolvedFromCommit(self, group, commit):
  54. assert not GroupLink.objects.filter(
  55. group_id=group.id, linked_type=GroupLink.LinkedType.commit, linked_id=commit.id
  56. ).exists()
  57. assert not Group.objects.filter(id=group.id, status=GroupStatus.RESOLVED).exists()
  58. assert GroupInbox.objects.filter(group=group).exists()
  59. # TODO(dcramer): pull out short ID matching and expand regexp tests
  60. def test_simple_no_author(self):
  61. group = self.create_group()
  62. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  63. repo = Repository.objects.create(name="example", organization_id=self.group.organization.id)
  64. commit = Commit.objects.create(
  65. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  66. repository_id=repo.id,
  67. organization_id=group.organization.id,
  68. message=f"Foo Biz\n\nFixes {group.qualified_short_id}",
  69. )
  70. self.assertResolvedFromCommit(group, commit)
  71. def test_updating_commit(self):
  72. group = self.create_group()
  73. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  74. repo = Repository.objects.create(name="example", organization_id=self.group.organization.id)
  75. commit = Commit.objects.create(
  76. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  77. repository_id=repo.id,
  78. organization_id=group.organization.id,
  79. )
  80. self.assertNotResolvedFromCommit(group, commit)
  81. commit.message = f"Foo Biz\n\nFixes {group.qualified_short_id}"
  82. commit.save()
  83. self.assertResolvedFromCommit(group, commit)
  84. def test_updating_commit_with_existing_grouplink(self):
  85. group = self.create_group()
  86. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  87. repo = Repository.objects.create(name="example", organization_id=self.group.organization.id)
  88. commit = Commit.objects.create(
  89. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  90. repository_id=repo.id,
  91. organization_id=group.organization.id,
  92. message=f"Foo Biz\n\nFixes {group.qualified_short_id}",
  93. )
  94. self.assertResolvedFromCommit(group, commit)
  95. commit.message = f"Foo Bar Biz\n\nFixes {group.qualified_short_id}"
  96. commit.save()
  97. self.assertResolvedFromCommit(group, commit)
  98. def test_removes_group_link_when_message_changes(self):
  99. group = self.create_group()
  100. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  101. repo = Repository.objects.create(name="example", organization_id=self.group.organization.id)
  102. commit = Commit.objects.create(
  103. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  104. repository_id=repo.id,
  105. organization_id=group.organization.id,
  106. message=f"Foo Biz\n\nFixes {group.qualified_short_id}",
  107. )
  108. self.assertResolvedFromCommit(group, commit)
  109. commit.message = "no groups here"
  110. commit.save()
  111. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  112. self.assertNotResolvedFromCommit(group, commit)
  113. def test_no_matching_group(self):
  114. repo = Repository.objects.create(name="example", organization_id=self.organization.id)
  115. commit = Commit.objects.create(
  116. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  117. repository_id=repo.id,
  118. organization_id=self.organization.id,
  119. message=f"Foo Biz\n\nFixes {self.project.slug.upper()}-12F",
  120. )
  121. assert not GroupLink.objects.filter(
  122. linked_type=GroupLink.LinkedType.commit, linked_id=commit.id
  123. ).exists()
  124. def test_matching_author_with_assignment(self):
  125. group = self.create_group()
  126. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  127. user = self.create_user(name="Foo Bar", email="foo@example.com", is_active=True)
  128. email = UserEmail.objects.get_primary_email(user=user)
  129. email.is_verified = True
  130. email.save()
  131. repo = Repository.objects.create(name="example", organization_id=self.group.organization.id)
  132. OrganizationMember.objects.create(organization=group.project.organization, user=user)
  133. UserOption.objects.set_value(user=user, key="self_assign_issue", value="1")
  134. commit = Commit.objects.create(
  135. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  136. organization_id=group.organization.id,
  137. repository_id=repo.id,
  138. message=f"Foo Biz\n\nFixes {group.qualified_short_id}",
  139. author=CommitAuthor.objects.create(
  140. organization_id=group.organization.id, name=user.name, email=user.email
  141. ),
  142. )
  143. self.assertResolvedFromCommit(group, commit)
  144. assert GroupAssignee.objects.filter(group=group, user=user).exists()
  145. assert Activity.objects.filter(
  146. project=group.project, group=group, type=ActivityType.ASSIGNED.value, user=user
  147. )[0].data == {
  148. "assignee": str(user.id),
  149. "assigneeEmail": user.email,
  150. "assigneeType": "user",
  151. }
  152. assert GroupSubscription.objects.filter(group=group, user=user).exists()
  153. def test_matching_author_without_assignment(self):
  154. group = self.create_group()
  155. add_group_to_inbox(group, GroupInboxReason.MANUAL)
  156. user = self.create_user(name="Foo Bar", email="foo@example.com", is_active=True)
  157. email = UserEmail.objects.get_primary_email(user=user)
  158. email.is_verified = True
  159. email.save()
  160. repo = Repository.objects.create(name="example", organization_id=self.group.organization.id)
  161. OrganizationMember.objects.create(organization=group.project.organization, user=user)
  162. UserOption.objects.set_value(user=user, key="self_assign_issue", value="0")
  163. commit = Commit.objects.create(
  164. key=sha1(uuid4().hex.encode("utf-8")).hexdigest(),
  165. organization_id=group.organization.id,
  166. repository_id=repo.id,
  167. message=f"Foo Biz\n\nFixes {group.qualified_short_id}",
  168. author=CommitAuthor.objects.create(
  169. organization_id=group.organization.id, name=user.name, email=user.email
  170. ),
  171. )
  172. self.assertResolvedFromCommit(group, commit)
  173. assert not Activity.objects.filter(
  174. project=group.project, group=group, type=ActivityType.ASSIGNED.value, user=user
  175. ).exists()
  176. assert GroupSubscription.objects.filter(group=group, user=user).exists()
  177. class ProjectHasReleasesReceiverTest(TestCase):
  178. def test(self):
  179. buffer = Buffer()
  180. rp = ReleaseProject.objects.get_or_create(release=self.release, project=self.project)[0]
  181. self.project.flags.has_releases = False
  182. self.project.update(flags=self.project.flags)
  183. buffer.process(
  184. ReleaseProject,
  185. {"new_groups": 1},
  186. {"release_id": rp.release_id, "project_id": rp.project_id},
  187. )
  188. self.project.refresh_from_db()
  189. assert self.project.flags.has_releases
  190. def test_deleted_release_project(self):
  191. # Should just not raise an error here if the `ReleaseProject` does not exist
  192. buffer_incr_complete.send_robust(
  193. model=ReleaseProject,
  194. columns={},
  195. filters={"release_id": -1, "project_id": -2},
  196. sender=ReleaseProject,
  197. )
  198. class SaveReleaseActivityReceiverTest(TestCase):
  199. def test_simple(self):
  200. with self.feature("organizations:active-release-monitor-alpha"):
  201. release = self.create_release(self.project, self.user)
  202. activity = list(ReleaseActivity.objects.filter(release_id=release.id))
  203. assert len(activity) == 1
  204. assert activity[0].date_added == release.date_added
  205. assert activity[0].type == ReleaseActivityType.CREATED.value
  206. assert activity[0].release_id == release.id
  207. def test_update_release_should_not_create_activity(self):
  208. with self.feature("organizations:active-release-monitor-alpha"):
  209. assert ReleaseActivity.objects.all().count() == 0
  210. release = self.create_release(self.project, self.user)
  211. assert ReleaseActivity.objects.all().count() == 1
  212. release.update(version="1")
  213. assert Release.objects.get(id=release.id).version == "1"
  214. release.version = "2"
  215. release.save()
  216. assert Release.objects.get(id=release.id).version == "2"
  217. release.version = "3"
  218. release.save()
  219. assert Release.objects.get(id=release.id).version == "3"
  220. assert ReleaseActivity.objects.all().count() == 1
  221. def test_flag_off(self):
  222. self.create_release(self.project, self.user)
  223. assert ReleaseActivity.objects.all().count() == 0